Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/0day-ci/linux/commits/David-Ahern/bpf-Add-MTU-check-to-fib-lookup-helper/20180520-103417
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
c
Sat, May 19, 2018 at 11:43:27PM CEST, marcelo.leit...@gmail.com wrote:
>On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote:
>...
>> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct
>> nlattr *nla,
>> return err;
>> }
>>
>> +static int tcf_action_delete(stru
Tue, Mar 27, 2018 at 05:43:08PM CEST, linus.luess...@c0d3.blue wrote:
>On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote:
>> >> I strongly believe it is a huge mistake to use sysfs for things like
>> >> this. This should be done via generic netlink api.
>> >
>> >This doesn't change the pro
On Tue, May 15, 2018 at 09:48:11PM +0200, Christoph Hellwig wrote:
> +static ssize_t aio_poll(struct aio_kiocb *aiocb, struct iocb *iocb)
> +{
> + struct kioctx *ctx = aiocb->ki_ctx;
> + struct poll_iocb *req = &aiocb->poll;
> + unsigned long flags;
> + __poll_t mask;
> +
> + /*
On Tue, May 15, 2018 at 09:48:09PM +0200, Christoph Hellwig wrote:
> case -EIOCBQUEUED:
> + if (req->ki_filp->f_op->cancel_kiocb) {
> + struct aio_kiocb *iocb =
> + container_of(req, struct aio_kiocb, rw);
> + st
Hi Jiri,
seems like you still haven't answered Linus' question.
On Montag, 7. Mai 2018 08:34:16 CEST Sven Eckelmann wrote:
> On Dienstag, 27. März 2018 17:43:08 CEST Linus Lüssing wrote:
> > On Sat, Oct 29, 2016 at 12:56:28PM +0200, Jiri Pirko wrote:
> > > >> I strongly believe it is a huge mista
From: William Tu
Date: Fri, 18 May 2018 19:22:28 -0700
> Currently ip6gre and ip6erspan share single metadata mode device,
> using 'collect_md_tun'. Thus, when doing:
> ip link add dev ip6gre11 type ip6gretap external
> ip link add dev ip6erspan12 type ip6erspan external
> RTNETLINK answer
Hi Andrea,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
From: Sergei Shtylyov
Date: Fri, 18 May 2018 21:28:29 +0300
> Here's a set of 3 patches against DaveM's 'net-next.git' repo. They
> (gradually)
> add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new
> register bits/values introduced with this chip, and ending with adding
On May 19, 2018 6:42:50 PM PDT, Andrew Lunn wrote:
>On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
>> Provide a means for !OF platforms to supply their DSA platform data
>> configuration using the dsa_platform_data structure.
>
>Hi Florian
>
>It seems a bit odd adding the header
From: Jeff Kirsher
Date: Fri, 18 May 2018 09:59:45 -0700
> Mitch shortens the ethtool link settings API function names to help
> reduce the amount of line wrapping done in the drivers, and also to make
> the ethtool link settings API functions less windows like (i.e. function
> names that are ful
From: Vlad Buslov
Date: Sat, 19 May 2018 13:12:49 +0300
>
> On Sat 19 May 2018 at 02:59, Cong Wang wrote:
>> On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote:
>>> Underlying implementation of action map has changed and doesn't require
>>> disabling bh anymore. Replace all action idr spinlock
Hi Andrea,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on net-next/master]
[also build test WARNING on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day
From: Ying Xue
Date: Fri, 18 May 2018 19:50:55 +0800
> As variable s of struct tipc_subscr type is not initialized
> in tipc_conn_rcv_from_sock() before it is used in tipc_conn_rcv_sub(),
> KMSAN reported the following uninit-value type complaint:
I agree with others that the short read is the b
From: Maxime Chevallier
Date: Fri, 18 May 2018 09:33:39 +0200
> Marvell PPv2 Header Parser sets some bits in the 'result_info' field in
> each lookup iteration, to identify different packet attributes such as
> DSA / VLAN tag, protocol infos, etc. This is used in further
> classification stages i
From: "Banerjee, Debabrata"
Date: Sat, 19 May 2018 22:57:48 +
> It does the same thing the application would do, but with much less
> overhead. The application called close() because it no longer cares
> about new data, but it still expected send() prior to close() to
> actually send.
It's n
Hello, Happy weekend,
Please contact me on my direct email, laminatasu...@gmail.com, i have
something important to discuss with you,
Hope to read from you soonest,
Yours beloved Laminata
Hi Andrea,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
[also build test ERROR on v4.17-rc5 next-20180517]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linu
syzbot has found a reproducer for the following crash on:
HEAD commit:eb38401c779d net: stmmac: Populate missing callbacks in HW..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=16d0820f80
kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8
On Sat, May 19, 2018 at 08:57:19AM -0700, Eric Dumazet wrote:
> SCTP experts, please take a look.
Ugh, same sctp footprint as in the other reports.
>
> > _sctp_make_chunk+0x58/0x280 net/sctp/sm_make_chunk.c:1417
> > sctp_make_control net/sctp/sm_make_chunk.c:1464 [inline]
> > sctp_make_heartbe
On Sat, May 19, 2018 at 03:55:10PM -0700, Florian Fainelli wrote:
> Provide a means for !OF platforms to supply their DSA platform data
> configuration using the dsa_platform_data structure.
Hi Florian
It seems a bit odd adding the header file, but no code. Yes, this will
help simplify the merge
> From: David Miller [mailto:da...@davemloft.net]
> From: Debabrata Banerjee
>
> > When TCP_CLOSE_NORST is set before a close(), offload sinking of
> > unwanted data to the kernel with low resource usage, with a timeout of
> > TCP_LINGER2. The socket will transition to FIN_WAIT1 and then
> > FIN_
Provide a means for !OF platforms to supply their DSA platform data
configuration using the dsa_platform_data structure.
Signed-off-by: Florian Fainelli
---
include/linux/platform_data/b53.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/linux/platform_data/b53.h
b/include/linu
On 05/19/2018 01:31 PM, Andrew Lunn wrote:
> Not all the world uses device tree. Some parts of the world still use
> platform devices and platform data. Add basic support for probing a
> Marvell switch via platform data.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
There is a
On 05/19/2018 01:31 PM, Andrew Lunn wrote:
> Add the size of the EEPROM to the platform data, so it can also be
> instantiated by a platform device.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
--
Florian
On 05/19/2018 01:31 PM, Andrew Lunn wrote:
> An IRQ domain will work without an OF node. It is not possible to
> reference interrupts via a phandle, but C code can still use
> irq_find_mapping() to get an interrupt from the domain.
>
> Signed-off-by: Andrew Lunn
Reviewed-by: Florian Fainelli
On Wed, May 16, 2018 at 12:58:38PM +0300, Vlad Buslov wrote:
>
> On Wed 16 May 2018 at 09:48, Jiri Pirko wrote:
> > Mon, May 14, 2018 at 04:27:15PM CEST, vla...@mellanox.com wrote:
> >>Implement delete function that is required to delete actions without
> >>holding rtnl lock. Use action API functi
On Wed, May 16, 2018 at 03:21:35PM +0200, Jiri Pirko wrote:
...
> int tcf_idr_check_alloc(struct tc_action_net *tn, u32 *index,
> struct tc_action **a, int bind)
Considering we don't have any other variant of it, maybe just
"tcf_idr_alloc()" instead?
On Mon, May 14, 2018 at 05:27:14PM +0300, Vlad Buslov wrote:
> Substitute calls to action insert function with calls to action insert
> unique function that warns if insertion overwrites index in idr.
I know this patch may be gone on V2, but a general comment, please use
the function names themsel
Please use a more meaningful patch summary. This one is too generic.
On Mon, May 14, 2018 at 05:27:11PM +0300, Vlad Buslov wrote:
...
> +int tcf_idr_find_delete(struct tc_action_net *tn, u32 index)
What about naming it tcf_idr_delete_index() instead?
The find operation is always implicit when you
On Mon, May 14, 2018 at 05:27:10PM +0300, Vlad Buslov wrote:
> Return from action init function with reference to action taken,
> even when overwriting existing action.
Isn't this patch necessary before patch 7, to not break things up?
AFAICU after patchset 7 it assumes the action init function is
On Mon, May 14, 2018 at 05:27:07PM +0300, Vlad Buslov wrote:
...
> @@ -1052,6 +1088,36 @@ static int tca_action_flush(struct net *net, struct
> nlattr *nla,
> return err;
> }
>
> +static int tcf_action_delete(struct net *net, struct list_head *actions,
> + struct ne
On Mon, May 14, 2018 at 05:16:41PM +0200, Jiri Pirko wrote:
> Mon, May 14, 2018 at 04:27:05PM CEST, vla...@mellanox.com wrote:
> >Add additional 'unlocked' argument to act API init functions.
> >Argument is true when rtnl lock is not taken and false otherwise.
> >It is required to implement actions
On Mon, May 14, 2018 at 05:27:03PM +0300, Vlad Buslov wrote:
> Change type of action reference counter to refcount_t.
>
> Change type of action bind counter to atomic_t.
> This type is used to allow decrementing bind counter without testing
> for 0 result.
... and in what does not testing for 0 re
Simon has noticed a typo in the comment accompaining the BCULR write --
fix it and move the comment before the write (following the style of
the other comments), while at it...
Reported-by: Simon Horman
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c |3 ++-
1 file
All the verbs in the comments to the 'struct sh_eth_cpu_data' declaration
should be in a 3rd person singular, to match the nouns.
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
Index: n
The correct name of the EESR bit 8 is TRO (transmit retry over), not RTO.
Note that EESIPR bit 8, TROIP remained correct...
Signed-off-by: Sergei Shtylyov
---
drivers/net/ethernet/renesas/sh_eth.c | 10 +-
drivers/net/ethernet/renesas/sh_eth.h |4 ++--
2 files changed, 7 insertio
From: Debabrata Banerjee
Date: Fri, 18 May 2018 15:01:41 -0400
> When TCP_CLOSE_NORST is set before a close(), offload sinking of
> unwanted data to the kernel with low resource usage, with a timeout of
> TCP_LINGER2. The socket will transition to FIN_WAIT1 and then FIN_WAIT2
> where it will ack
Hello!
Here's a set of 3 patches against DaveM's 'net-next.git' repo plus the R8A77980
support patches posted earlier. They fix the comments typos/grammar and another
typo in the EESR bit...
[1/1] sh_eth: fix typo in EESR.TRO bit name
[2/3] sh_eth: fix comment grammar in 'struct sh_eth_cpu_data'
An IRQ domain will work without an OF node. It is not possible to
reference interrupts via a phandle, but C code can still use
irq_find_mapping() to get an interrupt from the domain.
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/mv88e6xxx/global2.c | 3 ---
1 file changed, 3 deletions(-)
diff
There are a few Intel based platforms making use of the mv88exxx.
These don't easily have access to device tree in order to instantiate
the switch driver. These patches allow the use of platform data to
hold the configuration.
Andrew Lunn (3):
net: dsa: mv88e6xxx: Remove OF check for IRQ domain
Add the size of the EEPROM to the platform data, so it can also be
instantiated by a platform device.
Signed-off-by: Andrew Lunn
---
drivers/net/dsa/mv88e6xxx/chip.c| 11 +++
drivers/net/dsa/mv88e6xxx/chip.h| 2 +-
include/linux/platform_data/mv88e6xxx.h | 1 +
3 files
Not all the world uses device tree. Some parts of the world still use
platform devices and platform data. Add basic support for probing a
Marvell switch via platform data.
Signed-off-by: Andrew Lunn
---
MAINTAINERS | 1 +
drivers/net/dsa/mv88e6xxx/chip.c| 56
From: Florian Fainelli
Date: Fri, 18 May 2018 20:34:25 -0700
> On 05/18/2018 12:28 AM, Jiri Pirko wrote:
>> From: Jiri Pirko
>>
>> This patchset resolves 2 issues we have right now:
>> 1) There are many netdevices / ports in the system, for port, pf, vf
>>represenatation but the user has no
On Sat, May 19, 2018 at 4:13 PM, Willem de Bruijn
wrote:
> On Fri, May 18, 2018 at 12:03 AM, Tom Herbert wrote:
>> On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar
>> wrote:
>>> This patch adds support to pick Tx queue based on the Rx queue map
>>> configuration set by the admin through the sysf
On Sat, May 19, 2018 at 03:44:40PM +0800, Xin Long wrote:
> This feature is actually already supported by sk->sk_reuse which can be
> set by SO_REUSEADDR. But it's not working exactly as RFC6458 demands in
> section 8.1.27, like:
>
> - This option only supports one-to-one style SCTP sockets
> -
On Fri, May 18, 2018 at 12:03 AM, Tom Herbert wrote:
> On Tue, May 15, 2018 at 6:26 PM, Amritha Nambiar
> wrote:
>> This patch adds support to pick Tx queue based on the Rx queue map
>> configuration set by the admin through the sysfs attribute
>> for each Tx queue. If the user configuration for
usuarios de webmail
Tenga en cuenta que el 95% de sus correos electrónicos recibidos después de
actualizar el servidor webmail recientemente en nuestra base de datos se han
suspendido. Reciba su mensaje regularmente. Nuestro personal técnico
actualizará su cuenta dentro de los tres días hábiles
From: Jian Shen
Removes the goto and directly returns in case of errors as part of the
cleanup.
Signed-off-by: Jian Shen
Signed-off-by: Peng Li
Signed-off-by: Salil Mehta
---
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 14 ++
1 file changed, 6 insertions(+), 8 delet
This patch fixes the error reported by Intel's kbuild and fixes a
return value in one of the legs, caught during review of the original
patch sent by kbuild.
Fixes: fdb793670a00 ("net: hns3: Add support of .sriov_configure in HNS3
driver")
Signed-off-by: Fengguang Wu
Signed-off-by: Salil Mehta
This patch-set presents miscellaneous bug fixes and cleanups found during
internal review, system testing and cleanup.
Fuyun Liang (1):
net: hns3: Fix for netdev not running problem after calling net_stop
and net_open
Huazhong Tan (1):
net: hns3: Use enums instead of magic number in
h
SCTP experts, please take a look.
On 05/19/2018 08:55 AM, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 73fcb1a370c7 Merge branch 'akpm' (patches from Andrew)
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=1462ec0f8000
From: Xi Wang
This patch fixes the missing initialization of the client list node
in the hnae3_register_client() function.
Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08
SoC")
Signed-off-by: Xi Wang
Signed-off-by: Peng Li
Signed-off-by: Salil Mehta
---
driver
From: Peng Li
During the RX leg driver needs to fetch the ethernet header
length from the RX'ed Buffer Descriptor. Currently, proprietary
version hns3_nic_get_headlen is being used to fetch the header
length which uses l234info present in the Buffer Descriptor
which might not be valid for the fir
From: Yunsheng Lin
When vf module is loading, the cmd queue initialization should
happen before misc interrupt initialization, otherwise the misc
interrupt handle will cause using uninitialized cmd queue problem.
There is also the same issue when vf module is unloading.
This patch fixes it by ad
From: Fuyun Liang
The link status update function is called by timer every second. But
net_stop and net_open may be called with very short intervals. The link
status update function can not detect the link state has changed. It
causes the netdev not running problem.
This patch fixes it by updati
From: Xi Wang
If CONFIG_ARM_SMMU_V3 is enabled, arm64's dma_ops will replace
arm64_swiotlb_dma_ops with iommu_dma_ops. When releasing contiguous
dma memory, the new ops will call the vunmap function which cannot
be run in interrupt context.
Currently, spin_lock_bh is called before vunmap is exec
Hello,
syzbot found the following crash on:
HEAD commit:73fcb1a370c7 Merge branch 'akpm' (patches from Andrew)
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=1462ec0f80
kernel config: https://syzkaller.appspot.com/x/.config?x=f3b4e30da84ec1ed
dashboar
From: Huazhong Tan
This patch does bit of a clean-up by using already defined enums for
certain values in function hclge_is_special_opcode(). Below enums from
have been used as replacements for magic values:
enum hclge_opcode_type{
HCLGE_OPC_STATS_64_BIT = 0x0030,
From: Xi Wang
If the hns3 driver has been built into kernel and then loaded with
the same driver which built as KLM, it may trigger an error like
below:
[ 20.009555] hns3: Hisilicon Ethernet Network Driver for Hip08 Family -
version
[ 20.016789] hns3: Copyright (c) 2017 Huawei Corporation.
syzbot has found a reproducer for the following crash on:
HEAD commit:eb38401c779d net: stmmac: Populate missing callbacks in HW..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=1233a82780
kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8
Forward link to a new proposed patch at:
https://www.mail-archive.com/netdev@vger.kernel.org/msg236629.html
Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which
casues the ring to get corrupted by allowing multiple kernel threads
to claim ownership of the same ring entry. Track ownership in a shadow
ring structure to prevent other kernel threads from reusing the same
entry before it's full
On Sat 19 May 2018 at 02:59, Cong Wang wrote:
> On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote:
>> Underlying implementation of action map has changed and doesn't require
>> disabling bh anymore. Replace all action idr spinlock usage with regular
>> calls that do not disable bh.
>
> Please e
An offer with a potential opportunity for both of us.Do revert and treat this
message as urgent and important.
MS Christine Hodgson.
This commit removed calls to rtl_set_rx_mode(). This is ok for the
standard path if the link is brought up, however it breaks system
resume from suspend. Link comes up but no network traffic.
Meanwhile common code from rtl_hw_start_8169/8101/8168() was moved
to rtl_hw_start(), therefore re-add the
Hello,
syzbot found the following crash on:
HEAD commit:2c71d338bef2 Merge tag 'powerpc-4.17-6' of git://git.kerne..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=12a7bd5780
kernel config: https://syzkaller.appspot.com/x/.config?x=f3b4e30da84ec1ed
da
This feature is actually already supported by sk->sk_reuse which can be
set by SO_REUSEADDR. But it's not working exactly as RFC6458 demands in
section 8.1.27, like:
- This option only supports one-to-one style SCTP sockets
- This socket option must not be used after calling bind()
or sctp
68 matches
Mail list logo
