Hello Sam,
On Fri, Jun 01, 2018 at 09:48:28PM -0400, Sam Patton wrote:
> Hello!
>
> If you do not know what Enhanced IP is, read this post on netdev first:
>
> https://www.spinics.net/lists/netdev/msg327242.html
>
>
> The Enhanced IP project presents:
>
> Enhanced IP v1.4
>
>
Hi David,
The following pull-request contains BPF updates for your *net* tree.
The main changes are:
1) BPF uapi fix in struct bpf_prog_info and struct bpf_map_info in
order to fix offsets on 32 bit archs.
Please consider pulling these changes from:
On Fri, Jun 01, 2018 at 02:54:36PM -0600, Jason Gunthorpe wrote:
> > diff --git a/drivers/infiniband/core/uverbs_std_types_counters.c
> > b/drivers/infiniband/core/uverbs_std_types_counters.c
> > new file mode 100644
> > index ..a5bc50ceee13
> > +++
On Fri, Jun 01, 2018 at 03:11:49PM -0600, Jason Gunthorpe wrote:
> On Thu, May 31, 2018 at 04:43:27PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky
> >
> > Changelog:
> > v2->v3:
> > * Change function mlx5_fc_query signature to hide the details of
> >internal core driver struct
On 05/31/2018 11:44 AM, Toke Høiland-Jørgensen wrote:
> Song Liu writes:
>
>> On Wed, May 30, 2018 at 9:45 AM, Toke Høiland-Jørgensen wrote:
>>> This adds an example program showing how to sample packets from XDP using
>>> the perf event buffer. The example userspace program just prints the
>>>
On 05/31/2018 06:42 AM, Prashant Bhole wrote:
> test_sockmap was originally written only to exercise kernel code
> paths, so there was no strict checking of errors. When the code was
> modified to run as selftests, due to lack of error handling it was not
> able to detect test failures.
>
> In
On Sat, Jun 02, 2018 at 05:21:59AM +0200, Daniel Borkmann wrote:
> In 64 bit, we have a 4 byte hole between ifindex and netns_dev in the
> case of struct bpf_map_info but also struct bpf_prog_info. In net-next
> commit b85fab0e67b ("bpf: Add gpl_compatible flag to struct bpf_prog_info")
> added a
In 64 bit, we have a 4 byte hole between ifindex and netns_dev in the
case of struct bpf_map_info but also struct bpf_prog_info. In net-next
commit b85fab0e67b ("bpf: Add gpl_compatible flag to struct bpf_prog_info")
added a bitfield into it to expose some flags related to programs. Thus,
add an
Hello!
If you do not know what Enhanced IP is, read this post on netdev first:
https://www.spinics.net/lists/netdev/msg327242.html
The Enhanced IP project presents:
Enhanced IP v1.4
The Enhanced IP (EnIP) code has been updated. It now builds with OpenWRT
barrier breaker (for
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
master
head: 21ad1173589ef63a93f94e05c879393e2c27588c
commit: db9d7d36eecc8926f03a8f2e46781887577b3353 [379/381] net: mvpp2: Split
the PPv2 driver to a dedicated directory
config: s390-allmodconfig (attached as .config)
From: Tariq Toukan
Rename it and pass truesize as an extra argument, as it will be used also
in Legacy RQ in a downstream patch.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 16
1 file changed, 8
From: Tariq Toukan
Get the logic of copying the packet header into the SKB linear part
into a generic function. Function does copy length alignment
and dma buffer sync.
It is currently called only within the MPWQE flow.
In a downstream patch, it will be called within the legacy RQ flow
as well.
From: Tariq Toukan
Make name more generic by dropping MPWRQ from it, as it will be
used also in Legacy RQ in a downstream patch.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 2 +-
From: Ilan Tayari
Add handlers for this event to perform graceful teardown of the device.
Signed-off-by: Ilan Tayari
Signed-off-by: Adi Nissim
Signed-off-by: Saeed Mahameed
---
.../ethernet/mellanox/mlx5/core/fpga/core.c | 28 ---
1 file changed, 24 insertions(+), 4
From: Tariq Toukan
Instead of maintaining a local copy of skb->len/data and updating
it upon every copy to the WQE inline part, just calculate it once
when needed, using the ihs.
This obsoletes the function mlx5e_tx_skb_pull_inline.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
From: Tariq Toukan
Replace the common RQ WQ object with two separate ones for the
different RQ types.
This is in preparation for switching to using a cyclic WQ type
in Legacy RQ.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
From: Tariq Toukan
Now that LRO is not supported for Legacy RQ, there is no source of
out-of-order completions in the WQ, and we can use a cyclic one.
This has multiple advantages:
- reduces the WQE size (smaller PCI transactions).
- lower overhead in datapath (no handling of 'next' pointers).
-
From: Tariq Toukan
A call to mlx5e_tx_skb_pull_inline was mistakenly dropped
in the cited patch. Get it back.
Fixes: 043dc78ecf07 ("net/mlx5e: TX, Use actual WQE size for SQ edge fill")
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
From: Eran Ben Elisha
The driver can present all SW stats even when the state not opened.
Fixed get strings, count and stats to support it.
In addition, fix tc2txq to hold a static mapping which doesn't depend on
the amount of open channels, and cannot have the same value on two
different cells
From: Adi Nissim
The representor MTU was hard coded to 1500 bytes.
Allow setting arbitrary MTU values up to the max supported by the FW.
Signed-off-by: Adi Nissim
Reviewed-by: Or Gerlitz
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en.h | 4
From: Tariq Toukan
Prefer the linear SKB configuration of Legacy RQ over the
non-linear one of Striding RQ.
This implies that ConnectX-4 LX now uses legacy RQ by default,
as it does not support the linear configuration of Striding RQ.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
From: Tariq Toukan
Avoid false sharing of cachelines by separating the cachelines of
TX stats that are dertied in xmit flow and in completion flow.
Signed-off-by: Tariq Toukan
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c | 8
From: Tariq Toukan
Enhance the memory scheme of the legacy RQ, such that
only order-0 pages are used.
Whenever possible, prefer using a linear SKB, and build it
wrapping the WQE buffer.
Otherwise (for example, jumbo frames on x86), use non-linear SKB,
with as many frags as needed. In this
From: Tariq Toukan
Current LRO implementation in Legacy RQ uses high-order pages.
In downstream patches of this series we complete the transition
to using only order-0 pages in RX datapath (which was already done
in Striding RQ).
Unlike the more advanced Striding RQ, Legacy RQ does not make
From: Eran Ben Elisha
Now, when all channels stats are saved regardless of the channel's state
{open, closed}, we can safely remove this indication and the stats spin
lock which protects it.
Fixes: 76c3810bade3 ("net/mlx5e: Avoid reset netdev stats on configuration
changes")
Signed-off-by:
From: Florian Westphal
synchronize_rcu() is expensive.
The commit phase currently enforces an unconditional
synchronize_rcu() after incrementing the generation counter.
This is to make sure that a packet always sees a consistent chain, either
nft_do_chain is still using old generation (it will
From: Maor Gottlieb
Increase the aRFS flow table size to 64k so it could contain up to 64k
different streams.
Signed-off-by: Maor Gottlieb
Signed-off-by: Saeed Mahameed
---
drivers/net/ethernet/mellanox/mlx5/core/en_arfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hi dave,
Sorry for the extra 2 patches in this series, but mostly the series
contains small patches and some fixes to previous patches in this
submission window, with one main patch from Tariq to improve legacy
RQ buffer management, for more information please refer to that tag
log below.
Please
From: Tariq Toukan
IPoIB WQE size is larger than a single WQEBB. Must not fetch the WQE,
and surely not memset it, until it is guaranteed that there are enough
WQEBBs available before getting to SQ/frag edge.
Fixes: 043dc78ecf07 ("net/mlx5e: TX, Use actual WQE size for SQ edge fill")
On Fri, 2018-06-01 at 17:13 -0700, sae...@mellanox.com wrote:
> On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> > From: Saeed Mahameed
> > Date: Wed, 30 May 2018 10:59:48 -0700
> >
> > > The following series is for mlx5-next tree [1], it adds the
> > > support
> > > of two
> > > new
On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> From: Saeed Mahameed
> Date: Wed, 30 May 2018 10:59:48 -0700
>
> > The following series is for mlx5-next tree [1], it adds the support
> > of two
> > new device events, from Ilan Tayari:
> >
> > 1. High temperature warnings.
> > 2. FPGA
On Fri, Jun 1, 2018 at 1:26 AM, Eric Dumazet wrote:
> On Fri, Jun 1, 2018 at 4:18 AM Prashant Bhole
> wrote:
>>
>> In rtnl_newlink(), NULL check is performed on m_ops however member of
>> ops is accessed. Fixed by accessing member of m_ops instead of ops.
>>
>> [ 345.432629] BUG: KASAN:
On Fri, Jun 01, 2018 at 11:10:01AM -0700, Ronak Doshi wrote:
>
>
> On Thu, 31 May 2018, Neil Horman wrote:
>
> > On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote:
> > >
> > > On Wed, 30 May 2018, Paolo Abeni wrote:
> > >
> > > > Hi,
> > > >
> > > > On Thu, 2018-05-24 at 21:48
On Thu, May 31, 2018 at 10:07 PM, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
> master
> head: 4b8e6ac41a594ea67ded6af6af5935f03221ea4c
> commit: ccf8dbcd062a930e64741c939ca784d15316aa0c [375/376] rtnetlink: Remove
> VLA usage
>
On 05/24/2018 09:56 PM, Ilias Apalodimas wrote:
> On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote:
>> On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias Apalodimas wrote:
>>> On Thu, May 24, 2018 at 03:12:29PM +0200, Andrew Lunn wrote:
Device tree is supposed to describe the
Hi Ilias,
On 05/24/2018 01:56 AM, Ilias Apalodimas wrote:
> Hello,
>
> This is adding a new mode on the cpsw driver based around switchdev.
> In order to enable this you need to enable CONFIG_NET_SWITCHDEV,
> CONFIG_BRIDGE_VLAN_FILTERING, CONFIG_TI_CPSW_SWITCHDEV
> and add to udev config:
>
>
On Thu, May 31, 2018 at 04:43:27PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> Changelog:
> v2->v3:
> * Change function mlx5_fc_query signature to hide the details of
>internal core driver struct mlx5_fc
> * Add commen to data[] field at struct mlx5_ib_flow_counters_data
>
> diff --git a/drivers/infiniband/core/uverbs_std_types_counters.c
> b/drivers/infiniband/core/uverbs_std_types_counters.c
> new file mode 100644
> index ..a5bc50ceee13
> +++ b/drivers/infiniband/core/uverbs_std_types_counters.c
> @@ -0,0 +1,100 @@
> +/* SPDX-License-Identifier:
On Wed, 30 May 2018 12:11:32 -0700
Nathan Harold wrote:
> Currently, calling 'ip xfrm monitor all' will
> actually invoke the 'all-nsid' command because the
> soft-match for 'all-nsid' occurs before the precise
> match for 'all'. This patch rearranges the checks
> so that the 'all' command,
On Fri, 1 Jun 2018 17:02:18 +0200
Nicolas Dichtel wrote:
> Le 31/05/2018 à 17:51, Nicolas Dichtel a écrit :
> > Le 31/05/2018 à 17:46, Stephen Hemminger a écrit :
> >> On Thu, 31 May 2018 16:28:48 +0200
> > [snip]
> >> This makes sense. All of linkinfo that is present should be displayed.
On Wed, 30 May 2018 08:30:09 -0700
dsah...@kernel.org wrote:
> From: David Ahern
>
> RTA_CACHEINFO can be sent for non-cloned routes. If the attribute is
> present print it. Allows route dumps to print expires times for example
> which can exist on FIB entries.
>
> Signed-off-by: David Ahern
On 06/01/2018 03:46 PM, John Fastabend wrote:
> This fixes a crash where we assign tcp_prot to IPv6 sockets instead
> of tcpv6_prot.
...
> + /* ULPs are currently supported only for TCP sockets in ESTABLISHED
> + * state. Supporting sockets in LISTEN state will require us to
> +
On Tue, 29 May 2018 16:57:07 +0200
Patrick Talbert wrote:
> As mentioned in the ip-address man page, an address label must
> be equal to the device name or prefixed by the device name
> followed by a colon. Currently the only check on this input is
> to see if the device name appears at the
This fixes a crash where we assign tcp_prot to IPv6 sockets instead
of tcpv6_prot.
Previously we overwrote the sk->prot field with tcp_prot even in the
AF_INET6 case. This patch ensures the correct tcp_prot and tcpv6_prot
are used. Further, only allow ESTABLISHED connections to join the
map per
On Fri, Jun 01, 2018 at 01:08:18PM -0400, David Miller wrote:
> From: Leon Romanovsky
> Date: Fri, 1 Jun 2018 19:21:26 +0300
>
> > Of course, it is harmless for both of you to pull, but it looks like
> > extra work which is not needed for you.
>
> Just put net-next or rdma-next in the subject
On 06/01/2018 12:56 AM, John Fastabend wrote:
> On 05/31/2018 06:00 PM, Eric Dumazet wrote:
>> On Thu, May 31, 2018 at 7:32 PM John Fastabend
>> wrote:
>>>
>>>
>>> Hi Wei,
>>>
>>> Thanks for the report and fix. It would be better to fix the
>>> root cause so that IPv6 works as intended.
>>>
>>>
From: Petr Machata
Date: Thu, 31 May 2018 19:51:56 +0200
> This patchset adds more tests to the mirror-to-gretap suite where bridge
> is present in the underlay. Specifically it adds tests for bridge VLAN
> handling, FDB, and bridge port STP status.
>
> In patches #1-#3, the codebase is
On Thu, 31 May 2018, Neil Horman wrote:
> On Thu, May 31, 2018 at 11:02:34AM -0700, Ronak Doshi wrote:
> >
> > On Wed, 30 May 2018, Paolo Abeni wrote:
> >
> > > Hi,
> > >
> > > On Thu, 2018-05-24 at 21:48 +, Guolin Yang wrote:
> > > > Yes, that code is not correct, we should fix that
From: Nicolas Dichtel
Date: Thu, 31 May 2018 10:59:31 +0200
> The first patch restores the possibility to bind an ip4 tunnel to an
> interface whith a large mtu.
> The second patch was spotted after the first fix. I also target it to net
> because it fixes the max mtu value that can be used for
From: Tonghao Zhang
Date: Thu, 31 May 2018 03:14:01 -0700
> Use the % instead of while, and it may simple code and improve
> the calculating. The real_num_tx_queues has been checked when
> allocating and setting it.
>
> Signed-off-by: Tonghao Zhang
The loop is there to avoid the expensive
From: Steffen Klassert
Date: Thu, 31 May 2018 12:23:24 +0200
> 1) Avoid possible overflow of the offset variable
>in _decode_session6(), this fixes an infinite
>lookp there. From Eric Dumazet.
>
> 2) We may use an error pointer in the error path of
>xfrm_bundle_create(). Fix this
From: Leon Romanovsky
Date: Fri, 1 Jun 2018 19:21:26 +0300
> Of course, it is harmless for both of you to pull, but it looks like
> extra work which is not needed for you.
Just put net-next or rdma-next in the subject line(s) and that will
make it very clear what it expected to happen.
On Fri, Jun 01, 2018 at 08:50:16AM -0700, dsah...@kernel.org wrote:
> From: David Ahern
>
> A recent commit changed rtnl_talk_* to return the response message in
> allocated memory so callers need to free it. The change to name_is_vrf
> did not save the device index which is pointing to a struct
On Fri, 2018-06-01 at 11:45 -0400, David Miller wrote:
> From: Doug Ledford
> Date: Fri, 01 Jun 2018 11:08:24 -0400
>
> > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> >> From: Saeed Mahameed
> >> Date: Wed, 30 May 2018 10:59:48 -0700
> >>
> >> > The following series is for
On Fri, 2018-06-01 at 19:21 +0300, Leon Romanovsky wrote:
> On Fri, Jun 01, 2018 at 11:45:58AM -0400, David Miller wrote:
> > From: Doug Ledford
> > Date: Fri, 01 Jun 2018 11:08:24 -0400
> >
> > > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> > > > From: Saeed Mahameed
> > > > Date:
syzbot was able to trick af_packet again [1]
Various commits tried to address the problem in the past,
but failed to take into account V3 header size.
[1]
tpacket_rcv: packet too big, clamped from 72 to 4294967224. macoff=96
BUG: KASAN: use-after-free in prb_run_all_ft_ops
On Fri, Jun 01, 2018 at 11:45:58AM -0400, David Miller wrote:
> From: Doug Ledford
> Date: Fri, 01 Jun 2018 11:08:24 -0400
>
> > On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> >> From: Saeed Mahameed
> >> Date: Wed, 30 May 2018 10:59:48 -0700
> >>
> >> > The following series is for
Hi netdev community,
I am again on bug fixing in 6lowpan branch and thought that my
needed_headroom and needed_tailroom of net_device are available inside
my ndo_start_xmit() callback.
In case of a UDP socket, it was not the case. I send a fix now to use
skb_expand_copy() to make sure this space
From: David Ahern
A recent commit changed rtnl_talk_* to return the response message in
allocated memory so callers need to free it. The change to name_is_vrf
did not save the device index which is pointing to a struct inside the
now allocated and freed memory resulting in garbage getting
From: Doug Ledford
Date: Fri, 01 Jun 2018 11:08:24 -0400
> On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
>> From: Saeed Mahameed
>> Date: Wed, 30 May 2018 10:59:48 -0700
>>
>> > The following series is for mlx5-next tree [1], it adds the support of two
>> > new device events, from
On 5/30/18 11:06 AM, Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> Signed-off-by: Roopa Prabhu
> ---
> ip/iproute.c | 26 +-
> man/man8/ip-route.8.in | 20 +++-
> 2 files changed, 44 insertions(+), 2 deletions(-)
applied to iproute2-next.
Use the right device to determine if redirect should be sent especially
when using vrf. Same as well as when sending the redirect.
Signed-off-by: Stephen Suryaputra
---
net/ipv6/ip6_output.c | 3 ++-
net/ipv6/ndisc.c | 6 ++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git
Without rtnl lock protection it is no longer safe to use pointer to tc
action without holding reference to it. (it can be destroyed concurrently)
Remove unsafe action idr lookup function. Instead of it, implement safe tcf
idr check function that atomically looks up action in idr and increments
Add additional 'rtnl_held' argument to act API init functions. It is
required to implement actions that need to release rtnl lock before loading
kernel module and reacquire if afterwards.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
Changes from
Change type of action reference counter to refcount_t.
Change type of action bind counter to atomic_t.
This type is used to allow decrementing bind counter without testing
for 0 result.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
Act API used linked list to pass set of actions to functions. It is
intrusive data structure that stores list nodes inside action structure
itself, which means it is not safe to modify such list concurrently.
However, action API doesn't use any linked list specific operations on this
set of
Change action API to assume that action init function always takes
reference to action, even when overwriting existing action. This is
necessary because action API continues to use action pointer after init
function is done. At this point action becomes accessible for concurrent
modifications, so
Implement function that atomically checks if action exists and either takes
reference to it, or allocates idr slot for action index to prevent
concurrent allocations of actions with same index. Use EBUSY error pointer
to indicate that idr slot is reserved.
Implement cleanup helper function that
Return from action init function with reference to action taken,
even when overwriting existing action.
Action init API initializes its fourth argument (pointer to pointer to tc
action) to either existing action with same index or newly created action.
In case of existing index(and bind argument
Implement helper delete function that uses new action ops 'delete', instead
of destroying action directly. This is required so act API could delete
actions by index, without holding any references to action that is being
deleted.
Implement function __tcf_action_put() that releases reference to
Implement functions to atomically update and free action cookie
using rcu mechanism.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
include/net/act_api.h | 2 +-
include/net/pkt_cls.h | 1 +
net/sched/act_api.c | 44
Extend action ops with 'delete' function. Each action type to implements
its own delete function that doesn't depend on rtnl lock.
Implement delete function that is required to delete actions without
holding rtnl lock. Use action API function that atomically deletes action
only if it is still in
Currently, all netlink protocol handlers for updating rules, actions and
qdiscs are protected with single global rtnl lock which removes any
possibility for parallelism. This patch set is a first step to remove
rtnl lock dependency from TC rules update path.
Recently, new rtnl registration flag
Implement new action API function that atomically finds and deletes action
from idr by index. Intended to be used by lockless actions that do not rely
on rtnl lock.
Reviewed-by: Marcelo Ricardo Leitner
Signed-off-by: Vlad Buslov
Signed-off-by: Jiri Pirko
---
Changes from V1 to V2:
- Rename
On Fri 01 Jun 2018 at 12:24, Jamal Hadi Salim wrote:
> On 31/05/18 08:38 AM, Vlad Buslov wrote:
>
>> Hi Jamal,
>>
>> On current net-next I still have action with single reference after last
>> step:
>> ~$ sudo $TC -s actions ls action skbedit
>> total acts 1
>>
From: Damien Thébault
Date: Thu, 31 May 2018 07:04:01 +
> This patch adds support for the BCM5389 switch connected through MDIO.
>
> Signed-off-by: Damien Thébault
Applied, thank you.
From: Vlad Buslov
Date: Thu, 31 May 2018 09:52:53 +0300
> tc_ctl_tfilter handles three netlink message types: RTM_NEWTFILTER,
> RTM_DELTFILTER, RTM_GETTFILTER. However, implementation of this function
> involves a lot of branching on specific message type because most of the
> code is
On Thu, 2018-05-31 at 15:36 -0400, David Miller wrote:
> From: Saeed Mahameed
> Date: Wed, 30 May 2018 10:59:48 -0700
>
> > The following series is for mlx5-next tree [1], it adds the support of two
> > new device events, from Ilan Tayari:
> >
> > 1. High temperature warnings.
> > 2. FPGA QP
Le 31/05/2018 à 17:51, Nicolas Dichtel a écrit :
> Le 31/05/2018 à 17:46, Stephen Hemminger a écrit :
>> On Thu, 31 May 2018 16:28:48 +0200
> [snip]
>> This makes sense. All of linkinfo that is present should be displayed.
>>
>> Both netns and ifindex are really unsigned values. Use __u32 and
From: Ursula Braun
smc_setsockopt contains a check for the length specified on the
setsockopt socket call. If checked, it is supposed to return with
EINVAL. But the equivalent check is already contained in the preceding
setsockopt call on the internal TCP socket. That means, the extra
check can
Fri, Jun 01, 2018 at 10:18:49AM CEST, ivec...@redhat.com wrote:
>Since commit 049c58539f5d ("devlink: mnlg: Add support for extended ack")
>devlink requires NETLINK_{CAP,EXT}_ACK. This prevents devlink from
>working with older kernels that don't support these features.
>
>host # ./devlink/devlink
On 06/01/2018 07:05 AM, Tejaswi Tanikella wrote:
> On receiving a IGMPv2/v3 query, based on max_delay set in the header a
> timer is started to send out a response after a random time within
> max_delay. If the system then moves into suspend state, Report is
> delayed until system wakes up.
>
From: Prashant Bhole
Date: Fri, 1 Jun 2018 17:16:58 +0900
> In rtnl_newlink(), NULL check is performed on m_ops however member of
> ops is accessed. Fixed by accessing member of m_ops instead of ops.
>
> [ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110
> [ 345.432629]
On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Currently 10us delay is too low for many tests to succeed. It needs to
> be increased. Also, many corked tests are expected to hit rx timeout
> irrespective of timeout value.
>
> - This patch sets 1000usec timeout value for corked tests because less
On receiving a IGMPv2/v3 query, based on max_delay set in the header a
timer is started to send out a response after a random time within
max_delay. If the system then moves into suspend state, Report is
delayed until system wakes up.
In one reported scenario, on arm64 devices, max_delay was set
On 05/30/2018 09:42 PM, Prashant Bhole wrote:
> Test failures are not identified because exit code of RX/TX threads
> is not checked. Also threads are not returning correct exit code.
>
> - Return exit code from threads depending on test execution status
> - In main thread, check the exit code of
On 05/30/2018 09:13 PM, Prashant Bhole wrote:
>
>
> On 5/31/2018 4:59 AM, John Fastabend wrote:
>> On 05/30/2018 12:29 PM, Alexei Starovoitov wrote:
>>> On Wed, May 30, 2018 at 02:56:09PM +0900, Prashant Bhole wrote:
In order to reduce runtime of tests, recently timout for select() call
On Fri, Jun 01, 2018 at 05:16:58PM +0900, Prashant Bhole wrote:
> In rtnl_newlink(), NULL check is performed on m_ops however member of
> ops is accessed. Fixed by accessing member of m_ops instead of ops.
>
> [ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110
> [ 345.432629]
On 31/05/18 08:38 AM, Vlad Buslov wrote:
Hi Jamal,
On current net-next I still have action with single reference after last
step:
~$ sudo $TC -s actions ls action skbedit
total acts 1
action order 0: skbedit mark 1 pipe
RFC4821 say: The value for this timer MUST NOT be less than
5 minutes and is recommended to be 10 minutes, per RFC 1981.
Signed-off-by: Li RongQing
---
net/ipv4/sysctl_net_ipv4.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/sysctl_net_ipv4.c
On 05/31/2018 09:51 PM, Qing Huang wrote:
>
> It would be great if you could share the test case that triggered the KASAN
> report in your
> environment. Our QA has been running intensive tests using 8KB or 4KB chunk
> size configuration
> for some time, no one has reported memory
On 05/31/2018 06:14 AM, Tonghao Zhang wrote:
> Use the % instead of while, and it may simple code and improve
> the calculating. The real_num_tx_queues has been checked when
> allocating and setting it.
>
> Signed-off-by: Tonghao Zhang
> ---
> net/core/dev.c | 8 +++-
> 1 file changed, 3
While developing this I found it useful to always have the log
output when dealing with bpftool. This is a quick hack to enable
it but we should add a '-v' option shortly.
Then add a set of good and bad loop examples to test with. These
are all very basic at the moment but will get better soon.
Add some simple loop examples. For now I just load these
using bpftool but eventually they should have a loader
simliar to test_verifier except for C snippets.
We want to use C files here instead of BPF because most
users will be using C clang/llvm and want to test how
well this works with the
Allow bounded loops if we can become convinced they will in fact
terminate.
At a high level this is done in steps the first two steps are done
outside of the do_check routine which "runs" the instructions.
1. Use dom tree to find loops.
2. Find loop induction variable in the loop. (I use loop
Add functions to pretty print the CFG and DOM table. We can also
add contrib scripts to print this dot format so tools can visualize
them. I at least found this helpful. Will add scripts in tools/bpf
follow up patch.
For development we are always printing these but should put these
noisy routines
From: Jiong Wang
We don't want to do any further loop bounds analysis for irreducible loop,
so just reject programs containing it.
The current DOM based loop detection can't detect irreducible loop. We'd
use the algorithm given by Eric Stoltz to detect it. The algorithm requires
DOM info.
At the moment any BPF_ADD or BPF_NEG with a pointer type will create
a new pointer and destroy the register range. Then any memory access
after this will fail because it looks like no bounds checking has
been done, even if it was previously done on the other pointer. So
patterns like this fail,
From: Jiong Wang
This patch build call graph during insn scan inside check_subprogs.
Then do recursive and unreachable subprog detection using call graph.
Signed-off-by: Jiong Wang
Signed-off-by: John Fastabend
---
include/linux/bpf_verifier.h |1
kernel/bpf/cfg.c | 133
From: Jiong Wang
During building control flow graph, we need to build basic block nodes
and edge nodes etc. These nodes needs to allocated dynamically as we
don't have pre-scan pass to know how many nodes we need accurately.
It is better to manage their allocation using memory pool which could
1 - 100 of 118 matches
Mail list logo
