Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Andrew Lunn
Hi Grygorii > Don't know howto: > 1) add FDB entry with "blocked" flag - ALE can discard all packets with > SRC/DST > address = blocked MAC > 2) add multicast MAC address with Supervisory Packet flag set. > Such packets will bypass most of checks inside ALE and will be forwarded in > all

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Andrew Lunn
> 1) boot, ping no vlan > > # ip link add name br0 type bridge > # echo 0 > /sys/class/net/br0/bridge/default_pvid > # ip link set dev eth2 master br0 > # ip link set dev eth0 master br0 > # ip link set dev eth1 master br0 > # ifconfig br0 192.168.1.2 > > *Note*: I've had to disable default_pvid

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Andrew Lunn
> *After this patch set*: goal keep things working the same as max as > possible and get rid of TI custom tool. We are happy to keep things the same, if they fit with the switchdev model. Anything in your customer TI tool/model which does not fit the switchdev model you won't be able to keep,

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Andrew Lunn
On Sat, Jun 02, 2018 at 06:28:22PM -0500, Grygorii Strashko wrote: Hi Grygorii I'm just picking out one thing here... there is lots more good stuff here. > Additional headache is PTP: we have on PHC, but both external interfaces P1/P2 > can timestamp packets. This should not be a problem. The

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Grygorii Strashko
Hi All, Sry, for delayed reply. On 05/24/2018 09:08 AM, Ilias Apalodimas wrote: > On Thu, May 24, 2018 at 03:44:54PM +0200, Ivan Vecera wrote: >> On 24.5.2018 14:54, Andrew Lunn wrote: >>> On Thu, May 24, 2018 at 11:48:31AM +0300, Ilias Apalodimas wrote: On Thu, May 24, 2018 at 10:05:28AM

[PATCH net-next] Allow ethtool to change tun link settings

2018-06-02 Thread Chas Williams
Let user space set whatever it would like to advertise for the tun interface. Preserve the existing defaults. Signed-off-by: Chas Williams <3ch...@gmail.com> --- drivers/net/tun.c | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c

Re: [bpf PATCH v2] bpf: sockmap, fix crash when ipv6 sock is added

2018-06-02 Thread John Fastabend
On 06/01/2018 12:58 PM, Eric Dumazet wrote: > > > On 06/01/2018 03:46 PM, John Fastabend wrote: >> This fixes a crash where we assign tcp_prot to IPv6 sockets instead >> of tcpv6_prot. > > ... > >> +/* ULPs are currently supported only for TCP sockets in ESTABLISHED >> + * state.

Re: [PATCH bpf-next v2 10/11] bpf: sync bpf uapi header with tools

2018-06-02 Thread Daniel Borkmann
On 06/02/2018 10:53 PM, Daniel Borkmann wrote: [...] > diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h > index 64ac0f7..3f47f62 100644 > --- a/tools/include/uapi/linux/bpf.h > +++ b/tools/include/uapi/linux/bpf.h > @@ -2008,6 +2008,7 @@ union bpf_attr { > * Return

[PATCH bpf-next v3 11/11] bpf, doc: add missing patchwork url and libbpf to maintainers

2018-06-02 Thread Daniel Borkmann
Add missing bits under tools/lib/bpf/ and also Q: entry in order to make it easier for people to retrieve current patch queue. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS

[PATCH bpf-next v3 10/11] bpf: sync bpf uapi header with tools

2018-06-02 Thread Daniel Borkmann
Pull in recent changes from include/uapi/linux/bpf.h. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- tools/include/uapi/linux/bpf.h | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h

[PATCH bpf-next v3 01/11] bpf: test case for map pointer poison with calls/branches

2018-06-02 Thread Daniel Borkmann
Add several test cases where the same or different map pointers originate from different paths in the program and execute a map lookup or tail call at a common location. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- include/linux/filter.h

[PATCH bpf-next v3 08/11] bpf: fix cbpf parser bug for octal numbers

2018-06-02 Thread Daniel Borkmann
Range is 0-7, not 0-9, otherwise parser silently excludes it from the strtol() rather than throwing an error. Reported-by: Marc Boschma Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- tools/bpf/bpf_exp.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH bpf-next v3 07/11] bpf: make sure to clear unused fields in tunnel/xfrm state fetch

2018-06-02 Thread Daniel Borkmann
Since the remaining bits are not filled in struct bpf_tunnel_key resp. struct bpf_xfrm_state and originate from uninitialized stack space, we should make sure to clear them before handing control back to the program. Also add a padding element to struct bpf_xfrm_state for future use similar as we

[PATCH bpf-next v3 04/11] bpf: show prog and map id in fdinfo

2018-06-02 Thread Daniel Borkmann
Its trivial and straight forward to expose it for scripts that can then use it along with bpftool in order to inspect an individual application's used maps and progs. Right now we dump some basic information in the fdinfo file but with the help of the map/prog id full introspection becomes

[PATCH bpf-next v3 06/11] bpf: add bpf_skb_cgroup_id helper

2018-06-02 Thread Daniel Borkmann
Add a new bpf_skb_cgroup_id() helper that allows to retrieve the cgroup id from the skb's socket. This is useful in particular to enable bpf_get_cgroup_classid()-like behavior for cgroup v1 in cgroup v2 by allowing ID based matching on egress. This can in particular be used in combination with

[PATCH bpf-next v3 09/11] bpf: fix context access in tracing progs on 32 bit archs

2018-06-02 Thread Daniel Borkmann
Wang reported that all the testcases for BPF_PROG_TYPE_PERF_EVENT program type in test_verifier report the following errors on x86_32: 172/p unpriv: spill/fill of different pointers ldx FAIL Unexpected error message! 0: (bf) r6 = r10 1: (07) r6 += -8 2: (15) if r1 == 0x0 goto pc+3

[PATCH bpf-next v3 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-02 Thread Daniel Borkmann
While some of the BPF map lookup helpers provide a ->map_gen_lookup() callback for inlining the map lookup altogether it is not available for every map, so the remaining ones have to call bpf_map_lookup_elem() helper which does a dispatch to map->ops->map_lookup_elem(). In times of retpolines,

[PATCH bpf-next v3 03/11] bpf: fixup error message from gpl helpers on license mismatch

2018-06-02 Thread Daniel Borkmann
Stating 'proprietary program' in the error is just silly since it can also be a different open source license than that which is just not compatible. Reference: https://twitter.com/majek04/status/998531268039102465 Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Jesper

[PATCH bpf-next v3 02/11] bpf: add also cbpf long jump test cases with heavy expansion

2018-06-02 Thread Daniel Borkmann
We have one triggering on eBPF but lets also add a cBPF example to make sure we keep tracking them. Also add anther cBPF test running max number of MSH ops. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- lib/test_bpf.c | 63

[PATCH bpf-next v3 00/11] Misc BPF improvements

2018-06-02 Thread Daniel Borkmann
This set adds various patches I still had in my queue, first two are test cases to provide coverage for the recent two fixes that went to bpf tree, then a small improvement on the error message for gpl helpers. Next, we expose prog and map id into fdinfo in order to allow for inspection of these

[PATCH bpf-next v2 01/11] bpf: test case for map pointer poison with calls/branches

2018-06-02 Thread Daniel Borkmann
Add several test cases where the same or different map pointers originate from different paths in the program and execute a map lookup or tail call at a common location. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- include/linux/filter.h

[PATCH bpf-next v2 06/11] bpf: add bpf_skb_cgroup_id helper

2018-06-02 Thread Daniel Borkmann
Add a new bpf_skb_cgroup_id() helper that allows to retrieve the cgroup id from the skb's socket. This is useful in particular to enable bpf_get_cgroup_classid()-like behavior for cgroup v1 in cgroup v2 by allowing ID based matching on egress. This can in particular be used in combination with

[PATCH bpf-next v2 07/11] bpf: make sure to clear unused fields in tunnel/xfrm state fetch

2018-06-02 Thread Daniel Borkmann
Since the remaining bits are not filled in struct bpf_tunnel_key resp. struct bpf_xfrm_state and originate from uninitialized stack space, we should make sure to clear them before handing control back to the program. Also add a padding element to struct bpf_xfrm_state for future use similar as we

[PATCH bpf-next v2 08/11] bpf: fix cbpf parser bug for octal numbers

2018-06-02 Thread Daniel Borkmann
Range is 0-7, not 0-9, otherwise parser silently excludes it from the strtol() rather than throwing an error. Reported-by: Marc Boschma Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- tools/bpf/bpf_exp.l | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH bpf-next v2 02/11] bpf: add also cbpf long jump test cases with heavy expansion

2018-06-02 Thread Daniel Borkmann
We have one triggering on eBPF but lets also add a cBPF example to make sure we keep tracking them. Also add anther cBPF test running max number of MSH ops. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- lib/test_bpf.c | 63

[PATCH bpf-next v2 10/11] bpf: sync bpf uapi header with tools

2018-06-02 Thread Daniel Borkmann
Pull in recent changes from include/uapi/linux/bpf.h. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- tools/include/uapi/linux/bpf.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h

[PATCH bpf-next v2 05/11] bpf: avoid retpoline for lookup/update/delete calls on maps

2018-06-02 Thread Daniel Borkmann
While some of the BPF map lookup helpers provide a ->map_gen_lookup() callback for inlining the map lookup altogether it is not available for every map, so the remaining ones have to call bpf_map_lookup_elem() helper which does a dispatch to map->ops->map_lookup_elem(). In times of retpolines,

[PATCH bpf-next v2 04/11] bpf: show prog and map id in fdinfo

2018-06-02 Thread Daniel Borkmann
Its trivial and straight forward to expose it for scripts that can then use it along with bpftool in order to inspect an individual application's used maps and progs. Right now we dump some basic information in the fdinfo file but with the help of the map/prog id full introspection becomes

[PATCH bpf-next v2 11/11] bpf, doc: add missing patchwork url and libbpf to maintainers

2018-06-02 Thread Daniel Borkmann
Add missing bits under tools/lib/bpf/ and also Q: entry in order to make it easier for people to retrieve current patch queue. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Song Liu --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS

[PATCH bpf-next v2 00/11] Misc BPF improvements

2018-06-02 Thread Daniel Borkmann
This set adds various patches I still had in my queue, first two are test cases to provide coverage for the recent two fixes that went to bpf tree, then a small improvement on the error message for gpl helpers. Next, we expose prog and map id into fdinfo in order to allow for inspection of these

[PATCH bpf-next v2 03/11] bpf: fixup error message from gpl helpers on license mismatch

2018-06-02 Thread Daniel Borkmann
Stating 'proprietary program' in the error is just silly since it can also be a different open source license than that which is just not compatible. Reference: https://twitter.com/majek04/status/998531268039102465 Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: Jesper

[PATCH bpf-next v2 09/11] bpf: fix context access in tracing progs on 32 bit archs

2018-06-02 Thread Daniel Borkmann
Wang reported that all the testcases for BPF_PROG_TYPE_PERF_EVENT program type in test_verifier report the following errors on x86_32: 172/p unpriv: spill/fill of different pointers ldx FAIL Unexpected error message! 0: (bf) r6 = r10 1: (07) r6 += -8 2: (15) if r1 == 0x0 goto pc+3

[PATCH net-next 2/2] net: phy: remove PM ops from MDIO bus

2018-06-02 Thread Heiner Kallweit
Current implementation of MDIO bus PM ops doesn't actually implement bus-specific PM ops but just calls PM ops defined on a device level what doesn't seem to be fully in line with the core PM model. When looking e.g. at __device_suspend() the PM core looks for PM ops of a device in a specific

[PATCH net-next 1/2] net: phy: add struct device_type representation of a PHY

2018-06-02 Thread Heiner Kallweit
A PHY is a type of MDIO device, so let's model it as struct device_type and place PM ops, attribute groups and release callback on device type level. For this the attribute definitions have to be moved. This change allows us to get rid of the PM ops on a bus level in a second step. Signed-off-by:

[PATCH net-next 0/2] net: phy: improve PM handling of PHY/MDIO

2018-06-02 Thread Heiner Kallweit
Current implementation of MDIO bus PM ops doesn't actually implement bus-specific PM ops but just calls PM ops defined on a device level what doesn't seem to be fully in line with the core PM model. When looking e.g. at __device_suspend() the PM core looks for PM ops of a device in a specific

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-06-02 Thread Heiner Kallweit
On 01.06.2018 02:10, Andrew Lunn wrote: >> Configuring the different WoL options isn't handled by writing to >> the PHY registers but by writing to chip / MAC registers. >> Therefore phy_suspend() isn't able to figure out whether WoL is >> enabled or not. Only the parent has the full picture. > >

Proposal

2018-06-02 Thread Miss Victoria Mehmet
-- Hello I have been trying to contact you. Did you get my business proposal? Best Regards, Miss.Victoria Mehmet

Re: [PATCH bpf-next 1/2] bpf: btf: Check array t->size

2018-06-02 Thread Alexei Starovoitov
On Sat, Jun 02, 2018 at 09:06:50AM -0700, Martin KaFai Lau wrote: > This patch ensures array's t->size is 0. > > The array size is decided by its individual elem's size and the > number of elements. Hence, t->size is not used and > it must be 0. > > A test case is added to test_btf.c > >

[PATCH net-next 1/2] mlxsw: spectrum_switchdev: Postpone respin on object deletion

2018-06-02 Thread Ido Schimmel
From: Petr Machata VLAN deletion notifications are emitted before the relevant change is projected to bridge configuration. Thus, like with VLAN addition, schedule SPAN respin for later. Fixes: c520bc698647 ("mlxsw: Respin SPAN on switchdev events") Signed-off-by: Petr Machata Signed-off-by:

[PATCH net-next 2/2] mlxsw: spectrum_span: Suppress VLAN on BRIDGE_VLAN_INFO_UNTAGGED

2018-06-02 Thread Ido Schimmel
From: Petr Machata When offloading mirroring to gretap or ip6gretap netdevices, an 802.1q bridge is one of the soft devices permissible in the underlay when resolving the packet path. After the packet path is resolved to a particular bridge egress device, flags on packet VLAN determine whether

[PATCH net-next 0/2] mlxsw: Fixes in offloading of mirror-to-gretap

2018-06-02 Thread Ido Schimmel
Petr says: These two patches fix issues in offloading of mirror-to-gretap when bridge is present in the underlay. In patch #1, reconsideration of SPAN configuration is not done right at the point that SWITCHDEV_OBJ_ID_PORT_VLAN deletion notification is distributed, but is postponed, because the

Dear Talented

2018-06-02 Thread Lisa Clement
Dear Talented, I am Talent Scout For BLUE SKY FILM STUDIO, Present Blue sky Studio a Film Corporation Located in the United State, is Soliciting for the Right to use Your Photo/Face and Personality as One of the Semi -Major Role/ Character in our Upcoming ANIMATED Stereoscope 3D Movie-The Story

Re: ANNOUNCE: Enhanced IP v1.4

2018-06-02 Thread Willy Tarreau
On Sat, Jun 02, 2018 at 12:17:12PM -0400, Sam Patton wrote: > As far as application examples, check out this simple netcat-like > program I use for testing: > > https://github.com/EnIP/enhancedip/blob/master/userspace/netcat/netcat.c > > Lines 61-67 show how to connect directly via an EnIP

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Ilias Apalodimas
On Sat, Jun 02, 2018 at 09:10:08AM -0700, Florian Fainelli wrote: > On June 2, 2018 3:34:32 AM MST, Ilias Apalodimas > wrote: > >Hi Florian, > > > >Thanks for taking time to look into this > > > >On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: > >> > >> > >> On 05/24/2018

Re: [PATCH net] packet: fix reserve calculation

2018-06-02 Thread Lennert Buytenhek
On Thu, May 24, 2018 at 06:10:30PM -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > Commit b84bbaf7a6c8 ("packet: in packet_snd start writing at link > layer allocation") ensures that packet_snd always starts writing > the link layer header in reserved headroom allocated for this >

Re: ANNOUNCE: Enhanced IP v1.4

2018-06-02 Thread Sam Patton
Hello Willy, netdev, Thank you for your reply and advice.  I couldn't agree more with you about containers and the exciting prospects there, as well as the ADSL scenario you mention. As far as application examples, check out this simple netcat-like program I use for testing:

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Florian Fainelli
On June 2, 2018 3:34:32 AM MST, Ilias Apalodimas wrote: >Hi Florian, > >Thanks for taking time to look into this > >On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >> >> >> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: >> > On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew

[PATCH bpf-next 2/2] bpf: btf: Ensure t->type == 0 for BTF_KIND_FWD

2018-06-02 Thread Martin KaFai Lau
The t->type in BTF_KIND_FWD is not used. It must be 0. This patch ensures that and also adds a test case in test_btf.c Signed-off-by: Martin KaFai Lau --- kernel/bpf/btf.c | 21 - tools/testing/selftests/bpf/test_btf.c | 22 ++ 2

[PATCH bpf-next 1/2] bpf: btf: Check array t->size

2018-06-02 Thread Martin KaFai Lau
This patch ensures array's t->size is 0. The array size is decided by its individual elem's size and the number of elements. Hence, t->size is not used and it must be 0. A test case is added to test_btf.c Signed-off-by: Martin KaFai Lau --- kernel/bpf/btf.c | 5 +

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-02 Thread Andrew Lunn
On Fri, Jun 01, 2018 at 04:29:08PM -0500, Grygorii Strashko wrote: > Hi Ilias, > Second, Thanks a lot for your great work. I'm still testing it with different > use cases and trying to consolidate my reply for all questions. > > All, thanks for your comments. Hi Grygorii Something i've said

Donation!!!

2018-06-02 Thread Mr Mikhail Fridman
Charitable Donation for you, Respond for further directives. Mr. Mikhail Fridman --- This email has been checked for viruses by Avast antivirus software. https://www.avast.com/antivirus

Re: [PATCH V2 mlx5-next 0/2] Mellanox, mlx5 new device events

2018-06-02 Thread David Miller
From: Saeed Mahameed Date: Sat, 2 Jun 2018 00:17:37 + > On Fri, 2018-06-01 at 17:13 -0700, sae...@mellanox.com wrote: >> Hey Dave, this series was meant to go to mlx5-next tree as stated in >> the cover letter and patches titles "[PATCH V2 mlx5-next 0/2]". >> >> It is ok you applied those

Re: [pull request][net-next 00/17] Mellanox, mlx5e updates 2018-06-01

2018-06-02 Thread David Miller
From: Saeed Mahameed Date: Fri, 1 Jun 2018 17:05:27 -0700 > Sorry for the extra 2 patches in this series, but mostly the series > contains small patches and some fixes to previous patches in this > submission window, with one main patch from Tariq to improve legacy > RQ buffer management, for

Re: pull-request: bpf 2018-06-02

2018-06-02 Thread David Miller
From: Daniel Borkmann Date: Sat, 2 Jun 2018 07:07:22 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) BPF uapi fix in struct bpf_prog_info and struct bpf_map_info in >order to fix offsets on 32 bit archs. > > Please consider

Lucrative Business Proposal

2018-06-02 Thread Adrien Saif
-- Dear Friend, I would like to discuss a very important issue with you. I am writing to find out if this is your valid email. Please, let me know if this email is valid Kind regards Adrien Saif Attorney to Quatif Group of Companies

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-02 Thread Ilias Apalodimas
Hi Florian, Thanks for taking time to look into this On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: > > > On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: > > On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn wrote: > >> On Thu, May 24, 2018 at 04:32:34PM +0300, Ilias

Re: [net-next][PATCH] tcp: probe timer MUST not less than 5 minuter for tcp PMTU

2018-06-02 Thread Eric Dumazet
On 06/01/2018 07:03 AM, Li RongQing wrote: > RFC4821 say: The value for this timer MUST NOT be less than > 5 minutes and is recommended to be 10 minutes, per RFC 1981. > > Signed-off-by: Li RongQing > --- > net/ipv4/sysctl_net_ipv4.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-)

Lucrative Business Proposal

2018-06-02 Thread Adrien Saif
-- Dear Friend, I would like to discuss a very important issue with you. I am writing to find out if this is your valid email. Please, let me know if this email is valid Kind regards Adrien Saif Attorney to Quatif Group of Companies

re

2018-06-02 Thread Ms. Ella Golan
I am Ms.Ella Golan, I am the Executive Vice President Banking Division with FIRST INTERNATIONAL BANK OF ISRAEL LTD (FIBI). I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your