On Mon 04 Jun 2018 at 21:32, David Miller wrote:
> From: Vlad Buslov
> Date: Mon, 4 Jun 2018 18:32:23 +0300
>
>> If requested tcf proto is not found, get and del filter netlink protocol
>> handlers output error message to extack, but do not return actual error
>> code. Add check to return ENOE
On 05/06/2018 00:04, David Miller wrote:
From: Paul Blakey
Date: Sun, 3 Jun 2018 10:06:13 +0300
When destroying the instance, destroy the head rhashtable.
Fixes: 05cd271fd61a ("cls_flower: Support multiple masks per priority")
Reported-by: Vlad Buslov
Reviewed-by: Roi Dayan
Reviewed-by:
On Mon, Jun 04, 2018 at 11:07:19AM -0700, Cong Wang wrote:
> Per discussion with David at netconf 2018, let's clarify
> DaveM's position of handling stable backports in netdev-FAQ.
>
> This is important for people relying on upstream -stable
> releases.
>
> Cc: sta...@vger.kernel.org
> Cc: Greg K
Tue, Jun 05, 2018 at 12:15:01AM CEST, dsah...@kernel.org wrote:
>From: David Ahern
>
>Add extack argument to reload, port_split and port_unsplit operations.
>
>Signed-off-by: David Ahern
Acked-by: Jiri Pirko
Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
>From: David Ahern
>
>Return messages in extack for port split/unsplit errors. e.g.,
>$ devlink port split swp1s1 count 4
>Error: mlxsw_spectrum: Port cannot be split further.
>devlink answers: Invalid argument
>
>$ de
When using a vxlan device as the ingress dev, we count it as a
"no offload dev", so when such a rule comes and err stop is true,
we fail early and don't try the egdev route which can offload it
through the egress device.
Fix that by not calling the block offload if one of the devices
attached to i
On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
> > if (!mlxsw_sp_port->split) {
> > netdev_err(mlxsw_sp_port->dev, "Port wasn't split\n");
> >+NL_SET_ERR_MSG_MOD(extack, "Port was not split");
Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote:
>On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
>> >if (!mlxsw_sp_port->split) {
>> >netdev_err(mlxsw_sp_port->dev, "Port wasn't split\n");
This patch series implements support for Tx queue selection based on
Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue
using sysfs attribute. If the user configuration for Rx queues does
not apply, then the Tx queue selection falls back to XPS using CPUs and
finally to hashi
This patch adds support to pick Tx queue based on the Rx queue(s) map
configuration set by the admin through the sysfs attribute
for each Tx queue. If the user configuration for receive queue(s) map
does not apply, then the Tx queue selection falls back to CPU(s) map
based selection and finally to
Refactor XPS code to support Tx queue selection based on
CPU(s) map or Rx queue(s) map.
Signed-off-by: Amritha Nambiar
---
include/linux/cpumask.h | 11 ++
include/linux/netdevice.h | 73 ++
net/core/dev.c| 228 ++---
net/cor
Signed-off-by: Amritha Nambiar
---
Documentation/ABI/testing/sysfs-class-net-queues | 11
Documentation/networking/scaling.txt | 58 ++
2 files changed, 59 insertions(+), 10 deletions(-)
diff --git a/Documentation/ABI/testing/sysfs-class-net-queues
b/Doc
Use static_key for XPS maps to reduce the cost of extra map checks,
similar to how it is used for RPS and RFS.
Signed-off-by: Amritha Nambiar
---
net/core/dev.c |8
1 file changed, 8 insertions(+)
diff --git a/net/core/dev.c b/net/core/dev.c
index 156acbe..bba755f 100644
--- a/net/
Extend transmit queue sysfs attribute to configure Rx queue(s) map
per Tx queue. By default no receive queues are configured for the
Tx queue.
- /sys/class/net/eth0/queues/tx-*/xps_rxqs
Signed-off-by: Amritha Nambiar
---
net/core/net-sysfs.c | 81 ++
Den tis 5 juni 2018 kl 03:46 skrev Alexander Duyck :
>
> On Mon, Jun 4, 2018 at 4:32 PM, Alexei Starovoitov
> wrote:
> > On Mon, Jun 04, 2018 at 03:02:31PM -0700, Alexander Duyck wrote:
> >> On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote:
> >> > From: Or Gerlitz
> >> > Date: Tue, 5 Jun 2018
On Mon, Jun 04, 2018 at 08:58:22AM -0400, David Miller wrote:
> From: Steffen Klassert
> Date: Mon, 4 Jun 2018 08:09:07 +0200
>
> > This patchset introduces new virtual xfrm interfaces.
> > The design of virtual xfrm interfaces interfaces was
> > discussed at the Linux IPsec workshop 2018. This p
Daniel Borkmann writes:
> On 06/05/2018 12:32 AM, Jakub Kicinski wrote:
>> On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
>>> + if (load_bpf_file(filename)) {
>>
>> Would you mind using libbpf instead of bpf_load.o? I converted some
>> samples in be5bca44aa6b ("samples: bpf
Daniel Borkmann writes:
> On 06/05/2018 12:26 AM, Jakub Kicinski wrote:
>> On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
>>> This adds two new helper functions to trace_helpers that supports polling
>>> multiple perf file descriptors for events. These are used to the XDP
>>> p
On 06/05/2018 11:22 AM, Toke Høiland-Jørgensen wrote:
> Daniel Borkmann writes:
>> On 06/05/2018 12:26 AM, Jakub Kicinski wrote:
>>> On Mon, 04 Jun 2018 18:33:56 +0200, Toke Høiland-Jørgensen wrote:
This adds two new helper functions to trace_helpers that supports polling
multiple perf f
Hi,
2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan
:
> On 2018-02-21 04:38, Daniele Palmas wrote:
>>
>> Hello,
>>
>> in rmnet kernel documentation I read:
>>
>> "This driver can be used to register onto any physical network device in
>> IP mode. Physical transports include USB, HSIC, PC
From: Maciej Żenczykowski
Tested: 'git grep tw_timeout' comes up empty and it builds :-)
Signed-off-by: Maciej Żenczykowski
Cc: Eric Dumazet
---
include/net/inet_timewait_sock.h | 1 -
net/dccp/minisocks.c | 1 -
net/ipv4/tcp_minisocks.c | 1 -
3 files changed, 3 deletions
2018-06-04, 17:25:14 -0400, David Miller wrote:
> From: Sabrina Dubroca
> Date: Mon, 4 Jun 2018 13:55:54 +0200
>
> > commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table")
> > refactored ipmr_new_table, so that it now returns NULL when
> > mr_table_alloc fails. Unfortunately, all ca
On Tue, Jun 05, 2018 at 12:16:58PM +0800, Xin Long wrote:
> syzbot reported a rcu_sched self-detected stall on CPU which is caused
> by too small value set on rto_min with SCTP_RTOINFO sockopt. With this
> value, hb_timer will get stuck there, as in its timer handler it starts
> this timer again wi
Currently kcm holds both the RX mux lock and the socket lock when
updating the sk receive queue, except in some notable cases:
- kcm_rfree holds only the RX mux lock
- kcm_recvmsg holds only the socket lock
has results there are possible races which cause receive queue
corruption, as reported by
Signed-off-by: Toke Høiland-Jørgensen
---
tools/testing/selftests/bpf/trace_helpers.c | 47 ++-
tools/testing/selftests/bpf/trace_helpers.h |4 ++
2 files changed, 49 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/trace_helpers.c
b/tools/tes
This adds an example program showing how to sample packets from XDP using
the perf event buffer. The example userspace program just prints the
ethernet header for every packet sampled.
Signed-off-by: Toke Høiland-Jørgensen
---
samples/bpf/Makefile |4 +
samples/bpf/xdp_sample_p
This patchset removes the net_device operation ndo_xdp_flush() call.
This is a follow merge commit ea9916ea3ed9 ("Merge branch
'ndo_xdp_xmit-cleanup'"). As after commit c1ece6b245bd ("bpf/xdp:
devmap can avoid calling ndo_xdp_flush") no callers of ndo_xdp_flush
are left in bpf-next tree.
---
Jes
Remove the ndo_xdp_flush call implementation i40e_xdp_flush
as no callers of ndo_xdp_flush are left.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/ethernet/intel/i40e/i40e_main.c |1 -
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 19 ---
drivers/net/ethernet/intel/
Remove the ndo_xdp_flush call implementation ixgbe_xdp_flush
as no callers of ndo_xdp_flush are left.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixg
All drivers are cleaned up and no references to ndo_xdp_flush
are left in drivers, it is time to remove the net_device_ops
operation ndo_xdp_flush.
Signed-off-by: Jesper Dangaard Brouer
---
include/linux/netdevice.h |4
1 file changed, 4 deletions(-)
diff --git a/include/linux/netdevic
Remove the ndo_xdp_flush call implementation virtnet_xdp_flush
as no callers of ndo_xdp_flush are left.
Signed-off-by: Jesper Dangaard Brouer
---
drivers/net/virtio_net.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index
Remove the ndo_xdp_flush call implementation tun_xdp_flush
as no callers of ndo_xdp_flush are left.
The tun drivers XDP_TX implementation also used tun_xdp_flush (and
tun_xdp_xmit). This is easily solved by passing the XDP_XMIT_FLUSH
flag to tun_xdp_xmit in tun_xdp_tx.
Signed-off-by: Jesper Dang
In ip receive path, when ip header hasn't been pulled yet, ip_hdr() and
skb->data are pointing to the same byte.
In ip output path, when ip header is just pushed, ip_hdr() and skb->data
are pointing to the same byte.
As ip_hdr() is more expensive than using skb->data, so replace ip_hdr()
with skb
In ipv6 receive path, when ip header hasn't been pulled yet, ip_hdr()
and skb->data are pointing to the same byte.
In ipv6 output path, when ip header is just pushed, ip_hdr() and skb->data
are pointing to the same byte.
As ip_hdr() is more expensive than using skb->data, so replace ip_hdr()
with
On Tue, 2018-06-05 at 08:04 -0400, Yafang Shao wrote:
> In ip receive path, when ip header hasn't been pulled yet, ip_hdr() and
> skb->data are pointing to the same byte.
>
> In ip output path, when ip header is just pushed, ip_hdr() and skb->data
> are pointing to the same byte.
>
> As ip_hdr()
Willy Tarreau writes:
> I agree on these points, but I'd like to figure what can be done to put
> a bit more pressure on ISPs to *always* provide IPv6.
Most ISPs are in it for the money. So what you can do is either to make
it more expensive to provide IPv4-only services or more profitable to
p
On 06/05/2018 01:55 PM, Jesper Dangaard Brouer wrote:
> This patchset removes the net_device operation ndo_xdp_flush() call.
> This is a follow merge commit ea9916ea3ed9 ("Merge branch
> 'ndo_xdp_xmit-cleanup'"). As after commit c1ece6b245bd ("bpf/xdp:
> devmap can avoid calling ndo_xdp_flush") no
On Tue, Jun 05, 2018 at 02:33:03PM +0200, Bjørn Mork wrote:
> > I do have IPv6 at home (a /48, waste of addressing space, I'd be fine
> > with less),
>
> Any reason you would want less? Any reason the ISP should give you
> less?
What I mean is that *if* the availability of /48 networks was an is
On Mon, 4 Jun 2018 14:06:00 +0200
Björn Töpel wrote:
> Here, ndo_xsk_async_xmit is implemented. As a shortcut, the existing
> XDP Tx rings are used for zero-copy. This will result in other devices
> doing XDP_REDIRECT to an AF_XDP enabled queue will have its packets
> dropped.
This behavior is
From: Heiner Kallweit
Date: Sat, 2 Jun 2018 22:33:36 +0200
> Current implementation of MDIO bus PM ops doesn't actually implement
> bus-specific PM ops but just calls PM ops defined on a device level
> what doesn't seem to be fully in line with the core PM model.
>
> When looking e.g. at __devic
On 06/05/2018 03:07 AM, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski
>
> Tested: 'git grep tw_timeout' comes up empty and it builds :-)
>
> Signed-off-by: Maciej Żenczykowski
> Cc: Eric Dumazet
This field became no longer needed when tcp_tw_recycle was removed in linux-4.12
Sign
commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table")
refactored ipmr_new_table, so that it now returns NULL when
mr_table_alloc fails. Unfortunately, all callers of ipmr_new_table
expect an ERR_PTR.
This can result in NULL deref, for example when ipmr_rules_exit calls
ipmr_free_tabl
Currently, raw6_sk(sk)->ip6mr_table is set unconditionally during
ip6_mroute_setsockopt(MRT6_TABLE). A subsequent attempt at the same
setsockopt will fail with -ENOENT, since we haven't actually created
that table.
A similar fix for ipv4 was included in commit 5e1859fbcc3c ("ipv4: ipmr:
various fi
Before using nla_get_u32(), better make sure the attribute
is of the proper size.
Code recently was changed, but bug has been there from beginning
of git.
BUG: KMSAN: uninit-value in rtnetlink_put_metrics+0x553/0x960
net/core/rtnetlink.c:746
CPU: 1 PID: 14139 Comm: syz-executor6 Not tainted 4.17
When libraries are sourced from elsewhere from the tree, such as the
testing/selftests/drivers/net/mlxsw subdirectory, sourcing their own
dependencies directly by name doesn't work. Thus running mirror_gre.sh
from that subdirectory results in the following cascade of errors:
./../../../net/forward
Den tis 5 juni 2018 kl 14:44 skrev Jesper Dangaard Brouer :
>
> On Mon, 4 Jun 2018 14:06:00 +0200
> Björn Töpel wrote:
>
> > Here, ndo_xsk_async_xmit is implemented. As a shortcut, the existing
> > XDP Tx rings are used for zero-copy. This will result in other devices
> > doing XDP_REDIRECT to an
The 'link-netnsid' argument needs a number. Add 'link-netns' when the user
wants to use the iproute2 netns name instead of the nsid.
Example:
ip link add ipip1 link-netns foo type ipip remote 10.16.0.121 local 10.16.0.249
Signed-off-by: Nicolas Dichtel
---
ip/ip_common.h | 2 ++
ip/iplink.c
After these patches, the iproute2 name of netns is displayed instead of
the nsid. It's easier to read/understand.
v1 -> v2:
- open netns socket and init netns map only when needed
ip/ip_common.h | 3 +++
ip/ipaddress.c | 20 +++-
ip/iplink.c| 18 --
ip/ipn
When iproute2 has a name for the nsid, let's display it. It's more
user friendly than a number.
Signed-off-by: Nicolas Dichtel
---
ip/ip_common.h | 1 +
ip/ipaddress.c | 20 +++-
ip/ipnetns.c | 14 ++
3 files changed, 30 insertions(+), 5 deletions(-)
diff --git a/
Petr Machata writes:
> When libraries are sourced from elsewhere from the tree, such as the
> testing/selftests/drivers/net/mlxsw subdirectory, sourcing their own
Sorry, I didn't realize the mirror_bridge.sh is not upstream yet. This
patch is thus immaterial, it will be sent together with the te
From: Guillaume Nault
Date: Mon, 4 Jun 2018 18:52:19 +0200
> Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session
> object destroy") tried to fix a race condition where a PPPoL2TP socket
> would disappear while the L2TP session was still using it. However, it
> missed the root is
From: Cong Wang
Date: Mon, 4 Jun 2018 11:07:19 -0700
> +Q: Are all networking bug fixes backported to all stable releases?
> +
> +A: Due to capacity, Dave could only take care of the backports for the last
> + 3 stable releases.
As Greg stated, I only do 2 not 3.
From: Kun Yi
Date: Mon, 4 Jun 2018 13:17:04 -0700
> BCM54612E have 4 multi-functional LED pins that can be configured
> through register setting; the LED4 pin can be configured to a 125MHz
> reference clock output by setting the spare register. Since the dedicated
> CLK125 reference clock pin is
From: dsah...@kernel.org
Date: Mon, 4 Jun 2018 13:41:42 -0700
> From: David Ahern
>
> syzbot reported a use-after-free:
...
> The problem is that rt_last can point to a deleted route if the insert
> fails.
>
> One reproducer is to insert a route and then add a multipath route that
> has a dup
From: Yousuk Seung
Date: Mon, 4 Jun 2018 15:29:51 -0700
> Refactor tcp_ecn_check_ce and __tcp_ecn_check_ce to accept struct sock*
> instead of tcp_sock* to clean up type casts. This is a pure refactor
> patch.
>
> Signed-off-by: Yousuk Seung
> Signed-off-by: Neal Cardwell
> Signed-off-by: Yuc
On 06/05/2018 10:44 AM, Björn Töpel wrote:
> Den tis 5 juni 2018 kl 03:46 skrev Alexander Duyck
> :
>> On Mon, Jun 4, 2018 at 4:32 PM, Alexei Starovoitov
>> wrote:
>>> On Mon, Jun 04, 2018 at 03:02:31PM -0700, Alexander Duyck wrote:
On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote:
>
Hi Toke,
On 06/05/2018 01:14 PM, Toke Høiland-Jørgensen wrote:
> Signed-off-by: Toke Høiland-Jørgensen
Please no empty commit message. Not sure why from the previous patch
you removed it here.
> ---
> tools/testing/selftests/bpf/trace_helpers.c | 47
> ++-
> tools/te
Please only submit bug fixes at this time due to merge window, thank you.
From: Subash Abhinov Kasiviswanathan
Date: Mon, 4 Jun 2018 19:26:07 -0600
> RAWIP devices such as rmnet do not have a hardware address and
> instead require the kernel to generate a random IID for the
> IPv6 addresses.
>
> Signed-off-by: Sean Tranchetti
> Signed-off-by: Subash Abhinov Kasivisw
From: Subash Abhinov Kasiviswanathan
Date: Mon, 4 Jun 2018 19:43:38 -0600
> When sending an ack to a command packet, the skb is still referenced
> after it is sent to the real device. Since the real device could
> free the skb, the device pointer would be invalid.
> Also, remove an unnecessary v
From: Wei Yongjun
Date: Tue, 5 Jun 2018 02:42:45 +
> Fixes the following sparse warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning:
> symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun
Applied.
From: Wei Yongjun
Date: Tue, 5 Jun 2018 02:42:56 +
> Fix to return error code -ENOMEM from the kvzalloc_node() error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory
> scheme")
> Signed-off-by: Wei
From: Xin Long
Date: Tue, 5 Jun 2018 12:16:58 +0800
> syzbot reported a rcu_sched self-detected stall on CPU which is caused
> by too small value set on rto_min with SCTP_RTOINFO sockopt. With this
> value, hb_timer will get stuck there, as in its timer handler it starts
> this timer again with
From: Jiri Pirko
Date: Tue, 5 Jun 2018 10:18:36 +0200
> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote:
>>On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
>>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
>>> > if (!mlxsw_sp_port->split) {
>>> >
From: Paul Blakey
Date: Tue, 5 Jun 2018 11:04:03 +0300
> When using a vxlan device as the ingress dev, we count it as a
> "no offload dev", so when such a rule comes and err stop is true,
> we fail early and don't try the egdev route which can offload it
> through the egress device.
>
> Fix tha
Daniel Borkmann writes:
> Hi Toke,
>
> On 06/05/2018 01:14 PM, Toke Høiland-Jørgensen wrote:
>> Signed-off-by: Toke Høiland-Jørgensen
>
> Please no empty commit message. Not sure why from the previous patch
> you removed it here.
Ah, right, sorry; think I got patch versions mixed up :/
Will re
From: Eric Dumazet
Date: Tue, 5 Jun 2018 05:59:27 -0700
> On 06/05/2018 03:07 AM, Maciej Żenczykowski wrote:
>> From: Maciej Żenczykowski
>>
>> Tested: 'git grep tw_timeout' comes up empty and it builds :-)
>>
>> Signed-off-by: Maciej Żenczykowski
>> Cc: Eric Dumazet
>
> This field became n
Add an example program showing how to sample packets from XDP using the
perf event buffer. The example userspace program just prints the ethernet
header for every packet sampled.
Signed-off-by: Toke Høiland-Jørgensen
---
samples/bpf/Makefile |4 +
samples/bpf/xdp_sample_pkts_ke
Add two new helper functions to trace_helpers that supports polling
multiple perf file descriptors for events. These are used to the XDP
perf_event_output example, which needs to work with one perf fd per CPU.
Signed-off-by: Toke Høiland-Jørgensen
---
tools/testing/selftests/bpf/trace_helpers.c
From: Paolo Abeni
Date: Tue, 5 Jun 2018 12:32:33 +0200
> @@ -1157,7 +1158,9 @@ static int kcm_recvmsg(struct socket *sock, struct
> msghdr *msg,
> /* Finished with message */
> msg->msg_flags |= MSG_EOR;
> KCM_STATS_INCR(kcm->sta
On Tue, 2018-06-05 at 11:38 +0200, Daniele Palmas wrote:
> Hi,
>
> 2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan
> :
> > On 2018-02-21 04:38, Daniele Palmas wrote:
> > >
> > > Hello,
> > >
> > > in rmnet kernel documentation I read:
> > >
> > > "This driver can be used to register o
On 6/5/18 1:18 AM, Jiri Pirko wrote:
> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote:
>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
>>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
if (!mlxsw_sp_port->split) {
netdev_err(ml
From: David Ahern
Date: Tue, 5 Jun 2018 07:58:44 -0700
> On 6/5/18 1:18 AM, Jiri Pirko wrote:
>> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote:
>>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
Tue, Jun 05, 2018 at 04:58:44PM CEST, dsah...@gmail.com wrote:
>On 6/5/18 1:18 AM, Jiri Pirko wrote:
>> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote:
>>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote:
Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:
From: David Ahern
Patch 1 adds extack arg to reload, port_split and port_unsplit devlink
operations.
Patch 2 adds extack messages for reload operation in netdevsim.
Patch 3 adds extack messages to port split/unsplit in mlxsw driver.
v2
- make the extack messages align with existing dev_err
Da
From: David Ahern
devlink reset command can fail if a FIB resource limit is set to a value
lower than the current occupancy. Return a proper message indicating the
reason for the failure.
$ devlink resource sh netdevsim/netdevsim0
netdevsim/netdevsim0:
name IPv4 size unlimited unit entry size_
From: David Ahern
Return messages in extack for port split/unsplit errors. e.g.,
$ devlink port split swp1s1 count 4
Error: mlxsw_spectrum: Port cannot be split further.
devlink answers: Invalid argument
$ devlink port unsplit swp4
Error: mlxsw_spectrum: Port was not split.
From: David Ahern
Add extack argument to reload, port_split and port_unsplit operations.
Signed-off-by: David Ahern
Acked-by: Jiri Pirko
---
drivers/net/ethernet/mellanox/mlxsw/core.c | 9 ++---
drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 5 +++--
drivers/net/netdevsim/devl
Tue, Jun 05, 2018 at 05:14:11PM CEST, dsah...@kernel.org wrote:
>From: David Ahern
>
>Return messages in extack for port split/unsplit errors. e.g.,
>$ devlink port split swp1s1 count 4
>Error: mlxsw_spectrum: Port cannot be split further.
>devlink answers: Invalid argument
>
>$ de
Hi,
On Tue, 2018-06-05 at 08:35 -0700, Tom Herbert wrote:
> On Tue, Jun 5, 2018 at 7:53 AM, David Miller wrote:
> > From: Paolo Abeni
> > Date: Tue, 5 Jun 2018 12:32:33 +0200
> >
> >> @@ -1157,7 +1158,9 @@ static int kcm_recvmsg(struct socket *sock, struct
> >> msghdr *msg,
> >>
Hi,
I'm sorry for the long delay in my answer, I've been travelling.
On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote:
> On Thu, 31 May 2018, Neil Horman wrote:
> > What packet types will rcd.csum be set for?
> > Neil
>
> I looked thorugh the emulation code and found that rcd.csum is not se
It seems that rtnl_group_changelink() can call do_setlink
while a prior call to validate_linkmsg(dev = NULL, ...) could
not validate IFLA_ADDRESS / IFLA_BROADCAST
Make sure do_setlink() calls validate_linkmsg() instead
of letting its callers having this responsibility.
With help from Dmitry Vyuko
From: Sabrina Dubroca
Date: Tue, 5 Jun 2018 15:01:59 +0200
> Currently, raw6_sk(sk)->ip6mr_table is set unconditionally during
> ip6_mroute_setsockopt(MRT6_TABLE). A subsequent attempt at the same
> setsockopt will fail with -ENOENT, since we haven't actually created
> that table.
>
> A similar
From: Sabrina Dubroca
Date: Tue, 5 Jun 2018 15:02:00 +0200
> commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table")
> refactored ipmr_new_table, so that it now returns NULL when
> mr_table_alloc fails. Unfortunately, all callers of ipmr_new_table
> expect an ERR_PTR.
>
> This can r
From: Eric Dumazet
Date: Tue, 5 Jun 2018 06:06:19 -0700
> Before using nla_get_u32(), better make sure the attribute
> is of the proper size.
>
> Code recently was changed, but bug has been there from beginning
> of git.
...
> Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics file
From: dsah...@kernel.org
Date: Tue, 5 Jun 2018 08:14:08 -0700
> From: David Ahern
>
> Patch 1 adds extack arg to reload, port_split and port_unsplit devlink
> operations.
>
> Patch 2 adds extack messages for reload operation in netdevsim.
>
> Patch 3 adds extack messages to port split/unsplit
From: Amritha Nambiar
Date: Tue, 05 Jun 2018 01:37:45 -0700
> This patch series implements support for Tx queue selection based on
> Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue
> using sysfs attribute. If the user configuration for Rx queues does
> not apply, then th
On Tue, Jun 05, 2018 at 09:41:24AM -0400, David Miller wrote:
> From: Guillaume Nault
> Date: Mon, 4 Jun 2018 18:52:19 +0200
>
> > Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session
> > object destroy") tried to fix a race condition where a PPPoL2TP socket
> > would disappear w
Hi David,
The following pull-request contains BPF updates for your *net-next* tree.
The main changes are:
1) Add a new BPF hook for sendmsg similar to existing hooks for bind and
connect: "This allows to override source IP (including the case when it's
set via cmsg(3)) and destination IP:p
From: Eric Dumazet
Date: Tue, 5 Jun 2018 09:25:19 -0700
> It seems that rtnl_group_changelink() can call do_setlink
> while a prior call to validate_linkmsg(dev = NULL, ...) could
> not validate IFLA_ADDRESS / IFLA_BROADCAST
>
> Make sure do_setlink() calls validate_linkmsg() instead
> of letti
On 06/05/2018 09:41 AM, David Miller wrote:
> From: Eric Dumazet
> Date: Tue, 5 Jun 2018 09:25:19 -0700
>
>> It seems that rtnl_group_changelink() can call do_setlink
>> while a prior call to validate_linkmsg(dev = NULL, ...) could
>> not validate IFLA_ADDRESS / IFLA_BROADCAST
>>
>> Make sure
On Tue, Jun 5, 2018 at 6:43 AM, David Miller wrote:
> From: Cong Wang
> Date: Mon, 4 Jun 2018 11:07:19 -0700
>
>> +Q: Are all networking bug fixes backported to all stable releases?
>> +
>> +A: Due to capacity, Dave could only take care of the backports for the last
>> + 3 stable releases.
>
>
From: Eric Dumazet
Date: Tue, 5 Jun 2018 09:42:54 -0700
> On 06/05/2018 09:41 AM, David Miller wrote:
>> From: Eric Dumazet
>> Date: Tue, 5 Jun 2018 09:25:19 -0700
>>
>>> It seems that rtnl_group_changelink() can call do_setlink
>>> while a prior call to validate_linkmsg(dev = NULL, ...) could
From: Eric Dumazet
Date: Tue, 5 Jun 2018 09:25:19 -0700
> It seems that rtnl_group_changelink() can call do_setlink
> while a prior call to validate_linkmsg(dev = NULL, ...) could
> not validate IFLA_ADDRESS / IFLA_BROADCAST
>
> Make sure do_setlink() calls validate_linkmsg() instead
> of letti
Per discussion with David at netconf 2018, let's clarify
DaveM's position of handling stable backports in netdev-FAQ.
This is important for people relying on upstream -stable
releases.
Cc: sta...@vger.kernel.org
Cc: Greg Kroah-Hartman
Signed-off-by: Cong Wang
---
Documentation/networking/netde
On Tue, 5 Jun 2018 15:08:30 +0200
Nicolas Dichtel wrote:
>
> +char *get_name_from_nsid(int nsid)
> +{
> + struct nsid_cache *c;
> +
> + netns_nsid_socket_init();
> + netns_map_init();
> +
> + c = netns_map_get_by_nsid(nsid);
> + if (c)
> + return c->name;
> +
>
On 6/4/2018 8:42 PM, Stephen Hemminger wrote:
The net failover should be a simple library, not a virtual
object with function callbacks (see callback hell).
The code is simpler is smaller both for the netvsc and virtio use case.
I quickly tried this patch and it breaks virtio-net in standby mod
On 2018-06-05 08:54, Dan Williams wrote:
On Tue, 2018-06-05 at 11:38 +0200, Daniele Palmas wrote:
Hi,
2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan
:
> On 2018-02-21 04:38, Daniele Palmas wrote:
> >
> > Hello,
> >
> > in rmnet kernel documentation I read:
> >
> > "This driver can be
On Tue, 5 Jun 2018 10:22:13 -0700
"Samudrala, Sridhar" wrote:
> On 6/4/2018 8:42 PM, Stephen Hemminger wrote:
> > The net failover should be a simple library, not a virtual
> > object with function callbacks (see callback hell).
> > The code is simpler is smaller both for the netvsc and virtio us
From: Stephen Hemminger
Date: Tue, 5 Jun 2018 10:45:10 -0700
> I said it wasn't tested. Not surprising. Don't have a version of KVM
> that supports standby (and not going to build KVM from scratch for
> this).
It would definitely help me if you put "RFC" in the subject line
for patches which are
1 - 100 of 154 matches
Mail list logo
