Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

2018-08-09 Thread maowenan
On 2018/8/9 20:52, David Woodhouse wrote: > On Thu, 2018-08-09 at 14:47 +0200, Greg KH wrote: >> On Thu, Aug 09, 2018 at 08:37:13PM +0800, maowenan wrote: >>> There are two patches in stable branch linux-4.4, but I have tested with >>> below patches, and found that the cpu usage was very high.

Re: [PATCH] net: macb: do not disable MDIO bus when closing interface

2018-08-09 Thread Anssi Hannula
On 9.8.2018 18:14, Andrew Lunn wrote: > Hi Anssi Hi! >> macb_reset_hw() is called in init path too, though, so maybe clearing >> all bits is intentional / wanted to get the controller to a known state, >> even though the comment only mentions TX/RX? > You need to be careful here. Once of_mdiobus_

Re: pull-request: bpf 2018-08-10

2018-08-09 Thread David Miller
From: Daniel Borkmann Date: Fri, 10 Aug 2018 01:21:49 +0200 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git Pulled, thanks Daniel.

[net-next, PATCH 1/2 v2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Ilias Apalodimas
MMIO reads for remaining packets in queue occur (at least)twice per invocation of netsec_process_rx(). We can use the packet descriptor to identify if it's owned by the hardware and break out, avoiding the more expensive MMIO read operations. This has a ~2% increase on the pps of the Rx path when t

[net-next, PATCH 0/2 v2] netsec driver improvements

2018-08-09 Thread Ilias Apalodimas
This patchset introduces some improvements on socionext netsec driver. - patch 1/2, avoids unneeded MMIO reads on the Rx path - patch 2/2, is adjusting the numbers of descriptors used Changes since v1: - Move dma_rmb() to protect descriptor accesses until the device has updated the NETSEC_R

[net-next, PATCH 2/2 v2] net: socionext: Increase descriptors to 256

2018-08-09 Thread Ilias Apalodimas
Increasing descriptors to 256 from 128 and adjusting the NAPI weight to 64 increases performace on Rx by ~20% on 64byte packets Signed-off-by: Ilias Apalodimas --- drivers/net/ethernet/socionext/netsec.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/etherne

Re: [PATCH 0/2] net/sched: Add hardware specific counters to TC actions

2018-08-09 Thread Jakub Kicinski
On Thu, 9 Aug 2018 11:01:18 -0400, Eelco Chaudron wrote: > Add hardware specific counters to TC actions which will be exported > through the netlink API. This makes troubleshooting TC flower offload > easier, as it possible to differentiate the packets being offloaded. It is not immediately clear

Re: [PATCH bpf-next 1/3] bpf: add bpf queue map

2018-08-09 Thread Alexei Starovoitov
On Thu, Aug 09, 2018 at 06:41:54PM -0500, Mauricio Vasquez wrote: > > > On 08/09/2018 11:23 AM, Alexei Starovoitov wrote: > > On Thu, Aug 09, 2018 at 09:51:49AM -0500, Mauricio Vasquez wrote: > > > > Agree that existing ops are not the right alias, but deferring to user > > > > space as inline fu

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Alexei Starovoitov
On Fri, Aug 10, 2018 at 12:43:20AM +0200, Daniel Borkmann wrote: > On 08/09/2018 11:44 PM, Alexei Starovoitov wrote: > > On Thu, Aug 09, 2018 at 11:30:52PM +0200, Daniel Borkmann wrote: > >> On 08/09/2018 11:14 PM, Alexei Starovoitov wrote: > >>> On Thu, Aug 09, 2018 at 09:42:20PM +0200, Daniel Bor

[net-next:master 1941/1953] drivers/net/ethernet/qlogic/qede/qede_filter.c:2048:38: sparse: restricted __be16 degrades to integer

2018-08-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 36d2f761b5aa688567b6aebdc6d68e73682275d4 commit: 2ce9c93eaca6c67e3fa8828a471738a32cd66770 [1941/1953] qede: Ingress tc flower offload (drop action) support. reproduce: # apt-get install sparse

Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

2018-08-09 Thread maowenan
On 2018/8/9 20:52, David Woodhouse wrote: > On Thu, 2018-08-09 at 14:47 +0200, Greg KH wrote: >> On Thu, Aug 09, 2018 at 08:37:13PM +0800, maowenan wrote: >>> There are two patches in stable branch linux-4.4, but I have tested with >>> below patches, and found that the cpu usage was very high.

Re: [PATCH 4.9-stable] tcp: add tcp_ooo_try_coalesce() helper

2018-08-09 Thread maowenan
On 2018/8/9 20:47, Greg KH wrote: > On Thu, Aug 09, 2018 at 08:37:13PM +0800, maowenan wrote: >> >> >> On 2018/8/7 21:22, Greg KH wrote: >>> On Sat, Aug 04, 2018 at 10:10:00AM +0100, David Woodhouse wrote: From: Eric Dumazet commit 58152ecbbcc6a0ce7fddd5bf5f6ee535834ece0c upstrea

Re: Error running AF_XDP sample application

2018-08-09 Thread Jakub Kicinski
On Thu, 09 Aug 2018 18:18:08 +0200, kdjimeli wrote: > Hello, > > I have been trying to test a sample AF_XDP program, but I have been > experiencing some issues. > After building the sample code > https://github.com/torvalds/linux/tree/master/samples/bpf, > when running the xdpsock binary, I get th

[net-next:master 518/519] drivers/net/virtio_net.c:1910:3: error: implicit declaration of function '__netif_set_xps_queue'

2018-08-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 36d2f761b5aa688567b6aebdc6d68e73682275d4 commit: 4d99f6602cb552fb58db0c3b1d935bb6fa017f24 [518/519] net: allow to call netif_reset_xps_queues() under cpus_read_lock config: i386-randconfig-sb0-08100039 (atta

[PATCH net-next] net: add an empty __netif_set_xps_queue() stab in the !CONFIG_XPS case

2018-08-09 Thread Andrei Vagin
From: Andrei Vagin __netif_set_xps_queue() is used in drivers/net/virtio_net.c. Fixes: 4d99f6602cb5 ("net: allow to call netif_reset_xps_queues() under cpus_read_lock") Signed-off-by: Andrei Vagin --- include/linux/netdevice.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include

Re: [PATCH lora-next v2 8/8] net: lora: sx1301: convert driver over to regmap reads and writes

2018-08-09 Thread Andreas Färber
Am 10.08.2018 um 00:47 schrieb Ben Whitten: > On Thu, 9 Aug 2018 at 23:34, Andreas Färber wrote: >> Applying so that we can continue based on regmap. > > Thanks! Rebased onto latest linux-next, tested on RAK831 and pushed: https://git.kernel.org/pub/scm/linux/kernel/git/afaerber/linux-lora.git/

Re: [PATCH net-next v6 10/11] net: sched: atomically check-allocate action

2018-08-09 Thread Cong Wang
On Wed, Aug 8, 2018 at 5:06 AM Vlad Buslov wrote: > > > On Wed 08 Aug 2018 at 01:20, Cong Wang wrote: > > On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > >> > >> Implement function that atomically checks if action exists and either takes > >> reference to it, or allocates idr slot for action

Re: [PATCH bpf-next 1/3] bpf: add bpf queue map

2018-08-09 Thread Mauricio Vasquez
On 08/09/2018 11:23 AM, Alexei Starovoitov wrote: On Thu, Aug 09, 2018 at 09:51:49AM -0500, Mauricio Vasquez wrote: Agree that existing ops are not the right alias, but deferring to user space as inline function also doesn't really seem like a good fit, imho, so I'd prefer rather to have some

[net-next:master 518/519] drivers/net/virtio_net.c:1910:3: error: implicit declaration of function '__netif_set_xps_queue'; did you mean 'netif_set_xps_queue'?

2018-08-09 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 36d2f761b5aa688567b6aebdc6d68e73682275d4 commit: 4d99f6602cb552fb58db0c3b1d935bb6fa017f24 [518/519] net: allow to call netif_reset_xps_queues() under cpus_read_lock config: sh-allmodconfig (attached as .conf

pull-request: bpf 2018-08-10

2018-08-09 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. The main changes are: 1) Fix cpumap and devmap on teardown as they're under RCU context and won't have same assumption as running under NAPI protection, from Jesper. 2) Fix various sockmap bugs in bpf_tcp_sendm

Re: [PATCH] net: ethernet: cpsw-phy-sel: prefer phandle for phy sel and update binding

2018-08-09 Thread Grygorii Strashko
On 08/09/2018 05:46 AM, Tony Lindgren wrote: * Tony Lindgren [180808 13:52]: * Andrew Lunn [180808 12:02]: Do you need to handle EPROBE_DEFER here? The phandle points to a device which has not yet been loaded? I'm not sure exactly where it will be returned, maybe it is bus_find_device(),

Re: [PATCH lora-next v2 8/8] net: lora: sx1301: convert driver over to regmap reads and writes

2018-08-09 Thread Ben Whitten
On Thu, 9 Aug 2018 at 23:34, Andreas Färber wrote: > > Am 09.08.2018 um 14:33 schrieb Ben Whitten: > > The reads and writes are replaced with regmap versions and unneeded > > functions, variable, and defines removed. > > > > Signed-off-by: Ben Whitten > > --- > > drivers/net/lora/sx1301.c | 204

Re: [PATCH net-next,v4] net/tls: Calculate nsg for zerocopy path without skb_cow_data.

2018-08-09 Thread Doron Roberts-Kedes
On Wed, Aug 08, 2018 at 12:14:30PM -0700, David Miller wrote: > From: Doron Roberts-Kedes > Date: Tue, 7 Aug 2018 11:09:39 -0700 > > > +static int __skb_nsg(struct sk_buff *skb, int offset, int len, > > +unsigned int recursion_level) > > +{ > > + int start = skb_headlen(skb); >

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 11:44 PM, Alexei Starovoitov wrote: > On Thu, Aug 09, 2018 at 11:30:52PM +0200, Daniel Borkmann wrote: >> On 08/09/2018 11:14 PM, Alexei Starovoitov wrote: >>> On Thu, Aug 09, 2018 at 09:42:20PM +0200, Daniel Borkmann wrote: Commit a26ca7c982cb ("bpf: btf: Add pretty print suppor

Re: [PATCH lora-next v2 8/8] net: lora: sx1301: convert driver over to regmap reads and writes

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > The reads and writes are replaced with regmap versions and unneeded > functions, variable, and defines removed. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 204 > +++--- > drivers/net/lo

Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock

2018-08-09 Thread Michael S. Tsirkin
On Wed, Aug 08, 2018 at 08:07:35PM -0700, Andrei Vagin wrote: > From: Andrei Vagin > > The definition of static_key_slow_inc() has cpus_read_lock in place. In the > virtio_net driver, XPS queues are initialized after setting the queue:cpu > affinity in virtnet_set_affinity() which is already prot

Re: KCM - recvmsg() mangles packets?

2018-08-09 Thread Dominique Martinet
Tom Herbert wrote on Thu, Aug 09, 2018: > > diff --git a/net/strparser/strparser.c b/net/strparser/strparser.c > > index 625acb27efcc..348ff5945591 100644 > > --- a/net/strparser/strparser.c > > +++ b/net/strparser/strparser.c > > @@ -222,6 +222,16 @@ static int __strp_recv(read_descriptor_t *desc,

Re: [PATCH lora-next v2 7/8] net: lora: sx1301: add initial registration for regmap

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > The register and bit-field definitions are taken from the SX1301 > datasheet version 2.01 dated June 2014 with the revision information > 'First released version'. > > The reset state and RW capability of each field is not reflected in this > patch how

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Alexei Starovoitov
On Thu, Aug 09, 2018 at 11:30:52PM +0200, Daniel Borkmann wrote: > On 08/09/2018 11:14 PM, Alexei Starovoitov wrote: > > On Thu, Aug 09, 2018 at 09:42:20PM +0200, Daniel Borkmann wrote: > >> Commit a26ca7c982cb ("bpf: btf: Add pretty print support to > >> the basic arraymap") enabled support for BT

Re: [Patch net-next] net_sched: fix a potential out-of-bound access

2018-08-09 Thread Cong Wang
On Thu, Aug 9, 2018 at 12:32 AM Vlad Buslov wrote: > > Before version V5 of my action API patchset this functionality was > implemented in exactly the same way as in your patch. Unfortunately, it > has a double-free bug. The problem is that if you have multiple > actions(N) being deleted, and dele

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 11:14 PM, Alexei Starovoitov wrote: > On Thu, Aug 09, 2018 at 09:42:20PM +0200, Daniel Borkmann wrote: >> Commit a26ca7c982cb ("bpf: btf: Add pretty print support to >> the basic arraymap") enabled support for BTF and dumping via >> BPF fs for arraymap. However, both can be decoupled

Re: [PATCH net-next] cxgb4: update 1.20.8.0 as the latest firmware supported

2018-08-09 Thread David Miller
From: Ganesh Goudar Date: Thu, 9 Aug 2018 12:32:03 +0530 > Change t4fw_version.h to update latest firmware version > number to 1.20.8.0. > > Signed-off-by: Ganesh Goudar Applied, thank you.

Re: [PATCH net-next v2] net: allow to call netif_reset_xps_queues() under cpus_read_lock

2018-08-09 Thread David Miller
From: Andrei Vagin Date: Wed, 8 Aug 2018 20:07:35 -0700 > From: Andrei Vagin > > The definition of static_key_slow_inc() has cpus_read_lock in place. In the > virtio_net driver, XPS queues are initialized after setting the queue:cpu > affinity in virtnet_set_affinity() which is already protect

Re: [PATCH net-next v2 1/1] net/tls: Combined memory allocation for decryption request

2018-08-09 Thread David Miller
From: Vakul Garg Date: Thu, 9 Aug 2018 04:56:23 +0530 > For preparing decryption request, several memory chunks are required > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to > an accelerator, it is required that the buffers which are read by the > accelerator must be dma

Re: [PATCH lora-next v2 3/8] net: lora: sx1301: convert to passing priv data throughout

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 23:06 schrieb Ben Whitten: > On Thu, 9 Aug 2018 at 21:43, Andreas Färber wrote: >> Am 09.08.2018 um 14:33 schrieb Ben Whitten: >>> @@ -654,22 +646,35 @@ static int sx1301_probe(struct spi_device *spi) >>> priv->rst_gpio = rst; >>> priv->cur_page = 0xff; >>> >>> - s

Re: [PATCH v2 net-next] net: phy: sfp: print debug message with text, not numbers

2018-08-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Aug 2018 15:00:20 +0200 > Convert the state numbers, device state, etc from numbers to strings > when printing debug messages. > > Signed-off-by: Andrew Lunn > Acked-by: Florian Fainelli > --- > v2: Fixed typo in subject line. > Add Acked-by from Florian Gr

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Alexei Starovoitov
On Thu, Aug 09, 2018 at 09:42:20PM +0200, Daniel Borkmann wrote: > Commit a26ca7c982cb ("bpf: btf: Add pretty print support to > the basic arraymap") enabled support for BTF and dumping via > BPF fs for arraymap. However, both can be decoupled from each > other such that all BPF maps can be support

[PATCH] bonding: avoid repeated display of same link status change

2018-08-09 Thread rama nichanamatlu
From 9927a1c2a632d9479a80c63b7d9fda59ea8374bc Mon Sep 17 00:00:00 2001 From: Rama Nichanamatlu Date: Tue, 31 Jul 2018 07:09:52 -0700 Subject: [PATCH] bonding: avoid repeated display of same link status change When link status change needs to be committed and rtnl lock couldn't be taken, avoid re

Re: [patch net-next] net: sched: fix block->refcnt decrement

2018-08-09 Thread David Miller
From: Jiri Pirko Date: Wed, 8 Aug 2018 14:04:13 +0200 > From: Jiri Pirko > > Currently the refcnt is never decremented in case the value is not 1. > Fix it by adding decrement in case the refcnt is not 1. > > Reported-by: Vlad Buslov > Fixes: f71e0ca4db18 ("net: sched: Avoid implicit chain 0

Re: [PATCH lora-next v2 6/8] net: lora: sx1301: replace version and size magic numbers with defines

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We replace the hard coded numbers for size and version with meaningful > names. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 21 + > drivers/net/lora/sx1301.h | 18 ++ > 2 files changed, 31 in

Re: [PATCH net-next] net: ipv6_gre: Fix GRO to work on IPv6 over GRE tap

2018-08-09 Thread David Miller
From: Tariq Toukan Date: Wed, 8 Aug 2018 11:46:30 +0300 > IPv6 GRO over GRE tap is not working while GRO is not set > over the native interface. ... > This patch removes the override of the hard_header_len, and > assigns the calculated value to needed_headroom. > This way, the comparison in gro

Re: [PATCH lora-next v2 3/8] net: lora: sx1301: convert to passing priv data throughout

2018-08-09 Thread Ben Whitten
On Thu, 9 Aug 2018 at 21:43, Andreas Färber wrote: > > Am 09.08.2018 um 14:33 schrieb Ben Whitten: > > Instead of passing around the spi device we instead pass around our > > driver data directly. > > > > Signed-off-by: Ben Whitten > > --- > > drivers/net/lora/sx1301.c | 305 > > +++

Re: [PATCH net-next 0/3] qed*: Enhancements

2018-08-09 Thread David Miller
From: Manish Chopra Date: Thu, 9 Aug 2018 11:13:48 -0700 > This patch series adds following support in drivers - > > 1. Egress mqprio offload. > 2. Add destination IP based flow profile. > 3. Ingress flower offload (for drop action). > > Please consider applying this series to "net-next". Seri

Re: [PATCH net-next 0/7] s390/qeth: updates 2018-08-09

2018-08-09 Thread David Miller
From: Julian Wiedmann Date: Thu, 9 Aug 2018 14:47:57 +0200 > one more set of patches for net-next. This is all sorts of cleanups > and more refactoring on the way to using netdev_priv. Please apply. Looks simple enough, series applied, thanks.

Re: [PATCH lora-next v2 5/8] net: lora: sx1301: remove duplicate firmware size checks

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > No need to check the size of the firmware multiple times, just do it once > in the function responsible for loading as the firmwares are the same size. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 21 +++-- > 1 f

Re: KCM - recvmsg() mangles packets?

2018-08-09 Thread Tom Herbert
On Sun, Aug 5, 2018 at 4:39 PM, Dominique Martinet wrote: > Dominique Martinet wrote on Sun, Aug 05, 2018: >> It's getting late but I'll try adding a pskb_pull in there tomorrow, it >> would be better to make the bpf program start with an offset but I don't >> think that'll be easy to change... >

[PATCH net-next] liquidio: copperhead LED identification

2018-08-09 Thread Felix Manlunas
From: Raghu Vatsavayi Add LED identification support for liquidio TP copperhead cards. Signed-off-by: Raghu Vatsavayi Acked-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/lio_ethtool.c | 27 ++ .../net/ethernet/cavium/liquidio/li

Re: [PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Yonghong Song
On 8/9/18 12:42 PM, Daniel Borkmann wrote: Commit a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap") enabled support for BTF and dumping via BPF fs for arraymap. However, both can be decoupled from each other such that all BPF maps can be supported for attaching BTF key/

Re: [PATCH lora-next v2 4/8] net: lora: sx1301: convert load_firmware to take firmware directly

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We just pass the pointer to firmware down to the function that loads > it. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) Applied. Thanks, Andreas -- SUS

Re: [PATCH lora-next v2 3/8] net: lora: sx1301: convert to passing priv data throughout

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > Instead of passing around the spi device we instead pass around our > driver data directly. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 305 > +++--- > 1 file changed, 155 insertions(+),

Re: [bpf-next PATCH 2/2] samples/bpf: xdp_redirect_cpu load balance like Suricata

2018-08-09 Thread Jesper Dangaard Brouer
On Thu, 9 Aug 2018 22:15:22 +0200 Daniel Borkmann wrote: > On 08/09/2018 03:26 PM, Jesper Dangaard Brouer wrote: > > This implement XDP CPU redirection load-balancing across available > > CPUs, based on the hashing IP-pairs + L4-protocol. This equivalent to > > xdp-cpu-redirect feature in Surica

Re: [bpf-next PATCH 2/2] samples/bpf: xdp_redirect_cpu load balance like Suricata

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 03:26 PM, Jesper Dangaard Brouer wrote: > This implement XDP CPU redirection load-balancing across available > CPUs, based on the hashing IP-pairs + L4-protocol. This equivalent to > xdp-cpu-redirect feature in Suricata, which is inspired by the > Suricata 'ippair' hashing code. > >

Re: [net PATCH 0/3] Fix two teardown bugs for BPF maps cpumap and devmap

2018-08-09 Thread Daniel Borkmann
On 08/08/2018 11:00 PM, Jesper Dangaard Brouer wrote: > Removing entries from cpumap and devmap, goes through a number of > syncronization steps to make sure no new xdp_frames can be enqueued. > But there is a small chance, that xdp_frames remains which have not > been flushed/processed yet. Flush

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 07:54 PM, Yonghong Song wrote: > On 8/9/18 10:02 AM, Daniel Borkmann wrote: >> On 08/09/2018 06:55 PM, Yonghong Song wrote: >>> On 8/9/18 8:59 AM, Daniel Borkmann wrote: On 08/09/2018 05:15 PM, Yonghong Song wrote: > On 8/9/18 7:24 AM, Daniel Borkmann wrote: >> On 08/09/2

[PATCH bpf-next] bpf: enable btf for use in all maps

2018-08-09 Thread Daniel Borkmann
Commit a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap") enabled support for BTF and dumping via BPF fs for arraymap. However, both can be decoupled from each other such that all BPF maps can be supported for attaching BTF key/value information, while not all maps necessaril

[PATCH v1 net-next] lan743x: lan743x: Add PTP support

2018-08-09 Thread Bryan Whitehead
PTP support includes: Ingress, and egress timestamping. One step timestamping available. PTP clock support. Periodic output support. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Makefile |2 +- drivers/net/ethernet/microchip/lan743x_ethtool.c |

Re: [PATCH net-next v6 06/11] net: sched: add 'delete' function to action ops

2018-08-09 Thread Cong Wang
On Thu, Jul 5, 2018 at 7:24 AM Vlad Buslov wrote: > > Extend action ops with 'delete' function. Each action type to implements > its own delete function that doesn't depend on rtnl lock. > > Implement delete function that is required to delete actions without > holding rtnl lock. Use action API fu

Re: [PATCH lora-next v2 2/8] net: lora: sx1301: convert to devm registration of netdev

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > We allow the devres framework handle the clean removal of resources on > teardown of the device, in this case the SPI device, saving lengthy > unwind code and improving clarity. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/sx1301.c | 87 >

Re: [PATCH net-next 5/5] net: aquantia: bump driver version

2018-08-09 Thread Jakub Kicinski
On Thu, 9 Aug 2018 13:10:09 +0300, Igor Russkikh wrote: > Hi Andrew, > > Thanks for the review, agreed on all your findings, > we'll address these comments in next version. > > > Driver versions are pretty much useless. Say somebody backports this > > driver into a vendor kernel. Vendor kernels a

Re: [PATCH lora-next v2 1/8] net: lora: add methods for devm registration

2018-08-09 Thread Andreas Färber
Am 09.08.2018 um 14:33 schrieb Ben Whitten: > Follow the devm model so that we can avoid lengthy unwind code. > > Signed-off-by: Ben Whitten > --- > drivers/net/lora/dev.c | 28 > include/linux/lora/dev.h | 1 + > 2 files changed, 29 insertions(+) > > diff --git

Re: [net-next, PATCH 1/2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Ilias Apalodimas
On Thu, Aug 09, 2018 at 05:37:15PM +0200, Arnd Bergmann wrote: > On Thu, Aug 9, 2018 at 10:02 AM Ilias Apalodimas > wrote: > > > > MMIO reads for remaining packets in queue occur (at least)twice per > > invocation of netsec_process_rx(). We can use the packet descriptor to > > identify if it's own

[PATCH net] l2tp: use sk_dst_check() to avoid race on sk->sk_dst_cache

2018-08-09 Thread Wei Wang
From: Wei Wang In l2tp code, if it is a L2TP_UDP_ENCAP tunnel, tunnel->sk points to a UDP socket. User could call sendmsg() on both this tunnel and the UDP socket itself concurrently. As l2tp_xmit_skb() holds socket lock and call __sk_dst_check() to refresh sk->sk_dst_cache, while udpv6_sendmsg()

Re: [PATCH v4 net-next 0/9] Add support for XGMAC2 in stmmac

2018-08-09 Thread David Miller
From: Jose Abreu Date: Wed, 8 Aug 2018 09:04:28 +0100 > This series adds support for 10Gigabit IP in stmmac. Series applied, thanks Jose.

[PATCH net-next 3/3] qede: Ingress tc flower offload (drop action) support.

2018-08-09 Thread Manish Chopra
The main motive of this patch is to lay down driver's tc offload infrastructure in place. With these changes tc can offload various supported flow profiles (4 tuples, src-ip, dst-ip, l4 port) for the drop action. Dropped flows statistic is a global counter for all the offloaded flows for drop acti

[PATCH net-next 2/3] qede: Add destination ip based flow profile.

2018-08-09 Thread Manish Chopra
This patch adds support for dropping and redirecting the flows based on destination IP in the packet. This also moves the profile mode settings in their own functions which can be used through tc flows in successive patch. For example - ethtool -N p5p1 flow-type tcp4 dst-ip 192.168.40.100 action

[PATCH net-next 1/3] qed/qede: Multi CoS support.

2018-08-09 Thread Manish Chopra
This patch adds support for tc mqprio offload, using this different traffic classes on the adapter can be utilized based on configured priority to tc map. For example - tc qdisc add dev eth0 root mqprio num_tc 4 map 0 1 2 3 This will cause SKBs with priority 0,1,2,3 to transmit over tc 0,1,2,3 h

[PATCH net-next 0/3] qed*: Enhancements

2018-08-09 Thread Manish Chopra
Hi David, This patch series adds following support in drivers - 1. Egress mqprio offload. 2. Add destination IP based flow profile. 3. Ingress flower offload (for drop action). Please consider applying this series to "net-next". Thanks, Manish Manish Chopra (3): qed/qede: Multi CoS support.

Re: [PATCH net-next 00/13] More complete PHYLINK support for mv88e6xxx

2018-08-09 Thread David Miller
From: Andrew Lunn Date: Thu, 9 Aug 2018 15:38:36 +0200 > Previous patches added sufficient PHYLINK support to the mv88e6xxx > that it did not break existing use cases, basically fixed-link phys. > > This patchset builds out the support so that SFP modules, up to > 2.5Gbps can be supported, on m

[PATCH ethtool v2 1/3] ethtool-copy.h: sync with net-next

2018-08-09 Thread Florian Fainelli
This covers kernel changes up to commit 6cfef793b558: ethtool: Add WAKE_FILTER and RX_CLS_FLOW_WAKE Signed-off-by: Florian Fainelli --- ethtool-copy.h | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/ethtool-copy.h b/ethtool-copy.h index 8cc61e9ab40b..6bfbb

[PATCH ethtool v2 2/3] ethtool: Add support for WAKE_FILTER (WoL using filters)

2018-08-09 Thread Florian Fainelli
Add a new character 'f' which can be used to configure an Ethernet controller to support Wake-on-LAN using filters programmed with the ethtool::rxnfc and the special action -2 (wake-up filter). This is useful in particular in the context of devices that must support wake-up on more complex patterns

[PATCH ethtool v2 0/3] ethtool: Wake-on-LAN using filters

2018-08-09 Thread Florian Fainelli
Hi John, This patch series syncs up ethtool-copy.h to get the new definitions required for supporting wake-on-LAN using filters: WAKE_FILTER and RX_CLS_FLOW_WAKE and then updates the rxclass.c code to allow us to specify action -2 (RX_CLS_FLOW_WAKE). Let me know if you would like this to be done

[PATCH ethtool v2 3/3] ethtool: Add support for action value -2 (wake-up filter)

2018-08-09 Thread Florian Fainelli
Add the ability to program special filters using ethtool::rxnfc which are meant to be used for wake-up purposes (in conjuction with WAKE_FILTER) using the special action value: -2 (RX_CLS_FLOW_WAKE). Signed-off-by: Florian Fainelli --- ethtool.8.in | 1 + rxclass.c| 8 +--- 2 files chang

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Yonghong Song
On 8/9/18 10:02 AM, Daniel Borkmann wrote: On 08/09/2018 06:55 PM, Yonghong Song wrote: On 8/9/18 8:59 AM, Daniel Borkmann wrote: On 08/09/2018 05:15 PM, Yonghong Song wrote: On 8/9/18 7:24 AM, Daniel Borkmann wrote: On 08/09/2018 05:55 AM, Yonghong Song wrote: On 8/8/18 7:25 PM, Alexei S

Re: [PATCH net-next 0/7] mlxsw: Various updates

2018-08-09 Thread David Miller
From: Ido Schimmel Date: Thu, 9 Aug 2018 11:59:06 +0300 > Patches 1-3 update the driver to use a new firmware version. Due to a > recently discovered issue, the version (and future ones) does not > support matching on VLAN ID at egress. This is enforced in the driver > and reported back to the u

Re: [Query]: DSA Understanding

2018-08-09 Thread Andrew Lunn
> Its coming from the switch lan4 I have attached the png, where > C4:F3:12:08:FE:7F is > the mac of lan4, which is broadcast to ff:ff:ff:ff:ff:ff, which is > causing rx counter on > PC to go up. So, big packets are making it from the switch to the PC. But the small ARP packets are not. This is w

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 06:55 PM, Yonghong Song wrote: > On 8/9/18 8:59 AM, Daniel Borkmann wrote: >> On 08/09/2018 05:15 PM, Yonghong Song wrote: >>> On 8/9/18 7:24 AM, Daniel Borkmann wrote: On 08/09/2018 05:55 AM, Yonghong Song wrote: > On 8/8/18 7:25 PM, Alexei Starovoitov wrote: >> On Wed,

Re: [PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics

2018-08-09 Thread Eelco Chaudron
Thanks for the quick reply, see inline responses. On 9 Aug 2018, at 18:07, Stephen Hemminger wrote: On Thu, 9 Aug 2018 11:16:02 -0400 Eelco Chaudron wrote: +static void print_tcstats_basic_hw(struct rtattr **tbs, char *prefix) +{ + struct gnet_stats_basic bs = {0}; If not present

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Yonghong Song
On 8/9/18 8:59 AM, Daniel Borkmann wrote: On 08/09/2018 05:15 PM, Yonghong Song wrote: On 8/9/18 7:24 AM, Daniel Borkmann wrote: On 08/09/2018 05:55 AM, Yonghong Song wrote: On 8/8/18 7:25 PM, Alexei Starovoitov wrote: On Wed, Aug 08, 2018 at 06:25:19PM -0700, Yonghong Song wrote: In func

Error running AF_XDP sample application

2018-08-09 Thread kdjimeli
Hello, I have been trying to test a sample AF_XDP program, but I have been experiencing some issues. After building the sample code https://github.com/torvalds/linux/tree/master/samples/bpf, when running the xdpsock binary, I get the errors "libbpf: failed to create map (name: 'xsks_map'): Invalid

Re: [DO NOT MERGE] ARM: dts: vf610-zii-dev-rev-c: add support for SFF modules

2018-08-09 Thread Marek Behún
Hi Andres, I tried your patches on Turris Mox with one 6190 marvell switch with port 9 connected to CPU and port 10 to SFP cage. Seems it works :) Thank you. Marek

[PATCH net-next 3/4] tcp: always ACK immediately on hole repairs

2018-08-09 Thread Yuchung Cheng
RFC 5681 sec 4.2: To provide feedback to senders recovering from losses, the receiver SHOULD send an immediate ACK when it receives a data segment that fills in all or part of a gap in the sequence space. When a gap is partially filled, __tcp_ack_snd_check already checks the out-of-order que

[PATCH net-next 4/4] tcp: avoid resetting ACK timer upon receiving packet with ECN CWR flag

2018-08-09 Thread Yuchung Cheng
Previously commit 9aee40006190 ("tcp: ack immediately when a cwr packet arrives") calls tcp_enter_quickack_mode to force sending two immediate ACKs upon receiving a packet w/ CWR flag. The side effect is it'll also reset the delayed ACK timer and interactive session tracking. This patch removes tha

[PATCH net-next 2/4] tcp: avoid resetting ACK timer in DCTCP

2018-08-09 Thread Yuchung Cheng
The recent fix of acking immediately in DCTCP on CE status change has an undesirable side-effect: it also resets TCP ack timer and disables pingpong mode (interactive session). But the CE status change has nothing to do with them. This patch addresses that by using the new one-time immediate ACK fl

[PATCH net-next 0/4] new mechanism to ACK immediately

2018-08-09 Thread Yuchung Cheng
This patch is a follow-up feature improvement to the recent fixes on the performance issues in ECN (delayed) ACKs. Many of the fixes use tcp_enter_quickack_mode routine to force immediate ACKs. However the routine also reset tracking interactive session. This is not ideal because these immediate AC

[PATCH net-next 1/4] tcp: mandate a one-time immediate ACK

2018-08-09 Thread Yuchung Cheng
Add a new flag to indicate a one-time immediate ACK. This flag is occasionaly set under specific TCP protocol states in addition to the more common quickack mechanism for interactive application. In several cases in the TCP code we want to force an immediate ACK but do not want to call tcp_enter_q

Re: [PATCH net-next v2 1/1] net/tls: Combined memory allocation for decryption request

2018-08-09 Thread Dave Watson
On 08/09/18 04:56 AM, Vakul Garg wrote: > For preparing decryption request, several memory chunks are required > (aead_req, sgin, sgout, iv, aad). For submitting the decrypt request to > an accelerator, it is required that the buffers which are read by the > accelerator must be dma-able and not com

Re: [PATCH bpf-next 1/3] bpf: add bpf queue map

2018-08-09 Thread Alexei Starovoitov
On Thu, Aug 09, 2018 at 09:51:49AM -0500, Mauricio Vasquez wrote: > > > Agree that existing ops are not the right alias, but deferring to user > > space as inline function also doesn't really seem like a good fit, imho, > > so I'd prefer rather to have something native. (Aside from that, the > > a

Re: [PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics

2018-08-09 Thread Stephen Hemminger
On Thu, 9 Aug 2018 11:16:02 -0400 Eelco Chaudron wrote: > > +static void print_tcstats_basic_hw(struct rtattr **tbs, char *prefix) > +{ > + struct gnet_stats_basic bs = {0}; If not present don't print it rather than printing zero. > + struct gnet_stats_basic bs_hw = {0}; This initia

Re: [PATCH bpf-next] BPF: helpers: New helper to obtain namespace data from current task

2018-08-09 Thread Carlos Neira
Jesper, Here is the updated patch. >From 92633f6819423093932e8d04aa3dc99a5913f6fd Mon Sep 17 00:00:00 2001 From: Carlos Neira Date: Thu, 9 Aug 2018 09:55:32 -0400 Subject: [PATCH bpf-next] BPF: helpers: New helper to obtain namespace data from current task This helper obtains the active namesp

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Daniel Borkmann
On 08/09/2018 05:15 PM, Yonghong Song wrote: > On 8/9/18 7:24 AM, Daniel Borkmann wrote: >> On 08/09/2018 05:55 AM, Yonghong Song wrote: >>> On 8/8/18 7:25 PM, Alexei Starovoitov wrote: On Wed, Aug 08, 2018 at 06:25:19PM -0700, Yonghong Song wrote: > In function map_seq_next() of kernel/bp

[PATCH bpf-next 1/3] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Yonghong Song
In function map_seq_next() of kernel/bpf/inode.c, the first key will be the "0" regardless of the map type. This works for array. But for hash type, if it happens key "0" is in the map, the bpffs map show will miss some items if the key "0" is not the first element of the first bucket. This patch

[PATCH bpf-next 2/3] bpf: btf: add pretty print for hash/lru_hash maps

2018-08-09 Thread Yonghong Song
Commit a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap") added pretty print support to array map. This patch adds pretty print for hash and lru_hash maps. The following example shows the pretty-print result of a pinned hashmap: struct map_value { int count_a

[PATCH bpf-next 0/3] bpf: add bpffs pretty print for hash/lru_hash maps

2018-08-09 Thread Yonghong Song
Commit a26ca7c982cb ("bpf: btf: Add pretty print support to the basic arraymap") added pretty print support to array map. This patch adds pretty print for hash and lru_hash maps. The following example shows the pretty-print result of a pinned hashmap. Without this patch set, user will get an error

[PATCH bpf-next 3/3] tools/bpf: add bpffs pretty print btf test for hash/lru_hash maps

2018-08-09 Thread Yonghong Song
Pretty print tests for hash/lru_hash maps are added in test_btf.c. The btf type blob is the same as pretty print array map test. The test result: $ mount -t bpf bpf /sys/fs/bpf $ ./test_btf -p BTF pretty print array..OK BTF pretty print hash..OK BTF pretty print lru hash

Re: [net-next, PATCH 1/2] net: socionext: Use descriptor info instead of MMIO reads on Rx

2018-08-09 Thread Arnd Bergmann
On Thu, Aug 9, 2018 at 10:02 AM Ilias Apalodimas wrote: > > MMIO reads for remaining packets in queue occur (at least)twice per > invocation of netsec_process_rx(). We can use the packet descriptor to > identify if it's owned by the hardware and break out, avoiding the more > expensive MMIO read o

Re: [Query]: DSA Understanding

2018-08-09 Thread Andrew Lunn
> > > The received packets captured on the PC are MDNS and DHPC, these MDNS > > > are causing the rx > > > packet counter go up: > > > > And where are these packets coming from? The target device? Or some > > other device on your network? > > > AFIK, MDNS is also kind of a bcast its sending MDNS re

Re: C45 support and mdiobus_scan

2018-08-09 Thread Andrew Lunn
> > The PCIe core will look in the device tree and when it creates the > > platform device for the i210 on the pcie bus, it points > > pdev->dev.of_node at this node. So long as you are using a platform > > with DT, you can do this. I hope you are not using x86.. > > Yes I am :( Any possible solut

Re: [PATCH bpf] bpf: fix bpffs non-array map seq_show issue

2018-08-09 Thread Yonghong Song
On 8/9/18 7:24 AM, Daniel Borkmann wrote: On 08/09/2018 05:55 AM, Yonghong Song wrote: On 8/8/18 7:25 PM, Alexei Starovoitov wrote: On Wed, Aug 08, 2018 at 06:25:19PM -0700, Yonghong Song wrote: In function map_seq_next() of kernel/bpf/inode.c, the first key will be the "0" regardless of th

[PATCH iproute2/net-next] tc_util: Add support for showing TCA_STATS_BASIC_HW statistics

2018-08-09 Thread Eelco Chaudron
Add support for showing hardware specific counters to easily troubleshoot hardware offload. $ tc -s filter show dev enp3s0np0 parent : filter protocol ip pref 1 flower chain 0 filter protocol ip pref 1 flower chain 0 handle 0x1 eth_type ipv4 dst_ip 2.0.0.0 src_ip 1.0.0.0 ip_flags nofra

Re: [PATCH] net: macb: do not disable MDIO bus when closing interface

2018-08-09 Thread Andrew Lunn
Hi Anssi > macb_reset_hw() is called in init path too, though, so maybe clearing > all bits is intentional / wanted to get the controller to a known state, > even though the comment only mentions TX/RX? You need to be careful here. Once of_mdiobus_register() is called, the MDIO should be usable.

  1   2   >