On 21/08/18 01:28, Andrew Lunn wrote:
>> Turns out the problem is WinPCAP running on the host system (Windows
>> 10).
> It would be good to report this to the WinPCAP people. I hate it when
> debug tools actually introduce bugs.
This will take me some time. I couldn't fairly blame WinPCAP. Firstly
From: Alexei Starovoitov
Date: Mon, 20 Aug 2018 13:52:07 -0700
> I don't think copy-paste avoids the issue of uapi.
> Anything used by BPF program is uapi.
> The only exception is offsets of kernel internal structures
> passed into bpf_probe_read().
> So we have several options:
> 1. be honest an
From: Yue Haibing
Date: Tue, 21 Aug 2018 01:41:56 +
> Remove duplicated include.
>
> Signed-off-by: Yue Haibing
Applied, thank you.
Remove duplicated include.
Signed-off-by: Yue Haibing
---
lib/rhashtable.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index ae4223e..672eecd 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -28,7 +28,6 @@
#include
#include
#include
-#inclu
From: dsah...@kernel.org
Date: Mon, 20 Aug 2018 13:02:41 -0700
> From: David Ahern
>
> Prior to the introduction of fib6_info lwtstate was managed by the dst
> code. With fib6_info releasing lwtstate needs to be done when the struct
> is freed.
>
> Fixes: 93531c674315 ("net/ipv6: separate handl
On Mon, 20 Aug 2018 16:44:28 -0700
Mahesh Bandewar (महेश बंडेवार) wrote:
> On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार)
> wrote:
> > On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger
> > wrote:
> >> On Mon, 20 Aug 2018 14:42:15 -0700
> >> Mahesh Bandewar wrote:
> >>
> >
On Mon, Aug 20, 2018 at 4:44 PM, Mahesh Bandewar (महेश बंडेवार)
wrote:
> On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार)
> wrote:
>> On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger
>> wrote:
>>> On Mon, 20 Aug 2018 14:42:15 -0700
>>> Mahesh Bandewar wrote:
>>>
diff --git
On Mon, Aug 20, 2018 at 3:50 PM, Stephen Hemminger
wrote:
> On Mon, 20 Aug 2018 14:42:15 -0700
> Mahesh Bandewar wrote:
>
>>
>> if (is_json_context()) {
>> + json_writer_t *jw;
>> +
>> open_json_object("bittiming");
>>
From: Doron Roberts-Kedes
Date: Mon, 20 Aug 2018 17:27:23 -0700
> Given that frag_lists are not unlikely in this case, I believe the only
> remaining feedback on the original patch was the recursive
> implementation. If you'd like, I can re-submit with an iterative
> implementation, but I noticed
On Sat, Aug 11, 2018 at 11:54:53AM -0700, David Miller wrote:
> From: Doron Roberts-Kedes
> Date: Thu, 9 Aug 2018 15:43:44 -0700
>
> The reason is that we usually never need to "map" an SKB on receive,
> and on transmit the SKB geometry is normalized by the destination
> device features which mea
On Mon, Aug 20, 2018 at 11:29 AM David Miller wrote:
>
> From: Cong Wang
> Date: Sun, 19 Aug 2018 12:22:12 -0700
>
> > The only time we need to take tcfa_lock is when adding
> > a new metainfo to an existing ife->metalist. We don't need
> > to take tcfa_lock so early and so broadly in tcf_ife_ini
On Mon, Aug 20, 2018 at 4:38 PM, Mahesh Bandewar (महेश बंडेवार)
wrote:
> On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger
> wrote:
>> On Mon, 20 Aug 2018 14:42:15 -0700
>> Mahesh Bandewar wrote:
>>
>>> diff --git a/tc/m_ematch.c b/tc/m_ematch.c
>>> index ace4b3dd738b..a524b520b276 100644
>>> -
On Mon, Aug 20, 2018 at 3:52 PM, Stephen Hemminger
wrote:
> On Mon, 20 Aug 2018 14:42:15 -0700
> Mahesh Bandewar wrote:
>
>> diff --git a/tc/m_ematch.c b/tc/m_ematch.c
>> index ace4b3dd738b..a524b520b276 100644
>> --- a/tc/m_ematch.c
>> +++ b/tc/m_ematch.c
>> @@ -277,6 +277,7 @@ static int flatte
On Mon, Aug 20, 2018 at 5:39 PM, Florian Fainelli wrote:
> On 08/20/2018 12:44 PM, Marc Dionne wrote:
>> The r8169 adapter in one of my machines was not working after updating
>> to a current kernel from the merge window, which was fixed by enabling
>> CONFIG_REALTEK_PHY.
>>
>> So in addition to "
Signed-off-by: Stephen Hemminger
---
genl/genl_utils.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/genl/genl_utils.h b/genl/genl_utils.h
index 6e6f44501aba..3de0da34bdba 100644
--- a/genl/genl_utils.h
+++ b/genl/genl_utils.h
@@ -10,9 +10,10 @@ struct genl_util
Signed-off-by: Stephen Hemminger
---
ip/ip_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ip_common.h b/ip/ip_common.h
index 4d3227cbc389..200be5e23dd1 100644
--- a/ip/ip_common.h
+++ b/ip/ip_common.h
@@ -82,7 +82,7 @@ int do_netns(int argc, char **argv);
int do_
iproute2 uses kernel style guidelines
Stephen Hemminger (4):
ip: drop extern from function prototype
bridge: drop extern from function prototypes
genl: drop extern from function prototypes
tc: drop extern from function prototypes
bridge/br_common.h | 18 +-
genl/genl_util
Signed-off-by: Stephen Hemminger
---
bridge/br_common.h | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/bridge/br_common.h b/bridge/br_common.h
index 2f1cb8fd9f3d..7bf15e9548fc 100644
--- a/bridge/br_common.h
+++ b/bridge/br_common.h
@@ -6,20 +6,20 @@
#defi
Signed-off-by: Stephen Hemminger
---
tc/m_ematch.h | 35 +++
tc/m_pedit.h | 31 +++
tc/tc_common.h | 30 +++---
tc/tc_red.h| 7 ---
4 files changed, 49 insertions(+), 54 deletions(-)
diff --git a/tc/m
On Mon, 20 Aug 2018 14:42:15 -0700
Mahesh Bandewar wrote:
> diff --git a/tc/m_ematch.c b/tc/m_ematch.c
> index ace4b3dd738b..a524b520b276 100644
> --- a/tc/m_ematch.c
> +++ b/tc/m_ematch.c
> @@ -277,6 +277,7 @@ static int flatten_tree(struct ematch *head, struct
> ematch *tree)
> return co
On Mon, 20 Aug 2018 14:42:15 -0700
Mahesh Bandewar wrote:
>
> if (is_json_context()) {
> + json_writer_t *jw;
> +
> open_json_object("bittiming");
> print_int(PRINT_ANY, "bitrate", NULL, bt->bitrate);
> -
From: Mahesh Bandewar
These are primarily fixes for "string is not string literal" warnings
/ errors (with -Werror -Wformat-nonliteral). This should be a no-op
change. I had to replace couple of print helper functions with the
code they call as it was becoming harder to eliminate these warnings,
On Thu, Aug 16, 2018 at 09:44:20AM -0700, Petar Penkov wrote:
> From: Petar Penkov
>
> This patch series hardens the RX stack by allowing flow dissection in BPF,
> as previously discussed [1]. Because of the rigorous checks of the BPF
> verifier, this provides significant security guarantees. In
On 08/20/2018 12:44 PM, Marc Dionne wrote:
> The r8169 adapter in one of my machines was not working after updating
> to a current kernel from the merge window, which was fixed by enabling
> CONFIG_REALTEK_PHY.
>
> So in addition to "select PHYLIB", should CONFIG_R8169 not also be
> doing "select
On 20.08.2018 21:44, Marc Dionne wrote:
> The r8169 adapter in one of my machines was not working after updating
> to a current kernel from the merge window, which was fixed by enabling
> CONFIG_REALTEK_PHY.
>
> So in addition to "select PHYLIB", should CONFIG_R8169 not also be
> doing "select CON
From: David Ahern
Prior to the introduction of fib6_info lwtstate was managed by the dst
code. With fib6_info releasing lwtstate needs to be done when the struct
is freed.
Fixes: 93531c674315 ("net/ipv6: separate handling of FIB entries from dst based
routes")
Signed-off-by: David Ahern
---
n
Hi,
I just wanted to check if you would be interested in a list of Managed
Service Providers (MSPs) and Managed Security Service Providers (MSSPs)?
We also have the data intelligence of:
• Managed Service Providers (MSP’s)
• Managed Security Service Providers (MSSP’s)
• IT
The r8169 adapter in one of my machines was not working after updating
to a current kernel from the merge window, which was fixed by enabling
CONFIG_REALTEK_PHY.
So in addition to "select PHYLIB", should CONFIG_R8169 not also be
doing "select CONFIG_REALTEK_PHY" ?
Marc
we are getting such errors:
[ 408.737313] ixgbe :03:00.0 eth0: Detected Tx Unit Hang (XDP)
Tx Queue <46>
TDH, TDT <0>, <2>
next_to_use <2>
next_to_clean<0>
tx_buffer_inf
On Mon, 20 Aug 2018 20:50:55 +0200
Bartosz Golaszewski wrote:
> 2018-08-20 20:20 GMT+02:00 Boris Brezillon :
> > On Mon, 20 Aug 2018 11:43:34 +0100
> > Srinivas Kandagatla wrote:
> >
> >>
> >> Overall am still not able to clear visualize on how MTD bindings with
> >> nvmem cells would look in
On Mon, Aug 20, 2018 at 05:56:53PM +0200, Ahmad Fatoum wrote:
> On 08/20/2018 03:55 PM, Andrew Lunn wrote:
> > Why is of_phy_register_fixed_link(np) failing?
>
> Apparently, the fixed-link's gpio's FLAG_REQUESTED bit remained set
> causing gpiod_request_commit to return -EBUSY in (v4.18.0):
>
> [
gentle request. may i have review comments pls ?
-Rama
On 08/13/2018 01:10 PM, Rama Nichanamatlu wrote:
When link status change needs to be committed and rtnl lock couldn't be
taken, avoid redisplay of same link status change message.
Signed-off-by: Rama Nichanamatlu
---
drivers/net/bonding/
From: Tomer Tayar
Date: Mon, 20 Aug 2018 00:01:41 +0300
> This patch series fixes several issues in the driver's interface with the
> management FW (MFW).
>
> v1->v2:
> - Fix loop counter decrement to be pre instead of post.
Series applied, thank you.
From: Cong Wang
Date: Sun, 19 Aug 2018 12:22:12 -0700
> The only time we need to take tcfa_lock is when adding
> a new metainfo to an existing ife->metalist. We don't need
> to take tcfa_lock so early and so broadly in tcf_ife_init().
>
> This means we can always take ife_mod_lock first, avoid t
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c
When strncpy() is called with source and destination strings the same
length, gcc 8 warns that there may be an unterminated string. Using
strlcpy() rather than strncpy() forces a null at the end and quiets the
warning.
Signed-off-by: Larry Finger
---
drivers/staging/rtl8192e/rtllib_softmac.c | 4
When the size argument in a call to strncpy() is the size of the
destimation, gcc8 issues a warning. These patches fix the potential
problem by replacing the strncpy() with strlcpy().
Signed-off-by: Larry Finger
Larry Finger (2):
staging: rtl8192e: Fix compiler warning about strncpy
staging
On 8/17/2018 4:08 PM, Tushar Dave wrote:
RDS module sits on top of TCP (rds_tcp) and IB (rds_rdma), so messages
arrive in form of skb (over TCP) and scatterlist (over IB/RDMA).
However, because socket filter only deal with skb (e.g. struct skb as
bpf context) we can only use socket filter for rds
On Mon, Aug 20, 2018 at 7:13 AM, Willem de Bruijn
wrote:
> On Mon, Aug 20, 2018 at 1:47 AM Song Liu wrote:
>>
>> On Thu, Aug 16, 2018 at 4:14 PM, Petar Penkov wrote:
>> > On Thu, Aug 16, 2018 at 3:40 PM, Song Liu wrote:
>> >>
>> >> On Thu, Aug 16, 2018 at 9:44 AM, Petar Penkov
>> >> wrote:
>>
On 08/20/2018 03:55 PM, Andrew Lunn wrote:
> Why is of_phy_register_fixed_link(np) failing?
Apparently, the fixed-link's gpio's FLAG_REQUESTED bit remained set
causing gpiod_request_commit to return -EBUSY in (v4.18.0):
[] (gpiod_request_commit) from [] (gpiod_request+0x64/0x88)
[]
macb_reset_hw() is called from macb_close() and indirectly from
macb_open(). macb_reset_hw() zeroes the NCR register, including the MPE
(Management Port Enable) bit.
This will prevent accessing any other PHYs for other Ethernet MACs on
the MDIO bus, which remains registered at macb_reset_hw() time
On 08/20/2018 04:13 PM, Willem de Bruijn wrote:
> On Mon, Aug 20, 2018 at 1:47 AM Song Liu wrote:
>> On Thu, Aug 16, 2018 at 4:14 PM, Petar Penkov wrote:
>>> On Thu, Aug 16, 2018 at 3:40 PM, Song Liu wrote:
On Thu, Aug 16, 2018 at 9:44 AM, Petar Penkov
wrote:
> From: Petar Penkov
On Mon, Aug 20, 2018 at 1:47 AM Song Liu wrote:
>
> On Thu, Aug 16, 2018 at 4:14 PM, Petar Penkov wrote:
> > On Thu, Aug 16, 2018 at 3:40 PM, Song Liu wrote:
> >>
> >> On Thu, Aug 16, 2018 at 9:44 AM, Petar Penkov
> >> wrote:
> >> > From: Petar Penkov
> >> >
> >> > Adds a hook for programs of
On 17 Aug 2018, at 13:27, Jakub Kicinski wrote:
On Thu, 16 Aug 2018 14:02:44 +0200, Eelco Chaudron wrote:
On 11 Aug 2018, at 21:06, David Miller wrote:
From: Jakub Kicinski
Date: Thu, 9 Aug 2018 20:26:08 -0700
It is not immediately clear why this is needed. The memory and
updating two
> I've done so in part 4/4.
Yes, i noticed that later. Ideally, it would be here, since this is
the patch which actually changes the binding.
Andrew
On Mon, Aug 20, 2018 at 02:12:35PM +0200, Ahmad Fatoum wrote:
> The referenced commit broke initializing macb on the EVB-KSZ9477 eval board.
> There, of_mdiobus_register was called even for the fixed-link representing
> the SPI-connected switch PHY, with the result that the driver attempts to
> enu
On 08/20/2018 03:37 PM, Andrew Lunn wrote:
> We should be more specific than "device tree". It is actually the "mdio bus
> subtree".
I wasn't sure if there are more drivers that call of_mdiobus_register for the
MAC node.
I'll update the message.
> Is this patch on its own sufficient to fix your
On 08/20/2018 03:42 PM, Andrew Lunn wrote:
> On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote:
> This is correct. But i would prefer the more readable
>
> struct device_node *node = of_get_child_by_name(np, "mdio");
>
> if (!node)
> /*
On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote:
> To align macb DT entries with those of other MACs.
> For backwards compatibility, the old way remains supported.
>
> Suggested-by: Andrew Lunn
> Signed-off-by: Ahmad Fatoum
> ---
> drivers/net/ethernet/cadence/macb_main.c | 4 ++--
On Mon, Aug 20, 2018 at 02:12:36PM +0200, Ahmad Fatoum wrote:
> fixed-links are currently not handled by of_mdiobus_register,
> skip them with a warning instead of trying pointlessly to find their PHY
> address:
>
> libphy: MACB_mii_bus: probed
> mdio_bus f0028000.ethernet-: fi
> Turns out the problem is WinPCAP running on the host system (Windows
> 10).
Hi Craig
It would be good to report this to the WinPCAP people. I hate it when
debug tools actually introduce bugs.
Andrew
On 08/15/2018 03:59 PM, Lad, Prabhakar wrote:
> This didn’t happen in v4.9.x something in core has changed ?
In my case, it was the macb driver that changed. I found the offending commit
with git-bisect, you might want to give it a try.
On 08/20/2018 02:12 PM, Ahmad Fatoum wrote:
> /* Loop over the child nodes and register a phy_device for each phy */
> for_each_available_child_of_node(np, child) {
> + if (of_phy_is_fixed_link(np)) {
> + /* fixed-links are handled in the MAC drivers */
>
On 08/16/2018 04:24 PM, Andrew Lunn wrote:
> 1) A regression. We should find a fix for that. Maybe we should
>special case a child node called 'fixed-link' in
>of_mdiobus_register(). I would suggest adding a single warning if
>such node is found.
I just sent out a v2, which warns if fi
To align macb DT entries with those of other MACs.
For backwards compatibility, the old way remains supported.
Suggested-by: Andrew Lunn
Signed-off-by: Ahmad Fatoum
---
drivers/net/ethernet/cadence/macb_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e
fixed-links are currently not handled by of_mdiobus_register,
skip them with a warning instead of trying pointlessly to find their PHY
address:
libphy: MACB_mii_bus: probed
mdio_bus f0028000.ethernet-: fixed-link has invalid PHY address
mdio_bus f0028000.ethernet-ff
The referenced commit broke initializing macb on the EVB-KSZ9477 eval board.
There, of_mdiobus_register was called even for the fixed-link representing
the SPI-connected switch PHY, with the result that the driver attempts to
enumerate PHYs on a non-existent MDIO bus:
libphy: MACB_mii_bus:
Suggested-by: Andrew Lunn
Signed-off-by: Ahmad Fatoum
---
.../devicetree/bindings/net/macb.txt | 13 +++--
arch/arm/boot/dts/at91-sam9_l9260.dts | 6 ++-
arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 14 ++---
arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts | 10 ++--
arch/arm/
On 20/08/18 02:41, Andrew Lunn wrote:
>> I run inside Virtualbox with the Realtek PCIe GBE Family Controller.
>>
>> Assuming I'm reading /sys/class/net/enp0s3/driver correctly, it's using the
>> e1000 driver.
>
> Hi Craig
Andrew,
My apologies. I've wasted your time. PEBKAC.
> Ah. And how do you
Den mån 20 aug. 2018 kl 02:58 skrev Prashant Bhole
:
>
> s/ENOTSUPP/EOPNOTSUPP/ in function umem_assign_dev().
> This function's return value is directly returned by xsk_bind().
> EOPNOTSUPP is bind()'s possible return value.
>
> Fixes: f734607e819b ("xsk: refactor xdp_umem_assign_dev()")
> Signed-
60 matches
Mail list logo
