Re: [PATCH v3 net-next 4/9] bnxt_en: Use ignore_ari devlink parameter

On Sun, Sep 30, 2018 at 2:53 AM Or Gerlitz wrote: > > On Fri, Sep 28, 2018 at 9:30 AM Vasundhara Volam > wrote: > > This patch adds support for ignore_ari generic permanent mode > > devlink parameter. This parameter is disabled by default. It can be > > enabled using devlink param commands. > >

Re: [PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt

On Sat, Sep 29, 2018 at 6:27 PM Jiri Pirko wrote: > > Fri, Sep 28, 2018 at 08:28:23AM CEST, vasundhara-v.vo...@broadcom.com wrote: > >This patch adds a new file to add information about configuration > >parameters that are supported by bnxt_en driver via devlink. > > > >Cc: "David S. Miller" >

Re: [PATCH net-next] rtnetlink: fix rtnl_fdb_dump() for shorter family headers

On 9/28/18 1:35 PM, Mauricio Faria de Oliveira wrote: > Currently, rtnl_fdb_dump() assumes the family header is 'struct ifinfomsg', > which is not always true. For example, 'struct ndmsg' is used by iproute2 > as well (in the 'ip neigh' command). > > The problem is, the function bails out early

Re: [PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

On Sun, Sep 30, 2018 at 2:37 PM Eric Dumazet wrote: > > Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, > do not do it. > > Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") > Signed-off-by: Eric Dumazet > Cc: Willem de Bruijn > Reported-by: syzbot

Re: [PATCH iproute2-next 00/11] Fix dump requests to use proper header for type

On Sat, Sep 29, 2018 at 10:59:20AM -0700, David Ahern wrote: > From: David Ahern > > iproute2 currently uses ifinfomsg as the header for all dumps using the > wilddump headers. This is wrong as each message type actually has its own > header type. While the kernel has traditionally let it go as

[PATCH net] ipv4: fix use-after-free in ip_cmsg_recv_dstaddr()

Caching ip_hdr(skb) before a call to pskb_may_pull() is buggy, do not do it. Fixes: 2efd4fca703a ("ip: in cmsg IP(V6)_ORIGDSTADDR call pskb_may_pull") Signed-off-by: Eric Dumazet Cc: Willem de Bruijn Reported-by: syzbot --- net/ipv4/ip_sockglue.c | 3 +-- 1 file changed, 1 insertion(+), 2

Re: [PATCH iproute2-next 01/11] libnetlink: Convert GETADDR dumps to use rtnl_addrdump_req

On 9/30/18 3:35 AM, Stephen Hemminger wrote: > On Sat, 29 Sep 2018 10:59:21 -0700 > David Ahern wrote: > >> From: David Ahern >> >> Add rtnl_addrdump_req for address dumps using the proper ifaddrmsg >> as the header. Convert existing RTM_GETADDR dumps to use it. >> >> Signed-off-by: David Ahern

Re: [PATCH][net-next] ipv6: drop container_of when convert dst to rt6_info

On 9/30/18 3:38 AM, Li RongQing wrote: >> >> I don't understand why you are doing this? It is not going to be >> faster (or safer) than container_of. container_of provides the >> same functionality and is safe against position of the member >> in the structure. >> > > In fact, most places are

Re: [Patch net-next] net_sched: fix an extack message in tcf_block_find()

On Fri 28 Sep 2018 at 17:03, Cong Wang wrote: > On Fri, Sep 28, 2018 at 4:36 AM Vlad Buslov wrote: >> >> On Thu 27 Sep 2018 at 20:42, Cong Wang wrote: >> > It is clearly a copy-n-paste. >> > >> > Signed-off-by: Cong Wang >> > --- >> > net/sched/cls_api.c | 2 +- >> > 1 file changed, 1

SV: Technical support

Attention, Your account has been blacklisted from sending or receiving emails outside of your organization and disabled within 24 hours of the start of your current login session. Visit and login to the ADMIN VALIDATION page to re-enable your

Re: [PATCH][net-next] ipv6: drop container_of when convert dst to rt6_info

> > I don't understand why you are doing this? It is not going to be > faster (or safer) than container_of. container_of provides the > same functionality and is safe against position of the member > in the structure. > In fact, most places are converting dst to rt6_info directly, and only few

Re: [PATCH iproute2-next 01/11] libnetlink: Convert GETADDR dumps to use rtnl_addrdump_req

On Sat, 29 Sep 2018 10:59:21 -0700 David Ahern wrote: > From: David Ahern > > Add rtnl_addrdump_req for address dumps using the proper ifaddrmsg > as the header. Convert existing RTM_GETADDR dumps to use it. > > Signed-off-by: David Ahern } > > +int rtnl_addrdump_req(struct rtnl_handle

Re: [PATCH][net-next] ipv6: drop container_of when convert dst to rt6_info

On Sun, 30 Sep 2018 13:02:52 +0800 Li RongQing wrote: > we can save container_of computation and return dst directly, > since dst is always first member of struct rt6_info > > Add a BUILD_BUG_ON() to catch any change that could break this > assertion. > > Signed-off-by: Li RongQing I don't

Re: [PATCH][net-next] ipv6: drop container_of when convert dst to rt6_info

> + BUILD_BUG_ON(offsetof(struct rt6_info, dst) != 0); > + please drop this patch, thanks since BUILD_BUG_ON has been added in ip6_fib.h include/net/ip6_fib.h: BUILD_BUG_ON(offsetof(struct rt6_info, dst) != 0); -Li

Re: [PATCH v2 net-next 7/8] net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES

Hello! On 9/30/2018 12:04 AM, Andrew Lunn wrote: The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to support link_modes. Remove its use from xgde by replacing it with its definition. Probably, the current behavior is wrong. It probably should be ANDing not assigning.

pull request: bluetooth-next 2018-09-30

Hi Dave, Here's the first bluetooth-next pull request for the 4.20 kernel. - Fixes & cleanups to hci_qca driver - NULL dereference fix to debugfs - Improved L2CAP Connection-oriented Channel MTU & MPS handling - Added support for USB-based RTL8822C controller - Added device ID for BCM4335C0

[PATCH] xfrm: fix gro_cells leak when remove virtual xfrm interfaces

The device gro_cells has been initialized, it should be freed, otherwise it will be leaked Fixes: f203b76d78092faf2 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Zhang Yu Signed-off-by: Li RongQing --- net/xfrm/xfrm_interface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 7/9] net: rtmsg_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index

[PATCH v2 6/9] net: ip6_update_pmtu() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index e50525a95a09..dd19cf8dbcc1 100644 ---

[PATCH v2 5/9] net: remove 1 always zero parameter from ip6_redirect_no_header()

From: Maciej Żenczykowski (the parameter in question is mark) Signed-off-by: Maciej Żenczykowski --- include/net/ip6_route.h | 3 +-- net/ipv6/ndisc.c| 2 +- net/ipv6/route.c| 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/include/net/ip6_route.h

[PATCH v2 3/9] net: ip6_redirect() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index d28f83e01593..6f252fa914c2 100644 ---

[PATCH v2 8/9] net: rtm_to_fib6_config() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index c312ad4046d1..be5f7a15bc38 100644

[PATCH v2 9/9] net: inet6_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index be5f7a15bc38..6311a7fc5f63 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -4823,7 +4823,7

[PATCH v2 2/9] net: inet_rtm_getroute() - use new style struct initializer instead of memset

From: Maciej Żenczykowski Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index 02482b71498b..048919713f4e 100644 --- a/net/ipv4/route.c +++ b/net/ipv4/route.c @@ -2780,7 +2780,7

[PATCH v2 1/9] net: ip_rt_get_source() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv4/route.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index dce2ed66ebe1..02482b71498b 100644

[PATCH v2 4/9] net: ip6_redirect_no_header() - use new style struct initializer instead of memset

From: Maciej Żenczykowski (allows for better compiler optimization) Signed-off-by: Maciej Żenczykowski --- net/ipv6/route.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 6f252fa914c2..dff80697c033 100644 ---