Re: [PATCH v2 net-next 0/8] Continue towards using linkmode in phylib

2018-10-01 Thread David Miller
From: Andrew Lunn Date: Sat, 29 Sep 2018 23:04:08 +0200 > These patches contain some further cleanup and helpers, and the first > real patch towards using linkmode bitmaps in phylink. > > The macro magic in the RFC version has been replaced with run time > initialisation. Series applied,

Re: [PATCH net-next] nfp: warn on experimental TLV types

2018-10-01 Thread David Miller
From: Jakub Kicinski Date: Wed, 26 Sep 2018 15:35:31 -0700 > Reserve two TLV types for feature development, and warn in the driver > if they ever leak into production. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Simon Horman Applied.

[PATCH v2 net] inet: frags: rework rhashtable dismantle

2018-10-01 Thread Eric Dumazet
syszbot found an interesting use-after-free [1] happening while IPv4 fragment rhashtable was destroyed at netns dismantle. While no insertions can possibly happen at the time a dismantling netns is destroying this rhashtable, timers can still fire and attempt to remove elements from this

Re: pull request: bluetooth 2018-09-27

2018-10-01 Thread David Miller
From: Johan Hedberg Date: Thu, 27 Sep 2018 21:28:40 +0300 > Here's one more Bluetooth fix for 4.19, fixing the handling of an > attempt to unpair a device while pairing is in progress. > > Let me know if there are any issues pulling. Thanks. Pulled, thanks Johan.

Re: [PATCH net-next 2/2] tcp: adjust rcv zerocopy hints based on frag sizes

2018-10-01 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 26 Sep 2018 16:57:04 -0400 > From: Soheil Hassas Yeganeh > > When SKBs are coalesced, we can have SKBs with different > frag sizes. Some with PAGE_SIZE and some not with PAGE_SIZE. > Since recv_skip_hint is always set to the full SKB size, > it can

Re: [PATCH net-next 1/2] tcp: set recv_skip_hint when tcp_inq is less than PAGE_SIZE

2018-10-01 Thread David Miller
From: Soheil Hassas Yeganeh Date: Wed, 26 Sep 2018 16:57:03 -0400 > From: Soheil Hassas Yeganeh > > When we have less than PAGE_SIZE of data on receive queue, > we set recv_skip_hint to 0. Instead, set it to the actual > number of bytes available. > > Signed-off-by: Soheil Hassas Yeganeh >

[RFC v2 bpf-next 2/5] bpf: return EOPNOTSUPP when map lookup isn't supported

2018-10-01 Thread Prashant Bhole
Return ERR_PTR(-EOPNOTSUPP) from map_lookup_elem() methods of below map types: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH Signed-off-by: Prashant Bhole --- kernel/bpf/arraymap.c | 2 +- kernel/bpf/sockmap.c | 2 +-

Re: [net 1/1] tipc: ignore STATE_MSG on wrong link session

2018-10-01 Thread David Miller
From: Jon Maloy Date: Wed, 26 Sep 2018 22:28:52 +0200 > From: LUU Duc Canh > > The initial session number when a link is created is based on a random > value, taken from struct tipc_net->random. It is then incremented for > each link reset to avoid mixing protocol messages from different link

[RFC v2 bpf-next 5/5] selftests/bpf: verifier, check bpf_map_lookup_elem access in bpf prog

2018-10-01 Thread Prashant Bhole
map_lookup_elem isn't supported by certain map types like: - BPF_MAP_TYPE_PROG_ARRAY - BPF_MAP_TYPE_STACK_TRACE - BPF_MAP_TYPE_XSKMAP - BPF_MAP_TYPE_SOCKMAP/BPF_MAP_TYPE_SOCKHASH Let's add verfier tests to check whether verifier prevents bpf_map_lookup_elem call on above programs from bpf program.

[RFC v2 bpf-next 4/5] tools/bpf: bpftool, print strerror when map lookup error occurs

2018-10-01 Thread Prashant Bhole
Since map lookup error can be ENOENT or EOPNOTSUPP, let's print strerror() as error message in normal and JSON output. This patch adds helper function print_entry_error() to print entry from lookup error occurs Example: Following example dumps a map which does not support lookup. Output before:

[RFC v2 bpf-next 3/5] tools/bpf: bpftool, split the function do_dump()

2018-10-01 Thread Prashant Bhole
do_dump() function in bpftool/map.c has deep indentations. In order to reduce deep indent, let's move element printing code out of do_dump() into dump_map_elem() function. Signed-off-by: Prashant Bhole --- tools/bpf/bpftool/map.c | 83 - 1 file changed,

[RFC v2 bpf-next 1/5] bpf: error handling when map_lookup_elem isn't supported

2018-10-01 Thread Prashant Bhole
The error value returned by map_lookup_elem doesn't differentiate whether lookup was failed because of invalid key or lookup is not supported. Lets add handling for -EOPNOTSUPP return value of map_lookup_elem() method of map, with expectation from map's implementation that it should return

[RFC v2 bpf-next 0/5] Error handling when map lookup isn't supported

2018-10-01 Thread Prashant Bhole
Currently when map a lookup fails, user space API can not make any distinction whether given key was not found or lookup is not supported by particular map. In this series we modify return value of maps which do not support lookup. Lookup on such map implementation will return -EOPNOTSUPP. bpf()

Re: [PATCH net] net: sched: act_ipt: check for underflow in __tcf_ipt_init()

2018-10-01 Thread David Miller
From: Dan Carpenter Date: Sat, 22 Sep 2018 16:46:48 +0300 > If "td->u.target_size" is larger than sizeof(struct xt_entry_target) we > return -EINVAL. But we don't check whether it's smaller than > sizeof(struct xt_entry_target) and that could lead to an out of bounds > read. > > Fixes:

Re: [RFC bpf-next 4/4] tools/bpf: handle EOPNOTSUPP when map lookup is failed

2018-10-01 Thread Prashant Bhole
On 9/21/2018 12:59 AM, Jakub Kicinski wrote: On Thu, 20 Sep 2018 14:04:19 +0900, Prashant Bhole wrote: On 9/20/2018 12:29 AM, Jakub Kicinski wrote: On Wed, 19 Sep 2018 16:51:43 +0900, Prashant Bhole wrote: Let's add a check for EOPNOTSUPP error when map lookup is failed. Also in case map

Re: pull request (net-next): ipsec-next 2018-10-01

2018-10-01 Thread David Miller
From: Steffen Klassert Date: Mon, 1 Oct 2018 11:16:06 +0200 > 1) Make xfrmi_get_link_net() static to silence a sparse warning. >From Wei Yongjun. > > 2) Remove a unused esph pointer definition in esp_input(). >From Haishuang Yan. > > 3) Allow the NIC driver to quietly refuse xfrm

Re: pull request (net): ipsec 2018-10-01

2018-10-01 Thread David Miller
From: Steffen Klassert Date: Mon, 1 Oct 2018 10:58:49 +0200 > 1) Validate address prefix lengths in the xfrm selector, >otherwise we may hit undefined behaviour in the >address matching functions if the prefix is too >big for the given address family. > > 2) Fix skb leak on local

Re: [PATCH net v2] net/ncsi: Extend NC-SI Netlink interface to allow user space to send NC-SI command

2018-10-01 Thread Samuel Mendoza-Jonas
On Fri, 2018-09-28 at 18:15 +, justin.l...@dell.com wrote: > The new command (NCSI_CMD_SEND_CMD) is added to allow user space application > to send NC-SI command to the network card. > Also, add a new attribute (NCSI_ATTR_DATA) for transferring request and > response. > > The work flow is

Re: [PATCH net] inet: frags: rework rhashtable dismantle

2018-10-01 Thread Eric Dumazet
On Mon, Oct 1, 2018 at 5:58 PM Herbert Xu wrote: > The walk interface was designed to handle read-only iteration > through the hash table. While this probably works since the > actual freeing is delayed by RCU, it seems to be rather fragile. > > How about using the dead flag but instead of

Re: [PATCH net-next] rtnetlink: fix rtnl_fdb_dump() for shorter family headers

2018-10-01 Thread Mauricio Faria de Oliveira
On Mon, Oct 1, 2018 at 12:38 PM Mauricio Faria de Oliveira wrote: > Ok, thanks for your suggestions. > I'll do some research/learning on them, and give it a try for a v2. FYI, that is "[PATCH v2 net-next] rtnetlink: fix rtnl_fdb_dump() for ndmsg header". BTW, could please advise whether this

[PATCH v2 net-next] rtnetlink: fix rtnl_fdb_dump() for ndmsg header

2018-10-01 Thread Mauricio Faria de Oliveira
Currently, rtnl_fdb_dump() assumes the family header is 'struct ifinfomsg', which is not always true -- 'struct ndmsg' is used by iproute2 ('ip neigh'). The problem is, the function bails out early if nlmsg_parse() fails, which does occur for iproute2 usage of 'struct ndmsg' because the payload

[PATCH bpf-next 0/3] nfp: bpf: support big map entries

2018-10-01 Thread Jakub Kicinski
Hi! This series makes the control message parsing for interacting with BPF maps more flexible. Up until now we had a hard limit in the ABI for key and value size to be 64B at most. Using TLV capability allows us to support large map entries. Jakub Kicinski (3): nfp: bpf: parse global BPF ABI

[PATCH bpf-next 2/3] nfp: allow apps to request larger MTU on control vNIC

2018-10-01 Thread Jakub Kicinski
Some apps may want to have higher MTU on the control vNIC/queue. Allow them to set the requested MTU at init time. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/netronome/nfp/nfp_app.h | 4 .../net/ethernet/netronome/nfp/nfp_net_common.c| 14 -- 2 files

[PATCH bpf-next 1/3] nfp: bpf: parse global BPF ABI version capability

2018-10-01 Thread Jakub Kicinski
Up until now we only had per-vNIC BPF ABI version capabilities, which are slightly awkward to use because bulk of the resources and configuration does not relate to any particular vNIC. Add a new capability for global ABI version and check the per-vNIC version are equal to it. Assume the ABI

[PATCH bpf-next 3/3] nfp: bpf: allow control message sizing for map ops

2018-10-01 Thread Jakub Kicinski
In current ABI the size of the messages carrying map elements was statically defined to at most 16 words of key and 16 words of value (NFP word is 4 bytes). We should not make this assumption and use the max key and value sizes from the BPF capability instead. To make sure old kernels don't get

Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-01 Thread Samuel Mendoza-Jonas
On Fri, 2018-09-28 at 18:06 -0700, Vijay Khemka wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with its > handlers. > > ncsi_cmd_handler_oem: This is a generic command request handler for OEM >

Re: [PATCH net] inet: frags: rework rhashtable dismantle

2018-10-01 Thread Herbert Xu
On Mon, Oct 01, 2018 at 10:58:21AM -0700, Eric Dumazet wrote: > > void inet_frags_exit_net(struct netns_frags *nf) > { > + struct rhashtable_iter hti; > + struct inet_frag_queue *fq; > + > + /* Since we want to cleanup the hashtable, make sure that > + * we wont trigger an

Re: [PATCH iproute2 net-next] ipneigh: update man page and help for router

2018-10-01 Thread David Ahern
On 9/29/18 8:48 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > While at it also add missing text for proxy in the man page. > > Signed-off-by: Roopa Prabhu > --- > ip/ipneigh.c| 1 + > man/man8/ip-neighbour.8 | 11 ++- > 2 files changed, 11 insertions(+), 1 deletion(-)

Re: [PATCH net-next] ipv6: add vrf table handling code for ipv6 mcast

2018-10-01 Thread David Ahern
On 10/1/18 2:41 AM, Mike Manning wrote: > From: Patrick Ruddy > > The code to obtain the correct table for the incoming interface was > missing for IPv6. This has been added along with the table creation > notification to fib rules for the RTNL_FAMILY_IP6MR address family. > > Signed-off-by:

Re: [PATCH net-next] ipv4: Allow sending multicast packets on specific i/f using VRF socket

2018-10-01 Thread David Ahern
On 10/1/18 2:40 AM, Mike Manning wrote: > From: Robert Shearman > > It is useful to be able to use the same socket for listening in a > specific VRF, as for sending multicast packets out of a specific > interface. However, the bound device on the socket currently takes > precedence and results

[PATCH RFC v2 net-next 00/25] rtnetlink: Add support for rigid checking of data in dump request

2018-10-01 Thread David Ahern
From: David Ahern There are many use cases where a user wants to influence what is returned in a dump for some rtnetlink command: one is wanting data for a different namespace than the one the request is received and another is limiting the amount of data returned in the dump to a specific set

[PATCH RFC v2 net-next 19/25] net/bridge: Update br_mdb_dump to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update br_mdb_dump to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have a br_port_msg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended. Signed-off-by:

[PATCH RFC v2 net-next 17/25] net/ipv6: Update ip6addrlbl_dump to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update ip6addrlbl_dump to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifaddrlblmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended.

[PATCH RFC v2 net-next 07/25] rtnetlink: Update rtnl_bridge_getlink to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update rtnl_bridge_getlink to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an

[PATCH RFC v2 net-next 09/25] rtnetlink: Update inet6_dump_ifinfo to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update inet6_dump_ifinfo to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended.

[PATCH RFC v2 net-next 13/25] net/neighbor: Update neigh_dump_info to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update neigh_dump_info to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ndmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute is

[PATCH RFC v2 net-next 03/25] netlink: introduce NLM_F_DUMP_PROPER_HDR flag

2018-10-01 Thread David Ahern
From: David Ahern Add a new flag, NLM_F_DUMP_PROPER_HDR, for userspace to indicate to the kernel that it believes it is sending the right header struct for the dump message type (ifinfomsg, ifaddrmsg, rtmsg, fib_rule_hdr, ...). Setting the flag in the netlink message header indicates to the

[PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs

2018-10-01 Thread David Ahern
From: David Ahern Pull the inet6_fill_args arg up to in6_dump_addrs and move netnsid into it. Since IFA_TARGET_NETNSID is a kernel side filter add the NLM_F_DUMP_FILTERED flag so userspace knows the request was honored. Signed-off-by: David Ahern Acked-by: Christian Brauner ---

[PATCH RFC v2 net-next 14/25] net/neighbor: Update neightbl_dump_info to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update neightbl_dump_info to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ndtmsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended.

[PATCH RFC v2 net-next 08/25] rtnetlink: Update rtnl_stats_dump to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update rtnl_stats_dump to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an if_stats_msg struct as the header. All elements of the struct are expected to be 0 except filter_mask which must be non-0 (legacy

[PATCH RFC v2 net-next 05/25] net/ipv6: Update inet6_dump_addr to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update inet6_dump_addr to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute

[PATCH RFC v2 net-next 04/25] net/ipv4: Update inet_dump_ifaddr to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update inet_dump_ifaddr to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifaddrmsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute

[PATCH RFC v2 net-next 21/25] net/ipv4: Plumb support for filtering route dumps

2018-10-01 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by table id, egress device index, protocol, tos, scope, and route type. Signed-off-by: David Ahern --- include/net/ip_fib.h| 2 +- net/ipv4/fib_frontend.c | 13 - net/ipv4/fib_trie.c | 33

[PATCH RFC v2 net-next 01/25] net/netlink: Pass extack to dump callbacks

2018-10-01 Thread David Ahern
From: David Ahern Pass extack to dump callbacks by adding extack to netlink_dump_control, transferring to netlink_callback and adding to the netlink_dump. Update rtnetlink as the first user. Update netlink_dump to add any message after the dump_done_errno. Signed-off-by: David Ahern ---

[PATCH RFC v2 net-next 18/25] net: Update netconf dump handlers to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update inet_netconf_dump_devconf, inet6_netconf_dump_devconf, and mpls_netconf_dump_devconf to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an netconfmsg struct as the header. The struct only has the

[PATCH RFC v2 net-next 20/25] net: Add struct for fib dump filter

2018-10-01 Thread David Ahern
From: David Ahern Add struct fib_dump_filter for options on limiting which routes are dumped. The current list is table id, tos, protocol, scope, route type, flags and nexthop device index. This patch adds the struct and argument to ip_valid_fib_dump_req so that per-protocol patches can be done

[PATCH RFC v2 net-next 25/25] net: Enable kernel side filtering of route dumps

2018-10-01 Thread David Ahern
From: David Ahern Update parsing of route dump request to enable kernel side of filtering. Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 42 ++ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/net/ipv4/fib_frontend.c

[PATCH RFC v2 net-next 11/25] rtnetlink: Update fib dumps to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Add helper to check netlink message for route dumps. The dump request is expected to have an rtmsg struct as the header. All elements of the struct are expected to be 0 with the exception of rtm_flags (which is used by both ipv4 and ipv6 dumps) and with no attributes can be

[PATCH RFC v2 net-next 12/25] net/neigh: Refactor dump filter handling

2018-10-01 Thread David Ahern
From: David Ahern Move the attribute parsing from neigh_dump_table to neigh_dump_info, and pass the filter arguments down to neigh_dump_table in a new struct. Add the filter option to proxy neigh dumps as well to make the dumps consistent. Signed-off-by: David Ahern --- net/core/neighbour.c |

[PATCH RFC v2 net-next 15/25] net/namespace: Update rtnl_net_dumpid to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update rtnl_net_dumpid to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. The dump request is expected to have an rtgenmsg struct which has the family as the only element. No data may be appended. Signed-off-by: David Ahern --- net/core/net_namespace.c | 8

[PATCH RFC v2 net-next 16/25] net/fib_rules: Update fib_nl_dumprule to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update fib_nl_dumprule to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have fib_rule_hdr struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended.

[PATCH RFC v2 net-next 10/25] rtnetlink: Update ipmr_rtm_dumplink to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update ipmr_rtm_dumplink to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header. All elements of the struct are expected to be 0 and no attributes can be appended.

[PATCH RFC v2 net-next 22/25] net/ipv6: Plumb support for filtering route dumps

2018-10-01 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by table id, egress device index, protocol, and route type. Move the existing route flags check for prefix only routes to the new filter. Signed-off-by: David Ahern --- net/ipv6/ip6_fib.c | 13 + net/ipv6/route.c | 36

[PATCH RFC v2 net-next 24/25] net: Plumb support for filtering ipv4 and ipv6 multicast route dumps

2018-10-01 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by egress device index and table id. Signed-off-by: David Ahern --- include/linux/mroute_base.h | 5 +++-- net/ipv4/ipmr.c | 2 +- net/ipv4/ipmr_base.c| 42 +-

[PATCH RFC v2 net-next 06/25] rtnetlink: Update rtnl_dump_ifinfo to support NLM_F_DUMP_PROPER_HDR

2018-10-01 Thread David Ahern
From: David Ahern Update rtnl_dump_ifinfo to check for NLM_F_DUMP_PROPER_HDR in the netlink message header. If the flag is set, the dump request is expected to have an ifinfomsg struct as the header potentially followed by one or more attributes. Any data passed in the header or as an attribute

[PATCH RFC v2 net-next 23/25] net/mpls: Plumb support for filtering route dumps

2018-10-01 Thread David Ahern
From: David Ahern Implement kernel side filtering of routes by egress device index and protocol. MPLS uses only a single table and route type. Signed-off-by: David Ahern --- net/mpls/af_mpls.c | 55 +- 1 file changed, 54 insertions(+), 1

Re: [RFC PATCH bpf-next v3 4/7] bpf: add bpf queue and stack maps

2018-10-01 Thread Alexei Starovoitov
On Mon, Oct 01, 2018 at 08:11:43AM -0500, Mauricio Vasquez wrote: > > > > +BPF_CALL_3(bpf_map_pop_elem, struct bpf_map *, map, void *, > > > > value, u32, size) > > > > +{ > > > > +    void *ptr; > > > > + > > > > +    if (map->value_size != size) > > > > +    return -EINVAL; > > > > + > > > >

Re: [PATCH v2 net-next 7/8] net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES

2018-10-01 Thread Andrew Lunn
On Sun, Sep 30, 2018 at 11:41:00AM +0300, Sergei Shtylyov wrote: > Hello! > > On 9/30/2018 12:04 AM, Andrew Lunn wrote: > > >The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to > >support link_modes. Remove its use from xgde by replacing it with its > >definition. > > >

Re: [PATCH net-next] tcp: start receiver buffer autotuning sooner

2018-10-01 Thread Yuchung Cheng
On Mon, Oct 1, 2018 at 3:46 PM, David Miller wrote: > From: Yuchung Cheng > Date: Mon, 1 Oct 2018 15:42:32 -0700 > >> Previously receiver buffer auto-tuning starts after receiving >> one advertised window amount of data. After the initial receiver >> buffer was raised by patch a337531b942b

Re: [pull request][net-next 00/13] Mellanox, mlx5e updates 2018-10-01

2018-10-01 Thread David Miller
From: Saeed Mahameed Date: Mon, 1 Oct 2018 11:56:48 -0700 > The following pull request includes updates to mlx5e ethernet netdevice > driver, for more information please see tag log below. > > Please pull and let me know if there's any problem. Pulled, thank you.

Re: [PATCH net-next] tcp: start receiver buffer autotuning sooner

2018-10-01 Thread David Miller
From: Yuchung Cheng Date: Mon, 1 Oct 2018 15:42:32 -0700 > Previously receiver buffer auto-tuning starts after receiving > one advertised window amount of data. After the initial receiver > buffer was raised by patch a337531b942b ("tcp: up initial rmem to > 128KB and SYN rwin to around 64KB"),

Re: [Potential Spoof] Re: [PATCH v2] net/ncsi: Add NCSI OEM command support

2018-10-01 Thread Vijay Khemka
On 9/28/18, 6:21 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: > On 9/28/18, 6:07 PM, "Vijay Khemka" wrote: > This patch adds OEM commands and response handling. It also defines OEM > command and response structure as per NCSI specification along with

Re: [net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-01

2018-10-01 Thread David Miller
From: Jeff Kirsher Date: Mon, 1 Oct 2018 14:14:23 -0700 > This series contains updates to ice driver only. > > Anirudh provides several changes to "prep" the driver for upcoming > features. Specifically, the functions that are used for PF VSI/netdev > setup will also be used in SR-IOV support

Re: [PATCH net] tcp/dccp: fix lockdep issue when SYN is backlogged

2018-10-01 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Oct 2018 15:02:26 -0700 > In normal SYN processing, packets are handled without listener > lock and in RCU protected ingress path. > > But syzkaller is known to be able to trick us and SYN > packets might be processed in process context, after being > queued

[PATCH net-next] tcp: start receiver buffer autotuning sooner

2018-10-01 Thread Yuchung Cheng
Previously receiver buffer auto-tuning starts after receiving one advertised window amount of data. After the initial receiver buffer was raised by patch a337531b942b ("tcp: up initial rmem to 128KB and SYN rwin to around 64KB"), the reciver buffer may take too long to start raising. To address

Re: [PATCH net-next v2] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

2018-10-01 Thread Eric Dumazet
On Mon, Oct 1, 2018 at 3:18 PM Yuchung Cheng wrote: > Hi David: thanks for taking this patch - I didn't notice this earlier > but it seems patch v1 was applied instead of v2? should I submit a > v2-v1-diff patch? Yes, please, send an additional patch.

Re: [PATCH net-next v2] tcp: up initial rmem to 128KB and SYN rwin to around 64KB

2018-10-01 Thread Yuchung Cheng
On Sat, Sep 29, 2018 at 11:23 AM, David Miller wrote: > > From: Yuchung Cheng > Date: Fri, 28 Sep 2018 13:09:02 -0700 > > > Previously TCP initial receive buffer is ~87KB by default and > > the initial receive window is ~29KB (20 MSS). This patch changes > > the two numbers to 128KB and ~64KB

[PATCH net] tcp/dccp: fix lockdep issue when SYN is backlogged

2018-10-01 Thread Eric Dumazet
In normal SYN processing, packets are handled without listener lock and in RCU protected ingress path. But syzkaller is known to be able to trick us and SYN packets might be processed in process context, after being queued into socket backlog. In commit 06f877d613be ("tcp/dccp: fix other lockdep

[net-next 2/8] ice: Move common functions out of ice_main.c part 2/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch continues the code move out of ice_main.c The following top level functions (and related dependency functions) were moved to ice_lib.c: ice_vsi_start_rx_rings ice_vsi_stop_rx_rings ice_vsi_stop_tx_rings ice_vsi_cfg_rxqs ice_vsi_cfg_txqs ice_vsi_cfg_msix

[net-next 7/8] ice: Move common functions out of ice_main.c part 7/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch completes the code move out of ice_main.c The following top level functions and related dependency functions) were moved to ice_lib.c: ice_vsi_setup ice_vsi_cfg_tc The following functions were made static again: ice_vsi_setup_vector_base

[net-next 4/8] ice: Move common functions out of ice_main.c part 4/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch continues the code move out of ice_main.c The following top level functions (and related dependency functions) were moved to ice_lib.c: ice_vsi_alloc_rings ice_vsi_set_rss_params ice_vsi_set_num_qs ice_get_free_slot ice_vsi_init ice_vsi_clear_rings

[net-next 6/8] ice: Move common functions out of ice_main.c part 6/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch continues the code move out of ice_main.c The following top level functions (and related dependency functions) were moved to ice_lib.c: ice_vsi_setup_vector_base ice_vsi_alloc_q_vectors ice_vsi_get_qs The following functions were made static again:

[net-next 5/8] ice: Move common functions out of ice_main.c part 5/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch continues the code move out of ice_main.c The following top level functions (and related dependency functions) were moved to ice_lib.c: ice_vsi_clear ice_vsi_close ice_vsi_free_arrays ice_vsi_map_rings_to_vectors Signed-off-by: Anirudh Venkataramanan

[net-next 0/8][pull request] 100GbE Intel Wired LAN Driver Updates 2018-10-01

2018-10-01 Thread Jeff Kirsher
This series contains updates to ice driver only. Anirudh provides several changes to "prep" the driver for upcoming features. Specifically, the functions that are used for PF VSI/netdev setup will also be used in SR-IOV support and to allow the reuse of these functions, code needs to move. Dave

[net-next 3/8] ice: Move common functions out of ice_main.c part 3/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan This patch continues the code move out of ice_main.c The following top level functions (and related dependency functions) were moved to ice_lib.c: ice_vsi_delete ice_free_res ice_get_res ice_is_reset_recovery_pending ice_vsi_put_qs ice_vsi_dis_irq ice_vsi_free_irq

[net-next 1/8] ice: Move common functions out of ice_main.c part 1/7

2018-10-01 Thread Jeff Kirsher
From: Anirudh Venkataramanan The functions that are used for PF VSI/netdev setup will also be used for SR-IOV support. To allow reuse of these functions, move these functions out of ice_main.c to ice_common.c/ice_lib.c This move is done across multiple patches. Each patch moves a few functions

[net-next 8/8] ice: Change pf state behavior to protect reset path

2018-10-01 Thread Jeff Kirsher
From: Dave Ertman Currently, there is no bit, or set of bits, that protect the entirety of the reset path. If the reset is originated by the driver, then the relevant one of the following bits will be set when the reset is scheduled: __ICE_PFR_REQ __ICE_CORER_REQ __ICE_GLOBR_REQ This bit will

Re: [PATCH bpf-next v2 0/5] xsk: fix bug when trying to use both copy and zero-copy mode

2018-10-01 Thread Jakub Kicinski
On Mon, 1 Oct 2018 14:51:32 +0200, Magnus Karlsson wrote: > Jakub, please take a look at your patches. The last one I had to > change slightly to make it fit with the new interface > xdp_get_umem_from_qid(). An added bonus with this function is that we, > in the future, can also use it from the

[net-next 13/13] net/mlx5: Cache the system image guid

2018-10-01 Thread Saeed Mahameed
From: Alaa Hleihel The system image guid is a read-only field which is used by the TC offloads code to determine if two mlx5 devices belong to the same ASIC while adding flows. Read this once and save it on the core device rather than querying each time an offloaded flow is added.

[net-next 10/13] net/mlx5e: Add ethtool control of ring params to VF representors

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Added ethtool control to the representors for setting and querying the ring params. Signed-off-by: Gavi Teitz Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

[net-next 12/13] net/mlx5e: Allow reporting of checksum unnecessary

2018-10-01 Thread Saeed Mahameed
From: Or Gerlitz Currently we practically never report checksum unnecessary, because for all IP packets we take the checksum complete path. Enable non-default runs with reprorting checksum unnecessary, using an ethtool private flag. This can be useful for performance evals and other

[net-next 02/13] net/mlx5e: Change VF representors' RQ type

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz The representors' RQ size was not large enough for them to achieve high enough performance, and therefore needed to be enlarged, while suffering a minimum hit to its memory usage. To achieve this the representors RQ size was increased, and its type was changed to be a striding

[net-next 09/13] net/mlx5e: Enable multi-queue and RSS for VF representors

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Increased the amount of channels the representors can open to be the amount of CPUs. The default amount opened remains one. Used the standard NIC netdev functions to: * Set RSS params when building the representors' params. * Setup an indirect TIR and RQT for the representors

[net-next 06/13] net/mlx5e: Provide explicit directive if to create inner indirect tirs

2018-10-01 Thread Saeed Mahameed
From: Or Gerlitz Change the driver functions that deal with creating indirect tirs to get a flag telling if inner ttc is desired. A pre-step for enabling rss on the vport representors, where inner ttc is not needed. Signed-off-by: Or Gerlitz Reviewed-by: Or Gerlitz Signed-off-by: Saeed

[net-next 11/13] net/mlx5e: Enable reporting checksum unnecessary also for L3 packets

2018-10-01 Thread Saeed Mahameed
From: Or Gerlitz We can report checksum unnecessary also when the L3 checksum flag on the cqe is set and there's no L4 header. Signed-off-by: Or Gerlitz Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_rx.c | 3 ++- 1 file changed, 2

[net-next 08/13] net/mlx5e: Expose ethtool rss key size / indirection table functions

2018-10-01 Thread Saeed Mahameed
From: Or Gerlitz Towards enabling RSS for the vport representors, expose the functions for querying the rss hash key size and indirection table size via ethtool. Signed-off-by: Or Gerlitz Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h

[net-next 07/13] net/mlx5e: Expose function for building RSS params

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Towards enabling RSS for the vport representors, extract the procedure for building a device's RSS params, and expose the function. Signed-off-by: Gavi Teitz Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 +

[pull request][net-next 00/13] Mellanox, mlx5e updates 2018-10-01

2018-10-01 Thread Saeed Mahameed
Hi Dave, The following pull request includes updates to mlx5e ethernet netdevice driver, for more information please see tag log below. Please pull and let me know if there's any problem. Thanks, Saeed. --- The following changes since commit 804fe108fc92e591ddfe9447e7fb4691ed16daee:

[net-next 05/13] net/mlx5: E-Switch, Provide flow dest when creating vport rx rule

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Currently the destination for the representor e-switch rx rule is a TIR number. Towards changing that to potentially be a flow table, as part of enabling RSS for representors, modify the signature of the related e-switch API to get a flow destination. Signed-off-by: Gavi Teitz

[net-next 04/13] net/mlx5e: Extract creation of rep's default flow rule

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Cleaning up the flow of the representors' rx initialization, towards enabling RSS for the representors. Signed-off-by: Gavi Teitz Reviewed-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 25 --- 1 file

[net-next 01/13] net/mlx5e: Ethtool steering, Support masks for l3/l4 filters

2018-10-01 Thread Saeed Mahameed
From: Or Gerlitz Allow using partial masks for L3 addresses and L4 ports across the place. Signed-off-by: Or Gerlitz Signed-off-by: Saeed Mahameed --- .../mellanox/mlx5/core/en_fs_ethtool.c| 56 ++- 1 file changed, 16 insertions(+), 40 deletions(-) diff --git

[net-next 03/13] net/mlx5e: Enable stateless offloads for VF representor netdevs

2018-10-01 Thread Saeed Mahameed
From: Gavi Teitz Enabled checksum and TSO offloads for the representors, in order to increase their performance, which is required to increase the performance of flows that cannot be offloaded. Checksum offloads contribute to a general acceleration of all traffic (to around 150%), whereas the

Re: [bpf-next PATCH 1/3] net: fix generic XDP to handle if eth header was mangled

2018-10-01 Thread Daniel Borkmann
[ ping to Jesper wrt feedback ] On 09/26/2018 07:36 AM, Song Liu wrote: > On Tue, Sep 25, 2018 at 7:26 AM Jesper Dangaard Brouer > wrote: >> >> XDP can modify (and resize) the Ethernet header in the packet. >> >> There is a bug in generic-XDP, because skb->protocol and skb->pkt_type >> are setup

Re: [PATCH 0/3] bpf: allow zero-initialising hash map seed

2018-10-01 Thread Daniel Borkmann
On 10/01/2018 12:45 PM, Lorenz Bauer wrote: > This patch set adds a new flag BPF_F_ZERO_SEED, which allows > forcing the seed used by hash maps to zero. This makes > it possible to write deterministic tests. > > Based on an off-list conversation with Alexei Starovoitov and > Daniel Borkmann. > >

Re: [RFC PATCH ethtool] ethtool: better syntax for combinations of FEC modes

2018-10-01 Thread John W. Linville
Is this patch still RFC? On Wed, Sep 19, 2018 at 05:06:25PM +0100, Edward Cree wrote: > Instead of commas, just have them as separate argvs. > > The parsing state machine might look heavyweight, but it makes it easy to add > more parameters later and distinguish parameter names from encoding

Re: [PATCH net-next] tls: Add support for inplace records encryption

2018-10-01 Thread Dave Watson
On 09/30/18 08:04 AM, Vakul Garg wrote: > Presently, for non-zero copy case, separate pages are allocated for > storing plaintext and encrypted text of records. These pages are stored > in sg_plaintext_data and sg_encrypted_data scatterlists inside record > structure. Further, sg_plaintext_data &

Re: [PATCH net-next v1 0/1] net/sched: Introduce the taprio scheduler

2018-10-01 Thread Vinicius Costa Gomes
Hi, Just a small correction, one link on the cover letter is wrong. Vinicius Costa Gomes writes: [...] > > > [1] https://patchwork.ozlabs.org/cover/938991/ > > [2] https://patchwork.ozlabs.org/cover/808504/ > > [3] github doesn't make it clear, but the gist can be cloned like this: > $ git

[PATCH net] inet: frags: rework rhashtable dismantle

2018-10-01 Thread Eric Dumazet
syszbot found an interesting use-after-free [1] happening while IPv4 fragment rhashtable was destroyed at netns dismantle. While no insertions can possibly happen at the time a dismantling netns is destroying this rhashtable, timers can still fire and attempt to remove elements from this

[net 3/3] net/mlx5e: Set vlan masks for all offloaded TC rules

2018-10-01 Thread Saeed Mahameed
From: Jianbo Liu In flow steering, if asked to, the hardware matches on the first ethertype which is not vlan. It's possible to set a rule as follows, which is meant to match on untagged packet, but will match on a vlan packet: tc filter add dev eth0 parent : protocol ip flower ... To

[net 2/3] net/mlx5: E-Switch, Fix out of bound access when setting vport rate

2018-10-01 Thread Saeed Mahameed
From: Eran Ben Elisha The code that deals with eswitch vport bw guarantee was going beyond the eswitch vport array limit, fix that. This was pointed out by the kernel address sanitizer (KASAN). The error from KASAN log: [2018-09-15 15:04:45] BUG: KASAN: slab-out-of-bounds in

  1   2   >