Re: Fw: [Bug 201423] New: eth0: hw csum failure

2018-11-03 Thread Andre Tomt
On 31.10.2018 05:08, Andre Tomt wrote: On 30.10.2018 12:04, Andre Tomt wrote: On 30.10.2018 11:58, Andre Tomt wrote: On 27.10.2018 23:41, Andre Tomt wrote: On 26.10.2018 13:45, Andre Tomt wrote: On 25.10.2018 19:38, Eric Dumazet wrote: On 10/24/2018 12:41 PM, Andre Tomt wrote: It eventua

Re: [PATCH net] mlxsw: spectrum: Fix IP2ME CPU policer configuration

2018-11-03 Thread David Miller
From: Ido Schimmel Date: Fri, 2 Nov 2018 19:49:15 + > From: Shalom Toledo > > The CPU policer used to police packets being trapped via a local route > (IP2ME) was incorrectly configured to police based on bytes per second > instead of packets per second. > > Change the policer to police ba

Re: [PATCH net] sctp: define SCTP_SS_DEFAULT for Stream schedulers

2018-11-03 Thread David Miller
From: Xin Long Date: Sat, 3 Nov 2018 14:01:31 +0800 > According to rfc8260#section-4.3.2, SCTP_SS_DEFAULT is required to > defined as SCTP_SS_FCFS or SCTP_SS_RR. > > SCTP_SS_FCFS is used for SCTP_SS_DEFAULT's value in this patch. > > Fixes: 5e32a431 ("sctp: introduce stream scheduler found

Re: [PATCH net] sctp: fix strchange_flags name for Stream Change Event

2018-11-03 Thread David Miller
From: Xin Long Date: Sat, 3 Nov 2018 13:59:45 +0800 > As defined in rfc6525#section-6.1.3, SCTP_STREAM_CHANGE_DENIED > and SCTP_STREAM_CHANGE_FAILED should be used instead of > SCTP_ASSOC_CHANGE_DENIED and SCTP_ASSOC_CHANGE_FAILED. > > To keep the compatibility, fix it by adding two macros. >

Re: [PATCH net] net-sysfs: fix formatting of tx_timeout attribute

2018-11-03 Thread David Miller
From: Julian Wiedmann Date: Fri, 2 Nov 2018 19:33:17 +0100 > Add a missing newline. > > Signed-off-by: Julian Wiedmann > --- > net/core/net-sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c > index bd67c4d0fcfd..ef064

Re: [PATCH v3 1/2] kretprobe: produce sane stack traces

2018-11-03 Thread Masami Hiramatsu
On Sat, 3 Nov 2018 13:30:21 -0400 Steven Rostedt wrote: > On Sun, 4 Nov 2018 01:34:30 +0900 > Masami Hiramatsu wrote: > > > > > I was thinking of a bitmask that represents the handlers, and use that > > > to map which handler gets called for which shadow entry for a > > > particular task. > >

Re: [RFC PATCH] net/mlx5e: Temp software stats variable is not required

2018-11-03 Thread David Miller
From: Saeed Mahameed Date: Fri, 2 Nov 2018 18:54:22 -0700 > +static void mlx5e_fold_sw_stats(struct mlx5e_priv *priv, struct > rtnl_link_stats64 *s) > +{ > + int i; > + > + /* not required ? */ > + memset(s, 0, sizeof(*s)); Why wouldn't this be required? I can see that perhaps you

Re: [PATCH] openvswitch: fix linking without CONFIG_NF_CONNTRACK_LABELS

2018-11-03 Thread David Miller
From: Arnd Bergmann Date: Fri, 2 Nov 2018 16:36:55 +0100 > When CONFIG_CC_OPTIMIZE_FOR_DEBUGGING is enabled, the compiler > fails to optimize out a dead code path, which leads to a link failure: > > net/openvswitch/conntrack.o: In function `ovs_ct_set_labels': > conntrack.c:(.text+0x2e60): unde

Re: [PATCH] qed: fix link config error handling

2018-11-03 Thread David Miller
From: Arnd Bergmann Date: Fri, 2 Nov 2018 16:36:24 +0100 > gcc-8 notices that qed_mcp_get_transceiver_data() may fail to > return a result to the caller: > > drivers/net/ethernet/qlogic/qed/qed_mcp.c: In function > 'qed_mcp_trans_speed_mask': > drivers/net/ethernet/qlogic/qed/qed_mcp.c:1955:2:

Re: pull-request: bpf 2018-11-03

2018-11-03 Thread David Miller
From: Daniel Borkmann Date: Sat, 3 Nov 2018 01:47:03 +0100 > The following pull-request contains BPF updates for your *net* tree. > > The main changes are: > > 1) Fix BPF prog kallsyms and bpf_prog_get_info_by_fd() jited address export >to not use page start but actual start instead to wor

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread David Miller
From: Eric Dumazet Date: Sat, 3 Nov 2018 16:00:39 -0700 > On Sat, Nov 3, 2018 at 3:40 PM David Miller wrote: > >> Series applied, but I wonder how many other commonly used drivers we >> should update the same way mlx4 is here? > > I can provide patches but can not test them, so probably we sho

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Paweł Staszewski
n W dniu 03.11.2018 o 18:32, David Ahern pisze: On 11/1/18 11:30 AM, Paweł Staszewski wrote: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/samples/bpf/xdp_fwd_kern.c I can try some tests on same hw but testlab configuration - will give it a try :) That version

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread Eric Dumazet
On Sat, Nov 3, 2018 at 3:40 PM David Miller wrote: > Series applied, but I wonder how many other commonly used drivers we > should update the same way mlx4 is here? I can provide patches but can not test them, so probably we should get Tested-by tags before applying them. Thanks.

Re: [PATCH v2 net 0/3] net: bql: better deal with GSO

2018-11-03 Thread David Miller
From: Eric Dumazet Date: Wed, 31 Oct 2018 08:39:11 -0700 > While BQL bulk dequeue works well for TSO packets, it is > not very efficient as soon as GSO is involved. > > On a GSO only workload (UDP or TCP), this patch series > can save about 8 % of cpu cycles on a 40Gbit mlx4 NIC, > by keeping op

Re: [PATCH net 0/6] s390/qeth: fixes 2018-11-02

2018-11-03 Thread David Miller
From: Julian Wiedmann Date: Fri, 2 Nov 2018 19:04:07 +0100 > please apply one round of qeth fixes for -net. > > Patch 1 is rather large and removes a use-after-free hazard from many of our > debug trace entries. > Patch 2 is yet another fix-up for the L3 subdriver's new IP address management >

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread David Ahern
On 11/1/18 11:30 AM, Paweł Staszewski wrote:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/samples/bpf/xdp_fwd_kern.c >>> I can try some tests on same hw but testlab configuration - will give it >>> a try :) >>> >> That version does not work with VLAN

SACK compression patch causing performance drop

2018-11-03 Thread Jean-Louis Dupond
Hi All, On recent kernels we noticed a way lower throughput to our SAN system than before. While on pre 4.18 kernels we had 400-700MB/sec read speed, on 4.18+ we only had 70-120MB/sec. The SAN is connected via iSCSI over a 10G network (ixgbe/X520 NICS if it matters). After some debugging,

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Paweł Staszewski
W dniu 03.11.2018 o 16:23, Paweł Staszewski pisze: W dniu 03.11.2018 o 13:58, Jesper Dangaard Brouer pisze: On Sat, 3 Nov 2018 01:16:08 +0100 Paweł Staszewski wrote: W dniu 02.11.2018 o 20:02, Paweł Staszewski pisze: W dniu 02.11.2018 o 15:20, Aaron Lu pisze: On Fri, Nov 02, 2018 at 12

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Paweł Staszewski
W dniu 03.11.2018 o 13:58, Jesper Dangaard Brouer pisze: On Sat, 3 Nov 2018 01:16:08 +0100 Paweł Staszewski wrote: W dniu 02.11.2018 o 20:02, Paweł Staszewski pisze: W dniu 02.11.2018 o 15:20, Aaron Lu pisze: On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: On Fri

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Jesper Dangaard Brouer
On Sat, 3 Nov 2018 01:16:08 +0100 Paweł Staszewski wrote: > W dniu 02.11.2018 o 20:02, Paweł Staszewski pisze: > > > > > > W dniu 02.11.2018 o 15:20, Aaron Lu pisze: > >> On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: > >>> On Fri, 2 Nov 2018 13:23:56 +0800 > >>> Aaro

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Jesper Dangaard Brouer
On Fri, 2 Nov 2018 22:20:24 +0800 Aaron Lu wrote: > On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: > > On Fri, 2 Nov 2018 13:23:56 +0800 > > Aaron Lu wrote: > > > > > On Thu, Nov 01, 2018 at 08:23:19PM +, Saeed Mahameed wrote: > > > > On Thu, 2018-11-01 at 23:

Re: Kernel 4.19 network performance - forwarding/routing normal users traffic

2018-11-03 Thread Paweł Staszewski
W dniu 03.11.2018 o 01:16, Paweł Staszewski pisze: W dniu 02.11.2018 o 20:02, Paweł Staszewski pisze: W dniu 02.11.2018 o 15:20, Aaron Lu pisze: On Fri, Nov 02, 2018 at 12:40:37PM +0100, Jesper Dangaard Brouer wrote: On Fri, 2 Nov 2018 13:23:56 +0800 Aaron Lu wrote: On Thu, Nov 01, 2

Re: Help with the BPF verifier

2018-11-03 Thread Arnaldo Carvalho de Melo
Em Sat, Nov 03, 2018 at 08:29:34AM -0300, Arnaldo Carvalho de Melo escreveu: > PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT: > Preprocessed source(s) and associated run script(s) are located at: > clang-7: note: diagnostic msg: /tmp/augmented_raw_syscalls-7444d9.c > clang-7: note: diagnostic

Re: Help with the BPF verifier

2018-11-03 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 02, 2018 at 03:42:49PM +, Edward Cree escreveu: > On 02/11/18 15:02, Arnaldo Carvalho de Melo wrote: > > Yeah, didn't work as well: > > > And the -vv in 'perf trace' didn't seem to map to further details in the > > output of the verifier debug: > Yeah for log_level 2 you probably

Re: [PATCH net 0/2] net: timeout fixes for GENET and SYSTEMPORT

2018-11-03 Thread David Miller
From: Florian Fainelli Date: Thu, 1 Nov 2018 15:55:36 -0700 > This patch series fixes occasional transmit timeout around the time > the system goes into suspend. GENET and SYSTEMPORT have nearly the same > logic in that regard and were both affected in the same way. Series applied. > Please qu