>- Original Message -
>Sender : Eric Dumazet
>Date : 2018-11-08 15:13 (GMT+9)
>Title : Re: (2) (2) [Kernel][NET] Bug report on packet defragmenting
>
>On 11/07/2018 08:26 PM, Eric Dumazet wrote:
>>
>>
>> On 11/07/2018 08:10 PM, 배석진 wrote:
- Original Message -
On 2018/11/8 15:44, Rafael J. Wysocki wrote:
> On Thursday, November 8, 2018 8:22:16 AM CET Wang Dongsheng wrote:
>> Add support for parsing the ACPI data node for PHY devices on an MDIO bus.
>> The current implementation depend on mdio bus scan.
>> With _DSD device properties we can finally do thi
On Thursday, November 8, 2018 8:22:16 AM CET Wang Dongsheng wrote:
> Add support for parsing the ACPI data node for PHY devices on an MDIO bus.
> The current implementation depend on mdio bus scan.
> With _DSD device properties we can finally do this:
>
> Device (MDIO) {
> Name (_DSD,
On Fri, Oct 26, 2018 at 10:30:54AM +0800, Hangbin Liu wrote:
> Currently we only set mc_qrv to sysctl_mld_qrv when interface up. If we
> change sysctl_mld_qrv after interface up, it will has no effect.
>
> Fix it by assigning latest sysctl_mld_qrv to idev mc_qrv when join new group.
>
> Reported-
Use "phy-handle" to point to an internal MDIO device port.
Signed-off-by: Wang Dongsheng
---
drivers/net/ethernet/qualcomm/emac/emac-mac.c | 19 ++---
drivers/net/ethernet/qualcomm/emac/emac-phy.c | 78 ++-
2 files changed, 70 insertions(+), 27 deletions(-)
diff --git a/drivers/
Add support for parsing the ACPI data node for PHY devices on an MDIO bus.
The current implementation depend on mdio bus scan.
With _DSD device properties we can finally do this:
Device (MDIO) {
Name (_DSD, Package () {
ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"),
Originally I just push "phy-handle" support for ACPI on the QCOM QDF2400
platform. After some discussion and following Andrew's advice, I send
out with a generic version of ACPI.
Current there is no clear documentation about MDIO/PHY for ACPI, so when
I reading some documents about ACPI [1], I thi
This patch separate emac_mdio_bus_create and emac_get_phydev from
emac_phy_config, and do some codes clean.
Signed-off-by: Wang Dongsheng
---
drivers/net/ethernet/qualcomm/emac/emac-phy.c | 96 +++
1 file changed, 56 insertions(+), 40 deletions(-)
diff --git a/drivers/net/ethern
On 07.11.2018 21:45, Heiner Kallweit wrote:
> On 07.11.2018 21:21, Andrew Lunn wrote:
>> On Wed, Nov 07, 2018 at 09:05:49PM +0100, Heiner Kallweit wrote:
>>> On 07.11.2018 20:48, Andrew Lunn wrote:
On Wed, Nov 07, 2018 at 08:41:52PM +0100, Heiner Kallweit wrote:
> This patch series is base
From: Jeff Kirsher
Date: Wed, 7 Nov 2018 14:48:18 -0800
> This series contains updates to almost all of the Intel wired LAN
> drivers.
...
> The following are changes since commit
> 7c588c7468ea3f9b2fc8fa6840bed6262b5d1b00:
> Merge branch 'net-systemport-Unmap-queues-upon-DSA-unregister-even
From: John Hurley
Date: Wed, 7 Nov 2018 18:32:47 +
> A recent patch introduced the function netif_is_vxlan() to verify the
> tunnel type of a given netdev as vxlan.
>
> Add a similar function to detect geneve netdevs and make use of this
> function in the NFP driver. Also make use of the vx
avoid to compute the hash value if dev is not null, since
hash value is not used
Signed-off-by: Li RongQing
---
net/ipv6/anycast.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/anycast.c b/net/ipv6/anycast.c
index 94999058e110..cca3b3603c42 100644
--- a/net/i
From: Edward Cree
Date: Wed, 7 Nov 2018 18:12:42 +
> Expose the MUM/SUC Firmware, UEFI Expansion ROM and MC Status partitions
> of the NIC's NVRAM as MTDs if found on the NIC. The first two are needed
> in order to properly update them when performing firmware updates; the MC
> Status par
On Thu, Nov 08, 2018 at 06:05:26AM +, Kevin Easton wrote:
> On Wed, Nov 07, 2018 at 02:48:24PM -0800, Jeff Kirsher wrote:
> > From: Todd Fujinaka
> >
> > There's a new flag for setting WoL filters that is only
> > enabled on one manufacturer's NICs, and it's not ours. Fail
> > with EOPNOTSUPP
From: Michał Mirosław
Date: Wed, 07 Nov 2018 18:07:02 +0100
> This is a preparatory patchset before removing the use of VLAN_TAG_PRESENT
> bit in skb->vlan_tci as indication of VLAN offload. This set includes
> only cleanups that allow abstracting of code testing VLAN tag presence
> in drivers an
From: Michał Mirosław
Date: Wed, 07 Nov 2018 17:50:53 +0100
> VLAN.TCI == 0 is perfectly valid (802.1p), so allow it to be accelerated.
>
> Signed-off-by: Michał Mirosław
Applied.
From: Michał Mirosław
Date: Wed, 07 Nov 2018 17:50:52 +0100
> Don't request tag insertion when it isn't present in outgoing skb.
>
> Signed-off-by: Michał Mirosław
Applied and queued up for -stable.
From: Kuninori Morimoto
This patch updates license to use SPDX-License-Identifier
instead of verbose license text.
Signed-off-by: Kuninori Morimoto
Acked-by: Ramesh Shanmugasundaram
---
drivers/net/can/rcar/Kconfig | 1 +
drivers/net/can/rcar/Makefile | 1 +
drivers/net/can/rcar/rc
From: Madalin Bucur
Date: Wed, 7 Nov 2018 15:53:43 +0200
> +static int dpaa_set_coalesce(struct net_device *dev,
> + struct ethtool_coalesce *c)
> +{
> + const cpumask_t *cpus = qman_affine_cpus();
> + struct qman_portal *portal;
> + u32 period;
> + u8 th
From: Paolo Abeni
Date: Wed, 7 Nov 2018 10:34:36 +0100
> The tun XDP sendmsg code path, unconditionally computes the symmetric
> hash of each packet for RFS's sake, even when we could skip it. e.g.
> when the device has a single queue.
>
> This change adds the check already in-place for the skb
From: Davide Caratti
Date: Wed, 7 Nov 2018 11:28:18 +0100
> GSO tunneled packets are always segmented in software before they are
> transmitted by a VLAN, even when the lower device can offload tunnel
> encapsulation and VLAN together (i.e., some bits in NETIF_F_GSO_ENCAP_ALL
> mask are set in t
From: Heiner Kallweit
Date: Wed, 7 Nov 2018 08:15:58 +0100
> phy_trigger_machine() is used in phy.c only, so we can make it static.
>
> Signed-off-by: Heiner Kallweit
Applied.
From: Heiner Kallweit
Date: Wed, 7 Nov 2018 08:52:46 +0100
> Instead of listing every single PHYID, load the driver for every PHYID
> with a Realtek OUI, independent of model number and revision.
>
> This patch also improves two further aspects:
> - constify realtek_tbl[]
> - the mask should hav
On 11/07/2018 08:26 PM, Eric Dumazet wrote:
>
>
> On 11/07/2018 08:10 PM, 배석진 wrote:
>>> - Original Message -
>>> Sender : Eric Dumazet
>>> Date : 2018-11-08 12:57 (GMT+9)
>>> Title : Re: (2) [Kernel][NET] Bug report on packet defragmenting
>>>
>>> On 11/07/2018 07:24 PM,
On Wed, Nov 07, 2018 at 02:48:24PM -0800, Jeff Kirsher wrote:
> From: Todd Fujinaka
>
> There's a new flag for setting WoL filters that is only
> enabled on one manufacturer's NICs, and it's not ours. Fail
> with EOPNOTSUPP.
>
> Signed-off-by: Todd Fujinaka
> Tested-by: Andrew Bowers
> Signed-
Multiple cpus might attempt to insert a new fragment in rhashtable,
if for example RPS is buggy, as reported by 배석진in
https://patchwork.ozlabs.org/patch/994601/
We use rhashtable_lookup_get_insert_key() instead of
rhashtable_insert_fast() to let cpus losing the race
free their own inet_frag_queue
From: Ioana Ciocoi Radulescu
Date: Wed, 7 Nov 2018 10:31:16 +
> We chose this mechanism over BQL (to which it is conceptually
> very similar) because a) we can take advantage of the hardware
> offloading and b) BQL doesn't match well with our driver fastpath
> (we process ingress (Rx or Tx co
On 11/07/2018 08:55 PM, David Barmann wrote:
> When setting the SO_MARK socket option, the dst needs to be reset so
> that a new route lookup is performed.
>
> This fixes the case where an application wants to change routing by
> setting a new sk_mark. If this is done after some packets have a
From: "Maciej W. Rozycki"
Date: Wed, 7 Nov 2018 12:06:46 + (GMT)
> Here is a bunch of small fixes addressing issues that I missed in my
> final round of testing. None of these affect run-time behaviour. One was
> actually found by the kbuild bot, which turned out to be more pedantic
> t
From: Florian Fainelli
Date: Tue, 6 Nov 2018 16:37:44 -0800
> From: Justin Chen
>
> Add support for BCM7255 EPHY.
>
> Signed-off-by: Justin Chen
> Signed-off-by: Florian Fainelli
Applied, thanks Florian.
From: Li RongQing
Date: Thu, 8 Nov 2018 13:35:40 +0800
> avoid to compute the hash value if dev is not null, since
> hash value is not used
>
> Signed-off-by: Li RongQing
> ---
> net/ipv6/anycast.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv6/anycas
Makes it compatible with the logic that derives program type
from section name in libbpf_prog_type_by_name.
Signed-off-by: Stanislav Fomichev
---
tools/testing/selftests/bpf/bpf_flow.c | 2 +-
tools/testing/selftests/bpf/test_flow_dissector.sh | 2 +-
2 files changed, 2 insertions(+)
v3 changes:
* (maybe) better cleanup for partial failure in bpf_object__pin
* added special case in bpf_program__pin for programs with single
instances
v2 changes:
* addressed comments/style issues from Jakub Kicinski & Quentin Monnet
* removed logic that populates jump table
* added cleanup for
This commit adds support for loading/attaching/detaching flow
dissector program. The structure of the flow dissector program is
assumed to be the same as in the selftests:
* flow_dissector section with the main entry point
* a bunch of tail call progs
* a jmp_table map that is populated with the t
When bpf_program has only one instance, don't create a subdirectory with
per-instance pin files (/0). Instead, just create a single pin file
for that single instance. This simplifies object pinning by not creating
unnecessary subdirectories.
This can potentially break existing users that depend on
bpftool will use bpf_object__pin in the next commit to pin all programs
and maps from the file; in case of a partial failure, we need to get
back to the clean state (undo previous program/map pins).
Signed-off-by: Stanislav Fomichev
---
tools/lib/bpf/libbpf.c | 248 ++
avoid to compute the hash value if dev is not null, since
hash value is not used
Signed-off-by: Li RongQing
---
net/ipv6/anycast.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/net/ipv6/anycast.c b/net/ipv6/anycast.c
index 94999058e110..a20e344486cb 100644
--- a/net/i
When setting the SO_MARK socket option, the dst needs to be reset so
that a new route lookup is performed.
This fixes the case where an application wants to change routing by
setting a new sk_mark. If this is done after some packets have already
been sent, the dst is cached and has no effect.
Si
On 11/07/2018 08:10 PM, 배석진 wrote:
>> - Original Message -
>> Sender : Eric Dumazet
>> Date : 2018-11-08 12:57 (GMT+9)
>> Title : Re: (2) [Kernel][NET] Bug report on packet defragmenting
>>
>> On 11/07/2018 07:24 PM, Eric Dumazet wrote:
>>
>>> Sure, it is better if RPS is
> - Original Message -
> Sender : Eric Dumazet
> Date : 2018-11-08 12:57 (GMT+9)
> Title : Re: (2) [Kernel][NET] Bug report on packet defragmenting
>
> On 11/07/2018 07:24 PM, Eric Dumazet wrote:
>
> > Sure, it is better if RPS is smarter, but if there is a bug in IPv6 defrag
On 11/07/2018 07:24 PM, Eric Dumazet wrote:
> Sure, it is better if RPS is smarter, but if there is a bug in IPv6 defrag
> unit
> we must investigate and root-cause it.
BTW, IPv4 defrag seems to have the same issue.
Commit f6f3bac08ff9 ("tools/bpf: bpftool: add net support")
added certain networking support to bpftool.
The implementation relies on a relatively recent uapi header file
linux/tc_act/tc_bpf.h on the host which contains the marco
definition of TCA_ACT_BPF_ID.
Unfortunately, this is not the case fo
On 11/07/2018 06:05 PM, 배석진 wrote:
> - Original Message -
> Sender : Eric Dumazet
> Date : 2018-11-08 10:44 (GMT+9)
> Title : Re: [Kernel][NET] Bug report on packet defragmenting
>
>> On 11/07/2018 05:29 PM, 배석진 wrote:
>>
>>> If ipv6_defrag hook is not excuted simultaneo
On Thu, 2018-11-08 at 02:04 +, YueHaibing wrote:
> There is no need to have the '__be32 *p' variable static since new
> value
> always be assigned before use it.
>
> Signed-off-by: YueHaibing
> ---
> net/sunrpc/xdr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/n
Added support for filtering based on port ranges.
Example:
1. Match on a port range:
-
$ tc filter add dev enp4s0 protocol ip parent :\
prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\
action drop
$ tc -s filter show dev enp4s0 parent :
filter protocol
Added support in tc flower for filtering based on port ranges.
Example:
1. Match on a port range:
-
$ tc filter add dev enp4s0 protocol ip parent :\
prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\
action drop
$ tc -s filter show dev enp4s0 parent :
fil
- Original Message -
Sender : Eric Dumazet
Date : 2018-11-08 10:44 (GMT+9)
Title : Re: [Kernel][NET] Bug report on packet defragmenting
> On 11/07/2018 05:29 PM, 배석진 wrote:
>
> > If ipv6_defrag hook is not excuted simultaneously, then it's ok.
> > ipv6_defrag hook can handl
There is no need to have the '__be32 *p' variable static since new value
always be assigned before use it.
Signed-off-by: YueHaibing
---
net/sunrpc/xdr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
index 2bbb8d3..d80b156 100644
--- a/ne
On 10/19/2018 1:52 AM, Jiri Pirko wrote:
> Thu, Oct 18, 2018 at 08:24:44PM CEST, amritha.namb...@intel.com wrote:
>> On 10/18/2018 5:17 AM, Jiri Pirko wrote:
>>> Fri, Oct 12, 2018 at 03:53:30PM CEST, amritha.namb...@intel.com wrote:
Added support in tc flower for filtering based on port ranges
On 11/7/18 5:15 PM, Li Zhijian wrote:
> On 11/8/2018 9:00 AM, Yonghong Song wrote:
>> Commit f6f3bac08ff9 ("tools/bpf: bpftool: add net support")
>> added certain networking support to bpftool.
>> The implementation relies on a relatively recent uapi header file
>> linux/tc_act/tc_bpf.h on the ho
On 11/07/2018 05:29 PM, 배석진 wrote:
> If ipv6_defrag hook is not excuted simultaneously, then it's ok.
> ipv6_defrag hook can handle that. [exam 3]
This seems wrong.
This is the root cause, we should not try to work around it but fix it.
There is no guarantee that RSS/RPS/RFS can help here, p
Move destroying of the old child qdiscs outside of the sch_tree_lock()
section. This should improve the software qdisc replace but is even
more important for offloads. Calling offloads under a spin lock is
best avoided, and child's destroy would be called under sch_tree_lock().
Signed-off-by: Ja
Hi!
This series refactors the "switchdev" Qdisc offloads a little. We have
a few Qdiscs which can be fully offloaded today to the forwarding plane
of switching devices.
First patch adds a helper for handing statistic dumps, the code seems
to be copy pasted between PRIO and RED. Second patch rem
Offload dump helper does not use opt parameter, remove it.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
net/sched/sch_red.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_red.c b/net/sched/sch_red.c
index d5e441194397..2bf1d2fabc48 100644
---
PRIO and RED mark the qdisc with TCQ_F_OFFLOADED upon successful offload,
make MQ do the same. The consistency will help with consistent
graft callback behaviour.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
net/sched/sch_mq.c | 9 +++--
1 file changed, 3 insertions(+), 6 del
Qdisc graft operation of offload-capable qdiscs performs a few
extra steps which are identical among all the qdiscs. Add
a helper to share this code.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
include/net/sch_generic.h | 12
net/sched/sch_api.c | 29 +
The code for grafting Qdiscs when there is a parent has two needless
indentation levels, and breaks the "keep the success path unindented"
guideline. Refactor.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
net/sched/sch_api.c | 28 ++--
1 file changed, 14 i
Qdisc dump operation of offload-capable qdiscs performs a few
extra steps which are identical among all the qdiscs. Add
a helper to share this code.
Signed-off-by: Jakub Kicinski
Reviewed-by: John Hurley
---
include/net/sch_generic.h | 12
net/sched/sch_api.c | 21 ++
Move destroying of the old child qdisc outside of the sch_tree_lock()
section. This should improve the software qdisc replace but is even
more important for offloads. Firstly calling offloads under a spin
lock is best avoided. Secondly the destroy event of existing child
would have been sent to
Hello,
This is bae working on Samsung Elec.
We got the problem that fragmented SIP packet couldn't be deliverd to user
layer.
And found that they were stoled at HOOK function, ipv6_defrag.
In condition with SMP and RPS.
After first fragmented packet, they have no further network header except i
On 11/8/2018 9:00 AM, Yonghong Song wrote:
Commit f6f3bac08ff9 ("tools/bpf: bpftool: add net support")
added certain networking support to bpftool.
The implementation relies on a relatively recent uapi header file
linux/tc_act/tc_bpf.h on the host which contains the marco
definition of TCA_ACT_BP
From: Jeff Kirsher
Date: Wed, 7 Nov 2018 11:16:17 -0800
> This series contains fixes to igb, i40e and ice drivers.
Pulled, thanks Jeff.
W dniu 08.11.2018 o 01:59, Paweł Staszewski pisze:
W dniu 05.11.2018 o 21:17, Jesper Dangaard Brouer pisze:
On Sun, 4 Nov 2018 01:24:03 +0100 Paweł Staszewski
wrote:
And today again after allpy patch for page allocator - reached again
64/64 Gbit/s
with only 50-60% cpu load
Great.
to
Commit f6f3bac08ff9 ("tools/bpf: bpftool: add net support")
added certain networking support to bpftool.
The implementation relies on a relatively recent uapi header file
linux/tc_act/tc_bpf.h on the host which contains the marco
definition of TCA_ACT_BPF_ID.
Unfortunately, this is not the case fo
W dniu 05.11.2018 o 21:17, Jesper Dangaard Brouer pisze:
On Sun, 4 Nov 2018 01:24:03 +0100 Paweł Staszewski
wrote:
And today again after allpy patch for page allocator - reached again
64/64 Gbit/s
with only 50-60% cpu load
Great.
today no slowpath hit for netwoking :)
But again droppe
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 15:34:48 -0800, Stanislav Fomichev wrote:
> > On 11/07, Jakub Kicinski wrote:
> > > On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote:
> > > > On 11/07, Jakub Kicinski wrote:
> > > > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav F
From: Paolo Abeni
Date: Wed, 7 Nov 2018 12:38:27 +0100
> This series implements GRO support for UDP sockets, as the RX counterpart
> of commit bec1f6f69736 ("udp: generate gso with UDP_SEGMENT").
> The core functionality is implemented by the second patch, introducing a new
> sockopt to enable U
This patchset uses eBPF perf-event based notification mechanism to solve
the problem described in
https://marc.info/?l=linux-netdev&m=154022219423571&w=2.
Thanks to Daniel Borkmann for feedback/input.
V2: inlined the call to sys_perf_event_open() following the style
of existing code in kse
This patch provides a tcp_bpf based eBPF sample. The test
- ncat(1) as the TCP client program to connect() to a port
with the intention of triggerring SYN retransmissions: we
first install an iptables DROP rule to make sure ncat SYNs are
resent (instead of aborting instantly after a TCP RST)
This patch allows eBPF programs that use sock_ops to send
perf-based event notifications using bpf_perf_event_output()
Signed-off-by: Sowmini Varadhan
---
net/core/filter.c | 19 +++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/net/core/filter.c b/net/core/fi
From: Mike Manning
Date: Wed, 7 Nov 2018 15:36:01 +
> Services currently have to be VRF-aware if they are using an unbound
> socket. One cannot have multiple service instances running in the
> default and other VRFs for services that are not VRF-aware and listen
> on an unbound socket. This
On Wed, 7 Nov 2018 15:34:48 -0800, Stanislav Fomichev wrote:
> On 11/07, Jakub Kicinski wrote:
> > On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote:
> > > On 11/07, Jakub Kicinski wrote:
> > > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:
> > > > > bpftool map u
On Wed, 7 Nov 2018 15:25:16 -0800, Stanislav Fomichev wrote:
> On 11/07, Jakub Kicinski wrote:
> > On Wed, 7 Nov 2018 15:00:21 -0800, Stanislav Fomichev wrote:
> > > > > +err_unpin_programs:
> > > > > + bpf_object__for_each_program(prog, obj) {
> > > > > + char buf[PATH_MAX];
> >
On Wed, Nov 7, 2018 at 1:44 PM Daniel Borkmann wrote:
>
> On 10/29/2018 11:11 PM, John Fastabend wrote:
> > On 10/29/2018 02:19 PM, Shannon Nelson wrote:
> >> This is an example of using XDP to redirect the processing of
> >> particular vlan packets to specific CPUs. This is in response
> >> to c
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote:
> > On 11/07, Jakub Kicinski wrote:
> > > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:
> > > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \
> > > > key 0 0 0 0 \
> > >
On Wed, 7 Nov 2018 15:12:07 -0800, Stanislav Fomichev wrote:
> > > I agree, constructing the jmp_table is a bit fragile with all the
> > > dependencies on the order of the progs. I'll drop that and will send a
> > > v2 that pins all the programs from the obj file instead and offloads
> > > jmp_tabl
On Wed, 7 Nov 2018 15:13:33 -0800, Stanislav Fomichev wrote:
> On 11/07, Jakub Kicinski wrote:
> > On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:
> > > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \
> > > key 0 0 0 0 \
> > > value pinned /sys/fs/bpf/flow/IP/
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 15:00:21 -0800, Stanislav Fomichev wrote:
> > > > +err_unpin_programs:
> > > > + bpf_object__for_each_program(prog, obj) {
> > > > + char buf[PATH_MAX];
> > > > + int len;
> > > > +
> > > > + len =
From: Roopa Prabhu
After commit 4abb8c723a64 ("bridge: fdb: Fix for missing
keywords in non-JSON output"), I am seeing a double print for dev
in bridge fdb show. eg:
"44:38:39:00:6a:82 dev dev bridge vlan 1 master bridge permanent"
this patch removes the redundant print.
Fixes: 4abb8c723a64 ("b
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:
> > bpftool map update pinned /sys/fs/bpf/flow/jmp_table \
> > key 0 0 0 0 \
> > value pinned /sys/fs/bpf/flow/IP/0
>
> Where is that /0 coming from ? Is that in source code? I don't s
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 14:15:06 -0800, Stanislav Fomichev wrote:
> > On 11/07, Quentin Monnet wrote:
> > > 2018-11-07 12:32 UTC-0800 ~ Jakub Kicinski
> > >
> > > > On Wed, 7 Nov 2018 20:08:53 +, Quentin Monnet wrote:
> > > > > > + err = bpf_obj_pin(
On Wed, 7 Nov 2018 14:43:56 -0800, Stanislav Fomichev wrote:
> bpftool map update pinned /sys/fs/bpf/flow/jmp_table \
> key 0 0 0 0 \
> value pinned /sys/fs/bpf/flow/IP/0
Where is that /0 coming from ? Is that in source code? I don't see
libbpf adding it, maybe I'm missing somet
> On 11/07/2018 02:33 PM, David Barmann wrote:
> > When setting the SO_MARK socket option, the dst needs to be reset so
> > that a new route lookup is performed.
> >
> > This fixes the case where an application wants to change routing by
> > setting a new sk_mark. If this is done after some pack
On Wed, 7 Nov 2018 15:00:21 -0800, Stanislav Fomichev wrote:
> > > +err_unpin_programs:
> > > + bpf_object__for_each_program(prog, obj) {
> > > + char buf[PATH_MAX];
> > > + int len;
> > > +
> > > + len = snprintf(buf, PATH_MAX, "%s/%s", path,
> > > +
On 11/07, Jakub Kicinski wrote:
> On Wed, 7 Nov 2018 14:43:55 -0800, Stanislav Fomichev wrote:
> > bpftool will use bpf_object__pin in the next commit to pin all programs
> > and maps from the file; in case of a partial failure, we need to get
> > back to the clean state (undo previous program/map
On 11/07/2018 02:33 PM, David Barmann wrote:
> When setting the SO_MARK socket option, the dst needs to be reset so
> that a new route lookup is performed.
>
> This fixes the case where an application wants to change routing by
> setting a new sk_mark. If this is done after some packets have a
On Wed, 7 Nov 2018 14:43:55 -0800, Stanislav Fomichev wrote:
> bpftool will use bpf_object__pin in the next commit to pin all programs
> and maps from the file; in case of a partial failure, we need to get
> back to the clean state (undo previous program/map pins).
>
> Signed-off-by: Stanislav Fo
On Wed, 7 Nov 2018 14:15:06 -0800, Stanislav Fomichev wrote:
> On 11/07, Quentin Monnet wrote:
> > 2018-11-07 12:32 UTC-0800 ~ Jakub Kicinski
> > > On Wed, 7 Nov 2018 20:08:53 +, Quentin Monnet wrote:
> > > > > + err = bpf_obj_pin(bpf_program__fd(prog), pinfile);
> > > > > +
From: Colin Ian King
There is an earlier check to see if xdp_ring is null when configuring
the tx ring, so assuming that it can still be null, the clearing of
the xdp_ring->state currently could end up with a null pointer
dereference. Fix this by only clearing the bit if xdp_ring is not null.
D
From: Sasha Neftin
Address few community comments.
Remove unused code, will be added per demand.
Remove blank lines and unneeded includes.
Signed-off-by: Sasha Neftin
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igc/igc.h | 9 -
drivers/net/
From: Lance Roy
lockdep_assert_held() is better suited to checking locking requirements,
since it won't get confused when someone else holds the lock. This is
also a step towards possibly removing spin_is_locked().
Signed-off-by: Lance Roy
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
--
From: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/igc/igc_base.c: In function
'igc_init_phy_params_base':
drivers/net/ethernet/intel/igc/igc_base.c:240:6: warning:
variable 'ctrl_ext' set but not used [-Wunused-but-set-variable]
u32 ctrl_ext;
drivers
From: Jacob Keller
Add a call to skb_tx_timestamp in the ixgbevf_tx_map function. This
enables software timestamping for packets sent over this device driver.
The call is placed just prior to when we notify hardware of the new
packet, in order to software timestamp as close as possible to when th
From: YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/net/ethernet/intel/igc/igc_main.c: In function 'igc_probe':
drivers/net/ethernet/intel/igc/igc_main.c:3535:11: warning:
variable 'pci_using_dac' set but not used [-Wunused-but-set-variable]
It never used since introduction
From: Todd Fujinaka
There's a new flag for setting WoL filters that is only
enabled on one manufacturer's NICs, and it's not ours. Fail
with EOPNOTSUPP.
Signed-off-by: Todd Fujinaka
Tested-by: Andrew Bowers
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 3
This series contains updates to almost all of the Intel wired LAN
drivers.
Lance Roy replaces a spin lock with lockdep_assert_held() for igbvf
driver in move toward trying to remove spin_is_locked().
Colin Ian King fixes a potential null pointer dereference by adding a
check in ixgbe. Also fixed
From: Colin Ian King
The call to netif_set_real_num_tx_queues is not assigning the error
return to variable err even though the next line checks err for an
error. Fix this by adding the missing err assignment.
Detected by CoverityScan, CID#1474551 ("Logically dead code")
Fixes: 3df25e4c1e66 ("
From: Miroslav Lichvar
It seems with some NICs supported by the e1000e driver a SYSTIM reading
may occasionally be few microseconds before the previous reading and if
enabled also pass e1000e_sanitize_systim() without reaching the maximum
number of rereads, even if the function is modified to che
From: Shannon Nelson
When it's possible that the PF might end up trying to send a
packet to one of its own VFs, we have to forbid IPsec offload
because the device drops the packets into a black hole.
See commit 47b6f50077e6 ("ixgbe: disallow IPsec Tx offload
when in SR-IOV mode") for more info.
From: Dan Carpenter
I just cleaned up a couple small white space issues.
Signed-off-by: Dan Carpenter
Acked-by: Sasha Neftin
Tested-by: Aaron Brown
Signed-off-by: Jeff Kirsher
---
drivers/net/ethernet/intel/igc/igc_main.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
dif
1 - 100 of 245 matches
Mail list logo
