[PATCH net] ipv6: sr: properly initialize flowi6 prior passing to ip6_route_output

2018-12-06 Thread Shmulik Ladkani
In 'seg6_output', stack variable 'struct flowi6 fl6' was missing initialization. Fixes: 6c8702c60b88 ("ipv6: sr: add support for SRH encapsulation and injection with lwtunnels") Signed-off-by: Shmulik Ladkani --- Suggeting this fix, spotted during code review while experimenting with SRv6, alth

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-06 Thread Greg Ungerer
Hi John, On 4/12/18 12:02 am, John Crispin wrote: On 03/12/2018 15:00, René van Dorst wrote: Quoting Bjørn Mork : Greg Ungerer writes: The following change helped alot, but I still get some problems under sustained load and some types of port setups. Still trying to figure out what exactly

Re: [PATCH AUTOSEL 4.19 040/123] bpf: allocate local storage buffers using GFP_ATOMIC

2018-12-06 Thread Naresh Kamboju
On Fri, 7 Dec 2018 at 12:10, Naresh Kamboju wrote: > > On Wed, 5 Dec 2018 at 15:08, Sasha Levin wrote: > > > > From: Roman Gushchin > > > > [ Upstream commit 569a933b03f3c48b392fe67c0086b3a6b9306b5a ] > > > > Naresh reported an issue with the non-atomic memory allocation of > > cgroup local stor

Re: [PATCH AUTOSEL 4.19 040/123] bpf: allocate local storage buffers using GFP_ATOMIC

2018-12-06 Thread Naresh Kamboju
On Wed, 5 Dec 2018 at 15:08, Sasha Levin wrote: > > From: Roman Gushchin > > [ Upstream commit 569a933b03f3c48b392fe67c0086b3a6b9306b5a ] > > Naresh reported an issue with the non-atomic memory allocation of > cgroup local storage buffers: > > [ 73.047526] BUG: sleeping function called from inv

[PATCHv2 net 3/3] sctp: fa_resize sctp stream instead of redo fa_alloc

2018-12-06 Thread Xin Long
Now when doing 4-shakehand or adding new streams, sctp has to allocate new memory for asoc->stream and copy the old stream's information from the old asoc->stream to the new one. It also cause the stream pointers to change, by which a panic was even caused due to stream->out_curr's change. To fix

[PATCHv2 net 1/3] flex_array: make FLEX_ARRAY_BASE_SIZE the same value of FLEX_ARRAY_PART_SIZE

2018-12-06 Thread Xin Long
This patch is to separate the base data memory from struct flex_array and save it into a page. With this change, total_nr_elements of a flex_array can grow or shrink without having the old element's memory changed when the new size of the flex_arry crosses FLEX_ARRAY_BASE_SIZE, which will be added

[PATCHv2 net 0/3] net: add support for flex_array_resize in flex_array

2018-12-06 Thread Xin Long
Without the support for the total_nr_elements's growing or shrinking dynamically, flex_array is not that 'flexible'. Like when users want to change the size, they have to redo flex_array_alloc and copy all the elements from the old to the new one. The worse thing is every element's memory gets cha

[PATCHv2 net 2/3] flex_array: support flex_array_resize

2018-12-06 Thread Xin Long
This function can dynamically change total_nr_elements of a flex_array, and keep the old elements of the same memory. Returns 0 if it succeeds. Note that it won't do any memory allocation or shrinking for elements, which should be only done by flex_array_prealloc and flex_array_shrink. Suggested-

Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

2018-12-06 Thread David Miller
From: David Miller Date: Thu, 06 Dec 2018 22:24:09 -0800 (PST) > Series applied, thanks! Erm... actually reverted. Please fix these build failures: ld: net/ipv6/ip6_offload.o: in function `ipv6_gro_receive': ip6_offload.c:(.text+0xda2): undefined reference to `udp6_gro_receive' ld: ip6_offload

Re: [PATCH net-next v2 0/4] net: mitigate retpoline overhead

2018-12-06 Thread David Miller
From: Paolo Abeni Date: Wed, 5 Dec 2018 19:13:38 +0100 > The spectre v2 counter-measures, aka retpolines, are a source of measurable > overhead[1]. We can partially address that when the function pointer refers to > a builtin symbol resorting to a list of tests vs well-known builtin function >

Re: [PATCH rdma-next 0/3] Packet based credit mode

2018-12-06 Thread Leon Romanovsky
On Thu, Dec 06, 2018 at 08:27:06PM -0700, Jason Gunthorpe wrote: > On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > >From Danit, > > > > Packet based credit mode is an alternative end-to-end credit mode for QPs > > set during their creation. Credit

[PATCH v3] ptp: fix an IS_ERR() vs NULL check

2018-12-06 Thread Dan Carpenter
We recently modified pps_register_source() to return error pointers instead of NULL but it seems like there was a merge issue and part of the commit was lost. Anyway, the ptp_clock_register() function needs to be updated to check for IS_ERR() as well. Fixes: 3b1ad360acad ("pps: using ERR_PTR inst

Re: [PATCH net-next] rhashtable: further improve stability of rhashtable_walk

2018-12-06 Thread Herbert Xu
On Wed, Dec 05, 2018 at 02:51:02PM +1100, NeilBrown wrote: > > If the sequence: >obj = rhashtable_walk_next(iter); >rhashtable_walk_stop(iter); >rhashtable_remove_fast(ht, &obj->head, params); >rhashtable_walk_start(iter); > > races with another thread inserting or removing > an

linux-next: manual merge of the rcu tree with the net-next tree

2018-12-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rcu tree got conflicts in: net/bridge/br_mdb.c net/bridge/br_multicast.c between commits: 19e3a9c90c53 ("net: bridge: convert multicast to generic rhashtable") 4329596cb10d ("net: bridge: multicast: use non-bh rcu flavor") from the net-next tree

Re: [PATCH bpf] selftests/bpf: add missing pointer dereference for map stacktrace fixup

2018-12-06 Thread Prashant Bhole
On 12/7/2018 1:14 PM, Stanislav Fomichev wrote: I get a segfault without it, other fixups always do dereference, and without dereference I don't understand how it can ever work. Fixes: 7c85c448e7d74 ("selftests/bpf: test_verifier, check bpf_map_lookup_elem access in bpf prog") Signed-off-by:

[PATCH bpf] selftests/bpf: add missing pointer dereference for map stacktrace fixup

2018-12-06 Thread Stanislav Fomichev
I get a segfault without it, other fixups always do dereference, and without dereference I don't understand how it can ever work. Fixes: 7c85c448e7d74 ("selftests/bpf: test_verifier, check bpf_map_lookup_elem access in bpf prog") Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf

Re: [RFC PATCH 4/6] dt-bindings: update mvneta binding document

2018-12-06 Thread Kishon Vijay Abraham I
Hi Russell, On 05/12/18 9:00 PM, Rob Herring wrote: > On Wed, Dec 5, 2018 at 5:00 AM Russell King - ARM Linux > wrote: >> >> On Mon, Dec 03, 2018 at 05:54:55PM -0600, Rob Herring wrote: >>> On Mon, Nov 12, 2018 at 12:31:02PM +, Russell King wrote: Signed-off-by: Russell King >>> >>> Nee

Re: [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"

2018-12-06 Thread Benjamin Herrenschmidt
On Fri, 2018-12-07 at 14:20 +1100, Benjamin Herrenschmidt wrote: > Apologies for the empty email, not too sure what happened, I did a resend and the second one worked. Cheers Ben.

[PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"

2018-12-06 Thread Benjamin Herrenschmidt
This reverts commit 624ca9c33c8a853a4a589836e310d776620f4ab9. This commit is completely bogus. The STACR register has two formats, old and new, depending on the version of the IP block used. There's a pair of device-tree properties that can be used to specify the format used: has-inverted

Re: [PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"

2018-12-06 Thread David Miller
Looks like your posting was empty?

Re: [PATCH net-next] neighbour: Improve garbage collection

2018-12-06 Thread David Miller
From: David Ahern Date: Thu, 6 Dec 2018 14:38:44 -0800 > The existing garbage collection algorithm has a number of problems: Thanks for working on this! I totally agree with what you are doing, especially the separate gc_list. But why do you need the on_gc_list boolean state? That's equivale

Re: [PATCH net-next 3/4] net: use indirect call wrapper at GRO transport layer

2018-12-06 Thread kbuild test robot
Hi Paolo, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Paolo-Abeni/net-mitigate-retpoline-overhead/20181206-183400 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1

[PATCH bpf] selftests/bpf: skip sockmap tests on kernels without support

2018-12-06 Thread Stanislav Fomichev
Include "autoconf.h" header in the test_maps.c and selectively disable test_sockmap if CONFIG_BPF_STREAM_PARSER is not specified in the kernel config. When building out of tree/without autoconf.h, fall back to 'enabled'. Signed-off-by: Stanislav Fomichev --- tools/testing/selftests/bpf/test_maps

Re: [PATCH rdma-next 0/3] Packet based credit mode

2018-12-06 Thread Jason Gunthorpe
On Fri, Nov 30, 2018 at 01:22:03PM +0200, Leon Romanovsky wrote: > From: Leon Romanovsky > > >From Danit, > > Packet based credit mode is an alternative end-to-end credit mode for QPs > set during their creation. Credits are transported from the responder > to the requester to optimize the use o

[PATCH] Revert "net/ibm/emac: wrong bit is used for STA control"

2018-12-06 Thread Benjamin Herrenschmidt

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Richard Cochran
On Thu, Dec 06, 2018 at 08:00:26PM +, tristram...@microchip.com wrote: > A customer has already inquired about implementing 1588 PTP in the DSA > driver. I hope > this mechanism is approved so that I can start doing that. If you need changes to the PTP core, you had better discuss this with

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Edgecombe, Rick P
On Thu, 2018-12-06 at 15:08 -0800, Nadav Amit wrote: > > On Dec 6, 2018, at 12:17 PM, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: > > > > On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > > > > > > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wro

linux-next: manual merge of the net-next tree with the net tree

2018-12-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/dsa/master.c between commit: a3d7e01da060 ("net: dsa: Fix tagging attribute location") from the net tree and commit: dc0fe7d47f9f ("net: dsa: Set the master device's MTU to account for DSA overheads") from th

Re: [PATCH v2 perf,bpf 1/3] perf, bpf: Introduce PERF_RECORD_BPF_EVENT

2018-12-06 Thread kbuild test robot
Hi Song, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/perf/core] [also build test ERROR on v4.20-rc5 next-20181206] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH] crypto: user - support incremental algorithm dumps

2018-12-06 Thread Eric Biggers
From: Eric Biggers CRYPTO_MSG_GETALG in NLM_F_DUMP mode sometimes doesn't return all registered crypto algorithms, because it doesn't support incremental dumps. crypto_dump_report() only permits itself to be called once, yet the netlink subsystem allocates at most ~64 KiB for the skb being dumpe

[net-next PATCH RFC 8/8] veth: xdp_frames redirected into veth need to transfer xdp_mem_info

2018-12-06 Thread Jesper Dangaard Brouer
XDP frames redirected into a veth device, that choose XDP_PASS end-up creating an SKB from the xdp_frame. The xdp_frame mem info need to be transferred into the SKB. Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Ilias Apalodimas --- drivers/net/veth.c |1 + 1 file changed, 1 inserti

[net-next PATCH RFC 2/8] net: mvneta: use page pool API for sw buffer manager

2018-12-06 Thread Jesper Dangaard Brouer
From: Ilias Apalodimas Use the page_pool api for allocations and DMA handling instead of __dev_alloc_page()/dma_map_page() and free_page()/dma_unmap_page(). The page_pool API offers buffer recycling capabilities for XDP but allocates one page per packet, unless the driver splits and manages the

[net-next PATCH RFC 1/8] page_pool: add helper functions for DMA

2018-12-06 Thread Jesper Dangaard Brouer
From: Ilias Apalodimas Add helper functions for retreiving dma_addr_t stored in page_private and unmapping dma addresses, mapped via the page_pool API. Signed-off-by: Ilias Apalodimas Signed-off-by: Jesper Dangaard Brouer --- include/net/page_pool.h |6 ++ net/core/page_pool.c|

[net-next PATCH RFC 6/8] mvneta: activate page recycling via skb using page_pool

2018-12-06 Thread Jesper Dangaard Brouer
Previous mvneta patches have already started to use page_pool, but this was primarily for RX page alloc-side and for doing DMA map/unmap handling. Pages traveling through the netstack was unmapped and returned through the normal page allocator. It is now time to activate that pages are recycled b

[net-next PATCH RFC 5/8] net: mvneta: remove copybreak, prefetch and use build_skb

2018-12-06 Thread Jesper Dangaard Brouer
From: Ilias Apalodimas The driver memcpy for packets < 256b and it's recycle tricks are not needed anymore. As previous patch introduces buffer recycling using the page_pool API (although recycling doesn't get fully activated in this patch). After this switch to using build_skb(). This patch i

[net-next PATCH RFC 4/8] net: core: add recycle capabilities on skbs via page_pool API

2018-12-06 Thread Jesper Dangaard Brouer
From: Ilias Apalodimas This patch is changing struct sk_buff, and is thus per-definition controversial. Place a new member 'mem_info' of type struct xdp_mem_info, just after members (flags) head_frag and pfmemalloc, And not in between headers_start/end to ensure skb_copy() and pskb_copy() work a

[net-next PATCH RFC 7/8] xdp: bpf: cpumap redirect must update skb->mem_info

2018-12-06 Thread Jesper Dangaard Brouer
XDP-redirect to CPUMAP is about creating the SKB outside the driver (and on another CPU) via xdp_frame info. Transfer the xdp_frame mem info to the new SKB mem_info field. Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Ilias Apalodimas --- kernel/bpf/cpumap.c |2 ++ 1 file changed, 2

[net-next PATCH RFC 0/8] page_pool DMA handling and allow to recycles frames via SKB

2018-12-06 Thread Jesper Dangaard Brouer
This RFC patchset shows the plans for allowing page_pool to handle and maintain DMA map/unmap of the pages it serves to the driver. For this to work a return hook in the network core is introduced, which also involves extending sk_buff with the necessary information. The overall purpose is to sim

[net-next PATCH RFC 3/8] xdp: reduce size of struct xdp_mem_info

2018-12-06 Thread Jesper Dangaard Brouer
It is possible to compress/reduce the size of struct xdp_mem_info. This change reduce struct xdp_mem_info from 8 bytes to 4 bytes. The member xdp_mem_info.id can be reduced to u16, as the mem_id_ht rhashtable in net/core/xdp.c is already limited by MEM_ID_MAX=0xFFFE which can safely fit in u16. T

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Nadav Amit
> On Dec 6, 2018, at 12:17 PM, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: >>> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: >>> >>> On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrot

RE: [Intel-wired-lan] [PATCH] ixgbe: Fix race when the VF driver does a reset

2018-12-06 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Ross Lagerwall > Sent: Wednesday, December 5, 2018 5:54 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Cc: Ross Lagerwall ; David S. Miller > > Subject: [Intel-wired

RE: [Intel-wired-lan] [PATCH v3 2/2] i40e: DRY rx_ptype handling code

2018-12-06 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Michal Miroslaw > Sent: Tuesday, December 4, 2018 9:31 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH v3 2/2] i40e: DRY rx_ptype han

RE: [Intel-wired-lan] [PATCH v3 1/2] i40e: fix VLAN.TCI == 0 RX HW offload

2018-12-06 Thread Bowers, AndrewX
> -Original Message- > From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On > Behalf Of Michal Miroslaw > Sent: Tuesday, December 4, 2018 9:31 AM > To: netdev@vger.kernel.org; intel-wired-...@lists.osuosl.org > Subject: [Intel-wired-lan] [PATCH v3 1/2] i40e: fix VLAN.TCI ==

[PATCH net-next 1/4] tc-testing: Add command timeout feature to tdc

2018-12-06 Thread Lucas Bates
Using an attribute set in the tdc_config.py file, limit the amount of time tdc will wait for an executed command to complete and prevent the script from hanging entirely. This timeout will be applied to all executed commands. Signed-off-by: Lucas Bates --- tools/testing/selftests/tc-testing/tdc

[PATCH net-next 3/4] tc-testing: Implement the TdcResults module in tdc

2018-12-06 Thread Lucas Bates
In tdc and the valgrind plugin, begin using the TdcResults module to track executed test cases. Signed-off-by: Lucas Bates --- tools/testing/selftests/tc-testing/TdcPlugin.py| 3 +- .../tc-testing/plugin-lib/valgrindPlugin.py| 22 +++- tools/testing/selftests/tc-testing/tdc.py

[PATCH net-next 2/4] tc-testing: Add new TdcResults module

2018-12-06 Thread Lucas Bates
This module includes new classes for tdc to use in keeping track of test case results, instead of generating and tracking a lengthy string. The new module can be extended to support multiple formal test result formats to be friendlier to automation. Signed-off-by: Lucas Bates --- tools/testing/

[PATCH net-next 0/4] tc-testing: implement command timeouts and better results tracking

2018-12-06 Thread Lucas Bates
Patch 1 adds a timeout feature for any command tdc launches in a subshell. This prevents tdc from hanging indefinitely. Patches 2-4 introduce a new method for tracking and generating test case results, and implements it across the core script and all applicable plugins. Lucas Bates (4): tc-test

[PATCH net-next 4/4] tc-testing: gitignore, ignore generated test results

2018-12-06 Thread Lucas Bates
Ignore any .tap or .xml test result files generated by tdc. Additionally, ignore plugin symlinks. Signed-off-by: Lucas Bates --- tools/testing/selftests/tc-testing/.gitignore | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/testing/selftests/tc-testing/.gitignore b/tools/testing/se

[PATCH net-next,v5 11/12] qede: place ethtool_rx_flow_spec after code after TC flower codebase

2018-12-06 Thread Pablo Neira Ayuso
This is a preparation patch to reuse the existing TC flower codebase from ethtool_rx_flow_spec. This patch is merely moving the core ethtool_rx_flow_spec parser after tc flower offload driver code so we can skip a few forward function declarations in the follow up patch. Signed-off-by: Pablo Neir

[PATCH net-next,v5 01/12] flow_offload: add flow_rule and flow_match structures and use them

2018-12-06 Thread Pablo Neira Ayuso
This patch wraps the dissector key and mask - that flower uses to represent the matching side - around the flow_match structure. To avoid a follow up patch that would edit the same LoCs in the drivers, this patch also wraps this new flow match structure around the flow rule object. This new struct

[PATCH net-next,v5 10/12] dsa: bcm_sf2: use flow_rule infrastructure

2018-12-06 Thread Pablo Neira Ayuso
Update this driver to use the flow_rule infrastructure, hence we can use the same code to populate hardware IR from ethtool_rx_flow and the cls_flower interfaces. Signed-off-by: Pablo Neira Ayuso --- v5: rebase on top of net-next head. drivers/net/dsa/bcm_sf2_cfp.c | 102 +++

[PATCH net-next,v5 04/12] cls_api: add translator to flow_action representation

2018-12-06 Thread Pablo Neira Ayuso
This patch implements a new function to translate from native TC action to the new flow_action representation. Moreover, this patch also updates cls_flower to use this new function. Signed-off-by: Pablo Neira Ayuso --- v5: rebase on top of net-next head. include/net/pkt_cls.h | 3 ++ net/sche

[PATCH net-next,v5 07/12] cls_flower: don't expose TC actions to drivers anymore

2018-12-06 Thread Pablo Neira Ayuso
Now that drivers have been converted to use the flow action infrastructure, remove this field from the tc_cls_flower_offload structure. Signed-off-by: Pablo Neira Ayuso --- v5: rebase on top of net-next head. include/net/pkt_cls.h | 1 - net/sched/cls_flower.c | 5 - 2 files changed, 6 del

[PATCH net-next,v5 05/12] flow_offload: add statistics retrieval infrastructure and use it

2018-12-06 Thread Pablo Neira Ayuso
This patch provides the flow_stats structure that acts as container for tc_cls_flower_offload, then we can use to restore the statistics on the existing TC actions. Hence, tcf_exts_stats_update() is not used from drivers anymore. Signed-off-by: Pablo Neira Ayuso --- v5: Fix bytes and packet param

[PATCH net-next,v5 12/12] qede: use ethtool_rx_flow_rule() to remove duplicated parser code

2018-12-06 Thread Pablo Neira Ayuso
The qede driver supports for ethtool_rx_flow_spec and flower, both codebases look very similar. This patch uses the ethtool_rx_flow_rule() infrastructure to remove the duplicated ethtool_rx_flow_spec parser and consolidate ACL offload support around the flow_rule infrastructure. Furthermore, more

[PATCH net-next,v5 09/12] ethtool: add ethtool_rx_flow_spec to flow_rule structure translator

2018-12-06 Thread Pablo Neira Ayuso
This patch adds a function to translate the ethtool_rx_flow_spec structure to the flow_rule representation. This allows us to reuse code from the driver side given that both flower and ethtool_rx_flow interfaces use the same representation. This patch also includes support for the flow type flags

[PATCH net-next,v5 06/12] drivers: net: use flow action infrastructure

2018-12-06 Thread Pablo Neira Ayuso
This patch updates drivers to use the new flow action infrastructure. Signed-off-by: Pablo Neira Ayuso --- v5: rebase on top of net-next head. drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 74 +++--- .../net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c | 250 +-- drivers/n

[PATCH net-next,v5 08/12] flow_offload: add wake-up-on-lan and queue to flow_action

2018-12-06 Thread Pablo Neira Ayuso
These actions need to be added to support the ethtool_rx_flow interface. The queue action includes a field to specify the RSS context, that is set via FLOW_RSS flow type flag and the rss_context field in struct ethtool_rxnfc, plus the corresponding queue index. FLOW_RSS implies that rss_context is

[PATCH net-next,v5 00/12] add flow_rule infrastructure

2018-12-06 Thread Pablo Neira Ayuso
Hi, This is another iteration of the in-kernel intermediate representation (IR) that allows to express ACL hardware offloads using one unified representation from the driver side for the ethtool and the tc frontends [1] [2] [3]. In words of Michal Kubecek: "... the ethtool interface can apply fo

[PATCH net-next,v5 02/12] net/mlx5e: support for two independent packet edit actions

2018-12-06 Thread Pablo Neira Ayuso
This patch adds pedit_headers_action structure to store the result of parsing tc pedit actions. Then, it calls alloc_tc_pedit_action() to populate the mlx5e hardware intermediate representation once all actions have been parsed. This patch comes in preparation for the new flow_action infrastructur

[PATCH net-next,v5 03/12] flow_offload: add flow action infrastructure

2018-12-06 Thread Pablo Neira Ayuso
This new infrastructure defines the nic actions that you can perform from existing network drivers. This infrastructure allows us to avoid a direct dependency with the native software TC action representation. Signed-off-by: Pablo Neira Ayuso --- v5: rebase on top of net-next head. include/net/

[PATCH net-next] neighbour: Improve garbage collection

2018-12-06 Thread David Ahern
From: David Ahern The existing garbage collection algorithm has a number of problems: 1. The gc algorithm will not evict PERMANENT entries as those entries are managed by userspace, yet the existing algorithm walks the entire hash table which means it always considers PERMANENT entries whe

Re: OMAP4430 SDP with KS8851: very slow networking

2018-12-06 Thread Tony Lindgren
* Russell King - ARM Linux [181206 18:08]: > reverted, the problem is still there. Revert: > > ec0daae685b2 ("gpio: omap: Add level wakeup handling for omap4 based SoCs") > > on top, and networking returns to normal. So it appears to be this > last commit causing the issue. > > With that and

Re: [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads

2018-12-06 Thread Stephen Hemminger
On Thu, 6 Dec 2018 11:36:05 +0100 Andrew Lunn wrote: > +void dsa_master_set_mtu(struct net_device *dev, struct dsa_port *cpu_dp) > +{ > + unsigned int mtu = ETH_DATA_LEN + cpu_dp->tag_ops->overhead; > + int err; > + > + rtnl_lock(); > + if (mtu <= dev->max_mtu) { > +

Re: [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads

2018-12-06 Thread David Miller
From: Andrew Lunn Date: Thu, 6 Dec 2018 21:48:46 +0100 > David has already accepted the patchset, so i will add a followup > patch. Yeah sorry for jumping the gun, the changes looked pretty straightforward to me. :-/

Re: [PATCH net-next v2 0/8] Pass extack to NETDEV_PRE_UP

2018-12-06 Thread David Miller
From: Petr Machata Date: Thu, 6 Dec 2018 17:05:35 + > Drivers may need to validate configuration of a device that's about to > be upped. An example is mlxsw, which needs to check the configuration of > a VXLAN device attached to an offloaded bridge. Should the validation > fail, there's curre

Re: [PATCH net 0/4] mlxsw: Various fixes

2018-12-06 Thread David Miller
From: Ido Schimmel Date: Thu, 6 Dec 2018 17:44:48 + > Patches #1 and #2 fix two VxLAN related issues. The first patch removes > warnings that can currently be triggered from user space. Second patch > avoids leaking a FID in an error path. > > Patch #3 fixes a too strict check that causes ce

[PATCH] net: wireless: FTM: fix kernel-doc "cannot understand" warnings

2018-12-06 Thread Randy Dunlap
From: Randy Dunlap Fix kernel-doc warnings in FTM due to missing "struct" keyword. Fixes 109 warnings from : ../include/net/cfg80211.h:2838: warning: cannot understand function prototype: 'struct cfg80211_ftm_responder_stats ' and fixes 88 warnings from : ../include/net/mac80211.h:477: warning

Re: [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads

2018-12-06 Thread Andrew Lunn
On Thu, Dec 06, 2018 at 12:21:31PM -0800, Florian Fainelli wrote: > On 12/6/18 2:36 AM, Andrew Lunn wrote: > > DSA tagging of frames sent over the master interface to the switch > > increases the size of the frame. Such frames can then be bigger than > > the normal MTU of the master interface, and

Re: [PATCH RFC 2/6] net: dsa: microchip: Add MIB counter reading support

2018-12-06 Thread Andrew Lunn
> I wonder what is the official way to clear the counters. I don't think there is one, other than unloading the driver and loading it again. Andrew

Re: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Andrew Lunn
> I did try to implement this way. But the other switches do not have the same > format even though the length is the same. Then I need to change the > following > files for any new KSZ switch: include/linux/dsa.h, net/dsa/dsa.c, > net/dsa/dsa_priv.h, > and finally net/dsa/tag_ksz.c. You can a

Re: [PATCH 1/2] net: linkwatch: send change uevent on link changes

2018-12-06 Thread Jouke Witteveen
On Thu, Dec 6, 2018 at 9:10 PM David Miller wrote: > > From: Jouke Witteveen > Date: Thu, 6 Dec 2018 09:59:20 +0100 > > > On Thu, Dec 6, 2018 at 1:34 AM David Miller wrote: > >> > >> From: Jouke Witteveen > >> Date: Wed, 5 Dec 2018 23:38:17 +0100 > >> > >> > Can you elaborate a bit? I may not b

Re: [PATCH] mv88e6060: Warn about errors

2018-12-06 Thread Pavel Machek
On Thu 2018-12-06 12:21:59, David Miller wrote: > > Plain "printk" are never appropriate. > > Please explicitly use pr_warn() or similar. If there is a device context > available, either a generic device or a netdev, use one of the dev_*() > or netdev_*() variants. Can do, I guess is there'

Re: mv88e6060: Turn e6060 driver into e6065 driver

2018-12-06 Thread Pavel Machek
On Thu 2018-12-06 12:23:33, David Miller wrote: > From: Pavel Machek > Date: Thu, 6 Dec 2018 14:03:45 +0100 > > > @@ -79,7 +82,7 @@ static enum dsa_tag_protocol > > mv88e6060_get_tag_protocol(struct dsa_switch *ds, > > { > >//return DSA_TAG_PROTO_QCA; > >//return DSA_TAG_PROTO_TRAILER;

RE: [PATCH RFC 1/6] net: dsa: microchip: Prepare PHY for proper advertisement

2018-12-06 Thread Tristram.Ha
> > +static void ksz9477_phy_setup(struct ksz_device *dev, int port, > > + struct phy_device *phy) > > +{ > > + if (port < dev->phy_port_cnt) { > > + /* SUPPORTED_Asym_Pause and SUPPORTED_Pause can be > removed to > > +* disable flow control when rate

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 12:20 PM Edgecombe, Rick P wrote: > > On Thu, 2018-12-06 at 11:19 -0800, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > > > > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > > > If we are going to unmap the line

Re: mv88e6060: Turn e6060 driver into e6065 driver

2018-12-06 Thread David Miller
From: Pavel Machek Date: Thu, 6 Dec 2018 14:03:45 +0100 > @@ -79,7 +82,7 @@ static enum dsa_tag_protocol > mv88e6060_get_tag_protocol(struct dsa_switch *ds, > { >//return DSA_TAG_PROTO_QCA; >//return DSA_TAG_PROTO_TRAILER; These C++ style comments are not in any of my tree(s). Your pa

Re: [PATCH] mv88e6060: Warn about errors

2018-12-06 Thread David Miller
Plain "printk" are never appropriate. Please explicitly use pr_warn() or similar. If there is a device context available, either a generic device or a netdev, use one of the dev_*() or netdev_*() variants.

Re: [PATCH net-next 2/2] net: dsa: Set the master device's MTU to account for DSA overheads

2018-12-06 Thread Florian Fainelli
On 12/6/18 2:36 AM, Andrew Lunn wrote: > DSA tagging of frames sent over the master interface to the switch > increases the size of the frame. Such frames can then be bigger than > the normal MTU of the master interface, and it may drop them. Use the > overhead information from the tagger to set th

Re: [PATCH] tcp: fix code style in tcp_recvmsg()

2018-12-06 Thread David Miller
From: Pedro Tammela Date: Thu, 6 Dec 2018 10:45:28 -0200 > 2 goto labels are indented with a tab. remove the tabs and > keep the code style consistent. > > Signed-off-by: Pedro Tammela Applied to net-next.

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Edgecombe, Rick P
On Thu, 2018-12-06 at 11:19 -0800, Andy Lutomirski wrote: > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > > If we are going to unmap the linear alias, why not do it at vmalloc() > > > > time rather than vfree()

Re: [PATCH net-next 0/2] Adjust MTU of DSA master interface

2018-12-06 Thread David Miller
From: Andrew Lunn Date: Thu, 6 Dec 2018 11:36:03 +0100 > DSA makes use of additional headers to direct a frame in/out of a > specific port of the switch. When the slave interfaces uses an MTU of > 1500, the master interface can be asked to handle frames with an MTU > of 1504, or 1508 bytes. Some

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:39 AM Nadav Amit wrote: > > > On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > >> On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > If we are going to unmap the linear alias, why no

Re: [PATCH][net-next] tun: align write-heavy flow entry members to a cache line

2018-12-06 Thread David Miller
From: Li RongQing Date: Thu, 6 Dec 2018 16:08:17 +0800 > tun flow entry 'updated' fields are written when receive > every packet. Thus if a flow is receiving packets from a > particular flow entry, it'll cause false-sharing with > all the other who has looked it up, so move it in its own > cache

Re: [PATCH][net-next] tun: remove unnecessary check in tun_flow_update

2018-12-06 Thread David Miller
From: Li RongQing Date: Thu, 6 Dec 2018 16:28:11 +0800 > caller has guaranted that rxhash is not zero > > Signed-off-by: Li RongQing Applied.

RE: [PATCH RFC 2/6] net: dsa: microchip: Add MIB counter reading support

2018-12-06 Thread Tristram.Ha
> > +static void ksz9477_r_mib_cnt(struct ksz_device *dev, int port, u16 addr, > > + u64 *cnt) > > +{ > > + u32 data; > > + int timeout; > > + struct ksz_port *p = &dev->ports[port]; > > + > > + /* retain the flush/freeze bit */ > > + data = p->freeze ? MIB_COUNTER

Re: [PATCH 1/2] net: linkwatch: send change uevent on link changes

2018-12-06 Thread David Miller
From: Jouke Witteveen Date: Thu, 6 Dec 2018 09:59:20 +0100 > On Thu, Dec 6, 2018 at 1:34 AM David Miller wrote: >> >> From: Jouke Witteveen >> Date: Wed, 5 Dec 2018 23:38:17 +0100 >> >> > Can you elaborate a bit? I may not be aware of the policy you have in >> > mind. >> >> When we have a user

RE: [PATCH RFC 5/6] net: dsa: microchip: Update tag_ksz.c to access switch driver

2018-12-06 Thread Tristram.Ha
> >>> Update tag_ksz.c to access switch driver's tail tagging operations. > >> > >> Hi Tristram > >> > >> Humm, i'm not sure we want this, the tagging spit into two places. I > >> need to take a closer look at the previous patch, to see why it cannot > >> be done here. > > > > O.K, i think i get w

Re: [PATCH net-next 0/2] platform data controls for mdio-gpio

2018-12-06 Thread Andrew Lunn
On Thu, Dec 06, 2018 at 09:22:27AM -0800, Florian Fainelli wrote: > Hi Andrew, > > On 12/6/18 5:58 AM, Andrew Lunn wrote: > > Soon to be mainlined is an x86 platform with a Marvell switch, and a > > bit-banging MDIO bus. In order to make this work, the phy_mask of the > > MDIO bus needs to be set

Re: [PATCH] gianfar: Add gfar_change_carrier()

2018-12-06 Thread Andrew Lunn
> I can have a look at using dormant, but what is change_carrier > supposed to do if not this? It is intended for interfaces which are stacked, like the team driver, and for devices which don't have a phy, e.g. tun, and dummy. > I didn't find a tool for DORMANT, I guess i will have to write one >

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Nadav Amit
> On Dec 6, 2018, at 11:19 AM, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: >> On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: If we are going to unmap the linear alias, why not do it at vmalloc() time rather than vfree() time? >>>

Re: [PATCH bpf-next] tools: bpftool: add a command to dump the trace pipe

2018-12-06 Thread Alexei Starovoitov
On Thu, Dec 06, 2018 at 05:20:54PM +, Quentin Monnet wrote: > 2018-12-05 19:18 UTC-0800 ~ Alexei Starovoitov > > > On Wed, Dec 05, 2018 at 06:15:23PM +, Quentin Monnet wrote: > + > +/* Allow room for NULL terminating byte and pipe file name */ > +snprintf(for

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 20:30, Will Deacon wrote: > > On Thu, Dec 06, 2018 at 08:23:20PM +0100, Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > > > > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > > > wrote: > > > > > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lu

Re: [PATCH net-next 4/4] net: aquantia: add support of RSS configuration

2018-12-06 Thread Jakub Kicinski
On Thu, 6 Dec 2018 15:02:52 +, Igor Russkikh wrote: > From: Dmitry Bogdanov > > Add support of configuration of RSS hash key and RSS indirection table. > > Signed-off-by: Dmitry Bogdanov > Signed-off-by: Igor Russkikh > --- > .../ethernet/aquantia/atlantic/aq_ethtool.c | 42

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Will Deacon
On Thu, Dec 06, 2018 at 08:23:20PM +0100, Ard Biesheuvel wrote: > On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > > wrote: > > > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > > > > > > > That’s not totally nuts. Do

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 20:21, Andy Lutomirski wrote: > > On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel > wrote: > > > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > > work on module data? Perhaps crypt

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:04 AM Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > > That’s not totally nuts. Do we ever have code that expects __va() to > > work on module data? Perhaps crypto code trying to encrypt static > > data because our APIs don’t unders

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Andy Lutomirski
On Thu, Dec 6, 2018 at 11:01 AM Tycho Andersen wrote: > > On Thu, Dec 06, 2018 at 10:53:50AM -0800, Andy Lutomirski wrote: > > > If we are going to unmap the linear alias, why not do it at vmalloc() > > > time rather than vfree() time? > > > > That’s not totally nuts. Do we ever have code that exp

[PATCH] vhost/vsock: fix reset orphans race with close timeout

2018-12-06 Thread Stefan Hajnoczi
If a local process has closed a connected socket and hasn't received a RST packet yet, then the socket remains in the table until a timeout expires. When a vhost_vsock instance is released with the timeout still pending, the socket is never freed because vhost_vsock has already set the SOCK_DONE f

Re: [PATCH 1/2] vmalloc: New flag for flush before releasing pages

2018-12-06 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 19:54, Andy Lutomirski wrote: > > > On Dec 5, 2018, at 11:29 PM, Ard Biesheuvel > > wrote: > > > >> On Thu, 6 Dec 2018 at 00:16, Andy Lutomirski wrote: > >> > >>> On Wed, Dec 5, 2018 at 3:41 AM Will Deacon wrote: > >>> > On Tue, Dec 04, 2018 at 12:09:49PM -0800, Andy

  1   2   3   >