Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Andrew Lunn
On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote: > +static int ksz_i2c_read_reg(struct i2c_client *client, u32 reg, u8 *val, > + unsigned int len) > +{ > + struct i2c_adapter *adapter = client->adapter; > + struct i2c_msg msg[2]; > + u8 txd[2];

Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-16 Thread Andrew Lunn
On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote: > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos > --- > .../devicetree/bindings/net/dsa/ksz.txt | 50 +++ >

Re: [PATCH net-next] Documentation: networking: Clarify switchdev devices behavior

2018-12-16 Thread Ido Schimmel
On Wed, Dec 12, 2018 at 03:09:43PM -0800, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a number of things that > recently came up d

Re: [PATCH net-next 0/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread Heiner Kallweit
On 15.12.2018 17:17, Heiner Kallweit wrote: > If we detect a MDIO error, it seems to be a little bit too aggressive > to stop the state machine and bring down the PHY completely. > E.g. when polling and we miss one update, then this has no relevant > impact. > > Heiner Kallweit (2): > net: phy:

Re: [PATCH 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-16 Thread Sergio Paracuellos
On Sun, Dec 16, 2018 at 9:18 AM Andrew Lunn wrote: > > On Sun, Dec 16, 2018 at 08:57:41AM +0100, Sergio Paracuellos wrote: > > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > > > Cc: devicet...@vger.kernel.org > > Signed-off-by: Sergio Paracuellos > > --- > > .../d

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Sergio Paracuellos
On Sun, Dec 16, 2018 at 9:15 AM Andrew Lunn wrote: > > On Sun, Dec 16, 2018 at 08:57:40AM +0100, Sergio Paracuellos wrote: > > +static int ksz_i2c_read_reg(struct i2c_client *client, u32 reg, u8 *val, > > + unsigned int len) > > +{ > > + struct i2c_adapter *adapter = cl

Re: [PATCH net-next 1/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread Andrew Lunn
On Sat, Dec 15, 2018 at 05:18:33PM +0100, Heiner Kallweit wrote: > If we detect a MDIO error, it seems to be a little bit too aggressive > to stop the state machine and bring down the PHY completely. Hi Heiner My assumption is, if we get one MDIO error, we will gets lots more MDIO errors. This sh

Re: [PATCH 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Andrew Lunn
> I'll change these two to to get memory from kernel allocators instead > of using the stack. Thanks for let me know this. There appear to be other cases as well. Please review the whole driver. Thanks Andrew

[PATCH net-next 12/12] selftests: mlxsw: Add Bloom delta test

2018-12-16 Thread Ido Schimmel
From: Nir Dotan The eRP table is active when there is more than a single rule pattern. It may be that the patterns are close enough and use delta mechanism. Bloom filter index computation is based on the values of {rule & mask, mask ID, region ID} where the rule delta bits must be cleared. Add a

[PATCH net-next 09/12] mlxsw: reg: Activate Bloom filter

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Now that mlxsw driver handles all aspects of updating the Bloom filter mechanism, set bf_bypass value to false and allow HW to use Bloom filter. Signed-off-by: Nir Dotan Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/reg.h | 4 ++-- 1 file changed, 2 inser

[PATCH net-next 11/12] selftests: mlxsw: Add Bloom filter complex test

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Bloom filter index computation is based on the values of {rule & mask, mask ID, region ID} and the computation also varies according to the region key size. Add a test that exercises the possible combinations by creating multiple chains using different key sizes and then pass a f

[PATCH net-next 02/12] mlxsw: resources: Add Spectrum-2 Bloom filter resource

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Add the maximum Bloom filter logarithmic size per eRP table bank. Signed-off-by: Nir Dotan Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/resources.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/resources.h b/d

[PATCH net-next 08/12] mlxsw: spectrum_acl: Set master RP index on transition to eRP

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Bloom filter is updated on transitions from a single rule pattern, also called master RP, to eRP table and vice versa. Since rules are being written to or deleted from the Bloom filter on such transitions, it is not required to keep the same eRP bank ID for the master RP. Change

[PATCH net-next 10/12] selftests: mlxsw: Add Bloom filter simple test

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Add a test that exercises Bloom filter code. Activate eRP table in the region by adding multiple rule patterns which with very high probability use different entries in the Bloom filter. Then send packets in order to check lookup hits on all relevant rules. Signed-off-by: Nir Dot

[PATCH net-next 05/12] mlxsw: spectrum_acl: Add Bloom filter update

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Add Bloom filter update for rule insertion and rule removal scenarios. This is done within eRP module in order to assure that Bloom filter updates are done only for rules which are part of an eRP, as HW does not consult Bloom filter for entries when there is a single (master) mask

[PATCH net-next 01/12] mlxsw: reg: Add Policy Engine Algorithmic Bloom Filter Entries Register

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Bloom filter is a bit vector which allows the HW a fast lookup on a small size bit vector, that may reduce the number of lookups on the A-TCAM memory. PEABFE register allows setting values to the bits of the bit vector mentioned above. Add the register to be later used in A-TCAM o

[PATCH net-next 03/12] mlxsw: spectrum_acl: Introduce Bloom filter

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Lay the foundations for Bloom filter handling. Introduce a new file for Bloom filter actions. Add struct mlxsw_sp_acl_bf to struct mlxsw_sp_acl_erp_core and initialize the Bloom filter data structure. Also take care of proper destruction when terminating. Signed-off-by: Nir Dota

[PATCH net-next 00/12] mlxsw: spectrum_acl: Add Bloom filter support

2018-12-16 Thread Ido Schimmel
Nir says: Spectrum-2 uses Bloom filter to reduce the number of lookups in the algorithmic TCAM (A-TCAM). HW performs multiple exact match lookups in a given region using a key composed of { packet & mask, mask ID, region ID }. The masks which are used in a region are called rule patterns or RP. Wh

[PATCH net-next 04/12] mlxsw: spectrum_acl: Add Bloom filter handling

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Spectrum-2 HW uses Bloom filter in order to skip lookups on specific eRPs. It uses crc-16-Msbit-first calculation over a specific layout of a rule's key fields combined with eRP ID as well as region ID. Per potential lookup, iff the Bloom filter entry of the calculated index is em

[PATCH net-next 06/12] mlxsw: spectrum_acl: Set A-TCAM rules in Bloom filter

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Add calls to eRP module for updating Bloom filter when a rule is added or removed from the A-TCAM. eRP module will update the Bloom filter only for cases in which the region has an active eRP table. Signed-off-by: Nir Dotan Signed-off-by: Ido Schimmel --- .../net/ethernet/mell

[PATCH net-next 07/12] mlxsw: spectrum_acl: Update Bloom filter on eRP transitions

2018-12-16 Thread Ido Schimmel
From: Nir Dotan Bloom filter update is required only for rules which reside on an eRP. When the region has only a single rule pattern then eRP table is not used, however insertion of another pattern would trigger a move to an active eRP table so it is imperative to update the Bloom filter with al

Re: [PATCH net-next 1/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 09:42, Andrew Lunn wrote: > On Sat, Dec 15, 2018 at 05:18:33PM +0100, Heiner Kallweit wrote: >> If we detect a MDIO error, it seems to be a little bit too aggressive >> to stop the state machine and bring down the PHY completely. > > Hi Heiner > > My assumption is, if we get one MDI

[PATCH v2 1/2] net: dsa: ksz9477: add I2C managed mode support

2018-12-16 Thread Sergio Paracuellos
In this mode the switch device and the internal phys will be managed via I2C interface. Signed-off-by: Sergio Paracuellos --- Changes v2: - Use dev->txbuf as transmition buffer which is allocated using kernel allocators avoiding some possible DMA issues using the stack. drivers/n

[PATCH v2 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-16 Thread Sergio Paracuellos
Add device-tree binding example of the ksz9477 switch managed in i2c mode. Cc: devicet...@vger.kernel.org Signed-off-by: Sergio Paracuellos --- Changes v2: - Use generic name for label of the switch and make sure reg and @X have the same value. .../devicetree/bindings/net/dsa/ksz.txt

[PATCH v5 0/6] net: lorawan: Add LoRaWAN soft MAC module

2018-12-16 Thread Jian-Hong Pan
LoRaWAN(TM) is the MAC layer defined by LoRa Alliance(TM) over LoRa devices. LoRa is one of Low-Power Wide-Area Network (LPWAN) technology. LoRaWAN networks typically are laid out in a star-of-stars topology in which gateways relay messages between end-devices and a central network server at the

[PATCH v5 1/6] net: lorawan: Add LoRaWAN socket module

2018-12-16 Thread Jian-Hong Pan
This patch adds a new address/protocol family for LoRaWAN network. It also implements the the functions and maps to Datagram socket for LoRaWAN unconfirmed data messages. Signed-off-by: Jian-Hong Pan --- V2: - Split the LoRaWAN class module patch in V1 into LoRaWAN socket and LoRaWAN Soft MAC m

[PATCH v5 3/6] net: maclorawan: Add maclorawan module declaration

2018-12-16 Thread Jian-Hong Pan
Add the maclorawan header file for common APIs in the module. Signed-off-by: Jian-Hong Pan --- V2: - Split the LoRaWAN class module patch in V1 into LoRaWAN socket and LoRaWAN Soft MAC modules - Use SPDX license identifiers V4: - Fix typo in comments - Fix by coding style report from scripts/c

[PATCH v5 4/6] net: maclorawan: Implement the crypto of maclorawan module

2018-12-16 Thread Jian-Hong Pan
Implement the crypto for encryption/decryption and message integrity code (MIC) according to LoRaWAN(TM) Specification Ver. 1.0.2. Signed-off-by: Jian-Hong Pan --- V2: - Split the LoRaWAN class module patch in V1 into LoRaWAN socket and LoRaWAN Soft MAC modules - Rename the lrwsec files to cryp

[PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-16 Thread Jian-Hong Pan
List LORAWAN and MACLORAWAN in menuconfig and make they can be built. Signed-off-by: Jian-Hong Pan --- V2: - Split the LoRaWAN class module patch in V1 into LoRaWAN socket and LoRaWAN Soft MAC modules net/Kconfig | 2 ++ net/Makefile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/net

[PATCH v5 2/6] net: lorawan: Add LoRaWAN API declaration for LoRa devices

2018-12-16 Thread Jian-Hong Pan
Add public LoRaWAN API for compatible LoRa device drivers. Signed-off-by: Jian-Hong Pan --- V2: - Split the LoRaWAN class module patch in V1 into LoRaWAN socket and LoRaWAN Soft MAC modules - Merge the lrw_operations: set_bw, set_mod, set_sf into set_dr - Use SPDX license identifiers V3: - Rem

[PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-16 Thread Jian-Hong Pan
LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. This patch implements part of Class A end-devices SoftMAC defined in LoRaWAN(TM) Specification Ver. 1.0.2: 1. End-device receive slot timing 2. Only single channel and single data rate for now 3. Unconfirmed data up/down mess

[PATCH net-next] net: phy: improve phy state checking

2018-12-16 Thread Heiner Kallweit
Add helpers phy_is_started() and __phy_is_started() to avoid open-coded checks whether PHY has been started. To make the check easier move PHY_HALTED before PHY_UP in enum phy_state. Further improvements: phy_start_aneg(): Return -EBUSY and print warning if function is called from a non-started st

[PATCH v2 net-next] net: phy: improve phy state checking

2018-12-16 Thread Heiner Kallweit
Add helpers phy_is_started() and __phy_is_started() to avoid open-coded checks whether PHY has been started. To make the check easier move PHY_HALTED before PHY_UP in enum phy_state. Further improvements: phy_start_aneg(): Return -EBUSY and print warning if function is called from a non-started st

[PATCH] bonding: fix indentation issues, remove extra spaces

2018-12-16 Thread Colin King
From: Colin Ian King There are two statements that are indented too much by one space each, fix these. Signed-off-by: Colin Ian King --- drivers/net/bonding/bond_3ad.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/b

[PATCH] can: m_can: fix overly indented if statement

2018-12-16 Thread Colin King
From: Colin Ian King There is an if statement that is indented too much by one level, remove the extra tab to fix this. Signed-off-by: Colin Ian King --- drivers/net/can/m_can/m_can.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/can/m_can/m_can.c b/driv

[PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test

2018-12-16 Thread Luca Boccassi
Signed-off-by: Luca Boccassi --- v2: fixed copypasta in log message testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_default_route.t index 569ba1f8..ded4edc3 100755 ---

[PATCH iproute2 v2 1/4] Makefile: have check target depend on all

2018-12-16 Thread Luca Boccassi
Otherwise it will simply fail immediately from a just-cleaned workspace: $ make check -j1 cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Makefile:3: ../../config.mk: No such file or directory make[2]: *** No

[PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
The tunnel test leaves behind link devices created by the GRE kernel modules: $ ip -br link ... gre0@NONEDOWN 0.0.0.0 gretap0@NONE DOWN 00:00:00:00:00:00 erspan0@NONE DOWN 00:00:00:00:00:00 ip6tnl0@NONE DOWN :: ip6gre0@NONE DOWN 00:00:00:00: $ lsmod | grep gre ip6_gre 40960 0 ip6_tu

[PATCH iproute2 v2 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

2018-12-16 Thread Luca Boccassi
Parallel make from the top level directory fails since tests are at the same time as generate_nlmsg: $ make check -j4 ... cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Removing results dir ... make[1]: ./

Re: [PATCH iproute2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
On Sat, 2018-12-15 at 18:37 +0100, Petr Vorel wrote: > Hi Luca, > > > The tunnel test leaves behind link devices created by the GRE > > kernel > > modules: > > $ ip -br link > > ... > > gre0@NONEDOWN 0.0.0.0 > > gretap0@NONE DOWN 00:00:00:00:00:00 > > erspan0@NONE DOWN 00:00:00:00:00:00 > >

Re: [PATCH iproute2 3/4] tests: delete dummy interface after default route test

2018-12-16 Thread Luca Boccassi
On Sat, 2018-12-15 at 17:32 +0100, Petr Vorel wrote: > Hi Luca, > > > Signed-off-by: Luca Boccassi > > Reviewed-by: Petr Vorel > > --- > >  testsuite/tests/ip/route/add_default_route.t | 2 ++ > >  1 file changed, 2 insertions(+) > > diff --git a/testsuite/tests/ip/route/add_default_route.t > >

[PATCH net-next] net: fec: remove workaround to restart phylib state machine on MDIO timeout

2018-12-16 Thread Heiner Kallweit
There's a workaround to restart the phylib state machine in case of a MDIO access timeout. Seems it was introduced to deal with the consequences of a too small MDIO timeout. See also commit message of c3b084c24c8a ("net: fec: Adjust ENET MDIO timeouts") which increased the timeout value later. Due

[PATCH] bpf: promote bpf_perf_event.h to mandatory UAPI header

2018-12-16 Thread Masahiro Yamada
Since commit c895f6f703ad ("bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type"), all architectures (except um) are required to have bpf_perf_event.h in uapi/asm. Add it to mandatory-y so "make headers_install" can check it. Signed-off-by: Masahiro Yamada --- include/uapi/asm-g

Re: [PATCH net-next 1/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread Andrew Lunn
> After checking the fec history it seems that at the time this > workaround was added as part of phylib support (8 years ago), > the MDIO access timeout value was too low and therefore sometimes > MDIO access failed. Later timeout was set to a higher value and > driver switched to an event-driven

[PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
So far phy_error() silently stops the PHY state machine. If the network driver doesn't inform about a MDIO error then the user may wonder why his network is down. So let's inform the user. Signed-off-by: Heiner Kallweit --- drivers/net/phy/phy.c | 2 ++ 1 file changed, 2 insertions(+) diff --g

[PATCH net-next] net: ipv4: allocate ipv4_devconf memory for init_net

2018-12-16 Thread xiangxia . m . yue
From: Tonghao Zhang The devconf setting on the init_net will affect other namespace when them created. For example: $ cat /proc/sys/net/ipv4/conf/all/rp_filter 0 $ echo 2 > /proc/sys/net/ipv4/conf/all/rp_filter $ cat /proc/sys/net/ipv4/conf/all/rp_filter 2 $ ip netns add ns100 $ ip netns exec n

Re: [PATCH net-next v2 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-12-16 Thread Vlad Buslov
On Thu 13 Dec 2018 at 23:32, Cong Wang wrote: > On Tue, Dec 11, 2018 at 2:19 AM Vlad Buslov wrote: >> >> As a part of the effort to remove dependency on rtnl lock, cls API is being >> converted to use fine-grained locking mechanisms instead of global rtnl >> lock. However, chain_head_change callb

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Guillaume Nault
On Fri, Dec 14, 2018 at 07:59:21PM +0200, Sam Protsenko wrote: > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > in PPP packet will be received without leading 0x00. See section 6.5 in > RFC 1661 for details. So let's decompress protocol field if needed, the > same way it's

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Guillaume Nault
On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > in PPP packet should be transmitted without leading 0x00. See section > 6.5 in RFC 1661 for details. Let's compress protocol field if needed, > the same way it's

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Andrew Lunn
On Sun, Dec 16, 2018 at 04:52:21PM +0100, Heiner Kallweit wrote: > So far phy_error() silently stops the PHY state machine. If the network > driver doesn't inform about a MDIO error then the user may wonder why > his network is down. So let's inform the user. > > Signed-off-by: Heiner Kallweit

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : > So far phy_error() silently stops the PHY state machine. If the network > driver doesn't inform about a MDIO error then the user may wonder why > his network is down. So let's inform the user. > > Signed-off-by: Heiner Kallweit Reviewed-by: Flo

Re: [PATCH net-next] Documentation: networking: Clarify switchdev devices behavior

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 12:25 AM, Ido Schimmel a écrit : > On Wed, Dec 12, 2018 at 03:09:43PM -0800, Florian Fainelli wrote: >> This patch provides details on the expected behavior of switchdev >> enabled network devices when operating in a "stand alone" mode, as well >> as when being bridge members. This cl

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:02, Florian Fainelli wrote: > Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >> So far phy_error() silently stops the PHY state machine. If the network >> driver doesn't inform about a MDIO error then the user may wonder why >> his network is down. So let's inform the user. >> >

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:02, Florian Fainelli wrote: > Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >> So far phy_error() silently stops the PHY state machine. If the network >> driver doesn't inform about a MDIO error then the user may wonder why >> his network is down. So let's inform the user. >> >

[PATCH v3 net-next] net: phy: improve phy state checking

2018-12-16 Thread Heiner Kallweit
Add helpers phy_is_started() and __phy_is_started() to avoid open-coded checks whether PHY has been started. To make the check easier move PHY_HALTED before PHY_UP in enum phy_state. Further improvements: phy_start_aneg(): Return -EBUSY and print warning if function is called from a non-started st

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 9:16 AM, Heiner Kallweit a écrit : > On 16.12.2018 18:02, Florian Fainelli wrote: >> Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : >>> So far phy_error() silently stops the PHY state machine. If the network >>> driver doesn't inform about a MDIO error then the user may wonder why

Re: [PATCH v3 net-next] net: phy: improve phy state checking

2018-12-16 Thread Florian Fainelli
Le 12/16/18 à 9:30 AM, Heiner Kallweit a écrit : > Add helpers phy_is_started() and __phy_is_started() to avoid open-coded > checks whether PHY has been started. To make the check easier move > PHY_HALTED before PHY_UP in enum phy_state. Further improvements: > > phy_start_aneg(): > Return -EBUSY

Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-16 Thread Vivien Didelot
On Sat, 15 Dec 2018 09:28:41 -0800, Florian Fainelli wrote: > > The first patch adds the base support for "dsa" interfaces. > > > > The second patch adds the boilerplate for the "mv88e6xxx" DSA driver, > > all using 32 registers of 16 bits, the switch ID being available in > > the port identifi

Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-16 Thread Florian Fainelli
Le 12/15/18 à 9:48 AM, Andrew Lunn a écrit : > On Sat, Dec 15, 2018 at 09:28:41AM -0800, Florian Fainelli wrote: >> Hi Vivien, >> >> Le 12/14/18 à 6:50 PM, Vivien Didelot a écrit : >>> This patch series adds support to pretty dump the registers of user >>> ports created by the kernel "dsa" subsyste

Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-16 Thread Vivien Didelot
Hi Andrew, On Sat, 15 Dec 2018 18:48:49 +0100, Andrew Lunn wrote: > > > The first patch adds the base support for "dsa" interfaces. > > > > > > The second patch adds the boilerplate for the "mv88e6xxx" DSA driver, > > > all using 32 registers of 16 bits, the switch ID being available in > > > th

Re: [PATCH net-next] net: phy: print error message in phy_error

2018-12-16 Thread Heiner Kallweit
On 16.12.2018 18:55, Florian Fainelli wrote: > Le 12/16/18 à 9:16 AM, Heiner Kallweit a écrit : >> On 16.12.2018 18:02, Florian Fainelli wrote: >>> Le 12/16/18 à 7:52 AM, Heiner Kallweit a écrit : So far phy_error() silently stops the PHY state machine. If the network driver doesn't infor

[PATCH v2 net-next] net: phy: print stack trace in phy_error

2018-12-16 Thread Heiner Kallweit
So far phy_error() silently stops the PHY state machine. If the network driver doesn't inform about a MDIO error then the user may wonder why his network is down. Let's print the stack trace to facilitate search for the root cause of the error. Signed-off-by: Heiner Kallweit --- drivers/net/phy

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Sam Protsenko
Hi Guillaume, On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 07:59:21PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet will be received without leading 0x00. See section 6.5 in > > RFC 16

Re: [PATCH net-next 0/2] net: phy: don't stop state machine in case of MDIO error

2018-12-16 Thread David Miller
From: Heiner Kallweit Date: Sun, 16 Dec 2018 09:29:16 +0100 > On 15.12.2018 17:17, Heiner Kallweit wrote: >> If we detect a MDIO error, it seems to be a little bit too aggressive >> to stop the state machine and bring down the PHY completely. >> E.g. when polling and we miss one update, then this

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Sam Protsenko
Hi Guillaume, On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > in PPP packet should be transmitted without leading 0x00. See section > > 6.5 in R

Re: [PATCH net-next v2 01/17] net: sched: refactor mini_qdisc_pair_swap() to use workqueue

2018-12-16 Thread Cong Wang
On Sun, Dec 16, 2018 at 8:32 AM Vlad Buslov wrote: > > On Thu 13 Dec 2018 at 23:32, Cong Wang wrote: > > On Tue, Dec 11, 2018 at 2:19 AM Vlad Buslov wrote: > >> > >> As a part of the effort to remove dependency on rtnl lock, cls API is being > >> converted to use fine-grained locking mechanisms

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread Paolo Abeni
On Sat, 2018-12-15 at 13:23 -0800, David Miller wrote: > From: Paolo Abeni > Date: Fri, 14 Dec 2018 11:51:56 +0100 > > > The spectre v2 counter-measures, aka retpolines, are a source of measurable > > overhead[1]. We can partially address that when the function pointer refers > > to > > a builti

Re: [PATCH net-next] net: ipv4: allocate ipv4_devconf memory for init_net

2018-12-16 Thread Cong Wang
On Sun, Dec 16, 2018 at 8:24 AM wrote: > > From: Tonghao Zhang > > The devconf setting on the init_net will affect other > namespace when them created. For example: > > $ cat /proc/sys/net/ipv4/conf/all/rp_filter > 0 > $ echo 2 > /proc/sys/net/ipv4/conf/all/rp_filter > $ cat /proc/sys/net/ipv4/co

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread David Miller
From: Paolo Abeni Date: Sun, 16 Dec 2018 19:55:40 +0100 > Again, I messed it! I'm really sorry to waste everybody's time. > I was unable to give proper coverage with different configs. I tested > vs.: > > CONFIG_IPV6=ymn > CONFIG_INET=yn > > but > > # CONFIG_RETPOLINE is not set > > fooled me

Re: [PATCH] l2tp: Add protocol field decompression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:36:42PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:29 PM Guillaume Nault wrote: > > > > If you all agree, can we please revert this patch and properly > > implement PFC in ppp_generic.c? > > How about instead of reverting I will try to pr

Re: [PATCH 2/2] l2tp: Add Protocol field compression

2018-12-16 Thread Guillaume Nault
On Sun, Dec 16, 2018 at 08:46:19PM +0200, Sam Protsenko wrote: > Hi Guillaume, > > On Sun, Dec 16, 2018 at 6:30 PM Guillaume Nault wrote: > > > > On Fri, Dec 14, 2018 at 11:12:42PM +0200, Sam Protsenko wrote: > > > When Protocol Field Compression (PFC) is enabled, the "Protocol" field > > > in PP

Re: [PATCH] vhost: return EINVAL if iovecs size does not match the message size

2018-12-16 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:46:11AM -0800, David Miller wrote: > From: Pavel Tikhomirov > Date: Thu, 13 Dec 2018 17:53:50 +0300 > > > We've failed to copy and process vhost_iotlb_msg so let userspace at > > least know about it. For instance before these patch the code below runs > > without any er

[PATCH] [v2] test_rhashtable: remove semaphore usage

2018-12-16 Thread Arnd Bergmann
This is one of only two files that initialize a semaphore to a negative value. We don't really need the two semaphores here at all, but can do the same thing in more conventional and more effient way, by using a single waitqueue and an atomic thread counter. This gets us a little bit closer to eli

Re: [PATCH] test_rhashtable: remove semaphore usage

2018-12-16 Thread Arnd Bergmann
On Fri, Dec 14, 2018 at 10:25 PM David Miller wrote: > > From: Arnd Bergmann > Date: Mon, 10 Dec 2018 22:17:20 +0100 > > > @@ -635,8 +636,9 @@ static int threadfunc(void *data) > > int i, step, err = 0, insert_retries = 0; > > struct thread_data *tdata = data; > > > > - up(&presta

Re: [PATCH net-next 0/3] vhost: accelerate metadata access through vmap()

2018-12-16 Thread Michael S. Tsirkin
On Sat, Dec 15, 2018 at 11:43:08AM -0800, David Miller wrote: > From: Jason Wang > Date: Fri, 14 Dec 2018 12:29:54 +0800 > > > > > On 2018/12/14 上午4:12, Michael S. Tsirkin wrote: > >> On Thu, Dec 13, 2018 at 06:10:19PM +0800, Jason Wang wrote: > >>> Hi: > >>> > >>> This series tries to access vi

Re: [PATCH 0/7] ethtool: add pretty dump for DSA mv88e6xxx drivers

2018-12-16 Thread Andrew Lunn
> > Hi Florian, Vivien > > > > I was wondering about that. Having this all under 'dsa' seems too > > granular. It would be better if we could have 'mv88e6xxx', 'b53', > > 'ksz', etc. That might need a new DSA driver op to get the driver name > > which we then use for the slave? > > We could indee

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread Willem de Bruijn
On Sun, Dec 16, 2018 at 2:19 PM David Miller wrote: > > From: Paolo Abeni > Date: Sun, 16 Dec 2018 19:55:40 +0100 > > > Again, I messed it! I'm really sorry to waste everybody's time. > > I was unable to give proper coverage with different configs. I tested > > vs.: > > > > CONFIG_IPV6=ymn > > CO

Re: [Patch net 00/10] net: hns: Code improvements & fixes for HNS driver

2018-12-16 Thread David Miller
From: Peng Li Date: Sat, 15 Dec 2018 11:53:19 +0800 > This patchset introduces some code improvements and fixes > for the identified problems in the HNS driver. > > Every patch is independent. Series applied, thank you.

Re: [PATCH iproute2 v2 3/4] testsuite: delete dummy interface after default route test

2018-12-16 Thread Petr Vorel
Hi Luca, > Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel > --- > v2: fixed copypasta in log message Kind regards, Petr

Re: [PATCH net-next 1/2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread David Miller
From: Peter Oskolkov Date: Sat, 15 Dec 2018 14:27:23 -0800 > Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" > removes port-only listener lookups. This caused segfaults in DCCP > lookups because DCCP did not initialize the (addr,port) hashtable. > > This patch adds said init

Re: [PATCH net-next 2/2] selftests: net: reuseport_addr_any: add DCCP

2018-12-16 Thread David Miller
From: Peter Oskolkov Date: Sat, 15 Dec 2018 14:27:24 -0800 > This patch adds coverage of DCCP to reuseport_addr_any selftest. > > Signed-off-by: Peter Oskolkov Applied.

Re: [PATCH net-next] neighbor: Add protocol attribute

2018-12-16 Thread David Miller
From: David Ahern Date: Sat, 15 Dec 2018 14:09:06 -0800 > From: David Ahern > > Similar to routes and rules, add protocol attribute to neighbor entries > for easier tracking of how each was created. > > Signed-off-by: David Ahern Applied, thanks David.

Re: [PATCH net-next 0/5] tcp: Introduce a TFO key-pool for clean cookie-rotation

2018-12-16 Thread David Miller
From: Christoph Paasch Date: Fri, 14 Dec 2018 14:40:02 -0800 > Currently, TFO only allows a single TFO-secret. This means that whenever > the secret gets changed for key-rotation purposes, all the previously > issued TFO-cookies become invalid. This means that clients will fallback > to "regular"

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Petr Vorel
Hi Luca, Reviewed-by: Petr Vorel LGTM, but I'd suggest 2 small changes (see bellow). > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > TUNNEL_NAME="tunnel_test_ip" I'd put KMODS here: KMODS="ip6_gre ip6_tunnel ip_gre ip_tunnel gre" The reason is maintenance of this script - maybe one day there

Re: [PATCH net-next 1/2] net: dccp: initialize (addr,port) listening hashtable

2018-12-16 Thread David Miller
From: David Miller Date: Sun, 16 Dec 2018 12:14:50 -0800 (PST) > From: Peter Oskolkov > Date: Sat, 15 Dec 2018 14:27:23 -0800 > >> Commit d9fbc7f6431f "net: tcp: prefer listeners bound to an address" >> removes port-only listener lookups. This caused segfaults in DCCP >> lookups because DCCP di

Re: [PATCH net] net: mvneta: fix operation for 64K PAGE_SIZE

2018-12-16 Thread David Miller
From: Marcin Wojtas Date: Tue, 11 Dec 2018 13:56:49 +0100 > Recent changes in the mvneta driver reworked allocation > and handling of the ingress buffers to use entire pages. > Apart from that in SW BM scenario the HW must be informed > via PRXDQS about the biggest possible incoming buffer > that

Re: [PATCH net-next] nfp: abm: allow to opt-out of RED offload

2018-12-16 Thread David Miller
From: Jakub Kicinski Date: Fri, 14 Dec 2018 15:01:54 -0800 > FW team asks to be able to not support RED even if NIC is capable > of buffering for testing and experimentation. Add an opt-out flag. > > Signed-off-by: Jakub Kicinski > Reviewed-by: Dirk van der Merwe Applied, thanks Jakub.

[PATCH iproute2 v3 1/4] Makefile: have check target depend on all

2018-12-16 Thread Luca Boccassi
Otherwise it will simply fail immediately from a just-cleaned workspace: $ make check -j1 cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Makefile:3: ../../config.mk: No such file or directory make[2]: *** No

[PATCH iproute2 v3 3/4] testsuite: delete dummy interface after default route test

2018-12-16 Thread Luca Boccassi
Signed-off-by: Luca Boccassi Reviewed-by: Petr Vorel --- v2: fixed copypasta in log message v3: added reviewed-by tag testsuite/tests/ip/route/add_default_route.t | 2 ++ 1 file changed, 2 insertions(+) diff --git a/testsuite/tests/ip/route/add_default_route.t b/testsuite/tests/ip/route/add_d

[PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
The tunnel test leaves behind link devices created by the GRE kernel modules: $ ip -br link ... gre0@NONEDOWN 0.0.0.0 gretap0@NONE DOWN 00:00:00:00:00:00 erspan0@NONE DOWN 00:00:00:00:00:00 ip6tnl0@NONE DOWN :: ip6gre0@NONE DOWN 00:00:00:00: $ lsmod | grep gre ip6_gre 40960 0 ip6_tu

[PATCH iproute2 v3 2/4] testsuite: declare dependency between $(TESTS) and generate_nlmsg

2018-12-16 Thread Luca Boccassi
Parallel make from the top level directory fails since tests are at the same time as generate_nlmsg: $ make check -j4 ... cd testsuite && make && make alltests echo "Entering iproute2" && cd iproute2 && make configure && cd ..; Entering iproute2 make -C tools Removing results dir ... make[1]: ./

Re: [PATCH iproute2 v2 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Luca Boccassi
On Sun, 2018-12-16 at 21:21 +0100, Petr Vorel wrote: > Hi Luca, > > Reviewed-by: Petr Vorel > LGTM, but I'd suggest 2 small changes (see bellow). > > > +++ b/testsuite/tests/ip/tunnel/add_tunnel.t > >  TUNNEL_NAME="tunnel_test_ip" > > I'd put KMODS here: > KMODS="ip6_gre ip6_tunnel ip_gre ip_tu

Re: [PATCH/RFT net] ravb: expand rx descriptor data to accommodate hw checksum

2018-12-16 Thread Simon Horman
On Mon, Dec 10, 2018 at 07:56:14PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/10/2018 11:59 AM, Simon Horman wrote: > > > From: Simon Horman > > > > EtherAVB may provide a checksum of packet data appended to packet data. In > > order to allow this checksum to be received by the host descr

Re: [PATCH iproute2 v3 4/4] testsuite: remove gre kmods if the test loads them

2018-12-16 Thread Petr Vorel
Hi Luca, > Signed-off-by: Luca Boccassi > Reviewed-by: Petr Vorel Tested-by: Petr Vorel > --- > v2: applied suggestions from Petr to simplify the modules parsing/unloading > v3: ditto, added reviewed-by tag Kind regards, Petr

Re: [PATCH net-next v3 1/4] net: rtnetlink: support for fdb get

2018-12-16 Thread David Ahern
On 12/15/18 11:35 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > This patch adds support for fdb get similar to > route get. arguments can be any of the following (similar to fdb > add/del/dump): > [bridge, mac, vlan] or > [bridge_port, mac, vlan, flags=[NTF_MASTER]] or > [dev, mac, [vni|vlan]

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread NeilBrown
On Tue, Dec 11 2018, NeilBrown wrote: > > I got your patch working on 4.20-rc5 and did a performance comparison. > With the staging driver (using iperf3) I get > 220 MBit/sec in > 680 MBit/sec out > > with the patched mainline driver I get > 190 MBit/sec in >93 MBit/sec out > > (numbers

Re: [PATCH 0/3]: net: dsa: mt7530: support MT7530 in the MT7621 SoC

2018-12-16 Thread David Miller
From: NeilBrown Date: Mon, 17 Dec 2018 09:08:54 +1100 > In my 4.4 kernel, the build_skb() call in (the equivalent of) > mtk_poll_rx() takes about 1.2usec and the call to napi_gro_receive() > takes about 3usec. > > In my 4.20 kernel, these calls take about 30 and 24 usec respectively. > This easi

Re: [PATCH net 1/2] net: bpfilter: restart bpfilter_umh when error occurred

2018-12-16 Thread David Miller
From: Taehee Yoo Date: Sat, 15 Dec 2018 13:22:39 +0900 > If bpfilter_umh process is killed, shutdown_umh() is executed via > __stop_umh(). > because, __kernel_write() or kernel_read() will be failed in > __bpfilter_process_sockopt() if bpfilter_umh process had killed > or crashed. then, __bpfilt

Re: [PATCH V3 0/3] net: dsa: ksz: Clean up the tag code in prep for more switches

2018-12-16 Thread David Miller
From: Marek Vasut Date: Sat, 15 Dec 2018 01:58:03 +0100 > Clean up the KSZ DSA tag code in preparation for adding more switches. Series applied, thank you.

Re: [PATCH net-next v3 0/4] rtnl fdb get

2018-12-16 Thread David Miller
From: Roopa Prabhu Date: Sat, 15 Dec 2018 22:35:07 -0800 > From: Roopa Prabhu > > This series adds support for rtnl fdb get similar to > route get. > > v2: add nda_policy, fixes to exact msgs, strict nlmsg parsing > > v3: remove unnecessary attribute length checks + simplify code > as pointed

  1   2   >