Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Dan Carpenter
Do we still need Sergio's device tree patch? regards, dan carpenter

[PATCH v2] VSOCK: Send reset control packet when socket is partially bound

2018-12-18 Thread Jorgen Hansen
If a server side socket is bound to an address, but not in the listening state yet, incoming connection requests should receive a reset control packet in response. However, the function used to send the reset silently drops the reset packet if the sending socket isn't bound to a remote address (as

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Dmitry Vyukov
On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > On Mon, 17 Dec 2018 16:53:36 +0100 > Dmitry Vyukov wrote: > > > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio wrote: > > > > > > On Mon, 17 Dec 2018 06:57:35 -0800 > > > Eric Dumazet wrote: > > > > > > > Might be cause by commit b8a51b

Re: [PATCH net-next] net: phy: mscc: Fix the VSC 8530/31/40/41 Chips Init sequence

2018-12-18 Thread Sergei Shtylyov
Hello! On 18.12.2018 8:43, Raju Lakkaraju wrote: From: Raju Lakkaraju Fix the VSC 8530/31/40/41 Chips Init sequence - Turn on Broadcast writes - UNH 1.8.1 clear bias for UNH 1000BT distortion - UNH 1.8.7 optimize pre-emphasis for 100BasTx UNH 100W fix - Enable Token-ring during 'Coma Mode' S

Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Sergio Paracuellos
On Tue, Dec 18, 2018 at 9:06 AM Dan Carpenter wrote: > > Do we still need Sergio's device tree patch? I think is useful. If not at least add a clarification that the reg "5f" for the i2c is the one to use. > > regards, > dan carpenter > Thanks, Sergio Paracuellos

Re: [PATCH bpf-next v2 0/7] Add support for XDP_ATTACH

2018-12-18 Thread Björn Töpel
On 2018-12-18 03:36, Jakub Kicinski wrote: On Mon, 17 Dec 2018 14:39:57 +0100, Björn Töpel wrote: OTOH the implementation would probably look different if there was a per-q program, because this would open up for more optimizations. One could even imagine that the socket fd was part of the progr

[PATCH v1 net-next] net: phy: mscc: Fix the VSC 8531/41 Chip Init sequence

2018-12-18 Thread Raju Lakkaraju
From: Raju Lakkaraju - Turn on Broadcast writes - UNH 1.8.1 clear bias for UNH 1000BT distortion - UNH 1.8.7 optimize pre-emphasis for 100BasTx UNH 100W fix - Enable Token-ring during 'Coma Mode' Signed-off-by: Raju Lakkaraju --- v1: Fix the tag for the incriminating commit --- drivers/net/p

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-18 Thread Yunsheng Lin
On 2018/12/17 22:36, Russell King - ARM Linux wrote: > On Mon, Dec 17, 2018 at 05:42:20PM +0800, Yunsheng Lin wrote: >> On 2018/12/15 18:37, Russell King - ARM Linux wrote: >>> On Sat, Dec 15, 2018 at 04:07:42PM +0800, Yunsheng Lin wrote: There seems to be some problem with pause subsequent ne

Re: [PATCH net-next 0/2] net: phy: set 1Gbps as default for driver features

2018-12-18 Thread Andrew Lunn
On Tue, Dec 18, 2018 at 07:34:50AM +0100, Heiner Kallweit wrote: > Whether a PHY is 100Mbps or 1Gbps-capable can be autodetected, > therefore it's not needed to define this manually in the driver. > genphy_config_init() will remove 1Gbps from phydev->supported if > not supported. Having said that P

[PATCH net-next] tipc: handle broadcast NAME_DISTRIBUTOR packet when receiving it

2018-12-18 Thread Zhenbo Gao
NAME_DISTRIBUTOR messages are transmitted through unicast link on TIPC 2.0, by contrast, the messages are delivered through broadcast link on TIPC 1.7. But at present, NAME_DISTRIBUTOR messages received by broadcast link cannot be handled in tipc_rcv() until an unicast message arrives, which may le

Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Andrew Lunn
On Tue, Dec 18, 2018 at 07:24:52AM +0100, Sergio Paracuellos wrote: > > +static int ksz9477_i2c_read_reg(struct i2c_client *i2c, u32 reg, u8 *val, > > + unsigned int len) > > +{ > > + struct i2c_msg msg[2]; > > + int ret = 0; > > + > > + val[0] = (u8)

[PATCH] iptunnel: make some user care TUNNEL_FLAGS available in uapi

2018-12-18 Thread wenxu
From: wenxu ip l add dev tun type gretap external ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap For gretap Key example when the command set the id but don't set the TUNNEL_KEY flags. There is no key field in the send packet In the lwtunnel situation, some TUNNEL_FLAGS should c

[PATCH iproute2] iproute: lwtunnel set TUNNEL_KEY on LWTUNNEL_IP_FLAGS

2018-12-18 Thread wenxu
From: wenxu ip l add dev tun type gretap external ip r a 10.0.0.1 encap ip dst 192.168.152.171 id 1000 dev gretap For gretap example when the command set the id but don't set the TUNNEL_KEY flags. There is no key field in the send packet Signed-off-by: wenxu --- include/uapi/linux/if_tunnel.h

Re: Question: pause mode disabled for marvell 88e151x phy

2018-12-18 Thread Russell King - ARM Linux
On Tue, Dec 18, 2018 at 05:34:27PM +0800, Yunsheng Lin wrote: > On 2018/12/17 22:36, Russell King - ARM Linux wrote: > > As I've previously stated, the behaviour I've seen is _both_ pause bits > > clear: > > > > If I set bit 10 (pause), and read back to confirm: > > > > MII PHY #0 transceiver r

[PATCH V3 0/2] Replace all open encodings for NUMA_NO_NODE

2018-12-18 Thread Anshuman Khandual
Changes in V3: - Dropped all references to NUMA_NO_NODE as per Lubomir Rinetl - Split the patch into two creating a new one specifically for tools - Folded Stephen's linux-next build fix into the second patch Changes in V2: (https://patchwork.kernel.org/patch/10698089/) - Added inclusion of 'num

[PATCH V3 2/2] Tools: Replace open encodings for NUMA_NO_NODE

2018-12-18 Thread Anshuman Khandual
From: Stephen Rothwell This replaces all open encodings in tools with NUMA_NO_NODE. Also linux/numa.h is now needed for the perf build. Signed-off-by: Anshuman Khandual Signed-off-by: Stephen Rothwell --- tools/include/linux/numa.h | 16 tools/perf/bench/numa.c| 6 +++---

[PATCH V3 1/2] mm: Replace all open encodings for NUMA_NO_NODE

2018-12-18 Thread Anshuman Khandual
At present there are multiple places where invalid node number is encoded as -1. Even though implicitly understood it is always better to have macros in there. Replace these open encodings for an invalid node number with the global macro NUMA_NO_NODE. This helps remove NUMA related assumptions like

[PATCH bpf-next 1/2] tools: bpftool: attempt to mount tracefs if required for tracelog cmd

2018-12-18 Thread Quentin Monnet
As a follow-up to commit 30da46b5dc3a ("tools: bpftool: add a command to dump the trace pipe"), attempt to mount the tracefs virtual file system if it is not detected on the system before trying to dump content of the tracing pipe on an invocation of "bpftool prog tracelog". Usually, tracefs in au

[PATCH bpf-next 0/2] tools: bpftool: mount tracefs if needed and if desired

2018-12-18 Thread Quentin Monnet
Hi, This series focus on mounting (or not mounting) tracefs with bpftool. First patch makes bpftool attempt to mount tracefs if tracefs is not found when running "bpftool prog tracelog". Second patch adds an option to bpftool to prevent it from attempting to mount any file system (tracefs or bpff

[PATCH bpf-next 2/2] tools: bpftool: add an option to prevent auto-mount of bpffs, tracefs

2018-12-18 Thread Quentin Monnet
In order to make life easier for users, bpftool automatically attempts to mount the BPF virtual file system, if it is not mounted already, before trying to pin objects in it. Similarly, it attempts to mount tracefs if necessary before trying to dump the trace pipe to the console. While mounting fi

[PATCH 3/4] xfrm: Fix NULL pointer dereference in xfrm_input when skb_dst_force clears the dst_entry.

2018-12-18 Thread Steffen Klassert
Since commit 222d7dbd258d ("net: prevent dst uses after free") skb_dst_force() might clear the dst_entry attached to the skb. The xfrm code doesn't expect this to happen, so we crash with a NULL pointer dereference in this case. Fix it by checking skb_dst(skb) for NULL after skb_dst_force() and dr

pull request (net): ipsec 2018-12-18

2018-12-18 Thread Steffen Klassert
1) Fix error return code in xfrm_output_one() when no dst_entry is attached to the skb. From Wei Yongjun. 2) The xfrm state hash bucket count reported to userspace is off by one. Fix from Benjamin Poirier. 3) Fix NULL pointer dereference in xfrm_input when skb_dst_force clears the d

[PATCH 2/4] xfrm: Fix bucket count reported to userspace

2018-12-18 Thread Steffen Klassert
From: Benjamin Poirier sadhcnt is reported by `ip -s xfrm state count` as "buckets count", not the hash mask. Fixes: 28d8909bc790 ("[XFRM]: Export SAD info.") Signed-off-by: Benjamin Poirier Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_state.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 4/4] xfrm_user: fix freeing of xfrm states on acquire

2018-12-18 Thread Steffen Klassert
From: Mathias Krause Commit 565f0fa902b6 ("xfrm: use a dedicated slab cache for struct xfrm_state") moved xfrm state objects to use their own slab cache. However, it missed to adapt xfrm_user to use this new cache when freeing xfrm states. Fix this by introducing and make use of a new helper for

[PATCH 1/4] xfrm: Fix error return code in xfrm_output_one()

2018-12-18 Thread Steffen Klassert
From: Wei Yongjun xfrm_output_one() does not return a error code when there is no dst_entry attached to the skb, it is still possible crash with a NULL pointer dereference in xfrm_output_resume(). Fix it by return error code -EHOSTUNREACH. Fixes: 9e1437937807 ("xfrm: Fix NULL pointer dereference

[PATCH net-next 09/12] net: hns3: synchronize speed and duplex from phy when phy link up

2018-12-18 Thread Peng Li
Driver calls phy_connect_direct and registers hclge_mac_adjust_link to synchronize mac speed and duplex from phy. It is better to synchronize mac speed and duplex from phy when phy link up. Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 4 1 file change

[PATCH net-next 12/12] net: hns3: fix a SSU buffer checking bug

2018-12-18 Thread Peng Li
From: Yunsheng Lin When caculating the SSU buffer, it first allocate tx and rx private buffer, then the remaining buffer is for rx shared buffer. The remaining buffer size should be at least bigger than or equal to the shared_std, which is the minimum shared buffer size required by the driver, bu

[PATCH net-next 07/12] net: hns3: update coalesce param per second

2018-12-18 Thread Peng Li
coalesce param updates every 100 napi times, it may update a little late if ping test after a high rate flow, may over napi poll is called 100 times as ping test sends packets every second. This patch updates coalesce param every second, instead with every 100 napi times. It can not update the par

[PATCH net-next 03/12] net: hns3: fix napi_disable not return problem

2018-12-18 Thread Peng Li
From: Huazhong Tan While doing DOWN, the calling of napi_disable() may not return, since the napi_complete() in the hns3_nic_common_poll() will never be called when HNS3_NIC_STATE_DOWN is set. So we need to call napi_complete() before checking HNS3_NIC_STETE_DOWN. Fixes: ff0699e04b97 ("net: hns3

[PATCH net-next 06/12] net: hns3: fix incomplete uninitialization of IRQ in the hns3_nic_uninit_vector_data()

2018-12-18 Thread Peng Li
From: Huazhong Tan In the hns3_nic_uninit_vector_data(), the procedure of uninitializing the tqp_vector's IRQ has not set affinity_notify to NULL and changes its init flag. This patch fixes it. And for simplificaton, local variable tqp_vector is used instead of priv->tqp_vector[i]. Fixes: 424eb8

[PATCH net-next 04/12] net: hns3: update some variables while hclge_reset()/hclgevf_reset() done

2018-12-18 Thread Peng Li
From: Huazhong Tan When hclge_reset() completes successfully, it should update the last_reset_time, set reset_fail_cnt to 0, and set reset_type of hnae3_ae_dev to HNAE3_NONE_RESET. Also when hclgevf_reset() completes successfully, it should update the last_reset_time, and set reset_type of hnae3

[PATCH net-next 01/12] net: hns3: fix error handling int the hns3_get_vector_ring_chain

2018-12-18 Thread Peng Li
From: Huazhong Tan When hns3_get_vector_ring_chain() failed in the hns3_nic_init_vector_data(), it should do the error handling instead of return directly. Also, cur_chain should be freed instead of chain and head->next should be set to NULL in error handling of hns3_get_vector_ring_chain. This

[PATCH net-next 05/12] net: hns3: remove unnecessary configuration recapture while resetting

2018-12-18 Thread Peng Li
From: Huazhong Tan When doing reset, it is unnecessary to get the hardware's default configuration again, otherwise, the user's configuration will be overwritten. Fixes: 4ed340ab8f49 ("net: hns3: Add reset process in hclge_main") Signed-off-by: Huazhong Tan Signed-off-by: Peng Li --- drivers/

[PATCH net-next 10/12] net: hns3: getting tx and dv buffer size through firmware

2018-12-18 Thread Peng Li
From: Yunsheng Lin This patch adds support of getting tx and dv buffer size through firmware, because different version of hardware requires different size of tx and dv buffer. This patch also add dv_buf_size to tc' private buffer size even if pfc is not enable for the tc. Signed-off-by: Yunshe

[PATCH net-next 08/12] net: hns3: remove 1000M/half support of phy

2018-12-18 Thread Peng Li
From: Fuyun Liang Our phy does not support 1000M/half, this patch removes 1000M/half from PHY_SUPPORTED_FEATURES. Signed-off-by: Fuyun Liang Signed-off-by: Peng Li --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH net-next 11/12] net: hns3: aligning buffer size in SSU to 256 bytes

2018-12-18 Thread Peng Li
From: Yunsheng Lin The hardware expects the buffer size set to SSU is aligned to 256 bytes, this patch aligns the buffer size to 256 byte using roundup or rounddown function. Signed-off-by: Yunsheng Lin Signed-off-by: Peng Li --- .../ethernet/hisilicon/hns3/hns3pf/hclge_main.c| 43 +++

[PATCH net-next 02/12] net: hns3: uninitialize pci in the hclgevf_uninit

2018-12-18 Thread Peng Li
From: Huazhong Tan In the hclgevf_pci_reset(), it only uninitialize and initialize the msi, so if the initialization fails, hclgevf_uninit_hdev() does not need to uninitialize the msi, but needs to uninitialize the pci, otherwise it will cause pci resource not free. Fixes: 862d969a3a4d ("net: hn

[PATCH net-next 00/12] net: hns3: code optimizations & bugfixes for HNS3 driver

2018-12-18 Thread Peng Li
This patchset includes bugfixes and code optimizations for the HNS3 ethernet controller driver Fuyun Liang (1): net: hns3: remove 1000M/half support of phy Huazhong Tan (6): net: hns3: fix error handling int the hns3_get_vector_ring_chain net: hns3: uninitialize pci in the hclgevf_uninit

Re: [PATCH net v2 3/4] vxlan: changelink: Fix handling of default remotes

2018-12-18 Thread Petr Machata
Roopa Prabhu writes: > On Mon, Dec 17, 2018 at 3:44 PM Petr Machata wrote: >> >> Roopa Prabhu writes: >> >> Fixes: 0241b836732f ("vxlan: fix default fdb entry netlink notify >> >> ordering during netdev create") >> >> Signed-off-by: Petr Machata >> >> --- >> > >> > Acked-by: Roopa Prabhu >>

Re: [PATCH v2] net/smc: fix TCP fallback socket release

2018-12-18 Thread Ursula Braun
On 12/18/2018 08:03 AM, Myungho Jung wrote: > On Mon, Dec 17, 2018 at 03:58:58PM +0100, Ursula Braun wrote: >> > > Hi Ursula, > > Thank you for your suggestion. I have a question on your comment. > >> >> On 12/17/2018 06:21 AM, Myungho Jung wrote: >>> clcsock can be released while kernel_acce

Re: selftests/net: udpgso: LTS kernels supportability ?

2018-12-18 Thread Rafael David Tinoco
On 12/17/18 4:42 PM, shuah wrote: > Hi Rafael, > > On 12/17/18 10:53 AM, Rafael David Tinoco wrote: >> Shuah, >> >> I was recently investigating some errors coming out of our functional >> tests and we, Dan and I, came up with a discussion that might not be new >> for you, but, interests us, in de

[PATCH 01/17] selftests: add xfrm policy test script

2018-12-18 Thread Steffen Klassert
From: Florian Westphal add a script that adds a ipsec tunnel between two network namespaces plus following policies: .0/24 -> ipsec tunnel .240/28 -> bypass .253/32 -> ipsec tunnel Then check that .254 bypasses tunnel (match /28 exception), and .2 (match /24) and .253 (match direct policy) pass

[PATCH 15/17] xfrm6: remove BUG_ON from xfrm6_dst_ifdown

2018-12-18 Thread Steffen Klassert
From: Li RongQing if loopback_idev is NULL pointer, and the following access of loopback_idev will trigger panic, which is same as BUG_ON Signed-off-by: Li RongQing Signed-off-by: Steffen Klassert --- net/ipv6/xfrm6_policy.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/xfrm6_po

[PATCH 17/17] xfrm: clean an indentation issue, remove a space

2018-12-18 Thread Steffen Klassert
From: Colin Ian King Trivial fix to clean up indentation issue, remove an extraneous space. Signed-off-by: Colin Ian King Signed-off-by: Steffen Klassert --- include/net/xfrm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/net/xfrm.h b/include/net/xfrm.h index fa

[PATCH 16/17] xfrm: policy: fix policy hash rebuild

2018-12-18 Thread Steffen Klassert
From: Florian Westphal Dan Carpenter reports following static checker warning: net/xfrm/xfrm_policy.c:1316 xfrm_hash_rebuild() warn: 'dir' is out of bounds '3' vs '2' | 1280 /* reset the bydst and inexact table in all directions */ | 1281 xfrm_hash_reset_inexact_table(net

[PATCH 07/17] xfrm: policy: add inexact policy search tree infrastructure

2018-12-18 Thread Steffen Klassert
From: Florian Westphal At this time inexact policies are all searched in-order until the first match is found. After removal of the flow cache, this resolution has to be performed for every packetm resulting in major slowdown when number of inexact policies is high. This adds infrastructure to

[PATCH 08/17] xfrm: policy: store inexact policies in a tree ordered by destination address

2018-12-18 Thread Steffen Klassert
From: Florian Westphal This adds inexact lists per destination network, stored in a search tree. Inexact lookups now return two 'candidate lists', the 'any' policies ('any' destionations), and a list of policies that share same daddr/prefix. Next patch will add a second search tree for 'saddr:a

[PATCH 10/17] xfrm: policy: store inexact policies in a tree ordered by source address

2018-12-18 Thread Steffen Klassert
From: Florian Westphal This adds the 'saddr:any' search class. It contains all policies that have a fixed saddr/prefixlen, but 'any' destination. Signed-off-by: Florian Westphal Acked-by: David S. Miller Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 46 +++

[PATCH 03/17] xfrm: policy: split list insertion into a helper

2018-12-18 Thread Steffen Klassert
From: Florian Westphal ... so we can reuse this later without code duplication when we add policy to a second inexact list. Signed-off-by: Florian Westphal Acked-by: David S. Miller Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 43 ++ 1

[PATCH 06/17] xfrm: policy: consider if_id when hashing inexact policy

2018-12-18 Thread Steffen Klassert
From: Florian Westphal This avoids searches of polices that cannot match in the first place due to different interface id by placing them in different bins. Signed-off-by: Florian Westphal Acked-by: David S. Miller Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 25 +

[PATCH 04/17] xfrm: policy: return NULL when inexact search needed

2018-12-18 Thread Steffen Klassert
From: Florian Westphal currently policy_hash_bysel() returns the hash bucket list (for exact policies), or the inexact list (when policy uses a prefix). Searching this inexact list is slow, so it might be better to pre-sort inexact lists into a tree or another data structure for faster searching

[PATCH 02/17] xfrm: security: iterate all, not inexact lists

2018-12-18 Thread Steffen Klassert
From: Florian Westphal currently all non-socket policies are either hashed in the dst table, or placed on the 'inexact list'. When flushing, we first walk the table, then the (per-direction) inexact lists. When we try and get rid of the inexact lists to having "n" inexact lists (e.g. per-af ine

pull request (net-next): ipsec-next 2018-12-18

2018-12-18 Thread Steffen Klassert
1) Add xfrm policy selftest scripts. From Florian Westphal. 2) Split inexact policies into four different search list classes and use the rbtree infrastructure to store/lookup the policies. This is to improve the policy lookup performance after the flowcache removal. Patches from Fl

[PATCH 14/17] xfrm: policy: fix netlink/pf_key policy lookups

2018-12-18 Thread Steffen Klassert
From: Florian Westphal Colin Ian King says: Static analysis with CoverityScan found a potential issue [..] It seems that pointer pol is set to NULL and then a check to see if it is non-null is used to set pol to tmp; howeverm this check is always going to be false because pol is always NULL.

[PATCH 13/17] xfrm: policy: add missing indentation

2018-12-18 Thread Steffen Klassert
From: Colin Ian King There is a missing indentation before the goto statement. Add it. Signed-off-by: Colin Ian King Signed-off-by: Steffen Klassert --- net/xfrm/xfrm_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c i

[PATCH 09/17] xfrm: policy: check reinserted policies match their node

2018-12-18 Thread Steffen Klassert
From: Florian Westphal validate the re-inserted policies match the lookup node. Policies that fail this test won't be returned in the candidate set. This is enabled by default for now, it should not cause noticeable reinsert slow down. Such reinserts are needed when we have to merge an existing

[PATCH 05/17] xfrm: policy: store inexact policies in an rhashtable

2018-12-18 Thread Steffen Klassert
From: Florian Westphal Switch packet-path lookups for inexact policies to rhashtable. In this initial version, we now no longer need to search policies with non-matching address family and type. Next patch will add the if_id as well so lookups from the xfrm interface driver only need to search

[PATCH 11/17] xfrm: policy: add 2nd-level saddr trees for inexact policies

2018-12-18 Thread Steffen Klassert
From: Florian Westphal This adds the fourth and final search class, containing policies where both saddr and daddr have prefix lengths (i.e., not wildcards). Inexact policies now end up in one of the following four search classes: 1. "Any:Any" list, containing policies where both saddr and dadd

[PATCH 12/17] af_key: fix indentation on declaration statement

2018-12-18 Thread Steffen Klassert
From: Colin Ian King There is an indentation issue before the declaration of xfrm_ctx. Remove spaces and replace with a tab. Signed-off-by: Colin Ian King Signed-off-by: Steffen Klassert --- net/key/af_key.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/key/af_key.c

Re: [PATCH v1 net] lan743x: Expand phy search for LAN7431

2018-12-18 Thread Andrew Lunn
On Mon, Dec 17, 2018 at 04:44:50PM -0500, Bryan Whitehead wrote: > The LAN7431 uses an external phy, and it can be found anywhere in > the phy address space. This patch uses phy address 1 for LAN7430 > only. And searches all addresses otherwise. > > Signed-off-by: Bryan Whitehead > --- > drivers

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-18 Thread Chris Chiu
On Tue, Dec 18, 2018 at 5:45 AM Heiner Kallweit wrote: > > On 17.12.2018 14:25, Chris Chiu wrote: > > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit > > wrote: > >> > >> On 14.12.2018 04:33, Chris Chiu wrote: > >>> On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: > > Hi, >

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Stefano Brivio
On Tue, 18 Dec 2018 09:49:17 +0100 Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > > > On Mon, 17 Dec 2018 16:53:36 +0100 > > Dmitry Vyukov wrote: > > > > > On Mon, Dec 17, 2018 at 4:24 PM Stefano Brivio > > > wrote: > > > > > > > > On Mon, 17 Dec 2018 06

KMSAN: uninit-value in __tipc_nl_bearer_enable

2018-12-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:0a602458c72c kmsan: random: another take at unpoisoning CR.. git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=125b568b40 kernel config: https://syzkaller.appspot.com/x/.config?x=9b071100dcf8e641 dashb

KMSAN: uninit-value in tipc_nl_compat_link_set (2)

2018-12-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:cddc52641fd2 kmsan: use __memmove() in fixup_bad_iret() git tree: kmsan console output: https://syzkaller.appspot.com/x/log.txt?x=15d27ad540 kernel config: https://syzkaller.appspot.com/x/.config?x=e2808e34f8becb71 dashboard

[PATCH net v3 0/4] vxlan: Various fixes

2018-12-18 Thread Petr Machata
This patch set contains three fixes for the vxlan driver. Patch #1 fixes handling of offload mark on replaced VXLAN FDB entries. A way to trigger this is to replace the FDB entry with one that can not be offloaded. A future patch set should make it possible to veto such FDB changes. However the FD

[PATCH net v3 4/4] selftests: net: Add test_vxlan_fdb_changelink.sh

2018-12-18 Thread Petr Machata
Add a test to exercise the fix from the previous patch. Signed-off-by: Petr Machata --- tools/testing/selftests/net/Makefile | 1 + .../selftests/net/test_vxlan_fdb_changelink.sh | 29 ++ 2 files changed, 30 insertions(+) create mode 100755 tools/testing/s

[PATCH net v3 3/4] vxlan: changelink: Fix handling of default remotes

2018-12-18 Thread Petr Machata
Default remotes are stored as FDB entries with an Ethernet address of 00:00:00:00:00:00. When a request is made to change a remote address of a VXLAN device, vxlan_changelink() first deletes the existing default remote, and then creates a new FDB entry. This works well as long as the list of defau

[PATCH net v3 2/4] vxlan: Fix error path in __vxlan_dev_create()

2018-12-18 Thread Petr Machata
When a failure occurs in rtnl_configure_link(), the current code calls unregister_netdevice() to roll back the earlier call to register_netdevice(), and jumps to errout, which calls vxlan_fdb_destroy(). However unregister_netdevice() calls transitively ndo_uninit, which is vxlan_uninit(), and that

[PATCH net v3 1/4] vxlan: Unmark offloaded bit on replaced FDB entries

2018-12-18 Thread Petr Machata
When rdst of an offloaded FDB entry is replaced, it certainly isn't offloaded anymore. Drivers are notified about such replacements, and can re-mark the entry as offloaded again if they so wish. However until a driver does so explicitly, assume a replaced FDB entry is not offloaded. Note that repl

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-18 Thread Chris Chiu
On Tue, Dec 18, 2018 at 3:08 AM Heiner Kallweit wrote: > > On 17.12.2018 14:25, Chris Chiu wrote: > > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit > > wrote: > >> > >> On 14.12.2018 04:33, Chris Chiu wrote: > >>> On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: > > Hi, >

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Dmitry Vyukov
On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio wrote: > > On Tue, 18 Dec 2018 09:49:17 +0100 > Dmitry Vyukov wrote: > > > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio wrote: > > > > > > On Mon, 17 Dec 2018 16:53:36 +0100 > > > Dmitry Vyukov wrote: > > > > > > > On Mon, Dec 17, 2018 at 4:24 P

RE: [RFC PATCH] net/mlx4: Get rid of page operation after dma_alloc_coherent

2018-12-18 Thread Tariq Toukan
Hi Stephen, Thanks for your patch. > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Stephen Warren > Sent: Saturday, December 15, 2018 1:33 AM > To: Tariq Toukan ; w...@wwwdotorg.org; > h...@wwwdotorg.org; \ (Xavier\)

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-18 Thread Xue Liu
Hello Andreas, On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > > Hello Xue Liu, > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > I have a question about the architecture of your module. AFAIK LoRaWAN > > is already the MAC Layer above the LoRa technology. Why do you want to > > make a new laye

Re: [PATCH bpf-next 0/2] tools: bpftool: mount tracefs if needed and if desired

2018-12-18 Thread Daniel Borkmann
On 12/18/2018 11:13 AM, Quentin Monnet wrote: > Hi, > This series focus on mounting (or not mounting) tracefs with bpftool. > > First patch makes bpftool attempt to mount tracefs if tracefs is not found > when running "bpftool prog tracelog". > > Second patch adds an option to bpftool to prevent

Re: [PATCH bpf-next] tools/bpf: check precise {func,line,jited_line}_info_rec_size in test_btf

2018-12-18 Thread Daniel Borkmann
On 12/18/2018 02:31 AM, Yonghong Song wrote: > Current btf func_info, line_info and jited_line are designed to be > extensible. The record sizes for {func,line}_info are passed to kernel, > and the record sizes for {func,line,jited_line}_info are returned to > userspace during bpf_prog_info query.

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Paul E. McKenney
On Tue, Dec 18, 2018 at 02:26:00PM +0100, Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio wrote: > > > > On Tue, 18 Dec 2018 09:49:17 +0100 > > Dmitry Vyukov wrote: > > > > > On Tue, Dec 18, 2018 at 12:18 AM Stefano Brivio > > > wrote: > > > > > > > > On Mon, 17 Dec 2018 1

Re: Self-XORing BPF registers is undefined behavior

2018-12-18 Thread Alexander Potapenko
On Thu, Dec 13, 2018 at 2:18 PM Daniel Borkmann wrote: > > On 12/13/2018 01:24 PM, Alexander Potapenko wrote: > > On Thu, Dec 13, 2018 at 1:20 PM Michal Kubecek wrote: > >> On Thu, Dec 13, 2018 at 12:59:36PM +0100, Michal Kubecek wrote: > >>> On Thu, Dec 13, 2018 at 12:00:59PM +0100, Alexander Po

Re: WARNING in __rcu_read_unlock

2018-12-18 Thread Stefano Brivio
[Dropping syzbot from Cc:] On Tue, 18 Dec 2018 14:26:00 +0100 Dmitry Vyukov wrote: > On Tue, Dec 18, 2018 at 1:40 PM Stefano Brivio > wrote: > > > Maybe it would be nice to have a semi-automated way to isolate and > > describe/name specific conditions found by syzbot via fuzzing and > > turn th

Re: [bpf-next RFC 0/3] AF_XDP support for veth.

2018-12-18 Thread Björn Töpel
Den mån 17 dec. 2018 kl 20:40 skrev William Tu : > > The patch series adds AF_XDP async xmit support for veth device. > First patch add a new API for supporting non-physical NIC device to get > packet's virtual address. The second patch implements the async xmit, > and last patch adds example use

[PATCH net-next] MAINTAINERS: Add a maintainer for Microsemi switches

2018-12-18 Thread Alexandre Belloni
Microsemi has been bought by Microchip and Microchip is supporting those switches. Signed-off-by: Alexandre Belloni --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 50223cba6ddb..48abe982aed6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9823,6

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-18 Thread Jian-Hong Pan
> Sun, Dec 16, 2018 at 11:18:59AM CET, starni...@g.ncu.edu.tw wrote: > >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. > > > >This patch implements part of Class A end-devices SoftMAC defined in > >LoRaWAN(TM) Specification Ver. 1.0.2: > >1. End-device receive slot timing

Re: [PATCH net 0/2] SO_TIMESTAMPING fixes

2018-12-18 Thread Willem de Bruijn
On Tue, Dec 18, 2018 at 2:27 AM David Miller wrote: > > From: Willem de Bruijn > Date: Mon, 17 Dec 2018 12:23:58 -0500 > > > From: Willem de Bruijn > > > > Fix two omissions: > > > > - tx timestamping is missing for AF_INET6/SOCK_RAW/IPPROTO_RAW > > - SOF_TIMESTAMPING_OPT_ID is missing for IPPRO

Re: [bpf-next RFC 1/3] xsk: add xsk_umem_consume_tx_virtual.

2018-12-18 Thread Björn Töpel
Den mån 17 dec. 2018 kl 20:40 skrev William Tu : > > Currently the xsk_umem_consume_tx expects only the physical NICs so > the api returns a dma address. This patch introduce the new function > to return the virtual address, when XSK is used by a virtual device. > > Signed-off-by: William Tu > --

Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module

2018-12-18 Thread Jiri Pirko
Tue, Dec 18, 2018 at 03:27:09PM CET, starni...@g.ncu.edu.tw wrote: >> Sun, Dec 16, 2018 at 11:18:59AM CET, starni...@g.ncu.edu.tw wrote: >> >LoRaWAN defined by LoRa Alliance(TM) is the MAC layer over LoRa devices. >> > >> >This patch implements part of Class A end-devices SoftMAC defined in >> >LoR

Re: Self-XORing BPF registers is undefined behavior

2018-12-18 Thread Alexander Potapenko
On Thu, Dec 13, 2018 at 3:54 PM Daniel Borkmann wrote: > > On 12/13/2018 02:18 PM, Daniel Borkmann wrote: > > On 12/13/2018 01:24 PM, Alexander Potapenko wrote: > >> On Thu, Dec 13, 2018 at 1:20 PM Michal Kubecek wrote: > >>> On Thu, Dec 13, 2018 at 12:59:36PM +0100, Michal Kubecek wrote: >

Re: [bpf-next RFC 2/3] veth: support AF_XDP.

2018-12-18 Thread Björn Töpel
Den mån 17 dec. 2018 kl 20:40 skrev William Tu : > > The patch adds support for AF_XDP async xmit. Users can use > AF_XDP on both side of the veth and get better performance, with > the cost of ksoftirqd doing the xmit. The veth_xsk_async_xmit > simply kicks the napi function, veth_poll, to run,

Re: [Intel-wired-lan] [PATCH 1/2] xsk: export xdp_get_umem_from_qid

2018-12-18 Thread Björn Töpel
Den tis 18 dec. 2018 kl 14:48 skrev Jan Sokolowski : > > Export xdp_get_umem_from_qid for other modules to use. > > Signed-off-by: Jan Sokolowski Adding netdev. Acked-by: Björn Töpel > --- > net/xdp/xdp_umem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/xdp/xdp_umem.c b/net/x

Re: [PATCH RFC net-next] net: dsa: microchip: add KSZ9477 I2C driver

2018-12-18 Thread Marek Vasut
On 12/18/2018 11:01 AM, Andrew Lunn wrote: > On Tue, Dec 18, 2018 at 07:24:52AM +0100, Sergio Paracuellos wrote: >>> +static int ksz9477_i2c_read_reg(struct i2c_client *i2c, u32 reg, u8 *val, >>> + unsigned int len) >>> +{ >>> + struct i2c_msg msg[2]; >>> +

Re: [Intel-wired-lan] [PATCH 2/2] i40e: Remove umem from VSI

2018-12-18 Thread Björn Töpel
Den tis 18 dec. 2018 kl 14:48 skrev Jan Sokolowski : > > As current implementation of netdev already contains and provides > umems for us, we no longer have the need to contain these > structures in i40e_vsi. > > Refactor the code to operate on netdev-provided umems. > > Signed-off-by: Jan Sokolows

Re: selftests/net: udpgso: LTS kernels supportability ?

2018-12-18 Thread shuah
On 12/18/18 4:37 AM, Rafael David Tinoco wrote: On 12/17/18 4:42 PM, shuah wrote: Hi Rafael, On 12/17/18 10:53 AM, Rafael David Tinoco wrote: Shuah, I was recently investigating some errors coming out of our functional tests and we, Dan and I, came up with a discussion that might not be new f

[PATCH] xen/netfront: tolerate frags with no data

2018-12-18 Thread Juergen Gross
At least old Xen net backends seem to send frags with no real data sometimes. In case such a fragment happens to occur with the frag limit already reached the frontend will BUG currently even if this situation is easily recoverable. Modify the BUG_ON() condition accordingly. Cc: sta...@vger.kerne

Re: [PATCH v3 2/2] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode

2018-12-18 Thread Rob Herring
On Mon, Dec 17, 2018 at 09:44:23PM +0100, Sergio Paracuellos wrote: > Add device-tree binding example of the ksz9477 switch managed in i2c mode. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Sergio Paracuellos > --- > Changes v3: > - No changes. Just resent patches together. > > Change

[PATCH] vxge: ensure data0 is initialized in when fetching firmware version information

2018-12-18 Thread Colin King
From: Colin Ian King Currently variable data0 is not being initialized so a garbage value is being passed to vxge_hw_vpath_fw_api and this value is being written to the rts_access_steer_data0 register. There are other occurrances where data0 is being initialized to zero (e.g. in function vxge_hw

[PATCH 2/2] dpaa2-eth: Add QBMAN related stats

2018-12-18 Thread Ioana Ciornei
From: Ioana Radulescu Add statistics for pending frames in Rx/Tx conf FQs and number of buffers in pool. Available through ethtool -S. Signed-off-by: Ioana Radulescu Signed-off-by: Ioana ciornei --- .../net/ethernet/freescale/dpaa2/dpaa2-ethtool.c | 41 ++ 1 file changed

[PATCH 0/2] dpaa2-eth: add QBMAN statistics

2018-12-18 Thread Ioana Ciornei
This patch set adds ethtool statistics for pending frames/bytes in Rx/Tx conf FQs and number of buffers in pool. The first patch adds support for the query APIs in the DPIO driver while the latter actually exposes the statistics through ethtool. Ioana Radulescu (1): dpaa2-eth: Add QBMAN related

[PATCH 1/2] soc: fsl: dpio: Add BP and FQ query APIs

2018-12-18 Thread Ioana Ciornei
From: Roy Pledge Add FQ (Frame Queue) and BP (Buffer Pool) query APIs that users of QBMan can invoke to see the status of the queues and pools that they are using. Signed-off-by: Roy Pledge Signed-off-by: Ioana Radulescu Signed-off-by: Ioana Ciornei --- drivers/soc/fsl/dpio/dpio-service.c |

Re: [RESEND 1/4] mfd: altera-sysmgr: Add SOCFPGA System Manager abstraction

2018-12-18 Thread Arnd Bergmann
On Tue, Dec 18, 2018 at 12:21 AM Thor Thayer wrote: > > Hi Arnd, > > On 12/14/18 6:36 AM, Arnd Bergmann wrote: > > On Tue, Nov 13, 2018 at 5:03 PM wrote: > >> > >> From: Thor Thayer > >> +static int socfpga_is_s10(void) > >> +{ > >> + return of_machine_is_compatible("altr,socfpga-stratix1

Re: [PATCH v2 net-next 01/10] net: eth: altera: tse_start_xmit ignores tx_buffer call response

2018-12-18 Thread Thor Thayer
Hi Dalon, On 12/13/18 11:52 AM, dwest...@gmail.com wrote: From: Dalon Westergreen The return from tx_buffer call in tse_start_xmit is inapropriately ignored. tse_buffer calls should return 0 for success or NETDEV_TX_BUSY. tse_start_xmit should return not report a successful transmit when the

Re: [PATCH v2 net-next 02/10] net: eth: altera: set rx and tx ring size before init_dma call

2018-12-18 Thread Thor Thayer
On 12/13/18 11:52 AM, dwest...@gmail.com wrote: From: Dalon Westergreen It is more appropriate to set the rx and tx ring size before calling the init function for the dma. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse_main.c | 6 -- 1 file changed, 4 inser

Re: [PATCH v2 net-next 03/10] net: eth: altera: fix altera_dmaops declaration

2018-12-18 Thread Thor Thayer
On 12/13/18 11:52 AM, dwest...@gmail.com wrote: From: Dalon Westergreen The declaration of struct altera_dmaops does not have identifier names. Add identifier names to confrom with required coding styles. Signed-off-by: Dalon Westergreen --- drivers/net/ethernet/altera/altera_tse.h | 30 ++

  1   2   3   4   >