Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread Davide Caratti
On Mon, 2019-06-24 at 21:00 -0400, Lucas Bates wrote: > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcases,

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-25 Thread Jakub Sitnicki
[Reposting with correct format this time. Sorry.] On Fri, Jun 21, 2019 at 12:20 AM CEST, Joe Stringer wrote: > On Wed, Jun 19, 2019 at 2:14 AM Jakub Sitnicki wrote: >> >> Hey Florian, >> >> Thanks for taking a look at it. >> >> On Tue, Jun 18, 2019 at 03:52 PM CEST, Florian Westphal wrote: >> > J

Re: [PATCH bpf-next] libbpf: add xsk_ring_prod__free() function

2019-06-25 Thread Eelco Chaudron
On 24 Jun 2019, at 18:42, Andrii Nakryiko wrote: On Mon, Jun 24, 2019 at 2:37 AM Eelco Chaudron wrote: On 21 Jun 2019, at 21:13, Andrii Nakryiko wrote: On Fri, Jun 21, 2019 at 8:26 AM Eelco Chaudron wrote: When an AF_XDP application received X packets, it does not mean X frames can

Re: [RFC bpf-next 0/7] Programming socket lookup with BPF

2019-06-25 Thread Jakub Sitnicki
On Fri, Jun 21, 2019 at 06:50 PM CEST, Joe Stringer wrote: > On Fri, Jun 21, 2019 at 1:44 AM Jakub Sitnicki wrote: >> >> On Fri, Jun 21, 2019, 00:20 Joe Stringer wrote: >>> >>> On Wed, Jun 19, 2019 at 2:14 AM Jakub Sitnicki wrote: >>> > >>> > Hey Florian, >>> > >>> > Thanks for taking a look at

Re: [PATCH net-next 11/12] net: flow_offload: don't allow block sharing until drivers support this

2019-06-25 Thread Jiri Pirko
I don't understand the purpose of this patch. Could you please provide some description about what this is about. mlxsw supports block sharing between ports. Or what kind of "sharing" do you have in mind?

Re: [PATCH net-next 11/12] net: flow_offload: don't allow block sharing until drivers support this

2019-06-25 Thread Pablo Neira Ayuso
On Tue, Jun 25, 2019 at 10:16:27AM +0200, Jiri Pirko wrote: > I don't understand the purpose of this patch. Could you please provide > some description about what this is about. mlxsw supports block sharing > between ports. Or what kind of "sharing" do you have in mind? I'm refering to ethtool, tc

Re: [PATCH RFC net-next 5/5] net: dsa: mt7530: Add mediatek,ephy-handle to isolate external phy

2019-06-25 Thread René van Dorst
Quoting Andrew Lunn : Hi Andrew, +static int mt7530_isolate_ephy(struct dsa_switch *ds, + struct device_node *ephy_node) +{ + struct phy_device *phydev = of_phy_find_device(ephy_node); + int ret; + + if (!phydev) + return 0; + +

Re: [PATCH net-next 2/2] net: sched: protect against stack overflow in TC act_mirred

2019-06-25 Thread Eyal Birger
Hi John, On Mon, 24 Jun 2019 23:13:36 +0100 John Hurley wrote: > TC hooks allow the application of filters and actions to packets at > both ingress and egress of the network stack. It is possible, with > poor configuration, that this can produce loops whereby an ingress > hook calls a mirred egr

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-25 Thread Pablo Neira Ayuso
On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: > Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: > > [...] > > > > >+static LIST_HEAD(tcf_block_cb_list); > > I still don't like the global list. Have to go throught the code more > carefully, but why you can't pass t

[PATCH v1 1/2] dt-bindings: net: dsa: qca8k: document reset-gpios property

2019-06-25 Thread Christian Lamparter
This patch documents the qca8k's reset-gpios property that can be used if the QCA8337N ends up in a bad state during reset. Signed-off-by: Christian Lamparter --- Documentation/devicetree/bindings/net/dsa/qca8k.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetre

[PATCH v1 2/2] net: dsa: qca8k: introduce reset via gpio feature

2019-06-25 Thread Christian Lamparter
The QCA8337(N) has a RESETn signal on Pin B42 that triggers a chip reset if the line is pulled low. The datasheet says that: "The active low duration must be greater than 10 ms". This can hopefully fix some of the issues related to pin strapping in OpenWrt for the EA8500 which suffers from detecti

Re: [PATCH net-next 1/1] tc-testing: Restore original behaviour for namespaces in tdc

2019-06-25 Thread Nicolas Dichtel
Le 25/06/2019 à 03:00, Lucas Bates a écrit : > This patch restores the original behaviour for tdc prior to the > introduction of the plugin system, where the network namespace > functionality was split from the main script. > > It introduces the concept of required plugins for testcases, > and wil

RE: [PATCH v5 4/5] net: macb: add support for high speed interface

2019-06-25 Thread Parshuram Raju Thombare
>> switch (state->interface) { >> case PHY_INTERFACE_MODE_NA: >> +case PHY_INTERFACE_MODE_USXGMII: >> +case PHY_INTERFACE_MODE_10GKR: >> +if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) { >> +phylink_set(mask, 1baseCR_Full); >> +

RE: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-25 Thread Ran Rozenstein
> -Original Message- > From: Tariq Toukan > Sent: Monday, June 17, 2019 19:16 > To: Florian Westphal ; netdev@vger.kernel.org > Cc: Ran Rozenstein ; Maor Gottlieb > ; eduma...@google.com > Subject: Re: [PATCH net-next 0/2] net: ipv4: remove erroneous > advancement of list pointer > > >

Re: [PATCH net-next 2/2] net: sched: protect against stack overflow in TC act_mirred

2019-06-25 Thread John Hurley
On Tue, Jun 25, 2019 at 9:30 AM Eyal Birger wrote: > > Hi John, > > On Mon, 24 Jun 2019 23:13:36 +0100 > John Hurley wrote: > > > TC hooks allow the application of filters and actions to packets at > > both ingress and egress of the network stack. It is possible, with > > poor configuration, that

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Toke Høiland-Jørgensen
"Daniel T. Lee" writes: > Currently, each xdp samples are inconsistent in the use. > Most of the samples fetch the interface with it's name. > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > But some of the xdp samples are fetching the interface with > ifindex by command argument

Re: [PATCH net-next 2/2] net: sched: protect against stack overflow in TC act_mirred

2019-06-25 Thread Florian Westphal
John Hurley wrote: > Hi Eyal, > The value of 4 is basically a revert to what it was on older kernels > when TC had a TTL value in the skb: > https://elixir.bootlin.com/linux/v3.19.8/source/include/uapi/linux/pkt_cls.h#L97 IIRC this TTL value was not used ever. > I also found with my testing that

Re: [PATCH net-next 0/2] net: ipv4: remove erroneous advancement of list pointer

2019-06-25 Thread Florian Westphal
Ran Rozenstein wrote: > > On 6/17/2019 5:02 PM, Florian Westphal wrote: > > > Tariq reported a soft lockup on net-next that Mellanox was able to > > > bisect to 2638eb8b50cf ("net: ipv4: provide __rcu annotation for > > > ifa_list"). > > > > > > While reviewing above patch I found a regression wh

Re: [PATCH nf-next v2 1/2] netfilter: nft_meta: add NFT_META_BRI_PVID support

2019-06-25 Thread wenxu
Hi pablo, Any idea about these two patches? BR wenxu On 6/20/2019 9:17 AM, we...@ucloud.cn wrote: > From: wenxu > > nft add table bridge firewall > nft add chain bridge firewall zones { type filter hook prerouting priority - > 300 \; } > nft add rule bridge firewall zones counter ct zone se

Re: [PATCH v12 1/5] can: m_can: Create a m_can platform framework

2019-06-25 Thread Faiz Abbas
Hi, On 09/05/19 9:41 PM, Dan Murphy wrote: > Create a m_can platform framework that peripheral > devices can register to and use common code and register sets. > The peripheral devices may provide read/write and configuration > support of the IP. > > Acked-by: Wolfgang Grandegger > Signed-off-by

Re: [PATCH RFC net-next 4/5] dt-bindings: net: dsa: mt7530: Add mediatek,ephy-handle to isolate ext. phy

2019-06-25 Thread René van Dorst
Quoting Florian Fainelli : Hi Florian On 6/24/19 7:52 AM, René van Dorst wrote: On some platforum the external phy can only interface to the port 5 of the switch because the RGMII TX and RX lines are swapped. But it still can be useful to use the internal phy of the switch to act as a WAN port

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Daniel Borkmann
On 06/25/2019 08:37 AM, Eric Dumazet wrote: > On 6/24/19 8:17 PM, Joe Stringer wrote: >> On Fri, Jun 21, 2019 at 1:59 PM Florian Westphal wrote: >>> >>> Joe Stringer wrote: As discussed during LSFMM, I've been looking at adding something like an `skb_sk_assign()` helper to BPF so that l

[PATCH iproute2] ip/iptoken: fix dump error when ipv6 disabled

2019-06-25 Thread Hangbin Liu
When we disable IPv6 from the start up (ipv6.disable=1), there will be no IPv6 route info in the dump message. If we return -1 when ifi->ifi_family != AF_INET6, we will get error like $ ip token list Dump terminated which will make user feel confused. There is no need to return -1 if the dump mes

Re: [PATCH net-next 2/2] net: sched: protect against stack overflow in TC act_mirred

2019-06-25 Thread John Hurley
On Tue, Jun 25, 2019 at 10:15 AM Florian Westphal wrote: > > John Hurley wrote: > > Hi Eyal, > > The value of 4 is basically a revert to what it was on older kernels > > when TC had a TTL value in the skb: > > https://elixir.bootlin.com/linux/v3.19.8/source/include/uapi/linux/pkt_cls.h#L97 > > II

[PATCH] net: phylink: further documentation clarifications

2019-06-25 Thread Russell King
Clarify the validate() behaviour in a few cases which weren't mentioned in the documentation, but which are necessary for users to get the correct behaviour. Signed-off-by: Russell King --- include/linux/phylink.h | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/in

Re: [PATCH nf-next v2 1/2] netfilter: nft_meta: add NFT_META_BRI_PVID support

2019-06-25 Thread Pablo Neira Ayuso
On Tue, Jun 25, 2019 at 05:23:02PM +0800, wenxu wrote: > Hi pablo, > > Any idea about these two patches? Plan is to include them in the next batch. > On 6/20/2019 9:17 AM, we...@ucloud.cn wrote: > > From: wenxu > > > > nft add table bridge firewall > > nft add chain bridge firewall zones { type

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread kbuild test robot
/Marek-Vasut/net-dsa-microchip-Convert-to-regmap/20190625-021215 config: x86_64-randconfig-ne0-06250702 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 If you fix the issue, kindly add following

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Jesper Dangaard Brouer
On Tue, 25 Jun 2019 11:08:22 +0200 Toke Høiland-Jørgensen wrote: > "Daniel T. Lee" writes: > > > Currently, each xdp samples are inconsistent in the use. > > Most of the samples fetch the interface with it's name. > > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > > > But some

[PATCH RFC ipsec-next 4/7] xfrm: add route lookup to xfrm4_rcv_encap

2019-06-25 Thread Sabrina Dubroca
At this point, with TCP encapsulation, the dst may be gone, but xfrm_input needs one. Signed-off-by: Sabrina Dubroca --- net/ipv4/xfrm4_protocol.c | 9 + 1 file changed, 9 insertions(+) diff --git a/net/ipv4/xfrm4_protocol.c b/net/ipv4/xfrm4_protocol.c index bcab48944c15..1665e1a05ec5 1

[PATCH RFC ipsec-next 3/7] xfrm: introduce xfrm_trans_queue_net

2019-06-25 Thread Sabrina Dubroca
This will be used by TCP encapsulation to write packets to the encap socket without holding the user socket's lock. Without this reinjection, we're already holding the lock of the user socket, and then try to lock the encap socket as well when we enqueue the encrypted packet. While at it, add a BU

[PATCH RFC ipsec-next 0/7] ipsec: add TCP encapsulation support (RFC 8229)

2019-06-25 Thread Sabrina Dubroca
This patchset introduces support for TCP encapsulation of IKE and ESP messages, as defined by RFC 8229 [0]. It is an evolution of what Herbert Xu proposed in January 2018 [1] that addresses the main criticism against it, by not interfering with the TCP implementation at all. The networking stack no

[PATCH RFC ipsec-next 1/7] net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram

2019-06-25 Thread Sabrina Dubroca
This will be used by ESP over TCP to handle the queue of IKE messages. Signed-off-by: Sabrina Dubroca --- include/linux/skbuff.h | 11 --- net/core/datagram.c| 26 -- net/ipv4/udp.c | 3 ++- net/unix/af_unix.c | 7 --- 4 files changed, 30 ins

[PATCH RFC ipsec-next 7/7] xfrm: add espintcp (RFC 8229)

2019-06-25 Thread Sabrina Dubroca
TCP encapsulation of IKE and IPsec messages (RFC 8229) is implemented as a TCP ULP, overriding in particular the sendmsg and recvmsg operations. A Stream Parser is used to extract messages out of the TCP stream using the first 2 bytes as length marker. Received IKE messages are put on "ike_queue",

[PATCH RFC ipsec-next 2/7] skbuff: Avoid sleeping in skb_send_sock_locked

2019-06-25 Thread Sabrina Dubroca
From: Herbert Xu For a function that needs to be called with the socket spinlock held, sleeping would seem to be a bad idea. This function does in fact avoid sleeping when calling kernel_sendpage_locked on the page part of the skb. However, it doesn't do that when sending the linear part. Resu

[PATCH RFC ipsec-next 5/7] esp4: prepare esp_input_done2 for non-UDP encapsulation

2019-06-25 Thread Sabrina Dubroca
For espintcp encapsulation, we will need to get the source port from the TCP header instead of UDP. Introduce a variable to hold the port. Co-developed-by: Herbert Xu Signed-off-by: Herbert Xu Signed-off-by: Sabrina Dubroca --- net/ipv4/esp4.c | 16 ++-- 1 file changed, 14 insertio

[PATCH RFC ipsec-next 6/7] esp4: split esp_output_udp_encap and introduce esp_output_encap

2019-06-25 Thread Sabrina Dubroca
Co-developed-by: Herbert Xu Signed-off-by: Herbert Xu Signed-off-by: Sabrina Dubroca --- net/ipv4/esp4.c | 57 - 1 file changed, 37 insertions(+), 20 deletions(-) diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c index 5608dd47ee97..344660e2a17b 100

[PATCH iproute2 v2 3/3] ip address: do not set mngtmpaddr option for IPv4 addresses

2019-06-25 Thread Andrea Claudi
'mngtmpaddr' option make the kernel manage temporary addresses created from the specified one as template on behalf of Privacy Extensions (RFC3041). This option should be available only for IPv6 addresses, as correctly stated in the manpage. However it is possible to set mngtmpaddr on IPv4 address

[PATCH iproute2 v2 2/3] ip address: do not set home option for IPv4 addresses

2019-06-25 Thread Andrea Claudi
'home' option designates a IPv6 address as "home address" as defined in RFC 6275. This option should be available only for IPv6 addresses, as correctly stated in the manpage. However it is possible to set home on IPv4 addresses, too: $ ip link add dummy0 type dummy $ ip -4 addr add 192.168.1.1 de

Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present

2019-06-25 Thread Sergei Shtylyov
Hello! On 25.06.2019 11:19, Jose Abreu wrote: Some DT bindings do not have the PHY handle. Let's fallback to manually discovery in case phylink_of_phy_connect() fails. Reported-by: Katsuhiro Suzuki Fixes: 74371272f97f ("net: stmmac: Convert to phylink and remove phylib logic") Signed-off-by:

[PATCH 1/4] b43legacy: remove b43legacy_dma_set_mask

2019-06-25 Thread Christoph Hellwig
These days drivers are not required to fallback to smaller DMA masks, but can just set the largest mask they support, removing the need for this trial and error logic. Signed-off-by: Christoph Hellwig --- drivers/net/wireless/broadcom/b43legacy/dma.c | 39 +-- 1 file changed, 1 i

[PATCH iproute2 v2 1/3] ip address: do not set nodad option for IPv4 addresses

2019-06-25 Thread Andrea Claudi
Duplicate Address Detection (RFC 4862) is available only for IPv6 addresses. As a consequence, 'nodad' option, turning it off, should be available only for IPv6, and is defined like that in the man page. However it is possible to set nodad on IPv4 addresses, too: $ ip link add dummy0 type dummy $

[PATCH iproute2 v2 0/3] do not set IPv6-only options on IPv4 addresses

2019-06-25 Thread Andrea Claudi
'home', 'nodad' and 'mngtmpaddr' options are IPv6-only, but it is possible to set them on IPv4 addresses, too. This should not be possible. Fix this adding a check on the protocol family before setting the flags, and print warning messages on error to not break existing scripted setups. Andrea Cl

Re: [PATCH net-next v2 08/12] xdp: tracking page_pool resources and safe removal

2019-06-25 Thread Ivan Khoronzhuk
Hi Jesper, Could you please clarify one question. On Tue, Jun 18, 2019 at 03:05:47PM +0200, Jesper Dangaard Brouer wrote: This patch is needed before we can allow drivers to use page_pool for DMA-mappings. Today with page_pool and XDP return API, it is possible to remove the page_pool object (f

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Jamal Hadi Salim
On 2019-06-24 12:49 p.m., Eric Dumazet wrote: Well, I would simply remove the skb_orphan() call completely. My experience: You still need to call skb_orphan() from the lower level (and set the skb destructor etc). cheers, jamal

Re: [PATCH v3 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-25 Thread Neil Horman
On Mon, Jun 24, 2019 at 06:15:29PM -0400, Willem de Bruijn wrote: > > > > + if (need_wait && !packet_next_frame(po, &po->tx_ring, > > > > TP_STATUS_SEND_REQUEST)) { > > > > + po->wait_on_complete = 1; > > > > + timeo = sock_sndtimeo(&po->sk

[PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Baruch Siach
Merge commit 1c8c5a9d38f60 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat applications") by taking the gpl_compatible 1-bit field definition from commit b85fab0e67b162 ("bpf: Add gpl_compatible flag

Re: Removing skb_orphan() from ip_rcv_core()

2019-06-25 Thread Jamal Hadi Salim
On 2019-06-24 11:26 p.m., Joe Stringer wrote: [..] I haven't got as far as UDP yet, but I didn't see any need for a dependency on netfilter. I'd be curious to see what you did. My experience, even for TCP is the socket(transparent/tproxy) lookup code (to set skb->sk either listening or establi

Re: [PATCH net] sctp: change to hold sk after auth shkey is created successfully

2019-06-25 Thread Neil Horman
On Tue, Jun 25, 2019 at 12:21:45AM +0800, Xin Long wrote: > Now in sctp_endpoint_init(), it holds the sk then creates auth > shkey. But when the creation fails, it doesn't release the sk, > which causes a sk defcnf leak, > > Here to fix it by only holding the sk when auth shkey is created > succes

Re: [PATCH net-next 0/2] Track recursive calls in TC act_mirred

2019-06-25 Thread Jamal Hadi Salim
On 2019-06-24 6:13 p.m., John Hurley wrote: These patches aim to prevent act_mirred causing stack overflow events from recursively calling packet xmit or receive functions. Such events can occur with poor TC configuration that causes packets to travel in loops within the system. Florian Westphal

Re: [PATCH net-next 2/2] net: sched: protect against stack overflow in TC act_mirred

2019-06-25 Thread Jamal Hadi Salim
On 2019-06-25 5:06 a.m., John Hurley wrote: On Tue, Jun 25, 2019 at 9:30 AM Eyal Birger wrote: I'm not sure on the history of why a value of 4 was selected here but it seems to fall into line with my findings. Back then we could only loop in one direction (as opposed to two right now) - so

Re: [PATCH net-next v2 08/12] xdp: tracking page_pool resources and safe removal

2019-06-25 Thread Jesper Dangaard Brouer
On Tue, 25 Jun 2019 13:50:14 +0300 Ivan Khoronzhuk wrote: > Hi Jesper, > > Could you please clarify one question. > > On Tue, Jun 18, 2019 at 03:05:47PM +0200, Jesper Dangaard Brouer wrote: > >This patch is needed before we can allow drivers to use page_pool for > >DMA-mappings. Today with page

Re: [RFC PATCH 0/2] enable broadcom tagging for bcm531x5 switches

2019-06-25 Thread Benedikt Spranger
On Sat, 22 Jun 2019 19:24:10 -0700 Florian Fainelli wrote: > Something like this should take care of that (untested). You might > have to explicitly set the IMP port (port 8) in B53_UC_FWD_EN and > B53_MC_FWD_EN, though since you turn on management mode, this may not > be required. I might have s

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Russell King - ARM Linux admin : Hi Russel, Thanks for your review, see also my comments and questions below. Hi, On Mon, Jun 24, 2019 at 04:52:47PM +0200, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237

Re: [PATCH iproute2] iproute: Pass RTM_F_CLONED on dump to fetch cached routes to be flushed

2019-06-25 Thread Stefano Brivio
On Mon, 24 Jun 2019 15:55:49 -0600 David Ahern wrote: > On 6/14/19 7:33 PM, Stefano Brivio wrote: > > diff --git a/ip/iproute.c b/ip/iproute.c > > index 2b3dcc5dbd53..192442b42062 100644 > > --- a/ip/iproute.c > > +++ b/ip/iproute.c > > @@ -1602,6 +1602,16 @@ static int save_route_prep(void) > >

[PATCH iproute2 v2] iproute: Set flags and attributes on dump to get IPv6 cached routes to be flushed

2019-06-25 Thread Stefano Brivio
With a current (5.1) kernel version, IPv6 exception routes can't be listed (ip -6 route list cache) or flushed (ip -6 route flush cache). Kernel support for this is being added back. Relevant net-next commits: 564c91f7e563 fib_frontend, ip6_fib: Select routes or exceptions dump from RTM_F_CLONE

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread René van Dorst
Quoting Daniel Santos : Hi Daniel, On 6/24/19 9:52 AM, René van Dorst wrote: Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst --- drivers/net/dsa/mt7530.c | 237 +-- drivers/net/dsa/mt7530.h | 9 ++ 2 files changed, 187 insertions(+), 59 dele

[PATCH iproute2 2/2] devlink: fix libc and kernel headers collision

2019-06-25 Thread Baruch Siach
Since commit 2f1242efe9d ("devlink: Add devlink health show command") we use the sys/sysinfo.h header for the sysinfo(2) system call. But since iproute2 carries a local version of the kernel struct sysinfo, this causes a collision with libc that do not rely on kernel defined sysinfo like musl libc:

[PATCH iproute2 1/2] devlink: fix format string warning for 32bit targets

2019-06-25 Thread Baruch Siach
32bit targets define uint64_t as long long unsigned. This leads to the following build warning: devlink.c: In function ‘pr_out_u64’: devlink.c:1729:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Wformat=]

Re: [PATCH net-next v2 08/12] xdp: tracking page_pool resources and safe removal

2019-06-25 Thread Ivan Khoronzhuk
On Tue, Jun 25, 2019 at 01:27:50PM +0200, Jesper Dangaard Brouer wrote: On Tue, 25 Jun 2019 13:50:14 +0300 Ivan Khoronzhuk wrote: Hi Jesper, Could you please clarify one question. On Tue, Jun 18, 2019 at 03:05:47PM +0200, Jesper Dangaard Brouer wrote: >This patch is needed before we can allo

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Marek Vasut
On 6/25/19 1:59 AM, Vladimir Oltean wrote: > On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: >> >> On 6/24/19 12:35 AM, Marek Vasut wrote: >>> Add basic SPI regmap support into the driver. >>> >>> Previous patches unconver that ksz_spi_write() is always ever called >>> with len = 1, 2 or 4. We ca

Re: [PATCH RFC net-next 1/5] net: dsa: mt7530: Convert to PHYLINK API

2019-06-25 Thread Russell King - ARM Linux admin
On Tue, Jun 25, 2019 at 11:31:58AM +, René van Dorst wrote: > > > +if (state->link || mode == MLO_AN_FIXED) > > > +mcr |= PMCR_FORCE_LNK; > > > > This should be removed - state->link is not for use in mac_config. > > Even in fixed mode, the link can be brought u

[PATCH net] vrf: reset rt_iif for recirculated mcast out pkts

2019-06-25 Thread Stephen Suryaputra
Multicast egress packets has skb_rtable(skb)->rt_iif set to the oif. Depending on the socket, these packets might be recirculated back as input and raw sockets that are opened for them are bound to the VRF. But since skb_rtable(skb) is set and its rt_iif is non-zero, inet_iif() function returns rt_

Re: [PATCH net-next v2 08/12] xdp: tracking page_pool resources and safe removal

2019-06-25 Thread Ivan Khoronzhuk
On Tue, Jun 25, 2019 at 02:51:08PM +0300, Ivan Khoronzhuk wrote: On Tue, Jun 25, 2019 at 01:27:50PM +0200, Jesper Dangaard Brouer wrote: On Tue, 25 Jun 2019 13:50:14 +0300 Ivan Khoronzhuk wrote: Hi Jesper, Could you please clarify one question. On Tue, Jun 18, 2019 at 03:05:47PM +0200, Jesp

Re: [PATCH v3 bpf-next 0/2] veth: Bulk XDP_TX

2019-06-25 Thread Daniel Borkmann
On 06/13/2019 11:39 AM, Toshiaki Makita wrote: > This introduces bulk XDP_TX in veth. > Improves XDP_TX performance by approximately 9%. The detailed > explanation and performance numbers are shown in patch 2. > > v2: > - Use stack for bulk queue instead of a global variable. > > v3: > - Add act

Re: [PATCH] net: phylink: further documentation clarifications

2019-06-25 Thread Andrew Lunn
On Tue, Jun 25, 2019 at 10:44:33AM +0100, Russell King wrote: > Clarify the validate() behaviour in a few cases which weren't mentioned > in the documentation, but which are necessary for users to get the > correct behaviour. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Vladimir Oltean
On Tue, 25 Jun 2019 at 15:06, Marek Vasut wrote: > > On 6/25/19 1:59 AM, Vladimir Oltean wrote: > > On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: > >> > >> On 6/24/19 12:35 AM, Marek Vasut wrote: > >>> Add basic SPI regmap support into the driver. > >>> > >>> Previous patches unconver that ksz

Re: [EXT] [PATCH V2] bnx2x: Prevent ptp_task to be rescheduled indefinitely

2019-06-25 Thread Guilherme Piccoli
On Tue, Jun 25, 2019 at 1:02 AM Sudarsana Reddy Kalluru wrote: > > Thanks for your changes and time on this. In general time-latching happens in > couple or more milliseconds (even in some 100s of usec) under the normal > traffic conditions. With this approach, there's a possibility that every

Warnings generated from tcp_sacktag_write_queue.

2019-06-25 Thread Chinmay Agarwal
Dear All, We are hitting the following WARN_ON condition: WARN_ON((int)tcp_packets_in_flight(tp) < 0); tcp_packets_in_flight = packets_out –( lost_out + sacked_out ) + retrans_out (This value is coming -ve) The tcp socket being used is in fin_wait_1 state. The values f

Re: [PATCH 00/11] XDP unaligned chunk placement support

2019-06-25 Thread Laatz, Kevin
On 24/06/2019 16:38, Björn Töpel wrote: On Thu, 20 Jun 2019 at 18:55, Kevin Laatz wrote: This patchset adds the ability to use unaligned chunks in the XDP umem. Currently, all chunk addresses passed to the umem are masked to be chunk size aligned (default is 2k, max is PAGE_SIZE). This limi

Re: [PATCH 03/11] xdp: add offset param to zero_copy_allocator

2019-06-25 Thread Laatz, Kevin
On 24/06/2019 20:23, Jakub Kicinski wrote: On Thu, 20 Jun 2019 09:09:50 +, Kevin Laatz wrote: diff --git a/include/net/xdp.h b/include/net/xdp.h index 0f25b3675c5c..ea801fd2bf98 100644 --- a/include/net/xdp.h +++ b/include/net/xdp.h @@ -53,7 +53,8 @@ struct xdp_mem_info {  struct page_pool

Re: [PATCH net-next 0/2] Track recursive calls in TC act_mirred

2019-06-25 Thread John Hurley
On Tue, Jun 25, 2019 at 12:18 PM Jamal Hadi Salim wrote: > > On 2019-06-24 6:13 p.m., John Hurley wrote: > > These patches aim to prevent act_mirred causing stack overflow events from > > recursively calling packet xmit or receive functions. Such events can > > occur with poor TC configuration tha

Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent

2019-06-25 Thread Song Liu
On Tue, Jun 25, 2019 at 5:09 AM Jesper Dangaard Brouer wrote: > > On Tue, 25 Jun 2019 11:08:22 +0200 > Toke Høiland-Jørgensen wrote: > > > "Daniel T. Lee" writes: > > > > > Currently, each xdp samples are inconsistent in the use. > > > Most of the samples fetch the interface with it's name. > >

Re: [PATCH v3 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-25 Thread Willem de Bruijn
On Tue, Jun 25, 2019 at 7:03 AM Neil Horman wrote: > > On Mon, Jun 24, 2019 at 06:15:29PM -0400, Willem de Bruijn wrote: > > > > > + if (need_wait && !packet_next_frame(po, &po->tx_ring, > > > > > TP_STATUS_SEND_REQUEST)) { > > > > > + po->wait_on_complete = 1;

Клиентские базы! Email: proda...@armyspy.com Узнайте подробнее!

2019-06-25 Thread netdev
Клиентские базы! Email: proda...@armyspy.com Узнайте подробнее!

Re: [PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Alexei Starovoitov
On Tue, Jun 25, 2019 at 4:07 AM Baruch Siach wrote: > > Merge commit 1c8c5a9d38f60 ("Merge > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the > fix from commit 36f9814a494 ("bpf: fix uapi hole for 32 bit compat > applications") by taking the gpl_compatible 1-bit field defin

Re: Warnings generated from tcp_sacktag_write_queue.

2019-06-25 Thread Eric Dumazet
On 6/25/19 6:07 AM, Chinmay Agarwal wrote: > Dear All, > > We are hitting the following WARN_ON condition: > > WARN_ON((int)tcp_packets_in_flight(tp) < 0); > > tcp_packets_in_flight = packets_out –( lost_out + > sacked_out ) + retrans_out (This value is coming -ve) > > Th

Re: [PATCH iproute2] testsuite: don't clobber /tmp

2019-06-25 Thread Matteo Croce
On Thu, Jun 13, 2019 at 7:15 PM Matteo Croce wrote: > > On Wed, Jun 12, 2019 at 8:20 PM Stephen Hemminger > wrote: > > > > On Wed, 12 Jun 2019 19:32:29 +0200 > > Matteo Croce wrote: > > > > > On Wed, Jun 12, 2019 at 6:04 PM Matteo Croce wrote: > > > > > > > > On Wed, Jun 12, 2019 at 5:55 PM Ste

Re: [PATCH rdma-next v1 11/12] IB/mlx5: Implement DEVX dispatching event

2019-06-25 Thread Yishai Hadas
On 6/24/2019 9:06 PM, Jason Gunthorpe wrote: On Mon, Jun 24, 2019 at 07:55:32PM +0300, Yishai Hadas wrote: + /* Explicit filtering to kernel events which may occur frequently */ + if (event_type == MLX5_EVENT_TYPE_CMD || + event_type == MLX5_EVENT_TYPE_PAGE_REQUEST) +

[RFC, PATCH 0/2, net-next] net: netsec: Add XDP Support

2019-06-25 Thread Ilias Apalodimas
This is a respin of https://www.spinics.net/lists/netdev/msg526066.html Since page_pool API fixes are merged into net-next we can now safely use it's DMA mapping capabilities. The first patch changes the buffer allocation from netdev_alloc_frag() to page_pool API. Although this will lead to sli

[RFC, PATCH 1/2, net-next] net: netsec: Use page_pool API

2019-06-25 Thread Ilias Apalodimas
Use page_pool and it's DMA mapping capabilities for Rx buffers instead of netdev/napi_alloc_frag() Although this will result in a slight performance penalty on small sized packets (~10%) the use of the API will allow to easily add XDP support. The penalty won't be visible in network testing i.e ip

[RFC, PATCH 2/2, net-next] net: netsec: add XDP support

2019-06-25 Thread Ilias Apalodimas
The interface only supports 1 Tx queue so locking is introduced on the Tx queue if XDP is enabled to make sure .ndo_start_xmit and .ndo_xdp_xmit won't corrupt Tx ring - Performance (SMMU off) Benchmark XDP_SKB XDP_DRV xdp1291kpps 344kpps rxdrop 282kpps 342kpps - Perfor

Re: [PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Dmitry V. Levin
On Tue, Jun 25, 2019 at 07:16:55AM -0700, Alexei Starovoitov wrote: > On Tue, Jun 25, 2019 at 4:07 AM Baruch Siach wrote: > > > > Merge commit 1c8c5a9d38f60 ("Merge > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next") undid the > > fix from commit 36f9814a494 ("bpf: fix uapi hole for

Re: [PATCH V3 07/10] net: dsa: microchip: Initial SPI regmap support

2019-06-25 Thread Marek Vasut
On 6/25/19 2:40 PM, Vladimir Oltean wrote: > On Tue, 25 Jun 2019 at 15:06, Marek Vasut wrote: >> >> On 6/25/19 1:59 AM, Vladimir Oltean wrote: >>> On Tue, 25 Jun 2019 at 01:17, Marek Vasut wrote: On 6/24/19 12:35 AM, Marek Vasut wrote: > Add basic SPI regmap support into the driver.

Re: [PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Alexei Starovoitov
On Tue, Jun 25, 2019 at 8:08 AM Dmitry V. Levin wrote: > > On Tue, Jun 25, 2019 at 07:16:55AM -0700, Alexei Starovoitov wrote: > > On Tue, Jun 25, 2019 at 4:07 AM Baruch Siach wrote: > > > > > > Merge commit 1c8c5a9d38f60 ("Merge > > > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next"

[PATCH 0/1] Fix broken build of mlx5

2019-06-25 Thread Jes Sorensen
From: Jes Sorensen This fixes an obvious build error that could have been caught by simply building the code before pushing out the patch. Cheers, Jes Jes Sorensen (1): mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 ++- 1 fil

[PATCH 1/1] mlx5: Fix build when CONFIG_MLX5_EN_RXNFC is disabled

2019-06-25 Thread Jes Sorensen
From: Jes Sorensen The previous patch broke the build with a static declaration for a public function. Fixes: 8f0916c6dc5c (net/mlx5e: Fix ethtool rxfh commands when CONFIG_MLX5_EN_RXNFC is disabled) Signed-off-by: Jes Sorensen --- drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 3 ++-

Re: [PATCH v2] bpf: fix uapi bpf_prog_info fields alignment

2019-06-25 Thread Dmitry V. Levin
On Tue, Jun 25, 2019 at 08:19:35AM -0700, Alexei Starovoitov wrote: > On Tue, Jun 25, 2019 at 8:08 AM Dmitry V. Levin wrote: > > On Tue, Jun 25, 2019 at 07:16:55AM -0700, Alexei Starovoitov wrote: > > > On Tue, Jun 25, 2019 at 4:07 AM Baruch Siach wrote: > > > > > > > > Merge commit 1c8c5a9d38f60

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-25 Thread Davide Caratti
On Thu, 2019-06-20 at 10:33 -0700, Cong Wang wrote: > On Thu, Jun 20, 2019 at 5:52 AM Davide Caratti wrote: > > hello Cong, thanks for reading. > > > > On Wed, 2019-06-19 at 15:04 -0700, Cong Wang wrote: > > > On Wed, Jun 19, 2019 at 2:10 PM Davide Caratti > > > wrote: > > > > on some CPUs (e.g

[net-next 1/1] tipc: simplify stale link failure criteria

2019-06-25 Thread Jon Maloy
In commit a4dc70d46cf1 ("tipc: extend link reset criteria for stale packet retransmission") we made link retransmission failure events dependent on the link tolerance, and not only of the number of failed retransmission attempts, as we did earlier. This works well. However, keeping the original, ad

Re: Warnings generated from tcp_sacktag_write_queue.

2019-06-25 Thread Chinmay Agarwal
On Tue, Jun 25, 2019 at 04:24:14PM +0200, Eric Dumazet wrote: > > > On 6/25/19 6:07 AM, Chinmay Agarwal wrote: > > Dear All, > > > > We are hitting the following WARN_ON condition: > > > > WARN_ON((int)tcp_packets_in_flight(tp) < 0); > > > > tcp_packets_in_flight = packets_out –( lost

4.19: Traced deadlock during xfrm_user module load

2019-06-25 Thread Thomas Jarosch
Hi all, we're in the process of upgrading to kernel 4.19 and hit a very rare lockup on boot during "xfrm_user" module load. The tested kernel was 4.19.55. When the strongswan IPsec service starts, it loads the xfrm_user module. -> modprobe hangs forever. Also network services like ssh or apache

[PATCH] ipvs: allow tunneling with gre encapsulation

2019-06-25 Thread Vadim Fedorenko
windows real servers can handle gre tunnels, this patch allows gre encapsulation with the tunneling method, thereby letting ipvs be load balancer for windows-based services Signed-off-by: Vadim Fedorenko --- include/uapi/linux/ip_vs.h | 1 + net/netfilter/ipvs/ip_vs_xmit.c | 76 ++

[net-next 1/1] tipc: eliminate unnecessary skb expansion during retransmission

2019-06-25 Thread Jon Maloy
We increase the allocated headroom for the buffer copies to be retransmitted. This eliminates the need for the lower stack levels (UDP/IP/L2) to expand the headroom in order to add their own headers. Signed-off-by: Jon Maloy --- net/tipc/link.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [PATCH net] vxlan: do not destroy fdb if register_netdevice() is failed

2019-06-25 Thread Taehee Yoo
On Tue, 25 Jun 2019 at 13:12, Roopa Prabhu wrote: > Hi Roopa, Thank you for the review! > On Sun, Jun 23, 2019 at 7:18 PM Taehee Yoo wrote: > > > > On Mon, 24 Jun 2019 at 03:07, David Miller wrote: > > > > > > > Hi David, > > > > Thank you for the review! > > > > > From: Taehee Yoo > > > Dat

Re: [PATCH v3 net] af_packet: Block execution of tasks waiting for transmit to complete in AF_PACKET

2019-06-25 Thread Neil Horman
On Tue, Jun 25, 2019 at 09:37:17AM -0400, Willem de Bruijn wrote: > On Tue, Jun 25, 2019 at 7:03 AM Neil Horman wrote: > > > > On Mon, Jun 24, 2019 at 06:15:29PM -0400, Willem de Bruijn wrote: > > > > > > + if (need_wait && !packet_next_frame(po, > > > > > > &po->tx_ring, TP_STATUS_

Re: [PATCH net] net/sched: flower: fix infinite loop in fl_walk()

2019-06-25 Thread Davide Caratti
On Tue, 2019-06-25 at 17:47 +0200, Davide Caratti wrote: > On Thu, 2019-06-20 at 10:33 -0700, Cong Wang wrote: > > On Thu, Jun 20, 2019 at 5:52 AM Davide Caratti wrote: > > > hello Cong, thanks for reading. > > > > > > On Wed, 2019-06-19 at 15:04 -0700, Cong Wang wrote: > > > > On Wed, Jun 19, 20

[PATCH bpf] bpf: fix BPF_ALU32 | BPF_ARSH on BE arches

2019-06-25 Thread Jiong Wang
Yauheni reported the following code do not work correctly on BE arches: ALU_ARSH_X: DST = (u64) (u32) ((*(s32 *) &DST) >> SRC); CONT; ALU_ARSH_K: DST = (u64) (u32) ((*(s32 *) &DST) >> IMM); CONT; and are causing failure of

Re: 4.19: Traced deadlock during xfrm_user module load

2019-06-25 Thread Florian Westphal
Thomas Jarosch wrote: > we're in the process of upgrading to kernel 4.19 and hit > a very rare lockup on boot during "xfrm_user" module load. > The tested kernel was 4.19.55. > > When the strongswan IPsec service starts, it loads the xfrm_user module. > -> modprobe hangs forever. > > Also netwo

Re: [PATCH v2 net-next] ipv6: Convert gateway validation to use fib6_info

2019-06-25 Thread Wei Wang
On Mon, Jun 24, 2019 at 1:44 PM David Ahern wrote: > > From: David Ahern > > Gateway validation does not need a dst_entry, it only needs the fib > entry to validate the gateway resolution and egress device. So, > convert ip6_nh_lookup_table from ip6_pol_route to fib6_table_lookup > and ip6_route_

[PATCH bpf] tools: bpftool: use correct argument in cgroup errors

2019-06-25 Thread Jakub Kicinski
cgroup code tries to use argv[0] as the cgroup path, but if it fails uses argv[1] to report errors. Fixes: 5ccda64d38cc ("bpftool: implement cgroup bpf operations") Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet --- tools/bpf/bpftool/cgroup.c | 6 +++--- 1 file changed, 3 insertions(

  1   2   3   >