Re: [PATCH net v2] openvswitch: Fix conntrack cache with timeout

2019-08-22 Thread Pravin Shelar
On Thu, Aug 22, 2019 at 1:28 PM Yi-Hung Wei wrote: > > This patch addresses a conntrack cache issue with timeout policy. > Currently, we do not check if the timeout extension is set properly in the > cached conntrack entry. Thus, after packet recirculate from conntrack > action, the timeout polic

Re: [PATCH net-next] net/rds: Fix info leak in rds6_inc_info_copy()

2019-08-22 Thread santosh . shilimkar
On 8/21/19 8:18 PM, Ka-Cheong Poon wrote: The rds6_inc_info_copy() function has a couple struct members which are leaking stack information. The ->tos field should hold actual information and the ->flags field needs to be zeroed out. Fixes: 3eb450367d08 ("rds: add type of service(tos) infrastru

Re: [RFC bpf-next 0/5] Convert iproute2 to use libbpf (WIP)

2019-08-22 Thread Andrii Nakryiko
On Thu, Aug 22, 2019 at 1:33 AM Daniel Borkmann wrote: > > On 8/22/19 9:49 AM, Andrii Nakryiko wrote: > > On Wed, Aug 21, 2019 at 2:07 PM Toke Høiland-Jørgensen > > wrote: > >> Andrii Nakryiko writes: > >>> On Tue, Aug 20, 2019 at 4:47 AM Toke Høiland-Jørgensen > >>> wrote: > > ipro

Re: [PATCH net-next,v5, 0/6] Add software backchannel and mlx5e HV VHCA stats

2019-08-22 Thread David Miller
From: Saeed Mahameed Date: Fri, 23 Aug 2019 05:29:48 + > On Thu, 2019-08-22 at 15:39 -0700, David Miller wrote: >> From: Haiyang Zhang >> Date: Thu, 22 Aug 2019 22:37:13 + >> >> > The v5 is pretty much the same as v4, except Eran had a fix to >> patch #3 in response to >> > Leon Romanov

Re: [PATCH net v3] ixgbe: fix double clean of tx descriptors with xdp

2019-08-22 Thread Björn Töpel
On 2019-08-22 19:32, William Tu wrote: On Thu, Aug 22, 2019 at 10:21 AM Alexander Duyck wrote: On Thu, Aug 22, 2019 at 10:12 AM Ilya Maximets wrote: Tx code doesn't clear the descriptors' status after cleaning. So, if the budget is larger than number of used elems in a ring, some descriptor

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Saeed Mahameed
On Thu, 2019-08-22 at 18:33 -0700, Jakub Kicinski wrote: > On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > > From: Moshe Shemesh > > > > Added the following packets drop counter: > > Device out of buffer - counts packets which were dropped due to > > full > > device internal receive q

Re: [PATCH v2 net] Add genphy_c45_config_aneg() function to phy-c45.c

2019-08-22 Thread Heiner Kallweit
On 23.08.2019 01:15, David Miller wrote: > From: Marco Hartmann > Date: Wed, 21 Aug 2019 11:00:46 + > >> Commit 34786005eca3 ("net: phy: prevent PHYs w/o Clause 22 regs from calling >> genphy_config_aneg") introduced a check that aborts phy_config_aneg() >> if the phy is a C45 phy. >> This ca

Re: [PATCH] iwlwifi: remove redundant assignment to variable bufsz

2019-08-22 Thread Luca Coelho
On Thu, 2019-08-01 at 17:44 +0100, Colin King wrote: > From: Colin Ian King > > The variable bufsz is being initialized with a value that is never > read and it is being updated later with a new value. The > initialization is redundant and can be removed. > > Addresses-Coverity: ("Unused value")

[PATCH bpf-next 1/4] bpf: introduce verifier internal test flag

2019-08-22 Thread Alexei Starovoitov
Introduce BPF_F_TEST_STATE_FREQ flag to stress test parentage chain and state pruning. Signed-off-by: Alexei Starovoitov --- include/linux/bpf_verifier.h | 1 + include/uapi/linux/bpf.h | 3 +++ kernel/bpf/syscall.c | 1 + kernel/bpf/verifier.c| 5 - 4 files changed, 9 in

[PATCH bpf-next 3/4] selftests/bpf: verifier precise tests

2019-08-22 Thread Alexei Starovoitov
Use BPF_F_TEST_STATE_FREQ flag to check that precision tracking works as expected by comparing every step it takes. Signed-off-by: Alexei Starovoitov --- tools/testing/selftests/bpf/test_verifier.c | 68 -- .../testing/selftests/bpf/verifier/precise.c | 117 ++ 2 file

[PATCH net-next] bnxt_en: Fix allocation of zero statistics block size regression.

2019-08-22 Thread Michael Chan
Recent commit added logic to determine the appropriate statistics block size to allocate and the size is stored in bp->hw_ring_stats_size. But if the firmware spec is older than 1.6.0, it is 0 and not initialized. This causes the allocation to fail with size 0 and bnxt_open() to abort. Fix it by

[PATCH bpf-next 4/4] selftests/bpf: add precision tracking test

2019-08-22 Thread Alexei Starovoitov
Copy-paste of existing test "calls: cross frame pruning - liveness propagation" but ran with different parentage chain heuristic which stresses different path in precision tracking logic. Signed-off-by: Alexei Starovoitov --- This test will be failing without this fix https://patchwork.ozlabs.org

[PATCH bpf-next 2/4] tools/bpf: sync bpf.h

2019-08-22 Thread Alexei Starovoitov
sync bpf.h from kernel/ to tools/ Signed-off-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index b5889257cc33..5d2fb183ee2d 100644 --- a/tools/include/uapi/linux/bpf

[PATCH bpf-next 0/4] bpf: precision tracking tests

2019-08-22 Thread Alexei Starovoitov
Add few additional tests for precision tracking in the verifier. Alexei Starovoitov (4): bpf: introduce verifier internal test flag tools/bpf: sync bpf.h selftests/bpf: verifier precise tests selftests/bpf: add precision tracking test include/linux/bpf_verifier.h | 1 +

Re: [PATCH net-next,v5, 0/6] Add software backchannel and mlx5e HV VHCA stats

2019-08-22 Thread Saeed Mahameed
On Thu, 2019-08-22 at 15:39 -0700, David Miller wrote: > From: Haiyang Zhang > Date: Thu, 22 Aug 2019 22:37:13 + > > > The v5 is pretty much the same as v4, except Eran had a fix to > patch #3 in response to > > Leon Romanovsky . > > Well you now have to send me a patch relative to v4 in ord

Re: [PATCH spi for-5.4 0/5] Deterministic SPI latency with NXP DSPI driver

2019-08-22 Thread Richard Cochran
On Thu, Aug 22, 2019 at 07:13:12PM +0300, Vladimir Oltean wrote: > You do think that I understand the problem? But I don't! ;^) > > And who generates Local_sync_resp? > > > > Local_sync_resp is the same as Local_sync_req except maybe with a > custom tag added by the switch. Irrelevant as long as

Re: [PATCH] iwlwifi: mvm: fix old-style declaration

2019-08-22 Thread Luciano Coelho
On Fri, 2019-07-26 at 22:18 +0800, YueHaibing wrote: > There expect the 'static' keyword to come first in a > declaration, and we get a warning for this with "make W=1": > > drivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:427:1: warning: > 'static' is not at beginning of declaration [-Wold-styl

Re: [PATCH net-next 07/10] iwlwifi: Use dev_get_drvdata where possible

2019-08-22 Thread Luciano Coelho
On Wed, 2019-07-24 at 19:27 +0800, Chuhong Yuan wrote: > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan > --- This patch is not relevant anymore because we have removed all D0i3/runtime PM code. Thanks anyway! -- Cheer

Re: [PATCH net-next,v5, 0/6] Add software backchannel and mlx5e HV VHCA stats

2019-08-22 Thread Eran Ben Elisha
On 8/23/2019 1:43 AM, Haiyang Zhang wrote: > > >> -Original Message- >> From: David Miller >> Sent: Thursday, August 22, 2019 3:39 PM >> To: Haiyang Zhang >> Cc: sas...@kernel.org; sae...@mellanox.com; l...@kernel.org; >> era...@mellanox.com; lorenzo.pieral...@arm.com; bhelg...@google

Re: [PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-22 Thread kbuild test robot
Hi Jeff, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc5 next-20190822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH v2] bonding: force enable lacp port after link state recovery for 802.3ad

2019-08-22 Thread zhangsha.zhang
From: Sha Zhang After the commit 334031219a84 ("bonding/802.3ad: fix slave link initialization transition states") merged, the slave's link status will be changed to BOND_LINK_FAIL from BOND_LINK_DOWN in the following scenario: - Driver reports loss of carrier and bonding driver receives NETDEV

Re: BUG: bnxt_en driver fails to initialize

2019-08-22 Thread Michael Chan
On Thu, Aug 22, 2019 at 8:03 PM Jonathan Lemon wrote: > > On a recent net-next 932630fa902878f4c8c50d0b1260eeb9de16b0a4, > installing the build on a box which has a Broadcom card with > the 20.1 firmware, the driver refuses to initialize. I tracked > this down to: > > static int bnxt_allo

Re: [PATCH v3] tun: fix use-after-free when register netdev failed

2019-08-22 Thread Jason Wang
- Original Message - > > > On 2019/8/22 14:07, Yang Yingliang wrote: > > > > > > On 2019/8/22 10:13, Jason Wang wrote: > >> > >> On 2019/8/20 上午10:28, Jason Wang wrote: > >>> > >>> On 2019/8/20 上午9:25, David Miller wrote: > From: Yang Yingliang > Date: Mon, 19 Aug 2019 21:31:

BUG: bnxt_en driver fails to initialize

2019-08-22 Thread Jonathan Lemon
On a recent net-next 932630fa902878f4c8c50d0b1260eeb9de16b0a4, installing the build on a box which has a Broadcom card with the 20.1 firmware, the driver refuses to initialize. I tracked this down to: static int bnxt_alloc_stats(struct bnxt *bp) ... cpr->hw_stats

Re: [PATCH ipsec-next 1/7] net: add queue argument to __skb_wait_for_more_packets and __skb_{,try_}recv_datagram

2019-08-22 Thread kbuild test robot
Hi Sabrina, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ipsec-next/master] url: https://github.com/0day-ci/linux/commits/Sabrina-Dubroca/ipsec-add-TCP-encapsulation-support-RFC-8229/20190823-065431 base: https://kernel.googlesource.com/pub/scm/linux/

Re: [PATCH 2/2] selinux: use netlink_receive hook

2019-08-22 Thread kbuild test robot
Hi Jeff, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc5 next-20190822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jeff

Re: [PATCH 2/2] selinux: use netlink_receive hook

2019-08-22 Thread kbuild test robot
Hi Jeff, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc5 next-20190822] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Jeff

Re: [PATCH net-next 07/10] net: dsa: mv88e6xxx: rename port cmode macro

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:21AM +0200, Marek Behún wrote: > This is a cosmetic update. We are removing the last underscore from > macros MV88E6XXX_PORT_STS_CMODE_100BASE_X and > MV88E6XXX_PORT_STS_CMODE_1000BASE_X. The 2500base-x version does not > have that underscore. Also PHY_INTERFACE_MODE_

Re: [PATCH net-next 06/10] net: dsa: mv88e6xxx: add serdes_get_lane method for Topaz family

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:20AM +0200, Marek Behún wrote: > The Topaz family has only one SERDES, on port 5, with address 0x15. > Currently we have MV88E6341_ADDR_SERDES macro used in the > mv88e6341_serdes_power method. Rename the macro to MV88E6341_PORT5_LANE > and use the new mv88e6xxx_serdes

Re: [PATCH net-next 05/10] net: dsa: mv88e6xxx: create chip->info->ops->serdes_get_lane method

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 01:27:19AM +0200, Marek Behún wrote: > Create a serdes_get_lane() method in the mv88e6xxx operations structure. > Use it instead of calling the different implementations. > > Signed-off-by: Marek Behún Reviewed-by: Andrew Lunn Andrew

Re: [net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 23:35:52 +, Saeed Mahameed wrote: > From: Moshe Shemesh > > Added the following packets drop counter: > Device out of buffer - counts packets which were dropped due to full > device internal receive queue. > This counter will be shown on ethtool as a new counter called > d

Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-22 Thread Andrew Lunn
On Thu, Aug 22, 2019 at 04:20:47PM -0700, David Miller wrote: > From: René van Dorst > Date: Wed, 21 Aug 2019 16:45:44 +0200 > > > 1. net: dsa: mt7530: Convert to PHYLINK API > >This patch converts mt7530 to PHYLINK API. > > 2. dt-bindings: net: dsa: mt7530: Add support for port 5 > > 3. net:

[PATCH] ncsi-netlink: support sending NC-SI commands over Netlink interface

2019-08-22 Thread Ben Wei
This patch extends ncsi-netlink command line utility to send NC-SI command to kernel driver via NCSI_CMD_SEND_CMD command. New command line option -o (opcode) is used to specify NC-SI command and optional payload. For example, to send "Get Parameter" command ncsi-netlink -l 2 -c 0 -p0 -o 0x

Re: [PATCH net-next 6/6] net: dsa: clear VLAN flags for CPU port

2019-08-22 Thread Vladimir Oltean
On 8/22/19 11:13 PM, Vivien Didelot wrote: When the bridge offloads a VLAN on a slave port, we also need to program its dedicated CPU port as a member of the VLAN. Drivers may handle the CPU port's membership as they want. For example, Marvell as a special "Unmodified" mode to pass frames as is

Re: [PATCH net-next 2/6] net: dsa: do not skip -EOPNOTSUPP in dsa_port_vid_add

2019-08-22 Thread Vladimir Oltean
On Fri, 23 Aug 2019 at 02:43, Vivien Didelot wrote: > > Hi Vladimir, > > On Fri, 23 Aug 2019 01:06:58 +0300, Vladimir Oltean wrote: > > Hi Vivien, > > > > On 8/22/19 11:13 PM, Vivien Didelot wrote: > > > Currently dsa_port_vid_add returns 0 if the switch returns -EOPNOTSUPP. > > > > > > This func

Re: [PATCH net-next 2/6] net: dsa: do not skip -EOPNOTSUPP in dsa_port_vid_add

2019-08-22 Thread Vivien Didelot
Hi Vladimir, On Fri, 23 Aug 2019 01:06:58 +0300, Vladimir Oltean wrote: > Hi Vivien, > > On 8/22/19 11:13 PM, Vivien Didelot wrote: > > Currently dsa_port_vid_add returns 0 if the switch returns -EOPNOTSUPP. > > > > This function is used in the tag_8021q.c code to offload the PVID of > > ports,

Re: r8169: regression on MIPS/Loongson

2019-08-22 Thread Aaro Koskinen
Hi, On Fri, Aug 23, 2019 at 12:52:34AM +0200, Heiner Kallweit wrote: > On 23.08.2019 00:25, Aaro Koskinen wrote: > > After upgrading from v5.2 to v5.3-rc5 on MIPS/Loongson board, copying > > large files from network with scp started to fail with "Integrity error". > > Bisected to: > > > > f072218

[net-next 8/8] net/mlx5e: Support TSO and TX checksum offloads for IP-in-IP tunnels

2019-08-22 Thread Saeed Mahameed
From: Marina Varshaver Add TX offloads support for IP-in-IP tunneled packets by reporting the needed netdev features. Signed-off-by: Marina Varshaver Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 10 ++ 1 file changed, 10

[net-next 4/8] net/mlx5e: Add device out of buffer counter

2019-08-22 Thread Saeed Mahameed
From: Moshe Shemesh Added the following packets drop counter: Device out of buffer - counts packets which were dropped due to full device internal receive queue. This counter will be shown on ethtool as a new counter called dev_out_of_buffer. The counter is read from FW by command QUERY_VNIC_ENV.

[net-next 5/8] net/mlx5e: Change function's position to a more fitting file

2019-08-22 Thread Saeed Mahameed
From: Aya Levin Move function which indicates whether tunnel inner flow table is supported from en.h to en_fs.c. It fits better right after tunnel protocol rules definitions. Signed-off-by: Aya Levin Reviewed-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/ml

[net-next 7/8] net/mlx5e: Improve stateless offload capability check

2019-08-22 Thread Saeed Mahameed
From: Marina Varshaver Use generic function for checking tunnel stateless offload capability instead of separate macros. Signed-off-by: Marina Varshaver Reviewed-by: Aya Levin Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en/fs.h | 3 +++ drivers/net/ethernet/me

[net-next 6/8] net/mlx5e: Support RSS for IP-in-IP and IPv6 tunneled packets

2019-08-22 Thread Saeed Mahameed
From: Aya Levin Add support for inner header RSS on IP-in-IP and IPv6 tunneled packets. Add rules to the steering table regarding outer IP header, with IPv4/6->IP-in-IP. Tunneled packets with protocol numbers: 0x4 (IP-in-IP) and 0x29 (IPv6) are RSS-ed on the inner IP header. Separate FW dependen

[net-next 3/8] net/mlx5e: Support LAG TX port affinity distribution

2019-08-22 Thread Saeed Mahameed
From: Maxim Mikityanskiy When the VF LAG is in use, round-robin the TX affinity of channels among the different ports, if supported by the firmware. Create a set of TISes per port, while doing round-robin of the channels over the different sets. Let all SQs of a channel share the same set of TISe

[net-next 2/8] net/mlx5e: Expose new function for TIS destroy loop

2019-08-22 Thread Saeed Mahameed
From: Tariq Toukan For better modularity and code sharing. Function internal change to be introduced in the next patches. Signed-off-by: Tariq Toukan Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en.h | 1 + drivers/net/ethernet/mellanox/mlx5/core/en_main.c |

[net-next 1/8] net/mlx5e: ethtool, Fix a typo in WOL function names

2019-08-22 Thread Saeed Mahameed
From: Erez Alfasi Fix a typo in 'mlx5e_refomrat_wol_mode_mlx5_to_linux' and 'mlx5e_refomrat_wol_mode_linux_to_mlx5' function names: "refomrat" -> "reformat". Fixes: 928cfe8745a6 ("net/mlx5e: Wake On LAN support") Signed-off-by: Erez Alfasi Signed-off-by: Saeed Mahameed --- drivers/net/etherne

[pull request][net-next 0/8] Mellanox, mlx5 updates 2019-08-22

2019-08-22 Thread Saeed Mahameed
Hi Dave, This series provides some misc updates to mlx5 driver. For more information please see tag log below. Please pull and let me know if there is any problem. Please note that the series starts with a merge of mlx5-next branch, to resolve and avoid dependency with rdma tree. Thanks, Saeed.

Re: RFC: very rough draft of a bpf permission model

2019-08-22 Thread Alexei Starovoitov
On Thu, Aug 22, 2019 at 08:17:54AM -0700, Andy Lutomirski wrote: > BPF security strawman, v0.1 > > This is very rough. Most of this, especially the API details, needs > work before it's ready to implement. The whole concept also needs > review. > > = Goals = > > The overall goal is to make it

Re: [PATCH net-next v2 0/3] net: dsa: mt7530: Convert to PHYLINK and add support for port 5

2019-08-22 Thread David Miller
From: René van Dorst Date: Wed, 21 Aug 2019 16:45:44 +0200 > 1. net: dsa: mt7530: Convert to PHYLINK API >This patch converts mt7530 to PHYLINK API. > 2. dt-bindings: net: dsa: mt7530: Add support for port 5 > 3. net: dsa: mt7530: Add support for port 5 >These 2 patches adding support for

Re: [PATCH 1/2] rtnetlink: gate MAC address with an LSM hook

2019-08-22 Thread David Miller
From: Jeff Vander Stoep Date: Wed, 21 Aug 2019 15:45:47 +0200 > MAC addresses are often considered sensitive because they are > usually unique and can be used to identify/track a device or > user [1]. > > The MAC address is accessible via the RTM_NEWLINK message type of a > netlink route socket[

Re: [PATCH net-next] net: dsa: remove bitmap operations

2019-08-22 Thread David Miller
From: Vivien Didelot Date: Thu, 22 Aug 2019 16:17:28 -0400 > David, I've included this patch into a new series with other related patches, > you can ignore this one now. Ok, thanks for letting me know.

Re: [net-next 0/7][pull request] ipv6: Extension header infrastructure

2019-08-22 Thread David Miller
From: David Miller Date: Thu, 22 Aug 2019 16:01:44 -0700 (PDT) > Jeff, why are you submitting Tom's changes, can't he submit his > patches on his own? Just in case it isn't clear. Tom has submitted these changes in the past, there were objections made to them. Tom must keep submitting these ch

Re: [PATCH net-next 06/10] net: sched: conditionally obtain rtnl lock in cls hw offloads API

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 15:43:49 +0300, Vlad Buslov wrote: > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 02a547aa77c0..bda42f1b5514 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -3076,11 +3076,28 @@ __tc_setup_cb_call(struct tcf_block *block, enum > tc_setup_ty

Re: [net-next 0/7][pull request] ipv6: Extension header infrastructure

2019-08-22 Thread David Miller
Jeff, why are you submitting Tom's changes, can't he submit his patches on his own?

Re: r8169: regression on MIPS/Loongson

2019-08-22 Thread David Miller
From: Heiner Kallweit Date: Fri, 23 Aug 2019 00:52:34 +0200 > Typically the Realtek chips are used on Intel platforms and I haven't > seen any such report yet, so it seems to be platform-specific. > Which board (DT config) is it, and can you provide a full dmesg? Unfortunately on Intel you're no

[net-next 5/7] ip6tlvs: Add TX parameters

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Define a number of transmit parameters for TLV Parameter table definitions. These will be used for validating TLVs that are set on a socket. Signed-off-by: Tom Herbert Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- include/net/ipeh.h | 18 + in

[net-next 2/7] ipeh: Move generic EH functions to exthdrs_common.c

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Move generic functions in exthdrs.c to new exthdrs_common.c so that exthdrs.c only contains functions that are specific to IPv6 processing, and exthdrs_common.c contains functions that are generic. These functions include those that will be used with IPv4 extension headers. Gene

[net-next 7/7] ip6tlvs: Validation of TX Destination and Hop-by-Hop options

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Validate Destination and Hop-by-Hop options. This uses the information in the TLV parameters table to validate various aspects of both individual TLVs as well as a list of TLVs in an extension header. There are two levels of validation that can be performed: simple checks and d

[net-next 3/7] ipeh: Generic TLV parser

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Create a generic TLV parser. This will be used with various extension headers that carry options including Destination, Hop-by-Hop, Segment Routing TLVs, and other cases of simple stateless parsing. Signed-off-by: Tom Herbert Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsh

[net-next 6/7] ip6tlvs: Add netlink interface

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Add a netlink interface to manage the TX TLV parameters. Managed parameters include those for validating and sending TLVs being sent such as alignment, TLV ordering, length limits, etc. Signed-off-by: Tom Herbert Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- incl

[net-next 0/7][pull request] ipv6: Extension header infrastructure

2019-08-22 Thread Jeff Kirsher
This patchset improves the IPv6 extension header infrastructure to make extension headers more usable and scalable. - Reorganize extension header files to separate out common API components - Create common TLV handler that will can be used in other use cases (e.g. segment routing TLVs,

[net-next 1/7] ipeh: Create exthdrs_options.c and ipeh.h

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Create exthdrs_options.c to hold code related to specific Hop-by-Hop and Destination extension header options. Move related functions in exthdrs.c to the new file. Create include net/ipeh.h to contain common definitions for IP extension headers. Signed-off-by: Tom Herbert Tes

[net-next 4/7] ip6tlvs: Registration of TLV handlers and parameters

2019-08-22 Thread Jeff Kirsher
From: Tom Herbert Create a single TLV parameter table that holds meta information for IPv6 Hop-by-Hop and Destination TLVs. The data structure is composed of a 256 element array of u8's (one entry for each TLV type to allow O(1) lookup). Each entry provides an offset into an array of TLV proc dat

Re: [PATCH net-next 04/10] net: sched: notify classifier on successful offload add/delete

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 15:43:47 +0300, Vlad Buslov wrote: > diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c > index 4215c849f4a3..d8ef7a9e6906 100644 > --- a/net/sched/cls_api.c > +++ b/net/sched/cls_api.c > @@ -3099,9 +3099,13 @@ int tc_setup_cb_add(struct tcf_block *block, struct > tcf_proto

Re: [PATCH net-next 03/10] net: sched: refactor block offloads counter usage

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 15:43:46 +0300, Vlad Buslov wrote: > Without rtnl lock protection filters can no longer safely manage block > offloads counter themselves. Refactor cls API to protect block offloadcnt > with tcf_block->cb_lock that is already used to protect driver callback > list and nooffloadd

Re: r8169: regression on MIPS/Loongson

2019-08-22 Thread Heiner Kallweit
On 23.08.2019 00:25, Aaro Koskinen wrote: > Hi, > > After upgrading from v5.2 to v5.3-rc5 on MIPS/Loongson board, copying > large files from network with scp started to fail with "Integrity error". > Bisected to: > > f072218cca5b076dd99f3dfa3aaafedfd0023a51 is the first bad commit > commit f07221

Re: [PATCH v2 bpf-next 1/4] bpf: unprivileged BPF access via /dev/bpf

2019-08-22 Thread Alexei Starovoitov
On Thu, Aug 22, 2019 at 04:17:43PM +0200, Daniel Borkmann wrote: > > > > Hence unprivileged bpf is actually something that can be deprecated. > > There is actually a publicly known use-case on unprivileged bpf wrt > socket filters, see the SO_ATTACH_BPF on sockets section as an example: > > >

Re: [v4] ocelot_ace: fix action of trap

2019-08-22 Thread David Miller
From: Yangbo Lu Date: Wed, 21 Aug 2019 09:59:12 +0800 > The trap action should be copying the frame to CPU and > dropping it for forwarding, but current setting was just > copying frame to CPU. > > Fixes: b596229448dd ("net: mscc: ocelot: Add support for tcam") > Signed-off-by: Yangbo Lu > Acke

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread David Miller
From: Casey Schaufler Date: Thu, 22 Aug 2019 15:34:44 -0700 > On 8/22/2019 3:28 PM, David Miller wrote: >> From: Casey Schaufler >> Date: Thu, 22 Aug 2019 14:59:37 -0700 >> >>> Sure, you *can* do that, but it would be insane to do so. >> We look up the neighbour table entries on every single pac

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Casey Schaufler
On 8/22/2019 3:28 PM, David Miller wrote: > From: Casey Schaufler > Date: Thu, 22 Aug 2019 14:59:37 -0700 > >> Sure, you *can* do that, but it would be insane to do so. > We look up the neighbour table entries on every single packet we > transmit from the kernel in the same exact way. > > And it w

r8169: regression on MIPS/Loongson

2019-08-22 Thread Aaro Koskinen
Hi, After upgrading from v5.2 to v5.3-rc5 on MIPS/Loongson board, copying large files from network with scp started to fail with "Integrity error". Bisected to: f072218cca5b076dd99f3dfa3aaafedfd0023a51 is the first bad commit commit f072218cca5b076dd99f3dfa3aaafedfd0023a51 Author: Heiner Kallweit

Re: [PATCH 0/3] Add NETIF_F_HW_BRIDGE feature

2019-08-22 Thread David Miller
From: Horatiu Vultur Date: Thu, 22 Aug 2019 21:07:27 +0200 > Current implementation of the SW bridge is setting the interfaces in > promisc mode when they are added to bridge if learning of the frames is > enabled. > In case of Ocelot which has HW capabilities to switch frames, it is not > needed

Re: [net-next v2 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-22

2019-08-22 Thread David Miller
From: Jeff Kirsher Date: Thu, 22 Aug 2019 13:30:26 -0700 > This series contains updates to i40e driver only. Pulled, thanks Jeff.

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread David Miller
From: Casey Schaufler Date: Thu, 22 Aug 2019 14:59:37 -0700 > Sure, you *can* do that, but it would be insane to do so. We look up the neighbour table entries on every single packet we transmit from the kernel in the same exact way. And it was exactly to get rid of a pointer in a data structure

Re: [PATCH net-next 01/10] net: sched: protect block offload-related fields with rw_semaphore

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 15:43:44 +0300, Vlad Buslov wrote: > @@ -2987,19 +3007,26 @@ int tc_setup_cb_call(struct tcf_block *block, enum > tc_setup_type type, > int ok_count = 0; > int err; > > + down_read(&block->cb_lock); > /* Make sure all netdevs sharing this block are offlo

Re: [PATCH net-next 2/6] net: dsa: do not skip -EOPNOTSUPP in dsa_port_vid_add

2019-08-22 Thread Vladimir Oltean
Hi Vivien, On 8/22/19 11:13 PM, Vivien Didelot wrote: Currently dsa_port_vid_add returns 0 if the switch returns -EOPNOTSUPP. This function is used in the tag_8021q.c code to offload the PVID of ports, which would simply not work if .port_vlan_add is not supported by the underlying switch. Do

Re: [net-next v2 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-22

2019-08-22 Thread Jakub Kicinski
On Thu, 22 Aug 2019 13:30:26 -0700, Jeff Kirsher wrote: > v2: Combined patch 7 & 9 in the original series, since both patches > bumped firmware API version. Also combined patches 12 & 13 in the > original series, since one increased the scope of checking for MAC > and the follow-on pat

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Casey Schaufler
On 8/22/2019 2:18 PM, David Miller wrote: > From: Casey Schaufler > Date: Thu, 22 Aug 2019 13:35:01 -0700 > >> If the secmark where replaced by a security blob, the u32 secmark field >> in an sk_buff would be replaced by a void * security field. > You can already use the secmark to hash to some ki

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread David Miller
From: Casey Schaufler Date: Thu, 22 Aug 2019 13:35:01 -0700 > If the secmark where replaced by a security blob, the u32 secmark field > in an sk_buff would be replaced by a void * security field. You can already use the secmark to hash to some kind of pointer or other object.

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread David Miller
From: Casey Schaufler Date: Thu, 22 Aug 2019 13:10:43 -0700 > Given that the original objection to using a skb extension for a > security blob was that an extension is dynamic, and that the ubiquitous > nature of LSM use makes that unreasonable, it would seem that supporting > the security blob a

Re: [PATCH net-next v2 2/3] net: ethernet: mediatek: Re-add support SGMII

2019-08-22 Thread Russell King - ARM Linux admin
Hi Rene, On Thu, Aug 22, 2019 at 07:50:33PM +, René van Dorst wrote: > Quoting Russell King - ARM Linux admin : > > Isn't this set for Cisco SGMII as well as for 802.3 1000BASE-X and > > the up-clocked 2500BASE-X modes? > > > > If so, is there a reason why 10Mbps and 100Mbps speeds aren't > >

[net 4/4] net/mlx5e: Remove ethernet segment from dump WQE

2019-08-22 Thread Saeed Mahameed
From: Eran Ben Elisha Dump WQE shall not include Ethernet segment. Define mlx5e_dump_wqe to be used for "Dump WQEs" instead of sharing it with the general mlx5e_tx_wqe layout. Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload support") Signed-off-by: Eran Ben Elisha Signed-off-by: Saeed M

[net 1/4] net/mlx5: Fix crdump chunks print

2019-08-22 Thread Saeed Mahameed
From: Moshe Shemesh Crdump repeats itself every chunk of 256bytes. That is due to bug of missing progressing offset while copying the data from buffer to devlink_fmsg. Fixes: 9b1f29823605 ("net/mlx5: Add support for FW fatal reporter dump") Signed-off-by: Moshe Shemesh Reviewed-by: Eran Ben Eli

[net 3/4] net/mlx5e: Add num bytes metadata to WQE info

2019-08-22 Thread Saeed Mahameed
From: Eran Ben Elisha For TLS WQEs, metadata info did not include num_bytes. Due to this issue, tx_tls_dump_bytes counter did not increment. Modify tx_fill_wi() to fill num bytes. When it is called for non-traffic WQE, zero is expected. Fixes: d2ead1f360e8 ("net/mlx5e: Add kTLS TX HW offload su

[net 2/4] net/mlx5: Fix delay in fw fatal report handling due to fw report

2019-08-22 Thread Saeed Mahameed
From: Moshe Shemesh When fw fatal error occurs, poll health() first detects and reports on a fw error. Afterwards, it detects and reports on the fw fatal error itself. That can cause a long delay in fw fatal error handling which waits in a queue for the fw error handling to be finished. The fw e

[pull request][net 0/4] Mellanox, mlx5 fixes 2019-08-22

2019-08-22 Thread Saeed Mahameed
Hi Dave, This series introduces some fixes to mlx5 driver. 1) Form Moshe, two fixes for firmware health reporter 2) From Eran, two ktls fixes. Please pull and let me know if there is any problem. No -stable this time :) .. Thanks, Saeed. --- The following changes since commit cc07db5a5b100bc8

Re: New skb extension for use by LSMs (skb "security blob")?

2019-08-22 Thread Casey Schaufler
On 8/22/2019 1:15 PM, Florian Westphal wrote: > Casey Schaufler wrote: >> Given that the original objection to using a skb extension for a >> security blob was that an extension is dynamic, and that the ubiquitous >> nature of LSM use makes that unreasonable, it would seem that supporting >> the s

Re: [PATCH net-next v5] sched: Add dualpi2 qdisc

2019-08-22 Thread Dave Taht
This is vastly improved code, thank you! 1) Since we're still duking it out over the meaning of the bits - not just the SCE thing, but as best as I can tell (but could be wrong) the NQB idea wants to put something into the l4s fast queue? Or is NQB supposed to be a third queue? In those cases, th

[net-next v2 10/13] i40e: Remove function i40e_update_dcb_config()

2019-08-22 Thread Jeff Kirsher
From: Grzegorz Siwik This patch removes function i40e_update_dcb_config(). Instead of i40e_update_dcb_config() we use i40e_init_dcb(), which implements the correct NVM read. Signed-off-by: Grzegorz Siwik Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e

[net-next v2 12/13] i40e: Persistent LLDP support

2019-08-22 Thread Jeff Kirsher
From: Sylwia Wnuczko This patch adds a function to read NVM module data and uses it to read current LLDP agent configuration from NVM API version 1.8. Signed-off-by: Sylwia Wnuczko Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_dcb.c| 18 ++

[net-next v2 04/13] i40e: fix shifts of signed values

2019-08-22 Thread Jeff Kirsher
From: Beilei Xing This patch fixes following error reported by cppcheck: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Beilei Xing Signed-off-by: Ferruh Yigit Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- .../net/ethernet/intel/i40e/i40e_re

[net-next v2 02/13] i40e: Check if transceiver implements DDM before access

2019-08-22 Thread Jeff Kirsher
From: "Mauro S. M. Rodrigues" Similar to the ixgbe issue fixed in: 655c91414579 ("ixgbe: Check DDM existence in transceiver before access) i40e has the same issue when reading eeprom from SFP's module that comply with SFF-8472 but not implement the Digital Diagnostic Monitoring (DDM) interface d

[net-next v2 11/13] i40e: allow reset in recovery mode

2019-08-22 Thread Jeff Kirsher
From: Piotr Kwapulinski Driver waits after issuing a reset. When a reset takes too long a driver gives up. Implemented by invoking PF reset in a loop. After defined number of unsuccessful PF reset trials it returns error. Without this patch PF reset fails when NIC is in recovery mode. So make i4

[net-next v2 13/13] i40e: fix retrying in i40e_aq_get_phy_capabilities

2019-08-22 Thread Jeff Kirsher
From: Marcin Formela Fixed a bug where driver was breaking out of the loop and reporting an error without retrying first. Signed-off-by: Marcin Formela Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_common.c | 17 ++--- 1 file change

[net-next v2 00/13][pull request] 40GbE Intel Wired LAN Driver Updates 2019-08-22

2019-08-22 Thread Jeff Kirsher
This series contains updates to i40e driver only. Arnd Bergmann reduces the stack usage which was causing warnings on 32-bit architectures due to large structure sizes for 2 functions getting inlined, so use noinline_for_stack to prevent the compilers from combining the 2 functions. Mauro S. M. R

[net-next v2 06/13] i40e: check_recovery_mode had wrong if statement

2019-08-22 Thread Jeff Kirsher
From: Adrian Podlawski Function check_recovery_mode had wrong if statement. Now we check proper FWS1B register values, which are responsible for the recovery mode. Recovery mode has 4 values for x710 and 2 for x722. That's why we need 6 different flags which are defined in the code. Now in the if

[net-next v2 03/13] i40e: add check on i40e_configure_tx_ring() return value

2019-08-22 Thread Jeff Kirsher
From: huhai When i40e_configure_tx_ring(vsi->tx_rings[i]) returns an error, we should exit from i40e_vsi_configure_tx and return the error, instead of continuing to check whether xdp is enable, and configure the xdp transmit ring. Signed-off-by: huhai Tested-by: Andrew Bowers Signed-off-by: Je

[net-next v2 01/13] i40e: reduce stack usage in i40e_set_fc

2019-08-22 Thread Jeff Kirsher
From: Arnd Bergmann The functions i40e_aq_get_phy_abilities_resp() and i40e_set_fc() both have giant structure on the stack, which makes each one use stack frames larger than 500 bytes. As clang decides one function into the other, we get a warning for exceeding the frame size limit on 32-bit ar

[net-next v2 05/13] i40e: Add drop mode parameter to set mac config

2019-08-22 Thread Jeff Kirsher
From: Sylwia Wnuczko This patch adds "drop mode" parameter to set mac config AQ command. This bit controls the behavior when a no-drop packet is blocking a TC queue. 0 – The PF driver is notified. 1 – The blocking packet is dropped and then the PF driver is notified. Signed-off-by: Sylwia Wnuczk

[net-next v2 09/13] i40e: Fix crash caused by stress setting of VF MAC addresses

2019-08-22 Thread Jeff Kirsher
From: Slawomir Laba Add update to the VSI pointer passed to the i40e_set_vf_mac function. If VF is in reset state the driver waits in i40e_set_vf_mac function for the reset to be complete, yet after reset the vsi pointer that was passed into this function is no longer valid. The patch updates lo

[net-next v2 08/13] i40e: reset veb.tc_stats when resetting veb.stats

2019-08-22 Thread Jeff Kirsher
From: Jacob Keller The stats structure for the VEB switch statistics is reset periodically, but the tc_stats are not reset at the same time. Signed-off-by: Jacob Keller Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/i40e/i40e_main.c | 4 1 file chang

  1   2   3   >