Re: [RFC PATCH] bpftool btf: Add prefix option to dump C

2020-07-21 Thread Andrii Nakryiko
On Tue, Jul 21, 2020 at 10:44 PM Ian Rogers wrote: > > When bpftool dumps types and enum members into a header file for > inclusion the names match those in the original source. If the same > header file needs to be included in the original source and the bpf > program, the names of structs, union

[PATCH] xen-netfront: fix potential deadlock in xennet_remove()

2020-07-21 Thread Andrea Righi
There's a potential race in xennet_remove(); this is what the driver is doing upon unregistering a network device: 1. state = read bus state 2. if state is not "Closed": 3.request to set state to "Closing" 4.wait for state to be set to "Closing" 5.request to set state to "Clo

Re: [PATCH v3 bpf-next 2/9] bpf, xdp: maintain info on attached XDP BPF programs in net_device

2020-07-21 Thread Andrii Nakryiko
On Thu, Jul 16, 2020 at 1:31 PM Andrii Nakryiko wrote: > > On Thu, Jul 16, 2020 at 12:01 PM David Ahern wrote: > > > > On 7/15/20 10:55 PM, Andrii Nakryiko wrote: > > > Instead of delegating to drivers, maintain information about which BPF > > > programs are attached in which XDP modes (generic/s

[PATCH v4 bpf-next 8/9] selftests/bpf: add BPF XDP link selftests

2020-07-21 Thread Andrii Nakryiko
Add selftest validating all the attachment logic around BPF XDP link. Test also link updates and get_obj_info() APIs. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/prog_tests/xdp_link.c | 137 ++ .../selftests/bpf/progs/test_xdp_link.c | 12 ++ 2 files changed

[PATCH v4 bpf-next 6/9] bpf: implement BPF XDP link-specific introspection APIs

2020-07-21 Thread Andrii Nakryiko
Implement XDP link-specific show_fdinfo and link_info to emit ifindex. Signed-off-by: Andrii Nakryiko --- include/uapi/linux/bpf.h | 3 +++ net/core/dev.c | 31 +++ 2 files changed, 34 insertions(+) diff --git a/include/uapi/linux/bpf.h b/include/uapi/linu

[PATCH v4 bpf-next 9/9] bpf, xdp: remove XDP_QUERY_PROG and XDP_QUERY_PROG_HW XDP commands

2020-07-21 Thread Andrii Nakryiko
Now that BPF program/link management is centralized in generic net_device code, kernel code never queries program id from drivers, so XDP_QUERY_PROG/XDP_QUERY_PROG_HW commands are unnecessary. This patch removes all the implementations of those commands in kernel, along the xdp_attachment_query().

[PATCH v4 bpf-next 7/9] libbpf: add support for BPF XDP link

2020-07-21 Thread Andrii Nakryiko
Sync UAPI header and add support for using bpf_link-based XDP attachment. Make xdp/ prog type set expected attach type. Kernel didn't enforce attach_type for XDP programs before, so there is no backwards compatiblity issues there. Also fix section_names selftest to recognize that xdp prog types no

[PATCH v4 bpf-next 5/9] bpf, xdp: implement LINK_UPDATE for BPF XDP link

2020-07-21 Thread Andrii Nakryiko
Add support for LINK_UPDATE command for BPF XDP link to enable reliable replacement of underlying BPF program. Signed-off-by: Andrii Nakryiko --- net/core/dev.c | 43 +++ 1 file changed, 43 insertions(+) diff --git a/net/core/dev.c b/net/core/dev.c index

[PATCH v4 bpf-next 2/9] bpf, xdp: maintain info on attached XDP BPF programs in net_device

2020-07-21 Thread Andrii Nakryiko
Instead of delegating to drivers, maintain information about which BPF programs are attached in which XDP modes (generic/skb, driver, or hardware) locally in net_device. This effectively obsoletes XDP_QUERY_PROG command. Such re-organization simplifies existing code already. But it also allows to

[PATCH v4 bpf-next 4/9] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-21 Thread Andrii Nakryiko
Add bpf_link-based API (bpf_xdp_link) to attach BPF XDP program through BPF_LINK_CREATE command. bpf_xdp_link is mutually exclusive with direct BPF program attachment, previous BPF program should be detached prior to attempting to create a new bpf_xdp_link attachment (for a given XDP mode). Once B

[PATCH v4 bpf-next 1/9] bpf: make bpf_link API available indepently of CONFIG_BPF_SYSCALL

2020-07-21 Thread Andrii Nakryiko
Similarly to bpf_prog, make bpf_link and related generic API available unconditionally to make it easier to have bpf_link support in various parts of the kernel. Stub out init/prime/settle/cleanup and inc/put APIs. Reported-by: kernel test robot Signed-off-by: Andrii Nakryiko --- include/linux/

[PATCH v4 bpf-next 3/9] bpf, xdp: extract common XDP program attachment logic

2020-07-21 Thread Andrii Nakryiko
Further refactor XDP attachment code. dev_change_xdp_fd() is split into two parts: getting bpf_progs from FDs and attachment logic, working with bpf_progs. This makes attachment logic a bit more straightforward and prepares code for bpf_xdp_link inclusion, which will share the common logic. Signe

[PATCH v4 bpf-next 0/9] BPF XDP link

2020-07-21 Thread Andrii Nakryiko
Following cgroup and netns examples, implement bpf_link support for XDP. The semantics is described in patch #2. Program and link attachments are mutually exclusive, in the sense that neither link can replace attached program nor program can replace attached link. Link can't replace attached link

Re: [PATCH bpf-next 2/7] bpf, xdp: add bpf_link-based XDP attachment API

2020-07-21 Thread Andrii Nakryiko
On Thu, Jul 16, 2020 at 3:52 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > > On Wed, Jul 15, 2020 at 8:48 AM Toke Høiland-Jørgensen > > wrote: > >> > >> Andrii Nakryiko writes: > >> > >> >> Yup, that was helpful, thanks! I think our difference of opinion on this > >> >> stem

RE: [PATCH bpf-next] bpf: Generate cookie for new non-initial net NS

2020-07-21 Thread Jianlin Lv
> -Original Message- > From: bpf-ow...@vger.kernel.org On Behalf > Of Daniel Borkmann > Sent: Wednesday, July 22, 2020 4:18 AM > To: Jianlin Lv ; b...@vger.kernel.org > Cc: da...@davemloft.net; k...@kernel.org; a...@kernel.org; y...@fb.com; > Song Zhu ; linux-ker...@vger.kernel.org; > ne

KMSAN: uninit-value in _copy_to_iter (3)

2020-07-21 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:14525656 compiler.h: reinstate missing KMSAN_INIT git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1599608710 kernel config: https://syzkaller.appspot.com/x/.config

Re: [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

2020-07-21 Thread Julian Anastasov
Hello, On Wed, 22 Jul 2020, Pablo Neira Ayuso wrote: > On Fri, Jul 17, 2020 at 08:36:36PM +0300, Julian Anastasov wrote: > > > > On Fri, 17 Jul 2020, Andrew Sy Kim wrote: > > > > > Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when > > > CONFIG_SYSCTL is disabled > > > >

Re: [PATCH bpf-next v2 3/6] bpf: support attaching freplace programs to multiple attach points

2020-07-21 Thread Andrii Nakryiko
On Tue, Jul 21, 2020 at 5:29 PM Alexei Starovoitov wrote: > > On Mon, Jul 20, 2020 at 08:48:04PM -0700, Andrii Nakryiko wrote: > > > > Right, I wanted to avoid taking a refcnt on aux->linked_prog during > > PROG_LOAD. The reason for that was (and still is) that I don't get who > > and when has to

KMSAN: uninit-value in geneve_xmit

2020-07-21 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:14525656 compiler.h: reinstate missing KMSAN_INIT git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1339608710 kernel config: https://syzkaller.appspot.com/x/.config

RE: [EXT] Re: [PATCH] net: dsa: Add protocol support for 802.1AD when adding or deleting vlan for dsa switch and port

2020-07-21 Thread Hongbo Wang
Hi Florian, Thanks for your reply! I had posted my patch for switch port driver, the email title is "net: dsa: ocelot: Add support for QinQ Operation", Best Regards! hongbo -Original Message- From: Florian Fainelli Sent: 2020年7月22日 1:55 To: Hongbo Wang ; Xiaoliang Yang ; allan.niel.

[PATCH] net: dsa: ocelot: Add support for QinQ Operation

2020-07-21 Thread hongbo . wang
From: "hongbo.wang" This featue can be test using network test tools TX-tool -> swp0 -> swp1 -> RX-tool TX-tool simulates Customer that will send and receive packets with single VLAN tag(CTAG), RX-tool simulates Service-Provider that will send and receive packets with double VLA

[PATCH bpf-next] tools/bpftool: strip BPF .o files before skeleton generation

2020-07-21 Thread Andrii Nakryiko
Strip away DWARF info from .bpf.o files, before generating BPF skeletons. This reduces bpftool binary size from 3.43MB to 2.58MB. Signed-off-by: Andrii Nakryiko --- tools/bpf/bpftool/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/bpf/bpftool/Makefile b/tools

Re: [PATCH net 0/2] udp: Fix reuseport selection with connected sockets.

2020-07-21 Thread Kuniyuki Iwashima
From: David Miller Date: Tue, 21 Jul 2020 15:32:39 -0700 (PDT) > From: Kuniyuki Iwashima > Date: Tue, 21 Jul 2020 15:15:29 +0900 > > > From: kuniyu > > Please fix your configuration to show your full name in this > "From: " field, I had to edit it out and use the one from your > email head

pull-request: bpf-next 2020-07-21

2020-07-21 Thread Alexei Starovoitov
Hi David, The following pull-request contains BPF updates for your *net-next* tree. We've added 46 non-merge commits during the last 6 day(s) which contain a total of 68 files changed, 4929 insertions(+), 526 deletions(-). The main changes are: 1) Run BPF program on socket lookup, from Jakub.

Re: [PATCH net-next 3/3] docs: networking: timestamping: add a set of frequently asked questions

2020-07-21 Thread Richard Cochran
On Tue, Jul 21, 2020 at 10:51:27PM +0300, Vladimir Oltean wrote: > So I think the position of "just don't have software timestamping code > in DSA and you'll be fine" won't be getting us anywhere. Either you can > or you can't, and there isn't anything absurd about it, so sooner or > later somebody

linux-next: manual merge of the bpf-next tree with the net tree

2020-07-21 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the bpf-next tree got conflicts in: net/ipv4/udp.c net/ipv6/udp.c between commit: efc6b6f6c311 ("udp: Improve load balancing for SO_REUSEPORT.") from the net tree and commits: 7629c73a1466 ("udp: Extract helper for selecting socket from reuseport gr

Re: [PATCH v2] drivers/net/wan/x25_asy: Fix to make it work

2020-07-21 Thread Xie He
On Tue, Jul 21, 2020 at 6:30 PM -0700 David Miller wrote: > > Applied, thank you. Thank you so much, David!

[PATCH net-next] net: qed: Remove unneeded cast from memory allocation

2020-07-21 Thread Wang Hai
Remove casting the values returned by memory allocation function. Coccinelle emits WARNING: casting value returned by memory allocation unction to (struct roce_destroy_qp_req_output_params *) is useless. This issue was detected by using the Coccinelle software. Signed-off-by: Wang Hai --- driv

Re: [PATCH net-next 0/6] ionic updates

2020-07-21 Thread David Miller
From: Shannon Nelson Date: Tue, 21 Jul 2020 13:34:03 -0700 > These are a few odd code tweaks to the ionic driver: FW defined MTU > limits, remove unnecessary code, and other tidiness tweaks. Series applied, thanks Shannon.

Re: [PATCH] net: ethernet: ave: Fix error returns in ave_init

2020-07-21 Thread David Miller
From: Wang Hai Date: Fri, 17 Jul 2020 10:50:49 +0800 > When regmap_update_bits failed in ave_init(), calls of the functions > reset_control_assert() and clk_disable_unprepare() were missed. > Add goto out_reset_assert to do this. > > Fixes: 57878f2f4697 ("net: ethernet: ave: add support for phy-

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

2020-07-21 Thread David Miller
From: Grygorii Strashko Date: Fri, 17 Jul 2020 15:19:32 +0300 > From: Murali Karicheri > > Currently drive supports taprio offload which is a tc feature offloaded > to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC > in the net device to be compliant. This patch adds the

Re: [PATCH net-next v3] bareudp: Reverted support to enable & disable rx metadata collection

2020-07-21 Thread David Miller
From: Martin Varghese Date: Fri, 17 Jul 2020 08:05:12 +0530 > From: Martin Varghese > > The commit fe80536acf83 ("bareudp: Added attribute to enable & disable > rx metadata collection") breaks the the original(5.7) default behavior of > bareudp module to collect RX metadadata at the receive. It

Re: [PATCH v2] drivers/net/wan/x25_asy: Fix to make it work

2020-07-21 Thread David Miller
From: Xie He Date: Thu, 16 Jul 2020 16:44:33 -0700 > This driver is not working because of problems of its receiving code. > This patch fixes it to make it work. > > When the driver receives an LAPB frame, it should first pass the frame > to the LAPB module to process. After processing, the LAPB

[PATCH net-next v1 1/7] udp_tunnel: add the ability to share port tables

2020-07-21 Thread Jakub Kicinski
Unfortunately recent Intel NIC designs share the UDP port table across netdevs. So far the UDP tunnel port state was maintained per netdev, we need to extend that to cater to Intel NICs. Expect NICs to allocate the info structure dynamically and link to the state from there. All the shared NICs wi

[PATCH net-next v1 2/7] netdevsim: add warnings on unexpected UDP tunnel port errors

2020-07-21 Thread Jakub Kicinski
We should never see a removal of a port which is not in the table or adding a port to an occupied entry in the table. To make sure such errors don't escape the checks in the test script add a warning/kernel spat. Error injection will not trigger those, nor should it ever put us in a bad state. Si

[PATCH net-next v1 6/7] ice: remove unused args from ice_get_open_tunnel_port()

2020-07-21 Thread Jakub Kicinski
ice_get_open_tunnel_port() is always passed TNL_ALL as the second parameter. Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 6 ++ drivers/net/ethernet/intel/ice/ice_fdir.c | 2 +- drivers/net/ethernet/intel/ice/ice_flex_pipe.c| 7 ++- dr

[PATCH net-next v1 3/7] netdevsim: shared UDP tunnel port table support

2020-07-21 Thread Jakub Kicinski
Add the ability to simulate a device with a shared UDP tunnel port table. Try to reject the configurations and actions which are not supported by the core, so we don't get syzcaller etc. warning reports. Signed-off-by: Jakub Kicinski --- drivers/net/netdevsim/netdevsim.h | 7 ++- drivers

[PATCH net-next v1 7/7] ice: convert to new udp_tunnel infrastructure

2020-07-21 Thread Jakub Kicinski
Convert ice to the new infra, use share port tables. Leave a tiny bit more error checking in place than usual, because this driver really does quite a bit of magic. We need to calculate the number of VxLAN and GENEVE entries the firmware has reserved. Thanks to the conversion the driver will no

[PATCH net-next v1 4/7] selftests: net: add a test for shared UDP tunnel info tables

2020-07-21 Thread Jakub Kicinski
Add a test run of checks validating the shared UDP tunnel port tables function as we expect. Signed-off-by: Jakub Kicinski --- .../drivers/net/netdevsim/udp_tunnel_nic.sh | 109 ++ 1 file changed, 109 insertions(+) diff --git a/tools/testing/selftests/drivers/net/netdevsim/udp

[PATCH net-next v1 0/7] udp_tunnel: convert Intel drivers with shared tables

2020-07-21 Thread Jakub Kicinski
This set converts Intel drivers which have the ability to spawn multiple netdevs, but have only one UDP tunnel port table. Appropriate support is added to the core infra in patch 1, followed by netdevsim support and a selftest. The table sharing works by core attaching the same table structure to

[PATCH net-next v1 5/7] i40e: convert to new udp_tunnel infrastructure

2020-07-21 Thread Jakub Kicinski
Make use of the "shared port table" to convert i40e to the new infra. i40e did not have any reference tracking, locking is also dodgy because rtnl gets released while talking to FW, so port may get removed from the table while it's getting added etc. On the good side i40e does not seem to be usin

Re: [PATCH bpf-next v2 3/6] bpf: support attaching freplace programs to multiple attach points

2020-07-21 Thread Alexei Starovoitov
On Mon, Jul 20, 2020 at 08:48:04PM -0700, Andrii Nakryiko wrote: > > Right, I wanted to avoid taking a refcnt on aux->linked_prog during > PROG_LOAD. The reason for that was (and still is) that I don't get who > and when has to bpf_prog_put() original aux->linked_prog to allow the > prog X to be f

Re: [PATCH bpf-next v4] bpftool: use only nftw for file tree parsing

2020-07-21 Thread Tony Ambardar
On Tue, 21 Jul 2020 at 14:50, Daniel Borkmann wrote: > > On 7/21/20 4:48 AM, Tony Ambardar wrote: > > The bpftool sources include code to walk file trees, but use multiple > > frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and > > is widely available, fts is not conformant a

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-21 Thread Stefano Stabellini
On Tue, 21 Jul 2020, Boris Ostrovsky wrote: > >> +static int xen_setup_pm_notifier(void) > >> +{ > >> + if (!xen_hvm_domain()) > >> + return -ENODEV; > >> > >> I forgot --- what did we decide about non-x86 (i.e. ARM)? > > It would be great to support that

Re: [PATCH 05/29] l2tp: cleanup difficult-to-read line breaks

2020-07-21 Thread David Miller
From: Jakub Kicinski Date: Tue, 21 Jul 2020 13:59:38 -0700 > Please split this submission into series of at most 15 patches at a > time, to make sure reviewers don't get overloaded. +1

Re: [PATCH net-next 0/3] dpaa2-eth: add support for TBF offload

2020-07-21 Thread David Miller
From: Ioana Ciornei Date: Tue, 21 Jul 2020 19:38:22 +0300 > This patch set adds support for TBF offload in dpaa2-eth. > The first patch restructures how the .ndo_setup_tc() callback is > implemented (each Qdisc is treated in a separate function), the second > patch just adds the necessary APIs fo

Re: [PATCH,v2] ipvs: fix the connection sync failed in some cases

2020-07-21 Thread Pablo Neira Ayuso
On Sun, Jul 19, 2020 at 09:08:39AM +0300, Julian Anastasov wrote: > > Hello, > > On Thu, 16 Jul 2020, guodeqing wrote: > > > The sync_thread_backup only checks sk_receive_queue is empty or not, > > there is a situation which cannot sync the connection entries when > > sk_receive_queue is e

Re: [PATCH v2 0/2] Interrupt handler support for NPA and NIX in Octeontx2.

2020-07-21 Thread David Miller
From: Jakub Kicinski Date: Tue, 21 Jul 2020 12:23:29 -0700 > On Tue, 21 Jul 2020 08:08:45 +0530 rakeshs@gmail.com wrote: >> From: Rakesh Babu >> >> Changes from v1. >> 1. Assigned void pointers to another type of pointers without type casting. >> 2. Removed Switch and If cases in interrupt

Re: [PATCH net-next] mptcp: move helper to where its used

2020-07-21 Thread David Miller
From: Florian Westphal Date: Tue, 21 Jul 2020 21:08:54 +0200 > Only used in token.c. > > Signed-off-by: Florian Westphal Applied, thanks.

Re: [PATCH] ipvs: add missing struct name in ip_vs_enqueue_expire_nodest_conns when CONFIG_SYSCTL is disabled

2020-07-21 Thread Pablo Neira Ayuso
On Fri, Jul 17, 2020 at 08:36:36PM +0300, Julian Anastasov wrote: > > Hello, > > On Fri, 17 Jul 2020, Andrew Sy Kim wrote: > > > Adds missing "*ipvs" to ip_vs_enqueue_expire_nodest_conns when > > CONFIG_SYSCTL is disabled > > > > Signed-off-by: Andrew Sy Kim > > Acked-by: Julian Anastas

Re: [PATCH net-next 00/29] l2tp: cleanup checkpatch.pl warnings

2020-07-21 Thread David Miller
This patch set is way too large to be reasonably reviewed by other developers. Please either find a way to combine some of the patches, or submit this in stages of about 10 or so patches at a time. I am not applying this submission as submitted. Thank you.

Re: [PATCH net 0/3] Fix bugs in Octeontx2 netdev driver

2020-07-21 Thread David Miller
From: sundeep.l...@gmail.com Date: Tue, 21 Jul 2020 22:44:05 +0530 > Subbaraya Sundeep (3): > octeontx2-pf: Fix reset_task bugs > octeontx2-pf: cancel reset_task work > octeontx2-pf: Unregister netdev at driver remove I think you should shut down all the interrupts and other state before un

Re: [PATCH net-next 0/4] devlink small improvements

2020-07-21 Thread David Miller
From: Parav Pandit Date: Tue, 21 Jul 2020 19:53:50 +0300 > This short series improves the devlink code for lock commment, > simplifying checks and keeping the scope of mutex lock for necessary > fields. > > Patch summary: > Patch-1 Keep the devlink_mutex for only for necessary changes. > Patch-2

Re: [PATCH net-next] r8169: allow to enable ASPM on RTL8125A

2020-07-21 Thread David Miller
From: Heiner Kallweit Date: Tue, 21 Jul 2020 18:22:24 +0200 > For most chip versions this has been added already. Allow also for > RTL8125A to enable ASPM. > > Signed-off-by: Heiner Kallweit Applied.

Re: [PATCH v2] selftest: txtimestamp: fix net ns entry logic

2020-07-21 Thread David Miller
From: Paolo Pisati Date: Tue, 21 Jul 2020 18:17:10 +0200 > According to 'man 8 ip-netns', if `ip netns identify` returns an empty string, > there's no net namespace associated with current PID: fix the net ns entrance > logic. > > Signed-off-by: Paolo Pisati Applied, thanks.

Re: [PATCH net v2] netdevsim: fix unbalaced locking in nsim_create()

2020-07-21 Thread David Miller
From: Taehee Yoo Date: Tue, 21 Jul 2020 14:51:50 + > In the nsim_create(), rtnl_lock() is called before nsim_bpf_init(). > If nsim_bpf_init() is failed, rtnl_unlock() should be called, > but it isn't called. > So, unbalanced locking would occur. > > Fixes: e05b2d141fef ("netdevsim: move netd

Re: [PATCH net 0/2] qed: suppress irrelevant error messages on HW init

2020-07-21 Thread David Miller
From: Alexander Lobakin Date: Tue, 21 Jul 2020 17:41:41 +0300 > This raises the verbosity level of several error/warning messages on > driver/module initialization, most of which are false-positives, and > the one actively spamming the log for no reason. Series applied.

Re: [PATCH net-next 0/4] cxgb4: add ethtool self_test support

2020-07-21 Thread David Miller
From: Vishal Kulkarni Date: Tue, 21 Jul 2020 19:08:35 +0530 > Our requirement is to get overall adapter health from single tool and command. > Using devlink and ip will require multiple tools and commands. This is an invalid argument. We have multiple facilities, each of which handles a specifi

Re: [PATCH net-next 0/4] cxgb4: add ethtool self_test support

2020-07-21 Thread David Miller
From: Andrew Lunn Date: Tue, 21 Jul 2020 15:41:45 +0200 >> Hi Andrew, >> >> Our requirement is to get overall adapter health from single tool and >> command. >> Using devlink and ip will require multiple tools and commands. > > That is not a good reason to abuse the Kernel norms and do odd thi

Re: [PATCH V3 net-next 0/8] ENA driver new features

2020-07-21 Thread David Miller
From: Date: Tue, 21 Jul 2020 16:38:03 +0300 > This patchset contains performance improvements, support for new devices > and functionality: > > 1. Support for upcoming ENA devices > 2. Avoid unnecessary IRQ unmasking in busy poll to reduce interrupt rate > 3. Enabling device support for RSS func

Re: [PATCH] ipvlan: add the check of ip header checksum

2020-07-21 Thread David Miller
From: guodeqing Date: Tue, 21 Jul 2020 21:09:22 +0800 > The ip header checksum can be error in the following steps. ... > $ ip netns exec ns1 tc qdisc add dev ip1 root netem corrupt 50% This is not valid. The kernel internally already validated the ipv4 header checksum before forwarding or sen

Re: [PATCH net-next] qed: Fix ILT and XRCD bitmap memory leaks

2020-07-21 Thread David Miller
From: Yuval Basson Date: Tue, 21 Jul 2020 14:34:26 +0300 > - Free ILT lines used for XRC-SRQ's contexts. > - Free XRCD bitmap > > Fixes: b8204ad878ce7 ("qed: changes to ILT to support XRC") > Fixes: 7bfb399eca460 ("qed: Add XRC to RoCE") > Signed-off-by: Michal Kalderon > Signed-off-by: Yuval B

Re: [PATCH v3 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

2020-07-21 Thread Song Liu
> On Jul 21, 2020, at 3:43 PM, Alexei Starovoitov > wrote: > > On Tue, Jul 21, 2020 at 3:40 PM Song Liu wrote: >> >> We only need to block precise_ip >= 2. precise_ip == 1 is OK. > > Are you sure? > intel_pmu_hw_config() has: > if (event->attr.precise_ip) { >if (event->attr.sample_type

Re: [PATCH v4] net: dsa: microchip: call phy_remove_link_mode during probe

2020-07-21 Thread David Miller
From: Helmut Grohne Date: Tue, 21 Jul 2020 13:07:39 +0200 > When doing "ip link set dev ... up" for a ksz9477 backed link, > ksz9477_phy_setup is called and it calls phy_remove_link_mode to remove > 1000baseT HDX. During phy_remove_link_mode, phy_advertise_supported is > called. Doing so reverts

Re: [PATCH net-next] qed: Fix ILT and XRCD bitmap memory leaks

2020-07-21 Thread David Miller
From: Yuval Basson Date: Tue, 21 Jul 2020 14:34:26 +0300 > - Free ILT lines used for XRC-SRQ's contexts. > - Free XRCD bitmap > > Fixes: b8204ad878ce7 ("qed: changes to ILT to support XRC") > Fixes: 7bfb399eca460 ("qed: Add XRC to RoCE") > Signed-off-by: Michal Kalderon > Signed-off-by: Yuval B

Re: [PATCH net 0/4] net: hns3: fixes for -net

2020-07-21 Thread David Miller
From: Huazhong Tan Date: Tue, 21 Jul 2020 19:03:50 +0800 > There are some bugfixes for the HNS3 ethernet driver. Series applied, thank you.

Re: [PATCH net-next 00/14] Phylink PCS updates

2020-07-21 Thread David Miller
From: Russell King - ARM Linux admin Date: Tue, 21 Jul 2020 12:01:52 +0100 > This series updates the rudimentary phylink PCS support with the > results of the last four months of development of that. Phylink > PCS support was initially added back at the end of March, when it > became clear that

Re: [PATCH v3 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

2020-07-21 Thread Alexei Starovoitov
On Tue, Jul 21, 2020 at 3:40 PM Song Liu wrote: > > We only need to block precise_ip >= 2. precise_ip == 1 is OK. Are you sure? intel_pmu_hw_config() has: if (event->attr.precise_ip) { if (event->attr.sample_type & PERF_SAMPLE_CALLCHAIN) event->attr.sample_type |= __PERF_SAMPLE_CA

general protection fault in vsock_poll

2020-07-21 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6a70f89c Merge tag 'nfs-for-5.8-3' of git://git.linux-nfs... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=172ed85f10 kernel config: https://syzkaller.appspot.com/x/.config?x=a160d1053fc89af5 das

Re: [PATCH] net: udp: Fix wrong clean up for IS_UDPLITE macro

2020-07-21 Thread David Miller
From: linmiaohe Date: Tue, 21 Jul 2020 17:11:44 +0800 > From: Miaohe Lin > > We can't use IS_UDPLITE to replace udp_sk->pcflag when UDPLITE_RECV_CC is > checked. > > Fixes: b2bf1e2659b1 ("[UDP]: Clean up for IS_UDPLITE macro") > Signed-off-by: Miaohe Lin Applied and queued up for -stable, th

Re: [PATCH v3 bpf-next 1/2] bpf: separate bpf_get_[stack|stackid] for perf events BPF

2020-07-21 Thread Song Liu
> On Jul 21, 2020, at 12:10 PM, Alexei Starovoitov > wrote: > > On Thu, Jul 16, 2020 at 03:59:32PM -0700, Song Liu wrote: >> + >> +BPF_CALL_3(bpf_get_stackid_pe, struct bpf_perf_event_data_kern *, ctx, >> + struct bpf_map *, map, u64, flags) >> +{ >> +struct perf_event *event = ctx-

Re: [PATCH net-next v3 0/6] Add adaptive interrupt coalescing

2020-07-21 Thread David Miller
From: Claudiu Manoil Date: Tue, 21 Jul 2020 10:55:16 +0300 > Apart from some related cleanup patches, this set > introduces in a straightforward way the support needed > to enable and configure interrupt coalescing for ENETC. > > Patch 5 introduces the support needed for configuring the > interr

Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-21 Thread David Miller
From: Xiongfeng Wang Date: Tue, 21 Jul 2020 15:02:57 +0800 > When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to > add a newline for easy reading. > > root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout > 0root@syzkaller:~# > > Signed-off-by: Xiongfeng

Re: [PATCH net-next] net: mdio-mux-gpio: use devm_gpiod_get_array()

2020-07-21 Thread David Miller
From: Jisheng Zhang Date: Tue, 21 Jul 2020 15:01:57 +0800 > Use devm_gpiod_get_array() to simplify the error handling and exit > code path. > > Signed-off-by: Jisheng Zhang Applied.

Re: [PATCH v3] net: ethernet: ravb: exit if re-initialization fails in tx timeout

2020-07-21 Thread David Miller
From: Yoshihiro Shimoda Date: Tue, 21 Jul 2020 15:23:12 +0900 > According to the report of [1], this driver is possible to cause > the following error in ravb_tx_timeout_work(). > > ravb e680.ethernet ethernet: failed to switch device to config mode > > This error means that the hardware co

Re: [PATCH net 0/2] udp: Fix reuseport selection with connected sockets.

2020-07-21 Thread David Miller
From: Kuniyuki Iwashima Date: Tue, 21 Jul 2020 15:15:29 +0900 > From: kuniyu Please fix your configuration to show your full name in this "From: " field, I had to edit it out and use the one from your email headers. > This patch set addresses two issues which happen when both connected and > u

RE: [PATCH v3] net: hyperv: add support for vlans in netvsc driver

2020-07-21 Thread Haiyang Zhang
> -Original Message- > From: Sriram Krishnan (srirakr2) > Sent: Tuesday, July 21, 2020 3:10 AM > To: David Miller > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org; Malcolm Bumgardner (mbumgard) > ; Umesha G M (ugm) ; Niranjan M > M (nimm) ; xe-linux-exter

Re: [PATCH ghak90 V9 10/13] audit: add support for containerid to network namespaces

2020-07-21 Thread Richard Guy Briggs
On 2020-07-05 11:11, Paul Moore wrote: > On Sat, Jun 27, 2020 at 9:23 AM Richard Guy Briggs wrote: > > > > This also adds support to qualify NETFILTER_PKT records. > > > > Audit events could happen in a network namespace outside of a task > > context due to packets received from the net that trigg

Re: [RFC 2/7] ath10k: Add support to process rx packet in thread

2020-07-21 Thread Rajkumar Manoharan
On 2020-07-21 10:14, Rakesh Pillai wrote: NAPI instance gets scheduled on a CPU core on which the IRQ was triggered. The processing of rx packets can be CPU intensive and since NAPI cannot be moved to a different CPU core, to get better performance, its better to move the gist of rx packet proces

RE: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table

2020-07-21 Thread Haiyang Zhang
> -Original Message- > From: Chi Song > Sent: Tuesday, July 21, 2020 12:59 AM > To: Stephen Hemminger ; David Miller > ; Haiyang Zhang ; KY > Srinivasan ; Stephen Hemminger > ; wei@kernel.org; k...@kernel.org; linux- > hyp...@vger.kernel.org > Cc: netdev@vger.kernel.org; linux-ker..

Re: [PATCH bpf-next v4] bpftool: use only nftw for file tree parsing

2020-07-21 Thread Daniel Borkmann
On 7/21/20 4:48 AM, Tony Ambardar wrote: The bpftool sources include code to walk file trees, but use multiple frameworks to do so: nftw and fts. While nftw conforms to POSIX/SUSv3 and is widely available, fts is not conformant and less common, especially on non-glibc systems. The inconsistent fr

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-21 Thread Boris Ostrovsky
>> +static int xen_setup_pm_notifier(void) >> +{ >> + if (!xen_hvm_domain()) >> + return -ENODEV; >> >> I forgot --- what did we decide about non-x86 (i.e. ARM)? > It would be great to support that however, its out of > scope for this patch set. >>

[PATCH net-next v2 6/7] ARM: dts: at91: sama5d4: add an mdio sub-node to macb

2020-07-21 Thread Codrin Ciubotariu
Use the new macb bindings and add an mdio sub-node to contain all the phy nodes. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none arch/arm/boot/dts/at91-sama5d4_xplained.dts | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/at91-sama5

[PATCH net-next v2 7/7] ARM: dts: at91: sam9x60: add an mdio sub-node to macb

2020-07-21 Thread Codrin Ciubotariu
Use the new macb bindings and add an mdio sub-node to contain all the phy nodes. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none arch/arm/boot/dts/at91-sam9x60ek.dts | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/

[PATCH net-next v2 5/7] ARM: dts: at91: sama5d3: add an mdio sub-node to macb

2020-07-21 Thread Codrin Ciubotariu
Use the new macb bindings and add an mdio sub-node to contain all the phy nodes. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none; arch/arm/boot/dts/at91-sama5d3_xplained.dts | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/at91

[PATCH net-next v2 4/7] ARM: dts: at91: sama5d2: add an mdio sub-node to macb

2020-07-21 Thread Codrin Ciubotariu
Use the new macb bindings and add an mdio sub-node to contain all the phy nodes. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 16 ++-- arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 17 ++--- arch/arm/boot/dts/

[PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node

2020-07-21 Thread Codrin Ciubotariu
The MACB embeds an MDIO bus controller. For this reason, the PHY nodes were represented as sub-nodes in the MACB node. Generally, the Ethernet controller is different than the MDIO controller, so the PHYs are probed by a separate MDIO driver. Since adding the PHY nodes directly under the ETH node b

[PATCH net-next v2 2/7] dt-bindings: net: macb: use an MDIO node as a container for PHY nodes

2020-07-21 Thread Codrin Ciubotariu
The MACB driver embeds an MDIO bus controller and for this reason there was no need for an MDIO sub-node present to contain the PHY nodes. Adding MDIO devies directly under an Ethernet node is deprecated, so an MDIO node is included to contain of the PHY nodes (and other MDIO devices' nodes). Sign

[PATCH net-next v2 1/7] net: macb: use device-managed devm_mdiobus_alloc()

2020-07-21 Thread Codrin Ciubotariu
Use the device-managed variant for the allocating the MDIO bus. This cleans-up the code a little on the remove and error paths. Signed-off-by: Codrin Ciubotariu --- Changes in v2: - none drivers/net/ethernet/cadence/macb_main.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) di

[PATCH net-next v2 0/7] Add an MDIO sub-node under MACB

2020-07-21 Thread Codrin Ciubotariu
Adding the PHY nodes directly under the Ethernet node became deprecated, so the aim of this patch series is to make MACB use an MDIO node as container for MDIO devices. This patch series starts with a small patch to use the device-managed devm_mdiobus_alloc(). In the next two patches we update the

Re: [PATCH 05/29] l2tp: cleanup difficult-to-read line breaks

2020-07-21 Thread Jakub Kicinski
On Tue, 21 Jul 2020 18:31:57 +0100 Tom Parkin wrote: > #if IS_ENABLED(CONFIG_IPV6) > - if (info->attrs[L2TP_ATTR_IP6_SADDR] && > - info->attrs[L2TP_ATTR_IP6_DADDR]) { > - cfg.local_ip6 = nla_data( > - info->attrs[L2TP_ATTR

Re: [PATCH RFC leds + net-next 1/3] leds: trigger: add support for LED-private device triggers

2020-07-21 Thread Pavel Machek
Hi! > >This adds support for registering such triggers. > > > >This code is based on work by Pavel Machek and > >Ondřej Jirman . > > > >Signed-off-by: Marek Behún > Acked-by: Jacek Anaszewski Thanks, applied. Pavel -- (english) http://

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-21 Thread Russell King - ARM Linux admin
On Tue, Jul 21, 2020 at 06:16:24PM +0100, Jonathan McDowell wrote: > This adds full 802.1q VLAN support to the qca8k, allowing the use of > vlan_filtering and more complicated bridging setups than allowed by > basic port VLAN support. > > Tested with a number of untagged ports with separate VLANs

[PATCH] ipvs: add prameter name to ip_vs_enqueue_expire_nodest_conns

2020-07-21 Thread trix
From: Tom Rix Compile error here In file included from net/netfilter/ipvs/ip_vs_conn.c:37: ip_vs.h: In function ‘ip_vs_enqueue_expire_nodest_conns’: ip_vs.h:1536:54: error: parameter name omitted So add parameter name Fixes: 04231e52d355 ("ipvs: queue delayed work to expire no destination con

Re: [PATCH bpf v3] xsk: do not discard packet when QUEUE_STATE_FROZEN

2020-07-21 Thread Daniel Borkmann
On 7/20/20 3:53 PM, Magnus Karlsson wrote: In the skb Tx path, transmission of a packet is performed with dev_direct_xmit(). When QUEUE_STATE_FROZEN is set in the transmit routines, it returns NETDEV_TX_BUSY signifying that it was not possible to send the packet now, please try later. Unfortunate

[RFC v2 mptcp-next 05/12] mptcp: rename and export mptcp_subflow_request_sock_ops

2020-07-21 Thread Florian Westphal
syncookie code path needs to create an mptcp request sock. Prepare for this and add mptcp prefix plus needed export of ops struct. Signed-off-by: Florian Westphal --- include/net/mptcp.h | 1 + net/mptcp/subflow.c | 11 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a

[RFC v2 mptcp-next 11/12] mptcp: enable JOIN requests even if cookies are in use

2020-07-21 Thread Florian Westphal
JOIN requests do not work in syncookie mode -- for HMAC validation, the peers nonce is required, but this nonce is only present in the SYN. So either we need to drop or reject all JOIN requests once a listening socket enters syncookie mode, or we need to store enough state to validate the ACKs HMA

[RFC v2 mptcp-next 09/12] tcp: syncookies: create mptcp request socket for ACK cookies with MPTCP option

2020-07-21 Thread Florian Westphal
If SYN packet contains MP_CAPABLE option, keep it enabled. Syncokie validation and cookie-based socket creation is changed to instantiate an mptcp request sockets if the ACK contains an MPTCP connection request. Signed-off-by: Florian Westphal --- net/ipv4/syncookies.c | 21 +

[RFC v2 mptcp-next 12/12] selftests: mptcp: make 2nd net namespace use tcp syn cookies unconditionally

2020-07-21 Thread Florian Westphal
check we can establish connections even in syncookie mode. Also check following MIB counters: MPTcpExtMPCapableSYNRX (should increase for each MPTCP test) MPTcpExtMPCapableACKRX (should increase for each MPTCP test) TcpExtSyncookiesSent (should increase for listener in ns2) TcpExtSyncookiesRecv (sa

[RFC v2 mptcp-next 03/12] mptcp: token: move retry to caller

2020-07-21 Thread Florian Westphal
Once syncookie support is added, no state will be stored anymore when the syn/ack is generated in syncookie mode. When the ACK comes back, the generated key will be taken from the TCP ACK, the token is re-generated and inserted into the token tree. This means we can't retry with a new key when th

  1   2   3   4   >