Re: linux-next: build failure after merge of the net-next tree

2020-08-28 Thread Sven Joachim
On 2020-08-28 16:42 -0700, Randy Dunlap wrote: > On 8/28/20 4:16 PM, Brian Vazquez wrote: >> On Fri, Aug 28, 2020 at 8:12 AM Randy Dunlap wrote: >>> >>> On 8/28/20 8:09 AM, Sven Joachim wrote: On 2020-08-27 11:12 -0700, Brian Vazquez wrote: > I've been trying to reproduce it with yo

Re: INFO: task hung in tls_sk_proto_close

2020-08-28 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:b36c9697 Add linux-next specific files for 20200828 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=11ae3d6190 kernel config: https://syzkaller.appspot.com/x/.config?x

RE: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-08-28 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Friday, August 28, 2020 10:14 PM > > On Fri, 28 Aug 2020 04:27:19 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Friday, August 28, 2020 3:12 AM > > > > > > On Thu, 27 Aug 2020 20:15:01 + Parav Pandit wrote: > > > > > From: Jakub Kicinski

[PATCH iproute2 net-next v2] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
From: Roopa Prabhu This patch adds support for recently added link IFLA_PROTO_DOWN_REASON attribute. IFLA_PROTO_DOWN_REASON enumerates reasons for the already existing IFLA_PROTO_DOWN link attribute. $ cat /etc/iproute2/protodown_reasons.d/r.conf 0 mlag 1 evpn 2 vrrp 3 psecurity $ ip link set d

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/23/20 7:20 PM, David Ahern wrote: External email: Use caution opening links or attachments On 8/20/20 9:52 PM, Roopa Prabhu wrote: +void protodown_reason_n2a(int id, char *buf, int len) +{ + if (id < 0 || id >= PROTODOWN_REASON_NUM_BITS || numeric) { since the reason is limited to

Re: [PATCH iproute2 net-next] iplink: add support for protodown reason

2020-08-28 Thread Roopa Prabhu
On 8/21/20 6:30 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Fri, 21 Aug 2020 14:09:14 -0700 Roopa Prabhu wrote: On 8/20/20 10:18 PM, Roopa Prabhu wrote: On 8/20/20 9:36 PM, Stephen Hemminger wrote: On Thu, 20 Aug 2020 20:52:02 -0700 Roopa Pra

Re: drivers/of/of_mdio.c needs a small modification

2020-08-28 Thread Florian Fainelli
On 8/28/2020 4:14 PM, Adam Rudziński wrote: W dniu 2020-08-29 o 00:53, Andrew Lunn pisze: On Sat, Aug 29, 2020 at 12:34:05AM +0200, Adam Rudziński wrote: Hi Andrew. W dniu 2020-08-29 o 00:28, Andrew Lunn pisze: Hi Adam If kernel has to bring up two Ethernet interfaces, the processor has

[net-next:master 43/71] WARNING: modpost: vmlinux.o(__ex_table+0x1150): Section mismatch in reference from the (unknown reference) (unknown) to the variable .rodata.str1.4:.LC2

2020-08-28 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master head: 0f091e43310f5c292b7094f9f115e651358e8053 commit: 4718a471f1a7fc5cc943377c09300bb35138daf9 [43/71] netlink: remove duplicated nla_need_padding_for_64bit() check config: riscv-randconfig-r006-20200828

START UP FUNDS.

2020-08-28 Thread Angel Investors
Attention To Email : netdev@vger.kernel.org Good Day Sir, Our Group have the financial capability to finance any investment portfolio as far as is genuine, all we need is a capable business partner that possesses investment strategies for profitable business information for good turn over within

Re: [PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub

2020-08-28 Thread Marcelo Ricardo Leitner
On Fri, Aug 28, 2020 at 11:14:30PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add ip6_fragment in ipv6_stub and use it in openvswitch > This version add default function eafnosupport_ipv6_fragment Reviewed-by: Marcelo Ricardo Leitner

[PATCH net-next v3 3/3] hinic: add support to query function table

2020-08-28 Thread Luo bin
add debugfs node for querying function table, for example: cat /sys/kernel/debug/hinic/:15:00.0/func_table/valid Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch V1~V2: - remove vlan_id and vlan_mode fr

[PATCH net-next v3 2/3] hinic: add support to query rq info

2020-08-28 Thread Luo bin
add debugfs node for querying rq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/RQs/0x0/rq_hw_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch .../net/ethernet/huawei/hinic/hinic_debugfs.c

[PATCH net-next v3 0/3] hinic: add debugfs support

2020-08-28 Thread Luo bin
add debugfs node for querying sq/rq info and function table Luo bin (3): hinic: add support to query sq info hinic: add support to query rq info hinic: add support to query function table drivers/net/ethernet/huawei/hinic/Makefile| 3 +- .../net/ethernet/huawei/hinic/hinic_debugfs.c

[PATCH net-next v3 1/3] hinic: add support to query sq info

2020-08-28 Thread Luo bin
add debugfs node for querying sq info, for example: cat /sys/kernel/debug/hinic/:15:00.0/SQs/0x0/sq_pi Signed-off-by: Luo bin --- V0~V1: - remove command interfaces to the read only files - split addition of each object into a separate patch drivers/net/ethernet/huawei/hinic/Makefile|

Re: [PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-28 Thread luobin (L)
On 2020/8/29 1:19, Jakub Kicinski wrote: > On Fri, 28 Aug 2020 11:16:22 +0800 luobin (L) wrote: >> On 2020/8/28 3:44, Jakub Kicinski wrote: >>> On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote: + switch (idx) { + case VALID: + return funcfg_table_elem->dw0.bs.valid;

rtnl_lock deadlock with tg3 driver

2020-08-28 Thread Baptiste Covolato
Hi David, Michael, I am contacting you because I'm experiencing an issue that seems to be awfully close to what David attempted to fix related to the tg3 driver infinite sleep while holding rtnl_lock (https://lkml.org/lkml/2020/6/15/1122). I have a system with a bunch of "Broadcom Limited NetXtre

Re: linux-next: build failure after merge of the net-next tree

2020-08-28 Thread Randy Dunlap
On 8/28/20 4:16 PM, Brian Vazquez wrote: > On Fri, Aug 28, 2020 at 8:12 AM Randy Dunlap wrote: >> >> On 8/28/20 8:09 AM, Sven Joachim wrote: >>> On 2020-08-27 11:12 -0700, Brian Vazquez wrote: >>> I've been trying to reproduce it with your config but I didn't succeed. I also looked at th

proposed modification of drivers/of/of_mdio.c and include/linux/of_mdio.h

2020-08-28 Thread Adam Rudziński
Hi, I have found that a device with two Ethernet interfaces may have a problem with bringing up both interfaces on fresh boot (after power-on). According to my investigation, the problem is caused by probing PHYs on shared MDIO bus while one PHY still has no clock provided. The possible work

Re: drivers/of/of_mdio.c needs a small modification

2020-08-28 Thread Adam Rudziński
W dniu 2020-08-29 o 00:53, Andrew Lunn pisze: On Sat, Aug 29, 2020 at 12:34:05AM +0200, Adam Rudziński wrote: Hi Andrew. W dniu 2020-08-29 o 00:28, Andrew Lunn pisze: Hi Adam If kernel has to bring up two Ethernet interfaces, the processor has two peripherals with functionality of MACs (in i

Re: [PATCH v3] net: Use standardized (IANA) local port range

2020-08-28 Thread David Miller
From: Stephen Hemminger Date: Fri, 28 Aug 2020 14:52:03 -0700 > Changing the default range impacts existing users. Since Linux has been doing > this for so long, I don't think just because a standards body decided to > reserve > some space is sufficient justification to do this. Agreed, there i

Re: pull-request: bpf 2020-08-28

2020-08-28 Thread David Miller
From: Daniel Borkmann Date: Fri, 28 Aug 2020 23:14:52 +0200 > The following pull-request contains BPF updates for your *net* tree. > > We've added 4 non-merge commits during the last 4 day(s) which contain > a total of 4 files changed, 7 insertions(+), 4 deletions(-). > > The main changes are:

Re: drivers/of/of_mdio.c needs a small modification

2020-08-28 Thread Andrew Lunn
On Sat, Aug 29, 2020 at 12:34:05AM +0200, Adam Rudziński wrote: > Hi Andrew. > > W dniu 2020-08-29 o 00:28, Andrew Lunn pisze: > > Hi Adam > > > > > If kernel has to bring up two Ethernet interfaces, the processor has two > > > peripherals with functionality of MACs (in i.MX6ULL these are Fast >

Re: drivers/of/of_mdio.c needs a small modification

2020-08-28 Thread Adam Rudziński
Hi Andrew. W dniu 2020-08-29 o 00:28, Andrew Lunn pisze: Hi Adam If kernel has to bring up two Ethernet interfaces, the processor has two peripherals with functionality of MACs (in i.MX6ULL these are Fast Ethernet Controllers, FECs), but uses a shared MDIO bus, then the kernel first probes one

Re: drivers/of/of_mdio.c needs a small modification

2020-08-28 Thread Andrew Lunn
Hi Adam > If kernel has to bring up two Ethernet interfaces, the processor has two > peripherals with functionality of MACs (in i.MX6ULL these are Fast Ethernet > Controllers, FECs), but uses a shared MDIO bus, then the kernel first probes > one MAC, enables clock for its PHY, probes MDIO bus tryn

tc filter add with handle 800::10:800

2020-08-28 Thread Denis Gubin
Hello, everyone! How can I add filter rule with full handle option tc filter replace dev eno5 parent : pref 49100 handle 800:10:800 protocol ip u32 match u8 0 0 I get error: Error: cls_u32: Handle specified hash table address mismatch Why I get error? Am I right to article below? handle 8

Re: [PATCHv9 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-08-28 Thread Daniel Borkmann
On 8/26/20 3:19 PM, Hangbin Liu wrote: [...] +BPF_CALL_3(bpf_xdp_redirect_map_multi, struct bpf_map *, map, + struct bpf_map *, ex_map, u64, flags) +{ + struct bpf_redirect_info *ri = this_cpu_ptr(&bpf_redirect_info); + + /* Limit ex_map type to DEVMAP_HASH to get better perf

Re: [PATCHv9 bpf-next 1/5] bpf: add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL

2020-08-28 Thread Daniel Borkmann
On 8/26/20 3:19 PM, Hangbin Liu wrote: Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be used when we want to allow NULL pointer for map parameter. The bpf helper need to take care and check if the map is NULL when use this type. Signed-off-by: Hangbin Liu --- v9: merge the

Re: [PATCH v3] net: Use standardized (IANA) local port range

2020-08-28 Thread Stephen Hemminger
On Fri, 28 Aug 2020 22:44:47 +0200 Bart Groeneveld wrote: > IANA specifies User ports as 1024-49151, > and Private ports (local/ephemeral/dynamic/w/e) as 49152-65535 [1]. > > This means Linux uses 32768-49151 'illegally'. > This is not just a matter of following specifications: > IANA actually a

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Ondrej Zary
On Friday 28 August 2020 10:59:37 Kalle Valo wrote: > Ondrej Zary writes: > > > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: > >> Ondrej Zary writes: > >> > >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: > >> >> On Mon, 17 Aug 2020 16:27:01 +0300 > >> >> Kalle Valo wro

pull-request: bpf 2020-08-28

2020-08-28 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net* tree. We've added 4 non-merge commits during the last 4 day(s) which contain a total of 4 files changed, 7 insertions(+), 4 deletions(-). The main changes are: 1) Fix out of bounds access for BPF_OBJ_GET_INFO_BY_FD retriev

Re: [PATCH bpf-next v3 4/8] libbpf: implement bpf_prog_find_metadata

2020-08-28 Thread Toke Høiland-Jørgensen
Stanislav Fomichev writes: > This is a low-level function (hence in bpf.c) to find out the metadata > map id for the provided program fd. > It will be used in the next commits from bpftool. > > Cc: Toke Høiland-Jørgensen > Cc: YiFei Zhu > Signed-off-by: Stanislav Fomichev > --- > tools/lib/bp

Re: [PATCH net] drivers/net/wan/hdlc_cisco: Add hard_header_len

2020-08-28 Thread Xie He
On Fri, Aug 28, 2020 at 3:37 AM Krzysztof Hałasa wrote: > > OTOH hdlc_setup_dev() initializes hard_header_len to 16, > but in this case I guess 4 bytes are better. > > Acked-by: Krzysztof Halasa Thank you, Krzysztof! Actually I'm thinking about changing the default value of 16 in hdlc.c to 0.

[PATCH v2] net: Use standardized (IANA) local port range

2020-08-28 Thread Bart Groeneveld
IANA specifies User ports as 1024-49151, and Private ports (local/ephemeral/dynamic/w/e) as 49152-65535 [1]. This means Linux uses 32768-49151 'illegally'. This is not just a matter of following specifications: IANA actually assigns numbers in this range [1]. I understand that Linux uses 61000-65

Re: packet deadline and process scheduling

2020-08-28 Thread Stephen Hemminger
On Fri, 28 Aug 2020 16:01:31 +0200 Willem de Bruijn wrote: > On Fri, Aug 28, 2020 at 10:51 AM S.V.R.Anand wrote: > > > > There is an active Internet draft "Packet Delivery Deadline time in > > 6LoWPAN Routing Header" > > (https://datatracker.ietf.org/doc/draft-ietf-6lo-deadline-time/) which > >

[PATCH v3] net: Use standardized (IANA) local port range

2020-08-28 Thread Bart Groeneveld
IANA specifies User ports as 1024-49151, and Private ports (local/ephemeral/dynamic/w/e) as 49152-65535 [1]. This means Linux uses 32768-49151 'illegally'. This is not just a matter of following specifications: IANA actually assigns numbers in this range [1]. I understand that Linux uses 61000-65

[PATCH net-next] net: ethernet: ti: am65-cpts: fix i2083 genf (and estf) Reconfiguration Issue

2020-08-28 Thread Grygorii Strashko
The new bit TX_GENF_CLR_EN has been added in AM65x SR2.0 to fix i2083 errata, which can be just set unconditionally for all SoCs. Signed-off-by: Grygorii Strashko --- drivers/net/ethernet/ti/am65-cpts.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet

Re: [PATCH v2 08/30] net: wireless: ath: carl9170: Convert 'ar9170_qmap' to inline function

2020-08-28 Thread Christian Lamparter
On Thursday, 27 August 2020 11:33:51 CEST Lee Jones wrote: > 'ar9170_qmap' is used in some source files which include carl9170.h, > but not all of them. A 'defined but not used' warning is thrown when > compiling the ones which do not use it. > > Fixes the following W=1 kernel build warning(s) >

Re: [PATCH v3 bpf-next 1/5] mm/error_inject: Fix allow_error_inject function signatures.

2020-08-28 Thread Daniel Borkmann
On 8/28/20 12:01 AM, Alexei Starovoitov wrote: From: Alexei Starovoitov 'static' and 'static noinline' function attributes make no guarantees that gcc/clang won't optimize them. The compiler may decide to inline 'static' function and in such case ALLOW_ERROR_INJECT becomes meaningless. The comp

Re: [PATCH v3 bpf-next 0/5] bpf: Introduce minimal support for sleepable progs

2020-08-28 Thread Daniel Borkmann
On 8/28/20 12:01 AM, Alexei Starovoitov wrote: From: Alexei Starovoitov v2->v3: - switched to minimal allowlist approach. Essentially that means that syscall entry, few btrfs allow_error_inject functions, should_fail_bio(), and two LSM hooks: file_mprotect and bprm_committed_creds are the

Re: [PATCHi v2] net: mdiobus: fix device unregistering in mdiobus_register

2020-08-28 Thread Heiner Kallweit
On 28.08.2020 16:15, Sascha Hauer wrote: > On Thu, Aug 27, 2020 at 10:48:48AM +0200, Heiner Kallweit wrote: >> On 27.08.2020 09:06, Sascha Hauer wrote: >>> After device_register has been called the device structure may not be >>> freed anymore, put_device() has to be called instead. This gets viola

RE: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-08-28 Thread John Fastabend
Lukas Wunner wrote: > Commit e687ad60af09 ("netfilter: add netfilter ingress hook after > handle_ing() under unique static key") introduced the ability to > classify packets on ingress. > > Support the same on egress. This allows filtering locally generated > traffic such as DHCP, or outbound AF_

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-08-28 Thread Anchal Agarwal
On Fri, Aug 28, 2020 at 08:29:24PM +0200, Rafael J. Wysocki wrote: > CAUTION: This email originated from outside of the organization. Do not click > links or open attachments unless you can confirm the sender and know the > content is safe. > > > > On Fri, Aug 28, 2020 at 8:26 PM Anchal Agarwa

Re: [PATCH net-next] net/sched: add act_ct_output support

2020-08-28 Thread Cong Wang
On Tue, Aug 25, 2020 at 1:45 AM wrote: > > From: wenxu > > The fragment packets do defrag in act_ct module. If the reassembled > packet should send out to another net device. This over mtu big packet > should be fragmented to send out. This patch add the act ct_output to > archive this. There ar

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

2020-08-28 Thread Tong Zhang
I think the original code complaining parsing error is there for a reason, A better way is to modify ct_sip_parse_numerical_param() and let it return a real parsing error code instead of returning FOUND(1) and NOT FOUND(0) if deemed necessary Once again I'm not an expert and I'm may suggest somethi

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-08-28 Thread Rafael J. Wysocki
On Fri, Aug 28, 2020 at 8:26 PM Anchal Agarwal wrote: > > On Fri, Aug 21, 2020 at 10:22:43PM +, Anchal Agarwal wrote: > > Hello, > > This series fixes PM hibernation for hvm guests running on xen hypervisor. > > The running guest could now be hibernated and resumed successfully at a > > later

Re: [PATCH v3 00/11] Fix PM hibernation in Xen guests

2020-08-28 Thread Anchal Agarwal
On Fri, Aug 21, 2020 at 10:22:43PM +, Anchal Agarwal wrote: > Hello, > This series fixes PM hibernation for hvm guests running on xen hypervisor. > The running guest could now be hibernated and resumed successfully at a > later time. The fixes for PM hibernation are added to block and > network

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

2020-08-28 Thread Pablo Neira Ayuso
On Fri, Aug 28, 2020 at 02:14:48PM -0400, Tong Zhang wrote: > Hi Pablo, > I'm not an expert in this networking stuff. > But from my point of view there's no point in checking if this > condition is always true. Understood. > There's also no need of returning anything from the > ct_sip_parse_numer

Re: [PATCH net-next] net/sched: add act_ct_output support

2020-08-28 Thread Cong Wang
On Tue, Aug 25, 2020 at 8:33 AM Marcelo Ricardo Leitner wrote: > I still don't understand Cong's argument for not having this on > act_mirred because TC is L2. That's actually not right. TC hooks at L2 You miss a very important point that it is already too late to rename act_mirred to reflect wha

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

2020-08-28 Thread Tong Zhang
Hi Pablo, I'm not an expert in this networking stuff. But from my point of view there's no point in checking if this condition is always true. There's also no need of returning anything from the ct_sip_parse_numerical_param() if they are all being ignored like this. On Fri, Aug 28, 2020 at 2:07 PM

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

2020-08-28 Thread Pablo Neira Ayuso
On Sat, Aug 15, 2020 at 12:50:30PM -0400, Tong Zhang wrote: > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is > checking parsing error using < 0 Is this are real issue in your setup or probably some static analysis tool is reporting? You are right that ct_sip_parse_numerica

Re: [PATCH net-next] netfilter: xt_HMARK: Use ip_is_fragment() helper

2020-08-28 Thread Pablo Neira Ayuso
On Thu, Aug 27, 2020 at 10:08:13PM +0800, YueHaibing wrote: > Use ip_is_fragment() to simpify code. Applied.

[PATCH net-next 4/4] sfc: return errors from efx_mcdi_set_id_led, and de-indirect

2020-08-28 Thread Edward Cree
W=1 warnings indicated that 'rc' was unused in efx_mcdi_set_id_led(); change the function to return int instead of void and plumb the rc through the caller efx_ethtool_phys_id(). Since (post-Falcon) all sfc NICs use MCDI for this, there's no point in indirecting through a nic_type method, so rem

[PATCH net-next 3/4] sfc: fix kernel-doc on struct efx_loopback_state

2020-08-28 Thread Edward Cree
Missing 'struct' keyword caused "cannot understand function prototype" warnings. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/selftest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/selftest.c b/drivers/net/ethernet/sfc/selftest.c inde

[PATCH net-next 2/4] sfc: fix unused-but-set-variable warning in efx_farch_filter_remove_safe

2020-08-28 Thread Edward Cree
Thanks to some past refactor, 'spec' is not actually used in this function; the code using it moved to the callee efx_farch_filter_remove. Remove the variable to fix a W=1 warning. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/farch.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH net-next 1/4] sfc: fix W=1 warnings in efx_farch_handle_rx_not_ok

2020-08-28 Thread Edward Cree
Some of these RX-event flags aren't used at all, so remove them. Others are used only #ifdef DEBUG to log a message; suppress the unused-var warnings #ifndef DEBUG with a void cast. Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/farch.c | 7 ++- 1 file changed, 2 insertions(+), 5 d

[PATCH net-next 0/4] sfc: clean up some W=1 build warnings

2020-08-28 Thread Edward Cree
A collection of minor fixes to issues flagged up by W=1. After this series, the only remaining warnings in the sfc driver are some 'member missing in kerneldoc' warnings from ptp.c. Tested by building on x86_64 and running 'ethtool -p' on an EF10 NIC; there was no error, but I couldn't observe th

Re: [Linux-kernel-mentees] [PATCH net-next v2] ipvs: Fix uninit-value in do_ip_vs_set_ctl()

2020-08-28 Thread Pablo Neira Ayuso
On Tue, Aug 11, 2020 at 03:46:40AM -0400, Peilin Ye wrote: > do_ip_vs_set_ctl() is referencing uninitialized stack value when `len` is > zero. Fix it. Applied to nf-next, thanks.

Re: [PATCH net-next v1 3/3] hinic: add support to query function table

2020-08-28 Thread Jakub Kicinski
On Fri, 28 Aug 2020 11:16:22 +0800 luobin (L) wrote: > On 2020/8/28 3:44, Jakub Kicinski wrote: > > On Thu, 27 Aug 2020 19:13:21 +0800 Luo bin wrote: > >> + switch (idx) { > >> + case VALID: > >> + return funcfg_table_elem->dw0.bs.valid; > >> + case RX_MODE: > >> + return fun

Re: [PATCH v3 1/1] netfilter: nat: add a range check for l3/l4 protonum

2020-08-28 Thread Pablo Neira Ayuso
On Fri, Aug 28, 2020 at 06:45:51PM +0200, Florian Westphal wrote: > Pablo Neira Ayuso wrote: > > Hi Will, > > > > Given this is for -stable maintainers only, I'd suggest: > > > > 1) Specify what -stable kernel versions this patch applies to. > >Explain that this problem is gone since what ke

Re: [PATCH RFC net-next] net/tls: Implement getsockopt SOL_TLS TLS_RX

2020-08-28 Thread Jakub Kicinski
On Tue, 18 Aug 2020 14:12:24 + Yutaro Hayakawa wrote: > @@ -352,7 +352,11 @@ static int do_tls_getsockopt_tx(struct sock *sk, char > __user *optval, > } > > /* get user crypto info */ > - crypto_info = &ctx->crypto_send.info; > + if (tx) { > + crypto_info = &

Re: [PATCH v3 1/1] netfilter: nat: add a range check for l3/l4 protonum

2020-08-28 Thread Florian Westphal
Pablo Neira Ayuso wrote: > Hi Will, > > Given this is for -stable maintainers only, I'd suggest: > > 1) Specify what -stable kernel versions this patch applies to. >Explain that this problem is gone since what kernel version. > > 2) Maybe clarify that this is only for stable in the patch su

Re: [PATCH net-next 2/3] devlink: Consider other controller while building phys_port_name

2020-08-28 Thread Jakub Kicinski
On Fri, 28 Aug 2020 04:27:19 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Friday, August 28, 2020 3:12 AM > > > > On Thu, 27 Aug 2020 20:15:01 + Parav Pandit wrote: > > > > From: Jakub Kicinski > > > > > > > > I find it strange that you have pfnum 0 everywhere but then > >

Re: [PATCH v3 1/1] netfilter: nat: add a range check for l3/l4 protonum

2020-08-28 Thread Pablo Neira Ayuso
Hi Will, Given this is for -stable maintainers only, I'd suggest: 1) Specify what -stable kernel versions this patch applies to. Explain that this problem is gone since what kernel version. 2) Maybe clarify that this is only for stable in the patch subject, e.g. [PATCH -stable v3] netfilte

Re: [PATCH V2 1/5 nf] selftests: netfilter: fix header example

2020-08-28 Thread Pablo Neira Ayuso
On Sun, Aug 23, 2020 at 08:15:37PM +0200, Fabian Frederick wrote: > nft_flowtable.sh is made for bash not sh. > Also give values which not return "RTNETLINK answers: Invalid > argument" Series from 1 to 5 is applied.

Re: [PATCH] net: netfilter: delete repeated words

2020-08-28 Thread Pablo Neira Ayuso
On Sat, Aug 22, 2020 at 06:07:27PM -0700, Randy Dunlap wrote: > Drop duplicated words in net/netfilter/ and net/ipv4/netfilter/. Applied, thanks.

[PATCH bpf-next] samples/bpf: fix to xdpsock to avoid recycling frames

2020-08-28 Thread Weqaar Janjua
The txpush program in the xdpsock sample application is supposed to send out all packets in the umem in a round-robin fashion. The problem is that it only cycled through the first BATCH_SIZE worth of packets. Fixed this so that it cycles through all buffers in the umem as intended. Fixes: 248c7f9c

RE: [PATCH bpf-next] 0001-samples-bpf-fix-to-xdpsock-to-avoid-recycling-frames.patch

2020-08-28 Thread Janjua, Weqaar A
> -Original Message- > From: Janjua, Weqaar A > Sent: Friday, August 28, 2020 4:20 PM > To: Karlsson, Magnus ; Topel, Bjorn > ; a...@kernel.org; dan...@iogearbox.net; > netdev@vger.kernel.org; jonathan.le...@gmail.com > Cc: Janjua, Weqaar A ; b...@vger.kernel.org > Subject: [PATCH bpf-next

Re: [PATCH v2] netlabel: remove unused param from audit_log_format()

2020-08-28 Thread David Miller
From: Alex Dewar Date: Fri, 28 Aug 2020 14:55:23 +0100 > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > added a check to return an error if ret_val != 0, before ret_val is > later used in a log message. Now it will unconditionally print "... > res=1". So just drop the check

Re: VRRP not working on i40e X722 S2600WFT

2020-08-28 Thread Lennart Sorensen
On Thu, Aug 27, 2020 at 02:30:39PM -0400, Lennart Sorensen wrote: > I have hit a new problem with the X722 chipset (Intel R1304WFT server). > VRRP simply does not work. > > When keepalived registers a vmac interface, and starts transmitting > multicast packets with the vrp message, it never receiv

[PATCH net] cxgb4: fix thermal zone device registration

2020-08-28 Thread Potnuri Bharat Teja
When multiple adapters are present in the system, pci hot-removing second adapter leads to the following warning as both the adapters registered thermal zone device with same thermal zone name/type. Therefore, use unique thermal zone name during thermal zone device initialization. Also mark thermal

Re: [PATCH v3 bpf-next 0/3] bpf: Relax the max_entries check for inner map

2020-08-28 Thread Daniel Borkmann
On 8/28/20 3:18 AM, Martin KaFai Lau wrote: v3: - Add map_meta_equal to bpf_map_ops and use it as an explict opt-in support for map-in-map v2: - New BPF_MAP_TYPE_FL to minimize code churns (Alexei) - s/capabilities/properties/ (Andrii) - Describe WHY in commit log (Andrii) People has a u

[PATCH bpf-next] 0001-samples-bpf-fix-to-xdpsock-to-avoid-recycling-frames.patch

2020-08-28 Thread Weqaar Janjua
--- ...to-xdpsock-to-avoid-recycling-frames.patch | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 0001-samples-bpf-fix-to-xdpsock-to-avoid-recycling-frames.patch diff --git a/0001-samples-bpf-fix-to-xdpsock-to-avoid-recycling-frames.patch b/0001-samples-bpf-fix-to

[PATCH net-next v2 2/2] openvswitch: using ip6_fragment in ipv6_stub

2020-08-28 Thread wenxu
From: wenxu Using ipv6_stub->ipv6_fragment to avoid the netfilter dependency Signed-off-by: wenxu --- net/openvswitch/actions.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/net/openvswitch/actions.c b/net/openvswitch/actions.c index 2611657..fd34089 100644 --- a/ne

[PATCH net-next v2 1/2] ipv6: add ipv6_fragment hook in ipv6_stub

2020-08-28 Thread wenxu
From: wenxu Add ipv6_fragment to ipv6_stub to avoid calling netfilter when access ip6_fragment. Signed-off-by: wenxu --- v2: add default one eafnosupport_ipv6_fragment include/net/ipv6_stubs.h | 3 +++ net/ipv6/addrconf_core.c | 8 net/ipv6/af_inet6.c | 1 + 3 files changed, 12

[PATCH net-next v2 0/2] Add ip6_fragment in ipv6_stub

2020-08-28 Thread wenxu
From: wenxu Add ip6_fragment in ipv6_stub and use it in openvswitch This version add default function eafnosupport_ipv6_fragment wenxu (2): ipv6: add ipv6_fragment hook in ipv6_stub openvswitch: using ip6_fragment in ipv6_stub include/net/ipv6_stubs.h | 3 +++ net/ipv6/addrconf_core.c |

Re: linux-next: build failure after merge of the net-next tree

2020-08-28 Thread Randy Dunlap
On 8/28/20 8:09 AM, Sven Joachim wrote: > On 2020-08-27 11:12 -0700, Brian Vazquez wrote: > >> I've been trying to reproduce it with your config but I didn't >> succeed. I also looked at the file after the preprocessor and it >> looked good: >> >> ret = ({ __builtin_expect(!!(ops->match == fib6_ru

Re: linux-next: build failure after merge of the net-next tree

2020-08-28 Thread Sven Joachim
On 2020-08-27 11:12 -0700, Brian Vazquez wrote: > I've been trying to reproduce it with your config but I didn't > succeed. I also looked at the file after the preprocessor and it > looked good: > > ret = ({ __builtin_expect(!!(ops->match == fib6_rule_match), 1) ? > fib6_rule_match(rule, fl, flags

Re: [PATCH] Remove ipvs v6 dependency on iptables

2020-08-28 Thread Nicolas Dichtel
Le 28/08/2020 à 00:07, Lach a écrit : > This dependency was added in 63dca2c0b0e7a92cb39d1b1ecefa32ffda201975, > because this commit had dependency on > ipv6_find_hdr, which was located in iptables-specific code > > But it is no longer required, because > f8f626754ebeca613cf1af2e6f890cfde0e74d5b

Re: [PATCH v3 net-next 00/12] ionic memory usage rework

2020-08-28 Thread David Miller
From: Shannon Nelson Date: Thu, 27 Aug 2020 16:00:18 -0700 > Previous review comments have suggested [1],[2] that this driver > needs to rework how queue resources are managed and reconfigured > so that we don't do a full driver reset and to better handle > potential allocation failures. This pa

[PATCH iproute2-next] ip xfrm: support printing XFRMA_SET_MARK_MASK attribute in states

2020-08-28 Thread Antony Antony
The XFRMA_SET_MARK_MASK attribute is set in states (4.19+). It is the mask of XFRMA_SET_MARK(a.k.a. XFRMA_OUTPUT_MARK in 4.18) sample output: note the output-mark mask ip xfrm state src 192.1.2.23 dst 192.1.3.33 proto esp spi 0xSPISPI reqid REQID mode tunnel replay-window 3

Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-08-28 Thread Andrew Lunn
On Fri, Aug 28, 2020 at 02:24:28PM +, Asmaa Mnebhi wrote: > > > + The second generation BlueField SoC from Mellanox Technologies > > > + supports an out-of-band Gigabit Ethernet management port to the > > > + Arm subsystem. > > > > You might want to additionally select the PHY driver you

Re: [PATCH v2] netlabel: remove unused param from audit_log_format()

2020-08-28 Thread Paul Moore
On Fri, Aug 28, 2020 at 9:56 AM Alex Dewar wrote: > > Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") > added a check to return an error if ret_val != 0, before ret_val is > later used in a log message. Now it will unconditionally print "... > res=1". So just drop the check. >

RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-08-28 Thread Asmaa Mnebhi
> > +static int mlxbf_gige_get_link_ksettings(struct net_device *netdev, > > +struct ethtool_link_ksettings > *link_ksettings) { > > + struct phy_device *phydev = netdev->phydev; > > + u32 supported, advertising; > phy_ethtool_ksettings_get() and maybe phy_e

RE: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

2020-08-28 Thread Asmaa Mnebhi
> > + The second generation BlueField SoC from Mellanox Technologies > > + supports an out-of-band Gigabit Ethernet management port to the > > + Arm subsystem. > > You might want to additionally select the PHY driver you are using. > It is preferable to not set a specific PHY driver h

Re: [Patch net] net_sched: fix error path in red_init()

2020-08-28 Thread David Miller
From: Cong Wang Date: Thu, 27 Aug 2020 10:40:41 -0700 > When ->init() fails, ->destroy() is called to clean up. > So it is unnecessary to clean up in red_init(), and it > would cause some refcount underflow. > > Fixes: aee9caa03fc3 ("net: sched: sch_red: Add qevents "early_drop" and > "mark"")

Re: [PATCHi v2] net: mdiobus: fix device unregistering in mdiobus_register

2020-08-28 Thread Sascha Hauer
On Thu, Aug 27, 2020 at 10:48:48AM +0200, Heiner Kallweit wrote: > On 27.08.2020 09:06, Sascha Hauer wrote: > > After device_register has been called the device structure may not be > > freed anymore, put_device() has to be called instead. This gets violated > > when device_register() or any of the

Re: [PATCH net-next v3 0/2] Enable Fiber on DP83822 PHY

2020-08-28 Thread David Miller
From: Dan Murphy Date: Thu, 27 Aug 2020 08:45:07 -0500 > The DP83822 Ethernet PHY has the ability to connect via a Fiber port. The > derivative PHYs DP83825 and DP83826 do not have this ability. In fiber mode > the DP83822 disables auto negotiation and has a fixed 100Mbps speed with > support fo

Re: packet deadline and process scheduling

2020-08-28 Thread Willem de Bruijn
On Fri, Aug 28, 2020 at 10:51 AM S.V.R.Anand wrote: > > There is an active Internet draft "Packet Delivery Deadline time in > 6LoWPAN Routing Header" > (https://datatracker.ietf.org/doc/draft-ietf-6lo-deadline-time/) which > is presently in the RFC Editor queue and is expected to become an RFC in

[PATCH v2] netlabel: remove unused param from audit_log_format()

2020-08-28 Thread Alex Dewar
Commit d3b990b7f327 ("netlabel: fix problems with mapping removal") added a check to return an error if ret_val != 0, before ret_val is later used in a log message. Now it will unconditionally print "... res=1". So just drop the check. Addresses-Coverity: ("Dead code") Fixes: d3b990b7f327 ("netlab

Re: [PATCH] net: dsa: mt7530: fix advertising unsupported

2020-08-28 Thread David Miller
From: Landen Chao Date: Thu, 27 Aug 2020 17:15:47 +0800 > 1000baseT_Half > > Remove 1000baseT_Half to advertise correct hardware capability in > phylink_validate() callback function. > > Fixes: 38f790a80560 ("net: dsa: mt7530: Add support for port 5") > Signed-off-by: Landen Chao Applied and

Re: [PATCHv3 next] net: add option to not create fall-back tunnels in root-ns as well

2020-08-28 Thread David Miller
From: Mahesh Bandewar Date: Wed, 26 Aug 2020 09:05:35 -0700 > The sysctl that was added earlier by commit 79134e6ce2c ("net: do > not create fallback tunnels for non-default namespaces") to create > fall-back only in root-ns. This patch enhances that behavior to provide > option not to create fa

Re: [PATCH] netlink: fix a data race in netlink_rcv_wake()

2020-08-28 Thread David Miller
From: zhudi Date: Wed, 26 Aug 2020 20:01:13 +0800 > The data races were reported by KCSAN: > BUG: KCSAN: data-race in netlink_recvmsg / skb_queue_tail ... > Since the write is under sk_receive_queue->lock but the read > is done as lockless. so fix it by using skb_queue_empty_lockless() > instead

Re: [PATCH net-next v5 0/3] Add phylib support to smsc95xx

2020-08-28 Thread David Miller
From: Andre Edich Date: Wed, 26 Aug 2020 13:17:14 +0200 > To allow to probe external PHY drivers, this patch series adds use of > phylib to the smsc95xx driver. ... Series applied, thank you.

[PATCH net-next 0/2] gtp: minor enhancements

2020-08-28 Thread Nicolas Dichtel
The first patch removes a useless rcu lock and the second relax alloc constraints when a PDP context is added. drivers/net/gtp.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) Comments are welcomed, Nicolas

[PATCH net-next 2/2] gtp: relax alloc constraint when adding a pdp

2020-08-28 Thread Nicolas Dichtel
When a PDP context is added, the rtnl lock is held, thus no need to force a GFP_ATOMIC. Signed-off-by: Nicolas Dichtel --- drivers/net/gtp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index 6f871ec31393..2ed1e82a8ad8 10064

[PATCH net-next 1/2] gtp: remove useless rcu_read_lock()

2020-08-28 Thread Nicolas Dichtel
The rtnl lock is taken just the line above, no need to take the rcu also. Fixes: 1788b8569f5d ("gtp: fix use-after-free in gtp_encap_destroy()") Signed-off-by: Nicolas Dichtel --- drivers/net/gtp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/gtp.c b/drivers/net/gtp.c index c

Re: pull-request: mac80211-next 2020-08-28

2020-08-28 Thread David Miller
From: Johannes Berg Date: Fri, 28 Aug 2020 12:12:37 +0200 > Here also nothing stands out, though perhaps you'd be > interested in the fact that we now use the new netlink > range length validation for some binary attributes. Awesome! > Please pull and let me know if there's any problem. Pulled

Re: pull-request: mac80211 2020-08-28

2020-08-28 Thread David Miller
From: Johannes Berg Date: Fri, 28 Aug 2020 12:08:04 +0200 > We have a number of fixes for the current release cycle, > one is for a syzbot reported warning (the sanity check) > but most are more wifi protocol related. > > Please pull and let me know if there's any problem. Pulled, thanks Johann

[PATCH bpf-next] samples/bpf: optimize l2fwd performance in xdpsock

2020-08-28 Thread Magnus Karlsson
Optimize the throughput performance of the l2fwd sub-app in the xdpsock sample application by removing a duplicate syscall and increasing the size of the fill ring. The latter needs some further explanation. We recommend that you set the fill ring size >= HW RX ring size + AF_XDP RX ring size. Mak

Re: [PATCH 12/30] net: wireless: cisco: airo: Fix a myriad of coding style issues

2020-08-28 Thread Kalle Valo
Lee Jones writes: > On Fri, 28 Aug 2020, Kalle Valo wrote: > >> Ondrej Zary writes: >> >> > On Thursday 27 August 2020 09:49:12 Kalle Valo wrote: >> >> Ondrej Zary writes: >> >> >> >> > On Monday 17 August 2020 20:27:06 Jesse Brandeburg wrote: >> >> >> On Mon, 17 Aug 2020 16:27:01 +0300 >> >>

  1   2   >