On 30 Aug 2020, at 23:26, t...@redhat.com wrote:
From: Tom Rix
clang static analysis flags these problems
flow_table.c:713:2: warning: The expression is an uninitialized
value. The computed value will also be garbage
(*n_mask_hit)++;
^~~
flow_table.c:748:5: wa
On 31 Aug 2020, at 9:50, Eelco Chaudron wrote:
On 30 Aug 2020, at 23:26, t...@redhat.com wrote:
From: Tom Rix
clang static analysis flags these problems
flow_table.c:713:2: warning: The expression is an uninitialized
value. The computed value will also be garbage
(*n_mask_hit)+
On 8/28/20 2:52 PM, Stephen Hemminger wrote:
> On Fri, 28 Aug 2020 22:44:47 +0200
> Bart Groeneveld wrote:
>
>> IANA specifies User ports as 1024-49151,
>> and Private ports (local/ephemeral/dynamic/w/e) as 49152-65535 [1].
>>
>> This means Linux uses 32768-49151 'illegally'.
>> This is not ju
This addresses the following gcc warning with "make W=1":
drivers/net/wireless/ath/ath6kl/wmi.c: In function
‘ath6kl_wmi_bitrate_reply_rx’:
drivers/net/wireless/ath/ath6kl/wmi.c:1204:6: warning: variable ‘rate’
set but not used [-Wunused-but-set-variable]
1204 | s32 rate;
| ^~~~
The
On 8/29/20 12:37 PM, Tuong Lien wrote:
> The 'this_cpu_ptr()' is used to obtain the AEAD key' TFM on the current
> CPU for encryption, however the execution can be preemptible since it's
> actually user-space context, so the 'using smp_processor_id() in
> preemptible' has been observed.
>
> We
Hi Eric,
Thanks for your comments, please see my answers inline.
> -Original Message-
> From: Eric Dumazet
> Sent: Monday, August 31, 2020 3:15 PM
> To: Tuong Tong Lien ; da...@davemloft.net;
> jma...@redhat.com; ma...@donjonn.com;
> ying@windriver.com; netdev@vger.kernel.org
> Cc:
From: Randy Dunlap
Drop duplicated words in net/netfilter/ and net/ipv4/netfilter/.
Signed-off-by: Randy Dunlap
Reviewed-by: Florian Westphal
Signed-off-by: Pablo Neira Ayuso
---
net/ipv4/netfilter/nf_nat_pptp.c | 2 +-
net/netfilter/nf_conntrack_pptp.c | 2 +-
net/netfilter/nf_co
Hi,
The following patchset contains Netfilter fixes for net:
1) Do not delete clash entries on reply, let them expire instead,
from Florian Westphal.
2) Do not report EAGAIN to nfnetlink, otherwise this enters a busy loop.
Update nfnetlink_unicast() to translate EAGAIN to ENOBUFS.
3) Remo
From: Fabian Frederick
exit script with comments when parameters are wrong during address
addition. No need for a message when trying to change MTU with lower
values: output is self-explanatory.
Use short testing sequence to avoid shellcheck warnings
(suggested by Stefano Brivio).
Signed-off-by:
From: Fabian Frederick
Fix some shellcheck SC2181 warnings:
"Check exit code directly with e.g. 'if mycmd;', not indirectly with
$?." as suggested by Stefano Brivio.
Signed-off-by: Fabian Frederick
Signed-off-by: Pablo Neira Ayuso
---
.../selftests/netfilter/nft_flowtable.sh | 34 ++-
Frontend callback reports EAGAIN to nfnetlink to retry a command, this
is used to signal that module autoloading is required. Unfortunately,
nlmsg_unicast() reports EAGAIN in case the receiver socket buffer gets
full, so it enters a busy-loop.
This patch updates nfnetlink_unicast() to turn EAGAIN
From: Fabian Frederick
Avoid bad command arguments.
Based on tools/power/cpupower/bench/cpufreq-bench_plot.sh
Signed-off-by: Fabian Frederick
Signed-off-by: Pablo Neira Ayuso
---
tools/testing/selftests/netfilter/nft_flowtable.sh | 11 +++
1 file changed, 11 insertions(+)
diff --git
From: Fabian Frederick
'who' variable was not used in make_file()
Problem found using Shellcheck
Signed-off-by: Fabian Frederick
Signed-off-by: Pablo Neira Ayuso
---
tools/testing/selftests/netfilter/nft_flowtable.sh | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/too
From: Florian Westphal
Its possible that we have more than one packet with the same ct tuple
simultaneously, e.g. when an application emits n packets on same UDP
socket from multiple threads.
NAT rules might be applied to those packets. With the right set of rules,
n packets will be mapped to m
From: Fabian Frederick
nft_flowtable.sh is made for bash not sh.
Also give values which not return "RTNETLINK answers: Invalid argument"
Signed-off-by: Fabian Frederick
Signed-off-by: Pablo Neira Ayuso
---
tools/testing/selftests/netfilter/nft_flowtable.sh | 2 +-
1 file changed, 1 insertion(
On 8/31/20 1:33 AM, Tuong Tong Lien wrote:
> Hi Eric,
>
> Thanks for your comments, please see my answers inline.
>
>> -Original Message-
>> From: Eric Dumazet
>> Sent: Monday, August 31, 2020 3:15 PM
>> To: Tuong Tong Lien ; da...@davemloft.net;
>> jma...@redhat.com; ma...@donjonn.c
If nf_conncount_init fails currently the dispatched work is not canceled,
causing problems when the timer fires. This change fixes this by not
scheduling the work until all initialization is successful.
Fixes: a65878d6f00b ("net: openvswitch: fixes potential deadlock in dp cleanup
code")
Reported
> -Original Message-
> From: Eric Dumazet
> Sent: Monday, August 31, 2020 4:48 PM
> To: Tuong Tong Lien ; Eric Dumazet
> ; da...@davemloft.net;
> jma...@redhat.com; ma...@donjonn.com; ying@windriver.com;
> netdev@vger.kernel.org
> Cc: tipc-discuss...@lists.sourceforge.net
> Subject
Hi "Marek,
url:
https://github.com/0day-ci/linux/commits/Marek-Beh-n/net-dsa-mv88e6xxx-Add-Amethyst-88E6393X/20200819-234008
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git
e3ec1e8ca02b7e6c935bba3f9b6da86c2e57d2eb
config: openrisc-randconfig-m031-20200827 (attached
Sun, Aug 30, 2020 at 05:27:23PM CEST, mo...@mellanox.com wrote:
>Expose devlink reload actions counters to the user through devlink dev
>get command.
>
>Examples:
>$ devlink dev show
>pci/:82:00.0:
> reload_actions_stats:
>driver_reinit 2
>fw_activate 1
>fw_activate_no_reset 0
>pci
Sun, Aug 30, 2020 at 05:27:22PM CEST, mo...@mellanox.com wrote:
>Add reload actions counters to hold the history per reload action type.
>For example, the number of times fw_activate has been done on this
>device since the driver module was added or if the firmware activation
>was done with or with
Sun, Aug 30, 2020 at 05:27:20PM CEST, mo...@mellanox.com wrote:
>Introduce new option on devlink reload API to enable the user to select the
>reload action required. Complete support for all actions in mlx5.
>The following reload actions are supported:
> driver_reinit: driver entities re-initializ
On Fri, 28 Aug 2020 at 18:18, Weqaar Janjua wrote:
>
> The txpush program in the xdpsock sample application is supposed
> to send out all packets in the umem in a round-robin fashion.
> The problem is that it only cycled through the first BATCH_SIZE
> worth of packets. Fixed this so that it cycles
On Fri, 28 Aug 2020 at 18:18, Weqaar Janjua wrote:
>
[...]
> --
> 2.20.1
>
> --
> Intel Research and Development Ireland Limited
> Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
> Registere
Hello,
syzbot found the following issue on:
HEAD commit:3ed8e1c2 usb: typec: tcpm: Migrate workqueue to RT priorit..
git tree: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git
usb-testing
console output: https://syzkaller.appspot.com/x/log.txt?x=111f901590
kernel conf
Sun, Aug 30, 2020 at 05:27:21PM CEST, mo...@mellanox.com wrote:
>Add devlink reload action to allow the user to request a specific reload
>action. The action parameter is optional, if not specified then devlink
>driver re-init action is used (backward compatible).
>Note that when required to do fir
On 8/31/20 3:05 AM, Tuong Tong Lien wrote:
>
>
>> -Original Message-
>> From: Eric Dumazet
>> Sent: Monday, August 31, 2020 4:48 PM
>> To: Tuong Tong Lien ; Eric Dumazet
>> ; da...@davemloft.net;
>> jma...@redhat.com; ma...@donjonn.com; ying@windriver.com;
>> netdev@vger.kernel.
On Thu, Aug 27, 2020 at 3:23 AM Pravin Shelar wrote:
>
> On Mon, Aug 24, 2020 at 12:37 AM wrote:
> >
> > From: Tonghao Zhang
> >
> > Not change the logic, just improve coding style.
> >
> > Cc: Pravin B Shelar
> > Signed-off-by: Tonghao Zhang
>
> Acked-by: Pravin B Shelar
Hi David
This series
On 29.08.2020 16:29, Krzysztof Kozlowski wrote:
> Since "s3fwrn5" is not a valid vendor prefix, use new GPIO properties
> instead of the deprecated.
>
> Signed-off-by: Krzysztof Kozlowski
Tested-by: Marek Szyprowski
> ---
> arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 4 ++--
> 1
On 29.08.2020 16:29, Krzysztof Kozlowski wrote:
> The device tree property prefix describes the vendor, which in case of
> S3FWRN5 chip is Samsung. Therefore the "s3fwrn5" prefix for "en-gpios"
> and "fw-gpios" is not correct and should be deprecated. Introduce
> properly named properties for t
Dne 04. 08. 20 v 18:09 izabela.bakoll...@gmail.com napsala:
From: Izabela Bakollari
Dropwatch is a utility that monitors dropped frames by having userspace
record them over the dropwatch protocol over a file. This augument
allows live monitoring of dropped frames using tools like tcpdump.
With
Hi,
this small series cleans the smsc-phy code a bit and adds the support to
specify the phy clock source. Adding the phy clock source support is
also the main purpose of this series.
Regards,
Marco
Marco Felsch (5):
net: phy: smsc: skip ENERGYON interrupt if disabled
net: phy: smsc: simpl
Don't enable the interrupt if the platform disable the energy detection
by "smsc,disable-energy-detect".
Signed-off-by: Marco Felsch
---
drivers/net/phy/smsc.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/phy/smsc.c b/drivers/net/phy/smsc.c
ind
Don't reset the phy without respect to the phy-state-machine because
this breaks the phy IRQ mode. We can archive the same behaviour if the
refclk in is specified.
Signed-off-by: Marco Felsch
---
drivers/net/phy/smsc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/phy/smsc.c b/d
Exit the driver specific config_init hook early if energy detection is
disabled. We can do this because we don't need to clear the interrupt
status here. Clearing the status should be removed anyway since this is
handled by the phy_enable_interrupts().
Signed-off-by: Marco Felsch
---
drivers/net
Add support to specify the clock provider for the phy refclk and don't
rely on 'magic' host clock setup. [1] tried to address this by
introducing a flag and fixing the corresponding host. But this commit
breaks the IRQ support since the irq setup during .config_intr() is
thrown away because the res
Add support to specify the reference clock for the phy.
Signed-off-by: Marco Felsch
---
Documentation/devicetree/bindings/net/smsc-lan87xx.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/smsc-lan87xx.txt
b/Documentation/devicetree/bindings/net/s
On Mon, 31 Aug 2020 at 15:16, Marek Szyprowski wrote:
>
>
> On 29.08.2020 16:29, Krzysztof Kozlowski wrote:
> > Since "s3fwrn5" is not a valid vendor prefix, use new GPIO properties
> > instead of the deprecated.
> >
> > Signed-off-by: Krzysztof Kozlowski
> Tested-by: Marek Szyprowski
Thanks fo
Christian Lamparter writes:
> On Thursday, 27 August 2020 11:33:51 CEST Lee Jones wrote:
>> 'ar9170_qmap' is used in some source files which include carl9170.h,
>> but not all of them. A 'defined but not used' warning is thrown when
>> compiling the ones which do not use it.
>>
>> Fixes the fol
On Mon, Aug 31, 2020 at 03:48:32PM +0200, Marco Felsch wrote:
> Don't enable the interrupt if the platform disable the energy detection
> by "smsc,disable-energy-detect".
>
> Signed-off-by: Marco Felsch
> ---
> drivers/net/phy/smsc.c | 15 +++
> 1 file changed, 11 insertions(+), 4 de
> + priv->refclk = devm_clk_get_optional(dev, NULL);
> + if (IS_ERR(priv->refclk)) {
> + if (PTR_ERR(priv->refclk) == -EPROBE_DEFER)
> + return -EPROBE_DEFER;
> +
> + /* Clocks are optional all errors should be ignored here */
> + retu
On Mon, Aug 31, 2020 at 03:48:36PM +0200, Marco Felsch wrote:
> Don't reset the phy without respect to the phy-state-machine because
> this breaks the phy IRQ mode. We can archive the same behaviour if the
> refclk in is specified.
>
> Signed-off-by: Marco Felsch
> ---
> drivers/net/phy/smsc.c |
On machines with much memory (> 2 TByte) and log_mtts_per_seg == 0, a
max_order of 31 will be passed to mlx_buddy_init(), which results in
s = BITS_TO_LONGS(1 << 31) becoming a negative value, leading to
kvmalloc_array() failure when it is converted to size_t.
mlx4_core :b1:00.0: Failed to i
On Fri, 28 Aug 2020 at 00:02, Alexei Starovoitov
wrote:
>
> From: Alexei Starovoitov
>
[...]
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index 6f5a9f51cc03..3ebfdb7bd427 100644
[...]
>
> +/* non exhaustive list of sleepable bpf_lsm_*() functions */
> +BTF_SET_START(btf_slee
On 8/31/20 2:03 AM, Tony Ambardar wrote:
While compiling libbpf, some GCC versions (at least 8.4.0) have difficulty
determining control flow and a emit warning for potentially uninitialized
usage of 'map', which results in a build error if using "-Werror":
In file included from libbpf.c:56:
libb
From: Björn Töpel
The bq_enqueue() functions for {DEV, CPU}MAP always return
zero. Changing the return type from int to void makes the code easier
to follow.
Signed-off-by: Björn Töpel
---
kernel/bpf/cpumap.c | 4 +---
kernel/bpf/devmap.c | 9 -
2 files changed, 5 insertions(+), 8 dele
Hi all,
This patch-set implements the control plane for initial IGMPv3 support.
Patch 01 arranges the structure better by moving the frequently used
fields together, patches 02 and 03 add support for source lists and group
modes per port group which are dumped. Patch 04 adds support for
group-and-s
We need to be able to retransmit group-specific and group-and-source
specific queries. The new timer takes care of those.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 65 ++-
net/bridge/br_private.h | 8 +
2 files changed, 65 inser
We have to use mdb and port entries when sending mdb notifications in
order to fill in all group attributes properly. Before this change we
would've used a fake br_mdb_entry struct to fill in only partial
information about the mdb. Now we can also reuse the mdb dump fill
function and thus have only
Support per port group src list (address and timer) and filter mode
dumping. Currently limited only to IPv4.
Signed-off-by: Nikolay Aleksandrov
---
include/uapi/linux/if_bridge.h | 21 +++
net/bridge/br_mdb.c| 66 --
2 files changed, 85 inserti
This change is in preparation for using the mdb port group entries when
sending a notification, so their full state and additional attributes can
be filled in.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
Allows br_ip4_multicast_alloc_query to build queries with the port group's
source lists and sends a query for sources over and under lmqt when
necessary as per RFC 3376 with the suppress flag set appropriately.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 126 ++
This patch adds handling for the IGMPV3_ALLOW_NEW_SOURCES IGMPv3 report
type and limits it only when multicast_igmp_version == 3. Now that
IGMPv3 handling functions will be managing timers we need to delay their
activation, thus a new argument is added which controls if the timer
should be updated.
If an expired port group is in EXCLUDE mode, then we have to turn it
into INCLUDE mode, remove all srcs with zero timer and finally remove
the group itself if there are no more srcs with an active timer.
For IGMPv2 use there would be no sources, so this will reduce to just
removing the group as bef
In order to avoid future errors and reduce code duplication we should
factor out the port group del sequence. This allows us to have one
function which takes care of all details when removing a port group.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 15 +-
net/brid
Before this patch we'd need 2 cache lines for fast-path, now all used
fields are in the first cache line.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_private.h | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_priv
When an IGMPv3 query is received and we're operating in v3 mode then we
need to avoid updating group timers if the suppress flag is set. Also we
should update only timers for groups in exclude mode.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 7 +--
1 file changed, 5 i
Since each entry type has timers that can be running simultaneously we need
to make sure that entries are not freed before their timers have finished.
In order to do that generalize the src gc work to mcast gc work and use a
callback to free the entries (mdb, port group or src).
Signed-off-by: Nik
In order to process IGMPV3_MODE_IS_INCLUDE/EXCLUDE report types we need
some new helpers which allow us to set/clear flags for all current entries
and later delete marked entries after the report sources have been
processed.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 128
In order to process IGMPV3_CHANGE_TO_INCLUDE/EXCLUDE report types we
need new helpers which allow us to mark entries based on their timer
state and to query only marked entries.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 273 ++
1 file
Initial functions for group source lists which are needed for IGMPv3
include/exclude lists. Currently only IPv4 sources are supported.
User-added mdb entries are created with exclude filter mode, we can
extend that later to allow user-supplied mode. When group src entries
are deleted, they're freed
We already have all necessary helpers, so process IGMPV3_BLOCK_OLD_SOURCES
as per the RFC.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 88 +++
1 file changed, 88 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multi
Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Allen Pais
> Signed-off-by: Kalle Valo
Patch a
Switch to the ARC4 library interface, to remove the pointless
dependency on the skcipher API, from which we will hopefully be
able to drop ecb(arc4) skcipher support.
Signed-off-by: Ard Biesheuvel
Acked-by: Greg Kroah-Hartman
---
drivers/staging/rtl8192u/Kconfig | 1 +
Switch to the ARC4 library interface, to remove the pointless
dependency on the skcipher API, from which we will hopefully be
able to drop ecb(arc4) skcipher support.
Signed-off-by: Ard Biesheuvel
Acked-by: Greg Kroah-Hartman
---
drivers/staging/rtl8192e/Kconfig | 4 +-
drivers/sta
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/n2_core.c | 46
1 file changed, 46 deletions(-)
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index d8aec5153b21..8c8e17d5fb20 100644
--- a/drivers/crypto/n2_core.c
+++ b/drivers/crypto/n2_core.c
@@ -662,7 +
Colin King wrote:
> The return error check on the call to ath11k_pci_get_user_msi_assignment is
> missing. If an error does occur, num_vectors is still set to zero and
> later on a division by zero can occur when variable vector is being
> calculated. Fix this by adding an error check after the
Colin King wrote:
> There is a spelling mistake in an ath11k_warn warning message. Fix it.
>
> Signed-off-by: Colin Ian King
> Signed-off-by: Kalle Valo
Patch applied to ath-next branch of ath.git, thanks.
bd5dd7aaa4c0 ath11k: fix spelling mistake "moniter" -> "monitor"
--
https://patchwor
RC4 hasn't aged very well, and is a poor fit for the skcipher API so it
would be good if we could get rid of the ecb(arc4) drivers in the kernel
at some point in the future. This prevents new users from creeping in, and
allows us to improve the skcipher API without having to care too much about
obs
Drop some bogus Kconfig selects that are not entirely accurate, and
unnecessary to begin with, since the same Kconfig options also select
LIB80211 features that already imply the selected functionality (AES
for CCMP, ARC4 and ECB for TKIP)
Signed-off-by: Ard Biesheuvel
---
drivers/net/wireless/i
The RC4-HMAC-MD5 KerberosV algorithm is based on RFC 4757 [0], which
was specifically issued for interoperability with Windows 2000, but was
never intended to receive the same level of support. The RFC says
The IETF Kerberos community supports publishing this specification as
an informational
Signed-off-by: Ard Biesheuvel
---
drivers/crypto/bcm/cipher.c | 96 +---
drivers/crypto/bcm/cipher.h | 1 -
drivers/crypto/bcm/spu.c| 23 +
drivers/crypto/bcm/spu.h| 1 -
drivers/crypto/bcm/spu2.c | 12 +--
drivers/crypto/bcm/spu2.h | 1 -
6 files changed, 6 ins
Cryptographic algorithms may have a lifespan that is significantly
shorter than Linux's, and so we need to start phasing out algorithms
that are known to be broken, and are no longer fit for general use.
RC4 (or arc4) is a good example here: there are a few areas where its
use is still somewhat ac
Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/wireless/ath/wil6210/wmi.c:52: warning: Incorrect use of
> kernel-doc format: * Addressing - theory of operations
> drivers/net/wireless/ath/wil6210/wmi.c:70: warning: Incorrect use of
> kernel-doc format:
"Gustavo A. R. Silva" wrote:
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes. Also, remove unnecessary
> variable _len_.
>
> This code was detected with the help of Coccinelle and, audited and
> fixed manually.
>
> Signed-o
Lee Jones wrote:
> 'ar9170_qmap' is used in some source files which include carl9170.h,
> but not all of them. A 'defined but not used' warning is thrown when
> compiling the ones which do not use it.
>
> Fixes the following W=1 kernel build warning(s)
>
> from drivers/net/wireless/ath/carl91
On Sat, 29 Aug 2020 at 18:43, J. Bruce Fields wrote:
>
> This code is rarely if ever used, and there are pending patches to
> remove it completely, so I don't think it's worth trying to fix a rare
> memory leak at this point.
>
> --b.
>
FYI I just submitted v3 of my series removing this code to t
Hi Abhishek,
> While unregistering, make sure to clear the suspend tasks before
> cancelling the work. If the unregister is called during resume from
> suspend, this will unnecessarily add 2s to the resume time otherwise.
>
> Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race)
> Signed-o
Lee Jones wrote:
> 'tos_to_tid_inv' is only used in 2 of 17 files it's current being
> included into.
>
> Fixes the following W=1 kernel build warning(s):
>
> In file included from drivers/net/wireless/marvell/mwifiex/main.c:23:
> In file included from drivers/net/wireless/marvell/mwifiex/cmd
From: Alexei Starovoitov
When CONFIG_BPF_SYSCALL is not set, but CONFIG_BPF_JIT=y
the kernel build fails:
In file included from ../kernel/bpf/trampoline.c:11:
../kernel/bpf/trampoline.c: In function ‘bpf_trampoline_update’:
../kernel/bpf/trampoline.c:220:39: error: ‘call_rcu_tasks_trace’ undeclar
Hi Coiby,
> When two HCI_EV_CONN_COMPLETE event packets with status=0 of the same
> HCI connection are received, device_add would be called twice which
> leads to kobject_add being called twice. Thus duplicate
> (struct hci_conn *conn)->dev.kobj.entry would be inserted into
> (struct hci_conn *con
On 8/31/20 9:07 AM, Björn Töpel wrote:
> From: Björn Töpel
>
> The bq_enqueue() functions for {DEV, CPU}MAP always return
> zero. Changing the return type from int to void makes the code easier
> to follow.
>
You can expand that to a few other calls in this code path - both
bq_flush_to_queue an
On Mon, Aug 31, 2020 at 08:51:55AM -0700, Alexei Starovoitov wrote:
> From: Alexei Starovoitov
>
> When CONFIG_BPF_SYSCALL is not set, but CONFIG_BPF_JIT=y
> the kernel build fails:
> In file included from ../kernel/bpf/trampoline.c:11:
> ../kernel/bpf/trampoline.c: In function ‘bpf_trampoline_up
On 8/31/20 9:15 AM, Paul E. McKenney wrote:
On Mon, Aug 31, 2020 at 08:51:55AM -0700, Alexei Starovoitov wrote:
From: Alexei Starovoitov
When CONFIG_BPF_SYSCALL is not set, but CONFIG_BPF_JIT=y
the kernel build fails:
In file included from ../kernel/bpf/trampoline.c:11:
../kernel/bpf/trampolin
On Mon, Aug 31, 2020 at 7:52 AM Björn Töpel wrote:
>
> On Fri, 28 Aug 2020 at 00:02, Alexei Starovoitov
> wrote:
> >
> > From: Alexei Starovoitov
> >
>
> [...]
>
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 6f5a9f51cc03..3ebfdb7bd427 100644
>
> [...]
>
> >
> > +/* non
From: Alexei Starovoitov
resolve_btfids doesn't like empty set. Add unused ID when BPF_LSM is off.
Reported-by: Björn Töpel
Fixes: 1e6c62a88215 ("bpf: Introduce sleepable BPF programs")
Signed-off-by: Alexei Starovoitov
---
kernel/bpf/verifier.c | 2 ++
1 file changed, 2 insertions(+)
diff -
On 8/31/2020 6:48 AM, Marco Felsch wrote:
Add support to specify the clock provider for the phy refclk and don't
rely on 'magic' host clock setup. [1] tried to address this by
introducing a flag and fixing the corresponding host. But this commit
breaks the IRQ support since the irq setup durin
Hello,
syzbot found the following issue on:
HEAD commit:0f091e43 netlabel: remove unused param from audit_log_form..
git tree: net-next
console output: https://syzkaller.appspot.com/x/log.txt?x=14865df290
kernel config: https://syzkaller.appspot.com/x/.config?x=61025c6fd3261bb1
das
While unregistering, make sure to clear the suspend tasks before
cancelling the work. If the unregister is called during resume from
suspend, this will unnecessarily add 2s to the resume time otherwise.
Fixes: 4e8c36c3b0d73d (Bluetooth: Fix suspend notifier race)
Signed-off-by: Abhishek Pandit-Sub
v2 sent with fix.
On Mon, Aug 31, 2020 at 8:49 AM Marcel Holtmann wrote:
>
> Hi Abhishek,
>
> > While unregistering, make sure to clear the suspend tasks before
> > cancelling the work. If the unregister is called during resume from
> > suspend, this will unnecessarily add 2s to the resume time o
On 8/29/20 5:22 PM, Yonghong Song wrote:
LOCKDEP=y
DEBUG_ATOMIC_SLEEP=y
LOCK_DEBUGGING_SUPPORT=y
KASAN=y
in my .config and don't see it :(
Could pls send me your .config?
The config file is attached. In my environment, the warning is only
printed out during the first run of `./test_progs -t lsm
Create a sysfs attribute group and make failover sysfs file a
member.
Signed-off-by: Thomas Falcon
---
drivers/net/ethernet/ibm/ibmvnic.c | 31 ++-
1 file changed, 22 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c
b/drivers/net/etherne
Include documentation for existing ibmvnic sysfs files,
currently only for "failover," which is used to swap
the active hardware port to a backup port in redundant
backing hardware or failover configurations.
Signed-off-by: Thomas Falcon
---
Documentation/ABI/testing/sysfs-driver-ibmvnic | 14 ++
Provide documentation for ibmvnic device Access Control List
files.
Signed-off-by: Thomas Falcon
---
Documentation/ABI/testing/sysfs-driver-ibmvnic | 26 ++
1 file changed, 26 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-driver-ibmvnic
b/Documentation/ABI/
These patches provide support for VNIC Access Control List
settings reporting through sysfs, where they may be exposed
to administrators or tools. ABI Documentation is provided for
existing sysfs device files as well.
Thomas Falcon (5):
ibmvnic: Create failover sysfs as part of an attribute grou
Access Control Lists can be defined for each IBM VNIC
adapter at time of creation. MAC address and VLAN ID's
may be specified, as well as a Port VLAN ID (PVID).
These may all be requested though read-only sysfs files:
mac_acl, vlan_acl, and pvid. When these files are read,
a series of Command-Respo
Access Control Lists can not be dynamically changed,
so an existing device can never be notified of an update
in ACL settings. Remove it.
Signed-off-by: Thomas Falcon
---
drivers/net/ethernet/ibm/ibmvnic.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ib
Hello,
syzbot found the following issue on:
HEAD commit:4d41ead6 Merge tag 'block-5.9-2020-08-28' of git://git.ker..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=100cf1de90
kernel config: https://syzkaller.appspot.com/x/.config?x=5ebdb650dfa501c1
das
In some cases, the device or firmware may be busy when the
driver attempts to perform the CRQ initialization handshake.
If the partner is busy, the hypervisor will return the H_CLOSED
return code. The aim of this patch is that, if the device is not
ready, to query the device a number of times, with
On 8/26/20 7:56 PM, Hoang Huu Le wrote:
> Syzbot has reported those issues as:
>
> ==
> BUG: KASAN: use-after-free in tipc_bcast_get_mode+0x3ab/0x400
> net/tipc/bcast.c:759
> Read of size 1 at addr 88805e6b3571 by task kworker
1 - 100 of 222 matches
Mail list logo
