mlx5_suspend()/resume() keep the network interface, so during hibernation
netvsc_unregister_vf() and netvsc_register_vf() are not called, and hence
netvsc_resume() should call netvsc_vf_changed() to switch the data path
back to the VF after hibernation. Note: after we close and re-open the
vmbus ch
Mon, Sep 07, 2020 at 08:48:30AM CEST, l...@kernel.org wrote:
>On Mon, Sep 07, 2020 at 08:21:35AM +0200, Jiri Pirko wrote:
>> Sun, Sep 06, 2020 at 06:33:05PM CEST, k...@kernel.org wrote:
>> >On Sun, 6 Sep 2020 10:27:59 +0300 Leon Romanovsky wrote:
>> >> On Fri, Sep 04, 2020 at 01:06:21PM -0700, Jaku
Sun, Sep 06, 2020 at 05:08:45AM CEST, pa...@nvidia.com wrote:
>
>
>> From: Jiri Pirko
>> Sent: Friday, September 4, 2020 2:13 PM
>>
>> Thu, Sep 03, 2020 at 09:31:23PM CEST, k...@kernel.org wrote:
>> >On Thu, 3 Sep 2020 07:54:39 +0200 Jiri Pirko wrote:
>> >> Wed, Sep 02, 2020 at 05:23:58PM CEST, k
Hi all,
I was able to trigger the same issue as reported by Paul, and came
across this patch (+ Daniele's other patch and thread on the libqmi
mailing list). Applying Paul's fix solved the problem for me, changing
the MTU of the QMI interface now works fine. Thanks a lot to everyone
involved!
I j
Hi Andy,
On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan wrote:
> >
> > Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8
> > ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely
> > wireless SMB deploym
Hi,
This is not a really good solution, this patch will cause a wrong status to the
user:
The supplicant will give status to the user that we are connected although we
are not able to encrypt a management packet in addition, the supplicant will
try over and over to send the AES_CMAC key.
The r
On 20-09-04 08:37, Florian Fainelli wrote:
>
>
> On 9/3/2020 11:15 PM, Marco Felsch wrote:
> > Hi Florian,
> >
> > On 20-09-02 21:39, Florian Fainelli wrote:
> > > The internal Gigabit PHY on Broadcom STB chips has a digital clock which
> > > drives its MDIO interface among other things, the dri
On Sun, Sep 06, 2020 at 12:23:23PM -0700, Florian Fainelli wrote:
>
>
> On 9/6/2020 10:13 AM, Jakub Kicinski wrote:
> > On Sun, 6 Sep 2020 14:12:49 +0300 Ido Schimmel wrote:
> > > On Thu, Sep 03, 2020 at 12:14:28PM -0700, Jakub Kicinski wrote:
> > > > On Thu, 3 Sep 2020 12:52:25 +0530 Vasundhara
On 20-09-04 08:38, Florian Fainelli wrote:
>
>
> On 9/3/2020 11:18 PM, Marco Felsch wrote:
> > On 20-09-02 21:39, Florian Fainelli wrote:
> > > The internal Gigabit PHY on Broadcom STB chips has a digital clock which
> > > drives its MDIO interface among other things, the driver now requests
> >
Kristian Evensen writes:
> Hi all,
>
> I was able to trigger the same issue as reported by Paul, and came
> across this patch (+ Daniele's other patch and thread on the libqmi
> mailing list). Applying Paul's fix solved the problem for me, changing
> the MTU of the QMI interface now works fine. T
If the memory map changes before the driver status is
VIRTIO_CONFIG_S_DRIVER_OK, don't attempt to create resources because it
may fail. For example, if the VQ is not ready there is no point in
creating resources.
Fixes: 1a86b377aa21 ("vdpa/mlx5: Add VDPA driver for supported mlx5 devices")
Signed-
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Saturday, September 5, 2020 12:19 AM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.co
On Mon, Sep 7, 2020 at 10:30 AM Vadym Kochan wrote:
> On Fri, Sep 04, 2020 at 10:12:07PM +0300, Andy Shevchenko wrote:
> > On Fri, Sep 4, 2020 at 7:52 PM Vadym Kochan
> > wrote:
I'm assuming that you agree on all non-commented.
...
> > > +#define prestera_dev(sw) ((sw)->dev->dev
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Saturday, September 5, 2020 12:15 AM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.co
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Saturday, September 5, 2020 7:04 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com
> -Original Message-
> From: Jakub Kicinski
> Sent: Monday, September 7, 2020 12:57 AM
> To: Hoang Huu Le
> Cc: ying@windriver.com; netdev@vger.kernel.org; jma...@redhat.com;
> ma...@donjonn.com;
> syzbot+d5aa7e0385f6a5d0f...@syzkaller.appspotmail.com
> Subject: Re: [net-next] tip
This patch is for xdp multicast support. which has been discussed before[0],
The goal is to be able to implement an OVS-like data plane in XDP, i.e.,
a software switch that can forward XDP frames to multiple ports.
To achieve this, an application needs to specify a group of interfaces
to forward a
Use helper bpf_redirect_map() and bpf_redirect_map_multi() to test bpf
arg ARG_CONST_MAP_PTR and ARG_CONST_MAP_PTR_OR_NULL. Make sure the
map arg could be verified correctly when it is NULL or valid map
pointer.
Add devmap and devmap_hash in struct bpf_test due to bpf_redirect_{map,
map_multi} lim
Add a new bpf argument type ARG_CONST_MAP_PTR_OR_NULL which could be
used when we want to allow NULL pointer for map parameter. The bpf helper
need to take care and check if the map is NULL when use this type.
Signed-off-by: Hangbin Liu
---
v11: no update
v10: remove useless CONST_PTR_TO_MAP_OR_
Add a bpf selftest for new helper xdp_redirect_map_multi(). In this
test we have 3 forward groups and 1 exclude group. The test will
redirect each interface's packets to all the interfaces in the forward
group, and exclude the interface in exclude map. We will also test both
DEVMAP and DEVMAP_HASH
This is a sample for xdp multicast. In the sample we could forward all
packets between given interfaces.
Signed-off-by: Hangbin Liu
---
v10-v11: no update
v9: use NULL directly for arg2 and redefine the maps with btf format
v5: add a null_map as we have strict the arg2 to ARG_CONST_MAP_PTR.
This patch is for xdp multicast support. which has been discussed
before[0], The goal is to be able to implement an OVS-like data plane in
XDP, i.e., a software switch that can forward XDP frames to multiple ports.
To achieve this, an application needs to specify a group of interfaces
to forward a
Nathan Chancellor wrote:
> A new warning in clang points out when macro expansion might result in a
> GNU C statement expression. There is an instance of this in the mwifiex
> driver:
>
> drivers/net/wireless/marvell/mwifiex/cmdevt.c:217:34: warning: '}' and
> ')' tokens terminating statement ex
"Gustavo A. R. Silva" wrote:
> Replace the existing /* fall through */ comments and its variants with
> the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> fall-through markings when it is the case.
>
> [1]
> https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highl
YueHaibing wrote:
> In file included from drivers/net/wireless/marvell/mwifiex//cmdevt.c:26:0:
> drivers/net/wireless/marvell/mwifiex//wmm.h:41:17: warning: ‘tos_to_tid_inv’
> defined but not used [-Wunused-const-variable=]
> static const u8 tos_to_tid_inv[] = {
> ^
YueHaibing wrote:
> These variables only used in pcie.c, move them to .c file
> can silence these warnings:
>
> In file included from drivers/net/wireless/marvell/mwifiex/main.h:57:0,
> from drivers/net/wireless/marvell/mwifiex/init.c:24:
> drivers/net/wireless/marvell/mwifiex/p
Hi Kristian and Bjørn,
Il giorno lun 7 set 2020 alle ore 09:45 Bjørn Mork ha scritto:
>
> Kristian Evensen writes:
>
> > Hi all,
> >
> > I was able to trigger the same issue as reported by Paul, and came
> > across this patch (+ Daniele's other patch and thread on the libqmi
> > mailing list). A
YueHaibing wrote:
> These variables only used in sdio.c, move them to .c file
> can silence these warnings:
>
> In file included from drivers/net/wireless/marvell/mwifiex//main.h:59:0,
> from drivers/net/wireless/marvell/mwifiex//cfp.c:24:
> drivers/net/wireless/marvell/mwifiex/
Mauro Carvalho Chehab wrote:
> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore:
> with it applied, WiFi stops working, and the Kernel starts printing
> this message every second:
>
>wlcore: PHY firmware version: Rev 8.2.0.0.242
>wlcore: firmware booted (Rev 8.9.0.0.79)
Mauro Carvalho Chehab wrote:
> This patch causes a regression betwen Kernel 5.7 and 5.8 at wlcore:
> with it applied, WiFi stops working, and the Kernel starts printing
> this message every second:
>
>wlcore: PHY firmware version: Rev 8.2.0.0.242
>wlcore: firmware booted (Rev 8.9.0.0.79)
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Saturday, September 5, 2020 7:02 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com
Andrii Nakryiko writes:
>> May be we should talk about problem statement and goals.
>> Do we actually need metadata per program or metadata per single .o
>> or metadata per final .o with multiple .o linked together?
>> What is this metadata?
>
> Yep, that's a very valid question. I've also CC'ed
Hi Daniele,
On Mon, Sep 7, 2020 at 10:35 AM Daniele Palmas wrote:
> there was also another recent thread about this and the final plan was
> to simply increase the rx urb size setting to the highest value we are
> aware of (see https://www.spinics.net/lists/linux-usb/msg198858.html):
> this shoul
Hi
> Gesendet: Samstag, 05. September 2020 um 10:45 Uhr
> Von: "Frank Wunderlich"
> similar to bananapi-r2 (mt7530)
...
> reverse-mode:
>
> [ ID] Interval Transfer Bitrate Retr
> [ 5] 0.00-10.01 sec 1.05 GBytes 905 Mbits/sec 14533
> sender <<<
>
Hi Marc,
> -Original Message-
> From: Marc Zyngier
> Sent: Saturday, September 5, 2020 7:33 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com
Dmitry Osipenko wrote:
> This patch fixes SDHCI CRC errors during of RX throughput testing on
> BCM4329 chip if SDIO BUS is clocked above 25MHz. In particular the
> checksum problem is observed on NVIDIA Tegra20 SoCs. The good watermark
> value is borrowed from downstream BCMDHD driver and it's m
On 2020-09-07 09:40, Jianyong Wu wrote:
Hi Marc,
-Original Message-
From: Marc Zyngier
Sent: Saturday, September 5, 2020 7:02 PM
To: Jianyong Wu
Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
t...@linutronix.de; pbonz...@redhat.com;
sean.j.christopher...@intel
On Sun, Sep 6, 2020 at 1:21 AM Xie He wrote:
>
> On Sat, Sep 5, 2020 at 3:24 PM Xie He wrote:
> >
> > Hi Willem,
> >
> > I have a question about the function dev_validate_header used in
> > af_packet.c. Can you help me? Thanks!
> >
> > I see when the length of the data is smaller than hard_header
On Mon, Sep 07, 2020 at 09:19:39AM +0200, Jiri Pirko wrote:
> Mon, Sep 07, 2020 at 08:48:30AM CEST, l...@kernel.org wrote:
> >On Mon, Sep 07, 2020 at 08:21:35AM +0200, Jiri Pirko wrote:
> >> Sun, Sep 06, 2020 at 06:33:05PM CEST, k...@kernel.org wrote:
> >> >On Sun, 6 Sep 2020 10:27:59 +0300 Leon Ro
On Sun, Sep 6, 2020 at 8:42 PM Jakub Kicinski wrote:
>
> On Sat, 5 Sep 2020 14:11:11 +0800 Huazhong Tan wrote:
> > There are two updates relates to UDP GSO.
> > #1 adds a new GSO type for UDPv6
> > #2 adds check for UDP GSO when csum is disable in netdev_fix_features().
> >
> > Changes since RFC V
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, September 7, 2020 4:55 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com; Mark Ru
Hi,
On Sat, Oct 26, 2019 at 3:27 PM Sasha Levin wrote:
>
> From: Daniele Palmas
>
> [ Upstream commit e0ae2c578d3909e60e9448207f5d83f785f1129f ]
>
> This patch adds support for Telit FN980 0x1050 composition
>
> 0x1050: tty, adb, rmnet, tty, tty, tty, tty
>
> Signed-off-by: Daniele Palmas
> Ack
On Sun, Sep 6, 2020 at 5:18 AM Xie He wrote:
>
> This comment is outdated and no longer reflects the actual implementation
> of af_packet.c.
If it was previously true, can you point to a commit that changes the behavior?
>
> Reasons for the new comment:
>
> 1.
>
> In this file, the function pack
commit 77dacc8fc64c ("mwifiex: pcie: Move tables to the only place they're
used")
do the same things.
On 2020/9/7 16:34, Kalle Valo wrote:
> YueHaibing wrote:
>
>> These variables only used in pcie.c, move them to .c file
>> can silence these warnings:
>>
>> In file included from drivers/net
On Wed, Aug 26, 2020 at 02:49:43AM +0100, Dmitry Safonov wrote:
> Changes since v1:
> - reworked patches set to use translator
> - separated the compat layer into xfrm_compat.c,
> compiled under XFRM_USER_COMPAT config
> - 32-bit messages now being sent in frag_list (like wext-core does)
> - inst
On 2020-09-07 10:28, Jianyong Wu wrote:
-Original Message-
From: Marc Zyngier
Sent: Monday, September 7, 2020 4:55 PM
To: Jianyong Wu
[...]
>>arm_smccc_1_1_invoke(ARM_SMCCC_VENDOR_HYP_KVM_FEATUR
>> ES_FUNC_ID,
>> > + &hvc_res);
>> > + if (!(hvc_res.a0 |
We have to use mdb and port entries when sending mdb notifications in
order to fill in all group attributes properly. Before this change we
would've used a fake br_mdb_entry struct to fill in only partial
information about the mdb. Now we can also reuse the mdb dump fill
function and thus have only
This patch adds handling for the ALLOW_NEW_SOURCES IGMPv3/MLDv2 report
types and limits them only when multicast_igmp_version == 3 or
multicast_mld_version == 2 respectively. Now that IGMPv3/MLDv2 handling
functions will be managing timers we need to delay their activation, thus
a new argument is a
Before this patch we'd need 2 cache lines for fast-path, now all used
fields are in the first cache line.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_private.h | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_priv
Hi all,
This patch-set implements the control plane for initial IGMPv3/MLDv2
support which takes care of include/exclude sets and state transitions
based on the different report types.
Patch 01 arranges the structure better by moving the frequently used
fields together, patch 02 factors out the por
Since each entry type has timers that can be running simultaneously we need
to make sure that entries are not freed before their timers have finished.
In order to do that generalize the src gc work to mcast gc work and use a
callback to free the entries (mdb, port group or src).
v3: add IPv6 suppo
In order to process IGMPV3/MLDv2_MODE_IS_INCLUDE/EXCLUDE report types we
need some new helpers which allow us to set/clear flags for all current
entries and later delete marked entries after the report sources have been
processed.
v3: add IPv6/MLDv2 support
v2: drop flag helpers and directly do fl
Support per port group src list (address and timer) and filter mode
dumping. Protected by either multicast_lock or rcu.
v3: add IPv6 support
v2: require RCU or multicast_lock to traverse src groups
Signed-off-by: Nikolay Aleksandrov
---
include/uapi/linux/if_bridge.h | 21 +
net/bridge/
We need to be able to retransmit group-specific and group-and-source
specific queries. The new timer takes care of those.
v3: add IPv6 support
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 73 +--
net/bridge/br_private.h | 8 +
2 f
Initial functions for group source lists which are needed for IGMPv3
and MLDv2 include/exclude lists. Both IPv4 and IPv6 sources are supported.
User-added mdb entries are created with exclude filter mode, we can
extend that later to allow user-supplied mode. When group src entries
are deleted, they
If an expired port group is in EXCLUDE mode, then we have to turn it
into INCLUDE mode, remove all srcs with zero timer and finally remove
the group itself if there are no more srcs with an active timer.
For IGMPv2 use there would be no sources, so this will reduce to just
removing the group as bef
Allows br_multicast_alloc_query to build queries with the port group's
source lists and sends a query for sources over and under lmqt when
necessary as per RFCs 3376 and 3810 with the suppress flag set
appropriately.
v3: add IPv6 support
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mult
When an IGMPv3/MLDv2 query is received and we're operating in such mode
then we need to avoid updating group timers if the suppress flag is set.
Also we should update only timers for groups in exclude mode.
v3: add IPv6/MLDv2 support
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicas
In order to process IGMPV3/MLDv2 CHANGE_TO_INCLUDE/EXCLUDE report types we
need new helpers which allow us to mark entries based on their timer
state and to query only marked entries.
v3: add IPv6/MLDv2 support, fix other_query checks
v2: directly do flag bit operations
Signed-off-by: Nikolay Ale
We already have all necessary helpers, so process IGMPV3/MLDv2
BLOCK_OLD_SOURCES as per the RFCs.
v3: add IPv6/MLDv2 support
v2: directly do flag bit operations
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_multicast.c | 97 +++
1 file changed, 97 inse
In order to avoid future errors and reduce code duplication we should
factor out the port group del sequence. This allows us to have one
function which takes care of all details when removing a port group.
v4: set pg's fast leave flag when deleting due to fast leave
move the patch before addin
This change is in preparation for using the mdb port group entries when
sending a notification, so their full state and additional attributes can
be filled in.
Signed-off-by: Nikolay Aleksandrov
---
net/bridge/br_mdb.c | 20
1 file changed, 8 insertions(+), 12 deletions(-)
> -Original Message-
> From: Marc Zyngier
> Sent: Monday, September 7, 2020 5:47 PM
> To: Jianyong Wu
> Cc: netdev@vger.kernel.org; yangbo...@nxp.com; john.stu...@linaro.org;
> t...@linutronix.de; pbonz...@redhat.com; sean.j.christopher...@intel.com;
> richardcoch...@gmail.com; Mark Ru
These changes were made while debugging the ksz9477 driver for use on a
custom board which uses the ksz9893 switch supported by this driver. The
patches have been runtime tested on top of Linux 5.8.4, I couldn't
runtime test them on top of 5.9-rc3 due to unrelated issues. They have
been build teste
We can't assume that the link partner supports the in-band status
reporting which is enabled by default on the KSZ9893 when using RGMII
for the upstream port.
Signed-off-by: Paul Barker
Reviewed-by: Andrew Lunn
---
drivers/net/dsa/microchip/ksz9477.c | 3 +++
1 file changed, 3 insertions(+)
di
The datasheet for the ksz9893 and ksz9477 switches recommend waiting at
least 100us after the de-assertion of reset before trying to program the
device through any interface.
Also switch the existing msleep() call to usleep_range() as recommended
in Documentation/timers/timers-howto.rst. The 2ms r
Always print the selected phy mode for the CPU port when using the
ksz9477 driver. If the phy mode was changed, also print the previous
mode to aid in debugging.
To make the message more clear, prefix it with the port number which it
applies to and improve the language a little.
Signed-off-by: Pa
To make switch detection more informative print the result of the
ksz9477/ksz9893 compatibility check. With debug output enabled also
print the contents of the Chip ID registers as a 40-bit hex string.
As this detection is the first communication with the switch performed
by the driver, making it
From: Jérôme Pouiller
The statements in wfx_bss_info_changed() has no particular order.
For better readability, group and sort the statements relative to the
association processing.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 53 +++
1 fi
From: Jérôme Pouiller
Struct hif_bss_flags has no reason to exist. In add, it is never used.
Drop it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/stagi
From: Jérôme Pouiller
The structs hif_queue, hif_data_flags, hif_tx_flags and
hif_ht_tx_parameters have no real reasons to exist. Drop them and
simplify access to fields of struct hif_req_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 39 ++--
dr
From: Jérôme Pouiller
Struct hif_map_link_flags has no reason to exist. Drop it and simplify
access to struct hif_req_map_link.
Also rename the field 'map_direction' in 'unmap'. It is more
meaningful and allows to drop enum hif_sta_map_direction.
Signed-off-by: Jérôme Pouiller
---
drivers/sta
From: Jérôme Pouiller
In the wfx driver, the prefix 'hif_mib_' is normally used for structures
that represent a hardware message. hif_mib_tx_rate_retry_policy does not
fall in this category. So, rename it.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_mib.h | 4 ++--
1 file ch
From: Jérôme Pouiller
This struct hif_ie_tlv is definitively an Information Element (IE). This
struct is defined by 802.11 specification and already exists in
mac80211. Reuse this definition instead of struct hif_ie_tlv.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 10
From: Jérôme Pouiller
hif_tx_mib.c contains functions that format data to be sent to the
hardware. In this file, sometime the struct to be sent is named 'arg',
sometime 'val'. In some other function 'val' is used for the argument of
the function.
This patch uniformize the things and choose to ca
From: Jérôme Pouiller
The maximum length of a SSID is defined by 802.11 specification. It is
already defined in mac80211: IEEE80211_MAX_SSID_LEN. Therefore, use this
generic definition.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 8 +++-
drivers/staging/wfx/h
From: Jérôme Pouiller
There is no reason to place two spaces between the field tx_conf_payload
and its type.
In the same vein, remove duplicate empty lines between declarations.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 4 +---
drivers/staging/wfx/hif_api_gene
+ Pablo, netfilter-de...@vger.kernel.org
On Tue, Sep 01, 2020 at 04:56:02PM +0200, Eelco Chaudron wrote:
> The openvswitch module fails initialization when used in a kernel
> without IPv6 enabled. nf_conncount_init() fails because the ct code
> unconditionally tries to initialize the netns IPv6 re
From: Jérôme Pouiller
The union hif_indication_data is never used in the driver. So, it is not
necessary to declare it separately from hif_ind_generic.
In add, drop prefix 'indication_' from the names 'indication_type' and
'indication_data' since it is redundant with the name of the struct.
Sig
From: Jérôme Pouiller
The driver is now close to leave the staging directory. Update the TODO
list to reflect the work done.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/TODO | 19 ---
1 file changed, 19 deletions(-)
diff --git a/drivers/staging/wfx/TODO b/drivers/st
From: Jérôme Pouiller
The union hif_event_data is never used in the driver. So, it is
not necessary to declare it separately from hif_ind_event.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a
From: Jérôme Pouiller
The parameter "async" in wfx_cmd_send() allows to send command without
waiting for the reply. In this case, the mutex hif_cmd.lock is released
asynchronously in the context of the receiver workqueue.
However, "kbuild test robot" complains about this architecture[1] since
it
From: Jérôme Pouiller
The structs hif_capabilities, hif_otp_regul_sel_mode_info and
hif_otp_phy_info have no real reasons to exist. Drop them and simplify
access to fields of struct hif_ind_startup.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 32 +
From: Jérôme Pouiller
The union hif_privacy_key_data is never used in the driver. So, it is
not necessary to declare it separately from hif_req_add_key.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 24 +++-
1 file changed, 11 insertions(+), 13 dele
From: Jérôme Pouiller
The structs hif_scan_type, hif_scan_flags and hif_auto_scan_param have
no real reasons to exist (apart maybe defining namespaces). Moreover,
the names of the fields within these structs are not all meaningful.
Drop the structs and rename the fields.
Signed-off-by: Jérôme P
From: Jérôme Pouiller
Struct hif_pm_mode has no reason to exist. Drop it and simplify access
to struct hif_req_set_pm_mode.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
drivers/staging/wfx/hif_tx.c | 4 ++--
2 files changed, 3 insertions(+), 7 deletions
From: Jérôme Pouiller
Struct hif_suspend_resume_flags has no reason to exist. Drop it and
simplify access to struct hif_ind_suspend_resume_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +-
drivers/staging/wfx/hif_rx.c | 6 +++---
2 files changed, 4 inser
From: Jérôme Pouiller
Enum hif_beacon is not used. Moreover, it is just another definition of
a boolean. Absolutely useless.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers
From: Jérôme Pouiller
wfx_join() and wfx_join_finalize() are the two halves of the association
process. Group them.
In addition, for better uniformity of the code, rename wfx_do_join() in
wfx_join().
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/sta.c | 100 +++---
From: Jérôme Pouiller
Struct hif_tx_result_flags has no reason to exist. Drop it and simplify
access to struct hif_cnf_tx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_tx.c | 3 +--
drivers/staging/wfx/hif_api_cmd.h | 16 ++--
2 files changed, 7 insertions(+), 1
From: Jérôme Pouiller
Struct hif_reset_flags has no reason to exist. Drop it and simplify
access to struct hif_req_reset.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 +++---
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
From: Jérôme Pouiller
Struct hif_ie_flags has no reason to exist. Drop it and simplify
access to struct hif_req_update_ie.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 14 +-
drivers/staging/wfx/hif_tx.c | 2 +-
2 files changed, 6 insertions(+), 10 d
From: Jérôme Pouiller
Struct hif_join_flags has no reason to exist. Drop it and simplify
access to struct hif_req_join.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/w
From: Jérôme Pouiller
Struct hif_rx_flags has no reason to exist. Drop it and simplify access
to struct hif_ind_rx.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/data_rx.c | 2 +-
drivers/staging/wfx/hif_api_cmd.h | 25 ++---
2 files changed, 11 insertions(+),
From: Jérôme Pouiller
Union hif_commands_ids is unused.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_cmd.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/wfx/hif_api_cmd.h
b/drivers/staging/wfx/hif_api_cmd.h
index 75e8c2a7fdf9..c132d8e43b50 100644
-
From: Jérôme Pouiller
A new kind of error has appeared in API 3.4.
The Linux driver is not concerned by this new error, but let's keep the
API in sync with the firmware.
Signed-off-by: Jérôme Pouiller
---
drivers/staging/wfx/hif_api_general.h | 1 +
drivers/staging/wfx/hif_rx.c | 2 +
From: Jérôme Pouiller
The file hif_tx_mib.c expects to contain functions that format messages
for the hardware. It is unexpected to find function that manipulate
RCU and structures from mac80211.
Keep hif_set_association_mode() with the code necessary for message
formatting and relocate the smar
In mptcp_pm_nl_get_local_id, skc_local is the same as msk_local, so it
always return 0. Thus every subflow's local_id is 0. It's incorrect.
This patch fixed this issue.
Also, we need to ignore the zero address here, like 0.0.0.0 in IPv4. When
we use the zero address as a local address, it means t
From: Jérôme Pouiller
Since the code for multicast filtering has been dropped, the function
hif_set_data_filtering() is only called to disable multicast filtering.
In fact, the multicast filtering is already disabled by default. So,
this function is useless and can be dropped.
Signed-off-by: Jér
From: Jérôme Pouiller
The Secure Link (slk) feature allows to encrypt (and authenticate) the
traffic between the host and the device. The official implementation of
this feature relies on mbedTLS. For that reason, this implementation is
not included in the current driver. To be included, the impl
1 - 100 of 401 matches
Mail list logo
