[PATCH 10/29] iwlwifi: mvm: utils: Fix some doc-rot

2020-09-09 Thread Lee Jones
Fix misnamed, and missing descriptions likely due to doc-rot. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/utils.c:669: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_send_lq_cmd' drivers/net/wireless/intel/iwlwifi/mvm/utils.c:6

[PATCH 15/29] iwlwifi: iwl-drv: Provide descriptions debugfs dentries

2020-09-09 Thread Lee Jones
Also demote a non-conforming kernel-doc function header. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-drv.c:124: warning: Function parameter or member 'dbgfs_drv' not described in 'iwl_drv' drivers/net/wireless/intel/iwlwifi/iwl-drv.c:124: warning: Fu

[PATCH 09/29] iwlwifi: dvm: Demote a couple of nonconformant kernel-doc headers

2020-09-09 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/rx.c:145: warning: Function parameter or member 'priv' not described in 'iwlagn_good_plcp_health' drivers/net/wireless/intel/iwlwifi/dvm/rx.c:145: warning: Function parameter or member 'cur_ofdm' not descri

[PATCH 04/29] iwlwifi: dvm: lib: Demote non-compliant kernel-doc headers

2020-09-09 Thread Lee Jones
Neither of these headers attempt to document any function parameters. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/lib.c:121: warning: Function parameter or member 'priv' not described in 'iwlagn_txfifo_flush' drivers/net/wireless/intel/iwlwifi/dvm/li

[PATCH 05/29] iwlwifi: calib: Demote seemingly unintentional kerneldoc header

2020-09-09 Thread Lee Jones
This is the only use of kerneldoc in the sourcefile and no descriptions are provided. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/calib.c:770: warning: Function parameter or member 'priv' not described in 'iwl_find_disconn_antenna' drivers/net/wirele

[PATCH 01/29] iwlwifi: dvm: Demote non-compliant kernel-doc headers

2020-09-09 Thread Lee Jones
None of these headers attempt to document any function parameters. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/dvm/main.c:388: warning: Function parameter or member 't' not described in 'iwl_bg_statistics_periodic' drivers/net/wireless/intel/iwlwifi/dvm/

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Wolfram Sang
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c > index e32ef3f01fe8..b13b1cbcac29 100644 > --- a/drivers/i2c/busses/i2c-i801.c > +++ b/drivers/i2c/busses/i2c-i801.c > @@ -1785,7 +1785,7 @@ static int i801_probe(struct pci_dev *dev, const struct > pci_device_id *id) >

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Jiri Pirko
Wed, Sep 09, 2020 at 03:27:19PM CEST, mo...@nvidia.com wrote: > >On 9/7/2020 8:58 PM, Jakub Kicinski wrote: >> On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: >> > > In that sense I don't like --live because it doesn't really say much. >> > > AFAIU it means 1) no link flap; 2) < 2 sec datapa

RE: [EXT] Re: [PATCH rdma-next 0/8] RDMA/qedr: various fixes

2020-09-09 Thread Michal Kalderon
> From: Jason Gunthorpe > Sent: Wednesday, September 9, 2020 10:15 PM > On Wed, Sep 02, 2020 at 07:57:33PM +0300, Michal Kalderon wrote: > > This set addresses several issues that were observed and reproduced on > > different test and production configurations. > > > > Dave, Jason, > > There is on

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Mauro Carvalho Chehab
Em Wed, 09 Sep 2020 13:06:39 -0700 Joe Perches escreveu: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is b

Re: [PATCH net-next RFC v1 2/4] devlink: Add devlink traps under devlink_ports context

2020-09-09 Thread Aya Levin
On 9/8/2020 5:04 PM, Jiri Pirko wrote: Sun, Sep 06, 2020 at 05:44:28PM CEST, ido...@idosch.org wrote: On Wed, Sep 02, 2020 at 06:32:12PM +0300, Aya Levin wrote: [...] I understand how this struct allows you to re-use a lot of code between per-device and per-port traps, but it's mainly en

[PATCH v3 2/2] Bluetooth: sco: new getsockopt options BT_SNDMTU/BT_RCVMTU

2020-09-09 Thread Joseph Hwang
This patch defines new getsockopt options BT_SNDMTU/BT_RCVMTU for SCO socket to be compatible with other bluetooth sockets. These new options return the same value as option SCO_OPTIONS which is already present on existing kernels. Reviewed-by: Alain Michaud Reviewed-by: Abhishek Pandit-Subedi S

[PATCH v3 1/2] Bluetooth: btusb: define HCI packet sizes of USB Alts

2020-09-09 Thread Joseph Hwang
It is desirable to define the HCI packet payload sizes of USB alternate settings so that they can be exposed to user space. Reviewed-by: Alain Michaud Reviewed-by: Abhishek Pandit-Subedi Signed-off-by: Joseph Hwang --- Changes in v3: - Set hdev->sco_mtu to rp->sco_mtu if the latter is smaller.

[PATCH v3 0/2] To support the HFP WBS, a chip vendor may choose a particular

2020-09-09 Thread Joseph Hwang
USB alternate seeting of which the packet size is distinct. The patches are to expose the packet size to user space so that the user space does not need to hard code those values. We have verified this patch on Chromebooks which use - Realtek 8822CE controller with USB alt setting 1 - Intel contro

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-09-09 Thread Anmol Karn
On Wed, Sep 09, 2020 at 10:06:59PM -0700, Eric Biggers wrote: > On Thu, Sep 10, 2020 at 10:04:24AM +0530, Anmol Karn wrote: > > Prevent hci_phy_link_complete_evt() from dereferencing 'hcon->amp_mgr' > > as NULL. Fix it by adding pointer check for it. > > > > Reported-and-tested-by: > > syzbot+0be

[PATCH net v2] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-09 Thread Xie He
The difference between hard_header_len and needed_headroom has long been confusing to driver developers. Let's clarify it. The understanding on this issue in this patch is based on the following reasons: 1. In af_packet.c, the function packet_snd first reserves a headroom of length (dev->hard_he

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-09 Thread Alexei Starovoitov
On Wed, Sep 9, 2020 at 8:30 PM David Ahern wrote: > > > > I think the packets modification (edit dst mac, add vlan tag, etc) should be > > done on egress, which rely on David's XDP egress support. > > agreed. The DEVMAP used for redirect can have programs attached that > update the packet headers

Re: [PATCH net-next 0/4] tcp: increase flexibility of EBPF congestion control initialization

2020-09-09 Thread Alexei Starovoitov
On Wed, Sep 9, 2020 at 8:24 PM Neal Cardwell wrote: > > On Wed, Sep 9, 2020 at 8:36 PM Martin KaFai Lau wrote: > > > > On Wed, Sep 09, 2020 at 02:15:52PM -0400, Neal Cardwell wrote: > > > This patch series reorganizes TCP congestion control initialization so > > > that if > > > EBPF code called

Re: [PATCH net-next RFC v3 01/14] devlink: Add reload action option to devlink reload command

2020-09-09 Thread Vasundhara Volam
On Wed, Sep 9, 2020 at 10:51 PM Moshe Shemesh wrote: > > > On 9/7/2020 8:58 PM, Jakub Kicinski wrote: > > On Mon, 7 Sep 2020 16:46:01 +0300 Moshe Shemesh wrote: > >>> In that sense I don't like --live because it doesn't really say much. > >>> AFAIU it means 1) no link flap; 2) < 2 sec datapath dow

Re: [PATCH net-next 0/4] tcp: increase flexibility of EBPF congestion control initialization

2020-09-09 Thread Martin KaFai Lau
On Wed, Sep 09, 2020 at 11:21:50PM -0400, Neal Cardwell wrote: > On Wed, Sep 9, 2020 at 8:36 PM Martin KaFai Lau wrote: > > > > On Wed, Sep 09, 2020 at 02:15:52PM -0400, Neal Cardwell wrote: > > > This patch series reorganizes TCP congestion control initialization so > > > that if > > > EBPF code

Re: [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-09-09 Thread Eric Biggers
On Thu, Sep 10, 2020 at 10:04:24AM +0530, Anmol Karn wrote: > Prevent hci_phy_link_complete_evt() from dereferencing 'hcon->amp_mgr' > as NULL. Fix it by adding pointer check for it. > > Reported-and-tested-by: syzbot+0bef568258653cff2...@syzkaller.appspotmail.com > Link: https://syzkaller.appspot

BUG: stack guard page was hit in validate_chain (2)

2020-09-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:9322c47b Merge tag 'xfs-5.9-fixes-2' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1142839590 kernel config: https://syzkaller.appspot.com/x/.config?x=e1c560d0f4e121c9 das

[Linux-kernel-mentees] [PATCH] net: bluetooth: Fix null pointer dereference in hci_event_packet()

2020-09-09 Thread Anmol Karn
Prevent hci_phy_link_complete_evt() from dereferencing 'hcon->amp_mgr' as NULL. Fix it by adding pointer check for it. Reported-and-tested-by: syzbot+0bef568258653cff2...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=0bef568258653cff272f Signed-off-by: Anmol Karn --- ne

[PATCH] brcmsmac: phytbl_lcn: Remove unused variable 'dot11lcn_gain_tbl_rev1'

2020-09-09 Thread YueHaibing
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c:108:18: warning: ‘dot11lcn_gain_tbl_rev1’ defined but not used [-Wunused-const-variable=] static const u32 dot11lcn_gain_tbl_rev1[] = { ^~ commit ebcfc66f56a4 ("brcmsmac: phytbl_lcn: Remove u

[PATCH] brcmsmac: phy_lcn: Remove unused variable lcnphy_rx_iqcomp_table_rev0

2020-09-09 Thread YueHaibing
drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c:361:25: warning: ‘lcnphy_rx_iqcomp_table_rev0’ defined but not used [-Wunused-const-variable=] struct lcnphy_rx_iqcomp lcnphy_rx_iqcomp_table_rev0[] = { ^~~ commit 38c95e0258a0 ("brcms

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-09 Thread David Ahern
On 9/9/20 8:35 PM, Hangbin Liu wrote: > Hi Alexei, > > On Wed, Sep 09, 2020 at 02:52:06PM -0700, Alexei Starovoitov wrote: >> On Mon, Sep 07, 2020 at 04:27:21PM +0800, Hangbin Liu wrote: >>> This patch is for xdp multicast support. which has been discussed >>> before[0], The goal is to be able to

Re: [net-next v4 1/5] devlink: check flash_update parameter support in net core

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:49 -0700 Jacob Keller wrote: > + if (!(supported_params & > DEVLINK_SUPPORT_FLASH_UPDATE_COMPONENT)) { > + NL_SET_ERR_MSG_ATTR(info->extack, nla_component, > + "component update is not > supported");

Re: [PATCH] vhost-vdpa: fix memory leak in error path

2020-09-09 Thread Jason Wang
On 2020/9/9 下午11:41, Li Qiang wrote: Free the 'page_list' when the 'npages' is zero. Signed-off-by: Li Qiang --- drivers/vhost/vdpa.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c index 3fab94f88894..6a9fcaf1831d 100

[PATCH v3 net-next 0/9] mv88e6xxx: Add devlink regions support

2020-09-09 Thread Andrew Lunn
Make use of devlink regions to allow read access to some of the internal of the switches. Currently access to global1, global2 and the ATU is provided. The switch itself will never trigger a region snapshot, it is assumed it is performed from user space as needed. v2: Remove left of debug print C

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread Shannon Nelson
On 9/9/20 12:22 PM, Jakub Kicinski wrote: On Wed, 9 Sep 2020 10:58:19 -0700 Shannon Nelson wrote: I'm suggesting that this implementation using the existing devlink logging services should suffice until someone can design, implement, and get accepted a different bit of plumbing.  Unfortunately,

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: > The devlink core recently gained support for checking whether the driver > supports a flash_update parameter, via `supported_flash_update_params`. > However, parameters are specified as function arguments. Adding a new > parameter still requi

Re: [net-next v4 3/5] devlink: introduce flash update overwrite mask

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:51 -0700 Jacob Keller wrote: > diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h > index 40d35145c879..19a573566359 100644 > --- a/include/uapi/linux/devlink.h > +++ b/include/uapi/linux/devlink.h > @@ -228,6 +228,28 @@ enum { > DEVLINK_ATTR_ST

[PATCH v3 net-next 8/9] net: dsa: wire up devlink info get

2020-09-09 Thread Andrew Lunn
Allow the DSA drivers to implement the devlink call to get info info, e.g. driver name, firmware version, ASIC ID, etc. v2: Combine declaration and the assignment on a single line. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 5 - net/dsa/dsa2.c| 19 --- 2 files c

[PATCH v3 net-next 1/9] net: devlink: regions: Add a priv member to the regions ops struct

2020-09-09 Thread Andrew Lunn
The driver may have multiple regions which can be dumped using one function. However, for this to work, additional information is needed. Add a priv member to the ops structure for the driver to use however it likes. Signed-off-by: Andrew Lunn --- include/net/devlink.h | 2 ++ 1 file changed, 2

[PATCH v3 net-next 5/9] net: dsa: mv88e6xxx: Move devlink code into its own file

2020-09-09 Thread Andrew Lunn
There will soon be more devlink code. Move the existing code into a file of its own, before we start adding this new code. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/Makefile | 1 + drivers/net/dsa/mv88e6xxx/chip.c| 255 +-- drivers/net/dsa/mv88e6xxx/

[PATCH net-next] net: stmmac: Remove unused variable 'ret' at stmmac_rx_buf1_len()

2020-09-09 Thread Luo Jiaxing
Fixes the following warning when using W=1 to build kernel: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret, coe = priv->hw->rx_csum; When digging stmmac_get_rx_header_len(), dwmac4_get_rx_header_len() and dwx

Re: [mptcp] db71a2f198: WARNING:inconsistent_lock_state

2020-09-09 Thread Geliang Tang
kernel test robot 于2020年9月10日周四 上午8:19写道: > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: db71a2f198fef53a9f710ad5ac475bbdb6aba840 ("[MPTCP][PATCH v2 net 1/2] > mptcp: fix subflow's local_id issues") > url: > https://github.com/0day-ci/linux/commits/Geliang

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-09 Thread Hangbin Liu
Hi Alexei, On Wed, Sep 09, 2020 at 02:52:06PM -0700, Alexei Starovoitov wrote: > On Mon, Sep 07, 2020 at 04:27:21PM +0800, Hangbin Liu wrote: > > This patch is for xdp multicast support. which has been discussed > > before[0], The goal is to be able to implement an OVS-like data plane in > > XDP,

Re: [PATCH net-next v1 2/3] net: phy: add API for LEDs controlled by ethernet PHY chips

2020-09-09 Thread kernel test robot
t.git 81365af13a5630673c49bfad9b24cf415e9576f6 config: arm-randconfig-r036-20200909 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 8893d0816ccdf8998d2e21b5430e9d6abe7ef465) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Joe Perches
On Wed, 2020-09-09 at 19:36 -0300, Jason Gunthorpe wrote: > On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the next label is

Re: INFO: rcu detected stall in cleanup_net (4)

2020-09-09 Thread Jakub Kicinski
On Wed, 09 Sep 2020 14:54:36 -0700 Vinicius Costa Gomes wrote: > > Vinicius, could you please take a look at all the syzbot reports which > > point to your commit? I know syzbot bisection is not super reliable, > > but at least 3 reports point to your commit now, so something's > > probably going o

RE: [PATCH v2] net: phy: call phy_disable_interrupts() in phy_attach_direct() instead

2020-09-09 Thread Yoshihiro Shimoda
Hi Andrew, > From: Andrew Lunn, Sent: Wednesday, September 9, 2020 10:47 PM > > On Wed, Sep 09, 2020 at 04:18:56AM +, Yoshihiro Shimoda wrote: > > Hi David, > > > > > From: David Miller, Sent: Wednesday, September 9, 2020 12:25 PM > > > > > > From: Yoshihiro Shimoda > > > Date: Wed, 9 Sep 2

[net 2/4] i40e: always propagate error value in i40e_set_vsi_promisc()

2020-09-09 Thread Tony Nguyen
From: Stefan Assmann The for loop in i40e_set_vsi_promisc() reports errors via dev_err() but does not propagate the error up the call chain. Instead it continues the loop and potentially overwrites the reported error value. This results in the error being recorded in the log buffer, but the calle

[net 1/4] i40e: fix return of uninitialized aq_ret in i40e_set_vsi_promisc

2020-09-09 Thread Tony Nguyen
From: Stefan Assmann drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c: In function ‘i40e_set_vsi_promisc’: drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c:1176:14: error: ‘aq_ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized] i40e_status aq_ret; In case the co

[PATCH net v1] taprio: Fix allowing too small intervals

2020-09-09 Thread Vinicius Costa Gomes
It's possible that the user specifies an interval that couldn't allow any packet to be transmitted. This also avoids the issue of the hrtimer handler starving the other threads because it's running too often. The solution is to reject interval sizes that according to the current link speed wouldn'

[net 4/4] igc: Fix not considering the TX delay for timestamps

2020-09-09 Thread Tony Nguyen
From: Vinicius Costa Gomes When timestamping a packet there's a delay between the start of the packet and the point where the hardware actually captures the timestamp. This difference needs to be considered if we want accurate timestamps. This was done on the RX side, but not on the TX side. Fi

[net 0/4][pull request] Intel Wired LAN Driver Updates 2020-09-09

2020-09-09 Thread Tony Nguyen
This series contains updates to i40e and igc drivers. Stefan Assmann changes num_vlans to u16 to fix may be used uninitialized error and propagates error in i40_set_vsi_promisc() for i40e. Vinicius corrects timestamping latency values for i225 devices and accounts for TX timestamping delay for ig

[PATCH v3 net-next 2/9] net: devlink: region: Pass the region ops to the snapshot function

2020-09-09 Thread Andrew Lunn
Pass the region to be snapshotted to the function performing the snapshot. This allows one function to operate on numerous regions. Signed-off-by: Andrew Lunn --- drivers/net/ethernet/intel/ice/ice_devlink.c | 2 ++ drivers/net/netdevsim/dev.c | 6 -- include/net/devlink.h

[PATCH net] net: Clarify the difference between hard_header_len and needed_headroom

2020-09-09 Thread Xie He
The difference between hard_header_len and needed_headroom has long been confusing to driver developers. Let's clarify it. The understanding of the difference in this patch is based on the following reasons: 1. In this file, the function packet_snd first reserves a headroom of length (dev->hard_

[PATCH v3 net-next 6/9] net: dsa: mv88e6xxx: Create helper for FIDs in use

2020-09-09 Thread Andrew Lunn
Refactor the code in mv88e6xxx_atu_new() which builds a bitmaps of FIDs in use into a helper function. This will be reused by the devlink code when dumping the ATU. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 20 drivers/net/dsa/mv88e6xxx/chip.h | 2 ++

[PATCH] Bluetooth: Re-order clearing suspend tasks

2020-09-09 Thread Abhishek Pandit-Subedi
Unregister_pm_notifier is a blocking call so suspend tasks should be cleared beforehand. Otherwise, the notifier will wait for completion before returning (and we encounter a 2s timeout on resume). Fixes: 0e9952804ec9c8 (Bluetooth: Clear suspend tasks on unregister) Signed-off-by: Abhishek Pandit-

[PATCH v3 net-next 3/9] net: dsa: Add helper to convert from devlink to ds

2020-09-09 Thread Andrew Lunn
Given a devlink instance, return the dsa switch it is associated to. Reviewed-by: Florian Fainelli Signed-off-by: Andrew Lunn --- include/net/dsa.h | 7 +++ net/dsa/dsa.c | 12 ++-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/include/net/dsa.h b/include/net/

[PATCH v3 net-next 9/9] net: dsa: mv88e6xxx: Implement devlink info get callback

2020-09-09 Thread Andrew Lunn
Return the driver name and the asic.id with the switch name. Reviewed-by: Jakub Kicinski Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c| 1 + drivers/net/dsa/mv88e6xxx/devlink.c | 16 drivers/net/dsa/mv88e6xxx/devlink.h | 3 +++ 3 files changed, 20 insert

Re: [net-next v4 5/5] ice: add support for flash update overwrite mask

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:53 -0700 Jacob Keller wrote: > Support the recently added DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK > parameter in the ice flash update handler. Convert the overwrite mask > bitfield into the appropriate preservation level used by the firmware > when updating. > > Because

[PATCH v3 net-next 7/9] net: dsa: mv88e6xxx: Add devlink regions

2020-09-09 Thread Andrew Lunn
Allow the global registers, and the ATU to be snapshot via devlink regions. It is later planned to add support for the port registers. v2: Remove left over debug prints Comment ATU format is generic for mv88e6xxx, not wider v3: Make use of ops structure passed to snapshot function Remove port reg

[PATCH v3 net-next 4/9] net: dsa: Add devlink regions support to DSA

2020-09-09 Thread Andrew Lunn
Allow DSA drivers to make use of devlink regions, via simple wrappers. Signed-off-by: Andrew Lunn --- include/net/dsa.h | 6 ++ net/dsa/dsa.c | 16 2 files changed, 22 insertions(+) diff --git a/include/net/dsa.h b/include/net/dsa.h index 42ae6d4d9d43..431efb5098be 100

Re: [PATCH net-next 3/4] tcp: simplify tcp_set_congestion_control(): always reinitialize

2020-09-09 Thread Martin KaFai Lau
On Wed, Sep 09, 2020 at 02:15:55PM -0400, Neal Cardwell wrote: > Now that the previous patches ensure that all call sites for > tcp_set_congestion_control() want to initialize congestion control, we > can simplify tcp_set_congestion_control() by removing the reinit > argument and the code to suppor

Re: [net-next v4 4/5] devlink: add support for overwrite mask to netdevsim

2020-09-09 Thread Jakub Kicinski
On Wed, 9 Sep 2020 15:26:52 -0700 Jacob Keller wrote: > The devlink interface recently gained support for a new "overwrite mask" > parameter that allows specifying how various sub-sections of a flash > component are modified when updating. > > Add support for this to netdevsim, to enable easily t

[PATCH] Bluetooth: Re-order clearing suspend tasks

2020-09-09 Thread Abhishek Pandit-Subedi
Unregister_pm_notifier is a blocking call so suspend tasks should be cleared beforehand. Otherwise, the notifier will wait for completion before returning (and we encounter a 2s timeout on resume). Fixes: 0e9952804ec9c8 (Bluetooth: Clear suspend tasks on unregister) Signed-off-by: Abhishek Pandit-

Re: [PATCH net-next 0/4] tcp: increase flexibility of EBPF congestion control initialization

2020-09-09 Thread Martin KaFai Lau
On Wed, Sep 09, 2020 at 02:15:52PM -0400, Neal Cardwell wrote: > This patch series reorganizes TCP congestion control initialization so that if > EBPF code called by tcp_init_transfer() sets the congestion control algorithm > by calling setsockopt(TCP_CONGESTION) then the TCP stack initializes the

Re: [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs

2020-09-09 Thread Andrew Lunn
> They are in /sys/class/net/eth0/phydev/leds by default, because they > are children of the PHY device and are of `leds` class, and the PHY > subsystem creates a symlink `phydev` when PHY is attached to the > interface. > They are in /sys/class/leds/ as symlinks, because AFAIK everything in > /sys

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-09 Thread Jason Gunthorpe
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

[iproute2-next v4 2/2] devlink: support setting the overwrite mask

2020-09-09 Thread Jacob Keller
Add support for specifying the overwrite sections to allow in the flash update command. This is done by adding a new "overwrite" option which can take either "settings" or "identifiers" passing the overwrite mode multiple times will combine the fields using bitwise-OR. Signed-off-by: Jacob Keller

[iproute2-next v4 0/2] devlink: add flash update overwrite mask

2020-09-09 Thread Jacob Keller
This series implements the iproute2 side of the new DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is used to allow userspace to indicate what a device should do with various subsections of a flash component when updating. For example, a flash component might contain vital data such as t

[iproute2-next v4 1/2] Update devlink header for overwrite mask attribute

2020-09-09 Thread Jacob Keller
Signed-off-by: Jacob Keller --- include/uapi/linux/devlink.h | 27 +++ 1 file changed, 27 insertions(+) diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h index b7f23faae901..dc267058600d 100644 --- a/include/uapi/linux/devlink.h +++ b/include/uapi/l

[net-next v4 5/5] ice: add support for flash update overwrite mask

2020-09-09 Thread Jacob Keller
Support the recently added DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK parameter in the ice flash update handler. Convert the overwrite mask bitfield into the appropriate preservation level used by the firmware when updating. Because there is no equivalent preservation level for overwriting only iden

[net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-09 Thread Jacob Keller
The devlink core recently gained support for checking whether the driver supports a flash_update parameter, via `supported_flash_update_params`. However, parameters are specified as function arguments. Adding a new parameter still requires modifying the signature of the .flash_update callback in al

[net-next v4 4/5] devlink: add support for overwrite mask to netdevsim

2020-09-09 Thread Jacob Keller
The devlink interface recently gained support for a new "overwrite mask" parameter that allows specifying how various sub-sections of a flash component are modified when updating. Add support for this to netdevsim, to enable easily testing the interface. Make the allowed overwrite mask values cont

[net-next v4 3/5] devlink: introduce flash update overwrite mask

2020-09-09 Thread Jacob Keller
Sections of device flash may contain settings or device identifying information. When performing a flash update, it is generally expected that these settings and identifiers are not overwritten. However, it may sometimes be useful to allow overwriting these fields when performing a flash update. S

[net-next v4 0/5] devlink flash update overwrite mask

2020-09-09 Thread Jacob Keller
This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a bitfield which allows userspace to specify what set of subfields to overwrite when performing a flash update for a device. The intention is to support the

[net-next v4 1/5] devlink: check flash_update parameter support in net core

2020-09-09 Thread Jacob Keller
When implementing .flash_update, drivers which do not support per-component update are manually checking the component parameter to verify that it is NULL. Without this check, the driver might accept an update request with a component specified even though it will not honor such a request. Instead

Re: [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware

2020-09-09 Thread Pavel Machek
On Thu 2020-09-10 00:15:26, Marek Behun wrote: > On Wed, 9 Sep 2020 23:40:09 +0200 > Pavel Machek wrote: > > > > > > > > > 80 columns :-) (and please fix that globally, at least at places where > > > > it is easy, like comments). > > > > > > > > > > Linux is at 100 columns now since commit b

[PATCH ethtool] tunnels: implement new --show-tunnels command

2020-09-09 Thread Jakub Kicinski
Add support for the new show-tunnels command. Support dump. # ethtool --show-tunnels \* Tunnel information for eth0: UDP port table 0: Size: 4 Types: vxlan No entries UDP port table 1: Size: 4 Types: geneve, vxlan-gpe Entries (2): port 1230, vxlan-gpe p

Re: [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 23:40:09 +0200 Pavel Machek wrote: > > > > > > 80 columns :-) (and please fix that globally, at least at places where > > > it is easy, like comments). > > > > > > > Linux is at 100 columns now since commit bdc48fa11e46, commited by > > Linus. See > > https://git.kernel.or

Re: [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 23:42:59 +0200 Andrew Lunn wrote: > On Wed, Sep 09, 2020 at 06:25:45PM +0200, Marek Behún wrote: > > Hello Andrew and Pavel, > > > > please review these patches adding support for HW controlled LEDs. > > The main difference from previous version is that the API is now generali

Re: [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 15:15:52 -0600 Rob Herring wrote: > On Wed, Sep 09, 2020 at 06:25:46PM +0200, Marek Behún wrote: > > Document binding for LEDs connected to and controlled by various chips > > (such as ethernet PHY chips). > > If they are h/w controlled, then why are they in DT? The idea is

Re: INFO: rcu detected stall in cleanup_net (4)

2020-09-09 Thread Vinicius Costa Gomes
Hi Jakub, Jakub Kicinski writes: > On Tue, 08 Sep 2020 22:29:21 -0700 syzbot wrote: >> Hello, >> >> syzbot found the following issue on: >> >> HEAD commit:59126901 Merge tag 'perf-tools-fixes-for-v5.9-2020-09-03' .. >> git tree: upstream >> console output: https://syzkaller.appspot.c

Re: [PATCHv11 bpf-next 2/5] xdp: add a new helper for dev map multicast support

2020-09-09 Thread Alexei Starovoitov
On Mon, Sep 07, 2020 at 04:27:21PM +0800, Hangbin Liu wrote: > This patch is for xdp multicast support. which has been discussed > before[0], The goal is to be able to implement an OVS-like data plane in > XDP, i.e., a software switch that can forward XDP frames to multiple ports. > > To achieve t

Re: [PATCH net-next + leds v2 0/7] PLEASE REVIEW: Add support for LEDs on Marvell PHYs

2020-09-09 Thread Andrew Lunn
On Wed, Sep 09, 2020 at 06:25:45PM +0200, Marek Behún wrote: > Hello Andrew and Pavel, > > please review these patches adding support for HW controlled LEDs. > The main difference from previous version is that the API is now generalized > and lives in drivers/leds, so that part needs to be reviewe

Re: [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 15:31:22 -0600 Rob Herring wrote: > On Wed, Sep 09, 2020 at 11:07:26PM +0200, Marek Behun wrote: > > On Wed, 9 Sep 2020 14:59:23 -0600 > > Rob Herring wrote: > > > > > > > > > > I don't know :) I copied this from other drivers, I once tried setting > > > > up environment f

Re: [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware

2020-09-09 Thread Pavel Machek
Hi! > > > Many an ethernet PHY (and other chips) supports various HW control modes > > > for LEDs connected directly to them. > > > > I guess this should be > > > > "Many ethernet PHYs (and other chips) support various HW control modes > > for LEDs connected directly to them." > > > > I gues

Re: [PATCH net-next 0/6] chelsio/chtls:Fix inline tls bugs

2020-09-09 Thread David Miller
From: Vinay Kumar Yadav Date: Thu, 10 Sep 2020 01:55:34 +0530 > Sending bug fixes in net-next tree because chtls directory restructure > changes is available only in net-next not in net. Since when is file movement a reason to not submit bugs to the correct tree? I'm not doing this sorry, pleas

Re: [net-next V2 03/12] net/mlx5e: Move mlx5e_tx_wqe_inline_mode to en_tx.c

2020-09-09 Thread David Miller
From: Saeed Mahameed Date: Wed, 9 Sep 2020 19:22:02 + > Maxim really tried here to avoid this without huge performance > degradation (~6.4% reduce in packet rate), due to the refactoring > patches gcc yields non optimal code, as we explained in the commit > messages and cover-letter > > Our

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-09 Thread David Miller
From: Allen Date: Thu, 10 Sep 2020 00:06:47 +0530 >> >> > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device *data, >> > unsigned int txqueue) >> > } >> > >> > >> > -static void ace_tasklet(unsigned long arg) >> > +static void ace_tasklet(struct tasklet_struct *t) >> > { >> > -

Re: [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs

2020-09-09 Thread Rob Herring
On Wed, Sep 09, 2020 at 11:07:26PM +0200, Marek Behun wrote: > On Wed, 9 Sep 2020 14:59:23 -0600 > Rob Herring wrote: > > > > > > > I don't know :) I copied this from other drivers, I once tried setting > > > up environment for doing checking of device trees with YAML schemas, > > > and it was a

Re: [PATCH v3 net-next 2/2] ionic: add devlink firmware update

2020-09-09 Thread David Miller
From: Shannon Nelson Date: Wed, 9 Sep 2020 10:58:19 -0700 > I'm suggesting that this implementation using the existing devlink > logging services should suffice until someone can design, implement, > and get accepted a different bit of plumbing.  Unfortunately, that's > not a job that I can get t

Re: [PATCH net-next v2] net: dsa: b53: Report VLAN table occupancy via devlink

2020-09-09 Thread David Miller
From: Florian Fainelli Date: Wed, 9 Sep 2020 10:49:31 -0700 > We already maintain an array of VLANs used by the switch so we can > simply iterate over it to report the occupancy via devlink. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH v3 net 0/3] net: qed disable aRFS in NPAR and 100G

2020-09-09 Thread David Miller
From: Igor Russkikh Date: Wed, 9 Sep 2020 20:43:07 +0300 > This patchset fixes some recent issues found by customers. > > v3: > resending on Dmitry's behalf > > v2: > correct hash in Fixes tag Series applied, thank you.

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-09 Thread Alex Elder
On 9/9/20 4:14 PM, David Miller wrote: From: Alex Elder Date: Wed, 9 Sep 2020 08:43:44 -0500 There is exactly one reference here; the "reference" is essentially a Boolean flag. So the value is always either 0 or 1. Aha, then why not use a bitmask and test_and_set_bit() et al.? OK I'll go

Re: [PATCH net-next v4 0/6] Marvell PP2.2 PTP support

2020-09-09 Thread David Miller
From: Russell King - ARM Linux admin Date: Wed, 9 Sep 2020 17:25:02 +0100 > This series adds PTP support for PP2.2 hardware to the mvpp2 driver. > Tested on the Macchiatobin eth1 port. > > Note that on the Macchiatobin, eth0 uses a separate TAI block from > eth1, and there is no hardware synchro

Re: [PATCH net-next v3 0/6] devlink show controller number

2020-09-09 Thread David Miller
From: Jakub Kicinski Date: Wed, 9 Sep 2020 08:34:42 -0700 > On Wed, 9 Sep 2020 07:50:32 +0300 Parav Pandit wrote: >> From: Parav Pandit >> >> Hi Jakub, Dave, >> >> Currently a devlink instance that supports an eswitch handles eswitch >> ports of two type of controllers. >> (1) controller disc

Re: [PATCH net-next + leds v2 2/7] leds: add generic API for LEDs that can be controlled by hardware

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 22:48:15 +0200 Pavel Machek wrote: > Hi! > > > Many an ethernet PHY (and other chips) supports various HW control modes > > for LEDs connected directly to them. > > I guess this should be > > "Many ethernet PHYs (and other chips) support various HW control modes > for LEDs

Re: [PATCH net-next] net: pxa168_eth: remove redundant null check before clk_disable_unprepare()

2020-09-09 Thread David Miller
From: Zhang Changzhong Date: Wed, 9 Sep 2020 22:06:37 +0800 > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH net-next] net: stmmac: dwmac-intel-plat: remove redundant null check before clk_disable_unprepare()

2020-09-09 Thread David Miller
From: Zhang Changzhong Date: Wed, 9 Sep 2020 22:09:00 +0800 > Because clk_prepare_enable() and clk_disable_unprepare() already checked > NULL clock parameter, so the additional checks are unnecessary, just > remove them. > > Reported-by: Hulk Robot > Signed-off-by: Zhang Changzhong Applied.

Re: [PATCH v3 0/5] SMSC: Cleanups and clock setup

2020-09-09 Thread David Miller
From: Marco Felsch Date: Wed, 9 Sep 2020 15:44:56 +0200 > this small series cleans the smsc-phy code a bit and adds the support to > specify the phy clock source. Adding the phy clock source support is > also the main purpose of this series. > > Each file has its own changelog. > > Thanks a lo

Re: [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs

2020-09-09 Thread Rob Herring
On Wed, Sep 09, 2020 at 06:25:46PM +0200, Marek Behún wrote: > Document binding for LEDs connected to and controlled by various chips > (such as ethernet PHY chips). If they are h/w controlled, then why are they in DT? > > Signed-off-by: Marek Behún > Cc: Rob Herring > Cc: devicet...@vger.kern

Re: [PATCH net-next 1/5] net: ipa: use atomic exchange for suspend reference

2020-09-09 Thread David Miller
From: Alex Elder Date: Wed, 9 Sep 2020 08:43:44 -0500 > There is exactly one reference here; the "reference" is > essentially a Boolean flag. So the value is always either > 0 or 1. Aha, then why not use a bitmask and test_and_set_bit() et al.?

Re: [PATCH net-next] net: cavium: Fix a bunch of kerneldoc parameter issues

2020-09-09 Thread David Miller
From: Wang Hai Date: Wed, 9 Sep 2020 21:21:09 +0800 > Rename ptp to ptp_info. > > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/net/ethernet/cavium/common/cavium_ptp.c:94: warning: Excess function > parameter 'ptp' description in 'cavium_ptp_adjfine' > drivers/net/ethernet/cavium/c

Re: [PATCH net-next 1/1] net: usb: qmi_wwan: add default rx_urb_size

2020-09-09 Thread Daniele Palmas
Hi Bjørn, Il giorno mer 9 set 2020 alle ore 14:49 Bjørn Mork ha scritto: > > Daniele Palmas writes: > > Il giorno mer 9 set 2020 alle ore 13:09 Carl Yin(殷张成) > > ha scritto: > >> > >> Hi Deniele: > >> > >> I have an idea, by now in order to use QMAP, > >> must execute shell comm

Re: [PATCH net-next + leds v2 1/7] dt-bindings: leds: document binding for HW controlled LEDs

2020-09-09 Thread Marek Behun
On Wed, 9 Sep 2020 14:59:23 -0600 Rob Herring wrote: > > > > I don't know :) I copied this from other drivers, I once tried setting > > up environment for doing checking of device trees with YAML schemas, > > and it was a little painful :) > > pip3 install dtschema ? > > Can you elaborate on

  1   2   3   4   >