Re: [PATCH v3 0/7] crypto: mark ecb(arc4) skcipher as obsolete

2020-09-10 Thread Herbert Xu
On Mon, Aug 31, 2020 at 06:16:42PM +0300, Ard Biesheuvel wrote: > RC4 hasn't aged very well, and is a poor fit for the skcipher API so it > would be good if we could get rid of the ecb(arc4) drivers in the kernel > at some point in the future. This prevents new users from creeping in, and > allows

Re: [PATCH net] can: j1939: j1939_sk_bind(): return failure if netdev is down

2020-09-10 Thread Oleksij Rempel
On Mon, Sep 07, 2020 at 02:31:48PM +0800, Zhang Changzhong wrote: > When a netdev down event occurs after a successful call to > j1939_sk_bind(), j1939_netdev_notify() can handle it correctly. > > But if the netdev already in down state before calling j1939_sk_bind(), > j1939_sk_release() will sta

Re: [PATCH bpf] docs/bpf: fix ringbuf documentation

2020-09-10 Thread Mauro Carvalho Chehab
Hi Andrii, Em Thu, 10 Sep 2020 15:52:45 -0700 Andrii Nakryiko escreveu: > Remove link to litmus tests that didn't make it to upstream. Fix ringbuf > benchmark link. That work, thanks! > I wasn't able to test this with `make htmldocs`, unfortunately, because of > Sphinx dependencies. Weird. "

[PATCH net-next] drivers/net/wan/x25_asy: Remove an unused flag "SLF_OUTWAIT"

2020-09-10 Thread Xie He
The "SLF_OUTWAIT" flag defined in x25_asy.h is not actually used. It is only cleared at one place in x25_asy.c but is never read or set. So we can remove it. Signed-off-by: Xie He --- drivers/net/wan/x25_asy.c | 2 -- drivers/net/wan/x25_asy.h | 1 - 2 files changed, 3 deletions(-) diff --git a

Re: [PATCH] Revert "net: linkwatch: add check for netdevice being present to linkwatch_do_dev"

2020-09-10 Thread Geert Uytterhoeven
Hi David, On Thu, Sep 10, 2020 at 9:20 PM David Miller wrote: > From: Geert Uytterhoeven > Date: Tue, 1 Sep 2020 17:02:37 +0200 > > > This reverts commit 124eee3f6955f7aa19b9e6ff5c9b6d37cb3d1e2c. > > > > Inami-san reported that this commit breaks bridge support in a Xen > > environment, and tha

Re: [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver

2020-09-10 Thread Greg Kroah-Hartman
On Thu, Sep 10, 2020 at 10:38:48PM +0200, Andrew Lunn wrote: > On Thu, Sep 10, 2020 at 11:30:33PM +0300, Oded Gabbay wrote: > > On Thu, Sep 10, 2020 at 11:25 PM Andrew Lunn wrote: > > > > > > > Can you please elaborate on how to do this with a single driver that > > > > is already in misc ? > > >

Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups

2020-09-10 Thread Krzysztof Kozlowski
On Fri, 11 Sep 2020 at 00:22, David Miller wrote: > > From: Krzysztof Kozlowski > Date: Thu, 10 Sep 2020 18:12:11 +0200 > > > Changes since v2: > > 1. Fix dtschema ID after rename (patch 1/8). > > 2. Apply patch 9/9 (defconfig change). > > > > Changes since v1: > > 1. Rename dtschema file and add

[PATCH net-next] net/socket.c: Remove an unused header file

2020-09-10 Thread Xie He
This header file is not actually used in this file. Let's remove it. Information about this header file: This header file comes from the "Frame Relay" module at drivers/net/wan/dlci.c The "Frame Relay" module is used by only one hardware driver, at: drivers/net/wan/sdla.c Note that the "Fra

Re: [PATCH 0/8] drivers: net: convert tasklets to use new tasklet_setup()

2020-09-10 Thread Allen
David, > > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")' > introduced a new tasklet initialization API. This series converts > all the net/* drivers to use the new tasklet_setup() API > > Allen Pais (8): > net: dccp: convert tasklets to use new tasklet_setup() API > net: ip

Re: [PATCH v2 01/20] ethernet: alteon: convert tasklets to use new tasklet_setup() API

2020-09-10 Thread Allen
> > >> > >> > @@ -1562,10 +1562,11 @@ static void ace_watchdog(struct net_device > >> > *data, unsigned int txqueue) > >> > } > >> > > >> > > >> > -static void ace_tasklet(unsigned long arg) > >> > +static void ace_tasklet(struct tasklet_struct *t) > >> > { > >> > - struct net_device *dev =

[PATCH net-next] net/packet: Fix a comment about hard_header_len and add a warning for it

2020-09-10 Thread Xie He
This patch tries to clarify the difference between hard_header_len and needed_headroom by fixing an outdated comment and adding a WARN_ON_ONCE warning for hard_header_len. The difference between hard_header_len and needed_headroom as understood by this patch is based on the following reasons: 1.

Re: [PATCH v3 7/7] crypto: arc4 - mark ecb(arc4) skcipher as obsolete

2020-09-10 Thread Herbert Xu
On Mon, Aug 31, 2020 at 06:16:49PM +0300, Ard Biesheuvel wrote: > > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include This needs kernel.h too for the pr_warn_ratelimited. I'll add it when I apply the series. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au

Re: [PATCH bpf-next v3 0/5] tcp: increase flexibility of EBPF congestion control initialization

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 8:28 PM Martin KaFai Lau wrote: > > On Thu, Sep 10, 2020 at 03:35:31PM -0400, Neal Cardwell wrote: > > From: Neal Cardwell > > > > This patch series reorganizes TCP congestion control initialization so that > > if > > EBPF code called by tcp_init_transfer() sets the conge

[PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

2020-09-10 Thread Florian Fainelli
Update the B53 driver to support VLANs while not filtering. This requires us to enable VLAN globally within the switch upon driver initial configuration (dev->vlan_enabled). We also need to remove the code that dealt with PVID re-configuration in b53_vlan_filtering() since that function worked und

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Joe Perches
On Thu, 2020-09-10 at 15:21 +0100, Robin Murphy wrote: > On 2020-09-09 21:06, Joe Perches wrote: > > fallthrough to a separate case/default label break; isn't very readable. > > > > Convert pseudo-keyword fallthrough; statements to a simple break; when > > the next label is case or default and the

[PATCH net-next] net: stmmac: set get_rx_header_len() as void for it didn't have any error code to return

2020-09-10 Thread Luo Jiaxing
We found the following warning when using W=1 to build kernel: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret, coe = priv->hw->rx_csum; When digging stmmac_get_rx_header_len(), dwmac4_get_rx_header_len() and

Re: [PATCH net-next] net: stmmac: Remove unused variable 'ret' at stmmac_rx_buf1_len()

2020-09-10 Thread luojiaxing
On 2020/9/11 3:29, Jakub Kicinski wrote: On Thu, 10 Sep 2020 10:42:45 +0800 Luo Jiaxing wrote: Fixes the following warning when using W=1 to build kernel: drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3634:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int ret, c

Re: [PATCH bpf-next v3 0/5] tcp: increase flexibility of EBPF congestion control initialization

2020-09-10 Thread Martin KaFai Lau
On Thu, Sep 10, 2020 at 03:35:31PM -0400, Neal Cardwell wrote: > From: Neal Cardwell > > This patch series reorganizes TCP congestion control initialization so that if > EBPF code called by tcp_init_transfer() sets the congestion control algorithm > by calling setsockopt(TCP_CONGESTION) then the

Re: [PATCH bpf] docs/bpf: fix ringbuf documentation

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 3:53 PM Andrii Nakryiko wrote: > > Remove link to litmus tests that didn't make it to upstream. Fix ringbuf > benchmark link. > > I wasn't able to test this with `make htmldocs`, unfortunately, because of > Sphinx dependencies. But bench_ringbufs.c path is certainly correct

Re: [PATCH bpf-next v4] tools: bpftool: automate generation for "SEE ALSO" sections in man pages

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 1:39 PM Quentin Monnet wrote: > > The "SEE ALSO" sections of bpftool's manual pages refer to bpf(2), > bpf-helpers(7), then all existing bpftool man pages (save the current > one). > > This leads to nearly-identical lists being duplicated in all manual > pages. Ideally, whe

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-10 Thread Florian Fainelli
On 9/10/2020 5:03 PM, Vladimir Oltean wrote: On Thu, Sep 10, 2020 at 02:58:04PM -0700, Florian Fainelli wrote: On 9/9/2020 11:34 AM, Florian Fainelli wrote: On 9/9/2020 10:53 AM, Vladimir Oltean wrote: On Wed, Sep 09, 2020 at 10:22:42AM -0700, Florian Fainelli wrote: How do you make sure t

Re: [PATCH bpf-next] selftests/bpf: define string const as global for test_sysctl_prog.c

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 1:27 PM Yonghong Song wrote: > > When tweaking llvm optimizations, I found that selftest build failed > with the following error: > libbpf: elf: skipping unrecognized data section(6) .rodata.str1.1 > libbpf: prog 'sysctl_tcp_mem': bad map relo against > '.L__const.is_t

[PATCH net-next] net: hns: use IRQ_NOAUTOEN to avoid irq is enabled due to request_irq

2020-09-10 Thread Barry Song
Rather than doing request_irq and then disabling the irq immediately, it should be safer to use IRQ_NOAUTOEN flag for the irq. It removes any gap between request_irq() and disable_irq(). Cc: Salil Mehta Reviewed-by: Yunsheng Lin Signed-off-by: Barry Song --- drivers/net/ethernet/hisilicon/hns/

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread wanghai (M)
在 2020/9/11 3:38, Jakub Kicinski 写道: On Thu, 10 Sep 2020 12:38:00 -0700 Jakub Kicinski wrote: On Thu, 10 Sep 2020 23:04:26 +0800 Wang Hai wrote: Wang Hai (3): e1000e: Fix some kernel-doc warnings in ich8lan.c e1000e: Fix some kernel-doc warnings in netdev.c e1000: Fix a bunch of kern

Re: [net-next v5 3/5] devlink: introduce flash update overwrite mask

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 18:32:29 -0700 Jakub Kicinski wrote: > On Thu, 10 Sep 2020 14:28:10 -0700 Jacob Keller wrote: > > +#define DEVLINK_FLASH_OVERWRITE_SETTINGS > > BIT(DEVLINK_FLASH_OVERWRITE_SETTINGS_BIT) > > +#define DEVLINK_FLASH_OVERWRITE_IDENTIFIERS > > BIT(DEVLINK_FLASH_OVERWRITE_IDENTIFIER

Re: [net-next v5 3/5] devlink: introduce flash update overwrite mask

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 14:28:10 -0700 Jacob Keller wrote: > +#define DEVLINK_FLASH_OVERWRITE_SETTINGS > BIT(DEVLINK_FLASH_OVERWRITE_SETTINGS_BIT) > +#define DEVLINK_FLASH_OVERWRITE_IDENTIFIERS > BIT(DEVLINK_FLASH_OVERWRITE_IDENTIFIERS_BIT) You got two more here.

Re: [net-next v8 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 18:00:50 +0300 Vadym Kochan wrote: > +static int prestera_sdma_tx_wait(struct prestera_sdma *sdma, > + struct prestera_tx_ring *tx_ring) > +{ > + int tx_wait_num = PRESTERA_SDMA_WAIT_MUL * tx_ring->max_burst; > + bool is_ready; > + > + re

[RFC PATCH net-next v1 04/11] ixgbe: clean up W=1 warnings in ixgbe

2020-09-10 Thread Jesse Brandeburg
Inspired by Lee Jones, this eliminates the remaining W=1 warnings in ixgbe. Signed-off-by: Jesse Brandeburg --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 3 ++- drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 8 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/driver

[RFC PATCH net-next v1 03/11] iavf: clean up W=1 warnings in iavf

2020-09-10 Thread Jesse Brandeburg
Inspired by Lee Jones, this eliminates the remaining W=1 warnings in iavf. Signed-off-by: Jesse Brandeburg --- drivers/net/ethernet/intel/iavf/iavf_main.c | 24 ++--- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/dr

[RFC PATCH net-next v1 10/11] drivers/net/ethernet: remove incorrectly formatted doc

2020-09-10 Thread Jesse Brandeburg
As part of the W=1 series for ethernet, these drivers were discovered to be using kdoc style comments but were not actually doing kdoc. Signed-off-by: Jesse Brandeburg --- drivers/net/ethernet/amazon/ena/ena_com.c | 2 +- .../aquantia/atlantic/hw_atl/hw_atl_b0.c | 2 +- drivers/net/et

[RFC PATCH net-next v1 05/11] intel-ethernet: make W=1 build cleanly

2020-09-10 Thread Jesse Brandeburg
This takes care of all of the trivial W=1 fixes in the Intel Ethernet drivers, which allows developers and maintainers to build more of the networking tree with more complete warning checks. Almost all of the changes were trivial comment updates on function headers, but some of the changes were fo

[RFC PATCH net-next v1 06/11] drivers/net/ethernet: clean up unused assignments

2020-09-10 Thread Jesse Brandeburg
As part of the W=1 compliation series, these lines all created warnings about unused variables that were assigned a value. Most of them are from register reads, but some are just picking up a return value from a function and never doing anything with it. The register reads should be OK, because th

[RFC PATCH net-next v1 00/11] make drivers/net/ethernet W=1 clean

2020-09-10 Thread Jesse Brandeburg
This series is a placeholder to show I've about finished this work. After applying the patches below, the drivers/net/ethernet directory can be built as modules with W=1 with no warnings. This series removes 1,283 warnings and hopefully allows the ethernet directory to move forward from here with

[RFC PATCH net-next v1 02/11] i40e: clean up W=1 warnings in i40e

2020-09-10 Thread Jesse Brandeburg
Inspired by Lee Jones, this eliminates the remaining W=1 warnings in i40e. Signed-off-by: Jesse Brandeburg --- drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- drivers/net/ethernet/intel/i40e/i40e_common.c | 4 ++-- drivers/net/ethernet/intel/i40e/i40e_main.c | 17 ++--

[RFC PATCH net-next v1 09/11] drivers/net/ethernet: add some basic kdoc tags

2020-09-10 Thread Jesse Brandeburg
A couple of drivers had a "generic documentation" section that would trigger a "can't understand" message from W=1 compiles. Fix by using correct DOC: tags. Signed-off-by: Jesse Brandeburg --- drivers/net/ethernet/arc/emac_arc.c | 2 +- drivers/net/ethernet/cadence/macb_pci.c | 2 +- 2 file

[RFC PATCH net-next v1 01/11] i40e: prepare flash string in a simpler way

2020-09-10 Thread Jesse Brandeburg
The flash string handling code triggered a W=1 warning and upon investigation it seems everything can be handled in a simpler way with a single initialization and one strlcat. The buffer is filled with NULL after the end of the string by the initializer, and the strlcat checks total length, and ma

[RFC PATCH net-next v1 08/11] drivers/net/ethernet: handle one warning explicitly

2020-09-10 Thread Jesse Brandeburg
While fixing the W=1 builds, this warning came up because the developers used a very tricky way to get structures initialized to a non-zero value, but this causes GCC to warn about an override. In this case the override was intentional, so just disable the warning for this code with a #pragma. Sig

[RFC PATCH net-next v1 07/11] drivers/net/ethernet: rid ethernet of no-prototype warnings

2020-09-10 Thread Jesse Brandeburg
The W=1 builds showed a few files exporting functions (non-static) that were not prototyped. What actually happened is that there were prototypes, but the include file was forgotten in the implementation file. Add the include file and remove the warnings. Signed-off-by: Jesse Brandeburg --- dri

linux-next: manual merge of the net-next tree with the net tree

2020-09-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: drivers/net/dsa/microchip/ksz9477.c between commit: edecfa98f602 ("net: dsa: microchip: look for phy-mode in port nodes") from the net tree and commit: 805a7e6f5388 ("net: dsa: microchip: Improve phy mode message")

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for i40e

2020-09-10 Thread Jesse Brandeburg
Wang Hai wrote: > Wang Hai (3): > i40e: Fix some kernel-doc warnings in i40e_client.c > i40e: Fix some kernel-doc warnings in i40e_common.c > i40e: Fix a kernel-doc warning in i40e_ptp.c > > drivers/net/ethernet/intel/i40e/i40e_client.c | 2 -- > drivers/net/ethernet/intel/i40e/i40e_common

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 5:22 AM Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within > fstat syscall code path, so fentry/vfs_getattr trampoline > is not called. > > I'm not sure how to handle this in some generic way other > than use some other function, but that might ge

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread Nathan Chancellor
On Thu, Sep 10, 2020 at 03:28:11PM -0700, David Miller wrote: > From: Nathan Chancellor > Date: Thu, 10 Sep 2020 10:48:27 -0700 > > > Clang warns (trimmed for brevity): > > > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > > variable 'link' is used uninitialized whenever 'if

Re: [PATCH bpf-next v3 0/2] tools: bpftool: support creating outer maps

2020-09-10 Thread Alexei Starovoitov
On Thu, Sep 10, 2020 at 3:27 AM Quentin Monnet wrote: > > This series makes bpftool able to create outer maps (maps of types > array-of-maps and hash-of-maps). This is done by passing the relevant > inner_map_fd, which we do through a new command-line keyword. > > The first two patches also clean

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-10 Thread Vladimir Oltean
On Thu, Sep 10, 2020 at 02:58:04PM -0700, Florian Fainelli wrote: > On 9/9/2020 11:34 AM, Florian Fainelli wrote: > > On 9/9/2020 10:53 AM, Vladimir Oltean wrote: > > > On Wed, Sep 09, 2020 at 10:22:42AM -0700, Florian Fainelli wrote: > > > > How do you make sure that the CPU port sees the frame un

Re: [PATCH net] tg3: Fix soft lockup when tg3_reset_task() fails.

2020-09-10 Thread Baptiste Covolato
Hi Michael, On Sat, Sep 5, 2020 at 2:02 AM Michael Chan wrote: > Now we have AER errors detected on 2 other tg3 devices, not from the > one above with tg3_abort_hw() failure. > > I think this issue that you're reporting is not the same as David's > issue of TX timeout happening at about the same

[PATCH bpf] docs/bpf: fix ringbuf documentation

2020-09-10 Thread Andrii Nakryiko
Remove link to litmus tests that didn't make it to upstream. Fix ringbuf benchmark link. I wasn't able to test this with `make htmldocs`, unfortunately, because of Sphinx dependencies. But bench_ringbufs.c path is certainly correct now. Reported-by: Mauro Carvalho Chehab Fixes: 97abb2b39682 ("do

Re: [PATCH v4 bpf-next 5/5] docs/bpf: add BPF ring buffer design notes

2020-09-10 Thread Andrii Nakryiko
On Wed, Sep 9, 2020 at 6:53 AM Mauro Carvalho Chehab wrote: > > Em Fri, 29 May 2020 00:54:24 -0700 > Andrii Nakryiko escreveu: > > > Add commit description from patch #1 as a stand-alone documentation under > > Documentation/bpf, as it might be more convenient format, in long term > > perspective

Re: [PATCH bpf-next 2/2] selftests/bpf: Adding test for arg dereference in extension trace

2020-09-10 Thread Andrii Nakryiko
On Wed, Sep 9, 2020 at 8:38 AM Jiri Olsa wrote: > > Adding test that setup following program: > > SEC("classifier/test_pkt_md_access") > int test_pkt_md_access(struct __sk_buff *skb) > > with its extension: > > SEC("freplace/test_pkt_md_access") > int test_pkt_md_access_new(struct __sk_buf

Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip

2020-09-10 Thread David Miller
From: Lucy Yan Date: Thu, 10 Sep 2020 12:05:09 -0700 > Increase Rx ring size to address issue where hardware is reaching > the receive work limit. > > Before: > > [ 102.223342] de2104x :17:00.0 eth0: rx work limit reached > [ 102.245695] de2104x :17:00.0 eth0: rx work limit reached >

Re: [PATCH net-next] net: mvpp2: Initialize link in mvpp2_isr_handle_{xlg,gmac_internal}

2020-09-10 Thread David Miller
From: Nathan Chancellor Date: Thu, 10 Sep 2020 10:48:27 -0700 > Clang warns (trimmed for brevity): > > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c:3073:7: warning: > variable 'link' is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > if (val

Re: [PATCH net-next 00/10] net/smc: updates 2020-09-10

2020-09-10 Thread David Miller
From: Karsten Graul Date: Thu, 10 Sep 2020 18:48:19 +0200 > Please apply the following patch series for smc to netdev's net-next tree. > > This patch series is a mix of various improvements and cleanups. > The patches 1 and 10 improve the handling of large parallel workloads. > Patch 8 corrects

Re: [PATCH bpf-next] selftests/bpf: Check trampoline execution in d_path test

2020-09-10 Thread Andrii Nakryiko
On Thu, Sep 10, 2020 at 5:25 AM Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within > fstat syscall code path, so fentry/vfs_getattr trampoline > is not called. > > I'm not sure how to handle this in some generic way other > than use some other function, but that might ge

Re: [PATCH v3 0/8] nfc: s3fwrn5: Few cleanups

2020-09-10 Thread David Miller
From: Krzysztof Kozlowski Date: Thu, 10 Sep 2020 18:12:11 +0200 > Changes since v2: > 1. Fix dtschema ID after rename (patch 1/8). > 2. Apply patch 9/9 (defconfig change). > > Changes since v1: > 1. Rename dtschema file and add additionalProperties:false, as Rob >suggested, > 2. Add Marek's

Re: [PATCH net-next 0/6] Fix some kernel-doc warnings for hns

2020-09-10 Thread David Miller
From: Wang Hai Date: Thu, 10 Sep 2020 22:56:14 +0800 > Fix some kernel-doc warnings for hns. Series applied to net-next, thanks.

Re: [PATCH] net: mvpp2: ptp: Fix unused variables

2020-09-10 Thread David Miller
From: Alex Dewar Date: Thu, 10 Sep 2020 14:49:10 +0100 > In the functions mvpp2_isr_handle_xlg() and > mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a > true value in the case that a given bit of val is set. However, if the > bit is unset, no value is assigned to link and i

Re: [PATCH net-next] net: cxgb3: Fix some kernel-doc warnings

2020-09-10 Thread David Miller
From: Wang Hai Date: Thu, 10 Sep 2020 21:36:16 +0800 > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2209: warning: Excess function > parameter 'adapter' description in 'clear_sge_ctxt' > drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2975: warning:

Re: [PATCH net] netlink: fix doc about nlmsg_parse/nla_validate

2020-09-10 Thread David Miller
From: Nicolas Dichtel Date: Thu, 10 Sep 2020 15:34:39 +0200 > There is no @validate argument. > > CC: Johannes Berg > Fixes: 3de644035446 ("netlink: re-add parse/validate functions in strict > mode") > Signed-off-by: Nicolas Dichtel Applied, thank you.

Re: [PATCH V4 net-next 0/4] Enhance current features in ena driver

2020-09-10 Thread David Miller
From: Date: Thu, 10 Sep 2020 13:07:09 + > From: Sameeh Jubran > > This series adds the following: > * Exposes new device stats using ethtool. > * Adds and exposes the stats of xdp TX queues through ethtool. > > V3: Fix indentation in patches #3 and #4 > V2: Drop the need for casting stat_o

Re: [PATCH net] net: DCB: Validate DCB_ATTR_DCB_BUFFER argument

2020-09-10 Thread David Miller
From: Petr Machata Date: Thu, 10 Sep 2020 14:09:05 +0200 > The parameter passed via DCB_ATTR_DCB_BUFFER is a struct dcbnl_buffer. The > field prio2buffer is an array of IEEE_8021Q_MAX_PRIORITIES bytes, where > each value is a number of a buffer to direct that priority's traffic to. > That value i

Re: [PATCH net 0/2] net: Fix bridge enslavement failure

2020-09-10 Thread David Miller
From: Ido Schimmel Date: Thu, 10 Sep 2020 14:01:25 +0300 > From: Ido Schimmel > > Patch #1 fixes an issue in which an upper netdev cannot be enslaved to a > bridge when it has multiple netdevs with different parent identifiers > beneath it. > > Patch #2 adds a test case using two netdevsim ins

Re: [PATCH v2] macsec: Support 32bit PN netlink attribute for XPN links

2020-09-10 Thread David Miller
From: Era Mayflower Date: Thu, 10 Sep 2020 09:56:09 + > - pn_len = secy->xpn ? MACSEC_XPN_PN_LEN : MACSEC_DEFAULT_PN_LEN; > - if (nla_len(tb_sa[MACSEC_SA_ATTR_PN]) != pn_len) { > - pr_notice("macsec: nl: upd_rxsa: bad pn length: %d != > %d\n", > -

Re: [PATCH net] net: mvneta: fix possible use-after-free in mvneta_xdp_put_buff

2020-09-10 Thread David Miller
From: Lorenzo Bianconi Date: Thu, 10 Sep 2020 11:08:01 +0200 > Release first buffer as last one since it contains references > to subsequent fragments. This code will be optimized introducing > multi-buffer bit in xdp_buff structure. > > Fixes: ca0e014609f05 ("net: mvneta: move skb build after d

Re: WARNING in bpf_raw_tp_link_fill_link_info

2020-09-10 Thread Andrii Nakryiko
On Thu, Sep 10, 2020 at 2:31 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:7fb5eefd selftests/bpf: Fix test_sysctl_loop{1, 2} failure.. > git tree: bpf-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1424fdb390 > kernel config:

Re: [PATCH net-next 4/4] net: dsa: set configure_vlan_while_not_filtering to true by default

2020-09-10 Thread Florian Fainelli
On 9/9/2020 11:34 AM, Florian Fainelli wrote: On 9/9/2020 10:53 AM, Vladimir Oltean wrote: On Wed, Sep 09, 2020 at 10:22:42AM -0700, Florian Fainelli wrote: How do you make sure that the CPU port sees the frame untagged which would be necessary for a VLAN-unaware bridge? Do you have a spe

Re: [PATCH v4 09/11] net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support

2020-09-10 Thread Matthias Schiffer
On Mon, 2020-08-03 at 07:44 +0200, Michael Grzeschik wrote: > Add KSZ88X3 driver support. We add support for the KXZ88X3 three port > switches using the Microchip SMI Interface. They are supported using > the > MDIO-Bitbang Interface. > > Signed-off-by: Michael Grzeschik > > --- > v1 -> v2: - t

Re: [PATCH bpf-next] selftests/bpf: define string const as global for test_sysctl_prog.c

2020-09-10 Thread Andrii Nakryiko
On Thu, Sep 10, 2020 at 1:30 PM Yonghong Song wrote: > > When tweaking llvm optimizations, I found that selftest build failed > with the following error: > libbpf: elf: skipping unrecognized data section(6) .rodata.str1.1 > libbpf: prog 'sysctl_tcp_mem': bad map relo against > '.L__const.is_t

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-10 Thread Pavel Machek
On Wed 2020-09-09 18:25:51, Marek Behún wrote: > This patch adds support for controlling the LEDs connected to several > families of Marvell PHYs via the PHY HW LED trigger API. These families > are: 88E1112, 88E1121R, 88E1240, 88E1340S, 88E1510 and 88E1545. More can > be added. > > This patch doe

Re: WARNING in tracepoint_probe_register_prio (4)

2020-09-10 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:34d4ddd3 Merge tag 'linux-kselftest-5.9-rc5' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13ab2b7d90 kernel config: https://syzkaller.appspot.com/x/.config?x=8f5c353

Re: [PATCH net] net: mvneta: fix possible use-after-free in mvneta_xdp_put_buff

2020-09-10 Thread Jesper Dangaard Brouer
On Thu, 10 Sep 2020 11:08:01 +0200 Lorenzo Bianconi wrote: > Release first buffer as last one since it contains references > to subsequent fragments. This code will be optimized introducing > multi-buffer bit in xdp_buff structure. > > Fixes: ca0e014609f05 ("net: mvneta: move skb build after des

[PATCH v2] hv_netvsc: Add validation for untrusted Hyper-V values

2020-09-10 Thread Andrea Parri (Microsoft)
From: Andres Beltran For additional robustness in the face of Hyper-V errors or malicious behavior, validate all values that originate from packets that Hyper-V has sent to the guest in the host-to-guest ring buffer. Ensure that invalid values cannot cause indexing off the end of an array, or sub

[PATCH net-next 2/3] net: stmmac: Fix incorrect location to set real_num_rx|tx_queues

2020-09-10 Thread Wong Vee Khee
From: Aashish Verma netif_set_real_num_tx_queues() & netif_set_real_num_rx_queues() should be used to inform network stack about the real Tx & Rx queue (active) number in both stmmac_open() and stmmac_resume(), therefore, we move the code from stmmac_dvr_probe() to stmmac_hw_setup(). Fixes: c02b

Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

2020-09-10 Thread Russell King - ARM Linux admin
On Thu, Sep 10, 2020 at 10:31:12PM +0200, Marek Behun wrote: > On Thu, 10 Sep 2020 19:34:35 +0100 > Russell King - ARM Linux admin wrote: > > > On Thu, Sep 10, 2020 at 08:31:54PM +0200, Andrew Lunn wrote: > > > Generally the driver will default to the hardware reset blink > > > pattern. There are

[PATCH net-next 3/3] net: stmmac: use netif_tx_start|stop_all_queues() function

2020-09-10 Thread Wong Vee Khee
From: Ong Boon Leong The current implementation of stmmac_stop_all_queues() and stmmac_start_all_queues() will not work correctly when the value of tx_queues_to_use is changed through ethtool -L DEVNAME rx N tx M command. Also, netif_tx_start|stop_all_queues() are only needed in driver open() an

Re: Packet gets stuck in NOLOCK pfifo_fast qdisc

2020-09-10 Thread Paolo Abeni
On Thu, 2020-09-10 at 14:07 -0700, John Fastabend wrote: > Cong Wang wrote: > > On Thu, Sep 3, 2020 at 10:08 PM John Fastabend > > wrote: > > > Maybe this would unlock us, > > > > > > diff --git a/net/core/dev.c b/net/core/dev.c > > > index 7df6c9617321..9b09429103f1 100644 > > > --- a/net/core/

[PATCH V4 net-next 3/4] net: ena: ethtool: add stats printing to XDP queues

2020-09-10 Thread sameehj
From: Sameeh Jubran Added statistics for TX queues that are used for XDP TX. The statistics are the same as the ones printed for regular non-XDP TX queues. The XDP queue statistics can be queried using `ethtool -S ` Signed-off-by: Shay Agroskin Signed-off-by: Sameeh Jubran --- drivers/net/et

[PATCH V4 net-next 0/4] Enhance current features in ena driver

2020-09-10 Thread sameehj
From: Sameeh Jubran This series adds the following: * Exposes new device stats using ethtool. * Adds and exposes the stats of xdp TX queues through ethtool. V3: Fix indentation in patches #3 and #4 V2: Drop the need for casting stat_offset V1: Use unsigned long for pointer math instead of uintpt

[PATCH bpf-next v3 0/9] bpf: Support multi-attach for freplace programs

2020-09-10 Thread Toke Høiland-Jørgensen
This series adds support attaching freplace BPF programs to multiple targets. This is needed to support incremental attachment of multiple XDP programs using the libxdp dispatcher model. The first three patches are refactoring patches: The first one is a trivial change to the logging in the verifi

[PATCH V4 net-next 1/4] net: ena: ethtool: convert stat_offset to 64 bit resolution

2020-09-10 Thread sameehj
From: Sameeh Jubran The type of all stat fields is u64, therefore when iterating over stat fields in a stats struct, it makes sense to use an offset in 64 bit resolution. Doing so allows us to drop some of the casting that is currently used when referencing stats. Signed-off-by: Sameeh Jubran -

[PATCH V4 net-next 4/4] net: ena: xdp: add queue counters for xdp actions

2020-09-10 Thread sameehj
From: Sameeh Jubran When using XDP every ingress packet is passed to an eBPF (xdp) program which returns an action for this packet. This patch adds counters for the number of times each such action was received. It also counts all the invalid actions received from the eBPF program. Signed-off-b

[PATCH bpf-next v3 3/9] bpf: wrap prog->aux->linked_prog in a bpf_tracing_link

2020-09-10 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The bpf_tracing_link structure is a convenient data structure to contain the reference to a linked program; in preparation for supporting multiple attachments for the same freplace program, move the linked_prog in prog->aux into a bpf_tracing_link wrapper. With this

[PATCH bpf-next v3 6/9] tools: add new members to bpf_attr.raw_tracepoint in bpf.h

2020-09-10 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Sync addition of new members from main kernel tree. Signed-off-by: Toke Høiland-Jørgensen --- tools/include/uapi/linux/bpf.h |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h

[PATCH bpf-next v3 5/9] bpf: Fix context type resolving for extension programs

2020-09-10 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Eelco reported we can't properly access arguments if the tracing program is attached to extension program. Having following program: SEC("classifier/test_pkt_md_access") int test_pkt_md_access(struct __sk_buff *skb) with its extension: SEC("freplace/test_pkt

[PATCH bpf-next v3 4/9] bpf: support attaching freplace programs to multiple attach points

2020-09-10 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This enables support for attaching freplace programs to multiple attach points. It does this by amending UAPI for bpf_raw_tracepoint_open with a target prog fd and btf ID pair that can be used to supply the new attachment point. The target must be compatible with the

[PATCH bpf-next v3 2/9] bpf: verifier: refactor check_attach_btf_id()

2020-09-10 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen The check_attach_btf_id() function really does three things: 1. It performs a bunch of checks on the program to ensure that the attachment is valid. 2. It stores a bunch of state about the attachment being requested in the verifier environment and struct bpf_p

[PATCH net] netlink: fix doc about nlmsg_parse/nla_validate

2020-09-10 Thread Nicolas Dichtel
There is no @validate argument. CC: Johannes Berg Fixes: 3de644035446 ("netlink: re-add parse/validate functions in strict mode") Signed-off-by: Nicolas Dichtel --- include/net/netlink.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/net/netlink.h b/include/net/netlink.h index c04

[PATCH] net: mvpp2: ptp: Fix unused variables

2020-09-10 Thread Alex Dewar
In the functions mvpp2_isr_handle_xlg() and mvpp2_isr_handle_gmac_internal(), the bool variable link is assigned a true value in the case that a given bit of val is set. However, if the bit is unset, no value is assigned to link and it is then passed to mvpp2_isr_handle_link() without being initial

[PATCH net-next] net: cxgb3: Fix some kernel-doc warnings

2020-09-10 Thread Wang Hai
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2209: warning: Excess function parameter 'adapter' description in 'clear_sge_ctxt' drivers/net/ethernet/chelsio/cxgb3/t3_hw.c:2975: warning: Excess function parameter 'adapter' description in 't3_set_prot

[PATCH net-next v2] net: try to avoid unneeded backlog flush

2020-09-10 Thread Paolo Abeni
flush_all_backlogs() may cause deadlock on systems running processes with FIFO scheduling policy. The above is critical in -RT scenarios, where user-space specifically ensure no network activity is scheduled on the CPU running the mentioned FIFO process, but still get stuck. This commit tries to

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jacob Keller
On 9/10/2020 2:23 PM, Jakub Kicinski wrote: > On Thu, 10 Sep 2020 13:59:07 -0700 Jacob Keller wrote: >> On 9/9/2020 5:55 PM, Jakub Kicinski wrote: >>> On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: The devlink core recently gained support for checking whether the driver suppo

[net-next v5 5/5] ice: add support for flash update overwrite mask

2020-09-10 Thread Jacob Keller
Support the recently added DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK parameter in the ice flash update handler. Convert the overwrite mask bitfield into the appropriate preservation level used by the firmware when updating. Because there is no equivalent preservation level for overwriting only iden

[net-next v5 4/5] netdevsim: add support for flash_update overwrite mask

2020-09-10 Thread Jacob Keller
The devlink interface recently gained support for a new "overwrite mask" parameter that allows specifying how various sub-sections of a flash component are modified when updating. Add support for this to netdevsim, to enable easily testing the interface. Make the allowed overwrite mask values cont

[net-next v5 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jacob Keller
The devlink core recently gained support for checking whether the driver supports a flash_update parameter, via `supported_flash_update_params`. However, parameters are specified as function arguments. Adding a new parameter still requires modifying the signature of the .flash_update callback in al

[net-next v5 1/5] devlink: check flash_update parameter support in net core

2020-09-10 Thread Jacob Keller
When implementing .flash_update, drivers which do not support per-component update are manually checking the component parameter to verify that it is NULL. Without this check, the driver might accept an update request with a component specified even though it will not honor such a request. Instead

[net-next v5 3/5] devlink: introduce flash update overwrite mask

2020-09-10 Thread Jacob Keller
Sections of device flash may contain settings or device identifying information. When performing a flash update, it is generally expected that these settings and identifiers are not overwritten. However, it may sometimes be useful to allow overwriting these fields when performing a flash update. S

[net-next v5 0/5] devlink flash update overwrite mask

2020-09-10 Thread Jacob Keller
This series introduces support for a new attribute to the flash update command: DEVLINK_ATTR_FLASH_UPDATE_OVERWRITE_MASK. This attribute is a bitfield which allows userspace to specify what set of subfields to overwrite when performing a flash update for a device. The intention is to support the

[PATCH net v1] hinic: fix rewaking txq after netif_tx_disable

2020-09-10 Thread Luo bin
When calling hinic_close in hinic_set_channels, all queues are stopped after netif_tx_disable, but some queue may be rewaken in free_tx_poll by mistake while drv is handling tx irq. If one queue is rewaken core may call hinic_xmit_frame to send pkt after netif_tx_disable within a short time which m

[PATCH net-next] net: try to avoid unneeded backlog flush

2020-09-10 Thread Paolo Abeni
flush_all_backlogs() may cause deadlock on systems running processes with FIFO scheduling policy. The above is critical in -RT scenarios, where user-space specifically ensure no network activity is scheduled on the CPU running the mentioned FIFO process, but still get stuck. This commit tries to

Re: [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-10 Thread Robin Murphy
On 2020-09-09 21:06, Joe Perches wrote: fallthrough to a separate case/default label break; isn't very readable. Convert pseudo-keyword fallthrough; statements to a simple break; when the next label is case or default and the only statement in the next label block is break; Found using: $ grep

Re: [net-next v4 2/5] devlink: convert flash_update to use params structure

2020-09-10 Thread Jakub Kicinski
On Thu, 10 Sep 2020 13:59:07 -0700 Jacob Keller wrote: > On 9/9/2020 5:55 PM, Jakub Kicinski wrote: > > On Wed, 9 Sep 2020 15:26:50 -0700 Jacob Keller wrote: > >> The devlink core recently gained support for checking whether the driver > >> supports a flash_update parameter, via `supported_flash

Re: [PATCH 00/15] Adding GAUDI NIC code to habanalabs driver

2020-09-10 Thread Florian Fainelli
On 9/10/2020 2:15 PM, Oded Gabbay wrote: On Fri, Sep 11, 2020 at 12:05 AM Florian Fainelli wrote: On 9/10/2020 1:32 PM, Oded Gabbay wrote: On Thu, Sep 10, 2020 at 11:28 PM Jakub Kicinski wrote: On Thu, 10 Sep 2020 23:16:22 +0300 Oded Gabbay wrote: On Thu, Sep 10, 2020 at 11:01 PM Jak

  1   2   3   4   5   >