Re: Re: Altera TSE driver not working in 100mbps mode

2020-09-17 Thread Petko Manolov
On 20-09-16 22:32:03, David Bilsby wrote: > Hi > > Would you consider making the PhyLink modifications to the Altera TSE driver > public as this would be very useful for a board we have which uses an SFP PHY > connected to the TSE core via I2C. Currently we are using a fibre SFP and > fixing th

Re: [PATCH net-next] net: stmmac: introduce rtnl_lock|unlock() on configuring real_num_rx|tx_queues

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 01:02:15PM +0800, Wong Vee Khee wrote: > From: "Tan, Tee Min" > > For driver open(), rtnl_lock is acquired by network stack but not in the > resume(). Therefore, we introduce lock_acquired boolean to control when > to use rtnl_lock|unlock() within stmmac_hw_setup(). Doesn'

Re: [PATCH net-next 6/6] net: hns3: use napi_consume_skb() when cleaning tx desc

2020-09-17 Thread Yunsheng Lin
On 2020/9/16 16:38, Eric Dumazet wrote: > On Wed, Sep 16, 2020 at 10:33 AM Saeed Mahameed wrote: >> >> On Tue, 2020-09-15 at 15:04 +0800, Yunsheng Lin wrote: >>> On 2020/9/15 13:09, Saeed Mahameed wrote: On Mon, 2020-09-14 at 20:06 +0800, Huazhong Tan wrote: > From: Yunsheng Lin > >>

Re: [patch] freeaddrinfo.3: memory leaks in freeaddrinfo examples

2020-09-17 Thread Michael Kerrisk (man-pages)
[CC += beej, to alert the author about the memory leaks in the network programming guide] Hello Marko, > On Thu, Sep 17, 2020 at 7:42 AM Michael Kerrisk (man-pages) < > mtk.manpa...@gmail.com> wrote: > >> Hi Marko, >> >> On Thu, 17 Sep 2020 at 07:34, Marko Hrastovec >> wrote: >>> >>> Hi, >>> >

Re: [PATCH] ptp: mark symbols static where possible

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 10:25:08AM +0800, Herrington wrote: > We get 1 warning when building kernel with W=1: > drivers/ptp/ptp_pch.c:182:5: warning: no previous prototype for > ‘pch_ch_control_read’ [-Wmissing-prototypes] > u32 pch_ch_control_read(struct pci_dev *pdev) > drivers/ptp/ptp_pch.c:19

Re: [PATCH 2/2] crypto: ccree - add custom cache params from DT file

2020-09-17 Thread Gilad Ben-Yossef
hmm... On Wed, Sep 16, 2020 at 4:48 PM kernel test robot wrote: > > url: > https://github.com/0day-ci/linux/commits/Gilad-Ben-Yossef/add-optional-cache-params-from-DT/20200916-152151 > base: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > config: arm

Re: [PATCH 6/6] Bluetooth: Add MGMT command for controller capabilities

2020-09-17 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Daniel-Winkler/Bluetooth-Add-new-MGMT-interface-for-advertising-add/20200917-042141 base: https://git.kernel.org/pub/scm/linux/

Re: [PATCH] net: dsa: mt7530: Add some return-value checks

2020-09-17 Thread Landen Chao
Hi Alex, Thanks for your review and fixing. On Thu, 2020-09-17 at 03:50 +0800, Alex Dewar wrote: [..] > > If it is not expected that these functions will throw errors (i.e. > because the parameters passed will always be correct), we could dispense > with the use of EINVAL errors and just use BUG*

[PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Amit Pundir
Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error message in ath10k_qmi_host_cap_send_sync(), but we can still bring up WiFi services successfully on AOSP if we ignore it. We suspect either the host cap is not implemented or there m

[RFC PATCH] bpf: Fix potential call bpf_link_free() in atomic context

2020-09-17 Thread Muchun Song
The in_atomic macro cannot always detect atomic context. In particular, it cannot know about held spinlocks in non-preemptible kernels. Although, there is no user call bpf_link_put() with holding spinlock now. Be the safe side, we can avoid this in the feature. Signed-off-by: Muchun Song --- ker

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

[PATCH 3/3] docs: bpf: ringbuf.rst: fix a broken cross-reference

2020-09-17 Thread Mauro Carvalho Chehab
Sphinx warns about a broken cross-reference: Documentation/bpf/ringbuf.rst:194: WARNING: Unknown target name: "bench_ringbufs.c". It seems that the original idea were to add a reference for this file: tools/testing/selftests/bpf/benchs/bench_ringbufs.c However, this won't work

[PATCH 0/3] Additional doc warning fixes for issues at next-20200915

2020-09-17 Thread Mauro Carvalho Chehab
There are a couple of new warnings introduced at linux-next. This small patch series address them. The complete series addressing (almost) all doc warnings is at: https://git.linuxtv.org/mchehab/experimental.git/log/?h=doc-fixes I'll keep rebasing such tree until we get rid of all doc w

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Jiri Olsa
On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > The requirement to build resolve_btfids whenever CONFIG_DEBUG_INFO_BTF > is enabled breaks some cross builds. For example, when building a 64-bit > powerpc kernel on amd64 I get: > > Auto-detecting system features: > ...

[PATCH net-next 4/8] devlink: Support get and set state of port function

2020-09-17 Thread Parav Pandit
devlink port function can be in active or inactive state. Allow users to get and set port function's state. Example of a PCI SF port which supports a port function: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port show netdevsim/netdevs

[PATCH net-next 0/8] devlink: Add SF add/delete devlink ops

2020-09-17 Thread Parav Pandit
Hi Dave, Jakub, Similar to PCI VF, PCI SF represents portion of the device. PCI SF is represented using a new devlink port flavour. This short series implements small part of the RFC described in detail at [1] and [2]. It extends (a) devlink core to expose new devlink port flavour 'pcisf'. (b)

[PATCH net-next 2/8] devlink: Support add and delete devlink port

2020-09-17 Thread Parav Pandit
Extended devlink interface for the user to add and delete port. Extend devlink to connect user requests to driver to add/delete such port in the device. When driver routines are invoked, devlink instance lock is not held. This enables driver to perform several devlink objects registration, unregis

[PATCH net-next 5/8] netdevsim: Add support for add and delete of a PCI PF port

2020-09-17 Thread Parav Pandit
Simulate PCI PF ports. Allow user to create one or more PCI PF ports. Examples: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port show netdevsim/netdevsim10/0: type eth netdev eni10np1 flavour physical port 1 splittable false Add and

[PATCH net-next 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
Simulate PCI SF ports. Allow user to create one or more PCI SF ports. Examples: Create a PCI PF and PCI SF port. Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port show netdevsim/netdevsim10/0: type eth netdev eni10np1 flavour physical p

[PATCH net-next 3/8] devlink: Prepare code to fill multiple port function attributes

2020-09-17 Thread Parav Pandit
Prepare code to fill zero or more port function optional attributes. Subsequent patch makes use of this to fill more port function attributes. Signed-off-by: Parav Pandit Reviewed-by: Jiri Pirko --- net/core/devlink.c | 53 +- 1 file changed, 29 inser

[PATCH net-next 6/8] netdevsim: Simulate get/set hardware address of a PCI port

2020-09-17 Thread Parav Pandit
Allow users to get/set hardware address for the PCI port. Below example creates one devlink port, queries a port, sets a hardware address. Example of a PCI SF port which supports a port function hw_addr set: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_

[PATCH net-next 7/8] netdevsim: Simulate port function state for a PCI port

2020-09-17 Thread Parav Pandit
Simulate port function state of a PCI port. This enables users to get and set the state of the PCI port function. Example of a PCI SF port which supports a port function: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port show netdevsim/n

[PATCH net-next 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, introduce a PCI SF port

Re: [PATCH net-next] selftests: mptcp: interpret \n as a new line

2020-09-17 Thread Paolo Abeni
On Wed, 2020-09-16 at 15:13 +0200, Matthieu Baerts wrote: > In case of errors, this message was printed: > > (...) > # read: Resource temporarily unavailable > # client exit code 0, server 3 > # \nnetns ns1-0-BJlt5D socket stat for 10003: > (...) > > Obviously, the idea was to add a ne

Re: [PATCH bpf-next] selftests/bpf: Fix stat probe in d_path test

2020-09-17 Thread Jiri Olsa
On Wed, Sep 16, 2020 at 06:45:31PM -0700, Alexei Starovoitov wrote: > On Wed, Sep 16, 2020 at 01:24:16PM +0200, Jiri Olsa wrote: > > Some kernels builds might inline vfs_getattr call within fstat > > syscall code path, so fentry/vfs_getattr trampoline is not called. > > > > Alexei suggested [1] we

Re: [PATCH v3] mptcp: Fix unsigned 'max_seq' compared with zero in mptcp_data_queue_ofo

2020-09-17 Thread Paolo Abeni
On Thu, 2020-09-17 at 09:12 +0800, Ye Bin wrote: > Fixes coccicheck warnig: > net/mptcp/protocol.c:164:11-18: WARNING: Unsigned expression compared with > zero: max_seq > 0 > > Fixes: ab174ad8ef76 ("mptcp: move ooo skbs into msk out of order queue") > Reported-by: Hulk Robot > Signed-off-by: Ye

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > > The requirement to build resolve_btfids whenever CONFIG_DEBUG_INFO_BTF > > is enabled breaks some cross builds. For example, when building a 64-bit > > powerpc kernel on am

[PATCH v3] arm64: bpf: Fix branch offset in JIT

2020-09-17 Thread Ilias Apalodimas
Running the eBPF test_verifier leads to random errors looking like this: [ 6525.735488] Unexpected kernel BRK exception at EL1 [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP [ 6525.741609] Modules linked in: nls_utf8 cifs libdes libarc4 dns_resolver fscache binfmt_misc nls_a

Re: [PATCH net-next] net/packet: Fix a comment about mac_header

2020-09-17 Thread Willem de Bruijn
On Wed, Sep 16, 2020 at 8:54 PM Xie He wrote: > > 1. Change all "dev->hard_header" to "dev->header_ops" > > 2. On receiving incoming frames when header_ops == NULL: > > The comment only says what is wrong, but doesn't say what is right. > This patch changes the comment to make it clear what is rig

Re: [PATCH v3] arm64: bpf: Fix branch offset in JIT

2020-09-17 Thread Will Deacon
On Thu, Sep 17, 2020 at 11:49:25AM +0300, Ilias Apalodimas wrote: > Running the eBPF test_verifier leads to random errors looking like this: > > [ 6525.735488] Unexpected kernel BRK exception at EL1 > [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP > [ 6525.741609] Modules lin

[PATCH rdma-next v2 0/3] Fix in-kernel active_speed type

2020-09-17 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v2: * Changed WARN_ON casting to be saturated value instead while returning active_speed to the user. v1: https://lore.kernel.org/linux-rdma/20200902074503.743310-1-l...@kernel.org * Changed patch #1 to fix memory corruption to help with bisect. No change

[PATCH mlx5-next v2 2/3] RDMA/mlx5: Delete duplicated mlx5_ptys_width enum

2020-09-17 Thread Leon Romanovsky
From: Aharon Landau Combine two same enums to avoid duplication. Signed-off-by: Aharon Landau Reviewed-by: Michael Guralnik Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/main.c | 20 ++- .../mellanox/mlx5/core/ipoib/ethtool.c| 8

[PATCH mlx5-next v2 1/3] net/mlx5: Refactor query port speed functions

2020-09-17 Thread Leon Romanovsky
From: Aharon Landau The functions mlx5_query_port_link_width_oper and mlx5_query_port_ib_proto_oper are always called together, so combine them to a new function called mlx5_query_port_oper to avoid duplication. And while the mlx5i_get_port_settings is the same as mlx5_query_port_oper therefore

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 10:38:12AM +0200, Jiri Olsa wrote: > On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > > On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > > > The requirement to build resolve_btfids whenever CONFIG_DEBUG_INFO_BTF > > > is enabled breaks some cross b

Re: [PATCH] ptp: mark symbols static where possible

2020-09-17 Thread kernel test robot
use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Herrington/ptp-mark-symbols-static-where-possible/20200917-103557 base: https://git.kernel.org/pub/scm/linux/kernel/git/dav

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Jiri Olsa
On Thu, Sep 17, 2020 at 11:14:08AM +0200, Jiri Olsa wrote: > On Thu, Sep 17, 2020 at 10:38:12AM +0200, Jiri Olsa wrote: > > On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > > > On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > > > > The requirement to build resolve_btfids

Re: [PATCH] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-17 Thread Serge Semin
Hello Willy, Thanks for the patch. My comments are below. I've Cc'ed the U-boot/FreeBSD, who might be also interested in the solution you've provided. On Thu, Sep 17, 2020 at 09:47:33AM +0800, Willy Liu wrote: > RGMII RX Delay and TX Delay settings will not applied if Force TX RX Delay > Control

Re: [PATCH net-next] net/packet: Fix a comment about mac_header

2020-09-17 Thread Xie He
On Thu, Sep 17, 2020 at 1:51 AM Willem de Bruijn wrote: > > Acked-by: Willem de Bruijn Thank you, Willem!

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: >> >> +int bpf_check_attach_target(struct bpf_verifier_log *log, >> + const struct bpf_prog *prog, >> + const struct bpf_prog *tgt_prog, >> + u32 btf_id, >> + struct btf

Re: [PATCH nf-next v3 3/3] netfilter: Introduce egress hook

2020-09-17 Thread Laura García Liébana
Hi Daniel, On Tue, Sep 15, 2020 at 12:02 AM Daniel Borkmann wrote: > > On 9/14/20 1:29 PM, Laura García Liébana wrote: > > On Fri, Sep 11, 2020 at 6:28 PM Daniel Borkmann > > wrote: > >> On 9/11/20 9:42 AM, Laura García Liébana wrote: > >>> On Tue, Sep 8, 2020 at 2:55 PM Daniel Borkmann > >>>

Re: [EXT] Re: [net-next PATCH 0/2] Introduce mbox tracepoints for Octeontx2

2020-09-17 Thread sundeep subbaraya
On Thu, Sep 17, 2020 at 11:34 AM Jiri Pirko wrote: > > Wed, Sep 16, 2020 at 07:19:36PM CEST, sundeep.l...@gmail.com wrote: > >On Wed, Sep 16, 2020 at 4:04 PM Jiri Pirko wrote: > >> > >> Mon, Sep 07, 2020 at 12:59:45PM CEST, sundeep.l...@gmail.com wrote: > >> >Hi Jakub, > >> > > >> >On Sat, Sep 5,

[PATCH net-next RFC v2 1/3] devlink: Wrap trap related lists a trap_lists struct

2020-09-17 Thread Aya Levin
Bundle the trap related lists: trap_list, trap_group_list and trap_policer_list in a dedicated struct. This will be handy in the coming patches in the set introducing traps in devlink port context. With trap_lists, code reuse is much simpler. Signed-off-by: Aya Levin --- Changelog: v1->v2: Patch

[PATCH net-next RFC v2 2/3] devlink: Add devlink traps under devlink_ports context

2020-09-17 Thread Aya Levin
There are some cases where we would like to trap dropped packets only for a single port on a device without affecting the others. For that purpose: - Add trap lists and trap ops to devlink_port - Add corresponding trap API to manage traps - Add matching netlink commands Signed-off-by: Aya Levin -

[PATCH net-next RFC v2 0/3] Add devlink traps in devlink port context

2020-09-17 Thread Aya Levin
Implement support for devlink traps on per-port basis. Dropped packets in the RX flow are related to the Ethernet port and thus should be in port context. Traps per device should trap global configuration which may cause drops. Devlink traps is regard as a debug mode. Using traps per port enable de

[PATCH net-next RFC v2 3/3] net/mlx5e: Add devlink trap to catch oversize packets

2020-09-17 Thread Aya Levin
From: Aya Levin Register MTU error trap to allow visibility of oversize packets. Display a naive use of devlink trap in devlink port context. Signed-off-by: Aya Levin --- Changelog: v1->v2: -Minor changes in trap's definition -Adjustments to trap API and ops drivers/net/ethernet/mellanox/mlx5

[PATCH] netdevsim: fix semicolon.cocci warnings

2020-09-17 Thread kernel test robot
--- url: https://github.com/0day-ci/linux/commits/Parav-Pandit/devlink-Add-SF-add-delete-devlink-ops/20200917-162417 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git b948577b984a01d24d401d2264efbccc7f0146c1 port_function.c |4 ++-- 1 file changed, 2 insertions

Re: [PATCH v3] arm64: bpf: Fix branch offset in JIT

2020-09-17 Thread Catalin Marinas
On Thu, 17 Sep 2020 11:49:25 +0300, Ilias Apalodimas wrote: > Running the eBPF test_verifier leads to random errors looking like this: > > [ 6525.735488] Unexpected kernel BRK exception at EL1 > [ 6525.735502] Internal error: ptrace BRK handler: f2000100 [#1] SMP > [ 6525.741609] Modules linked in

Re: [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type

2020-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2020 at 12:02:20PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v2: > * Changed WARN_ON casting to be saturated value instead while returning > active_speed >to the user. > v1: https://lore.kernel.org/linux-rdma/20200902074503.743310-1-l...@kernel.o

[PATCH bpf v1] tools/bpftool: support passing BPFTOOL_VERSION to make

2020-09-17 Thread Tony Ambardar
This change facilitates out-of-tree builds, packaging, and versioning for test and debug purposes. Defining BPFTOOL_VERSION allows self-contained builds within the tools tree, since it avoids use of the 'kernelversion' target in the top-level makefile, which would otherwise pull in several other in

[PATCH net] net: wilc1000: clean up resource in error path of init mon interface

2020-09-17 Thread Huang Guobin
The wilc_wfi_init_mon_int() forgets to clean up resource when register_netdevice() failed. Add the missed call to fix it. And the return value of netdev_priv can't be NULL, so remove the unnecessary error handling. Fixes: 588713006ea4 ("staging: wilc1000: avoid the use of 'wilc_wfi_mon' static va

[PATCH net v2] hinic: fix potential resource leak

2020-09-17 Thread Wei Li
In rx_request_irq(), it will just return what irq_set_affinity_hint() returns. If it is failed, the napi and irq requested are not freed properly. So add exits for failures to handle these. Signed-off-by: Wei Li --- v1 -> v2: - Free irq as well when irq_set_affinity_hint() fails. --- drivers/ne

BPF redirect API design issue for BPF-prog MTU feedback?

2020-09-17 Thread Jesper Dangaard Brouer
As you likely know[1] I'm looking into moving the MTU check (for TC-BPF) in __bpf_skb_max_len() when e.g. called by bpf_skb_adjust_room(), because when redirecting packets to another netdev it is not correct to limit the MTU based on the incoming netdev. I was looking at doing the MTU check in b

[PATCH -next v2] net: hsr: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. net/hsr/hsr_debugfs.c | 21 ++--- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/net/hsr

Re: [PATCH -next] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread miaoqinglang
t new patches against linux-next(20200917), and they can be applied to mainline cleanly now. Thanks.

[PATCH -next v2] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Qinglang Miao
Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. .../freescale/dpaa2/dpaa2-eth-debugfs.c | 63 ++- 1 file changed, 6 insertions(+), 57 deletions(-) diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2

[PATCH net] drivers: net: Fix *_ipsec_offload_ok(): Use ip_hdr family

2020-09-17 Thread Christian Langrock
Xfrm_dev_offload_ok() is called with the unencrypted SKB. So in case of interfamily ipsec traffic (IPv4-in-IPv6 and IPv6 in IPv4) the check assumes the wrong family of the skb (IP family of the state). With this patch the ip header of the SKB is used to determine the family. Signed-off-by: Christi

Re: resolve_btfids breaks kernel cross-compilation

2020-09-17 Thread Seth Forshee
On Thu, Sep 17, 2020 at 11:14:06AM +0200, Jiri Olsa wrote: > On Thu, Sep 17, 2020 at 10:38:12AM +0200, Jiri Olsa wrote: > > On Thu, Sep 17, 2020 at 10:04:55AM +0200, Jiri Olsa wrote: > > > On Wed, Sep 16, 2020 at 02:47:33PM -0500, Seth Forshee wrote: > > > > The requirement to build resolve_btfids

Re: [PATCH net-next v2] net: phy: bcm7xxx: request and manage GPHY clock

2020-09-17 Thread Andrew Lunn
On Wed, Sep 16, 2020 at 07:04:13PM -0700, Florian Fainelli wrote: > The internal Gigabit PHY on Broadcom STB chips has a digital clock which > drives its MDIO interface among other things, the driver now requests > and manage that clock during .probe() and .remove() accordingly. > > Because the PH

Re: [PATCH net 2/2] net: phy: Do not warn in phy_stop() on PHY_DOWN

2020-09-17 Thread Andrew Lunn
On Wed, Sep 16, 2020 at 08:43:10PM -0700, Florian Fainelli wrote: > When phy_is_started() was added to catch incorrect PHY states, > phy_stop() would not be qualified against PHY_DOWN. It is possible to > reach that state when the PHY driver has been unbound and the network > device is then brought

Re: [PATCH net 1/2] net: phy: Avoid NPD upon phy_detach() when driver is unbound

2020-09-17 Thread Andrew Lunn
On Wed, Sep 16, 2020 at 08:43:09PM -0700, Florian Fainelli wrote: > If we have unbound the PHY driver prior to calling phy_detach() (often > via phy_disconnect()) then we can cause a NULL pointer de-reference > accessing the driver owner member. The steps to reproduce are: > > echo unimac-mdio-0:0

[PATCH v3,net-next,2/4] octeontx2-af: add support to manage the CPT unit

2020-09-17 Thread Srujana Challa
From: Srujana The Admin function (AF) manages hardware resources on the cryptographic acceleration unit(CPT). This patch adds a mailbox interface for PFs and VFs to configure hardware resources for cryptography and inline-ipsec. Signed-off-by: Suheil Chandran Signed-off-by: Vidya Sagar Velumuri

[PATCH net-next v4 4/5] ravb: Split delay handling in parsing and applying

2020-09-17 Thread Geert Uytterhoeven
Currently, full delay handling is done in both the probe and resume paths. Split it in two parts, so the resume path doesn't have to redo the parsing part over and over again. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Florian Fainelli --- v4: - Add Reviewed-

Re: RTL8402 stops working after hibernate/resume

2020-09-17 Thread Petr Tesarik
Hi Heiner, any comment on my findings? On Thu, 3 Sep 2020 10:41:22 +0200 Petr Tesarik wrote: > Hi Heiner, > > this issue was on the back-burner for some time, but I've got some > interesting news now. > > On Sat, 18 Jul 2020 14:07:50 +0200 > Heiner Kallweit wrote: > > >[...] > > Maybe the f

[PATCH net-next v4 0/5] net/ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Geert Uytterhoeven
Hi David, Jakub, Some Renesas EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured

RE: [PATCH net-next 5/8] netdevsim: Add support for add and delete of a PCI PF port

2020-09-17 Thread Parav Pandit
t/devlink-Add- > SF-add-delete-devlink-ops/20200917-162417 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > b948577b984a01d24d401d2264efbccc7f0146c1 > config: i386-randconfig-c003-20200917 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 &g

[PATCH net-next v4 3/5] dt-bindings: net: renesas,etheravb: Convert to json-schema

2020-09-17 Thread Geert Uytterhoeven
Convert the Renesas Ethernet AVB (EthernetAVB-IF) Device Tree binding documentation to json-schema. Add missing properties. Update the example to match reality. Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- v4: - Ad

[PATCH bpf-next] bpf: add support for other map types to bpf_map_lookup_and_delete_elem

2020-09-17 Thread Luka Oreskovic
Since this function already exists, it made sense to implement it for map types other than stack and queue. This patch adds the necessary parts from bpf_map_lookup_elem and bpf_map_delete_elem so it works as expected for all map types. Signed-off-by: Luka Oreskovic CC: Juraj Vijtiuk CC: Luka Per

[PATCH net-next v4 1/5] dt-bindings: net: ethernet-controller: Add internal delay properties

2020-09-17 Thread Geert Uytterhoeven
Internal Receive and Transmit Clock Delays are a common setting for RGMII capable devices. While these delays are typically applied by the PHY, some MACs support configuring internal clock delay settings, too. Hence add standardized properties to configure this. This is the MAC counterpart of co

[PATCH net-next v4 2/5] dt-bindings: net: renesas,ravb: Document internal clock delay properties

2020-09-17 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Add properties for configuring the internal MAC delays. These properties are m

[PATCH v3,net-next,0/4] Add Support for Marvell OcteonTX2 Cryptographic

2020-09-17 Thread Srujana Challa
The following series adds support for Marvell Cryptographic Acceleration Unit(CPT) on OcteonTX2 CN96XX SoC. This series is tested with CRYPTO_EXTRA_TESTS enabled and CRYPTO_DISABLE_TESTS disabled. Changes since v2: * Fixed C=1 warnings. * Added code to exit CPT VF driver gracefully. * Moved Oct

[PATCH net-next v4 5/5] ravb: Add support for explicit internal clock delay configuration

2020-09-17 Thread Geert Uytterhoeven
Some EtherAVB variants support internal clock delay configuration, which can add larger delays than the delays that are typically supported by the PHY (using an "rgmii-*id" PHY mode, and/or "[rt]xc-skew-ps" properties). Historically, the EtherAVB driver configured these delays based on the "rgmii-

Re: [PATCH -next v2] dpaa2-eth: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-17 Thread Ioana Ciornei
On Thu, Sep 17, 2020 at 08:45:08PM +0800, Qinglang Miao wrote: > Signed-off-by: Qinglang Miao Reviewed-by: Ioana Ciornei > --- > v2: based on linux-next(20200917), and can be applied to > mainline cleanly now. > > .../freescale/dpaa2/dpaa2-eth-de

[PATCH v3,net-next,1/4] octeontx2-pf: move asm code to include/linux/soc

2020-09-17 Thread Srujana Challa
On OcteonTX2 platform CPT instruction enqueue and NIX packet send are only possible via LMTST operations which uses LDEOR instruction. This patch moves the asm code from OcteonTX2 nic driver to include/linux/soc as it will be used by OcteonTX2 CPT and NIC driver for LMTST. Signed-off-by: Srujana C

Re: [PATCH bpf v1] tools/bpftool: support passing BPFTOOL_VERSION to make

2020-09-17 Thread Quentin Monnet
On 17/09/2020 12:58, Tony Ambardar wrote: > This change facilitates out-of-tree builds, packaging, and versioning for > test and debug purposes. Defining BPFTOOL_VERSION allows self-contained > builds within the tools tree, since it avoids use of the 'kernelversion' > target in the top-level makefi

Re: [PATCH 3/3] docs: bpf: ringbuf.rst: fix a broken cross-reference

2020-09-17 Thread Alexei Starovoitov
On Thu, Sep 17, 2020 at 1:04 AM Mauro Carvalho Chehab wrote: > > Sphinx warns about a broken cross-reference: > > Documentation/bpf/ringbuf.rst:194: WARNING: Unknown target name: > "bench_ringbufs.c". > > It seems that the original idea were to add a reference for this file: > > t

Re: ath11k: initialize wmi config based on hw_params

2020-09-17 Thread Kalle Valo
Colin Ian King writes: > Hi, > > static analysis with Coverity has detected a duplicated assignment issue > with the following commit: > > commit 2d4bcbed5b7d53e19fc158885e7340b464b64507 > Author: Carl Huang > Date: Mon Aug 17 13:31:51 2020 +0300 > > ath11k: initialize wmi config based on

[PATCH net-next] selftests: Set default protocol for raw sockets in nettest

2020-09-17 Thread David Ahern
IPPROTO_IP (0) is not valid for raw sockets. Default the protocol for raw sockets to IPPROTO_RAW if the protocol has not been set via the -P option. Signed-off-by: David Ahern --- tools/testing/selftests/net/nettest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/

Re: [PATCH net-next 6/7] lockdep: provide dummy forward declaration of *_is_held() helpers

2020-09-17 Thread peterz
On Wed, Sep 16, 2020 at 11:45:27AM -0700, Jakub Kicinski wrote: > When CONFIG_LOCKDEP is not set, lock_is_held() and lockdep_is_held() > are not declared or defined. This forces all callers to use ifdefs > around these checks. > > Recent RCU changes added a lot of lockdep_is_held() calls inside >

Re: [PATCH bpf-next v4] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-17 Thread Martin KaFai Lau
On Wed, Sep 16, 2020 at 03:46:45PM -0700, Yonghong Song wrote: > If a bucket contains a lot of sockets, during bpf_iter traversing > a bucket, concurrent userspace bpf_map_update_elem() and > bpf program bpf_sk_storage_{get,delete}() may experience > some undesirable delays as they will compete wit

[PATCH net-next] net: mdio: octeon: Select MDIO_DEVRES

2020-09-17 Thread Andrew Lunn
This driver makes use of devm_mdiobus_alloc_size. To ensure this is available select MDIO_DEVRES which provides it. Signed-off-by: Andrew Lunn --- drivers/net/mdio/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig index 1299880dfe74..

Re: [PATCH] ath10k: qmi: Skip host capability request for Xiaomi Poco F1

2020-09-17 Thread Bjorn Andersson
On Thu 17 Sep 02:41 CDT 2020, Amit Pundir wrote: > Workaround to get WiFi working on Xiaomi Poco F1 (sdm845) > phone. We get a non-fatal QMI_ERR_MALFORMED_MSG_V01 error > message in ath10k_qmi_host_cap_send_sync(), but we can still > bring up WiFi services successfully on AOSP if we ignore it. >

Re: [PATCH net 1/2] net: phy: Avoid NPD upon phy_detach() when driver is unbound

2020-09-17 Thread Florian Fainelli
On 9/17/2020 6:15 AM, Andrew Lunn wrote: On Wed, Sep 16, 2020 at 08:43:09PM -0700, Florian Fainelli wrote: If we have unbound the PHY driver prior to calling phy_detach() (often via phy_disconnect()) then we can cause a NULL pointer de-reference accessing the driver owner member. The steps to

[PATCH bpf-next v4] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-17 Thread Yonghong Song
If a bucket contains a lot of sockets, during bpf_iter traversing a bucket, concurrent userspace bpf_map_update_elem() and bpf program bpf_sk_storage_{get,delete}() may experience some undesirable delays as they will compete with bpf_iter for bucket lock. Note that the number of buckets for bpf_sk

Re: [PATCH bpf-next v5 2/8] bpf: verifier: refactor check_attach_btf_id()

2020-09-17 Thread Andrii Nakryiko
On Thu, Sep 17, 2020 at 3:06 AM Toke Høiland-Jørgensen wrote: > > Andrii Nakryiko writes: > > >> > >> +int bpf_check_attach_target(struct bpf_verifier_log *log, > >> + const struct bpf_prog *prog, > >> + const struct bpf_prog *tgt_prog, > >> +

Re: [PATCH rdma-next v2 0/3] Fix in-kernel active_speed type

2020-09-17 Thread Leon Romanovsky
On Thu, Sep 17, 2020 at 08:41:54AM -0300, Jason Gunthorpe wrote: > On Thu, Sep 17, 2020 at 12:02:20PM +0300, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Changelog: > > v2: > > * Changed WARN_ON casting to be saturated value instead while returning > > active_speed > >to the user

[PATCH] net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC

2020-09-17 Thread Necip Fazil Yildiran
When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for CRYPTO_HMAC Depends on [n]: CRYPTO [=n] Selected by [y]: - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y] WARNING: unmet direct depen

[PATCH bpf-next] bpf: Use hlist_add_head_rcu when linking to local_storage

2020-09-17 Thread Martin KaFai Lau
The local_storage->list will be traversed by rcu reader in parallel. Thus, hlist_add_head_rcu() is needed in bpf_selem_link_storage_nolock(). This patch fixes it. This part of the code has recently been refactored in bpf-next and this patch makes changes to the new file "bpf_local_storage.c". Inst

Re: [PATCH bpf-next v3] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-17 Thread Martin KaFai Lau
On Tue, Sep 15, 2020 at 11:16:49PM -0700, Yonghong Song wrote: [ ... ] > diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c > index 4a86ea34f29e..d43c3d6d0693 100644 > --- a/net/core/bpf_sk_storage.c > +++ b/net/core/bpf_sk_storage.c > @@ -678,6 +678,7 @@ struct bpf_iter_seq_sk_sto

Re: [PATCH bpf-next v3] bpf: using rcu_read_lock for bpf_sk_storage_map iterator

2020-09-17 Thread Yonghong Song
On 9/16/20 10:55 AM, Martin KaFai Lau wrote: On Tue, Sep 15, 2020 at 11:16:49PM -0700, Yonghong Song wrote: [ ... ] diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c index 4a86ea34f29e..d43c3d6d0693 100644 --- a/net/core/bpf_sk_storage.c +++ b/net/core/bpf_sk_storage.c @@ -6

Re: [PATCH bpf-next v5 5/8] bpf: Fix context type resolving for extension programs

2020-09-17 Thread Toke Høiland-Jørgensen
Andrii Nakryiko writes: > On Wed, Sep 16, 2020 at 12:59 PM Andrii Nakryiko > wrote: >> >> On Tue, Sep 15, 2020 at 5:50 PM Toke Høiland-Jørgensen >> wrote: >> > >> > From: Toke Høiland-Jørgensen >> > >> > Eelco reported we can't properly access arguments if the tracing >> > program is attached

Re: [PATCH net-next] net: mdio: octeon: Select MDIO_DEVRES

2020-09-17 Thread Randy Dunlap
On 9/17/20 9:19 AM, Andrew Lunn wrote: > This driver makes use of devm_mdiobus_alloc_size. To ensure this is > available select MDIO_DEVRES which provides it. > Reported-by: Randy Dunlap Acked-by: Randy Dunlap # build-tested Thanks. > Signed-off-by: Andrew Lunn > --- > drivers/net/mdio/Kcon

[PATCH bpf] bpf: Use hlist_add_head_rcu when linking to sk_storage

2020-09-17 Thread Martin KaFai Lau
The sk_storage->list will be traversed by rcu reader in parallel. Thus, hlist_add_head_rcu() is needed in __selem_link_sk(). This patch fixes it. This part of the code has recently been refactored in bpf-next. A separate fix will be provided for the bpf-next tree. Fixes: 6ac99e8f23d4 ("bpf: Intr

[PATCH net-next v2 0/8] devlink: Add SF add/delete devlink ops

2020-09-17 Thread Parav Pandit
Hi Dave, Jakub, Similar to PCI VF, PCI SF represents portion of the device. PCI SF is represented using a new devlink port flavour. This short series implements small part of the RFC described in detail at [1] and [2]. It extends (a) devlink core to expose new devlink port flavour 'pcisf'. (b)

[PATCH net-next v2 2/8] devlink: Support add and delete devlink port

2020-09-17 Thread Parav Pandit
Extended devlink interface for the user to add and delete port. Extend devlink to connect user requests to driver to add/delete such port in the device. When driver routines are invoked, devlink instance lock is not held. This enables driver to perform several devlink objects registration, unregis

[PATCH net-next v2 1/8] devlink: Introduce PCI SF port flavour and port attribute

2020-09-17 Thread Parav Pandit
A PCI sub-function (SF) represents a portion of the device similar to PCI VF. In an eswitch, PCI SF may have port which is normally represented using a representor netdevice. To have better visibility of eswitch port, its association with SF, and its representor netdevice, introduce a PCI SF port

[PATCH net-next v2 8/8] netdevsim: Add support for add and delete PCI SF port

2020-09-17 Thread Parav Pandit
Simulate PCI SF ports. Allow user to create one or more PCI SF ports. Examples: Create a PCI PF and PCI SF port. $ devlink port add netdevsim/netdevsim10/10 flavour pcipf pfnum 0 $ devlink port add netdevsim/netdevsim10/11 flavour pcisf pfnum 0 sfnum 44 $ devlink port show netdevsim/netdevsim10/1

[PATCH net-next v2 5/8] netdevsim: Add support for add and delete of a PCI PF port

2020-09-17 Thread Parav Pandit
Simulate PCI PF ports. Allow user to create one or more PCI PF ports. Examples: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device Add and show devlink port of flavour 'pcipf' for PF number 0. $ devlink port add netdevsim/netdevsim10/10 flavour pcipf

[PATCH net-next v2 6/8] netdevsim: Simulate get/set hardware address of a PCI port

2020-09-17 Thread Parav Pandit
Allow users to get/set hardware address for the PCI port. Below example creates one devlink port, queries a port, sets a hardware address. Example of a PCI SF port which supports a port function hw_addr set: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_

[PATCH net-next v2 4/8] devlink: Support get and set state of port function

2020-09-17 Thread Parav Pandit
devlink port function can be in active or inactive state. Allow users to get and set port function's state. Example of a PCI SF port which supports a port function: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port show netdevsim/netdevs

[PATCH net-next v2 7/8] netdevsim: Simulate port function state for a PCI port

2020-09-17 Thread Parav Pandit
Simulate port function state of a PCI port. This enables users to get and set the state of the PCI port function. Example of a PCI SF port which supports a port function: Create a device with ID=10 and one physical port. $ echo "10 1" > /sys/bus/netdevsim/new_device $ devlink port add netdevsim/n

  1   2   3   4   5   >