Re: [PATCH net-next 2/2] dt-bindings: net: dsa: b53: Drop old bindings

2020-10-15 Thread Kurt Kanzenbach
On Mon Oct 12 2020, Rob Herring wrote: > On Sat, Oct 10, 2020 at 06:46:27PM +0200, Kurt Kanzenbach wrote: >> The device tree bindings have been converted to YAML. No need to keep >> the text file around. Update MAINTAINERS file accordingly. > > You can squash this into the previous patch. OK, sure

Re: [PATCH v3] net: Add mhi-net driver

2020-10-15 Thread Eric Dumazet
On 10/14/20 1:53 PM, Loic Poulain wrote: > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control + PDN mux). > ... > +static void mhi_net_rx_refill_work(struct work_struct

Re: [PATCH net-next 3/9] net: 8021q: resolve forwarding path for vlan devices

2020-10-15 Thread kernel test robot
Hi Pablo, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Pablo-Neira-Ayuso/netfilter-flowtable-bridge-and-vlan-enhancements/20201015-091818 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-15 Thread Linus Walleij
On Thu, Oct 8, 2020 at 5:46 PM Arnd Bergmann wrote: > With Arm EBSA110 gone, nothing uses it any more, so the corresponding > code and the Kconfig option can be removed. > > Signed-off-by: Arnd Bergmann Very nice cleanup. Reviewed-by: Linus Walleij At some point we should do a retrospect abou

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
On 2020-10-14 12:44:23 [+0200], Eelco Chaudron wrote: > Let me know your thoughts. better. If your seccount is per-CPU then you get away without explicit writer locking if you rely on global per-CPU locking. You can't do preempt_disable() because this section can be interrupt by softirq. You need

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 9:55, Sebastian Andrzej Siewior wrote: On 2020-10-14 12:44:23 [+0200], Eelco Chaudron wrote: Let me know your thoughts. better. If your seccount is per-CPU then you get away without explicit writer locking if you rely on global per-CPU locking. You can't do preempt_disab

Re: [PATCH net-next] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
On 2020-10-15 10:11:31 [+0200], Eelco Chaudron wrote: > Thanks for your reply! Yes I had it replaced with local_bh_disable() in my > v2, as I noticed the hard IRQ to softirq part earlier. Okay. Resend the complete thing once you ready and I take a look. > Thanks, > > Eelco Sebastian

[PATCH v2] IPv6: sr: Fix End.X nexthop to use oif.

2020-10-15 Thread Reji Thomas
Currently End.X action doesn't consider the outgoing interface while looking up the nexthop.This breaks packet path functionality specifically while using link local address as the End.X nexthop. The patch fixes this by enforcing End.X action to have both nh6 and oif and using oif in lookup.It seem

RE: [EXT] Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load microcode and create engine groups

2020-10-15 Thread Srujana Challa
> Subject: [EXT] Re: [PATCH v7,net-next,07/13] crypto: octeontx2: load microcode > and create engine groups > > External Email > > -- > On Mon, 12 Oct 2020 16:27:13 +0530 Srujana Challa wrote: > > +/* tar header as defined in POS

[PATCH net] selftests: forwarding: Add missing 'rp_filter' configuration

2020-10-15 Thread Ido Schimmel
From: Ido Schimmel When 'rp_filter' is configured in strict mode (1) the tests fail because packets received from the macvlan netdevs would not be forwarded through them on the reverse path. Fix this by disabling the 'rp_filter', meaning no source validation is performed. Fixes: 1538812e0880 ("

[PATCH v2] net: phy: Prevent reporting advertised modes when autoneg is off

2020-10-15 Thread Łukasz Stelmach
Do not report advertised link modes (local and remote) when autonegotiation is turned off. mii_ethtool_get_link_ksettings() exhibits the same behaviour and this patch aims at unifying the behavior of both functions. Signed-off-by: Łukasz Stelmach --- Changes in v2: - clear lp_advertising - se

Re: [PATCH 2/2] Revert "dccp: don't free ccid2_hc_tx_sock struct in dccp_disconnect()"

2020-10-15 Thread Kleber Souza
On 15.10.20 05:42, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:49 +0200 Kleber Sacilotto de Souza wrote: >> From: Thadeu Lima de Souza Cascardo >> >> This reverts commit 2677d20677314101293e6da0094ede7b5526d2b1. >> >> This fixes an issue that after disconnect, dccps_hc_tx_ccid will still be

Re: selftests: netfilter: nft_nat.sh: /dev/stdin:2:9-15: Error: syntax error, unexpected counter

2020-10-15 Thread Pablo Neira Ayuso
On Thu, Oct 15, 2020 at 08:31:52AM +0530, Naresh Kamboju wrote: > On Thu, 15 Oct 2020 at 01:00, Pablo Neira Ayuso wrote: > > > > On Wed, Oct 14, 2020 at 05:19:33PM +0530, Naresh Kamboju wrote: > > > While running kselftest netfilter test on x86_64 devices linux next > > > tag 20201013 kernel > > >

[patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case

2020-10-15 Thread Rtp
commit d934423ac26ed373dfe089734d505dca5ff679b6 upstream. Orion5.x systems are still using machine files and not device-tree. Commit 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be specified for orion-mdio") has replaced devm_clk_get() with of_clk_get(), leading to a oops at boot an

[PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also called in the netlink context, which is preemptible. The below patch makes sure that even in the netlink path, preemption

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-15 Thread Russell King - ARM Linux admin
On Thu, Oct 15, 2020 at 09:53:29AM +0200, Linus Walleij wrote: > On Thu, Oct 8, 2020 at 5:46 PM Arnd Bergmann wrote: > > > With Arm EBSA110 gone, nothing uses it any more, so the corresponding > > code and the Kconfig option can be removed. > > > > Signed-off-by: Arnd Bergmann > > Very nice cle

Re: [patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case

2020-10-15 Thread Greg KH
On Thu, Oct 15, 2020 at 11:32:15AM +0200, Arnaud Patard wrote: > commit d934423ac26ed373dfe089734d505dca5ff679b6 upstream. > > Orion5.x systems are still using machine files and not device-tree. > Commit 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be > specified for orion-mdio") ha

Re: [patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case

2020-10-15 Thread Rtp
Greg KH writes: > On Thu, Oct 15, 2020 at 11:32:15AM +0200, Arnaud Patard wrote: >> commit d934423ac26ed373dfe089734d505dca5ff679b6 upstream. >> >> Orion5.x systems are still using machine files and not device-tree. >> Commit 96cb4342382290c9 ("net: mvmdio: allow up to three clocks to be >> spec

Re: [PATCH v3] net: Add mhi-net driver

2020-10-15 Thread Loic Poulain
On Thu, 15 Oct 2020 at 09:25, Eric Dumazet wrote: > > > > On 10/14/20 1:53 PM, Loic Poulain wrote: > > This patch adds a new network driver implementing MHI transport for > > network packets. Packets can be in any format, though QMAP (rmnet) > > is the usual protocol (flow control + PDN mux). > >

[PATCH v4 1/2] net: Add mhi-net driver

2020-10-15 Thread Loic Poulain
This patch adds a new network driver implementing MHI transport for network packets. Packets can be in any format, though QMAP (rmnet) is the usual protocol (flow control + PDN mux). It support two MHI devices, IP_HW0 which is, the path to the IPA (IP accelerator) on qcom modem, And IP_SW0 which i

[PATCH v4] net: Add mhi-net driver

2020-10-15 Thread Loic Poulain
This patch adds a new network driver implementing MHI transport for network packets. Packets can be in any format, though QMAP (rmnet) is the usual protocol (flow control + PDN mux). It support two MHI devices, IP_HW0 which is, the path to the IPA (IP accelerator) on qcom modem, And IP_SW0 which i

Re: [PATCH v4 1/2] net: Add mhi-net driver

2020-10-15 Thread Loic Poulain
Please ignore this one, the title is wrong (it's not patch 1/2). On Thu, 15 Oct 2020 at 12:25, Loic Poulain wrote: > > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control +

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 11:46 AM, Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must not be > preempted. However, this is fine in the general napi use case where > the local BH is disabled. But, it's also called in the netlink > context, which is preemptible. The below patch

Re: [PATCH 1/2] dccp: ccid: move timers to struct dccp_sock

2020-10-15 Thread Thadeu Lima de Souza Cascardo
On Wed, Oct 14, 2020 at 08:43:22PM -0700, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 19:18:48 +0200 Kleber Sacilotto de Souza wrote: > > From: Thadeu Lima de Souza Cascardo > > > > When dccps_hc_tx_ccid is freed, ccid timers may still trigger. The reason > > del_timer_sync can't be used is becau

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 12:27, Ilya Maximets wrote: On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must not be preempted. However, this is fine in the general napi use case where the local BH is disabled. But, it's also called in the netlink c

Re: [PATCH] net: sockmap: Don't call bpf_prog_put() on NULL pointer

2020-10-15 Thread Jakub Sitnicki
On Thu, Oct 15, 2020 at 06:43 AM CEST, John Fastabend wrote: [...] > Jakub, any opinions on if we should just throw an error if users try to > add a sock to a map with a parser but no verdict? At the moment we fall > through and add the socket, but it wont do any receive parsing/verdict. > At the

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 12:54 PM, Eelco Chaudron wrote: > > > On 15 Oct 2020, at 12:27, Ilya Maximets wrote: > >> On 10/15/20 11:46 AM, Eelco Chaudron wrote: >>> The flow_lookup() function uses per CPU variables, which must not be >>> preempted. However, this is fine in the general napi use case where >>> t

Re: [PATCH v1 1/6] staging: qlge: Initialize devlink health dump framework for the dlge driver

2020-10-15 Thread Benjamin Poirier
On 2020-10-15 11:37 +0800, Coiby Xu wrote: > On Tue, Oct 13, 2020 at 09:37:04AM +0900, Benjamin Poirier wrote: > > On 2020-10-12 19:24 +0800, Coiby Xu wrote: > > [...] > > > > I think, but didn't check in depth, that in those drivers, the devlink > > > > device is tied to the pci device and can exi

[PATCH] rsi: Fix TX EAPOL packet handling against iwlwifi AP

2020-10-15 Thread Marek Vasut
In case RSI9116 SDIO WiFi operates in STA mode against Intel 9260 in AP mode, the association fails. The former is using wpa_supplicant during association, the later is set up using hostapd: iwl$ cat hostapd.conf interface=wlp1s0 ssid=test country_code=DE hw_mode=g channel=1 wpa=2 wpa_passphrase=t

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Ilya Maximets
On 10/15/20 1:04 PM, Ilya Maximets wrote: > On 10/15/20 12:54 PM, Eelco Chaudron wrote: >> >> >> On 15 Oct 2020, at 12:27, Ilya Maximets wrote: >> >>> On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must not be preempted. However, this

RE: [EXT] Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-15 Thread Srujana Challa
> Subject: [EXT] Re: [PATCH v7,net-next,04/13] drivers: crypto: add Marvell > OcteonTX2 CPT PF driver > > External Email > > -- > On Mon, 12 Oct 2020 16:27:10 +0530 Srujana Challa wrote: > > +union otx2_cptx_lf_misc_int { > > +

[PATCH 2/3] gtp: Add LSM hooks to GPRS Tunneling Protocol (GTP)

2020-10-15 Thread Richard Haines
Add security hooks to allow security modules to exercise access control over GTP. The 'struct gtp_dev' has been moved to include/net/gtp.h so that it is visible to LSM security modules where their security blob is stored. Signed-off-by: Richard Haines --- drivers/net/gtp.c | 50

Re: [net-next PATCH 06/10] octeontx2-af: Add NIX1 interfaces to NPC

2020-10-15 Thread sundeep subbaraya
Hi Jakub, On Thu, Oct 15, 2020 at 8:18 AM Jakub Kicinski wrote: > > On Tue, 13 Oct 2020 15:56:28 +0530 sundeep.l...@gmail.com wrote: > > -static const struct npc_mcam_kex npc_mkex_default = { > > +static struct npc_mcam_kex npc_mkex_default = { > > .mkex_sign = MKEX_SIGN, > > .name =

Vorschlag

2020-10-15 Thread Yi Huiman
ich habe ein Geschäft Vorschlag für dich.

Re: [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Sebastian Andrzej Siewior
On 2020-10-15 11:46:53 [+0200], Eelco Chaudron wrote: > The flow_lookup() function uses per CPU variables, which must not be > preempted. However, this is fine in the general napi use case where > the local BH is disabled. But, it's also called in the netlink > context, which is preemptible. The be

Re: [PATCH 3/3] timekeeping: remove arch_gettimeoffset

2020-10-15 Thread Linus Walleij
On Thu, Oct 15, 2020 at 11:53 AM Russell King - ARM Linux admin wrote: > Don't be misled. It was not a matter of "enough gritty people", it > was a matter that EBSA110 was blocking it. I remember that EBSA110 was quite different in that it had this especially limited PIT timer, true that. At one

Re: [PATCH v4 1/2] net: Add mhi-net driver

2020-10-15 Thread Eric Dumazet
On 10/15/20 12:31 PM, Loic Poulain wrote: > This patch adds a new network driver implementing MHI transport for > network packets. Packets can be in any format, though QMAP (rmnet) > is the usual protocol (flow control + PDN mux). > > It support two MHI devices, IP_HW0 which is, the path to the

Re: [PATCHv3 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP

2020-10-15 Thread Marcelo Ricardo Leitner
On Wed, Oct 14, 2020 at 08:34:16PM -0700, Jakub Kicinski wrote: > On Tue, 13 Oct 2020 15:27:25 +0800 Xin Long wrote: > > Description From the RFC: > > > >The Main Reasons: > > > >o To allow SCTP traffic to pass through legacy NATs, which do not > > provide native SCTP support as sp

Re: [ovs-dev] [PATCH net v2] net: openvswitch: fix to make sure flow_lookup() is not preempted

2020-10-15 Thread Eelco Chaudron
On 15 Oct 2020, at 13:22, Ilya Maximets wrote: On 10/15/20 1:04 PM, Ilya Maximets wrote: On 10/15/20 12:54 PM, Eelco Chaudron wrote: On 15 Oct 2020, at 12:27, Ilya Maximets wrote: On 10/15/20 11:46 AM, Eelco Chaudron wrote: The flow_lookup() function uses per CPU variables, which must n

[PATCH v1 0/2] add ast2400/2500 phy-handle support

2020-10-15 Thread Ivan Mikhaylov
This patch introduces ast2400/2500 phy-handle support with an embedded MDIO controller. At the current moment it is not possible to set options with this format on ast2400/2500: mac { phy-handle = <&phy>; phy-mode = "rgmii"; mdio { #address-cells = <1>;

[PATCH v1 1/2] net: ftgmac100: move phy connect out from ftgmac100_setup_mdio

2020-10-15 Thread Ivan Mikhaylov
Split MDIO registration and PHY connect into ftgmac100_setup_mdio and ftgmac100_mii_probe. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 92 1 file changed, 47 insertions(+), 45 deletions(-) diff --git a/drivers/net/ethernet/faraday/ftgmac

[PATCH v1 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-15 Thread Ivan Mikhaylov
phy-handle can't be handled well for ast2400/2500 which has an embedded MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize PHYs from mdio child node with of_mdiobus_register. Signed-off-by: Ivan Mikhaylov --- drivers/net/ethernet/faraday/ftgmac100.c | 24 ++

[PATCH net-next 0/2] rxrpc: Fixes

2020-10-15 Thread David Howells
/dhowells/linux-fs.git rxrpc-next-20201015 David --- David Howells (2): rxrpc: Fix bundle counting for exclusive connections rxrpc: Fix loss of final ack on shutdown net/rxrpc/ar-internal.h | 1 + net/rxrpc/conn_client.c | 3 +++ net/rxrpc/conn_event.c | 6 +++--- 3 files

[PATCH net-next 2/2] rxrpc: Fix loss of final ack on shutdown

2020-10-15 Thread David Howells
Fix the loss of transmission of a call's final ack when a socket gets shut down. This means that the server will retransmit the last data packet or send a ping ack and then get an ICMP indicating the port got closed. The server will then view this as a failure. Fixes: 3136ef49a14c ("rxrpc: Delay

[PATCH net-next 1/2] rxrpc: Fix bundle counting for exclusive connections

2020-10-15 Thread David Howells
Fix rxrpc_unbundle_conn() to not drop the bundle usage count when cleaning up an exclusive connection. Based on the suggested fix from Hillf Danton. Fixes: 245500d853e9 ("rxrpc: Rewrite the client connection manager") Reported-by: syzbot+d57aaf84dd8a550e6...@syzkaller.appspotmail.com Signed-off-b

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-15 Thread Michael S. Tsirkin
On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote: > > On 2020/10/14 上午7:42, si-wei liu wrote: > > > > > > > > > So what I suggest is to fix the pinning leakage first and do the > > > possible optimization on top (which is still questionable to me). > > OK. Unfortunately, this was picke

Re: [PATCH v4 1/2] net: Add mhi-net driver

2020-10-15 Thread Loic Poulain
On Thu, 15 Oct 2020 at 14:41, Eric Dumazet wrote: > > > > On 10/15/20 12:31 PM, Loic Poulain wrote: > > This patch adds a new network driver implementing MHI transport for > > network packets. Packets can be in any format, though QMAP (rmnet) > > is the usual protocol (flow control + PDN mux). > >

Re: [Patch net v2] ip_gre: set dev->hard_header_len and dev->needed_headroom properly

2020-10-15 Thread Willem de Bruijn
On Wed, Oct 14, 2020 at 10:25 PM Xie He wrote: > > On Wed, Oct 14, 2020 at 6:38 PM Xie He wrote: > > > > On Wed, Oct 14, 2020 at 1:19 PM Willem de Bruijn > > wrote: > > > > > > On Wed, Oct 14, 2020 at 3:48 PM Xie He wrote: > > > > > > > > I thought we agreed that ideally GRE devices would not h

[PATCH] net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-10-15 Thread Fedor Tokarev
'snprintf' returns the number of characters which would have been written if enough space had been available, excluding the terminating null byte. Thus, the return value of 'sizeof(buf)' means that the last character has been dropped. Signed-off-by: Fedor Tokarev --- net/sunrpc/debugfs.c | 4 ++-

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-15 Thread Jérôme Pouiller
On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote: > On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote: > > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote: > > > On Monday 12 October 2020 12:46:32 Jerome Pouiller wrote: > > > > +#define SDIO_VENDOR_ID_SILABS0x

Re: [PATCH bpf-next] bpf: Fix register equivalence tracking.

2020-10-15 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 14 Oct 2020 10:56:08 -0700 you wrote: > From: Alexei Starovoitov > > The 64-bit JEQ/JNE handling in reg_set_min_max() was clearing reg->id in > either > true or false branch. In the case 'if (reg->id)' check was don

Re: [Linux-kernel-mentees] [PATCH] net: rose: Fix Null pointer dereference in rose_send_frame()

2020-10-15 Thread Anmol Karn
On Thu, Oct 15, 2020 at 07:12:25AM +0200, Greg KH wrote: > On Thu, Oct 15, 2020 at 05:47:12AM +0530, Anmol Karn wrote: > > In rose_send_frame(), when comparing two ax.25 addresses, it assigns > > rose_call to > > either global ROSE callsign or default port, but when the former block > > triggers

perf measure for stalled cycles per instruction on newer Intel processors

2020-10-15 Thread Or Gerlitz
Hi, Earlier Intel processors (e.g E5-2650) support the more of classical two stall events (for backend and frontend [1]) and then perf shows the nice measure of stalled cycles per instruction - e.g here where we have IPC of 0.91 and CSPI (see [2]) of 0.68: 9,568,273,970 cycles

RE: linux-next: Tree for Oct 15 (drivers/net/pcs/pcs-xpcs.o)

2020-10-15 Thread Jose Abreu
From: Randy Dunlap Date: Oct/15/2020, 15:45:57 (UTC+00:00) > On 10/15/20 12:28 AM, Stephen Rothwell wrote: > > Hi all, > > > > Since the merge window is open, please do not add any v5.11 material to > > your linux-next included branches until after v5.10-rc1 has been released. > > > > News: the

Re: [PATCH v2] Add support for mv88e6393x family of Marvell.

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 12:26:06 +1000 Pavana Sharma wrote: > The Marvell 88E6393X device is a single-chip integration of a 11-port > Ethernet switch with eight integrated Gigabit Ethernet (GbE) transceivers > and three 10-Gigabit interfaces. > > This patch adds functionalities specific to mv88e6393x

Re: [PATCH net-next 9/9] netfilter: flowtable: add vlan support

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 03:16:30 +0200 Pablo Neira Ayuso wrote: > Add the vlan id and proto to the flow tuple to uniquely identify flows > from the receive path. Store the vlan id and proto to set it accordingly > from the transmit path. This patch includes support for two VLAN headers > (Q-in-Q). > >

AW: [PATCH] net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-10-15 Thread Walter Harms
if xprt->debugfs->d_name.name can be what ever long it is more clever to use kasprintf() the some for link (no idea how many xprt als possible) jm2c wh Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktober 2020 15:59 An: bfie...@field

Re: [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comment below. Regards Henrik The 10/14/2020 16:33, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:26 + Henrik Bjoernlund wrote: > > + if (nla_put_u32(skb,

Re: [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread henrik.bjoernl...@microchip.com
Thanks for your review. Regards Henrik The 10/14/2020 10:54, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 2020-10-12 at 14:04 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink con

Re: [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:00, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:22 + Henrik Bjoernlund wrote: > > with restricted management access

Re: [PATCH net-next 9/9] netfilter: flowtable: add vlan support

2020-10-15 Thread Pablo Neira Ayuso
On Thu, Oct 15, 2020 at 08:10:13AM -0700, Jakub Kicinski wrote: > On Thu, 15 Oct 2020 03:16:30 +0200 Pablo Neira Ayuso wrote: > > Add the vlan id and proto to the flow tuple to uniquely identify flows > > from the receive path. Store the vlan id and proto to set it accordingly > > from the transmit

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:26, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > + /* This CCM related status i

Re: [PATCH net-next v5 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:30, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:22 + Henrik Bjoernlund wrote: > > + if (config->mdlevel > 7) { >

Re: [PATCH net-next v5 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 16:16, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:24 + Henrik Bjoernlund wrote: > > +struct br_cfm_status_tlv { > > +

Re: [PATCH net-next v5 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 15:59, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 12 Oct 2020 14:04:23 + Henrik Bjoernlund wrote: > > + skb = dev_alloc_skb(CFM_CCM_

Re: [net-next PATCH 06/10] octeontx2-af: Add NIX1 interfaces to NPC

2020-10-15 Thread Jakub Kicinski
On Thu, 15 Oct 2020 17:53:07 +0530 sundeep subbaraya wrote: > Hi Jakub, > > On Thu, Oct 15, 2020 at 8:18 AM Jakub Kicinski wrote: > > > > On Tue, 13 Oct 2020 15:56:28 +0530 sundeep.l...@gmail.com wrote: > > > -static const struct npc_mcam_kex npc_mkex_default = { > > > +static struct npc_mcam_k

Re: [PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-15 Thread Henrik Bjoernlund
Thanks for your review. Comments below. Regards Henrik The 10/14/2020 15:58, Jakub Kicinski wrote:> > On Mon, 12 Oct 2020 14:04:18 + Henrik Bjoernlund wrote: > > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises capab

Re: [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-15 Thread henrik.bjoernl...@microchip.com
Thanks for your review. Regards Henrik The 10/14/2020 11:24, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 2020-10-12 at 14:04 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink sta

[PATCH RFC bpf-next 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen Based on the discussion in [0], update the bpf_redirect_neigh() helper to accept an optional parameter specifying the nexthop information. This makes it possible to combine bpf_fib_lookup() and bpf_redirect_neigh() without incurring a duplicate FIB lookup - since the

[PATCH RFC bpf-next 0/2] bpf: Rework bpf_redirect_neigh() to allow supplying nexthop from caller

2020-10-15 Thread Toke Høiland-Jørgensen
Based on previous discussion[0], we determined that it would be beneficial to rework bpf_redirect_neigh() so the caller can supply the nexthop information (e.g., from a previous call to bpf_fib_lookup()). This way, the two helpers can be combined without incurring a second FIB lookup to find the ne

[PATCH RFC bpf-next 2/2] selftests: Update test_tc_neigh to use the modified bpf_redirect_neigh()

2020-10-15 Thread Toke Høiland-Jørgensen
From: Toke Høiland-Jørgensen This updates the test_tc_neigh selftest to use the new syntax of bpf_redirect_neigh(). To exercise the helper both with and without the optional parameter, one forwarding direction is changed to do a bpf_fib_lookup() followed by a call to bpf_redirect_neigh(), while t

[PATCH net-next 0/4] net: add functionality to net core byte/packet counters and use it in r8169

2020-10-15 Thread Heiner Kallweit
This series adds missing functionality to the net core handling of byte/packet counters and statistics. The extensions are used then to remove private rx/tx byte/packet counters in r8169 driver. Heiner Kallweit (4): net: core: add dev_sw_netstats_tx_add net: core: add devm_netdev_alloc_pcpu_st

Re: [Linux-kernel-mentees] [PATCH] net: rose: Fix Null pointer dereference in rose_send_frame()

2020-10-15 Thread Greg KH
On Thu, Oct 15, 2020 at 07:40:12PM +0530, Anmol Karn wrote: > On Thu, Oct 15, 2020 at 07:12:25AM +0200, Greg KH wrote: > > On Thu, Oct 15, 2020 at 05:47:12AM +0530, Anmol Karn wrote: > > > In rose_send_frame(), when comparing two ax.25 addresses, it assigns > > > rose_call to > > > either global

[PATCH net-next 3/4] r8169: use struct pcpu_sw_netstats for rx/tx packet/byte counters

2020-10-15 Thread Heiner Kallweit
Switch to the net core rx/tx byte/packet counter infrastructure. This simplifies the code, only small drawback is some memory overhead because we use just one queue, but allocate the counters per cpu. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 11 ---

[PATCH net-next 4/4] r8169: remove no longer needed private rx/tx packet/byte counters

2020-10-15 Thread Heiner Kallweit
After switching to the net core rx/tx byte/packet counters we can remove the now unused private version. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 34 --- 1 file changed, 34 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_mai

[PATCH net-next 2/4] net: core: add devm_netdev_alloc_pcpu_stats

2020-10-15 Thread Heiner Kallweit
Add a managed version of netdev_alloc_pcpu_stats, e.g. for allocating the per-cpu stats in the probe() callback of a driver. It needs to be a macro for dealing properly with the type argument. Signed-off-by: Heiner Kallweit --- include/linux/netdevice.h | 15 +++ net/devres.c

[PATCH net-next 1/4] net: core: add dev_sw_netstats_tx_add

2020-10-15 Thread Heiner Kallweit
Add dev_sw_netstats_tx_add(), complementing already existing dev_sw_netstats_rx_add(). Other than dev_sw_netstats_rx_add allow to pass the number of packets as function argument. Signed-off-by: Heiner Kallweit --- include/linux/netdevice.h | 12 1 file changed, 12 insertions(+) dif

[PATCH net-next v6 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
This is the implementation of CFM netlink configuration set information interface. Add new nested netlink attributes. These attributes are used by the user space to create/delete/configure CFM instances. SETLINK: IFLA_BRIDGE_CFM: Indicate that the following attributes are CFM. IF

[PATCH net-next v6 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-15 Thread Henrik Bjoernlund
This is the first commit of the implementation of the CFM protocol according to 802.1Q section 12.14. It contains MEP instance create, delete and configuration. Connectivity Fault Management (CFM) comprises capabilities for detecting, verifying, and isolating connectivity failures in Virtual Brid

Re: [net-next PATCH 01/10] octeontx2-af: Update get/set resource count functions

2020-10-15 Thread Jesse Brandeburg
sundeep.l...@gmail.com wrote: > From: Subbaraya Sundeep > > Since multiple blocks of same type are present in > 98xx, modify functions which get resource count and > which update resource count to work with individual > block address instead of block type. > > Signed-off-by: Subbaraya Sundeep

[PATCH net-next v6 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread Henrik Bjoernlund
This is the implementation of CFM netlink configuration get information interface. Add new nested netlink attributes. These attributes are used by the user space to get configuration information. GETLINK: Request filter RTEXT_FILTER_CFM_CONFIG: Indicating that CFM configuration informatio

[PATCH net-next v5 00/10] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-10-15 Thread Henrik Bjoernlund
Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. Connectivity Fault Management (CFM) comprises capabilities for detecting, verifying, and isolating connectivity failures in Virtual Bridged Networks. These capabilities can be used in networks operated by multiple independent

[PATCH net-next v6 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-15 Thread Henrik Bjoernlund
This is the implementation of CFM netlink status get information interface. Add new nested netlink attributes. These attributes are used by the user space to get status information. GETLINK: Request filter RTEXT_FILTER_CFM_STATUS: Indicating that CFM status information must be delivered.

[PATCH net-next v6 10/10] bridge: cfm: Netlink Notifications.

2020-10-15 Thread Henrik Bjoernlund
This is the implementation of Netlink notifications out of CFM. Notifications are initiated whenever a state change happens in CFM. IFLA_BRIDGE_CFM: Points to the CFM information. IFLA_BRIDGE_CFM_MEP_STATUS_INFO: This indicate that the MEP instance status are following. IFLA_BRIDGE_CFM_C

[PATCH net-next v6 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-15 Thread Henrik Bjoernlund
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux

[PATCH net-next v6 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-15 Thread Henrik Bjoernlund
This is the second commit of the implementation of the CFM protocol according to 802.1Q section 12.14. Functionality is extended with CCM frame transmission. Interface is extended with these functions: br_cfm_cc_rdi_set() br_cfm_cc_ccm_tx() br_cfm_cc_config_set() A MEP Continuity Check feature c

[PATCH net-next v6 01/10] net: bridge: extend the process of special frames

2020-10-15 Thread Henrik Bjoernlund
This patch extends the processing of frames in the bridge. Currently MRP frames needs special processing and the current implementation doesn't allow a nice way to process different frame types. Therefore try to improve this by adding a list that contains frame types that need special processing. T

[PATCH net-next v6 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-15 Thread Henrik Bjoernlund
This is the third commit of the implementation of the CFM protocol according to 802.1Q section 12.14. Functionality is extended with CCM frame reception. The MEP instance now contains CCM based status information. Most important is the CCM defect status indicating if correct CCM frames are receive

[PATCH net-next v6 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-15 Thread Henrik Bjoernlund
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund Reviewed-by: Horatiu Vultur Acked-by: Nikolay Aleksandrov --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h

[PATCH v2 net-next] net: stmmac: Enable EEE HW LPI timer with auto SW/HW switching

2020-10-15 Thread Voon Weifeng
From: "Vineetha G. Jaya Kumaran" This patch enables the HW LPI Timer which controls the automatic entry and exit of the LPI state. The EEE LPI timer value is configured through ethtool. The driver will auto select the LPI HW timer if the value in the HW timer supported range. Else, the driver wil

Re: [PATCH net] net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info

2020-10-15 Thread Jakub Kicinski
On Wed, 14 Oct 2020 11:56:42 +0300 Leon Romanovsky wrote: > From: Leon Romanovsky > > The access of tcf_tunnel_info() produces the following splat, so fix it > by dereferencing the tcf_tunnel_key_params pointer with marker that > internal tcfa_liock is held. Applied, queued for stable, thanks!

[PATCH net] net: core: use list_del_init() instead of list_del() in netdev_run_todo()

2020-10-15 Thread Taehee Yoo
dev->unlink_list is reused unless dev is deleted. So, list_del() should not be used. Due to using list_del(), dev->unlink_list can't be reused so that dev->nested_level update logic doesn't work. In order to fix this bug, list_del_init() should be used instead of list_del(). Test commands: ip

Re: [PATCH RFC bpf-next 1/2] bpf_redirect_neigh: Support supplying the nexthop as a helper parameter

2020-10-15 Thread David Ahern
On 10/15/20 9:46 AM, Toke Høiland-Jørgensen wrote: > diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h > index bf5a99d803e4..980cc1363be8 100644 > --- a/include/uapi/linux/bpf.h > +++ b/include/uapi/linux/bpf.h > @@ -3677,15 +3677,19 @@ union bpf_attr { > * Return > *

Re: [PATCH net-next V3] cxgb4/ch_ipsec: Replace the module name to ch_ipsec from chcr

2020-10-15 Thread Jakub Kicinski
On Wed, 14 Oct 2020 15:38:06 +0530 Ayush Sawal wrote: > This patch changes the module name to "ch_ipsec" and prepends > "ch_ipsec" string instead of "chcr" in all debug messages and > function names. > > V1->V2: > -Removed inline keyword from functions. > -Removed CH_IPSEC prefix from pr_debug. >

[PATCH net-next,v2 2/9] net: resolve forwarding path from virtual netdevice and HW destination address

2020-10-15 Thread Pablo Neira Ayuso
This patch adds dev_fill_forward_path() which resolves the path to reach the real netdevice from the IP forwarding step. This function takes as input the netdevice and the destination hardware address and it walks down over the devices calling .ndo_fill_forward_path() for each device until the real

[PATCH net-next,v2 1/9] netfilter: flowtable: add xmit path types

2020-10-15 Thread Pablo Neira Ayuso
Add the xmit_type field that defines the two supported xmit paths in the flowtable data plane, which are the neighbour and the xfrm xmit paths. This patch prepares for new flowtable xmit path types to come. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/netfilter/nf_flow_table

[PATCH net-next,v2 8/9] netfilter: flowtable: bridge port support

2020-10-15 Thread Pablo Neira Ayuso
Update hardware destination address to the master bridge device to emulate the forwarding behaviour. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/netfilter/nf_flow_table.h | 1 + net/netfilter/nf_flow_table_core.c| 4 net/netfilter/nft_flow_offload.c | 6 +-

[PATCH net-next,v2 6/9] netfilter: flowtable: use dev_fill_forward_path() to obtain egress device

2020-10-15 Thread Pablo Neira Ayuso
The egress device in the tuple is obtained from route. Use dev_fill_forward_path() instead to provide the real ingress device for this flow whenever this is available. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/netfilter/nf_flow_table.h | 4 net/netfilter/nf_flow_tab

[PATCH net-next,v2 7/9] netfilter: flowtable: add direct xmit path

2020-10-15 Thread Pablo Neira Ayuso
Add FLOW_OFFLOAD_XMIT_DIRECT to turn on the direct dev_queue_xmit() path to transmit ethernet frames. Cache the source and destination hardware address for flow to use dev_queue_xmit() to transfer packets. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/netfilter/nf_flow_table.

[PATCH net-next,v2 0/9] netfilter: flowtable bridge and vlan enhancements

2020-10-15 Thread Pablo Neira Ayuso
Hi, [ This is v2 fixing up the sparse warnings. ] The following patchset adds infrastructure to augment the Netfilter flowtable fastpath [1] to support for local network topologies that combine IP forwarding, bridge and vlan devices. A typical scenario that can benefit from this infrastructure i

  1   2   3   >