Re: [PATCH net-next] net: ptp: get rid of IPV4_HLEN() and OFF_IHL macros

2020-10-16 Thread Christian Eggers
On Thursday, 15 October 2020, 18:56:41 CEST, Florian Fainelli wrote: > Having recently helped someone with a bug that involved using > IPV4_HLEN() instead of ip_hdr() in a driver's transmit path (so with the > transport header correctly set), it would probably help if we could make > IPV4_HLEN()'s

Re: [PATCHv3 net-next 16/16] sctp: enable udp tunneling socks

2020-10-16 Thread Xin Long
On Fri, Oct 16, 2020 at 1:42 AM Marcelo Ricardo Leitner wrote: > > Actually.. > > On Tue, Oct 13, 2020 at 03:27:41PM +0800, Xin Long wrote: > ... > > Also add sysctl udp_port to allow changing the listening > > sock's port by users. > ... > > --- > > net/sctp/protocol.c | 5 + > > net/sctp/s

[PATCH v2 0/2] convert flexcan to the yaml

2020-10-16 Thread Oleksij Rempel
changes v2: - add can-controller.yaml for common patterns - use phandle-array instead of uint32-array - Drop the outer 'items' in fsl,stop-mode - use can@ instead of flexcan@ Oleksij Rempel (2): dt-bindings: can: add can-controller.yaml dt-bindings: can: flexcan: convert fsl,*flexcan bindings

[PATCH v2 1/2] dt-bindings: can: add can-controller.yaml

2020-10-16 Thread Oleksij Rempel
For now we have only node name as common rule for all CAN controllers Signed-off-by: Oleksij Rempel --- .../bindings/net/can/can-controller.yaml | 16 1 file changed, 16 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/can/can-controller.yaml dif

[PATCH v2 2/2] dt-bindings: can: flexcan: convert fsl,*flexcan bindings to yaml

2020-10-16 Thread Oleksij Rempel
In order to automate the verification of DT nodes convert fsl-flexcan.txt to fsl,flexcan.yaml Signed-off-by: Oleksij Rempel --- .../bindings/net/can/fsl,flexcan.yaml | 137 ++ .../bindings/net/can/fsl-flexcan.txt | 57 2 files changed, 137 insertions(+)

[PATCH net] net: dsa: ksz: don't pad a cloned sk_buff

2020-10-16 Thread Christian Eggers
If the supplied sk_buff is cloned (e.g. in dsa_skb_tx_timestamp()), __skb_put_padto() will allocate a new sk_buff with size = skb->len + padlen. So the condition just tested for (skb_tailroom(skb) >= padlen + len) is not fulfilled anymore. Although the real size will usually be larger than skb->len

[PATCH] cfg80211: make wifi driver probe

2020-10-16 Thread Daisy Zhang251
From: Daisy Zhang1 Register a WiFi driver of IEEE80211 WLAN for the Unisoc Marlin3 chipsets. The following code is a simple architecture for probing driver. Signed-off-by: Daisy Zhang1 --- drivers/net/wireless/sprd/Kconfig | 21 + drivers/net/wireless/sprd/Makefile | 15

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 8:46 AM, Joakim Zhang wrote: >>> @@ -2019,6 +2109,7 @@ static int flexcan_probe(struct platform_device >> *pdev) >>> priv->clk_src = clk_src; >>> priv->devtype_data = devtype_data; >>> priv->reg_xceiver = reg_xceiver; >>> + priv->can_idx = can_idx; >>> >>> if (priv->de

[PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver

2020-10-16 Thread Oleksij Rempel
After this patch we need 2 arguments less for the fsl,stop-mode property: | commit d9b081e3fc4bdc33e672dcb7bb256394909432fc | Author: Marc Kleine-Budde | Date: Sun Jun 14 21:09:20 2020 +0200 | | can: flexcan: remove ack_grp and ack_bit handling from driver | | Since commit: | | 048e3a34a2e7 ca

Re: [PATCH net] net: dsa: ksz: fix padding size of skb

2020-10-16 Thread Kurt Kanzenbach
On Thu Oct 15 2020, Christian Eggers wrote: > On Wednesday, 14 October 2020, 19:31:03 CEST, Vladimir Oltean wrote: >> What problem are you actually trying to solve? > After (hopefully) understanding the important bits, I would like to solve the > problem that after calling __skb_put_padto() there

Re: [PATCH 3/6] dt-bindings: can: flexcan: add fsl, can-index property to indicate a resource

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 8:52 AM, Joakim Zhang wrote: > > Hi Marc, > >> -Original Message- >> From: Marc Kleine-Budde >> Sent: 2020年10月16日 14:20 >> To: Joakim Zhang ; robh...@kernel.org; >> shawn...@kernel.org; s.ha...@pengutronix.de >> Cc: devicet...@vger.kernel.org; Peng Fan ; Ying Liu >> ; netdev@

[PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver

2020-10-16 Thread Oleksij Rempel
After this patch we need 2 arguments less for the fsl,stop-mode property: | commit d9b081e3fc4bdc33e672dcb7bb256394909432fc | Author: Marc Kleine-Budde | Date: Sun Jun 14 21:09:20 2020 +0200 | | can: flexcan: remove ack_grp and ack_bit handling from driver | | Since commit: | | 048e3a34a2e7 ca

Re: [PATCH net] can: peak_usb: add range checking in decode operations

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 9:43 AM, Stéphane Grosjean wrote: > Thank you for your detailed answer. And so? AFAIK I saw that this patch is > still > not in mainline. What needs to be done for it to be there? Should I bring an > Ack, for example? If you have reviewed the patch, give an Ack or Reviewed-by. regard

Re: [patch 1/1] drivers/net/ethernet/marvell/mvmdio.c: Fix non OF case

2020-10-16 Thread Greg KH
On Thu, Oct 15, 2020 at 12:08:00PM +0200, Arnaud Patard wrote: > Greg KH writes: > > > On Thu, Oct 15, 2020 at 11:32:15AM +0200, Arnaud Patard wrote: > >> commit d934423ac26ed373dfe089734d505dca5ff679b6 upstream. > >> > >> Orion5.x systems are still using machine files and not device-tree. > >>

RE: [PATCH v1] ARM: dts: imx6/7: sync fsl,stop-mode with current flexcan driver

2020-10-16 Thread Joakim Zhang
> -Original Message- > From: Oleksij Rempel > Sent: 2020年10月16日 15:52 > To: m...@pengutronix.de; Wolfgang Grandegger ; > David S. Miller ; Jakub Kicinski ; > Rob Herring ; Shawn Guo ; > Sascha Hauer > Cc: Oleksij Rempel ; ker...@pengutronix.de; > linux-...@vger.kernel.org; netdev@vger.ke

Re: [bpf-next PATCH 4/4] bpf, selftests: Add three new sockmap tests for verdict only programs

2020-10-16 Thread Jakub Sitnicki
On Sun, Oct 11, 2020 at 07:10 AM CEST, John Fastabend wrote: > Here we add three new tests for sockmap to test having a verdict program > without setting the parser program. > > The first test covers the most simply case, > >sender proxy_recv proxy_send recv > |

Re: [PATCH v4 1/2] net: Add mhi-net driver

2020-10-16 Thread Loic Poulain
Hi Eric, On Thu, 15 Oct 2020 at 20:56, Eric Dumazet wrote: > > > > On 10/15/20 3:29 PM, Loic Poulain wrote: > > On Thu, 15 Oct 2020 at 14:41, Eric Dumazet wrote: > >> > >> > >> > >> On 10/15/20 12:31 PM, Loic Poulain wrote: > >>> This patch adds a new network driver implementing MHI transport fo

Re: [PATCH] [v2] wireless: Initial driver submission for pureLiFi devices

2020-10-16 Thread Kalle Valo
Leon Romanovsky writes: > On Wed, Sep 30, 2020 at 12:11:24PM +0200, Johannes Berg wrote: >> On Wed, 2020-09-30 at 12:55 +0300, Leon Romanovsky wrote: >> > On Wed, Sep 30, 2020 at 11:01:27AM +0300, Kalle Valo wrote: >> > > Leon Romanovsky writes: >> > > >> > > > > diff --git a/drivers/net/wireles

Re: [PATCH] [v4] wireless: Initial driver submission for pureLiFi STA devices

2020-10-16 Thread Joe Perches
On Fri, 2020-10-16 at 12:04 +0530, Srinivasan Raju wrote: > This introduces the pureLiFi LiFi driver for LiFi-X, LiFi-XC > and LiFi-XL USB devices. Suggested neatening patch on top of this: o Use include "usb.h" instead of direct extern o Prefix purelifi to speed and send_packet_from_data_queue f

Re: [PATCH net] net: dsa: ksz: fix padding size of skb

2020-10-16 Thread Christian Eggers
On Friday, 16 October 2020, 09:45:42 CEST, Kurt Kanzenbach wrote: > On Thu Oct 15 2020, Christian Eggers wrote: > > On Wednesday, 14 October 2020, 19:31:03 CEST, Vladimir Oltean wrote: > >> What problem are you actually trying to solve? > > > > After (hopefully) understanding the important bits, I

Re: [PATCH net] net: dsa: ksz: fix padding size of skb

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 11:00:20AM +0200, Christian Eggers wrote: > On Friday, 16 October 2020, 09:45:42 CEST, Kurt Kanzenbach wrote: > > On Thu Oct 15 2020, Christian Eggers wrote: > > > On Wednesday, 14 October 2020, 19:31:03 CEST, Vladimir Oltean wrote: > > >> What problem are you actually tryin

[PATCH v6 2/3] net: Add mhi-net driver

2020-10-16 Thread Loic Poulain
This patch adds a new network driver implementing MHI transport for network packets. Packets can be in any format, though QMAP (rmnet) is the usual protocol (flow control + PDN mux). It support two MHI devices, IP_HW0 which is, the path to the IPA (IP accelerator) on qcom modem, And IP_SW0 which i

[PATCH v6 1/2] bus: mhi: Add mhi_queue_is_full function

2020-10-16 Thread Loic Poulain
This function can be used by client driver to determine whether it's possible to queue new elements in a channel ring. Signed-off-by: Loic Poulain --- v1->v5: This change is not part of the series v6: add this patch to the series drivers/bus/mhi/core/main.c | 15 +-- include/linux

Re: ixgbe - only presenting one out of four interfaces on 5.9

2020-10-16 Thread Ian Kumlien
Adding netdev, someone might have a clue of what to look at... On Mon, Oct 12, 2020 at 9:20 PM Ian Kumlien wrote: > > Hi, > > I was really surprised when i rebooted my firewall and there was > network issues, I was even more surprised when > only one of the four ports of my ixbe (x553) nic was av

[PATCH v3 1/1] net: dsa: seville: the packet buffer is 2 megabits, not megabytes

2020-10-16 Thread Maxim Kochetkov
The VSC9953 Seville switch has 2 megabits of buffer split into 4360 words of 60 bytes each. 2048 * 1024 is 2 megabytes instead of 2 megabits. 2 megabits is (2048 / 8) * 1024 = 256 * 1024. Signed-off-by: Maxim Kochetkov Reviewed-by: Vladimir Oltean Fixes: a63ed92d217f ("net: dsa: seville: fix buf

From Bukar Mangora, Hello Friend Please Treat Urgent

2020-10-16 Thread Bukar Mangora
Good day my good friend. How are you doing today? It has been long i hear from you, what is going on your side? Today i am very much happy to inform you about my success in getting those inheritance funds transferred under the co-operation of a new partner from India Asia. He is a Canadian but base

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Joakim Zhang
Hi Marc, [...] > > > +static int flexcan_stop_mode_enable_scfw(struct flexcan_priv *priv, > > > +bool enabled) { > > > + u8 idx = priv->can_idx; > > > + u32 rsrc_id, val; > > > + > > > + if (idx == 0) > > > + rsrc_id = IMX_SC_R_CAN_0; > > > + else if (idx == 1) > > > + rsrc_id = I

RE: [PATCH] [v4] wireless: Initial driver submission for pureLiFi STA devices

2020-10-16 Thread Srinivasan Raju
> Suggested neatening patch on top of this: Thanks for the neatening patch Joe, I will resubmit patch. Thanks Srini

[PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Signed-off-by: Alexander Sverdlin Fixes: 80ff0fd3ab ("Staging: Ad

[PATCH v2 net] staging: octeon: repair "fixed-link" support

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin The PHYs must be registered once in device probe function, not in device open callback because it's only possible to register them once. Fixes: a25e278020 ("staging: octeon: support fixed-link phys") Signed-off-by: Alexander Sverdlin --- drivers/staging/octeon/ethernet

Re: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Marc Kleine-Budde
On 10/16/20 12:00 PM, Joakim Zhang wrote: +static int flexcan_stop_mode_enable_scfw(struct flexcan_priv *priv, +bool enabled) { + u8 idx = priv->can_idx; + u32 rsrc_id, val; + + if (idx == 0) + rsrc_id = IMX_SC_R_CAN_0; + else if (idx == 1)

RE: [net-next 2/3] i40e: Fix MAC address setting for a VF via Host/VM

2020-10-16 Thread Loktionov, Aleksandr
Good day Willem The issue patch fixes has been introduced from the very beginning. So as fixes tag I can suggest the very first commit 5c3c48ac6bf56367c4e89f6453cd2d61e50375bd "i40e: implement virtual device interface" With the best regards Alex ND ITP Linux 40G base driver TL -Original

[RFC PATCH 0/2] tcp: factor out a couple of helpers

2020-10-16 Thread Paolo Abeni
Upcoming improvement in MPTCP subflows management will require to keep write data enqueued at the MPTCP level. As a side effect, such data could be sent via orphaned TCP subflows after close(). To implement the above MPTCP needs to cope directly with memory allocation failures in do_tcp_sendpages(

[RFC PATCH 1/2] tcp: factor out tcp_build_frag()

2020-10-16 Thread Paolo Abeni
Will be needed by the next patch, as MPTCP needs to handle directly the error/memory-allocation-needed path. No functional changes intended. Additionally let MPTCP code access the tcp_remove_empty_skb() helper. Signed-off-by: Paolo Abeni --- include/net/tcp.h | 3 ++ net/ipv4/tcp.c| 119

[RFC PATCH 2/2] tcp: factor out __tcp_close() helper

2020-10-16 Thread Paolo Abeni
unlocked version of protocol level close, will be used by MPTCP to allow decouple orphaning and subflow level close. Signed-off-by: Paolo Abeni --- include/net/tcp.h | 1 + net/ipv4/tcp.c| 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/include/net/tcp.h b/include

RE: [PATCH 5/6] can: flexcan: add CAN wakeup function for i.MX8QM

2020-10-16 Thread Joakim Zhang
Hi Marc, > -Original Message- > From: Marc Kleine-Budde > Sent: 2020年10月16日 18:40 > To: Joakim Zhang ; robh...@kernel.org; > shawn...@kernel.org; s.ha...@pengutronix.de > Cc: ker...@pengutronix.de; dl-linux-imx ; Ying Liu > ; Peng Fan ; > linux-...@vger.kernel.org; Pankaj Bansal ; > netd

[PATCH net] ip6_tunnel: set inner ipproto before ip6_tnl_encap.

2020-10-16 Thread Alexander Ovechkin
ip6_tnl_encap assigns to proto transport protocol which encapsulates inner packet, but we must pass to set_inner_ipproto protocol of that inner packet. Calling set_inner_ipproto after ip6_tnl_encap might break gso. For example, in case of encapsulating ipv6 packet in fou6 packet, inner_ipproto wo

Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Greg Kroah-Hartman
On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit mo

[patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Mike Galbraith
When the kernel is built with PREEMPT_RT or booted with threadirqs, irqs are not disabled when rtl8169_interrupt() is called, inspiring __raise_softirq_irqoff() to gripe. Use plain napi_schedule(). Signed-off-by: Mike Galbraith --- drivers/net/ethernet/realtek/r8169_main.c |2 +- 1 file c

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-16 Thread Ulf Hansson
On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller wrote: > > From: Jérôme Pouiller Please fill out this commit message to explain a bit more about the patch and the HW it enables support for. > > Signed-off-by: Jérôme Pouiller > --- > drivers/net/wireless/silabs/wfx/bus_sdio.c | 269 +

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Heiner Kallweit
On 16.10.2020 13:26, Mike Galbraith wrote: > > When the kernel is built with PREEMPT_RT or booted with threadirqs, > irqs are not disabled when rtl8169_interrupt() is called, inspiring > __raise_softirq_irqoff() to gripe. Use plain napi_schedule(). > I'm aware of the topic, but missing the bene

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-16 Thread Ulf Hansson
On Thu, 15 Oct 2020 at 16:03, Jérôme Pouiller wrote: > > On Wednesday 14 October 2020 14:43:34 CEST Pali Rohár wrote: > > On Wednesday 14 October 2020 13:52:15 Jérôme Pouiller wrote: > > > On Tuesday 13 October 2020 22:11:56 CEST Pali Rohár wrote: > > > > On Monday 12 October 2020 12:46:32 Jerome

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Mike Galbraith
On Fri, 2020-10-16 at 13:34 +0200, Heiner Kallweit wrote: > On 16.10.2020 13:26, Mike Galbraith wrote: > > > > When the kernel is built with PREEMPT_RT or booted with threadirqs, > > irqs are not disabled when rtl8169_interrupt() is called, inspiring > > __raise_softirq_irqoff() to gripe. Use plai

[PATCH v3 2/8] staging: qlge: Initialize devlink health dump framework

2020-10-16 Thread Coiby Xu
Initialize devlink health dump framework for the qlge driver so the coredump could be done via devlink. struct qlge_adapter is now used as the private data structure of struct devlink so it could exist independently of struct net_device and devlink reload could be supported in the future. The priv

[PATCH v3 3/8] staging: qlge: re-write qlge_init_device

2020-10-16 Thread Coiby Xu
Stop calling ql_release_all in qlge_init_device and free things one step at a time. Link: https://lore.kernel.org/patchwork/patch/1321092/#1516928 Suggested-by: Dan Carpenter Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_main.c | 32 1 file changed, 20 i

[PATCH v3 4/8] staging: qlge: coredump via devlink health reporter

2020-10-16 Thread Coiby Xu
$ devlink health dump show DEVICE reporter coredump -p -j { "Core Registers": { "segment": 1, "values": [ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,

[PATCH v3 5/8] staging: qlge: support force_coredump option for devlink health dump

2020-10-16 Thread Coiby Xu
With force_coredump module parameter set, devlink health dump will reset the MPI RISC first which takes 5 secs to be finished. Signed-off-by: Coiby Xu --- drivers/staging/qlge/qlge_devlink.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/qlge/qlge_devlink.c b/drivers

[PATCH v3 6/8] staging: qlge: remove mpi_core_to_log which sends coredump to the kernel ring buffer

2020-10-16 Thread Coiby Xu
devlink health could be used to get coredump. No need to send so much data to the kernel ring buffer. Signed-off-by: Coiby Xu --- drivers/staging/qlge/TODO | 2 -- drivers/staging/qlge/qlge.h | 3 --- drivers/staging/qlge/qlge_dbg.c | 11 --- drivers/staging/qlge/

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-16 Thread Kurt Kanzenbach
On Mon Oct 12 2020, Kurt Kanzenbach wrote: > On Sun Oct 11 2020, Vladimir Oltean wrote: >> On Sun, Oct 11, 2020 at 02:29:08PM +0200, Kurt Kanzenbach wrote: >>> On Tue Oct 06 2020, Vladimir Oltean wrote: >>> > It would be interesting to see if you could simply turn off VLAN >>> > awareness in standa

[PATCH v3 7/8] staging: qlge: clean up debugging code in the QL_ALL_DUMP ifdef land

2020-10-16 Thread Coiby Xu
The debugging code in the following ifdef land - QL_ALL_DUMP - QL_REG_DUMP - QL_DEV_DUMP - QL_CB_DUMP - QL_IB_DUMP - QL_OB_DUMP becomes unnecessary because, - Device status and general registers can be obtained by ethtool. - Coredump can be done via devlink health reporter. - Structure re

[PATCH v3 8/8] staging: qlge: add documentation for debugging qlge

2020-10-16 Thread Coiby Xu
Instructions and examples on kernel data structures dumping and coredump. Signed-off-by: Coiby Xu --- .../networking/device_drivers/index.rst | 1 + .../device_drivers/qlogic/index.rst | 18 +++ .../networking/device_drivers/qlogic/qlge.rst | 118 ++ MAINTAINER

Re: [PATCH 07/23] wfx: add bus_sdio.c

2020-10-16 Thread Jérôme Pouiller
Hello Ulf, On Friday 16 October 2020 13:30:30 CEST Ulf Hansson wrote: > On Mon, 12 Oct 2020 at 12:47, Jerome Pouiller > wrote: > > > > From: Jérôme Pouiller > > Please fill out this commit message to explain a bit more about the > patch and the HW it enables support for. This patch belongs to

[PATCH] netem: prevent division by zero in tabledist

2020-10-16 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Currently it is possible to craft a special netlink RTM_NEWQDISC command that result in jitter being equal to 0x8000. It is enough to set 32 bit jitter to 0x0200 (it will later be multiplied by 2^6) or set 64 bit jitter via TCA_NETEM_JITTER64. This causes an overflo

Re: [PATCH v4 4/4] PCI: Limit pci_alloc_irq_vectors() to housekeeping CPUs

2020-10-16 Thread Peter Zijlstra
On Mon, Sep 28, 2020 at 02:35:29PM -0400, Nitesh Narayan Lal wrote: > If we have isolated CPUs dedicated for use by real-time tasks, we try to > move IRQs to housekeeping CPUs from the userspace to reduce latency > overhead on the isolated CPUs. > > If we allocate too many IRQ vectors, moving them

Re: [PATCH net] net: dsa: ksz: fix padding size of skb

2020-10-16 Thread Christian Eggers
On Friday, 16 October 2020, 11:05:27 CEST, Vladimir Oltean wrote: > On Fri, Oct 16, 2020 at 11:00:20AM +0200, Christian Eggers wrote: > > On Friday, 16 October 2020, 09:45:42 CEST, Kurt Kanzenbach wrote: > > > Hmm. I've never observed any problems using DSA with L2 PTP time > > > stamping with this

Re: [PATCH net-next] net: ptp: get rid of IPV4_HLEN() and OFF_IHL macros

2020-10-16 Thread Richard Cochran
On Fri, Oct 16, 2020 at 09:04:38AM +0200, Christian Eggers wrote: > IPV4_HLEN() is only used for PTP. Is there any way to use "normal" > infrastructure as in the rest of the network stack? You answered your own question... > It looks like PTP code > typically has to look into multiple network lay

Re: [PATCH v2 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Greg Kroah-Hartman
On Fri, Oct 16, 2020 at 12:18:58PM +0200, Alexander A Sverdlin wrote: > From: Alexander Sverdlin > > Currently in case of alignment or FCS error if the packet cannot be > corrected it's still not dropped. Report the error properly and drop the > packet while making the code around a little bit mo

Re: WARNING: proc registration bug in afs_manage_cell

2020-10-16 Thread David Howells
#syz test: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git 7530d3eb3dcf1a30750e8e7f1f88b782b96b72b8

Re: [RFC PATCH] net: bridge: call br_multicast_del_port before the port leaves

2020-10-16 Thread Nikolay Aleksandrov
On Thu, 2020-10-15 at 20:33 +0300, Vladimir Oltean wrote: > Switchdev drivers often have different VLAN semantics than the bridge. > For example, consider this: > > ip link add br0 type bridge > ip link set swp0 master br0 > bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent > ip lin

[PATCH] xfrm: redact SA secret with lockdown confidentiality

2020-10-16 Thread Antony Antony
redact XFRM SA secret in the netlink response to xfrm_get_sa() or dumpall sa. Enable this at build time and set kernel lockdown to confidentiality. e.g. cat /sys/kernel/security/lockdown none integrity [confidentiality] ip xfrm state src 172.16.1.200 dst 172.16.1.100 proto esp spi 0x0

Re: [PATCH net] net: dsa: ksz: don't pad a cloned sk_buff

2020-10-16 Thread Andrew Lunn
On Fri, Oct 16, 2020 at 09:35:27AM +0200, Christian Eggers wrote: > If the supplied sk_buff is cloned (e.g. in dsa_skb_tx_timestamp()), > __skb_put_padto() will allocate a new sk_buff with size = skb->len + > padlen. So the condition just tested for (skb_tailroom(skb) >= padlen + > len) is not fulf

Re: WARNING: proc registration bug in afs_manage_cell

2020-10-16 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger any issue: Reported-and-tested-by: syzbot+b994ecf2b023f1483...@syzkaller.appspotmail.com Tested on: commit: 7530d3eb afs: Don't assert on unpurgeable server records git tree: git://git.kernel.org/pub/

Re: [PATCH net] net: dsa: ksz: don't pad a cloned sk_buff

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 04:00:36PM +0200, Andrew Lunn wrote: > On Fri, Oct 16, 2020 at 09:35:27AM +0200, Christian Eggers wrote: > > If the supplied sk_buff is cloned (e.g. in dsa_skb_tx_timestamp()), > > __skb_put_padto() will allocate a new sk_buff with size = skb->len + > > padlen. So the condit

Re: [PATCH net-next v2 1/2] Makefile.extrawarn: Add symbol for W=1 warnings for today

2020-10-16 Thread Andrew Lunn
> One drawback of your approach is that > you cannot set KBUILD_CFLAGS_W1_20200930 > until you eliminate all the warnings in the > sub-directory in interest. > (i.e. all or nothing approach) Hi Mashiro That actual works well for my use case. drivers/net/ethernet is W=1 clean. So is drivers/net/ph

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote: > I'm aware of the topic, but missing the benefits of the irqoff version > unconditionally doesn't seem to be the best option. What are the benefits of the irqoff version? As far as I see it, the only use case for that function is wh

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Heiner Kallweit
On 16.10.2020 16:26, Vladimir Oltean wrote: > On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote: >> I'm aware of the topic, but missing the benefits of the irqoff version >> unconditionally doesn't seem to be the best option. > > What are the benefits of the irqoff version? As far as

[PATCH iproute2-next v3 0/2] Implement filter terse dump mode support

2020-10-16 Thread Vlad Buslov
Implement support for terse dump mode which provides only essential classifier/action info (handle, stats, cookie, etc.). Use new TCA_DUMP_FLAGS_TERSE flag to prevent copying of unnecessary data from kernel. Vlad Buslov (2): tc: skip actions that don't have options attribute when printing tc:

[PATCH iproute2-next v3 1/2] tc: skip actions that don't have options attribute when printing

2020-10-16 Thread Vlad Buslov
From: Vlad Buslov Modify implementations that return error from action_until->print_aopt() callback to silently skip actions that don't have their corresponding TCA_ACT_OPTIONS attribute set (some actions already behave like this). This is necessary to support terse dump mode in following patch i

[PATCH iproute2-next v3 2/2] tc: implement support for terse dump

2020-10-16 Thread Vlad Buslov
From: Vlad Buslov Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when user requested it with following example CLI (-br for 'brief'): $ tc -s -brief filter show dev ens1f0 ingress filter protocol a

[PATCH v3 net] staging: octeon: Drop on uncorrectable alignment or FCS error

2020-10-16 Thread Alexander A Sverdlin
From: Alexander Sverdlin Currently in case of alignment or FCS error if the packet cannot be corrected it's still not dropped. Report the error properly and drop the packet while making the code around a little bit more readable. Fixes: 80ff0fd3ab ("Staging: Add octeon-ethernet driver files.") S

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-16 Thread Vlastimil Babka
On 10/13/20 10:09 AM, Mike Rapoport wrote: We are not complaining about TCP using too much memory, but how do we know that TCP uses a lot of memory. When I firstly face this problem, I do not know who uses the 25GB memory and it is not shown in the /proc/meminfo. If we can know the amount memory

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 04:41:50PM +0200, Heiner Kallweit wrote: > On 16.10.2020 16:26, Vladimir Oltean wrote: > > On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote: > >> I'm aware of the topic, but missing the benefits of the irqoff version > >> unconditionally doesn't seem to be the

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 02:11:06PM +0200, Kurt Kanzenbach wrote: > When VLAN awareness is disabled, the packet is still classified with the > pvid. But, later all rules regarding VLANs (except for the PCP field) > are ignored then. So, the programmed pvid doesn't matter in this case. Ok, clear now

[RFC] Exempt multicast address from five-second neighbor lifetime

2020-10-16 Thread Jeff Dike
Commit 58956317c8de guarantees arp table entries a five-second lifetime. We have some apps which make heavy use of multicast, and these can cause the table to overflow by filling it with multicast addresses which can't be GC-ed until their five seconds are up. This patch allows multicast addres

Re: [PATCH net] net: dsa: ksz: fix padding size of skb

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 02:44:46PM +0200, Christian Eggers wrote: > Machine: > - ARMv7 (i.MX6ULL), SMP_CACHE_BYTES is 64 > - DSA device: Microchip KSZ9563 (I am currently working on time stamping > support) I have a board very similar to this on which I am going to test. > Last, CONFIG_SLOB must

Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump

2020-10-16 Thread Jamal Hadi Salim
On 2020-10-16 10:42 a.m., Vlad Buslov wrote: From: Vlad Buslov Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when user requested it with following example CLI (-br for 'brief'): $ tc -s -brief f

Re: [PATCH v2 1/2] dt-bindings: can: add can-controller.yaml

2020-10-16 Thread Rob Herring
On Fri, 16 Oct 2020 09:33:14 +0200, Oleksij Rempel wrote: > For now we have only node name as common rule for all CAN controllers > > Signed-off-by: Oleksij Rempel > --- > .../bindings/net/can/can-controller.yaml | 16 > 1 file changed, 16 insertions(+) > create mode 10

Re: [PATCH v2 1/2] dt-bindings: can: add can-controller.yaml

2020-10-16 Thread Rob Herring
On Fri, Oct 16, 2020 at 09:33:14AM +0200, Oleksij Rempel wrote: > For now we have only node name as common rule for all CAN controllers > > Signed-off-by: Oleksij Rempel > --- > .../bindings/net/can/can-controller.yaml | 16 > 1 file changed, 16 insertions(+) > create m

gssapi, crypto and afs/rxrpc

2020-10-16 Thread David Howells
Hi Herbert, Dave, Trond, I've written basic gssapi-derived security support for AF_RXRPC: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rxgk I've borrowed some bits from net/sunrpc/auth_gss/ but there's a lot in there that is quite specific to the su

Re: [net-next 2/3] i40e: Fix MAC address setting for a VF via Host/VM

2020-10-16 Thread Willem de Bruijn
On Fri, Oct 16, 2020 at 6:46 AM Loktionov, Aleksandr wrote: > > Good day Willem > > The issue patch fixes has been introduced from the very beginning. > So as fixes tag I can suggest the very first commit > 5c3c48ac6bf56367c4e89f6453cd2d61e50375bd "i40e: implement virtual device > interface" F

[PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread Christian Eggers
>From a recent commit with the same summary: "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and KSZ9893 switches also use tail tags." Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the original commit. Fixes: 7a6ffe764be3 [net] ("net: dsa: point out the t

Re: [PATCH iproute2-next v3 2/2] tc: implement support for terse dump

2020-10-16 Thread Vlad Buslov
On Fri 16 Oct 2020 at 19:07, Jamal Hadi Salim wrote: > On 2020-10-16 10:42 a.m., Vlad Buslov wrote: >> From: Vlad Buslov >> >> Implement support for classifier/action terse dump using new TCA_DUMP_FLAGS >> tlv with only available flag value TCA_DUMP_FLAGS_TERSE. Set the flag when >> user reques

Re: [PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread Florian Fainelli
On 10/16/20 9:28 AM, Christian Eggers wrote: > From a recent commit with the same summary: > > "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and > KSZ9893 switches also use tail tags." > > Set "tail_tag" to true for KSZ8795 and KSZ9477 which were missing in the > original comm

Re: [RFC PATCH] net: bridge: call br_multicast_del_port before the port leaves

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 01:43:06PM +, Nikolay Aleksandrov wrote: > It can potentially use after free, multicast resources (per-cpu stats) are > freed > in br_multicast_del_port() and can be used due to a race with port state > sync on other CPUs since the handler can still process packets. Tha

Re: [PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread Vladimir Oltean
Hi Christian, On Fri, Oct 16, 2020 at 06:28:00PM +0200, Christian Eggers wrote: > From a recent commit with the same summary: > > "The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and > KSZ9893 switches also use tail tags." > > Set "tail_tag" to true for KSZ8795 and KSZ9477 which

Re: [PATCH net-next v6 2/7] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-16 Thread Florian Fainelli
On 10/16/20 8:43 AM, Vladimir Oltean wrote: > On Fri, Oct 16, 2020 at 02:11:06PM +0200, Kurt Kanzenbach wrote: >> When VLAN awareness is disabled, the packet is still classified with the >> pvid. But, later all rules regarding VLANs (except for the PCP field) >> are ignored then. So, the programmed

Re: TCP sender stuck in persist despite peer advertising non-zero window

2020-10-16 Thread Apollon Oikonomopoulos
Neal Cardwell writes: > On Thu, Oct 15, 2020 at 6:12 PM Apollon Oikonomopoulos > wrote: >> Neal, would it be possible to re-send the patch as an attachment? The >> inlined version does not apply cleanly due to linewrapping and >> whitespace changes and, although I can re-type it, I would prefer

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Mike Galbraith
On Fri, 2020-10-16 at 17:26 +0300, Vladimir Oltean wrote: > On Fri, Oct 16, 2020 at 01:34:55PM +0200, Heiner Kallweit wrote: > > I'm aware of the topic, but missing the benefits of the irqoff version > > unconditionally doesn't seem to be the best option. > > What are the benefits of the irqoff ver

[PATCH v4 0/4] can: add support for ETAS ES58X CAN USB

2020-10-16 Thread Vincent Mailhol
The purpose of this patch series is to introduce a new CAN USB driver to support ETAS USB interfaces (ES58X series). During development, issues in drivers/net/can/dev.c were discovered, the fix for those issues are included in this patch series. We also propose to add one helper functions in incl

Re: BUG: using __this_cpu_read() in preemptible code in trace_hardirqs_on

2020-10-16 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:9ff9b0d3 Merge tag 'net-next-5.10' of git://git.kernel.org.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1663860790 kernel config: https://syzkaller.appspot.com/x/.config?x=d13c3fa

[PATCH v4 1/4] can: dev: can_get_echo_skb(): prevent call to kfree_skb() in hard IRQ context

2020-10-16 Thread Vincent Mailhol
If a driver calls can_get_echo_skb() during a hardware IRQ (which is often, but not always, the case), the 'WARN_ON(in_irq)' in net/core/skbuff.c#skb_release_head_state() might be triggered, under network congestion circumstances, together with the potential risk of a NULL pointer dereference. The

[PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags

2020-10-16 Thread Christian Eggers
The Marvell 88E6060 uses tag_trailer.c and the KSZ8795, KSZ9477 and KSZ9893 switches also use tail tags. Fixes: 7a6ffe764be3 ("net: dsa: point out the tail taggers") Signed-off-by: Christian Eggers Reviewed-by: Florian Fainelli --- On Friday, 16 October 2020, 18:56:51 CEST, Vladimir Oltean wrote

Re: [patchlet] r8169: fix napi_schedule_irqoff() called with irqs enabled warning

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 07:11:22PM +0200, Mike Galbraith wrote: > Yeah, it's a straight up correctness issue as it sits. Yeah, tell me about it, you don't even want to know what it looks like when the local_softirq_pending_ref percpu mask gets corrupted. The symptom will be that random syscalls, l

[PATCH v4 2/4] can: dev: add a helper function to get the correct length of Classical frames

2020-10-16 Thread Vincent Mailhol
In classical CAN, the length of the data (i.e. CAN payload) is not always equal to the DLC! If the frame is a Remote Transmission Request (RTR), data length is always zero regardless of DLC value and else, if the DLC is greater than 8, the length is 8. Contrary to common belief, ISO 11898-1 Chapter

[PATCH v4 3/4] can: dev: __can_get_echo_skb(): fix the return length

2020-10-16 Thread Vincent Mailhol
The length of Remote Transmission Request (RTR) frames is always 0 bytes. The DLC represents the requested length, not the actual length of the RTR. But __can_get_echo_skb() returns the DLC value regardless. Apply get_can_len() function to retrieve the correct length. Signed-off-by: Vincent Mailh

Re: [PATCH net] net: dsa: tag_ksz: KSZ8795 and KSZ9477 also use tail tags

2020-10-16 Thread Vladimir Oltean
On Fri, Oct 16, 2020 at 07:16:03PM +0200, Christian Eggers wrote: > I added it manually because the commit ID is not from Linus' tree. Is there > any > value using Fixes tags with id's from other trees? Yes, that's what "git merge" does, it keeps sha1sums. You should check out "git log --oneline

Re: [PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread kernel test robot
Hi Christian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net/master] url: https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-003007 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git 2ecb

Re: [PATCH 2/3] dt-bindings: net: bluetooth: Add broadcom BCM4389 support

2020-10-16 Thread Rob Herring
On Wed, 14 Oct 2020 11:15:43 +0530, Amitesh Chandra wrote: > From: Amitesh Chandra > > Add bindings for BCM4389 bluetooth controller. > > Signed-off-by: Amitesh Chandra > --- > Documentation/devicetree/bindings/net/broadcom-bluetooth.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Ro

[PATCH net] nexthop: Fix performance regression in nexthop deletion

2020-10-16 Thread Ido Schimmel
From: Ido Schimmel While insertion of 16k nexthops all using the same netdev ('dummy10') takes less than a second, deletion takes about 130 seconds: # time -p ip -b nexthop.batch real 0.29 user 0.01 sys 0.15 # time -p ip link set dev dummy10 down real 131.03 user 0.06 sys 0.52 This is because

Re: [PATCH net] net: dsa: point out the tail taggers

2020-10-16 Thread Vladimir Oltean
On Sat, Oct 17, 2020 at 01:25:08AM +0800, kernel test robot wrote: > Hi Christian, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on net/master] > > url: > https://github.com/0day-ci/linux/commits/Christian-Eggers/net-dsa-point-out-the-tail-taggers/20201017-00

  1   2   >