[PATCH v2 net 1/5] net: ipa: assign proper packet context base

2020-10-28 Thread Alex Elder
At the end of ipa_mem_setup() we write the local packet processing context base register to tell it where the processing context memory is. But we are writing the wrong value. The value written turns out to be the offset of the modem header memory region (assigned earlier in the function). Fix t

Re: [patch] socket.7: document SO_INCOMING_NAPI_ID

2020-10-28 Thread Michael Kerrisk (man-pages)
On 10/28/20 7:13 AM, Michael Kerrisk (man-pages) wrote: > On 10/28/20 2:15 AM, Sridhar Samudrala wrote: >> Add documentation for SO_INCOMING_NAPI_ID in socket.7 man page. > > Hello Sridhar, > > Thank you! > > Would it be possible for you to resubmit the patch, with a commit > message that says h

Re: [PATCH rdma v2] RDMA: Add rdma_connect_locked()

2020-10-28 Thread Jason Gunthorpe
On Wed, Oct 28, 2020 at 11:19:14AM +0200, Maor Gottlieb wrote: > > + struct rdma_conn_param *conn_param) > > { > > struct rdma_id_private *id_priv = > > container_of(id, struct rdma_id_private, id); > > int ret; > > - mutex_lock(&id_priv->handler_mutex); >

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Alexei Starovoitov
On Wed, Oct 28, 2020 at 06:15:05PM +0100, Ard Biesheuvel wrote: > Commit 3193c0836 ("bpf: Disable GCC -fgcse optimization for > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > function scope __attribute__((optimize("-fno-gcse"))), to disable a > GCC specific optimization that

[PATCH v8,net-next,12/12] crypto: octeontx2: register with linux crypto framework

2020-10-28 Thread Srujana Challa
CPT offload module utilises the linux crypto framework to offload crypto processing. This patch registers supported algorithms by calling registration functions provided by the kernel crypto API. The module currently supports: - AES block cipher in CBC,ECB,XTS and CFB mode. - 3DES block cipher in

[PATCH v4 1/5] dt-bindings: vendor-prefixes: Add asix prefix

2020-10-28 Thread Łukasz Stelmach
Add the prefix for ASIX Electronics Corporation. Signed-off-by: Łukasz Stelmach Reviewed-by: Krzysztof Kozlowski Acked-by: Rob Herring --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefi

[PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-28 Thread Łukasz Stelmach
ASIX AX88796[1] is a versatile ethernet adapter chip, that can be connected to a CPU with a 8/16-bit bus or with an SPI. This driver supports SPI connection. The driver has been ported from the vendor kernel for ARTIK5[2] boards. Several changes were made to adapt it to the current kernel which in

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-10-28 Thread Ido Schimmel
On Tue, Oct 27, 2020 at 01:52:49PM +0200, Vladimir Oltean wrote: > Hi Ido, Hello, > > On Mon, Jul 27, 2020 at 07:56:38PM +0300, Ido Schimmel wrote: > > > The whole purpose of my patch series is to remove the CPU port from the > > > flood domain of all switchdev net_devices. That means, when an u

[PATCH v8,net-next,06/12] crypto: octeontx2: enable SR-IOV and mailbox communication with VF

2020-10-28 Thread Srujana Challa
Adds 'sriov_configure' to enable/disable virtual functions (VFs). Also Initializes VF<=>PF mailbox IRQs, register handlers for processing these mailbox messages. Admin function (AF) handles resource allocation and configuration for PFs and their VFs. PFs request the AF directly, via mailboxes. Unl

Re: [PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

2020-10-28 Thread Alexei Starovoitov
On Wed, Oct 28, 2020 at 09:25:24PM +0800, Hangbin Liu wrote: > This series converts iproute2 to use libbpf for loading and attaching > BPF programs when it is available. This means that iproute2 will > correctly process BTF information and support the new-style BTF-defined > maps, while keeping com

[PATCH v4 2/5] dt-bindings: net: Add bindings for AX88796C SPI Ethernet Adapter

2020-10-28 Thread Łukasz Stelmach
Add bindings for AX88796C SPI Ethernet Adapter. Signed-off-by: Łukasz Stelmach --- .../bindings/net/asix,ax88796c.yaml | 69 +++ 1 file changed, 69 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/asix,ax88796c.yaml diff --git a/Documentation/dev

Re: [PATCH] tools/perf: Remove broken __no_tail_call attribute

2020-10-28 Thread Miguel Ojeda
On Wed, Oct 28, 2020 at 9:11 AM Peter Zijlstra wrote: > > Subject: tools/perf: Remove broken __no_tail_call attribute Acked-by: Miguel Ojeda Cheers, Miguel

[PATCH net-next v3 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-28 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recogniz

Re: [PATCH v2 2/2] net: ftgmac100: add handling of mdio/phy nodes for ast2400/2500

2020-10-28 Thread Ivan Mikhaylov
On Tue, 2020-10-27 at 19:23 +0100, Andrew Lunn wrote: > On Tue, Oct 27, 2020 at 05:49:24PM +0300, Ivan Mikhaylov wrote: > > phy-handle can't be handled well for ast2400/2500 which has an embedded > > MDIO controller. Add ftgmac100_mdio_setup for ast2400/2500 and initialize > > PHYs from mdio child

Re: [PATCH v2 net] net/sched: act_mpls: Add softdep on mpls_gso.ko

2020-10-28 Thread Guillaume Nault
On Wed, Oct 28, 2020 at 12:35:17PM -0700, Cong Wang wrote: > On Tue, Oct 27, 2020 at 2:39 PM Guillaume Nault wrote: > > > > On Tue, Oct 27, 2020 at 10:28:29AM -0700, Cong Wang wrote: > > > On Mon, Oct 26, 2020 at 4:23 AM Guillaume Nault wrote: > > > > > > > > TCA_MPLS_ACT_PUSH and TCA_MPLS_ACT_MA

[PATCH v2 net 0/5] net: ipa: minor bug fixes

2020-10-28 Thread Alex Elder
This series fixes several bugs. They are minor, in that the code currently works on supported platforms even without these patches applied, but they're bugs nevertheless and should be fixed. Version 2 improves the commit message for the fourth patch. It also fixes a bug in two spots in the last

RE: [PATCH net 2/2] dpaa_eth: fix the RX headroom size alignment

2020-10-28 Thread Camelia Alexandra Groza
> -Original Message- > From: Willem de Bruijn > Sent: Tuesday, October 27, 2020 23:31 > To: Camelia Alexandra Groza > Cc: Madalin Bucur (OSS) ; David Miller > ; Jakub Kicinski ; Network > Development > Subject: Re: [PATCH net 2/2] dpaa_eth: fix the RX headroom size alignment > > On Tue,

[PATCH v8,net-next,04/12] drivers: crypto: add Marvell OcteonTX2 CPT PF driver

2020-10-28 Thread Srujana Challa
Adds skeleton for the Marvell OcteonTX2 CPT physical function driver which includes probe, PCI specific initialization and hardware register defines. RVU defines are present in AF driver (drivers/net/ethernet/marvell/octeontx2/af), header files from AF driver are included here to avoid duplication.

Re: [RFC bpf-next 00/16] bpf: Speed up trampoline attach

2020-10-28 Thread Alexei Starovoitov
On Tue, Oct 27, 2020 at 03:28:03PM +0100, Jiri Olsa wrote: > On Mon, Oct 26, 2020 at 09:30:14PM -0700, Alexei Starovoitov wrote: > > On Thu, Oct 22, 2020 at 10:42:05AM -0400, Steven Rostedt wrote: > > > On Thu, 22 Oct 2020 16:11:54 +0200 > > > Jiri Olsa wrote: > > > > > > > I understand direct ca

[PATCH v8,net-next,11/12] crypto: octeontx2: add support to process the crypto request

2020-10-28 Thread Srujana Challa
Attach LFs to CPT VF to process the crypto requests and register LF interrupts. Signed-off-by: Suheil Chandran Signed-off-by: Srujana Challa --- drivers/crypto/marvell/octeontx2/Makefile | 2 +- .../marvell/octeontx2/otx2_cpt_common.h | 3 + .../marvell/octeontx2/otx2_cpt_reqmgr.h

Re: [RFC PATCH net-next v3] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-28 Thread Michal Kubecek
On Tue, Oct 27, 2020 at 02:53:05PM -0700, Jakub Kicinski wrote: > On Tue, 27 Oct 2020 16:51:14 +0200 Ido Schimmel wrote: > > From: Ido Schimmel > > > > With the ioctl interface, when autoneg is enabled, but without > > specifying speed, duplex or link modes, the advertised link modes are > > set

[PATCH bpf-next] bpf: add struct bpf_redir_neigh forward declaration to BPF helper defs

2020-10-28 Thread Andrii Nakryiko
Forward-declare struct bpf_redir_neigh in bpf_helper_defs.h to avoid compiler warning about unknown structs. Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop") Signed-off-by: Andrii Nakryiko --- scripts/bpf_helpers_doc.py | 1 + 1 file changed, 1 inserti

Re: [PATCH] net: cls_api: remove unneeded local variable in tc_dump_chain()

2020-10-28 Thread Cong Wang
On Wed, Oct 28, 2020 at 6:59 AM Tom Rix wrote: > > > On 10/28/20 4:35 AM, Lukas Bulwahn wrote: > > @@ -2971,13 +2963,11 @@ static int tc_dump_chain(struct sk_buff *skb, > > struct netlink_callback *cb) > > if (!dev) > > return skb->len; > > > > - pa

[PATCH net-next v3] net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode

2020-10-28 Thread Robert Hancock
Update the axienet driver to properly support the Xilinx PCS/PMA PHY component which is used for 1000BaseX and SGMII modes, including properly configuring the auto-negotiation mode of the PHY and reading the negotiated state from the PHY. Signed-off-by: Robert Hancock --- Changed since v2: Remov

[PATCH net-next 2/3] net/core: introduce default_rps_mask netns attribute

2020-10-28 Thread Paolo Abeni
If RPS is enabled, this allows configuring a default rps mask, which is effective since receive queue creation time. A default RPS mask allows the system admin to ensure proper isolation, avoiding races at network namespace or device creation time. The default RPS mask is initially empty, and can

[PATCH net-next v3 2/4] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner

2020-10-28 Thread Xie He
The eth_type_trans function is called when we receive frames carrying Ethernet frames. This function expects a non-NULL pointer as an argument, and assigns it directly to skb->dev. However, the code handling other types of frames first assigns a pointer to "dev", and then at the end checks whether

[PATCH net-next v7 5/8] net: dsa: hellcreek: Add support for hardware timestamping

2020-10-28 Thread Kurt Kanzenbach
From: Kamil Alkhouri The switch has the ability to take hardware generated time stamps per port for PTPv2 event messages in Rx and Tx direction. That is useful for achieving needed time synchronization precision for TSN devices/switches. So add support for it. There are two directions: * RX

Re: [PATCH net-next v7 3/8] net: dsa: Add DSA driver for Hirschmann Hellcreek switches

2020-10-28 Thread Vladimir Oltean
On Wed, Oct 28, 2020 at 08:42:16AM +0100, Kurt Kanzenbach wrote: > Add a basic DSA driver for Hirschmann Hellcreek switches. Those switches are > implementing features needed for Time Sensitive Networking (TSN) such as > support > for the Time Precision Protocol and various shapers like the Time A

[PATCH net-next 1/3] net/sysctl: factor-out netdev_rx_queue_set_rps_mask() helper

2020-10-28 Thread Paolo Abeni
Will simplify the following patch. No functional change intended. Signed-off-by: Paolo Abeni --- net/core/net-sysfs.c | 66 1 file changed, 36 insertions(+), 30 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index 94fff0700bdd.

[PATCH net-next 0/3] net: introduce rps_default_mask

2020-10-28 Thread Paolo Abeni
Real-time setups try hard to ensure proper isolation between time critical applications and e.g. network processing performed by the network stack in softirq and RPS is used to move the softirq activity away from the isolated core. If the network configuration is dynamic, with netns and devices r

[PATCH net-next v7 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches

2020-10-28 Thread Kurt Kanzenbach
Add basic documentation and example. Signed-off-by: Kurt Kanzenbach Reviewed-by: Rob Herring Reviewed-by: Florian Fainelli --- .../net/dsa/hirschmann,hellcreek.yaml | 127 ++ 1 file changed, 127 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/ds

[PATCH net-next v5] net: phy: marvell: add special handling of Finisar modules with 88E1111

2020-10-28 Thread Robert Hancock
The Finisar FCLF8520P2BTL 1000BaseT SFP module uses a Marvel 88E PHY with a modified PHY ID. Add support for this ID using the 88E methods. By default these modules do not have 1000BaseX auto-negotiation enabled, which is not generally desirable with Linux networking drivers. Add handling

[PATCH net] cadence: force nonlinear buffers to be cloned

2020-10-28 Thread Mark Deneen
In my test setup, I had a SAMA5D27 device configured with ip forwarding, and second device with usb ethernet (r8152) sending ICMP packets.  If the packet was larger than about 220 bytes, the SAMA5 device would "oops" with the following trace: kernel BUG at net/core/skbuff.c:1863! Internal error: O

Re: [RFC PATCH net-next v3] ethtool: Improve compatibility between netlink and ioctl interfaces

2020-10-28 Thread Ido Schimmel
On Wed, Oct 28, 2020 at 01:53:39AM +0100, Michal Kubecek wrote: > On Tue, Oct 27, 2020 at 02:53:05PM -0700, Jakub Kicinski wrote: > > On Tue, 27 Oct 2020 16:51:14 +0200 Ido Schimmel wrote: > > > From: Ido Schimmel > > > > > > With the ioctl interface, when autoneg is enabled, but without > > > sp

Re: WARNING in xfrm_alloc_compat

2020-10-28 Thread Dmitry Safonov
On 10/28/20 10:45 AM, Steffen Klassert wrote: > Same here, Dmitry please look into it. Looking on both, thanks! > I guess we can just remove the WARN_ON() that > triggeres here. Thanks, Dmitry

[PATCH net-next 3/4] net: hdlc_fr: Improve the initial check when we receive an skb

2020-10-28 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_fx. fh

[PATCH] tools/perf: Remove broken __no_tail_call attribute

2020-10-28 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 04:11:27PM -0700, Nick Desaulniers wrote: > On Tue, Oct 27, 2020 at 4:04 PM Daniel Borkmann wrote: > > > > On 10/27/20 9:57 PM, Ard Biesheuvel wrote: > > > Commit 3193c0836f203 ("bpf: Disable GCC -fgcse optimization for > > > ___bpf_prog_run()") introduced a __no_fgcse macr

Re: [PATCH v3 net-next] net: bridge: mcast: add support for raw L2 multicast groups

2020-10-28 Thread Nikolay Aleksandrov
On Wed, 2020-10-28 at 12:54 +0200, Vladimir Oltean wrote: > From: Nikolay Aleksandrov > > Extend the bridge multicast control and data path to configure routes > for L2 (non-IP) multicast groups. > > The uapi struct br_mdb_entry union u is extended with another variant, > mac_addr, which does no

[bpf-next PATCH 2/4] selftests/bpf: Drop python client/server in favor of threads

2020-10-28 Thread Alexander Duyck
From: Alexander Duyck Drop the tcp_client/server.py files in favor of using a client and server thread within the test case. Specifically we spawn a new thread to play the role of the server, and the main testing thread plays the role of client. Doing this we are able to reduce overhead since we

Re: [PATCH bpf-next V4 2/5] bpf: bpf_fib_lookup return MTU value as output when looked up

2020-10-28 Thread Dan Carpenter
Hi Jesper, url: https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/bpf-New-approach-for-BPF-MTU-handling/20201028-002919 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf.git master config: i386-randconfig-m021-20201026 (attached as .config) compiler: gcc-9 (Debian

[PATCH net-next v3 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-28 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev

Re: [PATCH v4 3/3] mac80211: add KCOV remote annotations to incoming frame processing

2020-10-28 Thread Johannes Berg
On Wed, 2020-10-28 at 18:20 +, Aleksandr Nogikh wrote: > From: Aleksandr Nogikh > > Add KCOV remote annotations to ieee80211_iface_work and > ieee80211_rx. This will enable coverage-guided fuzzing of > mac80211 code that processes incoming 802.11 frames. > > Signed-off-by: Aleksandr Nogikh

Re: [PATCH net 5/5] net: ipa: avoid going past end of resource group array

2020-10-28 Thread Alex Elder
On 10/27/20 7:14 PM, Willem de Bruijn wrote: > On Tue, Oct 27, 2020 at 12:38 PM Alex Elder wrote: >> >> The minimum and maximum limits for resources assigned to a given >> resource group are programmed in pairs, with the limits for two >> groups set in a single register. >> >> If the number of sup

[PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-28 Thread Tsuchiya Yuto
To make the ps_mode (power_save) control easier, this commit adds a new module parameter allow_ps_mode and set it false (disallowed) by default. When this parameter is set to false, changing the power_save mode will be disallowed like the following: $ sudo iw dev mlan0 set power_save on c

[net-next] tipc: remove dead code in tipc_net and relatives

2020-10-28 Thread Hoang Huu Le
dist_queue is no longer used since commit 37922ea4a310 ("tipc: permit overlapping service ranges in name table") Acked-by: Jon Maloy Acked-by: Ying Xue Signed-off-by: Hoang Huu Le --- net/tipc/core.c | 2 -- net/tipc/core.h | 3 --- net/tipc/name_distr.c | 19 ---

Re: [PATCH v5 3/3] net: dsa: mv88e6xxx: Add support for mv88e6393x family of Marvell

2020-10-28 Thread Marek Behun
Pavana, please add me to Cc for this. Does USXGMII mode work? There are some erratas for for 10gb serdes mode. Also you should split this patch. The code that refactores the serdes_get_lane methods should be in a separate patch. I have a device with this switch and also a SFP module which can o

[PATCH v8,net-next,09/12] crypto: octeontx2: add support to get engine capabilities

2020-10-28 Thread Srujana Challa
Adds support to get engine capabilities and adds a new mailbox to share capabilities with VF driver. Signed-off-by: Suheil Chandran Signed-off-by: Srujana Challa --- .../marvell/octeontx2/otx2_cpt_common.h | 36 .../marvell/octeontx2/otx2_cpt_reqmgr.h | 51 ++ drivers/cry

Re: [PATCH RESEND 0/3] Fix wrong identifiers on kernel-doc markups

2020-10-28 Thread Mark Brown
On Mon, Oct 26, 2020 at 10:47:35AM +0100, Mauro Carvalho Chehab wrote: > Hi Mark/Jakub, > > As you requested, I'm resending the three -net patches > from the /56 patch series I sent last Friday: I was asking for you to do the same for the patches for my subsystems rather than resend the net patch

[PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Ard Biesheuvel
Commit 3193c0836 ("bpf: Disable GCC -fgcse optimization for ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a function scope __attribute__((optimize("-fno-gcse"))), to disable a GCC specific optimization that was causing trouble on x86 builds, and was not expected to have any posi

[PATCH v2 2/2] bpf: move interpreter into separate source file

2020-10-28 Thread Ard Biesheuvel
To reduce the impact of disabling certain compiler optimizations that are only needed for the interpreter, move it into its own source file, and apply the compiler command line override only to this file. Signed-off-by: Ard Biesheuvel --- include/linux/filter.h | 1 + kernel/bpf/Makefile|

[PATCH v4 2/3] net: add kcov handle to skb extensions

2020-10-28 Thread Aleksandr Nogikh
From: Aleksandr Nogikh Remote KCOV coverage collection enables coverage-guided fuzzing of the code that is not reachable during normal system call execution. It is especially helpful for fuzzing networking subsystems, where it is common to perform packet handling in separate work queues even for

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Thomas Gleixner
On Wed, Oct 28 2020 at 13:17, Heiner Kallweit wrote: > On 28.10.2020 12:43, Serge Belyshev wrote: >>> For several network drivers it was reported that using >>> __napi_schedule_irqoff() is unsafe with forced threading. One way to >>> fix this is switching back to __napi_schedule, but then we lose t

Re: [RFC PATCH 0/4] net: dsa: link aggregation support

2020-10-28 Thread Tobias Waldekranz
On Wed, Oct 28, 2020 at 00:32, Vladimir Oltean wrote: > And this all happens because for FROM_CPU packets, the hardware is > configured in mv88e6xxx_devmap_setup to deliver all packets with a > non-local switch ID towards the same "routing" port, right? Precisely. > Whereas for FORWARD frames, t

[RFC PATCH bpf-next 5/9] xsk: add busy-poll support for {recv,send}msg()

2020-10-28 Thread Björn Töpel
From: Björn Töpel Wire-up XDP socket busy-poll support for recvmsg() and sendmsg(). Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index 2e5b9f27c7a3..da649b4f377c 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xs

Re: [PATCH 20/33] docs: ABI: testing: make the files compatible with ReST output

2020-10-28 Thread Richard Cochran
On Wed, Oct 28, 2020 at 03:23:18PM +0100, Mauro Carvalho Chehab wrote: > diff --git a/Documentation/ABI/testing/sysfs-uevent > b/Documentation/ABI/testing/sysfs-uevent > index aa39f8d7bcdf..d0893dad3f38 100644 > --- a/Documentation/ABI/testing/sysfs-uevent > +++ b/Documentation/ABI/testing/sysfs-

Re: [RFC PATCH 4/4] net: dsa: tag_edsa: support reception of packets from lag devices

2020-10-28 Thread Tobias Waldekranz
On Wed Oct 28, 2020 at 3:05 PM CET, Vladimir Oltean wrote: > On one hand, I feel pretty yucky about this change. > On the other hand, I wonder if it might be useful under some conditions > for drivers with DSA_TAG_PROTO_NONE? For example, once the user bridges > all slave interfaces, then that brid

Re: [PATCH] mdio: use inline functions for to_mdio_device() etc

2020-10-28 Thread Arnd Bergmann
On Wed, Oct 28, 2020 at 2:16 AM Jakub Kicinski wrote: > On Mon, 26 Oct 2020 17:51:09 +0100 Arnd Bergmann wrote: > > > Fixes: a9049e0c513c ("mdio: Add support for mdio drivers.") > > I feel like this is slightly onerous, please drop the tag. > > Harmless W=2 warnings hardly call for getting this i

[PATCH v8 1/2] bus: mhi: Add mhi_queue_is_full function

2020-10-28 Thread Loic Poulain
This function can be used by client driver to determine whether it's possible to queue new elements in a channel ring. Signed-off-by: Loic Poulain --- v1->v5: not part of the series v6: Add this commit, used for stopping TX queue v7: no change v8: remove static change (up to the compiler) d

[PATCH v8,net-next,07/12] crypto: octeontx2: load microcode and create engine groups

2020-10-28 Thread Srujana Challa
CPT includes microcoded GigaCypher symmetric engines(SEs), IPsec symmetric engines(IEs), and asymmetric engines (AEs). Each engine receives CPT instructions from the engine groups it has subscribed to. This patch loads microcode, configures three engine groups(one for SEs, one for IEs and one for A

Re: [PATCH 1/2] tools, bpftool: Avoid array index warnings.

2020-10-28 Thread Andrii Nakryiko
On Tue, Oct 27, 2020 at 4:37 PM Ian Rogers wrote: > > The bpf_caps array is shorter without CAP_BPF, avoid out of bounds reads > if this isn't defined. Working around this avoids -Wno-array-bounds with > clang. > > Signed-off-by: Ian Rogers > --- Acked-by: Andrii Nakryiko > tools/bpf/bpftool/

[PATCH net-next 4/5] net: phy: marvell10g: change MACTYPE if underlying MAC does not support it

2020-10-28 Thread Marek Behún
RollBall SFPs contain a Marvell 88X3310 PHY, but by default the MACTYPE is set to 10GBASE-R with Rate Matching. Some devices (for example those based on Armada 38x) only support up to 2500base-x SerDes modes. Change the PHY's MACTYPE to 4 (which means changing between 10gbase-r, 5gbase-r, 2500bas

[PATCH net-next 2/5] net: phylink: allow attaching phy for SFP modules on 802.3z mode

2020-10-28 Thread Marek Behún
Some SFPs may contain an internal PHY which may in some cases want to connect with the host interface in 1000base-x/2500base-x mode. Do not fail if such PHY is being attached in one of these PHY interface modes. Signed-off-by: Marek Behún Cc: Andrew Lunn Cc: Russell King --- drivers/net/phy/ph

[PATCH -next] net: wan: sdla: Use bitwise instead of arithmetic

2020-10-28 Thread Zou Wei
Fix the following coccinelle warnings: ./drivers/net/wan/sdla.c:841:38-39: WARNING: sum of probable bitmasks, consider | Reported-by: Hulk Robot Signed-off-by: Zou Wei --- drivers/net/wan/sdla.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wan/sdla.c b/dri

[PATCH net-next 3/5] net: sfp: configure/destroy I2C mdiobus on transceiver plug/unplug

2020-10-28 Thread Marek Behún
Instead of configuring the I2C mdiobus when SFP driver is probed, configure/destroy the mdiobus when SFP transceiver is plugged/unplugged. This way we can tell the mdio-i2c code which protocol to use for each SFP transceiver. Signed-off-by: Marek Behún Cc: Andrew Lunn Cc: Russell King --- dri

[PATCH v2 net 2/5] net: ipa: fix resource group field mask definition

2020-10-28 Thread Alex Elder
The mask for the RSRC_GRP field in the INIT_RSRC_GRP endpoint initialization register is incorrectly defined for IPA v4.2 (where it is only one bit wide). So we need to fix this. The fix is not straightforward, however. Field masks are passed to functions like u32_encode_bits(), and for that the

[PATCH net-next 5/5] net: sfp: add support for multigig RollBall transceivers

2020-10-28 Thread Marek Behún
This adds support for multigig copper SFP modules from RollBall/Hilink. These modules have a specific way to access clause 45 registers of the internal PHY. We also need to wait at least 25 seconds after deasserting TX disable before accessing the PHY. The code waits for 30 seconds just to be sure

Re: [RFC] clang tooling cleanups

2020-10-28 Thread Finn Thain
On Tue, 27 Oct 2020, t...@redhat.com wrote: > This rfc will describe > An upcoming treewide cleanup. > How clang tooling was used to programatically do the clean up. > Solicit opinions on how to generally use clang tooling. > This tooling is very impressive. It makes possible an idea that I ha

[PATCH net-next v2 1/4] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames

2020-10-28 Thread Xie He
When the fr_rx function drops a received frame (because the protocol type is not supported, or because the PVC virtual device that corresponds to the DLCI number and the protocol type doesn't exist), the function frees the skb and returns. The code for freeing the skb and returning is repeated sev

[PATCH net-next v3 3/4] net: hdlc_fr: Improve the initial checks when we receive an skb

2020-10-28 Thread Xie He
1. Change the skb->len check from "<= 4" to "< 4". At first we only need to ensure a 4-byte header is present. We indeed normally need the 5th byte, too, but it'd be more logical and cleaner to check its existence when we actually need it. 2. Add an fh->ea2 check to the initial checks in fr_rx. fh

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-28 Thread Ard Biesheuvel
On Wed, 28 Oct 2020 at 22:39, Alexei Starovoitov wrote: > > On Wed, Oct 28, 2020 at 06:15:05PM +0100, Ard Biesheuvel wrote: > > Commit 3193c0836 ("bpf: Disable GCC -fgcse optimization for > > ___bpf_prog_run()") introduced a __no_fgcse macro that expands to a > > function scope __attribute__((opti

[PATCH v4 1/3] kernel: make kcov_common_handle consider the current context

2020-10-28 Thread Aleksandr Nogikh
From: Aleksandr Nogikh kcov_common_handle is a method that is used to obtain a "default" KCOV remote handle of the current process. The handle can later be passed to kcov_remote_start in order to collect coverage for the processing that is initiated by one process, but done in another. For detail

[PATCH net-next 1/5] net: phy: mdio-i2c: support I2C MDIO protocol for RollBall SFP modules

2020-10-28 Thread Marek Behún
Some multigig SFPs from RollBall and Hilink do not expose functional MDIO access to the internal PHY of the SFP via I2C address 0x56 (although there seems to be read-only clause 22 access on this address). Instead these SFPs PHY can be accessed via I2C via the SFP Enhanced Digital Diagnostic Inter

[RFC PATCH 1/3] mwifiex: pcie: add DMI-based quirk impl for Surface devices

2020-10-28 Thread Tsuchiya Yuto
This commit adds quirk implementation based on DMI matching with DMI table for Microsoft Surface devices that uses mwifiex chip (currently, all the devices that use mwifiex equip PCIe-88W8897 chip). This implementation can be used for quirks later. Signed-off-by: Tsuchiya Yuto --- drivers/net/w

[PATCH net-next 0/5] Support for RollBall 10G copper SFP modules

2020-10-28 Thread Marek Behún
Hello, this series adds support for RollBall/Hilink SFP modules. These are copper modules capable of up to 10G via copper. They contain a Marvell 88X3310 PHY. These modules by default configure the internal PHY into XFI with Rate Matching mode on the MAC side. To support devices which have MAC ca

[PATCH net-next 4/4] net: hdlc_fr: Add support for any Ethertype

2020-10-28 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only recogniz

[PATCH net 1/2] ibmvnic: notify peers when failover and migration happen

2020-10-28 Thread Lijun Pan
We need to notify peers only when failover and migration happen. It is unnecessary to call that in other events like FATAL, NON_FATAL, CHANGE_PARAM, and TIMEOUT resets since in those scenarios the MAC address and ip address mapping does not change. Originally all the resets except CHANGE_PARAM are

Re: [PATCH] net: ftgmac100: Ensure tx descriptor updates are visible

2020-10-28 Thread Arnd Bergmann
On Wed, Oct 28, 2020 at 5:47 AM Joel Stanley wrote: > > On Thu, 22 Oct 2020 at 07:41, Benjamin Herrenschmidt > wrote: > > > > > > > > + /* Ensure the descriptor config is visible before setting the tx > > > > +* pointer. > > > > +*/ > > > > + smp_wmb(); > > > > + > > >

[PATCH v2] net: fec: fix MDIO probing for some FEC hardware blocks

2020-10-28 Thread Greg Ungerer
Some (apparently older) versions of the FEC hardware block do not like the MMFR register being cleared to avoid generation of MII events at initialization time. The action of clearing this register results in no future MII events being generated at all on the problem block. This means the probing o

Re: [PATCH v3] net: core: Use skb_is_gso() in skb_checksum_help()

2020-10-28 Thread Jakub Kicinski
On Tue, 27 Oct 2020 13:59:04 +0800 Yi Li wrote: > No functional changes, just minor refactoring. > > Signed-off-by: Yi Li Applied, thanks!

Re: [PATCH net-next 01/11] atm: horizon: shut up clang null pointer arithmetic warning

2020-10-28 Thread Jakub Kicinski
On Mon, 26 Oct 2020 22:29:48 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > Building a "W=1" kernel with clang produces a warning about > suspicous pointer arithmetic: > > drivers/atm/horizon.c:1844:52: warning: performing pointer arithmetic > on a null pointer has undefined behavior [-Wnu

[PATCH bpf-next v4] bpf: Lift hashtab key_size limit

2020-10-28 Thread Florian Lehner
Currently key_size of hashtab is limited to MAX_BPF_STACK. As the key of hashtab can also be a value from a per cpu map it can be larger than MAX_BPF_STACK. The use-case for this patch originates to implement allow/disallow lists for files and file paths. The maximum length of file paths is define

Re: [tipc-discussion] [net v3 1/1] tipc: fix memory leak caused by tipc_buf_append()

2020-10-28 Thread Cong Wang
On Tue, Oct 27, 2020 at 1:09 PM Tung Nguyen wrote: > > Commit ed42989eab57 ("tipc: fix the skb_unshare() in tipc_buf_append()") > replaced skb_unshare() with skb_copy() to not reduce the data reference > counter of the original skb intentionally. This is not the correct More precisely, it is shin

Re: [PATCH net] r8169: fix operation under forced interrupt threading

2020-10-28 Thread Serge Belyshev
> For several network drivers it was reported that using > __napi_schedule_irqoff() is unsafe with forced threading. One way to > fix this is switching back to __napi_schedule, but then we lose the > benefit of the irqoff version in general. As stated by Eric it doesn't > make sense to make the m

[PATCH v2 net 5/5] net: ipa: avoid going past end of resource group array

2020-10-28 Thread Alex Elder
The minimum and maximum limits for resources assigned to a given resource group are programmed in pairs, with the limits for two groups set in a single register. If the number of supported resource groups is odd, only half of the register that defines these limits is valid for the last group; that

Re: [RFC PATCH 4/4] net: dsa: tag_edsa: support reception of packets from lag devices

2020-10-28 Thread Vladimir Oltean
Adding Ido here, he has some more experience with the do's and dont's here, and therefore might have one or two ideas to share. On Wed, Oct 28, 2020 at 04:28:23PM +0100, Tobias Waldekranz wrote: > On Wed Oct 28, 2020 at 3:05 PM CET, Vladimir Oltean wrote: > > On one hand, I feel pretty yucky about

Re: [PATCH net-next 1/4] net: xdp: introduce bulking for xdp tx return path

2020-10-28 Thread Lorenzo Bianconi
> On Tue, 27 Oct 2020 20:04:07 +0100 > Lorenzo Bianconi wrote: > > > Introduce bulking capability in xdp tx return path (XDP_REDIRECT). > > xdp_return_frame is usually run inside the driver NAPI tx completion > > loop so it is possible batch it. > > Current implementation considers only page_pool

general protection fault in wext_handle_ioctl

2020-10-28 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8c2ab803 Merge tag 'orphan-handling-v5.10-rc2' of git://gi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12e5787050 kernel config: https://syzkaller.appspot.com/x/.config?x=3140f5be49a06bf9 das

Re: Re: [PATCH v2 net] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-10-28 Thread Vishwanath Pai
On 9/17/20 3:26 PM, Cong Wang wrote: > On Fri, Sep 11, 2020 at 1:13 AM Yunsheng Lin wrote: >> >> On 2020/9/11 4:07, Cong Wang wrote: >>> On Tue, Sep 8, 2020 at 4:06 AM Yunsheng Lin wrote: Currently there is concurrent reset and enqueue operation for the same lockless qdisc whe

Re: [PATCH RFC net-next 00/13] RX filtering for DSA switches

2020-10-28 Thread Vladimir Oltean
On Wed, Oct 28, 2020 at 04:43:38PM +0200, Ido Schimmel wrote: > In "standalone" mode your netdev is like any other netdev and if it does > not support Rx filtering, then pass everything to the CPU and let it > filter what it does not want to see. I don't see the problem. This is > exactly what mlx

[net] tipc: add stricter control of reserved service types

2020-10-28 Thread jmaloy
From: Jon Maloy TIPC reserves 64 service types for current and future internal use. Therefore, the bind() function is meant to block regular user sockets from being bound to these values, while it should let through such bindings from internal users. However, since we at the design moment saw no

[PATCH net 2/2] ibmvnic: skip tx timeout reset while in resetting

2020-10-28 Thread Lijun Pan
Sometimes it takes longer than 5 seconds to complete failover, migration, and other resets. In stead of scheduling another timeout reset, we wait for the current one to complete. Suggested-by: Brian King Signed-off-by: Lijun Pan --- drivers/net/ethernet/ibm/ibmvnic.c | 6 ++ 1 file changed,

[PATCHv2 iproute2-next 4/5] examples/bpf: move struct bpf_elf_map defined maps to legacy folder

2020-10-28 Thread Hangbin Liu
Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README| 14 +- examples/bpf/{ => legacy}/bpf_cyclic.c | 2 +- examples/bpf/{ => legacy}/bpf_graft.c | 2 +- examples/bpf/{ => legacy}/bpf_map_in_map.c | 2 +- examples/

[PATCHv2 iproute2-next 1/5] configure: add check_libbpf() for later libbpf support

2020-10-28 Thread Hangbin Liu
This patch adds a check to see if we support libbpf. By default the system libbpf will be used, but static linking against a custom libbpf version can be achieved by passing LIBBPF_DIR to configure. FORCE_LIBBPF can be set to force configure to abort if no suitable libbpf is found, which is useful

[RFC PATCH bpf-next 3/9] xsk: add support for recvmsg()

2020-10-28 Thread Björn Töpel
From: Björn Töpel Add support for non-blocking recvmsg() to XDP sockets. Previously, only sendmsg() was supported by XDP socket. Now, for symmetry and the upcoming busy-polling support, recvmsg() is added. Signed-off-by: Björn Töpel --- net/xdp/xsk.c | 22 +- 1 file changed

[PATCHv2 iproute2-next 0/5] iproute2: add libbpf support

2020-10-28 Thread Hangbin Liu
This series converts iproute2 to use libbpf for loading and attaching BPF programs when it is available. This means that iproute2 will correctly process BTF information and support the new-style BTF-defined maps, while keeping compatibility with the old internal map definition syntax. This is achi

Re: KASAN: slab-out-of-bounds Write in xfrm_attr_cpy32

2020-10-28 Thread Steffen Klassert
Dimitry, you added this code, can you please look into that? Thanks! On Wed, Oct 28, 2020 at 05:00:22PM +0800, Hillf Danton wrote: > On Fri, 23 Oct 2020 01:38:23 -0700 > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit:c4d6fe73 Merge tag 'xarray-5.9' of git://git.

Re: [RFC bpf-next 07/16] kallsyms: Use rb tree for kallsyms name search

2020-10-28 Thread Jiri Olsa
On Thu, Oct 22, 2020 at 10:21:29AM +0200, Jiri Olsa wrote: > The kallsyms_expand_symbol function showed in several bpf related > profiles, because it's doing linear search. > > Before: > > Performance counter stats for './src/bpftrace -ve kfunc:__x64_sys_s* \ >{ printf("test\n"); } i:ms:10 {

Re: [PATCH v2 net] net/sched: act_mpls: Add softdep on mpls_gso.ko

2020-10-28 Thread Cong Wang
On Tue, Oct 27, 2020 at 2:39 PM Guillaume Nault wrote: > > On Tue, Oct 27, 2020 at 10:28:29AM -0700, Cong Wang wrote: > > On Mon, Oct 26, 2020 at 4:23 AM Guillaume Nault wrote: > > > > > > TCA_MPLS_ACT_PUSH and TCA_MPLS_ACT_MAC_PUSH might be used on gso > > > packets. Such packets will thus requi

[PATCH v3 net-next] net: bridge: mcast: add support for raw L2 multicast groups

2020-10-28 Thread Vladimir Oltean
From: Nikolay Aleksandrov Extend the bridge multicast control and data path to configure routes for L2 (non-IP) multicast groups. The uapi struct br_mdb_entry union u is extended with another variant, mac_addr, which does not change the structure size, and which is valid when the proto field is

[PATCHv2 iproute2-next 5/5] examples/bpf: add bpf examples with BTF defined maps

2020-10-28 Thread Hangbin Liu
Users should try use the new BTF defined maps instead of struct bpf_elf_map defined maps. The tail call examples are not added yet as libbpf doesn't currently support declaratively populating tail call maps. Reviewed-by: Toke Høiland-Jørgensen Signed-off-by: Hangbin Liu --- examples/bpf/README

  1   2   3   4   >