Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Alexandre Belloni
Hi Russell, On 03/12/2020 22:52:33+, Russell King - ARM Linux admin wrote: > You still have not Cc'd me on your patches. Please can you either: > > 1) use get_maintainer.pl to find out whom you should be sending >your patches to > or > 2) include me in your cc for this patch set as phylin

QMI QMAP interface stuck after power-cycling module

2020-12-03 Thread Kristian Evensen
Hi all, I am using QMI together with QMAP when configuring and connecting my LTE/5G modules. This all works well, but I have noticed something strange when modules are disconnected from the host. Most disconnects goes fine and everything related to module is removed, but sometimes it happens that

Re: [PATCH net-next] tun: fix ubuf refcount incorrectly on error path

2020-12-03 Thread Jason Wang
On 2020/12/3 下午4:00, wangyunjian wrote: From: Yunjian Wang After setting callback for ubuf_info of skb, the callback (vhost_net_zerocopy_callback) will be called to decrease the refcount when freeing skb. But when an exception occurs afterwards, the error handling in vhost handle_tx() will tr

Re: [PATCH v1 bpf-next 06/11] bpf: Introduce two attach types for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-03 Thread Martin KaFai Lau
On Thu, Dec 03, 2020 at 11:16:08PM +0900, Kuniyuki Iwashima wrote: > From: Martin KaFai Lau > Date: Wed, 2 Dec 2020 20:24:02 -0800 > > On Wed, Dec 02, 2020 at 11:19:02AM -0800, Martin KaFai Lau wrote: > > > On Tue, Dec 01, 2020 at 06:04:50PM -0800, Andrii Nakryiko wrote: > > > > On Tue, Dec 1,

Re: [Patch net] lwt: disable BH too in run_lwt_bpf()

2020-12-03 Thread Cong Wang
On Thu, Dec 3, 2020 at 10:30 AM Alexei Starovoitov wrote: > > On Thu, Dec 3, 2020 at 10:28 AM Cong Wang wrote: > > > > On Thu, Dec 3, 2020 at 10:22 AM Alexei Starovoitov > > wrote: > > > > > > I guess my previous comment could be misinterpreted. > > > Cong, > > > please respin with changing pree

[PATCH net-next] bcm63xx_enet: add BQL support

2020-12-03 Thread Sieng Piaw Liew
Add Byte Queue Limits support to reduce/remove bufferbloat in bcm63xx_enet. Signed-off-by: Sieng Piaw Liew --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/b

[PATCH net-next] bcm63xx_enet: convert to build_skb

2020-12-03 Thread Sieng Piaw Liew
We can increase the efficiency of rx path by using buffers to receive packets then build SKBs around them just before passing into the network stack. In contrast, preallocating SKBs too early reduces CPU cache efficiency. Check if we're in NAPI context when refilling RX. Normally we're almost alwa

[PATCH net-next] bcm63xx_enet: alloc rx skb with NET_IP_ALIGN

2020-12-03 Thread Sieng Piaw Liew
Use netdev_alloc_skb_ip_align on newer SoCs with integrated switch (enetsw) when refilling RX. Increases packet processing performance by 30% (with netif_receive_skb_list). Non-enetsw SoCs cannot function with the extra pad so continue to use the regular netdev_alloc_skb. Tested on BCM6328 320 MH

[PATCH net-next] bcm63xx_enet: batch process rx path

2020-12-03 Thread Sieng Piaw Liew
Use netif_receive_skb_list to batch process rx skb. Tested on BCM6328 320 MHz using iperf3 -M 512, increasing performance by 12.5%. Before: [ ID] Interval Transfer Bandwidth Retr [ 4] 0.00-30.00 sec 120 MBytes 33.7 Mbits/sec 277 sender [ 4] 0.00-30.00 sec

Re: Long delay on estimation_timer causes packet latency

2020-12-03 Thread Julian Anastasov
Hello, On Fri, 4 Dec 2020, dust.li wrote: > > On 12/3/20 4:48 PM, Julian Anastasov wrote: > > > > - work will use spin_lock_bh(&s->lock) to protect the > > entries, we do not want delays between /proc readers and > > the work if using mutex. But _bh locks stop timers and > > networking

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Florian Fainelli
On 12/3/2020 5:33 PM, Andrew Lunn wrote: >> Of course, neither is fully correct. There is always more to improve on >> the communication side of things. > > I wonder if switchdev needs to gain an enumeration API? A way to ask > the underlying driver, what can you offload? The user can then get

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Florian Fainelli
On 12/2/2020 1:13 AM, Tobias Waldekranz wrote: > Monitor the following events and notify the driver when: > > - A DSA port joins/leaves a LAG. > - A LAG, made up of DSA ports, joins/leaves a bridge. > - A DSA port in a LAG is enabled/disabled (enabled meaning > "distributing" in 802.3ad LACP

Re: [PATCH v3 net-next 4/4] net: dsa: tag_dsa: Support reception of packets from LAG devices

2020-12-03 Thread Florian Fainelli
On 12/2/2020 1:13 AM, Tobias Waldekranz wrote: > Packets ingressing on a LAG that egress on the CPU port, which are not > classified as management, will have a FORWARD tag that does not > contain the normal source device/port tuple. Instead the trunk bit > will be set, and the port field holds t

[PATCH 1/1 v3 net-next] ptp: Add clock driver for the OpenCompute TimeCard.

2020-12-03 Thread Jonathan Lemon
The OpenCompute time card is an atomic clock along with a GPS receiver that provides a Grandmaster clock source for a PTP enabled network. More information is available at http://www.timingcard.com/ Signed-off-by: Jonathan Lemon --- drivers/ptp/Kconfig | 14 ++ drivers/ptp/Makefile | 1 +

[PATCH 0/1 v3 net-next] Add OpenCompute timecard driver

2020-12-03 Thread Jonathan Lemon
From: Jonathan Lemon v2->v3: remove dev_info() informational lines v1->v2: make the driver dependent on CONFIG_PCI, for the test robot. move the config option under PTP_1588_CLOCK hierarcy v1: initial submission Jonathan Lemon (1): ptp: Add clock driver for the OpenCompute TimeCard. driv

[PATCH v2 bpf-next] bpf: increment and use correct thread iterator

2020-12-03 Thread Jonathan Lemon
From: Jonathan Lemon If unable to obtain the file structure for the current task, proceed to the next task number after the one returned from task_seq_get_next(), instead of the next task number from the original iterator. Use thread_group_leader() instead of comparing tgid vs pid, which might m

Re: [PATCH] bpf, x64: bump the number of passes to 64

2020-12-03 Thread Gary Lin
On Thu, Dec 03, 2020 at 10:14:31AM -0800, Alexei Starovoitov wrote: > On Thu, Dec 03, 2020 at 12:20:38PM +0100, Eric Dumazet wrote: > > > > > > On 12/3/20 10:12 AM, Gary Lin wrote: > > > The x64 bpf jit expects bpf images converge within the given passes, but > > > it could fail to do so with som

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-03 Thread Dan Williams
On Thu, Dec 3, 2020 at 6:34 PM Jason Gunthorpe wrote: > > On Thu, Dec 03, 2020 at 04:06:24PM +0100, Greg KH wrote: > > > > ...for all the independent drivers to have a common commit baseline. It > > > is not there yet pending Greg's Ack. > > > > I have been trying to carve out some time to review

Re: Long delay on estimation_timer causes packet latency

2020-12-03 Thread dust.li
On 12/3/20 4:48 PM, Julian Anastasov wrote: Hello, On Thu, 3 Dec 2020, dust.li wrote: Hi Yunhong & Julian, any updates ? We've encountered the same problem. With lots of ipvs services plus many CPUs, it's easy to reproduce this issue. I have a simple script to reproduce: First a

[PATCH net-next 6/6] icmp: add response to RFC 8335 PROBE messages

2020-12-03 Thread Andreas Roeseler
Modify the icmp_rcv function to check for PROBE messages and call icmp_echo if a PROBE request is detected. Modify the existing icmp_echo function to respond to both ping and PROBE requests. This was tested using a custom modification of the iputils package and wireshark. It supports IPV4 probing

[PATCH net-next 5/6] net: add support for sending RFC 8335 PROBE messages

2020-12-03 Thread Andreas Roeseler
Modify the ping_supported function to support PROBE message types. This allows tools such as the ping command in the iputils package to be modified to send PROBE requests through the existing framework for sending ping requests. Signed-off-by: Andreas Roeseler --- net/ipv4/ping.c | 4 +++- 1 fil

[PATCH net-next 4/6] net: add sysctl for enabling RFC 8335 PROBE messages

2020-12-03 Thread Andreas Roeseler
Section 8 of RFC 8335 specifies potential security concerns of responding to PROBE requests, and states that nodes that support PROBE functionality MUST be able to enable/disable responses and it is disabled by default. Add sysctl to enable responses to PROBE messages. Signed-off-by: Andreas Ro

[PATCH net-next 3/6] net: add sysctl for enabling RFC 8335 PROBE messages

2020-12-03 Thread Andreas Roeseler
Section 8 of RFC 8335 specifies potential security concerns of responding to PROBE requests, and states that nodes that support PROBE functionality MUST be able to enable/disable responses and it is disabled by default. Add sysctl to enable responses to PROBE messages. Signed-off-by: Andreas Ro

[PATCH net-next 2/6] ICMPv6: support for RFC 8335

2020-12-03 Thread Andreas Roeseler
Add definitions for the ICMPV6 type of Extended Echo Request and Extended Echo Reply, as defined in sections 2 and 3 of RFC 8335. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmpv6.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/l

[PATCH net-next 0/6] add support for RFC 8335 PROBE

2020-12-03 Thread Andreas Roeseler
The popular utility ping has several severe limitations such as the inability to query specific interfaces on a node and requiring bidirectional connectivity between the probing and probed interfaces. RFC 8335 attempts to solve these limitations by creating the new utility PROBE which is a speciali

[PATCH net-next 1/6] icmp: support for RFC 8335

2020-12-03 Thread Andreas Roeseler
Add definitions for PROBE ICMP types and codes. Add a struct to represent the additional header when probing by IP address (ctype == 3) for use in parsing incoming PROBE messages. Signed-off-by: Andreas Roeseler --- include/uapi/linux/icmp.h | 22 ++ 1 file changed, 22 inse

Re: [PATCH net v3] bonding: fix feature flag setting at init time

2020-12-03 Thread Jarod Wilson
On Thu, Dec 3, 2020 at 11:50 AM Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 19:43:57 -0500 Jarod Wilson wrote: > > bond_dev->hw_features |= NETIF_F_GSO_ENCAP_ALL | NETIF_F_GSO_UDP_L4; > > -#ifdef CONFIG_XFRM_OFFLOAD > > - bond_dev->hw_features |= BOND_XFRM_FEATURES; > > -#endif /* CONF

[PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict

2020-12-03 Thread Stephen Suryaputra
Depending on the order of the routes to fe80::/64 are installed on the VRF table, the NS for the source link-local address of the originator might be sent to the wrong interface. This patch ensures that packets with link-local addr source is doing a lookup with the orig_iif when the destination ad

Re: [PATCH][next] rtw88: coex: fix missing unitialization of variable 'interval'

2020-12-03 Thread Pkshih
On Thu, 2020-12-03 at 17:51 +, Colin King wrote: > From: Colin Ian King > > Currently the variable 'interval' is not initialized and is only set > to 1 when oex_stat->bt_418_hid_existi is true.  Fix this by inintializing > variable interval to 0 (which I'm assuming is the intended default). >

[PATCH V2 5/5] net: stmmac: overwrite the dma_cap.addr64 according to HW design

2020-12-03 Thread Joakim Zhang
From: Fugang Duan The current IP register MAC_HW_Feature1[ADDR64] only defines 32/40/64 bit width, but some SOCs support others like i.MX8MP support 34 bits but it maps to 40 bits width in MAC_HW_Feature1[ADDR64]. So overwrite dma_cap.addr64 according to HW real design. Fixes: 94abdad6974a ("net

[PATCH V2 4/5] net: stmmac: delete the eee_ctrl_timer after napi disabled

2020-12-03 Thread Joakim Zhang
From: Fugang Duan There have chance to re-enable the eee_ctrl_timer and fire the timer in napi callback after delete the timer in .stmmac_release(), which introduces to access eee registers in the timer function after clocks are disabled then causes system hang. Found this issue when do suspend/r

[PATCH V2 2/5] net: stmmac: start phylink instance before stmmac_hw_setup()

2020-12-03 Thread Joakim Zhang
From: Fugang Duan Start phylink instance and resume back the PHY to supply RX clock to MAC before MAC layer initialization by calling .stmmac_hw_setup(), since DMA reset depends on the RX clock, otherwise DMA reset cost maximum timeout value then finally timeout. Fixes: 74371272f97f ("net: stmma

[PATCH V2 3/5] net: stmmac: free tx skb buffer in stmmac_resume()

2020-12-03 Thread Joakim Zhang
From: Fugang Duan When do suspend/resume test, there have WARN_ON() log dump from stmmac_xmit() funciton, the code logic: entry = tx_q->cur_tx; first_entry = entry; WARN_ON(tx_q->tx_skbuff[first_entry]); In normal case, tx_q->tx_skbuff[txq->cur_tx] should be NULL because

[PATCH V2 1/5] net: stmmac: increase the timeout for dma reset

2020-12-03 Thread Joakim Zhang
From: Fugang Duan Current timeout value is not enough for gmac5 dma reset on imx8mp platform, increase the timeout range. Signed-off-by: Fugang Duan Signed-off-by: Joakim Zhang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH V2 0/5] patches for stmmac

2020-12-03 Thread Joakim Zhang
A patch set for stmmac, fix some driver issues. ChangeLogs: V1->V2: * add Fixes tag. * add patch 5/5 into this patch set. Fugang Duan (5): net: stmmac: increase the timeout for dma reset net: stmmac: start phylink instance before stmmac_hw_setup() net: stmmac: free tx skb bu

[RESEND v15 0/4] userspace MHI client interface driver

2020-12-03 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These f

[RESEND v15 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

[RESEND v15 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-12-03 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

[RESEND v15 3/4] docs: Add documentation for userspace client interface

2020-12-03 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently QMI MHI channel is supported by this driver. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- Documentation/mhi/index.rst

[RESEND v15 1/4] bus: mhi: core: Add helper API to return number of free TREs

2020-12-03 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/c

Re: [PATCH v15 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Hemant Kumar
On 12/3/20 3:45 PM, Jeffrey Hugo wrote: On 12/3/2020 3:45 PM, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI

Re: [resend/standalone PATCH v4] Add auxiliary bus support

2020-12-03 Thread Jason Gunthorpe
On Thu, Dec 03, 2020 at 04:06:24PM +0100, Greg KH wrote: > > ...for all the independent drivers to have a common commit baseline. It > > is not there yet pending Greg's Ack. > > I have been trying to carve out some time to review this. At my initial > glance, I still have objections, so please,

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-03 Thread Jakub Kicinski
On Wed, 2 Dec 2020 20:21:01 -0800 Saeed Mahameed wrote: > Add TX PTP port object support for better TX timestamping accuracy. > Currently, driver supports CQE based TX port timestamp. Device > also offers TX port timestamp, which has less jitter and better > reflects the actual time of a packet's t

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Andrew Lunn
> +static int dsa_tree_setup_lags(struct dsa_switch_tree *dst) > +{ > + struct dsa_port *dp; > + unsigned int num; > + > + list_for_each_entry(dp, &dst->ports, list) > + num = dp->ds->num_lags; > + > + list_for_each_entry(dp, &dst->ports, list) > + num = min(

pull-request: bpf-next 2020-12-03

2020-12-03 Thread Alexei Starovoitov
Hi David, hi Jakub, The following pull-request contains BPF updates for your *net-next* tree. We've added 118 non-merge commits during the last 20 day(s) which contain a total of 196 files changed, 4330 insertions(+), 2569 deletions(-). The main changes are: 1) Support BTF in kernel modules, fr

Re: [PATCH bpf-next v4 6/6] bpf: Test bpf_sk_storage_get in tcp iterators

2020-12-03 Thread Martin KaFai Lau
On Wed, Dec 02, 2020 at 09:55:27PM +0100, Florent Revest wrote: > This extends the existing bpf_sk_storage_get test where a socket is > created and tagged with its creator's pid by a task_file iterator. > > A TCP iterator is now also used at the end of the test to negate the > values already store

Re: [PATCH v2 net-next] ptp: Add clock driver for the OpenCompute TimeCard.

2020-12-03 Thread Jonathan Lemon
On Thu, Dec 03, 2020 at 04:56:24PM -0800, Richard Cochran wrote: > On Thu, Dec 03, 2020 at 10:29:25AM -0800, Jonathan Lemon wrote: > > The OpenCompute time card is an atomic clock along with > > a GPS receiver that provides a Grandmaster clock source > > for a PTP enabled network. > > > > More inf

Re: [PATCH bpf-next] bpf: increment and use correct thread iterator

2020-12-03 Thread Alexei Starovoitov
On Thu, Dec 03, 2020 at 01:59:07PM -0800, Jonathan Lemon wrote: > From: Jonathan Lemon > > If unable to obtain the file structure for the current task, > proceed to the next task number after the one returned from > task_seq_get_next(), instead of the next task number from the > original iterator

Re: [PATCH v6 bpf-next 10/14] bpf: allow to specify kernel module BTFs when attaching BPF programs

2020-12-03 Thread Alexei Starovoitov
On Thu, Dec 03, 2020 at 12:46:30PM -0800, Andrii Nakryiko wrote: > + if (attr->attach_prog_fd) { > + dst_prog = bpf_prog_get(attr->attach_prog_fd); > + if (IS_ERR(dst_prog)) { > + dst_prog = NULL; > + attach_btf = btf_get_by_fd(att

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-03 Thread Andrew Lunn
> static const struct of_device_id gswip_of_match[] = { > { .compatible = "lantiq,xrx200-gswip", .data = &gswip_xrx200 }, > + { .compatible = "lantiq,xrx300-gswip", .data = &gswip_xrx300 }, > + { .compatible = "lantiq,xrx330-gswip", .data = &gswip_xrx300 }, > {}, Is there an I

Re: [PATCH] net/mlx5e: fix non-IPV6 build

2020-12-03 Thread Jakub Kicinski
On Fri, 04 Dec 2020 01:20:15 + patchwork-bot+netdev...@kernel.org wrote: > Hello: > > This patch was applied to netdev/net-next.git (refs/heads/master): > > On Fri, 4 Dec 2020 00:12:59 +0100 you wrote: > > From: Arnd Bergmann > > > > When IPv6 is disabled, the flow steering code causes a b

Re: [PATCH v4 bpf-next 0/2] Add support to set window_clamp from bpf setsockops

2020-12-03 Thread Alexei Starovoitov
On Wed, Dec 02, 2020 at 01:31:50PM -0800, Prankur gupta wrote: > This patch contains support to set tcp window_field field from bpf setsockops. > > v2: Used TCP_WINDOW_CLAMP setsockopt logic for bpf_setsockopt (review comment > addressed) > > v3: Created a common function for duplicated code (re

Re: [PATCH bpf 3/7] netdevsim: Add debugfs toggle to reject BPF programs in verifier

2020-12-03 Thread Jakub Kicinski
On Thu, 03 Dec 2020 22:35:20 +0100 Toke Høiland-Jørgensen wrote: > diff --git a/drivers/net/netdevsim/netdevsim.h > b/drivers/net/netdevsim/netdevsim.h > index 827fc80f50a0..d1d329af3e61 100644 > --- a/drivers/net/netdevsim/netdevsim.h > +++ b/drivers/net/netdevsim/netdevsim.h > @@ -190,6 +190,7 @

Re: [PATCH bpf 1/7] xdp: remove the xdp_attachment_flags_ok() callback

2020-12-03 Thread Jakub Kicinski
On Thu, 03 Dec 2020 22:35:18 +0100 Toke Høiland-Jørgensen wrote: > Since we offloaded and non-offloaded programs can co-exist there doesn't > really seem to be any reason for the check anyway, and it's only used in > three drivers so let's just get rid of the callback entirely. I don't remember ex

Re: [PATCH bpf-next v4 5/6] bpf: Add an iterator selftest for bpf_sk_storage_get

2020-12-03 Thread Martin KaFai Lau
On Wed, Dec 02, 2020 at 09:55:26PM +0100, Florent Revest wrote: > The eBPF program iterates over all files and tasks. For all socket > files, it stores the tgid of the last task it encountered with a handle > to that socket. This is a heuristic for finding the "owner" of a socket > similar to what'

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Andrew Lunn
> Of course, neither is fully correct. There is always more to improve on > the communication side of things. I wonder if switchdev needs to gain an enumeration API? A way to ask the underlying driver, what can you offload? The user can then get an idea what is likely to be offloaded, and what not

Re: [PATCH] net/mlx5e: fix non-IPV6 build

2020-12-03 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 4 Dec 2020 00:12:59 +0100 you wrote: > From: Arnd Bergmann > > When IPv6 is disabled, the flow steering code causes a build failure: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c:55:14: error: no

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Richard Cochran
On Fri, Dec 04, 2020 at 03:00:50AM +0200, Vladimir Oltean wrote: > On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote: > > Yes, that would make sense. It would bring sysfs back to feature > > parity with the ioctls. > > Which is a good thing? Yes, of course it is. I'm sorry I didn'

Re: [PATCH net-next 1/4] ptp: clockmatrix: reset device and check BOOT_STATUS

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 10:20:16 -0500 min.li...@renesas.com wrote: > From: Min Li > > SM_RESET device only when loading full configuration and check > for BOOT_STATUS. Also remove polling for write trigger done in > _idtcm_settime(). > > Signed-off-by: Min Li Please fix the checkpatch warnings: C

RE: [PATCH] net: stmmac: overwrite the dma_cap.addr64 according to HW design

2020-12-03 Thread Joakim Zhang
> -Original Message- > From: Jakub Kicinski > Sent: 2020年12月4日 2:42 > To: Joakim Zhang > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; da...@davemloft.net; dl-linux-imx > ; netdev@vger.kernel.org > Subject: Re: [PATCH] net: stmmac: overwrite the dma_cap.add

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Vladimir Oltean
On Thu, Dec 03, 2020 at 04:45:56PM -0800, Richard Cochran wrote: > On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote: > > Should ptp_sysfs be extended with a "pulse" attribute with calls > > enable() with only PTP_PEROUT_DUTY_CYCLE set? > > Yes, that would make sense. It would bring

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Vladimir Oltean
On Fri, Dec 04, 2020 at 12:12:32AM +0100, Tobias Waldekranz wrote: > You make a lot of good points. I think it might be better to force the > user to be explicit about their choice though. Imagine something like > this: > > - We add NETIF_F_SWITCHDEV_OFFLOAD, which is set on switchdev ports by >

Re: [PATCH v2 net-next] ptp: Add clock driver for the OpenCompute TimeCard.

2020-12-03 Thread Richard Cochran
On Thu, Dec 03, 2020 at 10:29:25AM -0800, Jonathan Lemon wrote: > The OpenCompute time card is an atomic clock along with > a GPS receiver that provides a Grandmaster clock source > for a PTP enabled network. > > More information is available at http://www.timingcard.com/ > > Signed-off-by: Jonat

Re: [EXT] Re: [PATCH v5 7/9] task_isolation: don't interrupt CPUs with tick_nohz_full_kick_cpu()

2020-12-03 Thread Alex Belits
On Wed, 2020-12-02 at 14:20 +, Mark Rutland wrote: > External Email > > --- > --- > On Mon, Nov 23, 2020 at 05:58:22PM +, Alex Belits wrote: > > From: Yuri Norov > > > > For nohz_full CPUs the desirable behavior is to recei

Re: [PATCH net-next v5 9/9] net: dsa: microchip: ksz9477: add periodic output support

2020-12-03 Thread Richard Cochran
On Thu, Dec 03, 2020 at 04:36:26PM +0100, Christian Eggers wrote: > Should ptp_sysfs be extended with a "pulse" attribute with calls > enable() with only PTP_PEROUT_DUTY_CYCLE set? Yes, that would make sense. It would bring sysfs back to feature parity with the ioctls. Thanks, Richard

Re: [EXT] Re: [PATCH v5 5/9] task_isolation: Add driver-specific hooks

2020-12-03 Thread Alex Belits
On Wed, 2020-12-02 at 14:18 +, Mark Rutland wrote: > External Email > > --- > --- > On Mon, Nov 23, 2020 at 05:57:42PM +, Alex Belits wrote: > > Some drivers don't call functions that call > > task_isolation_kernel_enter() in

Re: [EXT] Re: [PATCH v5 0/9] "Task_isolation" mode

2020-12-03 Thread Alex Belits
On Wed, 2020-12-02 at 14:02 +, Mark Rutland wrote: > On Tue, Nov 24, 2020 at 05:40:49PM +, Alex Belits wrote: > > > > > I am having problems applying the patchset to today's linux-next. > > > > > > Which kernel should I be using ? > > > > The patches are against Linus' tree, in particul

Re: [EXT] Re: [PATCH v5 6/9] task_isolation: arch/arm64: enable task isolation functionality

2020-12-03 Thread Alex Belits
On Wed, 2020-12-02 at 13:59 +, Mark Rutland wrote: > External Email > > --- > --- > Hi Alex, > > On Mon, Nov 23, 2020 at 05:58:06PM +, Alex Belits wrote: > > In do_notify_resume(), call > > task_isolation_before_pending_work

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Vladimir Oltean
On Thu, Dec 03, 2020 at 10:35:12PM +0100, Tobias Waldekranz wrote: > - If offloading is available, reject anything that can not be > offloaded. My guess is that _any_ hardware offloaded setup will almost > always yield a better solution for the user than a software fallback. For the case where

Re: [PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-03 Thread Hauke Mehrtens
Hi, This looks good. I haven't checked all the differences between the SoCs, but found some minor problems in the code for the port configuration. On 12/3/20 11:03 PM, Aleksander Jan Bajkowski wrote: From: Aleksander Jan Bajkowski This patch allows you to use all phs on GRX300 and GRX330.

[PATCH bpf-next 1/2] libbpf: use memcpy instead of strncpy to please GCC

2020-12-03 Thread Andrii Nakryiko
Some versions of GCC are really nit-picky about strncpy() use. Use memcpy(), as they are pretty much equivalent for the case of fixed length strings. Fixes: e459f49b4394 ("libbpf: Separate XDP program load with xsk socket creation") Signed-off-by: Andrii Nakryiko --- tools/lib/bpf/xsk.c | 2 +-

[PATCH bpf-next 2/2] selftests/bpf: fix invalid use of strncat in test_sockmap

2020-12-03 Thread Andrii Nakryiko
strncat()'s third argument is how many bytes will be added *in addition* to already existing bytes in destination. Plus extra zero byte will be added after that. So existing use in test_sockmap has many opportunities to overflow the string and cause memory corruptions. And in this case, GCC complai

Re: [PATCH v15 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Jeffrey Hugo
On 12/3/2020 3:45 PM, Hemant Kumar wrote: This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel obje

Re: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Nikolay Aleksandrov
On 04/12/2020 00:42, Huang, Joseph wrote: >> From: Huang, Joseph >> Sent: Thursday, December 3, 2020 4:53 PM >> To: Nikolay Aleksandrov ; Jakub Kicinski >> >> Cc: Roopa Prabhu ; David S. Miller >> ; bri...@lists.linux-foundation.org; >> netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linus L

Re: [PATCH net 1/1] net: ipa: pass the correct size when freeing DMA memory

2020-12-03 Thread Bjorn Andersson
On Thu 03 Dec 15:51 CST 2020, Alex Elder wrote: > When the coherent memory is freed in gsi_trans_pool_exit_dma(), we > are mistakenly passing the size of a single element in the pool > rather than the actual allocated size. Fix this bug. > > Fixes: 9dd441e4ed575 ("soc: qcom: ipa: GSI transaction

[PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann A number of ethernet drivers require crc32 functionality to be avaialable in the kernel, causing a link error otherwise: arm-linux-gnueabi-ld: drivers/net/ethernet/agere/et131x.o: in function `et1310_setup_device_for_multicast': et131x.c:(.text+0x5918): undefined reference t

Re: [PATCH] net/mlx5e: fix non-IPV6 build

2020-12-03 Thread Randy Dunlap
On 12/3/20 3:12 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > When IPv6 is disabled, the flow steering code causes a build failure: > > drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c:55:14: error: no > member named 'skc_v6_daddr' in 'struct sock_common'; did you mean 'skc_daddr'

[PATCH] net/mlx5e: fix non-IPV6 build

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When IPv6 is disabled, the flow steering code causes a build failure: drivers/net/ethernet/mellanox/mlx5/core/en_accel/fs_tcp.c:55:14: error: no member named 'skc_v6_daddr' in 'struct sock_common'; did you mean 'skc_daddr'? &sk->sk_v6_daddr, 16);

Re: [PATCH v3 net-next 2/4] net: dsa: Link aggregation support

2020-12-03 Thread Tobias Waldekranz
On Thu, Dec 03, 2020 at 23:57, Vladimir Oltean wrote: > On Thu, Dec 03, 2020 at 09:53:08PM +0100, Tobias Waldekranz wrote: >> I am not sure which way is the correct one, but I do not think that it >> necessarily _always_ correct to silently fallback to a non-offloaded >> mode. > > Of course, neith

RE: [net-next v2 1/8] net-zerocopy: Copy straggler unaligned data for TCP Rx. zerocopy.

2020-12-03 Thread David Laight
From: Stephen Hemminger > Sent: 03 December 2020 00:15 > > On Wed, 2 Dec 2020 14:09:38 -0800 > Arjun Roy wrote: > > > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > > index cfcb10b75483..62db78b9c1a0 100644 > > --- a/include/uapi/linux/tcp.h > > +++ b/include/uapi/linux/tcp.

Re: [PATCH v8 3/4] phy: Add Sparx5 ethernet serdes PHY driver

2020-12-03 Thread Russell King - ARM Linux admin
On Thu, Dec 03, 2020 at 10:52:53PM +0100, Andrew Lunn wrote: > > +/* map from SD25G28 interface width to configuration value */ > > +static u8 sd25g28_get_iw_setting(const u8 interface_width) > > +{ > > + switch (interface_width) { > > + case 10: return 0; > > + case 16: return 1; > > + cas

[PATCH v2 net-next] nfc: s3fwrn5: skip the NFC bootloader mode

2020-12-03 Thread Bongsu Jeon
From: Bongsu Jeon If there isn't a proper NFC firmware image, Bootloader mode will be skipped. Signed-off-by: Bongsu Jeon --- ChangeLog: v2: - change the commit message. - change the skip handling code. drivers/nfc/s3fwrn5/core.c | 23 +-- drivers/nfc/s3fwrn5

[PATCH v15 1/4] bus: mhi: core: Add helper API to return number of free TREs

2020-12-03 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi/c

[PATCH v15 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-12-03 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam --- drivers/bus/mhi

[PATCH v15 3/4] docs: Add documentation for userspace client interface

2020-12-03 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently QMI MHI channel is supported by this driver. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo --- Documentation/mhi/index.rst

[PATCH v15 4/4] bus: mhi: Add userspace client interface driver

2020-12-03 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI chan

[PATCH v15 0/4] userspace MHI client interface driver

2020-12-03 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These f

Re: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Huang, Joseph
> From: Huang, Joseph > Sent: Thursday, December 3, 2020 4:53 PM > To: Nikolay Aleksandrov ; Jakub Kicinski > > Cc: Roopa Prabhu ; David S. Miller > ; bri...@lists.linux-foundation.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linus Lüssing > > Subject: RE: [PATCH] bridge: Fix a de

Re: [PATCH iproute2-next] Only compile mnl_utils when HAVE_LIBMNL is defined

2020-12-03 Thread David Ahern
On 12/3/20 2:45 PM, Petr Machata wrote: > > David Ahern writes: > >> diff --git a/lib/Makefile b/lib/Makefile >> index e37585c6..603ea83e 100644 >> --- a/lib/Makefile >> +++ b/lib/Makefile >> @@ -13,7 +13,10 @@ UTILOBJ += bpf_libbpf.o >> endif >> endif >> >> -NLOBJ=libgenl.o libnetlink.o mnl

[PATCH] enetc: fix build warning

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, there is a harmless warning about an unused variable: enetc_pf.c: In function 'enetc_phylink_create': enetc_pf.c:981:17: error: unused variable 'dev' [-Werror=unused-variable] Slightly rearrange the code to pass around the of_node as a function ar

Re: [GIT PULL] Networking for 5.10-rc7

2020-12-03 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Thu, 3 Dec 2020 12:44:59 -0800 you wrote: > The following changes since commit c84e1efae022071a4fcf9f1899bf71777c49943a: > > Merge tag 'asm-generic-fixes-5.10-2' of > git://git.kernel.org/pub/scm/linux/kernel/git/

[PATCH] ch_ktls: fix build warning for ipv4-only config

2020-12-03 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_IPV6 is disabled, clang complains that a variable is uninitialized for non-IPv4 data: drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:1046:6: error: variable 'cntrl1' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-unin

Re: [PATCH net-next 1/3] security: add const qualifier to struct sock in various places

2020-12-03 Thread Jakub Kicinski
On Fri, 4 Dec 2020 04:07:16 +1100 (AEDT) James Morris wrote: > On Wed, 2 Dec 2020, Jakub Kicinski wrote: > > On Mon, 30 Nov 2020 16:36:29 +0100 Florian Westphal wrote: > > > A followup change to tcp_request_sock_op would have to drop the 'const' > > > qualifier from the 'route_req' function as th

RE: [PATCH] bridge: Fix a deadlock when enabling multicast snooping

2020-12-03 Thread Huang, Joseph
> From: Nikolay Aleksandrov > Sent: Thursday, December 3, 2020 3:47 PM > To: Jakub Kicinski ; Huang, Joseph > > Cc: Roopa Prabhu ; David S. Miller > ; bri...@lists.linux-foundation.org; > netdev@vger.kernel.org; linux-ker...@vger.kernel.org; Linus Lüssing > > Subject: Re: [PATCH] bridge: Fix a d

Re: [GIT PULL] Networking for 5.10-rc7

2020-12-03 Thread Jakub Kicinski
On Thu, 3 Dec 2020 13:18:13 -0800 Linus Torvalds wrote: > On Thu, Dec 3, 2020 at 12:45 PM Jakub Kicinski wrote: > > Networking fixes for 5.10-rc7, including fixes from bpf, netfilter, > > wireless drivers, wireless mesh and can. > > Thanks, pulled. > > And btw - maybe I've already talked about

Re: net: macb: fail when there's no PHY

2020-12-03 Thread Grant Edwards
On 2020-12-03, Andrew Lunn wrote: >> I don't think there's any way I could justify using a kernel that >> doesn't have long-term support. > > 5.10 is LTS. Well, it will be, once it is actually released! Convincing people to ship an unreleased kernel would be a whole 'nother bucket of worms. It's

[PATCH 2/2] dt-bindings: net: dsa: lantiq, lantiq-gswip: add example for xRX330

2020-12-03 Thread Aleksander Jan Bajkowski
From: Aleksander Jan Bajkowski Add compatible string and example for xRX300 and xRX330. Signed-off-by: Aleksander Jan Bajkowski --- .../bindings/net/dsa/lantiq-gswip.txt | 110 +- 1 file changed, 109 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bi

[PATCH 1/2] net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330

2020-12-03 Thread Aleksander Jan Bajkowski
From: Aleksander Jan Bajkowski This patch allows you to use all phs on GRX300 and GRX330. The ARX300 has 3 and the GRX330 has 4 integrated PHYs connected to different ports compared to VRX200. Port configurations: xRX200: GMAC0: RGMII port GMAC1: RGMII port GMAC2: GPHY0 (GMII) GMAC3: GPHY0 (MII

Re: [PATCH v7 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-12-03 Thread Marcel Holtmann
Hi Daniel, > This patch series defines the new two-call MGMT interface for adding > new advertising instances. Similarly to the hci advertising commands, a > mgmt call to set parameters is expected to be first, followed by a mgmt > call to set advertising data/scan response. The members of the > p

[PATCH bpf-next] bpf: increment and use correct thread iterator

2020-12-03 Thread Jonathan Lemon
From: Jonathan Lemon If unable to obtain the file structure for the current task, proceed to the next task number after the one returned from task_seq_get_next(), instead of the next task number from the original iterator. Use thread_group_leader() instead of comparing tgid vs pid, which might m

  1   2   3   4   >