Re: [PATCH 2/7] net: batman-adv: remove unneeded MODULE_VERSION() usage

2020-12-04 Thread Sven Eckelmann
On Wednesday, 2 December 2020 13:49:54 CET Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. Is there some explanation besides an opinion? Some kind goal which you want to achieve with it maybe? A

Re: [PATCH net] net/tls: Fix kernel panic when socket is in tls toe mode

2020-12-04 Thread kernel test robot
/davem/net.git bbe2ba04c5a92a49db8a42c850a5a2f6481e47eb config: x86_64-randconfig-a014-20201204 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project fc7818f5d6906555cebad2c2e7c313a383b9cb82) reproduce (this is a W=1 build): wget https

Re: [PATCH net-next 3/6] net: add sysctl for enabling RFC 8335 PROBE messages

2020-12-04 Thread David Ahern
On 12/3/20 8:16 PM, Andreas Roeseler wrote: > Section 8 of RFC 8335 specifies potential security concerns of > responding to PROBE requests, and states that nodes that support PROBE > functionality MUST be able to enable/disable responses and it is > disabled by default. > > Add sysctl to enable

Re: [PATCH net-next 6/6] icmp: add response to RFC 8335 PROBE messages

2020-12-04 Thread David Ahern
On 12/3/20 8:17 PM, Andreas Roeseler wrote: > diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c > index 005faea415a4..313061b60387 100644 > --- a/net/ipv4/icmp.c > +++ b/net/ipv4/icmp.c > @@ -984,20 +984,121 @@ static bool icmp_redirect(struct sk_buff *skb) > static bool icmp_echo(struct sk_buff *skb

Re: [net 3/3] can: isotp: add SF_BROADCAST support for functional addressing

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 14:35:08 +0100 Marc Kleine-Budde wrote: > From: Oliver Hartkopp > > When CAN_ISOTP_SF_BROADCAST is set in the CAN_ISOTP_OPTS flags the CAN_ISOTP > socket is switched into functional addressing mode, where only single frame > (SF) protocol data units can be send on the specifie

Re: [PATCH v8 3/3] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 22:47:09 +0100 Łukasz Stelmach wrote: > ASIX AX88796[1] is a versatile ethernet adapter chip, that can be > connected to a CPU with a 8/16-bit bus or with an SPI. This driver > supports SPI connection. > > The driver has been ported from the vendor kernel for ARTIK5[2] > boards

Re: [PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to non-kernel BTF

2020-12-04 Thread Alexei Starovoitov
On Fri, Dec 4, 2020 at 7:11 PM Andrii Nakryiko wrote: > + return -EOPNOTSUPP; $ cd kernel/bpf $ git grep ENOTSUPP|wc -l 46 $ git grep EOPNOTSUPP|wc -l 11

[PATCH bpf-next] bpf: return -EOPNOTSUPP when attaching to non-kernel BTF

2020-12-04 Thread Andrii Nakryiko
Return -EOPNOTSUPP if tracing BPF program is attempted to be attached with specified attach_btf_obj_fd pointing to non-kernel (neither vmlinux nor module) BTF object. This scenario might be supported in the future and isn't outright invalid, so -EINVAL isn't the most appropriate error code. Sugges

Re: net: macb: fail when there's no PHY

2020-12-04 Thread Florian Fainelli
On 12/4/2020 6:52 PM, Grant Edwards wrote: > On 2020-12-04, Florian Fainelli wrote: >> On 12/2/2020 7:54 PM, Grant Edwards wrote: >>> On 2020-12-03, Florian Fainelli wrote: >>> You would have to have a local hack that intercepts the macb_ioctl() and instead of calling phylink_mii_ioc

Re: net: macb: fail when there's no PHY

2020-12-04 Thread Grant Edwards
On 2020-12-04, Florian Fainelli wrote: > On 12/2/2020 7:54 PM, Grant Edwards wrote: >> On 2020-12-03, Florian Fainelli wrote: >> >>> You would have to have a local hack that intercepts the macb_ioctl() >>> and instead of calling phylink_mii_ioctl() it would have to >>> implement a custom ioctl()

[PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-04 Thread Andrii Nakryiko
When Clang emits ldimm64 instruction for BPF_TYPE_ID_TARGET CO-RE relocation, put module BTF FD, containing target type, into upper 32 bits of imm64. Because this FD is internal to libbpf, it's very cumbersome to test this in selftests. Manual testing was performed with debug log messages sprinkle

Re: WARNING in ieee80211_ibss_csa_beacon

2020-12-04 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:e87297fa Merge tag 'drm-fixes-2020-12-04' of git://anongit.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1412f61750 kernel config: https://syzkaller.appspot.com/x/.config?x=e49433c

Re: [PATCH net-next 2/3] net: hns3: add priv flags support to switch limit promisc mode

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 20:18:55 +0800 Huazhong Tan wrote: > @@ -224,6 +224,7 @@ static int hclge_map_unmap_ring_to_vf_vector(struct > hclge_vport *vport, bool en, > static int hclge_set_vf_promisc_mode(struct hclge_vport *vport, >struct hclge_mbx_vf_to_pf_cmd *req)

[PATCH net-next v3 1/1] ibmvnic: add some debugs

2020-12-04 Thread Sukadev Bhattiprolu
We sometimes run into situations where a soft/hard reset of the adapter takes a long time or fails to complete. Having additional messages that include important adapter state info will hopefully help understand what is happening, reduce the guess work and minimize requests to reproduce problems wi

Re: [PATCH net-next 3/3] net: hns3: refine the VLAN tag handle for port based VLAN

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 20:18:56 +0800 Huazhong Tan wrote: > tranmist Please spell check the commit messages and comments.

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Jakub Kicinski
On Sat, 5 Dec 2020 03:49:27 +0200 Vladimir Oltean wrote: > So there you go, it just says "the reference plane marking the boundary > between the PTP node and the network". So it depends on how you draw the > borders. I cannot seem to find any more precise definition. Ah, you made me go search :)

Re: [Patch net] lwt: disable BH too in run_lwt_bpf()

2020-12-04 Thread Alexei Starovoitov
On Thu, Dec 3, 2020 at 9:55 PM Cong Wang wrote: > > On Thu, Dec 3, 2020 at 10:30 AM Alexei Starovoitov > wrote: > > > > On Thu, Dec 3, 2020 at 10:28 AM Cong Wang wrote: > > > > > > On Thu, Dec 3, 2020 at 10:22 AM Alexei Starovoitov > > > wrote: > > > > > > > > I guess my previous comment could

Re: [PATCH] ch_ktls: fix build warning for ipv4-only config

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 23:26:16 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_IPV6 is disabled, clang complains that a variable > is uninitialized for non-IPv4 data: > > drivers/net/ethernet/chelsio/inline_crypto/ch_ktls/chcr_ktls.c:1046:6: error: > variable 'cntrl1' is used uni

Re: [PATCH v1 bpf-next 11/11] bpf: Test BPF_SK_REUSEPORT_SELECT_OR_MIGRATE.

2020-12-04 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:18PM +0900, Kuniyuki Iwashima wrote: > This patch adds a test for BPF_SK_REUSEPORT_SELECT_OR_MIGRATE. > > Reviewed-by: Benjamin Herrenschmidt > Signed-off-by: Kuniyuki Iwashima > --- > .../bpf/prog_tests/migrate_reuseport.c| 164 ++ > .../bp

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Vladimir Oltean
On Fri, Dec 04, 2020 at 12:26:13PM -0800, Jakub Kicinski wrote: > On Fri, 04 Dec 2020 11:33:26 -0800 Saeed Mahameed wrote: > > On Thu, 2020-12-03 at 18:29 -0800, Jakub Kicinski wrote: > > > On Wed, 2 Dec 2020 20:21:01 -0800 Saeed Mahameed wrote: > > > > Add TX PTP port object support for better TX

Re: [PATCH net-next v4] net/nfc/nci: Support NCI 2.x initial sequence

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 07:31:47 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > implement the NCI 2.x initial sequence to support NCI 2.x NFCC. > Since NCI 2.0, CORE_RESET and CORE_INIT sequence have been changed. > If NFCEE supports NCI 2.x, then NCI 2.x initial sequence will work. > > In NCI 1.0

Re: [PATCH net-next] selftests: forwarding: Add MPLS L2VPN test

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 15:35:43 +0100 Guillaume Nault wrote: > Connect hosts H1 and H2 using two intermediate encapsulation routers > (LER1 and LER2). These routers encapsulate traffic from the hosts, > including the original Ethernet header, into MPLS. > > Use ping to test reachability between H1 and

Re: [PATCH v1 bpf-next 03/11] tcp: Migrate TCP_ESTABLISHED/TCP_SYN_RECV sockets in accept queues.

2020-12-04 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:10PM +0900, Kuniyuki Iwashima wrote: [ ... ] > diff --git a/net/core/sock_reuseport.c b/net/core/sock_reuseport.c > index fd133516ac0e..60d7c1f28809 100644 > --- a/net/core/sock_reuseport.c > +++ b/net/core/sock_reuseport.c > @@ -216,9 +216,11 @@ int reuseport_add_sock

Re: [PATCH v2] net: bna: remove trailing semicolon in macro definition

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 08:36:22 -0800 t...@redhat.com wrote: > From: Tom Rix > > The macro use will already have a semicolon. > Clean up escaped newlines. > > Signed-off-by: Tom Rix Applied, thanks!

Re: [net-next] tipc: support 128bit node identity for peer removing

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 10:50:45 +0700 Hoang Huu Le wrote: > From: Hoang Le > > We add the support to remove a specific node down with 128bit > node identifier, as an alternative to legacy 32-bit node address. > > example: > $tipc peer remove identiy <1001002|1677> > > Acked-by: Jon Maloy > Si

Re: [PATCH net] mac80211: mesh: fix mesh_pathtbl_init() error path

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 17:29:39 +0100 Johannes Berg wrote: > On Fri, 2020-12-04 at 08:24 -0800, Eric Dumazet wrote: > > From: Eric Dumazet > > > > If tbl_mpp can not be allocated, we call mesh_table_free(tbl_path) > > while tbl_path rhashtable has not yet been initialized, which causes > > panics. >

Re: [PATCH v1 bpf-next 01/11] tcp: Keep TCP_CLOSE sockets in the reuseport group.

2020-12-04 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:08PM +0900, Kuniyuki Iwashima wrote: > This patch is a preparation patch to migrate incoming connections in the > later commits and adds a field (num_closed_socks) to the struct > sock_reuseport to keep TCP_CLOSE sockets in the reuseport group. > > When we close a lis

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Vladimir Oltean
Hi Jakub, On Fri, Dec 04, 2020 at 02:52:40PM -0800, Jakub Kicinski wrote: > On Fri, 04 Dec 2020 13:57:49 -0800 Saeed Mahameed wrote: > > > Why not use the PTP classification helpers we already have? > > > > do you mean ptp_parse_header() or the ebpf prog ? > > We use skb_flow_dissect() which shoul

[PATCH v3 net-next] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Vladimir Oltean
Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has a very nice ocelot_mact_wait_for_completion at the end. Introduced in commit 639c1b2625af ("net: mscc: ocelot: Register poll timeout should be wall time not attempts"), this function uses readx_poll_timeout which triggers a lo

Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 19:23:11 + Vladimir Oltean wrote: > > > > What's the expected poll time? maybe it's not that bad to busy wait? > > > > Clearly nobody noticed the issue in 2 years (you mention lockdep so > > > > not a "real" deadlock) which makes me think the wait can't be that > > > > long?

Re: [PATCH bpf-next v9 00/34] bpf: switch to memcg-based memory accounting

2020-12-04 Thread Daniel Borkmann
On 12/3/20 4:26 AM, Roman Gushchin wrote: On Wed, Dec 02, 2020 at 06:54:46PM -0800, Alexei Starovoitov wrote: On Tue, Dec 1, 2020 at 1:59 PM Roman Gushchin wrote: 5) Cryptic -EPERM is returned on exceeding the limit. Libbpf even had a function to "explain" this case for users. ... v9:

Re: [PATCH net] net: openvswitch: fix TTL decrement exception action execution

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 07:16:23 -0500 Eelco Chaudron wrote: > Currently, the exception actions are not processed correctly as the wrong > dataset is passed. This change fixes this, including the misleading > comment. > > In addition, a check was added to make sure we work on an IPv4 packet, > and not

Re: [pull request][for-next] mlx5-next auxbus support

2020-12-04 Thread Jason Gunthorpe
On Fri, Dec 04, 2020 at 10:29:52AM -0800, Saeed Mahameed wrote: > Hi Jakub, Jason > > This pull request is targeting net-next and rdma-next branches. > > This series provides mlx5 support for auxiliary bus devices. > > It starts with a merge commit of tag 'auxbus-5.11-rc1' from > gregkh/driver-c

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 15:57:36 -0800 Saeed Mahameed wrote: > On Fri, 2020-12-04 at 15:17 -0800, Jakub Kicinski wrote: > > On Fri, 04 Dec 2020 13:57:49 -0800 Saeed Mahameed wrote: > > > > > option 2) route PTP traffic to a special SQs per ring, this SQ > > > > > will > > > > > be > > > > > PTP port

Re: [PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict

2020-12-04 Thread Stephen Suryaputra
On Fri, Dec 04, 2020 at 03:37:48PM -0800, Jakub Kicinski wrote: > On Fri, 4 Dec 2020 09:32:04 -0700 David Ahern wrote: > > On 12/3/20 8:06 PM, Stephen Suryaputra wrote: > > > Depending on the order of the routes to fe80::/64 are installed on the > > > VRF table, the NS for the source link-local add

Re: [PATCH 1/7] net: 8021q: remove unneeded MODULE_VERSION() usage

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult Thanks for the patches. Please drop the "metux IT consult" f

Re: [PATCH] nfp: Replace zero-length array with flexible-array member

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 13:56:01 +0100 Simon Horman wrote: > There is a regular need in the kernel to provide a way to declare having a > dynamically sized set of trailing elements in a structure. Kernel code > should always use "flexible array members"[1] for these cases. The older > style of one-elem

[PATCH v3] bridge: Fix a deadlock when enabling multicast snooping

2020-12-04 Thread Joseph Huang
When enabling multicast snooping, bridge module deadlocks on multicast_lock if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 network. The deadlock was caused by the following sequence: While holding the lock, br_multicast_open calls br_multicast_join_snoopers, which eventu

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Saeed Mahameed
On Fri, 2020-12-04 at 15:17 -0800, Jakub Kicinski wrote: > On Fri, 04 Dec 2020 13:57:49 -0800 Saeed Mahameed wrote: > > > > option 2) route PTP traffic to a special SQs per ring, this SQ > > > > will > > > > be > > > > PTP port accurate, Normal traffic will continue through regular > > > > SQs > >

Re: [PATCH net] openvswitch: fix error return code in validate_and_copy_dec_ttl()

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 13:07:48 +0100 Eelco Chaudron wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Changing 'return start' to 'return action_start' can fix this bug. > > > > Fixes: 69929d4c49e1 ("net: openvswit

Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports

2020-12-04 Thread Andrew Lunn
On Fri, Dec 04, 2020 at 03:24:56PM -0800, Jakub Kicinski wrote: > On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > > > The ksz8795 has five physical ports, but the driver assumes > > it has only four. This prevents the driver from working correctly. > >

Re: [PATCH net] net: bridge: vlan: fix error return code in __vlan_add()

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 12:47:07 +0200 Nikolay Aleksandrov wrote: > On 04/12/2020 10:48, Zhang Changzhong wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: f8ed289fab84 ("bridge: vlan: use br_vlan_(get|put)_m

Re: [PATCH net] ipv4: fix error return code in rtm_to_fib_config()

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 09:04:08 -0700 David Ahern wrote: > On 12/4/20 1:48 AM, Zhang Changzhong wrote: > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: d15662682db2 ("ipv4: Allow ipv6 gateway with ipv4 routes") >

Re: [PATCH net] vrf: packets with lladdr src needs dst at input with orig_iif when needs strict

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 09:32:04 -0700 David Ahern wrote: > On 12/3/20 8:06 PM, Stephen Suryaputra wrote: > > Depending on the order of the routes to fe80::/64 are installed on the > > VRF table, the NS for the source link-local address of the originator > > might be sent to the wrong interface. > > >

Re: [PATCH v2 net-next] nfc: s3fwrn5: skip the NFC bootloader mode

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 10:37:53 +0200 Krzysztof Kozlowski wrote: > On Fri, Dec 04, 2020 at 07:52:57AM +0900, Bongsu Jeon wrote: > > From: Bongsu Jeon > > > > If there isn't a proper NFC firmware image, Bootloader mode will be > > skipped. > > > > Signed-off-by: Bongsu Jeon > > --- > > > > ChangeL

Re: [PATCH net v1] net: dsa: ksz8795: use correct number of physical ports

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 16:46:45 -0500 Sven Van Asbroeck wrote: > From: Sven Van Asbroeck > > The ksz8795 has five physical ports, but the driver assumes > it has only four. This prevents the driver from working correctly. > > Fix by indicating the correct number of physical ports. > > Fixes: e66f8

[PATCH bpf] tools/bpftool: fix PID fetching with a lot of results

2020-12-04 Thread Andrii Nakryiko
In case of having so many PID results that they don't fit into a singe page (4096) bytes, bpftool will erroneously conclude that it got corrupted data due to 4096 not being a multiple of struct pid_iter_entry, so the last entry will be partially truncated. Fix this by sizing the buffer to fit exact

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 13:57:49 -0800 Saeed Mahameed wrote: > > > option 2) route PTP traffic to a special SQs per ring, this SQ will > > > be > > > PTP port accurate, Normal traffic will continue through regular SQs > > > > > > Pros: Regular non PTP traffic not affected. > > > Cons: High memory foot

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 13:57:49 -0800 Saeed Mahameed wrote: > > Why not use the PTP classification helpers we already have? > > do you mean ptp_parse_header() or the ebpf prog ? > We use skb_flow_dissect() which should be simple enough. Not sure which exact one TBH, I just know we have helpers for

Re: [PATCH] ethernet: select CONFIG_CRC32 as needed

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 00:20:37 +0100 Arnd Bergmann wrote: > From: Arnd Bergmann > > A number of ethernet drivers require crc32 functionality to be > avaialable in the kernel, causing a link error otherwise: > Add the missing 'select CRC32' entries in Kconfig for each of them. > > Signed-off-by: A

Re: [PATCH net 1/1] net: ipa: pass the correct size when freeing DMA memory

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 17:28:16 -0600 Bjorn Andersson wrote: > > When the coherent memory is freed in gsi_trans_pool_exit_dma(), we > > are mistakenly passing the size of a single element in the pool > > rather than the actual allocated size. Fix this bug. > > > > Fixes: 9dd441e4ed575 ("soc: qcom: ip

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Alexander Duyck
On Fri, Dec 4, 2020 at 2:28 PM Limonciello, Mario wrote: > > > -Original Message- > > From: Alexander Duyck > > Sent: Friday, December 4, 2020 15:27 > > To: Limonciello, Mario > > Cc: Jeff Kirsher; Tony Nguyen; intel-wired-lan; LKML; Linux PM; Netdev; > > Jakub > > Kicinski; Sasha Netfin

Re: [net-next v3 0/8] Perf. optimizations for TCP Recv. Zerocopy

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 14:53:41 -0800 Arjun Roy wrote: > Summarized: > 1. It is possible that a read payload is not exactly page aligned - > that there may exist "straggler" bytes that we cannot map into the > caller's address space cleanly. For this, we allow the caller to > provide as argument a "hy

Re: [PATCH v2] bridge: Fix a deadlock when enabling multicast snooping

2020-12-04 Thread Huang, Joseph
> > + if (join_snoopers) > > + br_multicast_join_snoopers(br); > > + else if (leave_snoopers) > > + br_multicast_leave_snoopers(br); > > If I'm not missing anything this can be just 1 bool like "change_snoopers" or > something which if set to true will check BROPT_M

RE: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Limonciello, Mario
> -Original Message- > From: Alexander Duyck > Sent: Friday, December 4, 2020 15:27 > To: Limonciello, Mario > Cc: Jeff Kirsher; Tony Nguyen; intel-wired-lan; LKML; Linux PM; Netdev; Jakub > Kicinski; Sasha Netfin; Aaron Brown; Stefan Assmann; David Miller; David > Arcari; Shen, Yijun; Yua

Re: [PATCH v2 bpf 1/5] net: ethtool: add xdp properties flag set

2020-12-04 Thread Daniel Borkmann
On 12/4/20 6:20 PM, Toke Høiland-Jørgensen wrote: Daniel Borkmann writes: [...] We tried to standardize on a minimum guaranteed amount, but unfortunately not everyone seems to implement it, but I think it would be very useful to query this from application side, for example, consider that an a

Re: [PATCH net] net/sched: fq_pie: initialize timer earlier in fq_pie_init()

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 10:35:07 -0800 Cong Wang wrote: > On Thu, Dec 3, 2020 at 10:41 AM Davide Caratti wrote: > > > > with the following tdc testcase: > > > > 83be: (qdisc, fq_pie) Create FQ-PIE with invalid number of flows > > > > as fq_pie_init() fails, fq_pie_destroy() is called to clean up. Sinc

Re: [PATCH v4 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-04 Thread Andrew Lunn
> > +struct ar9331_sw_stats { > > + u64 rxbroad; > > + u64 rxpause; > > + u64 rxmulti; > > +}; 7> > +struct ar9331_sw_port { > > + int idx; > > + struct ar9331_sw_priv *priv; > > + struct delayed_work mib_read; > > + struct ar9331_sw_stats stats; > > +st

Re: [PATCH v2] bridge: Fix a deadlock when enabling multicast snooping

2020-12-04 Thread Nikolay Aleksandrov
On 04/12/2020 23:39, Joseph Huang wrote: > When enabling multicast snooping, bridge module deadlocks on multicast_lock > if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 > network. > > The deadlock was caused by the following sequence: While holding the lock, > br_multicas

Re: [PATCH v4 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-04 Thread George McCollister
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote: > > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 247 ++- > 1 file changed, 246 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/

Re: [PATCH bpf-next v5 1/6] net: Remove the err argument from sock_from_file

2020-12-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 4 Dec 2020 12:36:04 +0100 you wrote: > Currently, the sock_from_file prototype takes an "err" pointer that is > either not set or set to -ENOTSOCK IFF the returned socket is NULL. This > makes the error redundant and

Re: [PATCH] net: rmnet: Adjust virtual device MTU on real device capability

2020-12-04 Thread subashab
On 2020-12-03 10:40, Loic Poulain wrote: A submitted qmap/rmnet packet size can not be larger than the linked interface (real_dev) MTU. This patch ensures that the rmnet virtual iface MTU is configured according real device capability. Signed-off-by: Loic Poulain --- drivers/net/ethernet/qualc

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Saeed Mahameed
On Fri, 2020-12-04 at 12:26 -0800, Jakub Kicinski wrote: > On Fri, 04 Dec 2020 11:33:26 -0800 Saeed Mahameed wrote: > > On Thu, 2020-12-03 at 18:29 -0800, Jakub Kicinski wrote: > > > On Wed, 2 Dec 2020 20:21:01 -0800 Saeed Mahameed wrote: > > > > Add TX PTP port object support for better TX times

[PATCH] net: wireless: validate key indexes for cfg80211_registered_device

2020-12-04 Thread Anant Thazhemadam
syzbot discovered a bug in which an OOB access was being made because an unsuitable key_idx value was wrongly considered to be acceptable while deleting a key in nl80211_del_key(). Since we don't know the cipher at the time of deletion, if cfg80211_validate_key_settings() were to be called directl

Re: [PATCH v4 net-next 1/2] net: dsa: add optional stats64 support

2020-12-04 Thread Florian Fainelli
On 12/4/2020 6:56 AM, Oleksij Rempel wrote: > Allow DSA drivers to export stats64 > > Signed-off-by: Oleksij Rempel > Reviewed-by: Vladimir Oltean Andrew and myself ave you R-b-y for this change already can you carry it forward? -- Florian

Re: [net-next v4 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-12-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 2 Dec 2020 14:05:09 +0100 you wrote: > This patchset provides support for the SRv6 End.DT4 and End.DT6 (VRF mode) > behaviors. > > The SRv6 End.DT4 behavior is used to implement multi-tenant IPv4 L3 VPNs. It > de

Re: [net-next v4 0/8] seg6: add support for SRv6 End.DT4/DT6 behavior

2020-12-04 Thread Jakub Kicinski
On Wed, 2 Dec 2020 14:05:09 +0100 Andrea Mayer wrote: > This patchset provides support for the SRv6 End.DT4 and End.DT6 (VRF mode) > behaviors. > > The SRv6 End.DT4 behavior is used to implement multi-tenant IPv4 L3 VPNs. It > decapsulates the received packets and performs IPv4 routing lookup in

Re: [PATCH v4 net-next 2/2] net: dsa: qca: ar9331: export stats64

2020-12-04 Thread George McCollister
On Fri, Dec 4, 2020 at 8:59 AM Oleksij Rempel wrote: > > Add stats support for the ar9331 switch. > > Signed-off-by: Oleksij Rempel > --- > drivers/net/dsa/qca/ar9331.c | 247 ++- > 1 file changed, 246 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/dsa/

[PATCH v2] bridge: Fix a deadlock when enabling multicast snooping

2020-12-04 Thread Joseph Huang
When enabling multicast snooping, bridge module deadlocks on multicast_lock if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2 network. The deadlock was caused by the following sequence: While holding the lock, br_multicast_open calls br_multicast_join_snoopers, which eventu

Re: [PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Alexander Duyck
On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello wrote: > > commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME > systems") > disabled s0ix flows for systems that have various incarnations of the > i219-LM ethernet controller. This was done because of some regressions > cause

Re: [PATCH v3 2/7] e1000e: Move all S0ix related code into its own source file

2020-12-04 Thread Alexander Duyck
On Fri, Dec 4, 2020 at 12:09 PM Mario Limonciello wrote: > > Introduce a flag to indicate the device should be using the S0ix > flows and use this flag to run those functions. > > Splitting the code to it's own file will make future heuristics > more self contained. > > Tested-by: Yijun Shen > Si

[PATCH net] net/tls: Fix kernel panic when socket is in tls toe mode

2020-12-04 Thread Vinay Kumar Yadav
When socket is in tls-toe (TLS_HW_RECORD) and connections are established in kernel stack, on every connection close it clears tls context which is created once on socket creation, causing kernel panic. fix it by not initializing listen in kernel stack incase of tls-toe, allow listen in only adapte

Re: Why the auxiliary cipher in gss_krb5_crypto.c?

2020-12-04 Thread Herbert Xu
On Fri, Dec 04, 2020 at 06:35:48PM +0100, Ard Biesheuvel wrote: > > Herbert recently made some changes for MSG_MORE support in the AF_ALG > code, which permits a skcipher encryption to be split into several > invocations of the skcipher layer without the need for this complexity > on the side of th

Re: bonding driver issue when configured for active/backup and using ARP monitoring

2020-12-04 Thread Jay Vosburgh
Finer, Howard wrote: >We use the bonding driver in an active-backup configuration with ARP >monitoring. We also use the TIPC protocol which we run over the bond >device. We are consistently seeing an issue in both the 3.16 and 4.19 >kernels whereby when the bond slave is switched TIPC is being no

Re: [PATCH 0/2 v3] Improve error handling of verifier tests

2020-12-04 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 4 Dec 2020 19:18:26 +0100 you wrote: > These patches improve the error handling for verifier tests. With "Test > the 32bit narrow read" Krzesimir Nowak provided these patches first, but > they were never merged. > Th

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 11:33:26 -0800 Saeed Mahameed wrote: > On Thu, 2020-12-03 at 18:29 -0800, Jakub Kicinski wrote: > > On Wed, 2 Dec 2020 20:21:01 -0800 Saeed Mahameed wrote: > > > Add TX PTP port object support for better TX timestamping accuracy. > > > Currently, driver supports CQE based TX p

[PATCH v3 0/7] Improve s0ix flows for systems i219LM

2020-12-04 Thread Mario Limonciello
commit e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems") disabled s0ix flows for systems that have various incarnations of the i219-LM ethernet controller. This was done because of some regressions caused by an earlier commit 632fbd5eb5b0e ("e1000e: fix S0ix flows for cable

[PATCH v3 6/7] e1000e: Add Dell TGL desktop systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
These Tiger Lake systems are not yet released, but have been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello --- d

[PATCH v3 2/7] e1000e: Move all S0ix related code into its own source file

2020-12-04 Thread Mario Limonciello
Introduce a flag to indicate the device should be using the S0ix flows and use this flag to run those functions. Splitting the code to it's own file will make future heuristics more self contained. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/Mak

[PATCH v3 5/7] e1000e: Add more Dell CML systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
These Comet Lake systems are not yet released, but have been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Tested-by: Yijun Shen Signed-off-by: Ma

[PATCH v3 1/7] e1000e: fix S0ix flow to allow S0i3.2 subset entry

2020-12-04 Thread Mario Limonciello
From: Vitaly Lifshits Changed a configuration in the flows to align with architecture requirements to achieve S0i3.2 substate. Also fixed a typo in the previous commit 632fbd5eb5b0 ("e1000e: fix S0ix flows for cable connected case"). Signed-off-by: Vitaly Lifshits Tested-by: Aaron Brown Signe

[PATCH v3 4/7] e1000e: Add Dell's Comet Lake systems into S0ix heuristics

2020-12-04 Thread Mario Limonciello
Dell's shipping Comet Lake Latitude and Precision systems containing i219LM are properly configured and should use the S0ix flows. Disabling s0ix entry and exit flows caused a regression in power consumption over suspend to idle on these systems. Fixes: e086ba2fccda ("e1000e: disable s0ix entry a

[PATCH v3 3/7] e1000e: Export S0ix flags to ethtool

2020-12-04 Thread Mario Limonciello
This flag can be used for debugging and development purposes including determining if S0ix flows work properly for a system not currently recognized by heuristics. Tested-by: Yijun Shen Signed-off-by: Mario Limonciello --- drivers/net/ethernet/intel/e1000e/ethtool.c | 40 +

[PATCH v3 7/7] e1000e: Add another Dell TGL notebook system into S0ix heuristics

2020-12-04 Thread Mario Limonciello
This Tiger Lake system is not yet released, but has been validated on pre-release hardware. This is being submitted separately from released hardware in case of a regression between pre-release and release hardware so this commit can be reverted alone. Signed-off-by: Mario Limonciello --- drive

Re: [PATCH v2 1/3] dt-bindings: net: fsl-fec add mdc/mdio bitbang option

2020-12-04 Thread Adrien Grassein
Hi all, I'm not a kernel expert, but I try to find why these patches were needed in the FSL/Boundary kernel. I found that the pin muxing in the original kernel was not good for FEC. It's now working well with the mainline code. You can delete these patches. Thanks a lot, Regards, Adrien Le lu

Re: [PATCH v1 bpf-next 09/11] bpf: Support bpf_get_socket_cookie_sock() for BPF_PROG_TYPE_SK_REUSEPORT.

2020-12-04 Thread Martin KaFai Lau
On Tue, Dec 01, 2020 at 11:44:16PM +0900, Kuniyuki Iwashima wrote: > We will call sock_reuseport.prog for socket migration in the next commit, > so the eBPF program has to know which listener is closing in order to > select the new listener. > > Currently, we can get a unique ID for each listener

[PATCH] net: fix spelling mistake "wil" -> "will" in Kconfig

2020-12-04 Thread Colin King
From: Colin Ian King There is a spelling mistake in the Kconfig help text. Fix it. Signed-off-by: Colin Ian King --- drivers/net/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 4ee41924cdf1..260f9f46668b 100644 --- a/d

Re: [PATCH v2] bpf: remove trailing semicolon in macro definition

2020-12-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Wed, 2 Dec 2020 13:28:10 -0800 you wrote: > From: Tom Rix > > The macro use will already have a semicolon. > Clean up escaped newlines > > Signed-off-by: Tom Rix > > [...] Here is the summary with links: - [v2] bpf

Re: [net-next V2 08/15] net/mlx5e: Add TX PTP port object support

2020-12-04 Thread Saeed Mahameed
On Thu, 2020-12-03 at 18:29 -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 20:21:01 -0800 Saeed Mahameed wrote: > > Add TX PTP port object support for better TX timestamping accuracy. > > Currently, driver supports CQE based TX port timestamp. Device > > also offers TX port timestamp, which has

Re: [PATCH v6 bpf-next 10/14] bpf: allow to specify kernel module BTFs when attaching BPF programs

2020-12-04 Thread Andrii Nakryiko
On Thu, Dec 3, 2020 at 5:54 PM Alexei Starovoitov wrote: > > On Thu, Dec 03, 2020 at 12:46:30PM -0800, Andrii Nakryiko wrote: > > + if (attr->attach_prog_fd) { > > + dst_prog = bpf_prog_get(attr->attach_prog_fd); > > + if (IS_ERR(dst_prog)) { > > + d

Re: pull-request: mac80211 2020-12-04

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 13:20:16 +0100 Johannes Berg wrote: > Hi Jakub, > > We've got a few more fixes for the current cycle, everything > else I have pending right now seems likely to go to 5.11 instead. > > Please pull and let me know if there's any problem. Pulled, thanks!

[PATCH] [v2] enetc: fix build warning

2020-12-04 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, there is a harmless warning about an unused variable: enetc_pf.c: In function 'enetc_phylink_create': enetc_pf.c:981:17: error: unused variable 'dev' [-Werror=unused-variable] Slightly rearrange the code to pass around the of_node as a function ar

Re: [PATCH v2 bpf 0/5] New netdev feature flags for XDP

2020-12-04 Thread Jakub Kicinski
On Fri, 04 Dec 2020 18:26:10 +0100 Toke Høiland-Jørgensen wrote: > Jakub Kicinski writes: > > > On Fri, 4 Dec 2020 11:28:56 +0100 alar...@gmail.com wrote: > >> * Extend ethtool netlink interface in order to get access to the XDP > >>bitmap (XDP_PROPERTIES_GET). [Toke] > > > > That's a g

Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 10:55:16 -0800 Jakub Kicinski wrote: > > > > drivers/net/ethernet/mscc/ocelot_net.c | 83 +- > > > > 1 file changed, 80 insertions(+), 3 deletions(-) > > > > > > This is a little large for a rc7 fix :S > > > > Fine, net-next it is then. > > If

Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Alexandre Belloni
On 04/12/2020 10:55:16-0800, Jakub Kicinski wrote: > On Fri, 4 Dec 2020 18:12:51 + Vladimir Oltean wrote: > > On Fri, Dec 04, 2020 at 10:00:21AM -0800, Jakub Kicinski wrote: > > > On Fri, 4 Dec 2020 19:51:25 +0200 Vladimir Oltean wrote: > > > > Currently ocelot_set_rx_mode calls ocelot_mact_

Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Vladimir Oltean
On Fri, Dec 04, 2020 at 10:55:16AM -0800, Jakub Kicinski wrote: > On Fri, 4 Dec 2020 18:12:51 + Vladimir Oltean wrote: > > On Fri, Dec 04, 2020 at 10:00:21AM -0800, Jakub Kicinski wrote: > > > On Fri, 4 Dec 2020 19:51:25 +0200 Vladimir Oltean wrote: > > > > Currently ocelot_set_rx_mode calls o

Re: pull-request: wireless-drivers-next-2020-12-03

2020-12-04 Thread Jakub Kicinski
On Thu, 3 Dec 2020 18:57:32 + (UTC) Kalle Valo wrote: > wireless-drivers-next patches for v5.11 > > First set of patches for v5.11. rtw88 getting improvements to work > better with Bluetooth and other driver also getting some new features. > mhi-ath11k-immutable branch was pulled from mhi tre

Re: [PATCH v2 net] net: mscc: ocelot: install MAC addresses in .ndo_set_rx_mode from process context

2020-12-04 Thread Jakub Kicinski
On Fri, 4 Dec 2020 18:12:51 + Vladimir Oltean wrote: > On Fri, Dec 04, 2020 at 10:00:21AM -0800, Jakub Kicinski wrote: > > On Fri, 4 Dec 2020 19:51:25 +0200 Vladimir Oltean wrote: > > > Currently ocelot_set_rx_mode calls ocelot_mact_learn directly, which has > > > a very nice ocelot_mact_wai

Re: [PATCH v2 bpf-next] bpf: increment and use correct thread iterator

2020-12-04 Thread Yonghong Song
On 12/4/20 9:14 AM, Jonathan Lemon wrote: On Fri, Dec 04, 2020 at 12:01:53AM -0800, Yonghong Song wrote: On 12/3/20 7:43 PM, Jonathan Lemon wrote: From: Jonathan Lemon Could you explain in the commit log what problem this patch tries to solve? What bad things could happen without this p

[PATCH v2 bpf-next 1/3] bpf: eliminate btf_module_mutex as RCU synchronization can be used

2020-12-04 Thread Alan Maguire
btf_module_mutex is used when manipulating the BTF module list. However we will wish to look up this list from BPF program context, and such contexts can include interrupt state where we cannot sleep due to a mutex_lock(). RCU usage here conforms quite closely to the example in the system call aud

  1   2   3   4   >