Re: memory leak in xskq_create

2020-12-16 Thread Peilin Ye
Hi Björn, On Thu, Dec 17, 2020 at 08:12:26AM +0100, Björn Töpel wrote: > On 2020-12-16 19:11, Peilin Ye wrote: > > I have tested the following diff locally against syzbot's reproducer, > > and sent a patch to it [1] for testing. I will send a real patch here > > tomorrow if syzbot is happy about

Re: [net-next PATCH v2 02/14] net: phy: Introduce phy related fwnode functions

2020-12-16 Thread Calvin Johnson
On Tue, Dec 15, 2020 at 07:23:26PM +0200, Andy Shevchenko wrote: > On Tue, Dec 15, 2020 at 6:44 PM Calvin Johnson > wrote: > > > > Define fwnode_phy_find_device() to iterate an mdiobus and find the > > phy device of the provided phy fwnode. Additionally define > > device_phy_find_device() to find

Re: [PATCH 00/21] Control VQ support in vDPA

2020-12-16 Thread Eli Cohen
On Wed, Dec 16, 2020 at 02:47:57PM +0800, Jason Wang wrote: Hi Jason, I saw the patchset and will start reviewing it starting Dec 27. I am out of office next week. > Hi All: > > This series tries to add the support for control virtqueue in vDPA. > > Control virtqueue is used by networking devic

[PATCH v1 1/4] Bluetooth: Keep MSFT extension info throughout a hci_dev's life cycle

2020-12-16 Thread Miao-chen Chou
This moves msft_do_close() from hci_dev_do_close() to hci_unregister_dev() to avoid clearing MSFT extension info. This also avoids retrieving MSFT info upon every msft_do_open() if MSFT extension has been initialized. The following test steps were performed. (1) boot the test device and verify the

Re: one prog multi fentry. Was: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-16 Thread Alexei Starovoitov
On Wed, Dec 16, 2020 at 02:27:23PM -0800, Andrii Nakryiko wrote: > > But this seems more "verifiable" and nicer to use, even though it > won't substituting an arbitrary btf_id and btf_obj (but that's sort of > a goal, I think): > > skb = bpf_get_btf_arg(ctx, 1, bpf_core_type_id_kernel(skb)); yep

Re: memory leak in xskq_create

2020-12-16 Thread Björn Töpel
On 2020-12-16 19:11, Peilin Ye wrote: Hi all, On Sun, Dec 13, 2020 at 06:53:10AM -0800, syzbot wrote: BUG: memory leak unreferenced object 0x88810f897940 (size 64): comm "syz-executor991", pid 8502, jiffies 4294942194 (age 14.080s) hex dump (first 32 bytes): 7f 00 00 00 80 00 0

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Colin King wrote: > Currently the null check on a newly allocated skb is missing and > this can lead to a null pointer dereference is the allocation fails. > Fix this by adding a null check and returning -ENOMEM. > > Addresses-Coverity: ("Dereference null return") > Fixes: 43ed15e1ee01 ("ath11k:

Re: USGv6 Tunnel Mode Fragmentation Failures

2020-12-16 Thread Steffen Klassert
On Thu, Nov 26, 2020 at 09:21:39AM +, Marler, Jonathan wrote: > We've found an issue while running the following USGv6 tests where the kernel > drops outgoing packets: > > 5.3.11 Tunnel Mode: Fragmentation > 5.4.11 Tunnel Mode: Fragmentation > > During the test, an esp PING request is sent t

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Kalle Valo writes: > Colin King wrote: > >> Currently the null check on a newly allocated skb is missing and >> this can lead to a null pointer dereference is the allocation fails. >> Fix this by adding a null check and returning -ENOMEM. >> >> Addresses-Coverity: ("Dereference null return") >>

Re: [PATCH][next] ath11k: add missing null check on allocated skb

2020-12-16 Thread Kalle Valo
Colin King wrote: > Currently the null check on a newly allocated skb is missing and > this can lead to a null pointer dereference is the allocation fails. > Fix this by adding a null check and returning -ENOMEM. > > Addresses-Coverity: ("Dereference null return") > Fixes: 43ed15e1ee01 ("ath11k:

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread Cong Wang
On Wed, Dec 16, 2020 at 10:35 AM Andrii Nakryiko wrote: > > On Tue, Dec 15, 2020 at 4:15 PM Cong Wang wrote: > > > > On Tue, Dec 15, 2020 at 2:08 PM Andrii Nakryiko > > wrote: > > > > > > On Tue, Dec 15, 2020 at 12:06 PM Cong Wang > > > wrote: > > > > > > > > On Tue, Dec 15, 2020 at 11:27 AM A

Re: [RFC PATCH v1 7/7] powerpc/bpf: Implement extended BPF on PPC32

2020-12-16 Thread Alexei Starovoitov
On Wed, Dec 16, 2020 at 10:07:37AM +, Christophe Leroy wrote: > Implement Extended Berkeley Packet Filter on Powerpc 32 > > Test result with test_bpf module: > > test_bpf: Summary: 378 PASSED, 0 FAILED, [354/366 JIT'ed] nice! > Registers mapping: > > [BPF_REG_0] = r11-r12 >

RE: [net-next v5 05/15] devlink: Support get and set state of port function

2020-12-16 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Thursday, December 17, 2020 5:39 AM > > On Wed, 16 Dec 2020 05:15:04 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Wednesday, December 16, 2020 6:08 AM > > > > > > On Tue, 15 Dec 2020 01:03:48 -0800 Saeed Mahameed wrote: > > > > From: Parav Pa

DR

2020-12-16 Thread db.bankdirecto...@gmail.com

RE: [PATCH][next] octeontx2-af: Fix undetected unmap PF error check

2020-12-16 Thread George Cherian
> -Original Message- > From: Colin King > Sent: Wednesday, December 16, 2020 6:06 PM > To: Sunil Kovvuri Goutham ; Linu Cherian > ; Geethasowjanya Akula ; > Jerin Jacob Kollanukkaran ; David S . Miller > ; Jakub Kicinski ; George > Cherian ; netdev@vger.kernel.org > Cc: kernel-janit...@v

RE: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-16 Thread Parav Pandit
> From: Jakub Kicinski > Sent: Thursday, December 17, 2020 5:42 AM > > On Wed, 16 Dec 2020 05:19:15 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > Sent: Wednesday, December 16, 2020 6:14 AM > > > > > > On Tue, 15 Dec 2020 01:03:50 -0800 Saeed Mahameed wrote: > > > > +static ssize_

Re: [Patch bpf-next v2 2/5] bpf: introduce timeout map

2020-12-16 Thread Cong Wang
On Tue, Dec 15, 2020 at 6:35 PM Alexei Starovoitov wrote: > > On Tue, Dec 15, 2020 at 6:10 PM Cong Wang wrote: > > > > Sure, people also implement CT on native hash map too and timeout > > with user-space timers. ;) > > exactly. what's wrong with that? > Perfectly fine way to do CT. Seriously? W

Re: [net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-16 Thread Saeed Mahameed
On Wed, 2020-12-16 at 15:59 -0800, Jakub Kicinski wrote: > On Wed, 16 Dec 2020 03:42:51 + Parav Pandit wrote: > > > From: Jakub Kicinski > > > So subfunctions don't have a VF id but they may have a > > > controller? > > > > > Right. SF can be on external controller. > > > > > Can you tell

Re: [PATCH 00/21] Control VQ support in vDPA

2020-12-16 Thread Jason Wang
On 2020/12/16 下午5:47, Michael S. Tsirkin wrote: On Wed, Dec 16, 2020 at 02:47:57PM +0800, Jason Wang wrote: Hi All: This series tries to add the support for control virtqueue in vDPA. Control virtqueue is used by networking device for accepting various commands from the driver. It's a must t

Re: [PATCH net v2 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-16 Thread Jason Wang
On 2020/12/16 下午5:23, Michael S. Tsirkin wrote: On Wed, Dec 16, 2020 at 04:20:37PM +0800, wangyunjian wrote: From: Yunjian Wang Currently we break the loop and wake up the vhost_worker when sendmsg fails. When the worker wakes up again, we'll meet the same error. This will cause high CPU load

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-16 Thread Sven Van Asbroeck
On Wed, Dec 16, 2020 at 8:01 PM Florian Fainelli wrote: > > x86 is a fully cache and device coherent memory architecture and there > are smarts like DDIO to bring freshly DMA'd data into the L3 cache > directly. For ARMv7, it depends on the hardware you have, most ARMv7 > SoCs do not have hardware

RE: [PATCH net v2 2/2] vhost_net: fix high cpu load when sendmsg fails

2020-12-16 Thread wangyunjian
> -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, December 16, 2020 5:23 PM > To: wangyunjian > Cc: netdev@vger.kernel.org; jasow...@redhat.com; > willemdebruijn.ker...@gmail.com; virtualizat...@lists.linux-foundation.org; > Lilijun (Jerry) ; chenc

Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2020-12-16 Thread Richard Cochran
On Wed, Dec 16, 2020 at 05:13:34PM -0800, Jakub Kicinski wrote: > On Wed, 16 Dec 2020 12:32:38 +0100 Holger Assmann wrote: > > As it is, valid SIOCSHWTSTAMP ioctl calls - i.e. enable/disable time > > stamping or changing filter settings - lead to synchronization of the > > NIC's hardware clock with

Re: [RFC PATCH net-next 2/9] net: switchdev: delete switchdev_port_obj_add_now

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > After the removal of the transactional model inside > switchdev_port_obj_add_now, it has no added value and we can just call > switchdev_port_obj_notify directly, bypassing this function. Let's > delete it. > > Signed-off-by: Vladimir Oltean Rev

Re: [RFC PATCH net-next 1/9] net: switchdev: remove the transaction structure from port object notifiers

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > Since the introduction of the switchdev API, port objects were > transmitted to drivers for offloading using a two-step transactional > model, with a prepare phase that was supposed to catch all errors, and a > commit phase that was supposed to nev

Re: [RFC PATCH net-next 9/9] net: switchdev: delete the transaction object

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > Now that all users of struct switchdev_trans have been modified to do > without it, we can remove this structure and the two helpers to determine > the phase. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 7/9] net: dsa: remove obsolete comment about switchdev transactions

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > Now that all port object notifiers were converted to be non-transactional, > we can remove the comment that says otherwise. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli -- Florian

Re: [RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > It should be the driver's business to logically separate its VLAN > offloading into a preparation and a commit phase, and some drivers don't > need / can't do this. > > So remove the transactional shim from DSA and let drivers to propagate > error

Re: [RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > For many drivers, the .port_mdb_prepare callback was not a good opportunity > to avoid any error condition, and they would suppress errors found during > the actual commit phase. > > Where a logical separation between the prepare and the commit ph

Re: [RFC PATCH net-next 4/9] net: dsa: remove the transactional logic from ageing time notifiers

2020-12-16 Thread Florian Fainelli
On 12/16/2020 5:58 PM, Vladimir Oltean wrote: > Remove the shim introduced in DSA for offloading the bridge ageing time > from switchdev, by first checking whether the ageing time is within the > range limits requested by the driver. > > Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fai

[RFC PATCH net-next 9/9] net: switchdev: delete the transaction object

2020-12-16 Thread Vladimir Oltean
Now that all users of struct switchdev_trans have been modified to do without it, we can remove this structure and the two helpers to determine the phase. Signed-off-by: Vladimir Oltean --- include/net/switchdev.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/include/net/swi

[RFC PATCH net-next 7/9] net: dsa: remove obsolete comment about switchdev transactions

2020-12-16 Thread Vladimir Oltean
Now that all port object notifiers were converted to be non-transactional, we can remove the comment that says otherwise. Signed-off-by: Vladimir Oltean --- net/dsa/slave.c | 5 - 1 file changed, 5 deletions(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index ffad4324c736..c5f38bcaa5af

[RFC PATCH net-next 6/9] net: dsa: remove the transactional logic from VLAN objects

2020-12-16 Thread Vladimir Oltean
It should be the driver's business to logically separate its VLAN offloading into a preparation and a commit phase, and some drivers don't need / can't do this. So remove the transactional shim from DSA and let drivers to propagate errors directly from the .port_vlan_add callback. Signed-off-by:

[RFC PATCH net-next 8/9] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects

2020-12-16 Thread Vladimir Oltean
As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning errors in commit phase"), the mlxsw driver performs the VLAN object offloading during the prepare phase. So conversion just seems to be a matter of removing the code that was running in the commit phase. Signed-off-by: Vladimir

[RFC PATCH net-next 5/9] net: dsa: remove the transactional logic from MDB entries

2020-12-16 Thread Vladimir Oltean
For many drivers, the .port_mdb_prepare callback was not a good opportunity to avoid any error condition, and they would suppress errors found during the actual commit phase. Where a logical separation between the prepare and the commit phase existed, the function that used to implement the .port_

[RFC PATCH net-next 3/9] net: switchdev: remove the transaction structure from port attributes

2020-12-16 Thread Vladimir Oltean
Since the introduction of the switchdev API, port attributes were transmitted to drivers for offloading using a two-step transactional model, with a prepare phase that was supposed to catch all errors, and a commit phase that was supposed to never fail. Some classes of failures can never be avoide

[RFC PATCH net-next 2/9] net: switchdev: delete switchdev_port_obj_add_now

2020-12-16 Thread Vladimir Oltean
After the removal of the transactional model inside switchdev_port_obj_add_now, it has no added value and we can just call switchdev_port_obj_notify directly, bypassing this function. Let's delete it. Signed-off-by: Vladimir Oltean --- net/switchdev/switchdev.c | 17 + 1 file cha

[RFC PATCH net-next 4/9] net: dsa: remove the transactional logic from ageing time notifiers

2020-12-16 Thread Vladimir Oltean
Remove the shim introduced in DSA for offloading the bridge ageing time from switchdev, by first checking whether the ageing time is within the range limits requested by the driver. Signed-off-by: Vladimir Oltean --- net/dsa/dsa_priv.h | 1 - net/dsa/port.c | 6 +- net/dsa/switch.c |

[RFC PATCH net-next 1/9] net: switchdev: remove the transaction structure from port object notifiers

2020-12-16 Thread Vladimir Oltean
Since the introduction of the switchdev API, port objects were transmitted to drivers for offloading using a two-step transactional model, with a prepare phase that was supposed to catch all errors, and a commit phase that was supposed to never fail. Some classes of failures can never be avoided,

[RFC PATCH net-next 0/9] Get rid of the switchdev transactional model

2020-12-16 Thread Vladimir Oltean
This series comes after the late realization that the prepare/commit separation imposed by switchdev does not help literally anybody: https://patchwork.kernel.org/project/netdevbpf/patch/20201212203901.351331-1-vladimir.olt...@nxp.com/ We should kill it before it inflicts even more damage to the e

Re: [PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2020-12-16 Thread Song Liu
> On Dec 16, 2020, at 4:34 PM, Andrii Nakryiko > wrote: > > On Tue, Dec 15, 2020 at 3:37 PM Song Liu wrote: >> >> Introduce task_vma bpf_iter to print memory information of a process. It >> can be used to print customized information similar to /proc//maps. >> >> task_vma iterator releases

Re: [PATCH net-next] ceph: Delete useless kfree code

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 21:02:39 +0800 Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun To be clear the subject tags is misleading we're not taking this into the networking tree, ceph folk please go ahead :)

Re: [PATCH 1/2] net: stmmac: retain PTP-clock at hwtstamp_set

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 12:32:38 +0100 Holger Assmann wrote: > As it is, valid SIOCSHWTSTAMP ioctl calls - i.e. enable/disable time > stamping or changing filter settings - lead to synchronization of the > NIC's hardware clock with CLOCK_REALTIME. This might be necessary > during system initialization,

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-16 Thread Florian Fainelli
On 12/16/20 4:57 PM, Sven Van Asbroeck wrote: > Hi Andrew, > > On Wed, Dec 9, 2020 at 9:10 AM Andrew Lunn wrote: >> >> 9K is not a nice number, since for each allocation it probably has to >> find 4 contiguous pages. See what the performance difference is with >> 2K, 4K and 8K. If there is a big

Re: [PATCH net v1 2/2] lan743x: boost performance: limit PCIe bandwidth requirement

2020-12-16 Thread Sven Van Asbroeck
Hi Andrew, On Wed, Dec 9, 2020 at 9:10 AM Andrew Lunn wrote: > > 9K is not a nice number, since for each allocation it probably has to > find 4 contiguous pages. See what the performance difference is with > 2K, 4K and 8K. If there is a big difference, you might want to special > case when the MT

Re: [PATCH wireless -next] rtw88: Delete useless kfree code

2020-12-16 Thread Pkshih
On Wed, 2020-12-16 at 13:04 +, Zheng Yongjun wrote: > The parameter of kfree function is NULL, so kfree code is useless, delete it. > > Signed-off-by: Zheng Yongjun Acked-by: Ping-Ke Shih > --- >  drivers/net/wireless/realtek/rtw88/main.c | 1 - >  1 file changed, 1 deletion(-) > > diff --

Re: [PATCH net-next] net: rds: Change PF_INET to AF_INET

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 15:06:20 +0800 Zheng Yongjun wrote: > By bsd codestyle, change PF_INET to AF_INET. > > Signed-off-by: Zheng Yongjun # Form letter - net-next is closed We have already sent the networking pull request for 5.11 and therefore net-next is closed for new drivers, features, code r

Re: [PATCH net-next] r8169: facilitate adding new chip versions

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 17:15:05 +0100 Heiner Kallweit wrote: > Add a constant RTL_GIGA_MAC_MAX and use it if all new chip versions > handle a feature in a specific way. As result we have to touch less > places when adding support for a new chip version. > > Signed-off-by: Heiner Kallweit Looks harm

Re: [PATCH] net: remove disc_data_lock in ppp line discipline

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 23:00:54 +0800 Gao Yan wrote: > tty layer provide tty->ldisc_sem lock to protect tty->disc_data; > For examlpe, when cpu A is running ppp_synctty_ioctl that > hold the tty->ldisc_sem, so if cpu B calls ppp_synctty_close, > it will wait until cpu A release tty->ldisc_sem. So I th

Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix That's for new code I assume? What's the harm in leaving this ancient code b

Re: [PATCH net 1/2] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 15:32:12 +0200 stef...@marvell.com wrote: > From: Stefan Chulski > > During GoP port 2 Networking Complex Control mode of operation configurations, > also GoP port 3 mode of operation was wrongly set mode. > Patch removes these configurations. > GENCONF_CTRL0_PORTX naming also

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-16 Thread Jason Gunthorpe
On Wed, Dec 16, 2020 at 02:53:07PM -0800, Alexander Duyck wrote: > It isn't about the association, it is about who is handling the > traffic. Going back to the macvlan model what we did is we had a group > of rings on the device that would automatically forward unicast > packets to the macvlan in

Re: [PATCH v2 bpf-next 1/4] bpf: introduce task_vma bpf_iter

2020-12-16 Thread Andrii Nakryiko
On Tue, Dec 15, 2020 at 3:37 PM Song Liu wrote: > > Introduce task_vma bpf_iter to print memory information of a process. It > can be used to print customized information similar to /proc//maps. > > task_vma iterator releases mmap_lock before calling the BPF program. > Therefore, we cannot pass vm

Re: [PATCH net-next] devlink: use _BITUL() macro instead of BIT() in the UAPI header

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 15 Dec 2020 11:25:31 +0100 you wrote: > The BIT() macro is not available for the UAPI headers. Moreover, it can > be defined differently in user space headers. Thus, replace its usage > with the _BITUL() macro which is a

Re: [MPTCP][PATCH net-next] mptcp: clear use_ack and use_map when dropping other suboptions

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 16:11:52 -0800 (PST) Mat Martineau wrote: > On Tue, 15 Dec 2020, Geliang Tang wrote: > > > This patch cleared use_ack and use_map when dropping other suboptions to > > fix the following syzkaller BUG: > > Reported-by: Christoph Paasch > > Fixes: 84dfe3677a6f (mptcp: send out

Re: [PATCH] bpf: remove unused including

2020-12-16 Thread Andrii Nakryiko
On Tue, Dec 15, 2020 at 6:47 PM Tian Tao wrote: > > Remove including that don't need it. > > Signed-off-by: Tian Tao > --- > kernel/bpf/syscall.c | 1 - > 1 file changed, 1 deletion(-) > Probably a left over since times kprobe programs were required to specify expected kernel version. Acked-b

Re: [PATCH net-next] net/mlx5: Fix compilation warning for 32-bit platform

2020-12-16 Thread Jakub Kicinski
On Mon, 14 Dec 2020 12:08:46 -0800 Saeed Mahameed wrote: > I will change this and attach this patch to my PR of the SF support. Looks like the SF discussion will not wind down in time to make this merge window, so I think I'm going to take this in after all. Okay?

Re: [net-next v5 07/15] net/mlx5: SF, Add auxiliary device support

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 05:19:15 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Wednesday, December 16, 2020 6:14 AM > > > > On Tue, 15 Dec 2020 01:03:50 -0800 Saeed Mahameed wrote: > > > +static ssize_t sfnum_show(struct device *dev, struct device_attribute > > > +*attr, char *buf) {

Re: [PATCH v9 bpf-next] bpf/selftests: fold test_current_pid_tgid_new_ns into test_progs.

2020-12-16 Thread Andrii Nakryiko
On Wed, Dec 16, 2020 at 6:18 AM Carlos Neira wrote: > > Currently tests for bpf_get_ns_current_pid_tgid() are outside test_progs. > This change folds test cases into test_progs. > > Changes from v8: > > - Fixed code style > - Fixed CHECK macro usage > - Removed root namespace sub-test > - Spli

Re: [net-next v5 05/15] devlink: Support get and set state of port function

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 05:15:04 + Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Wednesday, December 16, 2020 6:08 AM > > > > On Tue, 15 Dec 2020 01:03:48 -0800 Saeed Mahameed wrote: > > > From: Parav Pandit > > > > > > devlink port function can be in active or inactive state. > > > A

Re: net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-16 Thread Ben Greear
On 12/16/20 3:09 PM, Ben Greear wrote: Hello Eric, The patch below evidently causes TCP throughput to be about 50Mbps instead of 700Mbps when using ax200 to upload tcp traffic. When I disable TSO, performance goes back up to around 700Mbps. As a followup, when I revert the patch, upload spee

Re: [net-next v5 03/15] devlink: Introduce PCI SF port flavour and port attribute

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 03:42:51 + Parav Pandit wrote: > > From: Jakub Kicinski > > So subfunctions don't have a VF id but they may have a controller? > > > Right. SF can be on external controller. > > > Can you tell us more about the use cases and deployment models you're > > intending to sup

Re: [PATCH net-next 0/4] enetc: code cleanups

2020-12-16 Thread Andrew Lunn
> Ah, I thought it will be picked up automatically after the merge > window is closed, no? Nope. With netdev, if it is not merged in about 3 days, it needs to be reposted. And it might need a rebased after the merge window closes and net-next reopens. Andrew

Re: [PATCH net 2/4] mptcp: properly annotate nested lock

2020-12-16 Thread Mat Martineau
On Wed, 16 Dec 2020, Paolo Abeni wrote: MPTCP closes the subflows while holding the msk-level lock. While acquiring the subflow socket lock we need to use the correct nested annotation, or we can hit a lockdep splat at runtime. Reported-and-tested-by: Geliang Tang Fixes: e16163b6e2b7 ("mptcp

Re: [PATCH net 1/4] mptcp: fix security context on server socket

2020-12-16 Thread Mat Martineau
On Wed, 16 Dec 2020, Paolo Abeni wrote: Currently MPTCP is not propagating the security context from the ingress request socket to newly created msk at clone time. Address the issue invoking the missing security helper. Fixes: cf7da0d66cc1 ("mptcp: Create SUBFLOW socket for incoming connection

Re: [PATCH net-next v4] udp:allow UDP cmsghdrs through io_uring

2020-12-16 Thread Victor Stewart
https://github.com/0day-ci/linux/commits/Victor-Stewart/udp-allow-UDP-cmsghdrs-through-io_uring/20201217-020451 > base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9 > config: riscv-randconfig-r031-20201216 (attached as .config

Re: [PATCH v2 bpf-next 4/4] selftests/bpf: add test for bpf_iter_task_vma

2020-12-16 Thread Song Liu
> On Dec 16, 2020, at 10:18 AM, Yonghong Song wrote: > [...] >> + >> +err = bpf_iter_task_vma__load(skel); >> +if (CHECK(err, "bpf_iter_task_vma__load", "skeleton load failed\n")) >> +goto out; >> + >> +do_dummy_read(skel->progs.proc_maps); > > This do_dummy_read() i

Re: [PATCH 1/3] PCI/ASPM: Use the path max in L1 ASPM latency check

2020-12-16 Thread Bjorn Helgaas
On Wed, Dec 16, 2020 at 12:20:53PM +0100, Ian Kumlien wrote: > On Wed, Dec 16, 2020 at 1:08 AM Bjorn Helgaas wrote: > > On Tue, Dec 15, 2020 at 02:09:12PM +0100, Ian Kumlien wrote: > > > On Tue, Dec 15, 2020 at 1:40 AM Bjorn Helgaas wrote: > > > > On Mon, Dec 14, 2020 at 11:56:31PM +0100, Ian Kum

Re: [PATCH net-next v4] udp:allow UDP cmsghdrs through io_uring

2020-12-16 Thread kernel test robot
-next.git 3db1a3fa98808aa90f95ec3e0fa2fc7abf28f5c9 config: riscv-randconfig-r031-20201216 (attached as .config) compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 71601d2ac9954cb59c443cb3ae442cb106df35d4) reproduce (this is a W=1 build): wget https

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2020-12-16 Thread Edward Cree
On 16/12/2020 08:45, Jesper Dangaard Brouer wrote: > So, what I hear is that this fix is just pampering over the real issue. Yes, it is, but it's better than nothing in the meantime while we work out the complete fix. > I suggest that you/we detect the situation, and have a code path that > will

Re: [PATCH net-next 0/1] net/smc: fix access to parent of an ib device

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 15 Dec 2020 10:10:57 +0100 you wrote: > Please apply the following patch for smc to netdev's net-next tree. > > The patch fixes an access to the parent of an ib device which might be NULL. > > I am sending this fix to

net: tso: add UDP segmentation support: adds regression for ax200 upload

2020-12-16 Thread Ben Greear
Hello Eric, The patch below evidently causes TCP throughput to be about 50Mbps instead of 700Mbps when using ax200 to upload tcp traffic. When I disable TSO, performance goes back up to around 700Mbps. I recall ~5 years ago we had similar TCP related performance issues with ath10k. I vaguely r

Re: [PATCH net-next] phy: fix kdoc warning

2020-12-16 Thread Jakub Kicinski
On Mon, 14 Dec 2020 22:37:50 -0800 Jakub Kicinski wrote: > Kdoc does not like it when multiline comment follows the networking > style of starting right on the first line: > > include/linux/phy.h:869: warning: Function parameter or member 'config_intr' > not described in 'phy_driver' > > Signed-

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Jakub Kicinski
On Wed, 16 Dec 2020 13:32:26 -0800 Florian Fainelli wrote: > On 12/16/20 12:43 PM, Jakub Kicinski wrote: > > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: > >> The ndo_start_xmit() method must not attempt to free the skb to transmit > >> when returning NETDEV_TX_BUSY. Therefore, make s

[PATCH net-next v5] udp:allow UDP cmsghdrs through io_uring

2020-12-16 Thread Victor Stewart
This patch adds PROTO_CMSG_DATA_ONLY to inet_dgram_ops and inet6_dgram_ops so that UDP_SEGMENT (GSO) and UDP_GRO can be used through io_uring. GSO and GRO are vital to bring QUIC servers on par with TCP throughputs, and together offer a higher throughput gain than io_uring alone (rate of data tr

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-16 Thread Alexander Duyck
On Wed, Dec 16, 2020 at 12:35 PM Jason Gunthorpe wrote: > > On Wed, Dec 16, 2020 at 11:27:32AM -0800, Alexander Duyck wrote: > > > That has been the case for a long time. However it had been my > > experience that SR-IOV never scaled well to meet those needs and so it > > hadn't been used in such

Re: [PATCH 0/2] Add LED mode behavior/select properties and handle

2020-12-16 Thread Pavel Machek
Hi! > In KSZ9131 PHY it is possible to control LEDs blink behavior via > LED mode behavior and select registers. Add DTS properties plus handles > of them inside micrel PHY driver. > > I've some concerns about passing raw register values into LED mode > select and behavior. It can be passed via a

Re: one prog multi fentry. Was: [PATCH bpf-next] libbpf: support module BTF for BPF_TYPE_ID_TARGET CO-RE relocation

2020-12-16 Thread Andrii Nakryiko
On Wed, Dec 16, 2020 at 8:18 AM Alan Maguire wrote: > > On Tue, 15 Dec 2020, Alexei Starovoitov wrote: > > > On Wed, Dec 09, 2020 at 11:21:43PM +, Alan Maguire wrote: > > > Right, that's exactly it. A pair of generic tracing BPF programs are > > > used, and they attach to kprobe/kretprobes, a

Re: [PATCH v1 bpf-next 05/11] tcp: Migrate TCP_NEW_SYN_RECV requests.

2020-12-16 Thread Martin KaFai Lau
On Thu, Dec 17, 2020 at 01:41:58AM +0900, Kuniyuki Iwashima wrote: [ ... ] > > There may also be places assuming that the req->rsk_listener will never > > change once it is assigned. not sure. have not looked closely yet. > > I have checked this again. There are no functions that expect explici

Re: [PATCH] selftests: Skip BPF seftests by default

2020-12-16 Thread Seth Forshee
On Thu, Dec 10, 2020 at 06:52:33PM +, Mark Brown wrote: > The BPF selftests have build time dependencies on cutting edge versions > of tools in the BPF ecosystem including LLVM which are more involved > to satisfy than more typical requirements like installing a package from > your distribution

[PATCH net-next V9] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-16 Thread Dmytro Shytyi
Variable SLAAC [Can be activated via sysctl]: SLAAC with prefixes of arbitrary length in PIO (randomly generated hostID or stable privacy + privacy extensions). The main problem is that SLAAC RA or PD allocates a /64 by the Wireless carrier 4G, 5G to a mobile hotspot, however segmentation of the /

Re: [PATCH net-next V8] net: Variable SLAAC: SLAAC with prefixes of arbitrary length in PIO

2020-12-16 Thread Dmytro Shytyi
Hello Jakub, On Wed, 16 Dec 2020 18:28:31 +0100 Jakub Kicinski wrote > On Wed, 16 Dec 2020 15:01:33 +0100 Dmytro Shytyi wrote: > > Hello David, > > > > Thank you for your comment. > > Asnwers in-line. > > > > Take care, > > > > Dmytro SHYTYI > > > > > > On

WARNING: suspicious RCU usage in get_wiphy_regdom

2020-12-16 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:00f7763a Merge tag 'mac80211-next-for-net-next-2020-12-11'.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=160acef350 kernel config: https://syzkaller.appspot.com/x/.config?x=1d8e2f94cac4630 dash

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Florian Fainelli
On 12/16/20 12:43 PM, Jakub Kicinski wrote: > On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: >> The ndo_start_xmit() method must not attempt to free the skb to transmit >> when returning NETDEV_TX_BUSY. Therefore, make sure the >> korina_send_packet() function returns NETDEV_TX_OK when it

Re: [RFC PATCH net-next 14/16] net: mscc: ocelot: rebalance LAGs on link up/down events

2020-12-16 Thread Alexandre Belloni
On 08/12/2020 14:08:00+0200, Vladimir Oltean wrote: > At present there is an issue when ocelot is offloading a bonding > interface, but one of the links of the physical ports goes down. Traffic > keeps being hashed towards that destination, and of course gets dropped > on egress. > > Monitor the n

Re: [RFC PATCH net-next 13/16] net: mscc: ocelot: rename aggr_count to num_ports_in_lag

2020-12-16 Thread Alexandre Belloni
On 08/12/2020 14:07:59+0200, Vladimir Oltean wrote: > It makes it a bit easier to read and understand the code that deals with > balancing the 16 aggregation codes among the ports in a certain LAG. > > Signed-off-by: Vladimir Oltean Reviewed-by: Alexandre Belloni > --- > drivers/net/ethernet/m

Re: [PATCH net] ethtool: fix error paths in ethnl_set_channels()

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 11:09:21 +0100 Michal Kubecek wrote: > On Tue, Dec 15, 2020 at 10:08:10AM +0100, Ivan Vecera wrote: > > Fix two error paths in ethnl_set_channels() to avoid lock-up caused > > but unreleased RTNL. > > > > Fixes: e19c591eafad ("ethtool: set device channel counts with CHANNELS_SE

Re: [RFC PATCH net-next 12/16] net: mscc: ocelot: drop the use of the "lags" array

2020-12-16 Thread Alexandre Belloni
On 08/12/2020 14:07:58+0200, Vladimir Oltean wrote: > We can now simplify the implementation by always using ocelot_get_bond_mask > to look up the other ports that are offloading the same bonding interface > as us. > > In ocelot_set_aggr_pgids, the code had a way to uniquely iterate through > LAGs

Re: [PATCH v2 net-next 0/2] nfc: s3fwrn5: Refactor the s3fwrn5 module

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Tue, 15 Dec 2020 15:53:59 +0900 you wrote: > From: Bongsu Jeon > > Refactor the s3fwrn5 module. > > 1/2 is to remove the unneeded delay for NFC sleep. > 2/2 is to remove the unused NCI prop commands. > > [...] Here is t

Re: [PATCH net-next] ibmvnic: merge do_change_param_reset into do_reset

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 02:30:08 -0600 Lijun Pan wrote: > Commit b27507bb59ed ("net/ibmvnic: unlock rtnl_lock in reset so > linkwatch_event can run") introduced do_change_param_reset function to > solve the rtnl lock issue. Majority of the code in do_change_param_reset > duplicates do_reset. Also, we c

Re: [net-next] tipc: do sanity check payload of a netlink message

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 15 Dec 2020 10:31:51 +0700 you wrote: > From: Hoang Le > > When we initialize nlmsghdr with no payload inside tipc_nl_compat_dumpit() > the parsing function returns -EINVAL. We fix it by making the parsing call > condi

Re: [PATCH net v2 1/2] vhost_net: fix ubuf refcount incorrectly when sendmsg fails

2020-12-16 Thread Michael S. Tsirkin
On Wed, Dec 16, 2020 at 04:20:20PM +0800, wangyunjian wrote: > From: Yunjian Wang > > Currently the vhost_zerocopy_callback() maybe be called to decrease > the refcount when sendmsg fails in tun. The error handling in vhost > handle_tx_zerocopy() will try to decrease the same refcount again. > Th

Re: [PATCH net-next v2 0/3] lockless version of netdev_notify_peers

2020-12-16 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 14 Dec 2020 15:19:27 -0600 you wrote: > This series introduce the lockless version of netdev_notify_peers > and then apply it to the relevant drivers. > > In v1, a more appropriate name __netdev_notify_peers is used; >

Re: [PATCH v2] net: korina: fix return value

2020-12-16 Thread Jakub Kicinski
On Mon, 14 Dec 2020 23:09:52 +0100 Vincent Stehlé wrote: > The ndo_start_xmit() method must not attempt to free the skb to transmit > when returning NETDEV_TX_BUSY. Therefore, make sure the > korina_send_packet() function returns NETDEV_TX_OK when it frees a packet. > > Fixes: ef11291bcd5f ("Add s

Re: [net-next v4 00/15] Add mlx5 subfunction support

2020-12-16 Thread Jason Gunthorpe
On Wed, Dec 16, 2020 at 11:27:32AM -0800, Alexander Duyck wrote: > That has been the case for a long time. However it had been my > experience that SR-IOV never scaled well to meet those needs and so it > hadn't been used in such deployments. Seems to be going quite well here, perhaps the applica

ethtool 5.10 released

2020-12-16 Thread Michal Kubecek
Hello, ethtool 5.10 has been released. Home page: https://www.kernel.org/pub/software/network/ethtool/ Download link: https://www.kernel.org/pub/software/network/ethtool/ethtool-5.10.tar.xz Release notes: * Feature: infrastructure for JSON output * Feature: separate FLAGS in -h

Re: [PATCH v4 net-next 4/5] net: dsa: mv88e6xxx: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
On Wed, Dec 16, 2020 at 21:04, Vladimir Oltean wrote: > On Wed, Dec 16, 2020 at 05:00:55PM +0100, Tobias Waldekranz wrote: >> Support offloading of LAGs to hardware. LAGs may be attached to a >> bridge in which case VLANs, multicast groups, etc. are also offloaded >> as usual. >> >> Signed-off-by

Re: [RFC PATCH net-next 11/16] net: mscc: ocelot: set up logical port IDs centrally

2020-12-16 Thread Alexandre Belloni
On 08/12/2020 14:07:57+0200, Vladimir Oltean wrote: > The setup of logical port IDs is done in two places: from the inconclusively > named ocelot_setup_lag and from ocelot_port_lag_leave, a function that > also calls ocelot_setup_lag (which apparently does an incomplete setup > of the LAG). > > To

Re: [PATCH v4 net-next 3/5] net: dsa: Link aggregation support

2020-12-16 Thread Tobias Waldekranz
On Wed, Dec 16, 2020 at 20:44, Vladimir Oltean wrote: > On Wed, Dec 16, 2020 at 05:00:54PM +0100, Tobias Waldekranz wrote: >> diff --git a/net/dsa/dsa2.c b/net/dsa/dsa2.c >> index 183003e45762..deee4c0ecb31 100644 >> --- a/net/dsa/dsa2.c >> +++ b/net/dsa/dsa2.c >> @@ -21,6 +21,46 @@ >> static DEF

Re: [PATCH 0/7] Introduce vdpa management tool

2020-12-16 Thread Michael S. Tsirkin
On Wed, Dec 16, 2020 at 04:54:37PM +, Parav Pandit wrote: > > From: Jakub Kicinski > > Sent: Wednesday, December 16, 2020 9:36 PM > > > > On Wed, 16 Dec 2020 04:13:51 -0500 Michael S. Tsirkin wrote: > > > > > > 3. Why not use ioctl() interface? > > > > > > > > > > Obviously I'm gonna ask you

  1   2   3   >