KMSAN: uninit-value in xfrm_user_rcv_msg_compat

2021-01-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=17e7a0eb50 kernel config: https://syzkaller.appspot.co

Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-02 Thread Masahiro Yamada
On Sun, Jan 3, 2021 at 5:14 AM Valdis Klētnieks wrote: > > Consider the following own goal I just discovered I scored: > > [~] zgrep -i fq_codel /proc/config.gz > CONFIG_NET_SCH_FQ_CODEL=m > CONFIG_DEFAULT_FQ_CODEL=y > CONFIG_DEFAULT_NET_SCH="fq_codel" > > Obviously, fq_codel didn't get set as the

[PATCH iproute2-next v2] rdma: Add support for the netlink extack

2021-01-02 Thread Leon Romanovsky
From: Patrisious Haddad Add support in rdma for extack errors to be received in userspace when sent from kernel, so now netlink extack error messages sent from kernel would be printed for the user. Signed-off-by: Patrisious Haddad Signed-off-by: Leon Romanovsky --- David, Just as a note, rdma

Re: [PATCH iproute2-next] rdma: Add support for the netlink extack

2021-01-02 Thread Leon Romanovsky
On Thu, Dec 31, 2020 at 09:18:52AM -0700, David Ahern wrote: > On 12/30/20 10:42 PM, Leon Romanovsky wrote: > > diff --git a/rdma/utils.c b/rdma/utils.c > > index 2a201aa4..927e2107 100644 > > --- a/rdma/utils.c > > +++ b/rdma/utils.c > > @@ -664,7 +664,7 @@ void rd_prepare_msg(struct rd *rd, uint3

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-02 Thread Pali Rohár
Hello! On Sunday 03 January 2021 03:25:23 Thomas Schreiber wrote: > Hi Pali, > I have a CarlitoxxPro module and I reported an issue about RX_LOS pin > to the manufacturer. > It looks to me that the module asserts "inverted LOS" through EEPROM > but does not implement it. So, it is broken :-( But

Re: [PATCH 1/4] net: sfp: add workaround for Realtek RTL8672 and RTL9601C chips

2021-01-02 Thread Thomas Schreiber
Hi Pali, I have a CarlitoxxPro module and I reported an issue about RX_LOS pin to the manufacturer. It looks to me that the module asserts "inverted LOS" through EEPROM but does not implement it. Consequently, the SFP state machine of my host router stays in check los state and link is not set up f

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Martin Blumenstingl
Hi Andrew, On Sun, Jan 3, 2021 at 3:09 AM Andrew Lunn wrote: > > On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > > Without this the PHY link is detected properly and ethtool statistics > > for TX are i

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Andrew Lunn
On Sun, Jan 03, 2021 at 02:25:43AM +0100, Martin Blumenstingl wrote: > Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. > Without this the PHY link is detected properly and ethtool statistics > for TX are increasing but there's no RX traffic coming in. > > Fixes: 14fceff4771e51

Re: [PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access

2021-01-02 Thread Hauke Mehrtens
On 1/3/21 2:25 AM, Martin Blumenstingl wrote: There is one GSWIP_MII_CFG register for each switch-port except the CPU port. The register offset for the first port is 0x0, 0x02 for the second, 0x04 for the third and so on. Update the driver to not only restrict the GSWIP_MII_CFG registers to port

Re: [PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Hauke Mehrtens
On 1/3/21 2:25 AM, Martin Blumenstingl wrote: Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. Without this the PHY link is detected properly and ethtool statistics for TX are increasing but there's no RX traffic coming in. Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel

[PATCH 2/2] net: dsa: lantiq_gswip: Fix GSWIP_MII_CFG(p) register access

2021-01-02 Thread Martin Blumenstingl
There is one GSWIP_MII_CFG register for each switch-port except the CPU port. The register offset for the first port is 0x0, 0x02 for the second, 0x04 for the third and so on. Update the driver to not only restrict the GSWIP_MII_CFG registers to ports 0, 1 and 5. Handle ports 0..5 instead but skip

[PATCH 0/2] net: dsa: lantiq_gswip: two fixes for -net/-stable

2021-01-02 Thread Martin Blumenstingl
While testing the lantiq_gswip driver in OpenWrt at least one board had a non-working Ethernet port connected to an internal 100Mbit/s PHY22F GPHY. The problem which could be observed: - the PHY would detect the link just fine - ethtool stats would see the TX counter rise - the RX counter in ethtoo

[PATCH 1/2] net: dsa: lantiq_gswip: Enable GSWIP_MII_CFG_EN also for internal PHYs

2021-01-02 Thread Martin Blumenstingl
Enable GSWIP_MII_CFG_EN also for internal PHYs to make traffic flow. Without this the PHY link is detected properly and ethtool statistics for TX are increasing but there's no RX traffic coming in. Fixes: 14fceff4771e51 ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Cc: sta...@vger.kernel.

[PATCH v4 net RESEND] net/sonic: Fix some resource leaks in error handling paths

2021-01-02 Thread Finn Thain
From: Christophe JAILLET A call to dma_alloc_coherent() is wrapped by sonic_alloc_descriptors(). This is correctly freed in the remove function, but not in the error handling path of the probe function. Fix this by adding the missing dma_free_coherent() call. While at it, rename a label in orde

Re: [PATCH net] net: bareudp: add missing error handling for bareudp_link_config()

2021-01-02 Thread Cong Wang
On Wed, Dec 30, 2020 at 7:46 PM Jakub Kicinski wrote: > @@ -661,9 +662,14 @@ static int bareudp_newlink(struct net *net, struct > net_device *dev, > > err = bareudp_link_config(dev, tb); > if (err) > - return err; > + goto err_unconfig; > > retu

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2021-01-02 Thread Jiri Olsa
On Sat, Jan 02, 2021 at 02:25:34PM -0800, Andrii Nakryiko wrote: SNIP > > > > so your .config has > > CONFIG_CRYPTO_DEV_BCM_SPU=y > > > > and that defines 'struct device_private' which > > clashes with the same struct defined in drivers/base/base.h > > > > so several networking structs will be

Re: BTFIDS: FAILED unresolved symbol udp6_sock

2021-01-02 Thread Andrii Nakryiko
On Wed, Dec 30, 2020 at 5:28 AM Jiri Olsa wrote: > > On Wed, Dec 30, 2020 at 10:03:37AM +0100, Jiri Olsa wrote: > > On Tue, Dec 29, 2020 at 11:28:35PM +, Qais Yousef wrote: > > > Hi Jiri > > > > > > On 12/29/20 18:34, Jiri Olsa wrote: > > > > On Tue, Dec 29, 2020 at 03:13:52PM +, Qais Yous

[PATCH 1/2] dt-bindings: net: bluetooth: Add rtl8723ds-bluetooth

2021-01-02 Thread John-Eric Kamps
Add binding documentation for bluetooth part of RTL8723DS Signed-off-by: John-Eric Kamps --- Documentation/devicetree/bindings/net/realtek-bluetooth.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Docum

Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-02 Thread Valdis Klētnieks
Consider the following own goal I just discovered I scored: [~] zgrep -i fq_codel /proc/config.gz CONFIG_NET_SCH_FQ_CODEL=m CONFIG_DEFAULT_FQ_CODEL=y CONFIG_DEFAULT_NET_SCH="fq_codel" Obviously, fq_codel didn't get set as the default, because that happens before the module gets loaded (which may

Re: [PATCH iproute2 1/3] dcb: Set values with RTM_SETDCB type

2021-01-02 Thread Stephen Hemminger
On Sat, 2 Jan 2021 00:25:50 +0100 Petr Machata wrote: > dcb currently sends all netlink messages with a type RTM_GETDCB, even the > set ones. Change to the appropriate type. > > Signed-off-by: Petr Machata > --- > dcb/dcb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --g

Re: [PATCH 1/3] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-02 Thread Arseny Krasnov
> E.g. what you describe sounds like it will work but > won't allow pipelining more than one message in flight. You mean it will fail when two threads send concurrently using same socket? Yes, this problem could be fixed adding semaphore to send loop. > Support will probably need a feature bit, t

Re: [PATCH 2/3] vhost/vsock: support for SOCK_SEQPACKET socket.

2021-01-02 Thread Arseny Krasnov
> oh this was not threaded correctly so I did not see rest of > patches. ignore this pls will respond there. Sorry, i'll resend whole patchset ASAP in one thread. On 30.12.2020 23:58, Michael S. Tsirkin wrote: > On Wed, Dec 30, 2020 at 03:56:03PM -0500, Michael S. Tsirkin wrote: >> On Tue, Dec 29

memory leak in nfcmrvl_nci_register_dev

2021-01-02 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:dea8dcf2 Merge tag 'for-5.11/dm-fix' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15e2607750 kernel config: https://syzkaller.appspot.com/x/.config?x=f182e38c52a35dc6 das