Re: [PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-08 Thread Kurt Kanzenbach
On Sat Jan 09 2021, Vladimir Oltean wrote: > From: Vladimir Oltean > > The call path of a switchdev VLAN addition to the bridge looks something > like this today: > > nbp_vlan_init > | __br_vlan_set_default_pvid > | | | > | |br_afspec

[PATCH net-next] net: marvell: prestera: Correct typo

2021-01-08 Thread Florian Fainelli
The function was incorrectly named with a trailing 'r' at the end of prestera. Signed-off-by: Florian Fainelli --- Jakub, David, This patch is on top of Vladimir's series: [PATCH v4 net-next 00/11] Get rid of the switchdev transactional model .../net/ethernet/marvell/prestera/prestera_switchde

[PATCH] Revert "tcp: simplify window probe aborting on USER_TIMEOUT"

2021-01-08 Thread Enke Chen
From: Enke Chen This reverts commit 9721e709fa68ef9b860c322b474cfbd1f8285b0f. With the commit 9721e709fa68 ("tcp: simplify window probe aborting on USER_TIMEOUT"), the TCP session does not terminate with TCP_USER_TIMEOUT when data remain untransmitted due to zero window. The number of unanswere

Re: [PATCH] bus: mhi: Add inbound buffers allocation flag

2021-01-08 Thread Hemant Kumar
On 1/8/21 7:30 AM, Manivannan Sadhasivam wrote: On Fri, Jan 08, 2021 at 03:01:59PM +0100, Loic Poulain wrote: Hi Mani, On Fri, 8 Jan 2021 at 14:44, Manivannan Sadhasivam < manivannan.sadhasi...@linaro.org> wrote: On Wed, Jan 06, 2021 at 02:43:43PM +0100, Loic Poulain wrote: Currently, the

RE

2021-01-08 Thread General Leigh Ann Hester
Hi, How are you doing, i hope all is well with you? I would like to hear from you very urgently because I have an important issue to discuss with you. So contact me with this email address as follows: (hesterleighann...@gmail.com) for more information. Thanks, General Leigh Ann Hester.

Re: [PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > The call path of a switchdev VLAN addition to the bridge looks something > like this today: > > nbp_vlan_init > | __br_vlan_set_default_pvid > | | | > | |br_afs

Re: [PATCH v4 net-next 02/11] net: dsa: mv88e6xxx: deny vid 0 on the CPU port and DSA links too

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > mv88e6xxx apparently has a problem offloading VID 0, which the 8021q > module tries to install as part of commit ad1afb003939 ("vlan_dev: VLAN > 0 should be treated as "no vlan tag" (802.1p packet)"). That mv88e6xxx > rest

Re: [PATCH v3 net-next 10/10] net: mscc: ocelot: configure watermarks using devlink-sb

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Using devlink-sb, we can configure 12/16 (the important 75%) of the > switch's controlling watermarks for congestion drops, and we can monitor > 50% of the watermark occupancies (we can monitor the reservation > watermarks

Re: [PATCH v3 net-next 09/10] net: mscc: ocelot: initialize watermarks to sane defaults

2021-01-08 Thread Florian Fainelli
On 1/8/2021 9:59 AM, Vladimir Oltean wrote: > From: Vladimir Oltean > > This is meant to be a gentle introduction into the world of watermarks > on ocelot. The code is placed in ocelot_devlink.c because it will be > integrated with devlink, even if it isn't right now. > > My first step was in

Re: [PATCH net 0/3] net: fix issues around register_netdevice() failures

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (refs/heads/master): On Wed, 6 Jan 2021 10:40:04 -0800 you wrote: > This series attempts to clean up the life cycle of struct > net_device. Dave has added dev->needs_free_netdev in the > past to fix double frees, we can lean on that mechanism > a

Re: [PATCH net-next] ppp: clean up endianness conversions

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 7 Jan 2021 15:39:56 +0100 you wrote: > sparse complains about some harmless endianness issues: > > > drivers/net/ppp/pptp.c:281:21: warning: incorrect type in assignment > > (different base types) > > drivers/net

Re: [PATCH net-next] net: ip_tunnel: clean up endianness conversions

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 7 Jan 2021 15:40:08 +0100 you wrote: > sparse complains about some harmless endianness issues: > > > net/ipv4/ip_tunnel_core.c:225:43: warning: cast to restricted __be16 > > net/ipv4/ip_tunnel_core.c:225:43: warni

Re: [PATCH net v3] ppp: fix refcount underflow on channel unbridge

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 21:57:50 +0100 Guillaume Nault wrote: > On Thu, Jan 07, 2021 at 06:13:15PM +, Tom Parkin wrote: > > When setting up a channel bridge, ppp_bridge_channels sets the > > pch->bridge field before taking the associated reference on the bridge > > file instance. > > > > This opens

Re: [PATCH V2 net-next 3/3] MAINTAINERS: add bgmac section entry

2021-01-08 Thread Jakub Kicinski
On Thu, 7 Jan 2021 12:08:58 -0800 Florian Fainelli wrote: > On 1/7/21 10:00 AM, Rafał Miłecki wrote: > > From: Rafał Miłecki > > > > This driver exists for years but was missing its MAINTAINERS entry. > > > > Signed-off-by: Rafał Miłecki > > Acked-by: Florian Fainelli Applied, thanks!

Re: [PATCH] udp: Prevent reuseport_select_sock from reading uninitialized socks

2021-01-08 Thread Jakub Kicinski
On Thu, 7 Jan 2021 00:27:07 -0500 Willem de Bruijn wrote: > On Thu, Jan 7, 2021 at 12:11 AM Baptiste Lepers > wrote: > > > > reuse->socks[] is modified concurrently by reuseport_add_sock. To > > prevent reading values that have not been fully initialized, only read > > the array up until the last

Re: [PATCH net v3] net: fix use-after-free when UDP GRO with shared fraglist

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 11:18:39 +0100 Daniel Borkmann wrote: > On 1/8/21 3:28 AM, Dongseok Yi wrote: > > skbs in fraglist could be shared by a BPF filter loaded at TC. If TC > > writes, it will call skb_ensure_writable -> pskb_expand_head to create > > a private linear section for the head_skb. And the

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Don Dutile
On 1/8/21 4:09 PM, Bjorn Helgaas wrote: On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: On 1/7/21 7:57 PM, Bjorn Helgaas wrote: On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: + **/ +int pci_set_msix_vec_count(struct pci_dev *dev, int numb) +{ + struct pci_de

[PATCH net V2] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-08 Thread Ayush Sawal
TID stuck is seen when there is a race in CPL_PASS_ACCEPT_RPL/CPL_ABORT_REQ and abort is arriving before the accept reply, which sets the queue number. In this case HW ends up sending CPL_ABORT_RPL_RSS to an incorrect ingress queue. V1->V2: - Removed the unused variable len in chtls_set_quiesce_ct

[PATCH net-next 0/2] Introduce XDP_FLAGS_NO_TX flag

2021-01-08 Thread Charlie Somerville
This patch series introduces a new flag XDP_FLAGS_NO_TX which prevents the allocation of additional send queues for XDP programs. Included in this patch series is an implementation of XDP_FLAGS_NO_TX for the virtio_net driver. This flag is intended to be advisory - not all drivers must implement s

[PATCH net-next 2/2] virtio_net: Implement XDP_FLAGS_NO_TX support

2021-01-08 Thread Charlie Somerville
No send queues will be allocated for XDP filters. Attempts to transmit packets when no XDP send queues exist will fail with EOPNOTSUPP. Signed-off-by: Charlie Somerville --- drivers/net/virtio_net.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/ne

[PATCH net-next 1/2] xdp: Add XDP_FLAGS_NO_TX flag

2021-01-08 Thread Charlie Somerville
Some network interfaces must allocate additional hardware resources to support XDP filters retransmitting packets with XDP_TX. However not all XDP filters do use XDP_TX, and there may not be any additional send queues available for use. XDP filters can indicate that they will never transmit by se

Re: [PATCH net] net: ipa: modem: add missing SET_NETDEV_DEV() for proper sysfs links

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 6 Jan 2021 11:07:55 +0100 you wrote: > At the moment it is quite hard to identify the network interface > provided by IPA in userspace components: The network interface is > created as virtual device, without any link t

Re: [PATCH net-next 0/2] Update register/bit definitions in the EtherAVB driver

2021-01-08 Thread Jakub Kicinski
On Wed, 6 Jan 2021 23:30:42 +0300 Sergey Shtylyov wrote: > Here are 2 patches against DaveM's 'net-next' repo. I'm updating the driver > to match > the recent R-Car gen2/3 manuals... Applied, thanks, but I dropped the Fixes tag from patch 1. Patch which makes no functional changes can't be fixing

Re: [PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 21:27:27 +0100 Leon Schuermann wrote: > This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to > work with the cdc_ether driver. When you say "used to work" do you mean there was a regression where the older kernels would work fine and newer don't? Or just "it wo

Re: [PATCH net] cxgb4/chtls: Fix tid stuck due to wrong update of qid

2021-01-08 Thread Jakub Kicinski
On Fri, 8 Jan 2021 23:29:14 +0530 Ayush Sawal wrote: > +void chtls_set_quiesce_ctrl(struct sock *sk, int val) > +{ > + struct chtls_sock *csk; > + struct sk_buff *skb; > + unsigned int wrlen; > + unsigned int len; > + int ret; > + > + wrlen = sizeof(struct cpl_set_tcb_field

Re: [PATCH bpf-next v6 2/3] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt

2021-01-08 Thread Martin KaFai Lau
On Fri, Jan 08, 2021 at 01:02:22PM -0800, Stanislav Fomichev wrote: > When we attach a bpf program to cgroup/getsockopt any other getsockopt() > syscall starts incurring kzalloc/kfree cost. > > Let add a small buffer on the stack and use it for small (majority) > {s,g}etsockopt values. The buffer

Re: [PATCH v4 net-next 05/11] net: switchdev: remove the transaction structure from port attributes

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Since the introduction of the switchdev API, port attributes were > transmitted to drivers for offloading using a two-step transactional > model, with a prepare phase that was supposed to catch all errors, and a > commit p

Re: [PATCH v4 net-next 10/11] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects

2021-01-08 Thread Florian Fainelli
On 1/8/2021 4:01 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning > errors in commit phase"), the mlxsw driver performs the VLAN object > offloading during the prepare phase. So conversion just seems to be a > matter

Re: [PATCH net-next] net: dsa: dsa_legacy_fdb_{add,del} can be static

2021-01-08 Thread Florian Fainelli
On 1/8/2021 3:30 PM, Vladimir Oltean wrote: > From: Vladimir Oltean > > Introduced in commit 37b8da1a3c68 ("net: dsa: Move FDB add/del > implementation inside DSA") in net/dsa/legacy.c, these functions were > moved again to slave.c as part of commit 2a93c1a3651f ("net: dsa: Allow > compiling o

Re: [PATCH v5 net-next 15/16] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-08 Thread Jakub Kicinski
Sparse says that you... On Fri, 8 Jan 2021 18:31:58 +0200 Vladimir Oltean wrote: > + rcu_read_lock(); > + > + bond_for_each_slave_rcu(bond, slave, iter) { > + struct bonding_slave_dev *s; > + > + s = kzalloc(sizeof(*s), GFP_ATOMIC); > + if (!s) { > +

Re: [PATCH bpf-next v6 1/3] bpf: remove extra lock_sock for TCP_ZEROCOPY_RECEIVE

2021-01-08 Thread Martin KaFai Lau
On Fri, Jan 08, 2021 at 01:02:21PM -0800, Stanislav Fomichev wrote: > Add custom implementation of getsockopt hook for TCP_ZEROCOPY_RECEIVE. > We skip generic hooks for TCP_ZEROCOPY_RECEIVE and have a custom > call in do_tcp_getsockopt using the on-stack data. This removes > 3% overhead for locking

Re: [RFC PATCH v2 net-next 00/12] Make .ndo_get_stats64 sleepable

2021-01-08 Thread Jacob Keller
On 1/6/2021 5:45 AM, Vladimir Oltean wrote: > On Tue, Jan 05, 2021 at 08:58:50PM +0200, Vladimir Oltean wrote: >> This is marked as Request For Comments for a reason. > > If nobody has any objections, I will remove the memory leaks I > introduced to check if anybody is paying attention, and I w

[PATCH v2 3/3] hv_netvsc: Process NETDEV_GOING_DOWN on VF hot remove

2021-01-08 Thread Long Li
From: Long Li On VF hot remove, NETDEV_GOING_DOWN is sent to notify the VF is about to go down. At this time, the VF is still sending/receiving traffic and we request the VSP to switch datapath. On completion, the datapath is switched to synthetic and we can proceed with VF hot remove. Signed-o

[PATCH v2 2/3] hv_netvsc: Wait for completion on request SWITCH_DATA_PATH

2021-01-08 Thread Long Li
From: Long Li The completion indicates if NVSP_MSG4_TYPE_SWITCH_DATA_PATH has been processed by the VSP. The traffic is steered to VF or synthetic after we receive this completion. Signed-off-by: Long Li Reported-by: kernel test robot --- Change from v1: Fixed warnings from kernel test robot.

[PATCH v2 1/3] hv_netvsc: Check VF datapath when sending traffic to VF

2021-01-08 Thread Long Li
From: Long Li The driver needs to check if the datapath has been switched to VF before sending traffic to VF. Signed-off-by: Long Li Reviewed-by: Haiyang Zhang --- drivers/net/hyperv/netvsc_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_d

[PATCH v2 0/3] hv_netvsc: Prevent packet loss during VF add/remove

2021-01-08 Thread Long Li
From: Long Li This patch set fixes issues with packet loss on VF add/remove. Long Li (3): hv_netvsc: Check VF datapath when sending traffic to VF hv_netvsc: Wait for completion on request SWITCH_DATA_PATH hv_netvsc: Process NETDEV_GOING_DOWN on VF hot remove drivers/net/hyperv/netvsc.c

[PATCH net-next 1/8] mptcp: add the address ID assignment bitmap

2021-01-08 Thread Mat Martineau
From: Geliang Tang Currently the address ID set by the netlink PM from user-space is overridden by the kernel. This patch added the address ID assignment bitmap to allow user-space to set the address ID. Use a per netns bitmask id_bitmap (256 bits) to keep track of in-use IDs. And use next_id to

[PATCH net-next 3/8] mptcp: add the outgoing MP_PRIO support

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added the outgoing MP_PRIO logic: In mptcp_pm_nl_mp_prio_send_ack, find the related subflow and subsocket according to the input parameter addr. Save the input priority value to suflow's backup, then set subflow's send_mp_prio flag to true, and save the input priori

[PATCH net-next 8/8] selftests: mptcp: add the MP_PRIO testcases

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added the MP_PRIO testcases: Add a new argument bkup for run_tests and do_transfer, it can be set as "backup" or "nobackup", the default value is "". Add a new function chk_prio_nr to check the MP_PRIO related MIB counters. The output looks like this: 29 single s

[PATCH net-next 5/8] mptcp: add set_flags command in PM netlink

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added a new command MPTCP_PM_CMD_SET_FLAGS in PM netlink: In mptcp_nl_cmd_set_flags, parse the input address, get the backup value according to whether the address's FLAG_BACKUP flag is set from the user-space. Then check whether this address had been added in the l

[PATCH net-next 2/8] selftests: mptcp: add testcases for setting the address ID

2021-01-08 Thread Mat Martineau
From: Geliang Tang Since the address ID can be set from user-space, some of the tests in pm_netlink.sh will fail. This patch fixed the failures, and add the testcases for setting the address ID. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- .../testing/selftests/net/mptcp/pm_ne

[PATCH net-next 0/8] MPTCP: Add MP_PRIO support and rework local address IDs

2021-01-08 Thread Mat Martineau
Here are some patches we've merged in the MPTCP tree that are ready for net-next. Patches 1 and 2 rework the assignment of local address IDs to allow them to be assigned by a userspace path manager, and add corresponding self tests. Patches 2-8 add the ability to change subflow priority after a s

[PATCH net-next 7/8] mptcp: add the mibs for MP_PRIO

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added the mibs for MP_PRIO, MPTCP_MIB_MPPRIOTX for transmitting of the MP_PRIO suboption, and MPTCP_MIB_MPPRIORX for receiving of it. Signed-off-by: Geliang Tang Signed-off-by: Mat Martineau --- net/mptcp/mib.c| 2 ++ net/mptcp/mib.h| 2 ++ net/mp

[PATCH net-next 4/8] mptcp: add the incoming MP_PRIO support

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added the incoming MP_PRIO logic: Added a flag named mp_prio in struct mptcp_options_received, to mark the MP_PRIO is received, and save the priority value to struct mptcp_options_received's backup member. Then invoke mptcp_pm_mp_prio_received with the receiving sub

[PATCH net-next 6/8] selftests: mptcp: add set_flags command in pm_nl_ctl

2021-01-08 Thread Mat Martineau
From: Geliang Tang This patch added the set_flags command in pm_nl_ctl, currently we can only set two flags: backup and nobackup. The set_flags command can be used like this: # pm_nl_ctl set 10.0.0.1 flags backup # pm_nl_ctl set 10.0.0.1 flags nobackup Signed-off-by: Geliang Tang Signed-off-

Re: [PATCH net-next] net: dsa: dsa_legacy_fdb_{add,del} can be static

2021-01-08 Thread Andrew Lunn
On Sat, Jan 09, 2021 at 01:30:54AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Introduced in commit 37b8da1a3c68 ("net: dsa: Move FDB add/del > implementation inside DSA") in net/dsa/legacy.c, these functions were > moved again to slave.c as part of commit 2a93c1a3651f ("net: dsa: A

Re: MDIO over I2C driver driver probe dependency issue

2021-01-08 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 02:11:31PM -0800, Florian Fainelli wrote: > On 1/8/2021 1:04 PM, Andrew Lunn wrote: > > On Fri, Jan 08, 2021 at 03:02:52PM -0500, Brian Silverman wrote: > >> Thanks for the responses - I now have a more clear picture of what's going > >> on. > >>  (Note: I'm using Xilinx's

Re: MDIO over I2C driver driver probe dependency issue

2021-01-08 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 02:11:31PM -0800, Florian Fainelli wrote: > > > On 1/8/2021 1:04 PM, Andrew Lunn wrote: > > On Fri, Jan 08, 2021 at 03:02:52PM -0500, Brian Silverman wrote: > >> Thanks for the responses - I now have a more clear picture of what's going > >> on. > >>  (Note: I'm using Xil

Re: [PATCH v7 net-next 2/2] net: dsa: qca: ar9331: export stats64

2021-01-08 Thread Vladimir Oltean
On Fri, Jan 08, 2021 at 06:32:28AM +0100, Oleksij Rempel wrote: > May be the "net: dsa: add optional stats64 support" can already be > taken? I'm not sure that I see the point. David and Jakub won't cherry-pick partial series, and if you resend just patch 1/2, they won't accept new code that doesn

[PATCH v4 net-next 01/11] net: switchdev: remove vid_begin -> vid_end range from VLAN objects

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean The call path of a switchdev VLAN addition to the bridge looks something like this today: nbp_vlan_init | __br_vlan_set_default_pvid | | | | |br_afspec | | || | | |

[PATCH v4 net-next 09/11] net: dsa: remove obsolete comments about switchdev transactions

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Now that all port object notifiers were converted to be non-transactional, we can remove the comments that say otherwise. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Acked-by: Linus Walleij Acked-by: Jiri Pirko --- Changes in v4: None. Changes in v3: N

[PATCH v4 net-next 11/11] net: switchdev: delete the transaction object

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Now that all users of struct switchdev_trans have been modified to do without it, we can remove this structure and the two helpers to determine the phase. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Reviewed-by: Ido Schimmel Acked-by: Linus Walleij Acke

[PATCH v4 net-next 08/11] net: dsa: remove the transactional logic from VLAN objects

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean It should be the driver's business to logically separate its VLAN offloading into a preparation and a commit phase, and some drivers don't need / can't do this. So remove the transactional shim from DSA and let drivers propagate errors directly from the .port_vlan_add callb

[PATCH v4 net-next 10/11] mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean As of commit 457e20d65924 ("mlxsw: spectrum_switchdev: Avoid returning errors in commit phase"), the mlxsw driver performs the VLAN object offloading during the prepare phase. So conversion just seems to be a matter of removing the code that was running in the commit phase.

[PATCH v4 net-next 07/11] net: dsa: remove the transactional logic from MDB entries

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean For many drivers, the .port_mdb_prepare callback was not a good opportunity to avoid any error condition, and they would suppress errors found during the actual commit phase. Where a logical separation between the prepare and the commit phase existed, the function that used

[PATCH v4 net-next 05/11] net: switchdev: remove the transaction structure from port attributes

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Since the introduction of the switchdev API, port attributes were transmitted to drivers for offloading using a two-step transactional model, with a prepare phase that was supposed to catch all errors, and a commit phase that was supposed to never fail. Some classes of fail

[PATCH v4 net-next 06/11] net: dsa: remove the transactional logic from ageing time notifiers

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Remove the shim introduced in DSA for offloading the bridge ageing time from switchdev, by first checking whether the ageing time is within the range limits requested by the driver. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Acked-by: Linus Walleij Acke

[PATCH v4 net-next 04/11] net: switchdev: delete switchdev_port_obj_add_now

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean After the removal of the transactional model inside switchdev_port_obj_add_now, it has no added value and we can just call switchdev_port_obj_notify directly, bypassing this function. Let's delete it. Signed-off-by: Vladimir Oltean Reviewed-by: Florian Fainelli Reviewed-b

[PATCH v4 net-next 00/11] Get rid of the switchdev transactional model

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Changes in v4: - Fixed build error in dsa_loop and build warning in hellcreek driver. - Scheduling the mlxsw SPAN work item regardless of the VLAN add return code, as per Ido's and Petr's request. Changes in v3: - Resolved a build warning in mv88e6xxx and tested that it a

[PATCH v4 net-next 03/11] net: switchdev: remove the transaction structure from port object notifiers

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Since the introduction of the switchdev API, port objects were transmitted to drivers for offloading using a two-step transactional model, with a prepare phase that was supposed to catch all errors, and a commit phase that was supposed to never fail. Some classes of failure

[PATCH v4 net-next 02/11] net: dsa: mv88e6xxx: deny vid 0 on the CPU port and DSA links too

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean mv88e6xxx apparently has a problem offloading VID 0, which the 8021q module tries to install as part of commit ad1afb003939 ("vlan_dev: VLAN 0 should be treated as "no vlan tag" (802.1p packet)"). That mv88e6xxx restriction seems to have been introduced by the "VTU GetNext V

Re: [PATCH net 2/3] net: compound page support in skb_seq_read

2021-01-08 Thread Willem de Bruijn
On Fri, Jan 8, 2021 at 12:11 PM Willem de Bruijn wrote: > > From: Willem de Bruijn > > skb_seq_read iterates over an skb, returning pointer and length of > the next data range with each call. > > It relies on kmap_atomic to access highmem pages when needed. > > An skb frag may be backed by a comp

[PATCH net-next] net: dsa: dsa_legacy_fdb_{add,del} can be static

2021-01-08 Thread Vladimir Oltean
From: Vladimir Oltean Introduced in commit 37b8da1a3c68 ("net: dsa: Move FDB add/del implementation inside DSA") in net/dsa/legacy.c, these functions were moved again to slave.c as part of commit 2a93c1a3651f ("net: dsa: Allow compiling out legacy support"), before actually deleting net/dsa/slave

Re: [PATCH net 3/3] net-sysfs: move the xps cpus/rxqs retrieval in a common function

2021-01-08 Thread Antoine Tenart
Quoting Alexander Duyck (2021-01-08 23:04:57) > On Fri, Jan 8, 2021 at 10:58 AM Antoine Tenart wrote: > > > > Quoting Alexander Duyck (2021-01-08 17:33:01) > > > On Fri, Jan 8, 2021 at 1:07 AM Antoine Tenart wrote: > > > > > > > > Quoting Alexander Duyck (2021-01-07 17:38:35) > > > > > On Thu, Ja

Re: MDIO over I2C driver driver probe dependency issue

2021-01-08 Thread Brian Silverman
Thanks - I will have to keep a local patch to fix this for my needs for the time being. If in the future if I'm able to do something better (e.g. with a better fw_devlink, which looks interesting), I'll post a patch. But I generally lag the latest kernels by a couple years, so... not any time so

Re: [PATCH RESEND v2 1/3] bpf,x64: pad NOPs to make images converge more easily

2021-01-08 Thread Daniel Borkmann
On 1/7/21 3:16 AM, Gary Lin wrote: The x64 bpf jit expects bpf images converge within the given passes, but it could fail to do so with some corner cases. For example: l0: ja 40 l1: ja 40 [... repeated ja 40 ] l39:ja 40 l40:ret #0 This bpf

Re: [PATCH V2 net-next 2/3] net: broadcom: share header defining UniMAC registers

2021-01-08 Thread Doug Berger
On 1/7/2021 10:00 AM, Rafał Miłecki wrote: > From: Rafał Miłecki > > UniMAC is integrated into multiple Broadcom's Ethernet controllers so > use a shared header file for it and avoid some code duplication. > > Signed-off-by: Rafał Miłecki > Acked-by: Florian Fainelli > --- > V2: Open code (n <

Re: MDIO over I2C driver driver probe dependency issue

2021-01-08 Thread Florian Fainelli
On 1/8/2021 1:04 PM, Andrew Lunn wrote: > On Fri, Jan 08, 2021 at 03:02:52PM -0500, Brian Silverman wrote: >> Thanks for the responses - I now have a more clear picture of what's going >> on. >>  (Note: I'm using Xilinx's 2019.2 kernel (based off 4.19).  I believe it >> would >> be similar to

[PATCH v2 bpf-next 1/7] bpf: add bpf_patch_call_args prototype to include/linux/bpf.h

2021-01-08 Thread Andrii Nakryiko
Add bpf_patch_call_args() prototype. This function is called from BPF verifier and only if CONFIG_BPF_JIT_ALWAYS_ON is not defined. This fixes compiler warning about missing prototype in some kernel configurations. Reported-by: kernel test robot Fixes: 1ea47e01ad6e ("bpf: add support for bpf_call

[PATCH v2 bpf-next 6/7] libbpf: support kernel module ksym externs

2021-01-08 Thread Andrii Nakryiko
Add support for searching for ksym externs not just in vmlinux BTF, but across all module BTFs, similarly to how it's done for CO-RE relocations. Kernels that expose module BTFs through sysfs are assumed to support new ldimm64 instruction extension with BTF FD provided in insn[1].imm field, so no e

[PATCH v2 bpf-next 7/7] selftests/bpf: test kernel module ksym externs

2021-01-08 Thread Andrii Nakryiko
Add per-CPU variable to bpf_testmod.ko and use those from new selftest to validate it works end-to-end. Signed-off-by: Andrii Nakryiko --- .../selftests/bpf/bpf_testmod/bpf_testmod.c | 3 ++ .../selftests/bpf/prog_tests/ksyms_module.c | 33 +++ .../selftests/bpf/progs/test_k

[PATCH v2 bpf-next 4/7] selftests/bpf: sync RCU before unloading bpf_testmod

2021-01-08 Thread Andrii Nakryiko
If some of the subtests use module BTFs through ksyms, they will cause bpf_prog to take a refcount on bpf_testmod module, which will prevent it from successfully unloading. Module's refcnt is decremented when bpf_prog is freed, which generally happens in RCU callback. So we need to trigger syncroni

[PATCH v2 bpf-next 5/7] bpf: support BPF ksym variables in kernel modules

2021-01-08 Thread Andrii Nakryiko
Add support for directly accessing kernel module variables from BPF programs using special ldimm64 instructions. This functionality builds upon vmlinux ksym support, but extends ldimm64 with src_reg=BPF_PSEUDO_BTF_ID to allow specifying kernel module BTF's FD in insn[1].imm field. During BPF progr

[PATCH v2 bpf-next 3/7] bpf: declare __bpf_free_used_maps() unconditionally

2021-01-08 Thread Andrii Nakryiko
__bpf_free_used_maps() is always defined in kernel/bpf/core.c, while include/linux/bpf.h is guarding it behind CONFIG_BPF_SYSCALL. Move it out of that guard region and fix compiler warning. Reported-by: kernel test robot Fixes: a2ea07465c8d ("bpf: Fix missing prog untrack in release_maps") Signed

[PATCH v2 bpf-next 2/7] bpf: avoid warning when re-casting __bpf_call_base into __bpf_call_base_args

2021-01-08 Thread Andrii Nakryiko
BPF interpreter uses extra input argument, so re-casts __bpf_call_base into __bpf_call_base_args. Avoid compiler warning about incompatible function prototypes by casting to void * first. Reported-by: kernel test robot Fixes: 1ea47e01ad6e ("bpf: add support for bpf_call to interpreter") Signed-of

[PATCH v2 bpf-next 0/7] Support kernel module ksym variables

2021-01-08 Thread Andrii Nakryiko
Add support for using kernel module global variables (__ksym externs in BPF program). BPF verifier will now support ldimm64 with src_reg=BPF_PSEUDO_BTF_ID and non-zero insn[1].imm field, specifying module BTF's FD. In such case, module BTF object, similarly to BPF maps referenced from ldimm64 with

Re: [PATCH net 3/3] net-sysfs: move the xps cpus/rxqs retrieval in a common function

2021-01-08 Thread Alexander Duyck
On Fri, Jan 8, 2021 at 10:58 AM Antoine Tenart wrote: > > Quoting Alexander Duyck (2021-01-08 17:33:01) > > On Fri, Jan 8, 2021 at 1:07 AM Antoine Tenart wrote: > > > > > > Quoting Alexander Duyck (2021-01-07 17:38:35) > > > > On Thu, Jan 7, 2021 at 12:54 AM Antoine Tenart > > > > wrote: > > >

Re: [net-next 09/15] net/mlx5e: CT: Support offload of +trk+new ct rules

2021-01-08 Thread Marcelo Ricardo Leitner
Hi, On Thu, Jan 07, 2021 at 09:30:48PM -0800, Saeed Mahameed wrote: > @@ -1429,6 +1600,14 @@ mlx5_tc_ct_add_ft_cb(struct mlx5_tc_ct_priv *ct_priv, > u16 zone, > if (err) > goto err_insert; > > + nf_ct_zone_init(&ctzone, zone, NF_CT_DEFAULT_ZONE_DIR, 0); > + ft->tmpl

Re: [PATCH v3 bpf-next 2/4] bpf: allow bpf_d_path in sleepable bpf_iter program

2021-01-08 Thread KP Singh
On Thu, Jan 7, 2021 at 5:23 AM Song Liu wrote: > > task_file and task_vma iter programs have access to file->f_path. Enable > bpf_d_path to print paths of these file. > > bpf_iter programs are generally called in sleepable context. However, it > is still necessary to diffientiate sleepable and non

RE: [net-next 15/19] can: tcan4x5x: rework SPI access

2021-01-08 Thread David Laight
From: Marc Kleine-Budde > Sent: 07 January 2021 21:17 > > On 1/7/21 8:06 PM, Jakub Kicinski wrote: > > On Thu, 7 Jan 2021 11:00:35 -0800 Jakub Kicinski wrote: > >> On Thu, 7 Jan 2021 10:48:56 +0100 Marc Kleine-Budde wrote: > >>> +struct __packed tcan4x5x_map_buf { > >>> + struct tcan4x5x_buf_cmd

Re: [net-next 08/15] net/mlx5e: CT: Preparation for offloading +trk+new ct rules

2021-01-08 Thread Marcelo Ricardo Leitner
Hi, On Thu, Jan 07, 2021 at 09:30:47PM -0800, Saeed Mahameed wrote: > From: Roi Dayan > > Connection tracking associates the connection state per packet. The > first packet of a connection is assigned with the +trk+new state. The > connection enters the established state once a packet is seen on

[net] selftests/tls: fix selftests after adding ChaCha20-Poly1305

2021-01-08 Thread Vadim Fedorenko
TLS selftests where broken because of wrong variable types used. Fix it by changing u16 -> uint16_t Fixes: 4f336e88a870 ("selftests/tls: add CHACHA20-POLY1305 to tls selftests") Reported-by: kernel test robot Signed-off-by: Vadim Fedorenko --- tools/testing/selftests/net/tls.c | 4 ++-- 1 file

Re: Flaw in "random32: update the net random state on interrupt and activity"

2021-01-08 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 4:41 PM Eric Dumazet wrote: > > On Fri, Jan 8, 2021 at 2:51 PM Sedat Dilek wrote: > > > > On Fri, Jan 8, 2021 at 2:08 PM Sedat Dilek wrote: > > > > > > On Wed, Aug 12, 2020 at 6:25 PM Eric Dumazet wrote: > > > > > > > > Also, I tried the diff for tcp_conn_request... > > >

Re: [PATCH mlx5-next 1/4] PCI: Configure number of MSI-X vectors for SR-IOV VFs

2021-01-08 Thread Bjorn Helgaas
On Thu, Jan 07, 2021 at 10:54:38PM -0500, Don Dutile wrote: > On 1/7/21 7:57 PM, Bjorn Helgaas wrote: > > On Sun, Jan 03, 2021 at 10:24:37AM +0200, Leon Romanovsky wrote: > > > + **/ > > > +int pci_set_msix_vec_count(struct pci_dev *dev, int numb) > > > +{ > > > + struct pci_dev *pdev = pci_physfn

Re: MDIO over I2C driver driver probe dependency issue

2021-01-08 Thread Andrew Lunn
On Fri, Jan 08, 2021 at 03:02:52PM -0500, Brian Silverman wrote: > Thanks for the responses - I now have a more clear picture of what's going on. >  (Note: I'm using Xilinx's 2019.2 kernel (based off 4.19).  I believe it would > be similar to latest kernels, but I could be wrong.) Hi Brian macb_m

Re: [PATCH net v3] ppp: fix refcount underflow on channel unbridge

2021-01-08 Thread Guillaume Nault
On Thu, Jan 07, 2021 at 06:13:15PM +, Tom Parkin wrote: > When setting up a channel bridge, ppp_bridge_channels sets the > pch->bridge field before taking the associated reference on the bridge > file instance. > > This opens up a refcount underflow bug if ppp_bridge_channels called > via. iot

Re: UBSAN: object-size-mismatch in wg_xmit

2021-01-08 Thread Nathan Chancellor
On Fri, Jan 08, 2021 at 10:33:19AM +0100, Dmitry Vyukov wrote: > On Thu, Jan 7, 2021 at 8:06 PM Jeffrey Walton wrote: > > > > On Thu, Jan 7, 2021 at 2:03 PM Jason A. Donenfeld wrote: > > > > > > On Thu, Jan 7, 2021 at 1:22 PM Dmitry Vyukov wrote: > > > > > > > > On Mon, Dec 21, 2020 at 12:23 PM

[PATCH 0/1] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-08 Thread Leon Schuermann
Hi, this patch resolves an issue with my Lenovo USB-C Hub with an integrated Realtek USB Ethernet controller. When suspending my host system, along with an active Ethernet link using the Realtek USB Ethernet adapter on a somewhat busy network, after a few minutes the NIC would start to constantly

[PATCH 1/1] r8152: Add Lenovo Powered USB-C Travel Hub

2021-01-08 Thread Leon Schuermann
This USB-C Hub (17ef:721e) based on the Realtek RTL8153B chip used to work with the cdc_ether driver. However, using this driver, with the system suspended the device sends pause-frames as soon as the receive buffer fills up. This produced substantial network load, up to the point where some Ethern

Re: [GIT PULL] Networking for 5.11-rc3

2021-01-08 Thread pr-tracker-bot
The pull request you sent on Thu, 7 Jan 2021 21:00:59 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git > tags/net-5.11-rc3-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6279d812eab67a6df6b22fa495201db6f2305924 Thank you! -- Deet-doot-dot, I

Re: [PATCH net-next v1 1/2] net: core: count drops from GRO

2021-01-08 Thread Saeed Mahameed
On Fri, 2021-01-08 at 11:21 -0800, Shannon Nelson wrote: > On 1/8/21 10:26 AM, Jesse Brandeburg wrote: > > Shannon Nelson wrote: > > > > > On 1/6/21 1:55 PM, Jesse Brandeburg wrote: > > > > When drivers call the various receive upcalls to receive an skb > > > > to the stack, sometimes that stack c

Re: [PATCH] selftests/bpf: remove duplicate include in test_lsm

2021-01-08 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 5 Jan 2021 07:20:47 -0800 you wrote: > From: Menglong Dong > > 'unistd.h' included in 'selftests/bpf/prog_tests/test_lsm.c' is > duplicated. > > Signed-off-by: Menglong Dong > > [...] Here is the summary with li

Re: [PATCH v3 net-next 10/12] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-08 Thread Vladimir Oltean
On Fri, Jan 08, 2021 at 11:38:57AM -0800, Saeed Mahameed wrote: > Let me take a look at the current series, and if I see that the > rcu/dev_hold approach is more lightweight then i will suggest it to > Vladimir and he can make the final decision. The last version does use temporary RCU protection.

Re: [PATCH net 2/2] net: ipa: re-enable NAPI before enabling interrupt

2021-01-08 Thread Alex Elder
On 1/7/21 8:38 PM, Jakub Kicinski wrote: On Thu, 7 Jan 2021 15:43:25 -0600 Alex Elder wrote: @@ -743,21 +743,21 @@ static void gsi_channel_freeze(struct gsi_channel *channel) set_bit(GSI_CHANNEL_FLAG_STOPPING, channel->flags); smp_mb__after_atomic(); /* Ensure gsi_channel_poll(

[PATCH] net: phy: micrel: reconfigure the phy on resume

2021-01-08 Thread Claudiu Beznea
KSZ9131 is used in setups with SAMA7G5. SAMA7G5 supports a special power saving mode (backup mode) that cuts the power for almost all parts of the SoC. The rail powering the ethernet PHY is also cut off. When resuming, in case the PHY has been configured on probe with slew rate or DLL settings thes

[PATCH bpf-next] libbpf: clarify kernel type use with USER variants of CORE reading macros

2021-01-08 Thread Andrii Nakryiko
Add comments clarifying that USER variants of CO-RE reading macro are still only going to work with kernel types, defined in kernel or kernel module BTF. This should help preventing invalid use of those macro to read user-defined types (which doesn't work with CO-RE). Signed-off-by: Andrii Nakryik

Re: [PATCH] drivers: net: wireless: rtlwifi: fix bool comparison in expressions

2021-01-08 Thread Larry Finger
ately Signed-off-by: Aditya Srivastava --- - The changes made are compile tested - Applies perfecly on next-20210108 drivers/net/wireless/realtek/rtlwifi/ps.c | 4 ++-- drivers/net/wireless/realtek/rtlwifi/rtl8188ee/dm.c | 8 drivers/net/wireless/realtek/rtlwifi/rtl8

Re: [PATCH v3 net-next 10/12] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-08 Thread Saeed Mahameed
On Fri, 2021-01-08 at 10:27 +0100, Eric Dumazet wrote: > On Fri, Jan 8, 2021 at 10:21 AM Vladimir Oltean > wrote: > > On Fri, Jan 08, 2021 at 10:14:01AM +0100, Eric Dumazet wrote: > > > If you disagree, repost a rebased patch series so that we can > > > test/compare and choose the best solution. >

Re: [PATCH net-next 1/2] ice: drop dead code in ice_receive_skb()

2021-01-08 Thread Jesse Brandeburg
Eric Dumazet wrote: > From: Eric Dumazet > > napi_gro_receive() can never return GRO_DROP > > GRO_DROP can only be returned from napi_gro_frags() > which is the other NAPI GRO entry point. > > Followup patch will remove GRO_DROP, because drivers > are not supposed to call napi_gro_frags() if p

Re: [PATCH v3 net-next 10/12] net: bonding: ensure .ndo_get_stats64 can sleep

2021-01-08 Thread Saeed Mahameed
On Fri, 2021-01-08 at 10:14 +0100, Eric Dumazet wrote: > On Fri, Jan 8, 2021 at 4:59 AM Saeed Mahameed > wrote: > > Eric, about two years ago you were totally against sleeping in > > ndo_get_stats, what happened ? :) > > https://lore.kernel.org/netdev/4cc44e85-cb5e-502c-30f3-c6ea564fe...@gmail.com

  1   2   3   >