Re: [PATCH v2 net-next 5/5] mptcp: implement delegated actions

2021-01-22 Thread Paolo Abeni
On Fri, 2021-01-22 at 15:23 -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 09:25:07 +0100 Paolo Abeni wrote: > > > Do you need it because of locking? > > > > This infrastructure is used to avoid the workqueue usage in the MPTCP > > receive path (to push pending data). With many mptcp connect

[PATCH] nfc: fix typo

2021-01-22 Thread samirweng1979
From: wengjianfeng change 'regster' to 'register' Signed-off-by: wengjianfeng --- drivers/nfc/trf7970a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index c70f62fe..3397802 100644 --- a/drivers/nfc/trf7970a.c +++ b/drivers

Re: [PATCH net-next v4 0/5] HTB offload

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 19 Jan 2021 14:08:10 +0200 you wrote: > This series adds support for HTB offload to the HTB qdisc, and adds > usage to mlx5 driver. > > The previous RFCs are available at [1], [2]. > > The feature is intended to

Re: question about bonding mode 4

2021-01-22 Thread moyufeng
Ping... Any comments? Thanks! On 2021/1/15 10:02, moyufeng wrote: > Hi Team, > > I have a question about bonding. During testing bonding mode 4 > scenarios, I find that there is a very low probability that > the pointer is null. The following information is displayed: > > [99359.795934] bond0: (

Re: [PATCH net-next v2 0/2] mlxsw: Expose number of physical ports

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 21 Jan 2021 15:10:22 +0200 you wrote: > From: Ido Schimmel > > The switch ASIC has a limited capacity of physical ports that it can > support. While each system is brought up with a different number of > ports, t

Re: Duplicate crash reports related with smsc75xx/smsc95xx and root cause analysis

2021-01-22 Thread 慕冬亮
On Sat, Jan 23, 2021 at 1:40 PM 慕冬亮 wrote: > > Dear kernel developers, > > I found that on the syzbot dashboard, “KMSAN: uninit-value in > smsc75xx_read_eeprom (2)” [1], > "KMSAN: uninit-value in smsc95xx_read_eeprom (2)" [2], "KMSAN: > uninit-value in smsc75xx_bind" [3], > "KMSAN: uninit-value in

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-22 Thread David Ahern
On 1/22/21 9:07 PM, Jakub Kicinski wrote: > On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: >> diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h >> index 768e93bd5b51..b216270105af 100644 >> --- a/include/uapi/linux/tcp.h >> +++ b/include/uapi/linux/tcp.h >> @@ -353,5 +353,9 @@ s

Duplicate crash reports related with smsc75xx/smsc95xx and root cause analysis

2021-01-22 Thread 慕冬亮
Dear kernel developers, I found that on the syzbot dashboard, “KMSAN: uninit-value in smsc75xx_read_eeprom (2)” [1], "KMSAN: uninit-value in smsc95xx_read_eeprom (2)" [2], "KMSAN: uninit-value in smsc75xx_bind" [3], "KMSAN: uninit-value in smsc95xx_reset" [4], "KMSAN: uninit-value in smsc95xx_wait

Re: [PATCH v3 net-next 1/1] Allow user to set metric on default route learned via Router Advertisement.

2021-01-22 Thread David Ahern
On 1/22/21 9:02 PM, Maciej Żenczykowski wrote: > Why can't we get rid of the special case for 0 and simply make 1024 the > default value? That would work too. > > As for making it an RA option: it's not clear how that would work, the > use case I see for this is for example two connections to th

[PATCH] usbnet: fix the indentation of one code snippet

2021-01-22 Thread Dongliang Mu
Every line of code should start with tab (8 characters) Signed-off-by: Dongliang Mu --- drivers/net/usb/usbnet.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 1447da1d5729..305c5f7b9a9b 100644 --- a/driv

[net-next PATCH] octeontx2-af: Support ESP/AH RSS hashing

2021-01-22 Thread sundeep . lkml
From: Subbaraya Sundeep Support SPI and sequence number fields of ESP/AH header to be hashed for RSS. By default ESP/AH fields are not considered for RSS and needs to be set explicitly as below: ethtool -U eth0 rx-flow-hash esp4 sdfn or ethtool -U eth0 rx-flow-hash ah4 sdfn or ethtool -U eth0 rx-

[PATCH iproute2-next 4/4] iplink: render IFLA_VF_STATS from IFLA_VFSTATS_LIST

2021-01-22 Thread Edwin Peer
The maximum possible length of a netlink attribute is 64KB, but the IFLA_VFINFO_LIST exceeds this when stats are included and more than about 220 VFs are present (each VF consumes approximately 300 bytes, depending on alignment and optional fields). Exceeding the limit will cause the list to be tru

[PATCH iproute2-next 3/4] iplink: filter stats using RTEXT_FILTER_SKIP_STATS

2021-01-22 Thread Edwin Peer
Don't request statistics we do not intend to render. This is a step towards avoiding a truncated IFLA_VFINFO_LIST. It also avoids fetching unnecessary data, reducing netlink traffic. Signed-off-by: Edwin Peer --- ip/ipaddress.c | 6 +- ip/iplink.c| 3 +++ 2 files changed, 8 insertions(+)

[PATCH iproute2-next 1/4] uapi: update kernel headers from upstream

2021-01-22 Thread Edwin Peer
This primarily pulls in the ABI changes needed to detect truncated lists of netlink attributes as well as the bits necessary to elevate IFLA_VF_INFO stats out of IFLA_VFINFO_LIST. Unrelated changes in the affected files were also synced. Signed-off-by: Edwin Peer --- include/uapi/linux/if_link.h

[PATCH iproute2-next 2/4] lib: iplink: print warnings for missing data

2021-01-22 Thread Edwin Peer
The kernel might truncate VF info in IFLA_VFINFO_LIST. Sufficiently new kernels will provide NLM_F_NEST_TRUNCATED in these cases, but this flag has limited resolution, as it pertains to the entire netlink message. A better approach is to compare the expected number of VFs in IFLA_NUM_VF to how many

[PATCH net-next 4/4] rtnetlink: promote IFLA_VF_STATS to same level as IFLA_VF_INFO

2021-01-22 Thread Edwin Peer
Separating the VF stats out of IFLA_VF_INFO appears to be the least impact way of resolving the nlattr overflow bug in IFLA_VFINFO_LIST. Since changing the hierarchy does constitute an ABI change, it must be explicitly requested via RTEXT_FILTER_VF_SEPARATE_STATS. Otherwise, the old location is ma

[PATCH net-next 3/4] rtnetlink: refactor IFLA_VF_INFO stats into rtnl_fill_vfstats()

2021-01-22 Thread Edwin Peer
Moving VF stats into their own function will facilitate separating them out later. No functional change. Signed-off-by: Edwin Peer --- net/core/rtnetlink.c | 66 +--- 1 file changed, 38 insertions(+), 28 deletions(-) diff --git a/net/core/rtnetlink.c b/n

[PATCH net-next 1/4] netlink: truncate overlength attribute list in nla_nest_end()

2021-01-22 Thread Edwin Peer
If a nested list of attributes is too long, then the length will exceed the 16-bit nla_len of the parent nlattr. In such cases, determine how many whole attributes can fit and truncate the message to this length. This properly maintains the nesting hierarchy, keeping the entire message valid, while

[PATCH net-next 2/4] rtnetlink: extend RTEXT_FILTER_SKIP_STATS to IFLA_VF_INFO

2021-01-22 Thread Edwin Peer
This filter already exists for excluding IPv6 SNMP stats. Extend its definition to also exclude IFLA_VF_INFO stats in RTM_GETLINK. This patch constitutes a partial fix for a netlink attribute nesting overflow bug in IFLA_VFINFO_LIST. By excluding the stats when the requester doesn't need them, the

Re: [PATCH v6 net-next 07/10] net: dsa: allow changing the tag protocol via the "tagging" device attribute

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 18:01:28 +0200 Vladimir Oltean wrote: > +/* Since the dsa/tagging sysfs device attribute is per master, the assumption > + * is that all DSA switches within a tree share the same tagger, otherwise > + * they would have formed disjoint trees (different "dsa,member" values). > + *

[PATCH net-next 0/4] support for 256 VFs in RTM_GETLINK

2021-01-22 Thread Edwin Peer
RTM_GETLINK for greater than about 220 VFs truncates IFLA_VFINFO_LIST due to the maximum reach of nlattr's nla_len being exceeded. There is not a lot of enthusiasm for extensive fixes to the deprecated netlink ABI for VF config, but there appears to be even less appetite for the kinds of work aroun

Re: [net-next PATCH 3/7] octeontx2-pf: ethtool fec mode support

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 13:23:25 +0530 Hariprasad Kelam wrote: > From: Christina Jacob > > Add ethtool support to configure fec modes baser/rs and > support to fecth FEC stats from CGX as well PHY. > > Configure fec mode > - ethtool --set-fec eth0 encoding rs/baser/off/auto > Query fec mode >

Re: [net-next v2 2/2] tcp: Add receive timestamp support for receive zerocopy.

2021-01-22 Thread Jakub Kicinski
On Wed, 20 Jan 2021 16:41:48 -0800 Arjun Roy wrote: > diff --git a/include/uapi/linux/tcp.h b/include/uapi/linux/tcp.h > index 768e93bd5b51..b216270105af 100644 > --- a/include/uapi/linux/tcp.h > +++ b/include/uapi/linux/tcp.h > @@ -353,5 +353,9 @@ struct tcp_zerocopy_receive { > __u64 copybu

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
resending answer to all: On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port b

Re: [PATCH net-next 00/14] net: bridge: multicast: add initial EHT support

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 16:51:49 +0200 you wrote: > From: Nikolay Aleksandrov > > Hi, > This set adds explicit host tracking support for IGMPv3/MLDv2. The > already present per-port fast leave flag is used to enable it since

Re: [PATCH net-next] net: hns3: replace skb->csum_not_inet with skb_csum_is_sctp

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Fri, 22 Jan 2021 17:31:01 +0800 you wrote: > Commit fa8211701043 ("net: add inline function skb_csum_is_sctp") > missed replacing skb->csum_not_inet check in hns3. This patch is > to replace it with skb_csum_is_sctp(). >

Re: [PATCH v2 1/5] dt-bindings: net: renesas,etheravb: Add r8a779a0 support

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 11:06:15 +0100 Wolfram Sang wrote: > Document the compatible value for the RAVB block in the Renesas R-Car > V3U (R8A779A0) SoC. This variant has no stream buffer, so we only need > to add the new compatible and add it to the TX delay block. > > Reviewed-by: Geert Uytterhoeven

Re: [PATCH v2 net-next 0/5] mptcp: re-enable sndbuf autotune

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 15:39:09 +0100 you wrote: > The sendbuffer autotuning was unintentionally disabled as a > side effect of the recent workqueue removal refactor. These > patches re-enable id, with some extra care: with a

Re: [PATCH] net: fec: put child node on error path

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 20 Jan 2021 04:20:37 -0800 you wrote: > Also decrement the reference count of child device on error path. > > Fixes: 3e782985cb3c ("net: ethernet: fec: Allow configuration of MDIO bus > speed") > Signed-off-by: Pan Bia

Re: [PATCH net-next] sfc: reduce the number of requested xdp ev queues

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 13:27:59 -0800 you wrote: > Without this change the driver tries to allocate too many queues, > breaching the number of available msi-x interrupts on machines > with many logical cpus and default adapter

Re: BPF: unbounded bpf_map_free_deferred problem

2021-01-22 Thread Cong Wang
On Fri, Jan 22, 2021 at 4:42 PM Tetsuo Handa wrote: > > Hello, BPF developers. > > Alexey Kardashevskiy is reporting that system_wq gets stuck due to flooding of > unbounded bpf_map_free_deferred work. Use of WQ_MEM_RECLAIM | WQ_HIGHPRI | > WQ_UNBOUND > workqueue did not solve this problem. Is it

Re: [PATCH] net: Simplify the calculation of variables

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 16:57:47 +0800 Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./net/ipv4/esp4_offload.c:288:32-34: WARNING !A || A && B is > equivalent to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong > --- > net/ipv4/esp4_offload.c | 2 +- > 1 fi

Re: [PATCH v2 net-next] vmxnet3: Remove buf_info from device

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 00:30:51 -0800 Ronak Doshi wrote: > + tq->buf_info = kcalloc_node(tq->tx_ring.size, sizeof(tq->buf_info[0]), > + GFP_KERNEL | __GFP_ZERO, > + dev_to_node(&adapter->pdev->dev)); no need to pass __GFP_ZERO to kca

Re: [PATCH net-next] tcp: add TTL to SCM_TIMESTAMPING_OPT_STATS

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 12:41:55 -0800 you wrote: > This patch adds TCP_NLA_TTL to SCM_TIMESTAMPING_OPT_STATS that exports > the time-to-live or hop limit of the latest incoming packet with > SCM_TSTAMP_ACK. The value exported

Re: [PATCH net-next v2 1/2] nfc: Add a virtual nci device driver

2021-01-22 Thread Jakub Kicinski
On Wed, 20 Jan 2021 20:56:44 +0900 Bongsu Jeon wrote: > From: Bongsu Jeon > > A NCI virtual device can be made to simulate a NCI device in user space. > Using the virtual NCI device, The NCI module and application can be > validated. This driver supports to communicate between the virtual NCI > d

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Enke Chen
Hi, Jakub: On Fri, Jan 22, 2021 at 06:34:24PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen wrote: > > Hi, Jakub: > > > > In terms of backporting, this patch should go together with: > > > > 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window > > As in it:

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 18:28:23 -0800 Enke Chen wrote: > Hi, Jakub: > > In terms of backporting, this patch should go together with: > > 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window As in it: Fixes: 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window or does it further fix the

Re: [PATCH] net: stmmac: dwmac-intel-plat: remove config data on error

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 20 Jan 2021 03:07:44 -0800 you wrote: > Remove the config data when rate setting fails. > > Fixes: 9efc9b2b04c7 ("net: stmmac: Add dwmac-intel-plat for GBE driver") > Signed-off-by: Pan Bian > --- > drivers/net/ethern

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Enke Chen
Hi, Jakub: In terms of backporting, this patch should go together with: 9d9b1ee0b2d1 tcp: fix TCP_USER_TIMEOUT with zero window Thanks. -- Enke On Fri, Jan 22, 2021 at 05:43:25PM -0800, Jakub Kicinski wrote: > On Fri, 22 Jan 2021 11:13:06 -0800 Enke Chen wrote: > > From: Enke Chen > > >

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote: > On Thu, Jan 21, 2021 at 10:27:54AM +, Russell King - ARM Linux admin > wrote: > > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote: > > > The mvpp2 is an Ethernet driver, and it implements MAC style time > > > stampin

Re: [PATCH net-next] tcp: remove unused ICSK_TIME_EARLY_RETRANS

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 16:32:36 +0100 Eric Dumazet wrote: > On Thu, Jan 21, 2021 at 3:32 PM Pengcheng Yang wrote: > > > > Since the early retransmit has been removed by > > commit bec41a11dd3d ("tcp: remove early retransmit"), > > we also remove the unused ICSK_TIME_EARLY_RETRANS macro. > > > > Signe

Re: [PATCH v3 net-next 0/4] net: ipa: remove a build dependency

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 15:26:02 -0600 you wrote: > (David/Jakub, please take these all through net-next if they are > acceptable to you, once Rob has acked the binding. Rob, please ack > if the binding looks OK to you.) > >

Re: [PATCH] net: octeontx2: Make sure the buffer is 128 byte aligned

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Thu, 21 Jan 2021 15:09:06 +0800 you wrote: > The octeontx2 hardware needs the buffer to be 128 byte aligned. > But in the current implementation of napi_alloc_frag(), it can't > guarantee the return address is 128 byte aligne

Re: [PATCH v3] net: phy: realtek: Add support for RTL9000AA/AN

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 21:15:52 +0100 Andrew Lunn wrote: > On Thu, Jan 21, 2021 at 05:02:54PM +0900, Yuusuke Ashizuka wrote: > > RTL9000AA/AN as 100BASE-T1 is following: > > - 100 Mbps > > - Full duplex > > - Link Status Change Interrupt > > - Master/Slave configuration > > > > Signed-off-by: Yuusuke

Re: [PATCH bpf-next V12 7/7] bpf/selftests: tests using bpf_check_mtu BPF-helper

2021-01-22 Thread Daniel Borkmann
On 1/18/21 5:54 PM, Jesper Dangaard Brouer wrote: Adding selftest for BPF-helper bpf_check_mtu(). Making sure it can be used from both XDP and TC. [...] (small nit: your subject lines are mixed up with 'bpf/selftests' vs 'selftests/bpf')

Re: [PATCH bpf-next V12 2/7] bpf: fix bpf_fib_lookup helper MTU check for SKB ctx

2021-01-22 Thread Daniel Borkmann
On 1/18/21 5:54 PM, Jesper Dangaard Brouer wrote: BPF end-user on Cilium slack-channel (Carlo Carraro) wants to use bpf_fib_lookup for doing MTU-check, but *prior* to extending packet size, by adjusting fib_params 'tot_len' with the packet length plus the expected encap size. (Just like the bpf_c

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:13:06 -0800 Enke Chen wrote: > From: Enke Chen > > The TCP_USER_TIMEOUT is checked by the 0-window probe timer. As the > timer has backoff with a max interval of about two minutes, the > actual timeout for TCP_USER_TIMEOUT can be off by up to two minutes. > > In this patch

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 5:01 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: >>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: >>> @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct >>

Re: [net-next PATCH v4 10/15] net: mdio: Add ACPI support code for mdio

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 21:12:55 +0530 Calvin Johnson wrote: > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. > > Signed-off-by: Calvin Johnson ERROR: modpost: missing MODULE_LICENSE() in drivers/net/mdio/acpi_mdio.o make[2]: *** [Module.symvers] Error

Re: [PATCH net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 16:13:47 +0100 Laurent Badel wrote: > fec_restart() does a hard reset of the MAC module when the link status > changes to up. This temporarily resets the R_CNTRL register which controls > the MII mode of the ENET_OUT clock. In the case of RMII, the clock > frequency momentarily

Re: [PATCH bpf-next V12 4/7] bpf: add BPF-helper for MTU checking

2021-01-22 Thread Daniel Borkmann
On 1/18/21 5:54 PM, Jesper Dangaard Brouer wrote: This BPF-helper bpf_check_mtu() works for both XDP and TC-BPF programs. The SKB object is complex and the skb->len value (accessible from BPF-prog) also include the length of any extra GRO/GSO segments, but without taking into account that these

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
> it migth be helpful for developers work on userspace networking tools with > PHY-less lan743x (the interface even could not be brought up) > of course, there nothing much to do without TP port but the difference is > representative. > > sbauer@metamini ~$ sudo ethtool eth7 > Settings for eth7:

Re: [PATCH net] tcp: fix TLP timer not set when CA_STATE changes from DISORDER to OPEN

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:53:46 +0100 Eric Dumazet wrote: > On Fri, Jan 22, 2021 at 11:28 AM Pengcheng Yang wrote: > > > > When CA_STATE is in DISORDER, the TLP timer is not set when receiving > > an ACK (a cumulative ACK covered out-of-order data) causes CA_STATE to > > change from DISORDER to OPEN.

RE: [Intel-wired-lan] [PATCH v3 net-next 10/11] ice: store the result of ice_rx_offset() onto ice_ring

2021-01-22 Thread Brelinski, TonyX
From: Intel-wired-lan On Behalf Of Maciej Fijalkowski Sent: Monday, January 18, 2021 7:13 AM To: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; k...@kernel.org; b...@vger.kernel.org; Topel, Bjorn ; Karlsson, Magnus Subject: [Intel-wired-lan] [PATCH v3 net-next 10/11] ice: store th

RE: [Intel-wired-lan] [PATCH v3 net-next 05/11] ice: move skb pointer from rx_buf to rx_ring

2021-01-22 Thread Brelinski, TonyX
From: Intel-wired-lan On Behalf Of Maciej Fijalkowski Sent: Monday, January 18, 2021 7:13 AM To: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; k...@kernel.org; b...@vger.kernel.org; Topel, Bjorn ; Karlsson, Magnus Subject: [Intel-wired-lan] [PATCH v3 net-next 05/11] ice: move skb

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 08:36:01 + Oleksandr Mazur wrote: > On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > > > Add new trap action HARD_DROP, which can be used by the > > > drivers to register traps, where it's impossi

Re: [PATCH v6 bpf-next 0/8] mvneta: introduce XDP multi-buffer support

2021-01-22 Thread Daniel Borkmann
Hi Lorenzo, On 1/19/21 9:20 PM, Lorenzo Bianconi wrote: This series introduce XDP multi-buffer support. The mvneta driver is the first to support these new "non-linear" xdp_{buff,frame}. Reviewers please focus on how these new types of xdp_{buff,frame} packets traverse the different layers and t

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: > On 1/22/2021 3:58 PM, Sergej Bauer wrote: > > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > lan743x_adapter *adapter)> > > >

Re: [PATCH v2] net: usb: qmi_wwan: added support for Thales Cinterion PLSx3 modem family

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:39:12 +0100 Bjørn Mork wrote: > Jakub Kicinski writes: > > > Bjorn, I think this was posted before you pointed out the missing CCs > > and Giacinto didn't repost. > > > > Looks good? > > Yes, LGTM > > Acked-by: Bjørn Mork Applied, thanks!

BPF: unbounded bpf_map_free_deferred problem

2021-01-22 Thread Tetsuo Handa
Hello, BPF developers. Alexey Kardashevskiy is reporting that system_wq gets stuck due to flooding of unbounded bpf_map_free_deferred work. Use of WQ_MEM_RECLAIM | WQ_HIGHPRI | WQ_UNBOUND workqueue did not solve this problem. Is it possible that a refcount leak somewhere preventing bpf_map_free_

RE: [Intel-wired-lan] [PATCH v3 net-next 06/11] ice: remove redundant checks in ice_change_mtu

2021-01-22 Thread Brelinski, TonyX
From: Intel-wired-lan On Behalf Of Maciej Fijalkowski Sent: Monday, January 18, 2021 7:13 AM To: intel-wired-...@lists.osuosl.org Cc: netdev@vger.kernel.org; k...@kernel.org; b...@vger.kernel.org; Topel, Bjorn ; Karlsson, Magnus Subject: [Intel-wired-lan] [PATCH v3 net-next 06/11] ice: remove r

[PATCH 22/22] RDMA/irdma: Update MAINTAINERS file

2021-01-22 Thread Shiraz Saleem
Add maintainer entry for irdma driver. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4183ddc..4798280 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8924,6 +8924,14 @@ F:

[PATCH 06/22] i40e: Register auxiliary devices to provide RDMA

2021-01-22 Thread Shiraz Saleem
Convert i40e to use the auxiliary bus infrastructure to export the RDMA functionality of the device to the RDMA driver. Register i40e client auxiliary RDMA device on the auxiliary bus per PCIe device function for the new auxiliary rdma driver (irdma) to attach to. This replaces the need for the gl

[PATCH 07/22] RDMA/irdma: Register an auxiliary driver and implement private channel OPs

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Register irdma as an auxiliary driver which can attach to auxiliary RDMA devices from Intel PCI netdev drivers i40e and ice. Implement the private channel ops, add basic devlink support in the driver and register net notifiers. Signed-off-by: Mustafa Ismail Signed-off-by: S

[PATCH 08/22] RDMA/irdma: Implement device initialization definitions

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Implement device initialization routines, interrupt set-up, and allocate object bit-map tracking structures. Also, add device specific attributes and register definitions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/hw.c

[PATCH 12/22] RDMA/irdma: Add QoS definitions

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Add definitions for managing the RDMA HW work scheduler (WS) tree. A WS node is created via a control QP operation with the bandwidth allocation, arbitration scheme, and traffic class of the QP specified. The Qset handle returned associates the QoS parameters for the QP. The

Re: [Intel-wired-lan] [PATCH net v2] ixgbe: add NULL pointer check before calling xdp_rxq_info_reg

2021-01-22 Thread Nguyen, Anthony L
On Fri, 2021-01-22 at 09:54 -0800, Alexander Duyck wrote: > On Fri, Jan 22, 2021 at 5:29 AM wangyunjian > wrote: > > > > From: Yunjian Wang > > > > The rx_ring->q_vector could be NULL, so it needs to be checked > > before > > calling xdp_rxq_info_reg. > > > > Fixes: b02e5a0ebb172 ("xsk: Propag

[PATCH 11/22] RDMA/irdma: Add privileged UDA queue implementation

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Implement privileged UDA queues to handle iWARP connection packets and receive exceptions. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/puda.c | 1743 drivers/infiniband/hw/irdma/puda.h |

[PATCH 13/22] RDMA/irdma: Add connection manager

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Add connection management (CM) implementation for iWARP including accept, reject, connect, create_listen, destroy_listen and CM utility functions Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/cm.c | 4463 +++

[PATCH net 2/7] ice: Implement flow for IPv6 next header (extension header)

2021-01-22 Thread Tony Nguyen
From: Nick Nunley This patch is based on a similar change to i40e by Slawomir Laba: "i40e: Implement flow for IPv6 next header (extension header)". When a packet contains an IPv6 header with next header which is an extension header and not a protocol one, the kernel function skb_transport_header

[PATCH net 0/7][pull request] Intel Wired LAN Driver Updates 2021-01-22

2021-01-22 Thread Tony Nguyen
This series contains updates to the ice and i40e driver. Henry corrects setting an unspecified protocol to IPPROTO_NONE instead of 0 for IPv6 flexbytes filters for ice. Nick fixes the IPv6 extension header being processed incorrectly and updates the netdev->dev_addr if it exists in hardware as it

[PATCH 17/22] RDMA/irdma: Add user/kernel shared libraries

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Building the WQE descriptors for different verb operations are similar in kernel and user-space. Add these shared libraries. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uk.c | 1729 driv

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 3:58 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > lan743x_adapter *adapter)> > > struct net_device *netdev = adapter->netdev; > > phy_stop(netd

[PATCH net 6/7] ice: Fix MSI-X vector fallback logic

2021-01-22 Thread Tony Nguyen
From: Brett Creeley The current MSI-X enablement logic tries to enable best-case MSI-X vectors and if that fails we only support a bare-minimum set. This includes a single MSI-X for 1 Tx and 1 Rx queue and a single MSI-X for the OICR interrupt. Unfortunately, the driver fails to load when we don'

[PATCH net 7/7] i40e: acquire VSI pointer only after VF is initialized

2021-01-22 Thread Tony Nguyen
From: Stefan Assmann This change simplifies the VF initialization check and also minimizes the delay between acquiring the VSI pointer and using it. As known by the commit being fixed, there is a risk of the VSI pointer getting changed. Therefore minimize the delay between getting and using the p

[PATCH net 4/7] ice: use correct xdp_ring with XDP_TX action

2021-01-22 Thread Tony Nguyen
From: Piotr Raczynski XDP queue number for XDP_TX action is used inconsistently and may result with no packets transmitted. Fix queue number used by the driver when doing XDP_TX, i.e. use receive queue number as in ice_finalize_xdp_rx. Also, using smp_processor_id() is wrong here and won't work

[PATCH net 1/7] ice: fix FDir IPv6 flexbyte

2021-01-22 Thread Tony Nguyen
From: Henry Tieman The packet classifier would occasionally misrecognize an IPv6 training packet when the next protocol field was 0. The correct value for unspecified protocol is IPPROTO_NONE. Fixes: 165d80d6adab ("ice: Support IPv6 Flow Director filters") Signed-off-by: Henry Tieman Reviewed-b

[PATCH net 5/7] ice: Don't allow more channels than LAN MSI-X available

2021-01-22 Thread Tony Nguyen
From: Brett Creeley Currently users could create more channels than LAN MSI-X available. This is happening because there is no check against pf->num_lan_msix when checking the max allowed channels and will cause performance issues if multiple Tx and Rx queues are tied to a single MSI-X. Fix this

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); > >

[PATCH 20/22] RDMA/irdma: Add ABI definitions

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Add ABI definitions for irdma. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- include/uapi/rdma/irdma-abi.h | 140 ++ 1 file changed, 140 insertions(+) create mode 100644 include/uapi/rdma/irdma-abi.h diff --git a/

[PATCH 18/22] RDMA/irdma: Add miscellaneous utility definitions

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Add miscellaneous utility functions and headers. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/osdep.h | 99 ++ drivers/infiniband/hw/irdma/protos.h | 118 ++ drivers/infiniband/hw/irdma/status.h | 70 + drivers/infiniban

[PATCH 19/22] RDMA/irdma: Add dynamic tracing for CM

2021-01-22 Thread Shiraz Saleem
From: "Michael J. Ruhl" Add dynamic tracing functionality to debug connection management issues. Signed-off-by: Michael J. Ruhl Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/trace.c| 112 drivers/infiniband/hw/irdma/trace.h| 3 + drivers/infiniband/hw/irdma/t

[PATCH net 3/7] ice: update dev_addr in ice_set_mac_address even if HW filter exists

2021-01-22 Thread Tony Nguyen
From: Nick Nunley Fix the driver to copy the MAC address configured in ndo_set_mac_address into dev_addr, even if the MAC filter already exists in HW. In some situations (e.g. bonding) the netdev's dev_addr could have been modified outside of the driver, with no change to the HW filter, so the dr

[PATCH 16/22] RDMA/irdma: Add RoCEv2 UD OP support

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Add the header, data structures and functions to populate the WQE descriptors and issue the Control QP commands that support RoCEv2 UD operations. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/uda.c | 391

[PATCH 14/22] RDMA/irdma: Add PBLE resource manager

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Implement a Physical Buffer List Entry (PBLE) resource manager to manage a pool of PBLE HMC resource objects. Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/pble.c | 525 + drivers/infiniband/

[PATCH 15/22] RDMA/irdma: Implement device supported verb APIs

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail Implement device supported verb APIs. The supported APIs vary based on the underlying transport the ibdev is registered as (i.e. iWARP or RoCEv2). Signed-off-by: Mustafa Ismail Signed-off-by: Shiraz Saleem --- drivers/infiniband/hw/irdma/verbs.c | 4617 +++

[PATCH 10/22] RDMA/irdma: Add HMC backing store setup functions

2021-01-22 Thread Shiraz Saleem
From: Mustafa Ismail HW uses host memory as a backing store for a number of protocol context objects and queue state tracking. The Host Memory Cache (HMC) is a component responsible for managing these objects stored in host memory. Add the functions and data structures to manage the allocation o

[PATCH 05/22] i40e: Prep i40e header for aux bus conversion

2021-01-22 Thread Shiraz Saleem
Add the definitions and private ops to the i40e client header file in preparation to convert i40e to use the new auxiliary bus infrastructure. This header is shared between the 'i40e' Intel networking driver providing RDMA support and the 'irdma' driver. Signed-off-by: Shiraz Saleem --- include/

[PATCH 04/22] ice: Register auxiliary device to provide RDMA

2021-01-22 Thread Shiraz Saleem
From: Dave Ertman Register ice client auxiliary RDMA device on the auxiliary bus per PCIe device function for the auxiliary driver (irdma) to attach to. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/Kconfig | 1 + drivers/net/ethernet/intel/ice/ic

[PATCH 03/22] ice: Implement iidc operations

2021-01-22 Thread Shiraz Saleem
From: Dave Ertman Add implementations for supporting iidc operations which the peer calls for device operation such as registration, allocation of queues, and event notifications. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice.h | 1

[PATCH 02/22] ice: Initialize RDMA support

2021-01-22 Thread Shiraz Saleem
From: Dave Ertman Probe the device's capabilities to see if it supports RDMA. If so, allocate and reserve resources to support its operation; populate structures with initial values. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/Makefile |

[PATCH 00/22] Add Intel Ethernet Protocol Driver for RDMA (irdma)

2021-01-22 Thread Shiraz Saleem
From: "Shiraz, Saleem" The following patch series introduces a unified Intel Ethernet Protocol Driver for RDMA (irdma) for the X722 iWARP device and a new E810 device which supports iWARP and RoCEv2. The irdma driver replaces the legacy i40iw driver for X722 and extends the ABI already defined fo

[PATCH 01/22] iidc: Introduce iidc.h

2021-01-22 Thread Shiraz Saleem
From: Dave Ertman Introduce a shared header file used by the 'ice' Intel networking driver providing RDMA support and the 'irdma' driver to provide a private interface. Signed-off-by: Dave Ertman Signed-off-by: Tony Nguyen --- MAINTAINERS| 1 + include/linux/net/intel/ii

Re: [PATCH 17/18] net: iosm: readme file

2021-01-22 Thread Andrew Lunn
On Wed, Jan 20, 2021 at 07:34:48PM -0600, Dan Williams wrote: > On Wed, 2021-01-20 at 15:32 -0800, Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 20:34:51 +0100 Andrew Lunn wrote: > > > On Sun, Jan 17, 2021 at 06:26:54PM +0100, Bjørn Mork wrote: > > > > I was young and stupid. Now I'm not that young

Re: [PATCH bpf-next] bpf: fix typo in scalar{,32}_min_max_rsh comments

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 21 Jan 2021 18:43:24 +0100 you wrote: > s/bounts/bounds/ > > Signed-off-by: Tobias Klauser > --- > kernel/bpf/verifier.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links:

Re: [PATCHv10 bpf-next] samples/bpf: add xdp program on egress for xdp_redirect_map

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 22 Jan 2021 10:50:07 +0800 you wrote: > This patch add a xdp program on egress to show that we can modify > the packet on egress. In this sample we will set the pkt's src > mac to egress's mac address. The xdp_prog wil

Re: [PATCH v2 net-next 5/5] mptcp: implement delegated actions

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 09:25:07 +0100 Paolo Abeni wrote: > On Thu, 2021-01-21 at 17:34 -0800, Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 15:39:14 +0100 Paolo Abeni wrote: > > > On MPTCP-level ack reception, the packet scheduler > > > may select a subflow other then the current one. > > > > > > P

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
> > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > lan743x_adapter *adapter)> > > > struct net_device *netdev = adapter->netdev; > > > > > > phy_stop(netdev->phydev); > > > > > > - phy_disconnect(netdev->phydev); > > > - netdev->phydev = NULL; > > > + if (phy_is_pseudo

Re: [PATCH] net: dp83tc811: fix link detection and possbile IRQ storm

2021-01-22 Thread Andrew Lunn
On Fri, Jan 22, 2021 at 04:03:34PM +0100, Marc Kleine-Budde wrote: > In our setup the dp83tc811 is configure to master mode. When there is no slave > connected the dp83tc811 triggers an interrupt is triggerd, several bits in the > status registers are set, and te INT_N pin goes low. One of interrup

[pull request][net-next V10 00/14] Add mlx5 subfunction support

2021-01-22 Thread Saeed Mahameed
From: Saeed Mahameed Hi Dave, Jakub, Jason, This series form Parav was the theme of this mlx5 release cycle, we've been waiting anxiously for the auxbus infrastructure to make it into the kernel, and now as the auxbus is in and all the stars are aligned, I can finally submit this patchset of the

  1   2   3   4   >