RE: [EXT] Re: [net-next] net: mvpp2: Add reserved port private flag configuration

2021-03-11 Thread Stefan Chulski
> > From: Stefan Chulski > > > > According to Armada SoC architecture and design, all the PPv2 ports > > which are populated on the same communication processor silicon die > > (CP11x) share the same Classifier and Parser engines. > > > > Armada is an embedded platform and therefore there is a nee

Re: [PATCH] perf tools: Remove redundant code

2021-03-11 Thread kajoljain
On 3/10/21 8:48 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./tools/perf/util/evlist.c:1315:5-8: Unneeded variable: "err". Return "- > ENOMEM" on line 1340. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > tools/perf/util/evlist.c | 3 +-- > 1 fi

Re: [PATCH 14/17] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-11 Thread Christoph Hellwig
On Wed, Mar 10, 2021 at 06:39:57PM +, Robin Murphy wrote: >> Actually... Just mirroring the iommu_dma_strict value into >> struct iommu_domain should solve all of that with very little >> boilerplate code. > > Yes, my initial thought was to directly replace the attribute with a > common flag at

Re: [PATCH mlx5-next v7 0/4] Dynamically assign MSI-X vectors count

2021-03-11 Thread Leon Romanovsky
On Wed, Mar 10, 2021 at 09:21:55PM +0100, Greg Kroah-Hartman wrote: > On Wed, Mar 10, 2021 at 10:10:41PM +0200, Leon Romanovsky wrote: > > On Wed, Mar 10, 2021 at 01:09:06PM -0600, Bjorn Helgaas wrote: > > > On Sun, Mar 07, 2021 at 10:55:24AM -0800, Alexander Duyck wrote: > > > > On Sun, Feb 28, 20

Re: [PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-11 Thread Mel Gorman
On Wed, Mar 10, 2021 at 03:46:50PM -0800, Andrew Morton wrote: > On Wed, 10 Mar 2021 10:46:15 + Mel Gorman > wrote: > > > This patch adds a new page allocator interface via alloc_pages_bulk, > > and __alloc_pages_bulk_nodemask. A caller requests a number of pages > > to be allocated and adde

[PATCH] net/rds: Fix a use after free in rds_message_map_pages

2021-03-11 Thread Lv Yunlong
In rds_message_map_pages, rds_message_put() will free rm. Maybe store the value of rm->data.op_sg ahead of rds_message_put() is better. Otherwise other threads could allocate the freed chunk and may change the value of rm->data.op_sg. Signed-off-by: Lv Yunlong --- net/rds/message.c | 3 ++- 1 fi

Re: [PATCH 0/5] Introduce a bulk order-0 page allocator with two in-tree users

2021-03-11 Thread Mel Gorman
On Wed, Mar 10, 2021 at 03:47:04PM -0800, Andrew Morton wrote: > On Wed, 10 Mar 2021 10:46:13 + Mel Gorman > wrote: > > > This series introduces a bulk order-0 page allocator with sunrpc and > > the network page pool being the first users. > > > > Right now, the [0/n] doesn't even tell us

Re: [net 13/18] RDMA/mlx5: Fix timestamp default mode

2021-03-11 Thread Leon Romanovsky
On Wed, Mar 10, 2021 at 11:03:37AM -0800, Saeed Mahameed wrote: > From: Maor Gottlieb > > 1. Don't set the ts_format bit to default when it reserved - device is >running in the old mode (free running). > 2. XRC doesn't have a CQ therefore the ts format in the QP >context should be default

Kernel Routing tabel

2021-03-11 Thread Mihai
Hello, I have 2 NIC with ips eth1: 10.100.1.2/30 eth2: 10.200.1.2/30 both of them must reach IP: 172.16.16.1 what i've done so far: eth1: ip route add 10.100.1.0/30 dev eth1 src 10.100.1.2 scope link table 100 ip route add default via 10.100.1.1 dev eth1 table 100 ip rule add from 10.100.1.0/30 d

Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64

2021-03-11 Thread Arnd Bergmann
On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski wrote: > On 10/03/2021 17:42, Arnd Bergmann wrote: > > On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski > > wrote: > >> On 10/03/2021 16:47, Krzysztof Kozlowski wrote: > >>> This edac Altera driver is very weird... it uses the same compatible

[PATCH] net: core: bpf_sk_storage.c: Fix bare usage of unsigned

2021-03-11 Thread Shubhankar Kuranagatti
Changed bare usage of unsigned to unsigned int Signed-off-by: Shubhankar Kuranagatti --- net/core/bpf_sk_storage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/bpf_sk_storage.c b/net/core/bpf_sk_storage.c index 4edd033e899c..d99753f88a70 100644 --- a/net/core/bpf_

[PATCH] tracing: remove holes in events

2021-03-11 Thread Tony Lu
There are some holes in the event definitions, spaces are wasted. Based on the analysis result of pahole and event format files, 22 events have more than one hole. To change less and fix worst, 5 events are picked up and fixed in this patch according the following rules. Rules: - try not to aff

Re: [PATCH] net: core: bpf_sk_storage.c: Fix bare usage of unsigned

2021-03-11 Thread Greg KH
On Thu, Mar 11, 2021 at 03:13:49PM +0530, Shubhankar Kuranagatti wrote: > Changed bare usage of unsigned to unsigned int That says _what_ you did, but not _why_ you did it :( thanks, greg k-h

[PATCH v3 net-next 0/2] pktgen: scripts improvements

2021-03-11 Thread Igor Russkikh
Hello netdev community, Please consider small improvements to pktgen scripts we use in our environment. Adding delay parameter through command line, Adding new -a (append) parameter to make flex runs v3: change us to ns in docs v2: Review comments from Jesper CC: Jesper Dangaard Brouer Igor R

[PATCH v3 net-next 1/2] samples: pktgen: allow to specify delay parameter via new opt

2021-03-11 Thread Igor Russkikh
DELAY may now be explicitly specified via common parameter -w Signed-off-by: Igor Russkikh --- samples/pktgen/README.rst | 1 + samples/pktgen/parameters.sh | 10 +- samples/pktgen/pktgen_bench_xmit_mode_netif_receive.sh | 3 --- s

[PATCH v3 net-next 2/2] samples: pktgen: new append mode

2021-03-11 Thread Igor Russkikh
To configure various complex flows we for sure can create custom pktgen init scripts, but sometimes thats not that easy. New "-a" (append) option in all the existing sample scripts allows to append more "devices" into pktgen threads. The most straightforward usecases for that are: - using multipl

[PATCH 1/2] net: core: datagram.c: Fix use of assignment in if condition

2021-03-11 Thread Shubhankar Kuranagatti
The assignment inside the if condition has been changed to initialising outside the if condition. Signed-off-by: Shubhankar Kuranagatti --- net/core/datagram.c | 31 --- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/net/core/datagram.c b/net/core/dat

[PATCH 2/2] net: core: datagram.c: Fix usage of space before tab

2021-03-11 Thread Shubhankar Kuranagatti
Removed an extra space before the tab key. Signed-off-by: Shubhankar Kuranagatti --- net/core/datagram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/datagram.c b/net/core/datagram.c index 7b2204f102b7..be0caaec9add 100644 --- a/net/core/datagram.c +++ b/net/core/

Re:_

2021-03-11 Thread Mark Carissa
Greetings, why haven't you replied to me? I sent you an email a few days ago but you haven't responded.

Re: [Patch bpf-next v4 01/11] skmsg: lock ingress_skb when purging

2021-03-11 Thread Jakub Sitnicki
On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote: > From: Cong Wang > > Currently we purge the ingress_skb queue only when psock > refcnt goes down to 0, so locking the queue is not necessary, > but in order to be called during ->close, we have to lock it > here. > > Cc: John Fastabend > Cc:

RE: [PATCH net] ethtool: Add indicator field for link_mode validity to link_ksettings

2021-03-11 Thread Danielle Ratson
> -Original Message- > From: Jakub Kicinski > Sent: Thursday, March 4, 2021 8:47 PM > To: Danielle Ratson > Cc: netdev@vger.kernel.org; da...@davemloft.net; eric.duma...@gmail.com; > and...@lunn.ch; mkube...@suse.cz; > f.faine...@gmail.com; acard...@redhat.com; irussk...@marvell.com;

Re: [Patch bpf-next v4 02/11] skmsg: introduce a spinlock to protect ingress_msg

2021-03-11 Thread Jakub Sitnicki
On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote: > From: Cong Wang > > Currently we rely on lock_sock to protect ingress_msg, > it is too big for this, we can actually just use a spinlock > to protect this list like protecting other skb queues. > > __tcp_bpf_recvmsg() is still special becaus

Re: [PATCH bpf-next 07/10] bpftool: add `gen bpfo` command to perform BPF static linking

2021-03-11 Thread Quentin Monnet
2021-03-09 20:04 UTC-0800 ~ Andrii Nakryiko > Add `bpftool gen bpfo ...` command to statically > link multiple BPF object files into a single output BPF object file. > > Similarly to existing '*.o' convention, bpftool is establishing a '*.bpfo' > convention for statically-linked BPF object files

Re: [Patch bpf-next v4 03/11] skmsg: introduce skb_send_sock() for sock_map

2021-03-11 Thread Jakub Sitnicki
On Wed, Mar 10, 2021 at 06:32 AM CET, Cong Wang wrote: > From: Cong Wang > > We only have skb_send_sock_locked() which requires callers > to use lock_sock(). Introduce a variant skb_send_sock() > which locks on its own, callers do not need to lock it > any more. This will save us from adding a ->s

[PATCH 1/5] SUNRPC: Set rq_page_end differently

2021-03-11 Thread Mel Gorman
From: Chuck Lever Refactor: I'm about to use the loop variable @i for something else. As far as the "i++" is concerned, that is a post-increment. The value of @i is not used subsequently, so the increment operator is unnecessary and can be removed. Also note that nfsd_read_actor() was renamed

[PATCH 0/5 v3] Introduce a bulk order-0 page allocator with two in-tree users

2021-03-11 Thread Mel Gorman
Changelog since v3 o Prep new pages with IRQs enabled o Minor documentation update Changelog since v1 o Parenthesise binary and boolean comparisons o Add reviewed-bys o Rebase to 5.12-rc2 This series introduces a bulk order-0 page allocator with sunrpc and the network page pool being the first us

[PATCH 4/5] net: page_pool: refactor dma_map into own function page_pool_dma_map

2021-03-11 Thread Mel Gorman
From: Jesper Dangaard Brouer In preparation for next patch, move the dma mapping into its own function, as this will make it easier to follow the changes. V2: make page_pool_dma_map return boolean (Ilias) Signed-off-by: Jesper Dangaard Brouer Signed-off-by: Mel Gorman Reviewed-by: Ilias Apalo

[PATCH 5/5] net: page_pool: use alloc_pages_bulk in refill code path

2021-03-11 Thread Mel Gorman
From: Jesper Dangaard Brouer There are cases where the page_pool need to refill with pages from the page allocator. Some workloads cause the page_pool to release pages instead of recycling these pages. For these workload it can improve performance to bulk alloc pages from the page-allocator to r

[PATCH 2/5] mm/page_alloc: Add a bulk page allocator

2021-03-11 Thread Mel Gorman
This patch adds a new page allocator interface via alloc_pages_bulk, and __alloc_pages_bulk_nodemask. A caller requests a number of pages to be allocated and added to a list. They can be freed in bulk using free_pages_bulk(). The API is not guaranteed to return the requested number of pages and ma

[PATCH 3/5] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-11 Thread Mel Gorman
From: Chuck Lever Reduce the rate at which nfsd threads hammer on the page allocator. This improve throughput scalability by enabling the threads to run more independently of each other. Signed-off-by: Chuck Lever Signed-off-by: Mel Gorman --- net/sunrpc/svc_xprt.c | 43 ++

Re: [RFC PATCH 03/10] nfp: Replace nfp_pr_et with ethtool_gsprintf

2021-03-11 Thread Simon Horman
On Wed, Mar 10, 2021 at 05:35:32PM -0800, Alexander Duyck wrote: > From: Alexander Duyck > > The nfp_pr_et function is nearly identical to ethtool_gsprintf except for > the fact that it passes the pointer by value and as a return whereas > ethtool_gsprintf passes it as a pointer. > > Since they

Re: Softirq error with mcp251xfd driver

2021-03-11 Thread Marc Kleine-Budde
On 10.03.2021 22:22:54, Daniel Glöckner wrote: > On Wed, Mar 10, 2021 at 08:13:51AM +0100, Marc Kleine-Budde wrote: > > On 10.03.2021 07:46:26, Daniel Glöckner wrote: > > > the mcp251xfd driver uses a threaded irq handler to queue skbs with the > > > can_rx_offload_* helpers. I get the following er

RE: stmmac driver timeout issue

2021-03-11 Thread Joakim Zhang
> -Original Message- > From: Florian Fainelli > Sent: 2021年3月9日 1:57 > To: Joakim Zhang ; Jakub Kicinski > ; Andrew Lunn > Cc: netdev@vger.kernel.org > Subject: Re: stmmac driver timeout issue > > On 3/8/21 4:45 AM, Joakim Zhang wrote: > > > > Hi Florian, Andrew, > > > > Thanks for your

Re: [net-next PATCH v7 07/16] net: mii_timestamper: check NULL in unregister_mii_timestamper()

2021-03-11 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson wrote: > > Callers of unregister_mii_timestamper() currently check for NULL > value of mii_ts before calling it. > > Place the NULL check inside unregister_mii_timestamper() and update > the callers accordingly FWIW, Reviewed-by: Andy Shevchenko (D

RE: [Intel-wired-lan] [PATCH intel-net] ice: fix napi work done reporting in xsk path

2021-03-11 Thread Bhandare, KiranX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Magnus Karlsson > Sent: Friday, February 5, 2021 2:39 PM > To: Karlsson, Magnus ; Topel, Bjorn > ; intel-wired-...@lists.osuosl.org; Nguyen, Anthony > L ; Fijalkowski, Maciej > ; maciejromanfijalkow...@gmail.com > Cc: netdev@vger.

Re: [net-next PATCH v7 08/16] net: mdiobus: Introduce fwnode_mdiobus_register_phy()

2021-03-11 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 8:21 AM Calvin Johnson wrote: > > Introduce fwnode_mdiobus_register_phy() to register PHYs on the > mdiobus. From the compatible string, identify whether the PHY is > c45 and based on this create a PHY device instance which is > registered on the mdiobus. > uninitialized s

Re: [net-next PATCH v7 10/16] ACPI: utils: Introduce acpi_get_local_address()

2021-03-11 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 8:22 AM Calvin Johnson wrote: > > Introduce a wrapper around the _ADR evaluation. Reviewed-by: Andy Shevchenko > Signed-off-by: Calvin Johnson > --- > > Changes in v7: None > Changes in v6: None > Changes in v5: > - Replace fwnode_get_id() with acpi_get_local_address()

Re: [net-next PATCH v7 11/16] net: mdio: Add ACPI support code for mdio

2021-03-11 Thread Andy Shevchenko
On Thu, Mar 11, 2021 at 8:22 AM Calvin Johnson wrote: > > Define acpi_mdiobus_register() to Register mii_bus and create PHYs for > each ACPI child node. > > Signed-off-by: Calvin Johnson > --- > > Changes in v7: > - Include headers directly used in acpi_mdio.c > > Changes in v6: > - use GENMASK()

Re: Softirq error with mcp251xfd driver

2021-03-11 Thread Marc Kleine-Budde
On 10.03.2021 22:56:21, Daniel Glöckner wrote: [...] > Or we leave can_rx_offload unchanged and keep two additional lists of skbs > inside the mcp251xfd driver: One for the packets that arrived before the > timestamp read from TBC and one for the packets that arrived later. At the > end of an itera

[PATCH net-next 1/6] mlxsw: spectrum_span: Add SPAN session identifier support

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel When packets are mirrored to the CPU, the trap identifier with which the packets are trapped is determined according to the session identifier of the SPAN agent performing the mirroring. Packets that are trapped for the same logical reason (e.g., buffer drops) should use the sa

[PATCH net-next 4/6] mlxsw: spectrum_matchall: Split sampling support between ASICs

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel Sampling of ingress packets is supported using a dedicated sampling mechanism on all Spectrum ASICs. However, Spectrum-2 and later ASICs support more sophisticated sampling by mirroring packets to the CPU. As a preparation for more advanced sampling configurations, split the s

[PATCH net-next 3/6] mlxsw: spectrum_span: Add SPAN probability rate support

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel Currently, every packet that matches a mirroring trigger (e.g., received packets, buffer dropped packets) is mirrored. Spectrum-2 and later ASICs support mirroring with probability, where every 1 in N matched packets is mirrored. Extend the API that creates the binding between

[PATCH net-next 2/6] mlxsw: reg: Extend mirroring registers with probability rate field

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel The MPAR and MPAGR registers are used to configure the binding between the mirroring trigger (e.g., received packet) and the SPAN agent. Add probability rate field, which will allow us to support sampling by mirroring to the CPU. Signed-off-by: Ido Schimmel Reviewed-by: Jiri

[PATCH net-next 0/6] mlxsw: Implement sampling using mirroring

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel So far, sampling was implemented using a dedicated sampling mechanism that is available on all Spectrum ASICs. Spectrum-2 and later ASICs support sampling by mirroring packets to the CPU port with probability. This method has a couple of advantages compared to the legacy method

[PATCH net-next 6/6] mlxsw: spectrum_matchall: Implement sampling using mirroring

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel Spectrum-2 and later ASICs support sampling of packets by mirroring to the CPU with probability. There are several advantages compared to the legacy dedicated sampling mechanism: * Extra metadata per-packet: Egress port, egress traffic class, traffic class occupancy and end-

[PATCH net-next 5/6] mlxsw: spectrum_trap: Split sampling traps between ASICs

2021-03-11 Thread Ido Schimmel
From: Ido Schimmel Sampling of ingress packets is supported using a dedicated sampling mechanism on all Spectrum ASICs. However, Spectrum-2 and later ASICs support more sophisticated sampling by mirroring packets to the CPU. As a preparation for more advanced sampling configurations, split the t

[PATCH] kernel/bpf/: fix misspellings using codespell tool

2021-03-11 Thread menglong8 . dong
From: Liu xuzhi A typo is found out by codespell tool in 34th lines of hashtab.c: $ codespell ./kernel/bpf/ ./hashtab.c:34 : differrent ==> different Fix a typo found by codespell. Signed-off-by: Liu xuzhi --- kernel/bpf/hashtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[PATCH V2 net-next 1/2] dt-bindings: net: bcm4908-enet: add optional TX interrupt

2021-03-11 Thread Rafał Miłecki
From: Rafał Miłecki I discovered that hardware actually supports two interrupts, one per DMA channel (RX and TX). Signed-off-by: Rafał Miłecki --- .../bindings/net/brcm,bcm4908-enet.yaml | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/Documentatio

[PATCH V2 net-next 2/2] net: broadcom: bcm4908_enet: support TX interrupt

2021-03-11 Thread Rafał Miłecki
From: Rafał Miłecki It appears that each DMA channel has its own interrupt and both rings can be configured (the same way) to handle interrupts. 1. Make ring interrupts code generic (make it operate on given ring) 2. Move napi to ring (so each has its own) 3. Make IRQ handler generic (match ring

[PATCH bpf-next] bpf: Make symbol 'bpf_task_storage_busy' static

2021-03-11 Thread 'Wei Yongjun
From: Wei Yongjun The sparse tool complains as follows: kernel/bpf/bpf_task_storage.c:23:1: warning: symbol '__pcpu_scope_bpf_task_storage_busy' was not declared. Should it be static? This symbol is not used outside of bpf_task_storage.c, so this commit marks it static. Fixes: bc235cdb423a (

RE: [RFC PATCH 05/10] ena: Update driver to use ethtool_gsprintf

2021-03-11 Thread Kiyanovski, Arthur
> -Original Message- > From: Alexander Duyck > Sent: Thursday, March 11, 2021 3:36 AM > To: k...@kernel.org > Cc: netdev@vger.kernel.org; oss-driv...@netronome.com; > simon.hor...@netronome.com; yisen.zhu...@huawei.com; > salil.me...@huawei.com; intel-wired-...@lists.osuosl.org; > jesse.br

[PATCH 2/2] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails

2021-03-11 Thread Stefano Garzarella
In vhost_vdpa_set_config_call() if eventfd_ctx_fdget() fails the 'v->config_ctx' contains an error instead of a valid pointer. Since we consider 'v->config_ctx' valid if it is not NULL, we should set it to NULL in this case to avoid to use an invalid pointer in other functions such as vhost_vdpa_c

[PATCH 0/2] vhost-vdpa: fix issues around v->config_ctx handling

2021-03-11 Thread Stefano Garzarella
While writing a test for a Rust library [1] to handle vhost-vdpa devices, I experienced the 'use-after-free' issue fixed in patch 1, then I discovered the potential issue when eventfd_ctx_fdget() fails fixed in patch 2. Do you think it might be useful to write a vdpa test suite, perhaps using this

[PATCH 1/2] vhost-vdpa: fix use-after-free of v->config_ctx

2021-03-11 Thread Stefano Garzarella
When the 'v->config_ctx' eventfd_ctx reference is released we didn't set it to NULL. So if the same character device (e.g. /dev/vhost-vdpa-0) is re-opened, the 'v->config_ctx' is invalid and calling again vhost_vdpa_config_put() causes use-after-free issues like the following refcount_t underflow:

Re: [PATCH] tracing: remove holes in events

2021-03-11 Thread Steven Rostedt
On Thu, 11 Mar 2021 17:44:15 +0800 Tony Lu wrote: > --- > include/trace/events/net.h| 42 +-- > include/trace/events/qdisc.h | 4 ++-- > include/trace/events/sunrpc.h | 4 ++-- > include/trace/events/tcp.h| 2 +- > 4 files changed, 26 insertions(+), 26

[syzbot] WARNING in netlink_broadcast_filtered

2021-03-11 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:a74e6a01 Merge tag 's390-5.12-3' of git://git.kernel.org/p.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=16f7c83ad0 kernel config: https://syzkaller.appspot.com/x/.config?x=c7ac5ce2d1160e16 das

Re: [RFC net-next v2 3/3] devlink: add more failure modes

2021-03-11 Thread Eran Ben Elisha
On 3/11/2021 5:26 AM, Jakub Kicinski wrote: Pending vendors adding the right reporters. << Would you like Nvidia to reply with the remedy per reporter or to actually prepare the patch? Extend the applicability of devlink health reporters beyond what can be locally remedied. Add failure

Re: [PATCH 3/5] SUNRPC: Refresh rq_pages using a bulk page allocator

2021-03-11 Thread Chuck Lever III
> On Mar 11, 2021, at 6:49 AM, Mel Gorman wrote: > > From: Chuck Lever > > Reduce the rate at which nfsd threads hammer on the page allocator. > This improve throughput scalability by enabling the threads to run > more independently of each other. Mel, if you should repost this series: ^imp

Re: [RFC net-next v2 2/3] devlink: health: add remediation type

2021-03-11 Thread Eran Ben Elisha
On 3/11/2021 5:26 AM, Jakub Kicinski wrote: Currently devlink health does not give user any clear information of what kind of remediation ->recover callback will perform. This makes it difficult to understand the impact of enabling auto- -remediation, and the severity of the error itself. To

[PATCH net 0/2] Bugfixes for HTB

2021-03-11 Thread Maxim Mikityanskiy
The HTB offload feature introduced a few bugs in HTB. One affects the non-offload mode, preventing attaching qdiscs to HTB classes, and the other affects the error flow, when the netdev doesn't support the offload, but it was requested. This short series fixes them. Maxim Mikityanskiy (2): sch_h

[PATCH net 2/2] sch_htb: Fix offload cleanup in htb_destroy on htb_init failure

2021-03-11 Thread Maxim Mikityanskiy
htb_init may fail to do the offload if it's not supported or if a runtime error happens when allocating direct qdiscs. In those cases TC_HTB_CREATE command is not sent to the driver, however, htb_destroy gets called anyway and attempts to send TC_HTB_DESTROY. It shouldn't happen, because the drive

[PATCH net 1/2] sch_htb: Fix select_queue for non-offload mode

2021-03-11 Thread Maxim Mikityanskiy
htb_select_queue assumes it's always the offload mode, and it ends up in calling ndo_setup_tc without any checks. It may lead to a NULL pointer dereference if ndo_setup_tc is not implemented, or to an error returned from the driver, which will prevent attaching qdiscs to HTB classes in the non-offl

Re: [RFC v2 3/5] arm64: socfpga: rename ARCH_STRATIX10 to ARCH_SOCFPGA64

2021-03-11 Thread Krzysztof Kozlowski
On 11/03/2021 10:14, Arnd Bergmann wrote: > On Thu, Mar 11, 2021 at 8:08 AM Krzysztof Kozlowski > wrote: >> On 10/03/2021 17:42, Arnd Bergmann wrote: >>> On Wed, Mar 10, 2021 at 4:54 PM Krzysztof Kozlowski >>> wrote: On 10/03/2021 16:47, Krzysztof Kozlowski wrote: > This edac Altera driv

Re: [PATCH net-next 01/14] nexthop: Pass nh_config to replace_nexthop()

2021-03-11 Thread David Ahern
On 3/10/21 8:02 AM, Petr Machata wrote: > Currently, replace assumes that the new group that is given is a > fully-formed object. But mpath groups really only have one attribute, and > that is the constituent next hop configuration. This may not be universally > true. From the usability perspective

Re: [PATCH net-next 02/14] nexthop: __nh_notifier_single_info_init(): Make nh_info an argument

2021-03-11 Thread David Ahern
On 3/10/21 8:02 AM, Petr Machata wrote: > The cited function currently uses rtnl_dereference() to get nh_info from a > handed-in nexthop. However, under the resilient hashing scheme, this > function will not always be called under RTNL, sometimes the mutual > exclusion will be achieved differently.

[PATCH v3 00/15] arm64 / clk: socfpga: simplifying, cleanups and compile testing

2021-03-11 Thread Krzysztof Kozlowski
Hi, All three Intel arm64 SoCFPGA architectures (Agilex, N5X and Stratix 10) are basically flavors/platforms of the same architecture. At least from the Linux point of view. Up to a point that N5X and Agilex share DTSI. Having three top-level architectures for the same one barely makes sense and

[PATCH v3 01/15] clk: socfpga: allow building N5X clocks with ARCH_N5X

2021-03-11 Thread Krzysztof Kozlowski
The Intel's eASIC N5X (ARCH_N5X) architecture shares a lot with Agilex (ARCH_AGILEX) so it uses the same socfpga_agilex.dtsi, with minor changes. Also the clock drivers are the same. However the clock drivers won't be build without ARCH_AGILEX. One could assume that ARCH_N5X simply depends on AR

[PATCH v3 02/15] ARM: socfpga: introduce common ARCH_INTEL_SOCFPGA

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. This the common practice for other platforms. Additionally, the ARCH_SOCFPGA is too generic as SoCFPGA designs come from multiple vendors. Signed-off-by: Krzysztof Kozlowski --- arch/arm/Kconfig

[PATCH v3 03/15] mfd: altera: merge ARCH_SOCFPGA and ARCH_STRATIX10

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. This the common practice for other platforms. Additionally, the ARCH_SOCFPGA is too generic as SoCFPGA designs come from multiple vendors. The side effect is that the MFD_ALTERA_A10SR will now be availab

[PATCH v3 05/15] clk: socfpga: build together Stratix 10, Agilex and N5X clock drivers

2021-03-11 Thread Krzysztof Kozlowski
On a multiplatform kernel there is little benefit in splitting each clock driver per platform because space savings are minimal. Such split also complicates the code, especially after adding compile testing. Build all arm64 Intel SoCFPGA clocks together with one entry in Makefile. This also remo

[PATCH v3 06/15] clk: socfpga: merge ARCH_SOCFPGA and ARCH_STRATIX10

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. This the common practice for other platforms. Additionally, the ARCH_SOCFPGA is too generic as SoCFPGA designs come from multiple vendors. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/Makefile |

[PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA

2021-03-11 Thread Krzysztof Kozlowski
Agilex, N5X and Stratix 10 share all quite similar arm64 hard cores and SoC-part. Up to a point that N5X uses the same DTSI as Agilex. From the Linux kernel point of view these are flavors of the same architecture so there is no need for three top-level arm64 architectures. Simplify this by merg

[PATCH v3 04/15] net: stmmac: merge ARCH_SOCFPGA and ARCH_STRATIX10

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. This the common practice for other platforms. Additionally, the ARCH_SOCFPGA is too generic as SoCFPGA designs come from multiple vendors. Signed-off-by: Krzysztof Kozlowski --- drivers/net/ethernet/st

[PATCH v3 07/15] EDAC: altera: merge ARCH_SOCFPGA and ARCH_STRATIX10

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. This the common practice for other platforms. Additionally, the ARCH_SOCFPGA is too generic as SoCFPGA designs come from multiple vendors. Signed-off-by: Krzysztof Kozlowski --- drivers/edac/Kconfig

[PATCH v3 09/15] clk: socfpga: allow compile testing of Stratix 10 / Agilex clocks

2021-03-11 Thread Krzysztof Kozlowski
The Stratix 10 / Agilex / N5X clocks do not use anything other than OF or COMMON_CLK so they should be compile testable on most of the platforms. Signed-off-by: Krzysztof Kozlowski --- drivers/clk/Makefile| 2 +- drivers/clk/socfpga/Kconfig | 15 --- 2 files changed, 13 inse

[PATCH v3 12/15] fpga: altera: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs

2021-03-11 Thread Krzysztof Kozlowski
ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the 32-bit ARM drivers to rely on new symbol. Signed-off-by: Krzysztof Kozlowski --- drivers/fpga/Kconfig | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig index fd32

[PATCH v3 13/15] i2c: altera: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs

2021-03-11 Thread Krzysztof Kozlowski
ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the 32-bit ARM drivers to rely on new symbol. The side effect is that the I2C_ALTERA will now be available for both 32-bit and 64-bit Intel SoCFPGA, even though it is used only for 32-bit. Signed-off-by: Krzysztof Kozlowski --- drive

[PATCH v3 15/15] ARM: socfpga: drop ARCH_SOCFPGA

2021-03-11 Thread Krzysztof Kozlowski
Simplify 32-bit and 64-bit Intel SoCFPGA Kconfig options by having only one for both of them. After conversion of all drivers to use the new ARCH_INTEL_SOCFPGA, the remaining ARM option can be removed. Signed-off-by: Krzysztof Kozlowski --- arch/arm/configs/multi_v7_defconfig | 2 +- arch/arm/c

[PATCH v3 10/15] clk: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs (and compile test)

2021-03-11 Thread Krzysztof Kozlowski
ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the 32-bit ARM drivers to rely on new symbol. There is little point to share clock controller drivers between 32-bit and 64-bit platforms because there will not be a generic image for both of them. Therefore add a new Kconfig entry for

[PATCH v3 14/15] reset: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs

2021-03-11 Thread Krzysztof Kozlowski
ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the 32-bit ARM drivers to rely on new symbol. Signed-off-by: Krzysztof Kozlowski --- drivers/reset/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index b1e

[PATCH v3 11/15] dmaengine: socfpga: use ARCH_INTEL_SOCFPGA also for 32-bit ARM SoCs

2021-03-11 Thread Krzysztof Kozlowski
ARCH_SOCFPGA is being renamed to ARCH_INTEL_SOCFPGA so adjust the 32-bit ARM drivers to rely on new symbol. Signed-off-by: Krzysztof Kozlowski --- drivers/dma/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig index 0c2827fd8c19.

Re: [PATCH net-next 03/14] nexthop: Add a dedicated flag for multipath next-hop groups

2021-03-11 Thread David Ahern
On 3/10/21 8:02 AM, Petr Machata wrote: > With the introduction of resilient nexthop groups, there will be two types > of multipath groups: the current hash-threshold "mpath" ones, and resilient > groups. Both are multipath, but to determine the fact, the system needs to > consider two flags. This

Re: [PATCH net-next 04/14] nexthop: Add netlink defines and enumerators for resilient NH groups

2021-03-11 Thread David Ahern
On 3/10/21 8:02 AM, Petr Machata wrote: > diff --git a/include/uapi/linux/nexthop.h b/include/uapi/linux/nexthop.h > index 2d4a1e784cf0..8efebf3cb9c7 100644 > --- a/include/uapi/linux/nexthop.h > +++ b/include/uapi/linux/nexthop.h > @@ -22,6 +22,7 @@ struct nexthop_grp { > > enum { > NEXTH

Re: [PATCH net-next 03/14] nexthop: Add a dedicated flag for multipath next-hop groups

2021-03-11 Thread Petr Machata
David Ahern writes: >> diff --git a/include/net/nexthop.h b/include/net/nexthop.h >> index 7bc057aee40b..5062c2c08e2b 100644 >> --- a/include/net/nexthop.h >> +++ b/include/net/nexthop.h >> @@ -80,6 +80,7 @@ struct nh_grp_entry { >> struct nh_group { >> struct nh_group *spare; /*

Re: [PATCH 1/2] net: core: datagram.c: Fix use of assignment in if condition

2021-03-11 Thread kernel test robot
Hi Shubhankar, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] [also build test ERROR on linus/master v5.12-rc2 next-20210311] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH v2 bpf-next 02/17] selftests: xsk: remove struct ifaceconfigobj

2021-03-11 Thread Maciej Fijalkowski
ifaceconfigobj is not really useful, it is possible to keep the functionality and simplify the code. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 65 +++- tools/testing/selftests/bpf/xdpxceiver.h | 9 2 files changed, 30 insertions(+)

[PATCH v2 bpf-next 05/17] selftests: xsk: simplify frame traversal in dumping thread

2021-03-11 Thread Maciej Fijalkowski
Store offsets to each layer in a separate variables rather than compute them every single time. Signed-off-by: Björn Töpel Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 48 +++- 1 file changed, 22 insertions(+), 26 deletions(-) diff --git

[PATCH v2 bpf-next 00/17] AF_XDP selftests improvements & bpf_link

2021-03-11 Thread Maciej Fijalkowski
-- v1 of xsk's bpf_link support can be found here: https://lore.kernel.org/bpf/20210215154638.4627-1-maciej.fijalkow...@intel.com/ Changes since v1: - selftests improvements and test case for bpf_link persistence itself - do not unload netlink-based

[PATCH v2 bpf-next 04/17] selftests: xsk: remove inline keyword from source file

2021-03-11 Thread Maciej Fijalkowski
Follow the kernel coding style guidelines and let compiler do the decision about inlining. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.

[PATCH v2 bpf-next 01/17] selftests: xsk: don't call worker_pkt_dump() for stats test

2021-03-11 Thread Maciej Fijalkowski
For TEST_TYPE_STATS, worker_pkt_validate() that places frames onto pkt_buf is not called. Therefore, when dump mode is set, don't call worker_pkt_dump() for mentioned test type, so that it won't crash on pkt_buf() access. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiv

[PATCH v2 bpf-next 03/17] selftests: xsk: remove unused function

2021-03-11 Thread Maciej Fijalkowski
Probably it was ported from xdpsock but is not used anywhere. Signed-off-by: Maciej Fijalkowski --- tools/testing/selftests/bpf/xdpxceiver.c | 13 - 1 file changed, 13 deletions(-) diff --git a/tools/testing/selftests/bpf/xdpxceiver.c b/tools/testing/selftests/bpf/xdpxceiver.c inde

[PATCH v2 bpf-next 06/17] libbpf: xsk: use bpf_link

2021-03-11 Thread Maciej Fijalkowski
Currently, if there are multiple xdpsock instances running on a single interface and in case one of the instances is terminated, the rest of them are left in an inoperable state due to the fact of unloaded XDP prog from interface. Consider the scenario below: // load xdp prog and xskmap and add e

[PATCH v2 bpf-next 07/17] samples: bpf: do not unload prog within xdpsock

2021-03-11 Thread Maciej Fijalkowski
With the introduction of bpf_link in xsk's libbpf part, there's no further need for explicit unload of prog on xdpsock's termination. When process dies, the bpf_link's refcount will be decremented and resources will be unloaded/freed under the hood in case when there are no more active users. Whil

[PATCH v2 bpf-next 09/17] selftests: xsk: split worker thread

2021-03-11 Thread Maciej Fijalkowski
Let's a have a separate Tx/Rx worker threads instead of a one common thread packed with Tx/Rx specific checks. Move mmap for umem buffer space and a switch_namespace() call to thread_common_ops. This also allows for a bunch of simplifactions that are the subject of the next commits. The final res

[PATCH v2 bpf-next 10/17] selftests: xsk: remove Tx synchronization resources

2021-03-11 Thread Maciej Fijalkowski
Tx thread needs to be started after the Rx side is fully initialized so that packets are not xmitted until xsk Rx socket is ready to be used. It can be observed that atomic variable spinning_tx is not checked from Rx side in any way, so thread_common_ops can be modified to only address the spinnin

[PATCH v2 bpf-next 12/17] selftests: xsk: remove sync_mutex_tx and atomic var

2021-03-11 Thread Maciej Fijalkowski
Although thread_common_ops() are called in both Tx and Rx threads, testapp_validate() will not spawn Tx thread until Rx thread signals that it has finished its initialization via condition variable. Therefore, locking in thread_common_ops is not needed and furthermore Tx thread does not have to sp

[PATCH v2 bpf-next 13/17] veth: implement ethtool's get_channels() callback

2021-03-11 Thread Maciej Fijalkowski
Libbpf's xsk part calls get_channels() API to retrieve the queue count of the underlying driver so that XSKMAP is sized accordingly. Implement that in veth so multi queue scenarios can work properly. Signed-off-by: Maciej Fijalkowski --- drivers/net/veth.c | 12 1 file changed, 12

[PATCH v2 bpf-next 16/17] selftest: xsk: Remove mutex and condition variable

2021-03-11 Thread Maciej Fijalkowski
From: Björn Töpel The usage of the condition variable is broken, and overkill. Replace with a pthread barrier. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 33 tools/testing/selftests/bpf/xdpxceiver.h | 3 +-- 2 files changed, 6 insertions

[PATCH v2 bpf-next 14/17] selftests: xsk: implement bpf_link test

2021-03-11 Thread Maciej Fijalkowski
Introduce a test that is supposed to verify the persistence of BPF resources based on underlying bpf_link usage. Test will: 1) create and bind two sockets on queue ids 0 and 1 2) run a traffic on queue ids 0 3) remove xsk sockets from queue 0 on both veth interfaces 4) run a traffic on queues ids

[PATCH v2 bpf-next 15/17] selftests: xsk: remove thread attribute

2021-03-11 Thread Maciej Fijalkowski
From: Björn Töpel There is really no reason to have a non-default thread stack size. Remove that. Signed-off-by: Björn Töpel --- tools/testing/selftests/bpf/xdpxceiver.c | 9 ++--- tools/testing/selftests/bpf/xdpxceiver.h | 2 -- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git

  1   2   3   4   >