bonding: 3ad: update slave arr after initialize

2021-04-15 Thread jin yiting
From 71e63af579edd15ad7f7395760a19f67d9a1d7d3 Mon Sep 17 00:00:00 2001 From: jin yiting Date: Wed, 31 Mar 2021 20:38:40 +0800 Subject: [PATCH] bonding: 3ad: update slave arr after initialize MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bond works

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

2021-04-15 Thread Matthieu Baerts
Hi David, Thank you for your very clear reply! On 15/04/2021 08:01, David Gow wrote: On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts wrote: Up to the KUnit maintainers to decide ;-) To summarise my view: personally, I'd prefer things the way this patch works: have everything end in _KUNIT_T

Different behavior wrt VRF and no VRF - packet Tx

2021-04-15 Thread Bala Sajja
When interfaces are not part of VRF and below ip address config is done on these interfaces, ping with -I (interface) option, we see packets transmitting out of the right interfaces. ip addr add 2.2.2.100 peer 1.1.1.100/32 dev enp0s3 ip addr add 2.2.2.100 peer 1.1.1.100/32 dev enp0s8 ping 1.

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-15 Thread Jason Wang
在 2021/4/15 下午2:36, Zhu Lingshan 写道: On 4/15/2021 2:30 PM, Jason Wang wrote: 在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id

Re: Different behavior wrt VRF and no VRF - packet Tx

2021-04-15 Thread Bala Sajja
Forgot to mention Linux version: Linux DR1 4.19.0-16-amd64 #1 SMP Debian 4.19.181-1 (2021-03-19) x86_64 GNU/Linux On Thu, Apr 15, 2021 at 12:45 PM Bala Sajja wrote: > > When interfaces are not part of VRF and below ip address config is > done on these interfaces, ping with -I (interface) option,

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-15 Thread Jason Wang
在 2021/4/15 下午2:41, Zhu Lingshan 写道: I think we've discussed this sometime in the past but what's the reason for such whitelist consider there's already a get_features() implemention? E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or VIRTIO_F_RING_PACKED? Thanks The reason is some fea

[PATCH] selftests: xfrm: put cleanup code into a exit trap

2021-04-15 Thread Po-Hsu Lin
If the xfrm_policy.sh script takes longer than the default kselftest framework 45 seconds timeout to run, it will be terminated and thus leave those netns namespace files created by the test alone. In this case a second attempt will fail with: # Cannot create namespace file "/run/netns/ns1": Fil

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Stefan Hajnoczi
On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote: > > > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > > > VDUSE (vDPA Device in Userspace) is a framework to support > > > implementing software-emulated vDPA devic

Re: [PATCH 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-15 Thread Zhu Lingshan
On 4/15/2021 3:16 PM, Jason Wang wrote: 在 2021/4/15 下午2:36, Zhu Lingshan 写道: On 4/15/2021 2:30 PM, Jason Wang wrote: 在 2021/4/15 下午1:52, Zhu Lingshan 写道: On 4/15/2021 11:30 AM, Jason Wang wrote: 在 2021/4/14 下午5:18, Zhu Lingshan 写道: This commit deduces VIRTIO device ID as device typ

Re: [PATCH 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-15 Thread Zhu Lingshan
On 4/15/2021 3:17 PM, Jason Wang wrote: 在 2021/4/15 下午2:41, Zhu Lingshan 写道: I think we've discussed this sometime in the past but what's the reason for such whitelist consider there's already a get_features() implemention? E.g Any reason to block VIRTIO_BLK_F_WRITE_ZEROS or VIRTIO_F_R

[PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Masahiro Yamada
Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler"), some kselftests fail to build. The tools/ directory opted out Kbuild, and went in a different direction. They copy any kind of files to the tools/ directory in order to do whatever they want to do in th

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 11:57:20, Aswath Govindraju wrote: > Hi Marc, > > On 14/04/21 9:03 pm, Marc Kleine-Budde wrote: > > On 14.04.2021 19:35:18, Aswath Govindraju wrote: > >> Add binding documentation for TI TCAN104x CAN transceivers. > >> > >> Signed-off-by: Aswath Govindraju > >> --- > >> .../binding

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Paolo Bonzini
On 15/04/21 09:27, Masahiro Yamada wrote: Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler"), some kselftests fail to build. The tools/ directory opted out Kbuild, and went in a different direction. They copy any kind of files to the tools/ directory i

Re: [PATCH net 2/3] net/xfrm: Add inner_ipproto into sec_path

2021-04-15 Thread Steffen Klassert
On Wed, Apr 14, 2021 at 04:25:39PM -0700, Saeed Mahameed wrote: > From: Huy Nguyen > > The inner_ipproto saves the inner IP protocol of the plain > text packet. This allows vendor's IPsec feature making offload > decision at skb's features_check and configuring hardware at > ndo_start_xmit. > >

[PATCH net 0/4] chelsio/ch_ktls: chelsio inline tls driver bug fixes

2021-04-15 Thread Vinay Kumar Yadav
This series of patches fix following bugs in Chelsio inline tls driver. Patch1: kernel panic. Patch2: connection close issue. Patch3: tcb close call issue. Patch4: unnecessary snd_una update. Vinay Kumar Yadav (4): ch_ktls: Fix kernel panic ch_ktls: fix device connection close ch_ktls: tcb c

[PATCH net 2/4] ch_ktls: fix device connection close

2021-04-15 Thread Vinay Kumar Yadav
When sge queue is full and chcr_ktls_xmit_wr_complete() returns failure, skb is not freed if it is not the last tls record in this skb, causes refcount never gets freed and tls_dev_del() never gets called on this connection. Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling") Signed-of

[PATCH net 1/4] ch_ktls: Fix kernel panic

2021-04-15 Thread Vinay Kumar Yadav
Taking page refcount is not ideal and causes kernel panic sometimes. It's better to take tx_ctx lock for the complete skb transmit, to avoid page cleanup if ACK received in middle. Fixes: 5a4b9fe7fece ("cxgb4/chcr: complete record tx handling") Signed-off-by: Vinay Kumar Yadav Signed-off-by: Rohi

[PATCH net 3/4] ch_ktls: tcb close causes tls connection failure

2021-04-15 Thread Vinay Kumar Yadav
HW doesn't need marking TCB closed. This TCB state change sometimes causes problem to the new connection which gets the same tid. Fixes: 34aba2c45024 ("cxgb4/chcr : Register to tls add and del callback") Signed-off-by: Vinay Kumar Yadav Signed-off-by: Rohit Maheshwari --- .../chelsio/inline_cry

[PATCH net 4/4] ch_ktls: do not send snd_una update to TCB in middle

2021-04-15 Thread Vinay Kumar Yadav
snd_una update should not be done when the same skb is being sent out.chcr_short_record_handler() sends it again even though SND_UNA update is already sent for the skb in chcr_ktls_xmit(), which causes mismatch in un-acked TCP seq number, later causes problem in sending out complete record. Fixes:

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread Du Cheng
Le Thu, Apr 15, 2021 at 08:56:09AM +0200, Eric Dumazet a écrit : > > > On 4/15/21 8:39 AM, Du Cheng wrote: > > There is a reproducible sequence from the userland that will trigger a > > WARN_ON() > > condition in taprio_get_start_time, which causes kernel to panic if > > configured > > as "pani

[PATCH v2] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread Du Cheng
There is a reproducible sequence from the userland that will trigger a WARN_ON() condition in taprio_get_start_time, which causes kernel to panic if configured as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by userland-initiated syscalls. Reported as bug on syzkaller: ht

[PATCH v2] net: sched: tapr: remove WARN_ON() in taprio_get_start_time

2021-04-15 Thread Du Cheng
There is a reproducible sequence from the userland that will trigger a WARN_ON() condition in taprio_get_start_time, which causes kernel to panic if configured as "panic_on_warn". Remove this WARN_ON() to prevent kernel from crashing by userland-initiated syscalls. Reported as bug on syzkaller: ht

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Masahiro Yamada
On Thu, Apr 15, 2021 at 4:40 PM Paolo Bonzini wrote: > > On 15/04/21 09:27, Masahiro Yamada wrote: > > Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to > > scripts/Makefile.compiler"), some kselftests fail to build. > > > > The tools/ directory opted out Kbuild, and went in a dif

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Christian Borntraeger
On 15.04.21 09:27, Masahiro Yamada wrote: Since commit d9f4ff50d2aa ("kbuild: spilt cc-option and friends to scripts/Makefile.compiler"), some kselftests fail to build. The tools/ directory opted out Kbuild, and went in a different direction. They copy any kind of files to the tools/ directory

Re: [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-15 Thread Stefano Garzarella
On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/i

Re: [Resend RFC PATCH V2 03/12] x86/Hyper-V: Add new hvcall guest address host visibility support

2021-04-15 Thread Tianyu Lan
Hi Christoph: Thanks for your review. On 4/14/2021 11:40 PM, Christoph Hellwig wrote: +/* + * hv_set_mem_host_visibility - Set host visibility for specified memory. + */ I don't think this comment really clarifies anything over the function name. What is 'host visibility' OK. Will u

Re: [PATCH 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-15 Thread Jason Wang
在 2021/4/15 下午4:12, Stefano Garzarella 写道: On Wed, Apr 14, 2021 at 05:18:32PM +0800, Zhu Lingshan wrote: get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 11 ++- 1 file changed, 10 insertions(

Re: [Resend RFC PATCH V2 04/12] HV: Add Write/Read MSR registers via ghcb

2021-04-15 Thread Tianyu Lan
On 4/14/2021 11:41 PM, Christoph Hellwig wrote: +EXPORT_SYMBOL_GPL(hv_ghcb_msr_write); Just curious, who is going to use all these exports? These seems like extremely low-level functionality. Isn't there a way to build a more useful higher level API? Yes, will remove it.

Re: [PATCH 2/2] tools: do not include scripts/Kbuild.include

2021-04-15 Thread Paolo Bonzini
On 15/04/21 10:04, Masahiro Yamada wrote: On Thu, Apr 15, 2021 at 4:40 PM Paolo Bonzini wrote: I think it would make sense to add try-run, cc-option and .DELETE_ON_ERROR to tools/build/Build.include? To be safe, I just copy-pasted what the makefiles need. If someone wants to refactor the tool

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread kernel test robot
documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Du-Cheng/net-sched-tapr-remove-WARN_ON-in-taprio_get_start_time/20210415-144126 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab54

Re: Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Thu, Apr 15, 2021 at 3:19 PM Stefan Hajnoczi wrote: > > On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: > > On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi > > wrote: > > > > > > On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: > > > > VDUSE (vDPA Device in Userspace)

Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Jason Wang
在 2021/4/15 下午3:19, Stefan Hajnoczi 写道: On Thu, Apr 15, 2021 at 01:38:37PM +0800, Yongji Xie wrote: On Wed, Apr 14, 2021 at 10:15 PM Stefan Hajnoczi wrote: On Wed, Mar 31, 2021 at 04:05:19PM +0800, Xie Yongji wrote: VDUSE (vDPA Device in Userspace) is a framework to support implementing sof

[PATCH][next] net: stmmac: replace redundant comparison with true

2021-04-15 Thread Colin King
From: Colin Ian King The comparison of the u32 variable queue with <= zero is always true since an unsigned can never be negative. Replace the conditional check with the boolean true to simplify the code. The while loop will terminate because of the zero check on queue before queue is decremente

Re: [Resend RFC PATCH V2 11/12] HV/Netvsc: Add Isolation VM support for netvsc driver

2021-04-15 Thread Tianyu Lan
On 4/14/2021 11:50 PM, Christoph Hellwig wrote: +struct dma_range { + dma_addr_t dma; + u32 mapping_size; +}; That's a rather generic name that is bound to create a conflict sooner or later. Good point. Will update. #include "hyperv_net.h" #include "netvsc_trace.h" +#in

[PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Colin King
From: Colin Ian King There is an assignment to *netdev that is can potentially be null but the null check is checking netdev and not *netdev as intended. Fix this by adding in the missing * operator. Addresses-Coverity: ("Dereference before null check") Fixes: 8537257874e9 ("can: etas_es58x: add

[PATCH] Bluetooth: 6lowpan: remove unused function

2021-04-15 Thread Jiapeng Chong
Fix the following clang warning: net/bluetooth/6lowpan.c:913:20: warning: unused function 'bdaddr_type' [-Wunused-function]. net/bluetooth/6lowpan.c:106:35: warning: unused function 'peer_lookup_ba' [-Wunused-function]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- net/bluetooth/6

[PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

2021-04-15 Thread Colin King
From: Colin Ian King The pointer cf is being null checked earlier in the code, however the update of the rx_bytes statistics is dereferencing cf without null checking cf. Fix this by moving the statement into the following code block that has a null cf check. Addresses-Coverity: ("Dereference a

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 09:55:35, Colin King wrote: > From: Colin Ian King > > The pointer cf is being null checked earlier in the code, however the > update of the rx_bytes statistics is dereferencing cf without null > checking cf. Fix this by moving the statement into the following code > block that has

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 09:47:23, Colin King wrote: > From: Colin Ian King > > There is an assignment to *netdev that is can potentially be null but the > null check is checking netdev and not *netdev as intended. Fix this by > adding in the missing * operator. > > Addresses-Coverity: ("Dereference before

Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Jason Wang
在 2021/4/15 下午4:36, Jason Wang 写道: Please state this explicitly at the start of the document. Existing interfaces like FUSE are designed to avoid trusting userspace. There're some subtle difference here. VDUSE present a device to kernel which means IOMMU is probably the only thing to prev

Panic in sfc module on boot since 5.10

2021-04-15 Thread Trevor Hemsley
Hi, I run Fedora 32 and since kernels in the 5.10 series I have been unable to boot without getting a panic in the sfc module. I tried on 5.11.12 tonight and the crash still occurs. I have tried reporting this via Fedora channels but the silence has been deafening and I suspect this is an ups

Re: [Debian-on-mobile-maintainers] Forking on MMSD

2021-04-15 Thread Guido Günther
Hi Chris, On Wed, Apr 14, 2021 at 02:46:30PM -0400, Chris Talbot wrote: > Hello, > > On Wed, 2021-04-14 at 20:30 +0200, Guido Günther wrote: > > Hi, > > On Wed, Apr 14, 2021 at 02:21:04PM -0400, Chris Talbot wrote: > > > Hello All, > > > > > > In talking to the Debian Developer Mr. Federico Cerat

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Aswath Govindraju
Hi Marc, On 15/04/21 1:08 pm, Marc Kleine-Budde wrote: > On 15.04.2021 11:57:20, Aswath Govindraju wrote: >> Hi Marc, >> >> On 14/04/21 9:03 pm, Marc Kleine-Budde wrote: >>> On 14.04.2021 19:35:18, Aswath Govindraju wrote: Add binding documentation for TI TCAN104x CAN transceivers.

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

2021-04-15 Thread Colin Ian King
On 15/04/2021 10:03, Marc Kleine-Budde wrote: > On 15.04.2021 09:55:35, Colin King wrote: >> From: Colin Ian King >> >> The pointer cf is being null checked earlier in the code, however the >> update of the rx_bytes statistics is dereferencing cf without null >> checking cf. Fix this by moving th

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 14:41:57, Aswath Govindraju wrote: > +++ b/Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > > Can you create a maintainers entry for this file with your address? > > I don't see this being done for other phy yamls in the > Documentation/devicetree/bindings/phy folder

[syzbot] INFO: trying to register non-static key in nfc_llcp_sock_unlink

2021-04-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:50987bec Merge tag 'trace-v5.12-rc7' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14d2cab1d0 kernel config: https://syzkaller.appspot.com/x/.config?x=b5591c832f889fd9 das

Re: [PATCH RFC net-next 0/3] Multi-CPU DSA support

2021-04-15 Thread Tobias Waldekranz
On Thu, Apr 15, 2021 at 02:39, Vladimir Oltean wrote: > On Wed, Apr 14, 2021 at 08:39:53PM +0200, Tobias Waldekranz wrote: >> In order to have two entries for the same destination, they must belong >> to different FIDs. But that FID is also used for automatic learning. So >> if all ports use their

[PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Kurt Kanzenbach
When using native XDP with the igb driver, the XDP frame data doesn't point to the beginning of the packet. It's off by 16 bytes. Everything works as expected with XDP skb mode. Actually these 16 bytes are used to store the packet timestamps. Therefore, pull the timestamp before executing any XDP

Re: [PATCHv7 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue

2021-04-15 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > On Wed, Apr 14, 2021 at 05:17:11PM -0700, Martin KaFai Lau wrote: >> > static void bq_xmit_all(struct xdp_dev_bulk_queue *bq, u32 flags) >> > { >> >struct net_device *dev = bq->dev; >> > - int sent = 0, err = 0; >> > + int sent = 0, drops = 0, err = 0; >> > + unsign

[PATCH v2 net-next 0/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-15 Thread Tobias Waldekranz
This is a continuation of the work started in this patch: https://lore.kernel.org/netdev/20210323102326.3677940-1-tob...@waldekranz.com/ In addition to the mv88e6xxx support to dynamically change the protocol, it is now possible to override the protocol from the device tree. This means that when a

[PATCH v2 net-next 1/5] net: dsa: mv88e6xxx: Mark chips with undocumented EDSA tag support

2021-04-15 Thread Tobias Waldekranz
All devices are capable of using regular DSA tags. Support for Ethertyped DSA tags sort into three categories: 1. No support. Older chips fall into this category. 2. Full support. Datasheet explicitly supports configuring the CPU port to receive FORWARDs with a DSA tag. 3. Undocumented suppor

[PATCH v2 net-next 3/5] net: dsa: Only notify CPU ports of changes to the tag protocol

2021-04-15 Thread Tobias Waldekranz
Previously DSA ports were also included, on the assumption that the protocol used by the CPU port had to the matched throughout the entire tree. As there is not yet any consumer in need of this, drop the call. Signed-off-by: Tobias Waldekranz --- net/dsa/switch.c | 25 +++--

[PATCH v2 net-next 2/5] net: dsa: mv88e6xxx: Allow dynamic reconfiguration of tag protocol

2021-04-15 Thread Tobias Waldekranz
For devices that supports both regular and Ethertyped DSA tags, allow the user to change the protocol. Additionally, because there are ethernet controllers that do not handle regular DSA tags in all cases, also allow the protocol to be changed on devices with undocumented support for EDSA. But, in

[PATCH v2 net-next 5/5] dt-bindings: net: dsa: Document dsa,tag-protocol property

2021-04-15 Thread Tobias Waldekranz
The 'dsa,tag-protocol' is used to force a switch tree to use a particular tag protocol, typically because the Ethernet controller that it is connected to is not compatible with the default one. Signed-off-by: Tobias Waldekranz --- Documentation/devicetree/bindings/net/dsa/dsa.yaml | 9 +

[PATCH v2 net-next 4/5] net: dsa: Allow default tag protocol to be overridden from DT

2021-04-15 Thread Tobias Waldekranz
Some combinations of tag protocols and Ethernet controllers are incompatible, and it is hard for the driver to keep track of these. Therefore, allow the device tree author (typically the board vendor) to inform the driver of this fact by selecting an alternate protocol that is known to work. Sign

[PATCH v2 1/2] net: phy: add genphy_c45_pma_suspend/resume

2021-04-15 Thread Radu Pirea (NXP OSS)
Add generic PMA suspend and resume callback functions for C45 PHYs. Signed-off-by: Radu Pirea (NXP OSS) --- drivers/net/phy/phy-c45.c | 43 +++ include/linux/phy.h | 2 ++ 2 files changed, 45 insertions(+) diff --git a/drivers/net/phy/phy-c45.c b/drive

[PATCH v2 0/2] TJA1103 driver

2021-04-15 Thread Radu Pirea (NXP OSS)
Hi, This small series adds the TJA1103 PHY driver. Changes in v2: - implemented genphy_c45_pma_suspend/genphy_c45_pma_suspend - set default internal delays set to 2ns(90 degrees) - added "VEND1_" prefix to the register definitions - disable rxid in case of txid - disable txid in case of rxid

[PATCH v2 2/2] phy: nxp-c45: add driver for tja1103

2021-04-15 Thread Radu Pirea (NXP OSS)
Add driver for tja1103 driver and for future NXP C45 PHYs. Signed-off-by: Radu Pirea (NXP OSS) --- MAINTAINERS | 6 + drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/nxp-c45-tja11xx.c | 607

Re: [PATCHv7 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support

2021-04-15 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > On Wed, Apr 14, 2021 at 05:23:50PM -0700, Martin KaFai Lau wrote: >> On Wed, Apr 14, 2021 at 08:26:08PM +0800, Hangbin Liu wrote: >> [ ... ] >> >> > +static __always_inline int __bpf_xdp_redirect_map(struct bpf_map *map, >> > u32 ifindex, >> > +

[PATCH bpf-next 1/2] bpf: Remove bpf_jit_enable=2 debugging mode

2021-04-15 Thread Jianlin Lv
For debugging JITs, dumping the JITed image to kernel log is discouraged, "bpftool prog dump jited" is much better way to examine JITed dumps. This patch get rid of the code related to bpf_jit_enable=2 mode and update the proc handler of bpf_jit_enable, also added auxiliary information to explain h

[PATCH bpf-next 2/2] docs: bpf: bpf_jit_enable mode changed

2021-04-15 Thread Jianlin Lv
Remove information about bpf_jit_enable=2 mode and added description for how to use the bpf_jit_disasm tool after get rid of =2 mode. Signed-off-by: Jianlin Lv --- Documentation/admin-guide/sysctl/net.rst | 1 - Documentation/networking/filter.rst | 25 ++-- 2 files cha

[PATCH net-next] net: ethernet: mediatek: fix typo in offload code

2021-04-15 Thread DENG Qingfang
.key_offset was assigned to .head_offset instead. Fix the typo. Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support") Signed-off-by: DENG Qingfang --- drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dri

Re: [PATCH] net: sched: tapr: remove WARN_ON() in taprio_get_start_time()

2021-04-15 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Du-Cheng/net-sched-tapr-remove-WARN_ON-in-taprio_get_start_time/20210415-144126 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7f75285ca572eaabc028cf78c6ab5473d0d16

Re: [RFC v4 net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-15 Thread DENG Qingfang
On Tue, Apr 13, 2021 at 02:12:59PM +0100, Russell King - ARM Linux admin wrote: > On Tue, Apr 13, 2021 at 11:59:20AM +0800, DENG Qingfang wrote: > > Within 12 hours, I got some spontaneous link down/ups when EEE is enabled: > > > > [16334.236233] mt7530 mdio-bus:1f wan: Link is Down > > [16334.241

[syzbot] KASAN: use-after-free Write in nfc_llcp_local_put

2021-04-15 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:50987bec Merge tag 'trace-v5.12-rc7' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=15680319d0 kernel config: https://syzkaller.appspot.com/x/.config?x=b5591c832f889fd9 das

[PATCH V2 0/3] vDPA/ifcvf: enables Intel C5000X-PL virtio-blk

2021-04-15 Thread Zhu Lingshan
This series enabled Intel FGPA SmartNIC C5000X-PL virtio-blk for vDPA. This series requires: Stefano's vdpa block patchset: https://lkml.org/lkml/2021/3/15/2113 my patchset to enable Intel FGPA SmartNIC C5000X-PL virtio-net for vDPA: https://lkml.org/lkml/2021/3/17/432 changes from V1: (1)add com

[PATCH V2 1/3] vDPA/ifcvf: deduce VIRTIO device ID when probe

2021-04-15 Thread Zhu Lingshan
This commit deduces VIRTIO device ID as device type when probe, then ifcvf_vdpa_get_device_id() can simply return the ID. ifcvf_vdpa_get_features() and ifcvf_vdpa_get_config_size() can work properly based on the device ID. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 1 + d

[PATCH V2 3/3] vDPA/ifcvf: get_config_size should return dev specific config size

2021-04-15 Thread Zhu Lingshan
get_config_size() should return the size based on the decected device type. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_main.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c ind

[PATCH V2 2/3] vDPA/ifcvf: enable Intel C5000X-PL virtio-block for vDPA

2021-04-15 Thread Zhu Lingshan
This commit enabled Intel FPGA SmartNIC C5000X-PL virtio-block for vDPA. Signed-off-by: Zhu Lingshan --- drivers/vdpa/ifcvf/ifcvf_base.h | 8 +++- drivers/vdpa/ifcvf/ifcvf_main.c | 10 +- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h

Re: [PATCH net-next] net: ethernet: mediatek: fix typo in offload code

2021-04-15 Thread Frank Wunderlich
Am 15. April 2021 11:40:05 MESZ schrieb DENG Qingfang : >.key_offset was assigned to .head_offset instead. Fix the typo. > >Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading >support") >Signed-off-by: DENG Qingfang Thanks for posting the fix,but imho commit-message is not good

Re: rtl8152 / power management kernel hang

2021-04-15 Thread Oliver Neukum
Am Dienstag, den 13.04.2021, 13:57 -0700 schrieb Thiago Macieira: > This has been happening for at least a year but I've only now decided to > report it. > > Kernel 5.11.11 > Symptom: > - partial kernel freeze > - some kernel tasks end up in state D and never leave it > (notably ipv6_addrcon

Re: [PATCH net v3] i40e: fix the panic when running bpf in xdpdrv mode

2021-04-15 Thread Jesper Dangaard Brouer
On Wed, 14 Apr 2021 19:06:52 -0700 Jesse Brandeburg wrote: > kerneljasonx...@gmail.com wrote: > > > From: Jason Xing > > > > Fix this panic by adding more rules to calculate the value of @rss_size_max > > which could be used in allocating the queues when bpf is loaded, which, > > however, coul

[PATCH v2 0/2] brcmfmac: support parse country code map from DT

2021-04-15 Thread Shawn Guo
This is a couple of patches adding optional brcm,ccode-map bindings for brcmfmac driver to parse country code map from DT. Changes for v2: - Rebase bindings patch on top of yaml conversion patch [1]. - Improve commit log with Arend's explanation on why this data could be put in device tree.

[PATCH v2 1/2] dt-bindings: bcm4329-fmac: add optional brcm,ccode-map

2021-04-15 Thread Shawn Guo
Add optional brcm,ccode-map property to support translation from ISO3166 country code to brcmfmac firmware country code and revision. The country revision is needed because the RF parameters that provide regulatory compliance are tweaked per platform/customer. So depending on the RF path tight to

[PATCH v2 2/2] brcmfmac: support parse country code map from DT

2021-04-15 Thread Shawn Guo
With any regulatory domain requests coming from either user space or 802.11 IE (Information Element), the country is coded in ISO3166 standard. It needs to be translated to firmware country code and revision with the mapping info in settings->country_codes table. Support populate country_codes tab

[PATCH hyperv-next] scsi: storvsc: Use blk_mq_unique_tag() to generate requestIDs

2021-04-15 Thread Andrea Parri (Microsoft)
Use blk_mq_unique_tag() to generate requestIDs for StorVSC, avoiding all issues with allocating enough entries in the VMbus requestor. Suggested-by: Michael Kelley Signed-off-by: Andrea Parri (Microsoft) --- Changes since RFC: - pass sentinel values for {init,reset}_request in vmbus_sendpacket

Re: Re: [PATCH v6 10/10] Documentation: Add documentation for VDUSE

2021-04-15 Thread Yongji Xie
On Thu, Apr 15, 2021 at 5:05 PM Jason Wang wrote: > > > 在 2021/4/15 下午4:36, Jason Wang 写道: > >>> > >> Please state this explicitly at the start of the document. Existing > >> interfaces like FUSE are designed to avoid trusting userspace. > > > > > > There're some subtle difference here. VDUSE pres

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Lorenzo Bianconi
[...] > @@ -8683,7 +8676,10 @@ static int igb_clean_rx_irq(struct igb_q_vector > *q_vector, const int budget) > while (likely(total_packets < budget)) { > union e1000_adv_rx_desc *rx_desc; > struct igb_rx_buffer *rx_buffer; > + ktime_t timestamp = 0; >

[PATCH][next] can: etas_es58x: Fix a couple of spelling mistakes

2021-04-15 Thread Colin King
From: Colin Ian King There are spelling mistakes in netdev_dbg and netdev_dbg messages, fix these. Signed-off-by: Colin Ian King --- drivers/net/can/usb/etas_es58x/es58x_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/can/usb/etas_es58x/es58x_core.c

Re: [PATCH][next] can: etas_es58x: Fix a couple of spelling mistakes

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 12:30:50, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in netdev_dbg and netdev_dbg messages, > fix these. > > Signed-off-by: Colin Ian King Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Vincent MAILHOL
On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > On 15.04.2021 09:47:23, Colin King wrote: > > From: Colin Ian King > > > > There is an assignment to *netdev that is can potentially be null but the ^^ Typo: that is can -> that can > > null check

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 20:42:36, Vincent MAILHOL wrote: > On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > > On 15.04.2021 09:47:23, Colin King wrote: > > > From: Colin Ian King > > > > > > There is an assignment to *netdev that is can potentially be null but the >

RE: [PATCH net v2]bonding: check port and aggregator when select

2021-04-15 Thread liaichun
> > Aichun Li wrote: > > > > >When the network service is repeatedly restarted in 802.3ad, there is > > >a low probability that oops occurs. > > >Test commands:systemctl restart network > > > > > >1.crash: __enable_port():port->slave is NULL > > [...] > > > PC: 00e2fcd0 [ad_agg_sel

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Jesper Dangaard Brouer
On Thu, 15 Apr 2021 11:21:45 +0200 Kurt Kanzenbach wrote: > When using native XDP with the igb driver, the XDP frame data doesn't point to > the beginning of the packet. It's off by 16 bytes. Everything works as > expected > with XDP skb mode. > > Actually these 16 bytes are used to store the p

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Kurt Kanzenbach
On Thu Apr 15 2021, Jesper Dangaard Brouer wrote: > On Thu, 15 Apr 2021 11:21:45 +0200 > Kurt Kanzenbach wrote: > >> When using native XDP with the igb driver, the XDP frame data doesn't point >> to >> the beginning of the packet. It's off by 16 bytes. Everything works as >> expected >> with XDP

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Nick Lowe
> Doesn't the i210 card use the igc driver? > This change is for igb driver. The igb driver is used for the i210/i211, not igc.

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Kurt Kanzenbach
On Thu Apr 15 2021, Lorenzo Bianconi wrote: > [...] >> @@ -8683,7 +8676,10 @@ static int igb_clean_rx_irq(struct igb_q_vector >> *q_vector, const int budget) >> while (likely(total_packets < budget)) { >> union e1000_adv_rx_desc *rx_desc; >> struct igb_rx_buffer *rx_

Re: [PATCH v3 net-next] net: multipath routing: configurable seed

2021-04-15 Thread Pavel Balaev
On Wed, Apr 14, 2021 at 08:24:11PM -0700, David Ahern wrote: > On 4/14/21 12:33 AM, Pavel Balaev wrote: > >> > >> This should work the same for IPv6. > > I wanted to add IPv6 support after IPv4 will be approved, > > anyway no problem, will add IPv6 in next version > >> And please add test cases un

Re: Panic in sfc module on boot since 5.10

2021-04-15 Thread Edward Cree
On 15/04/2021 10:03, Trevor Hemsley wrote: > Hi, > > I run Fedora 32 and since kernels in the 5.10 series I have been unable to > boot without getting a panic in the sfc module. I tried on 5.11.12 tonight > and the crash still occurs. I have tried reporting this via Fedora channels > but the si

Re: [PATCH net] igb: Fix XDP with PTP enabled

2021-04-15 Thread Jesper Dangaard Brouer
On Thu, 15 Apr 2021 14:16:36 +0200 Kurt Kanzenbach wrote: > On Thu Apr 15 2021, Jesper Dangaard Brouer wrote: > > On Thu, 15 Apr 2021 11:21:45 +0200 > > Kurt Kanzenbach wrote: > > > >> When using native XDP with the igb driver, the XDP frame data doesn't > >> point to > >> the beginning of th

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-15 Thread Tianyu Lan
Hi Stephen: Thanks for your review. On 4/15/2021 12:17 AM, Stephen Hemminger wrote: On Wed, 14 Apr 2021 17:45:51 +0200 Greg KH wrote: On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: From: Tianyu Lan UIO HV driver should not load in the isolation VM for security reason.

[PATCH v2 2/7] net: phy: micrel: KSZ8081 & KSZ9031: add loopback support

2021-04-15 Thread Oleksij Rempel
PHY loopback is needed for the ethernet controller self test support. This PHY was tested with the generic net sefltest in combination with FEC ethernet controller and SJA1105 switch. Signed-off-by: Oleksij Rempel --- drivers/net/phy/micrel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH v2 3/7] net: phy: at803x: AR8085 & AR9331: add loopback support

2021-04-15 Thread Oleksij Rempel
PHY loopback is needed for the ethernet controller self test support. This PHY was tested with the generic net sefltest in combination with FEC ethernet controller and AR9331 switch. Signed-off-by: Oleksij Rempel --- drivers/net/phy/at803x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/

[PATCH v2 1/7] net: phy: genphy_loopback: add link speed configuration

2021-04-15 Thread Oleksij Rempel
In case of loopback, in most cases we need to disable autoneg support and force some speed configuration. Otherwise, depending on currently active auto negotiated link speed, the loopback may or may not work. This patch was tested with following PHYs: TJA1102, KSZ8081, KSZ9031, AT8035, AR9331. Si

[PATCH v2 4/7] net: add generic selftest support

2021-04-15 Thread Oleksij Rempel
Port some parts of the stmmac selftest and reuse it as basic generic selftest library. This patch was tested with following combinations: - iMX6DL FEC -> AT8035 - iMX6DL FEC -> SJA1105Q switch -> KSZ8081 - iMX6DL FEC -> SJA1105Q switch -> KSZ9031 - AR9331 ag71xx -> AR9331 PHY - AR9331 ag71xx -> AR9

[PATCH net-next v2 0/7] provide generic net selftest support

2021-04-15 Thread Oleksij Rempel
changes v2: - make this tests available for all netowking devices. - enable them on FEC, ag71xx and all DSA switches. - add and test loopback support on more PHYs. This patch set provides diagnostic capabilities for some iMX, ag71xx or any DSA based devices. For proper functionality, PHY loopback

[PATCH v2 6/7] net: ag71xx: make use of generic NET_SELFTESTS library

2021-04-15 Thread Oleksij Rempel
With this patch the ag71xx on Atheros AR9331 will able to run generic net selftests. Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/atheros/Kconfig | 1 + drivers/net/ethernet/atheros/ag71xx.c | 20 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/dr

[PATCH v2 5/7] net: fec: make use of generic NET_SELFTESTS library

2021-04-15 Thread Oleksij Rempel
With this patch FEC on iMX will able to run generic net selftests Signed-off-by: Oleksij Rempel --- drivers/net/ethernet/freescale/Kconfig| 1 + drivers/net/ethernet/freescale/fec_main.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/net/ethernet/freescale/Kconfig b/dri

[PATCH v2 7/7] net: dsa: enable selftest support for all switches by default

2021-04-15 Thread Oleksij Rempel
Most of generic selftest should be able to work with probably all ethernet controllers. The DSA switches are not exception, so enable it by default at least for DSA. This patch was tested with SJA1105 and AR9331. Signed-off-by: Oleksij Rempel --- include/net/dsa.h | 2 ++ net/dsa/Kconfig |

Re: [Resend RFC PATCH V2 08/12] UIO/Hyper-V: Not load UIO HV driver in the isolation VM.

2021-04-15 Thread Tianyu Lan
On 4/14/2021 11:45 PM, Greg KH wrote: On Wed, Apr 14, 2021 at 10:49:41AM -0400, Tianyu Lan wrote: From: Tianyu Lan UIO HV driver should not load in the isolation VM for security reason. Return ENOTSUPP in the hv_uio_probe() in the isolation VM. Signed-off-by: Tianyu Lan --- drivers/uio/

  1   2   3   4   >