Re: [PATCH]Fix BUG of ip_rt_send_redirect()

2006-11-16 Thread Wei Yongjun
On Friday, November 17, 2006 11:51 AM Stephen Hemminger <[EMAIL PROTECTED]> wrote: On Thu, 16 Nov 2006 23:57:50 -0500 Li Yewang <[EMAIL PROTECTED]> wrote: [1]Summary of the problem: On IA32 system, If jiffies - b > 0x7fff, router can not send redirect packet.unsigned long b = rt->u.dst.rat

[PATCH] IPv6: Fix the return value of ipv6_getsockopt

2007-12-12 Thread Wei Yongjun
argument of ipv6_getsockopt is not supported by the kernel. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/ipv6/ipv6_sockglue.c 2007-12-11 04:33:00.0 -0500 +++ b/net/ipv6/ipv6_sockglue.c 2007-12-11 06:40:18.0 -0500 @@ -1046,7 +1046,7 @@ static int do_ipv6_gets

[PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-30 Thread Wei Yongjun
] [SSEQ 6] [PPID 0x87d8b423] 02:19:58.931690 sctp (1) [SACK] [cum ack 217114046] [a_rwnd 54784] [#gap acks 0] [#dup tsns 0] Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- net/sctp/sm_statefuns.c.orig2007-07-29 18:11:01.0 -0400 +++ net/sctp/sm_statefuns.c 2007-07-29

Re: [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-07-31 Thread Wei Yongjun
> On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: > >> On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: >> >>> If SCTP data sender received a SACK which contains Cumulative TSN Ack is >>> not less than the Cumulative TSN Ack Point, an

Re: [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-01 Thread Wei Yongjun
Sorry, coming in late due to list issues... Wei Yongjun wrote: On Tue, 2007-07-31 at 07:37 -0400, Neil Horman wrote: On Tue, Jul 31, 2007 at 12:44:27PM +0800, Wei Yongjun wrote: If SCTP data sender received a SACK which contains Cumulative TSN Ack is not less than

Re: [PATCH] SCTP: drop SACK if ctsn is not less than the next tsn of assoc

2007-08-02 Thread Wei Yongjun
g the association in this case since either the peer is a mis-behaved implementation, or the association is under attack. Patch has been modified base on comment. Thanks. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- net/sctp/sm_statefuns.c.orig2007-07-29 18:11:01.0 -0

[PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-05-31 Thread Wei Yongjun
says ICMP error message return as much as we can without exceeding 576 bytes. This patch has Fixed this BUG. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- net/ipv4/route.c.orig 2007-05-25 05:22:47.0 +0800 +++ net/ipv4/route.c2007-06-01 11:42:55.0 +0800 @@ -

Re: [PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-06-03 Thread Wei Yongjun
the received message's size: unsigned short old_mtu = ntohs(iph->tot_len); So maybe the patch would like following. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- net/ipv4/route.c.orig 2007-05-25 05:22:47.0 +0800 +++ net/ipv4/route.c2007-06-04 08:31:36.0

Re: [PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-06-03 Thread Wei Yongjun
On Mon, Jun 04, 2007 at 08:39:21AM +0800, Wei Yongjun wrote: Huh? The test new_mtu >= old_mtu should only hold if the sending router is buggy which is what the hack is for. Note here old_mtu is not the real old mtu, is the received message's size: unsigned short old_mtu = n

Re: [PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-06-03 Thread Wei Yongjun
On Mon, Jun 04, 2007 at 12:03:57PM +0800, Wei Yongjun wrote: So I want to know how the route announce a MTU larger then 576, such as 1280? RFC says ICMP error message return as much as we can without exceeding 576 bytes. I think there is a misunderstanding here. The RFC is talking

Re: [PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-06-03 Thread Wei Yongjun
iph->tot_len which is the length of field in the *original* IP header. We're certainly not allowed touch that field. Cheers, -- A new email address of FJWAN is launched from Apr.1 2007. The updated address is: [EMAIL PROTECTED] ------

[PATCH] IPv6: Fix kernel panic while send SCTP data with IP fragments

2007-08-19 Thread Wei Yongjun
c1 83 e1 03 74 02 f3 a4 29 45 08 0f 84 7b 01 00 00 01 EIP: [] skb_copy_bits+0x4f/0x1ef SS:ESP 0068:c0759adc Kernel panic - not syncing: Fatal exception in interrupt Following is the patch. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/ipv6/ip6_output.c 2007-08-14 10:36:03.

Re: [PATCH] IPv6: Fix kernel panic while send SCTP data with IP fragments

2007-08-19 Thread Wei Yongjun
Hi Arnaldo Carvalho de Melo: Em Mon, Aug 20, 2007 at 09:28:27AM +0800, Wei Yongjun escreveu: If ICMP6 message with "Packet Too Big" is received after send SCTP DATA, kernel panic will occur when SCTP DATA is send again. This is because of a bad dest address when call to skb

SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-26 Thread Wei Yongjun
th is set to zero, chunk->chunk_end will be never changed and process enter dead loop. Following is the patch. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/sctp/inqueue.c2007-08-25 10:53:45.0 -0400 +++ b/net/sctp/inqueue.c2007-08-26 05:45:57.0

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-29 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: A ootb chunk such as data in close state or init-ack in estab state will cause SCTP to enter dead loop. Look like this: (1) Endpoint A Endpoint B (Closed)(Closed) DATA

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-29 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an "out of the blue" (OOTB) packet if it is correctly formed (i.e., passed the receiver's CRC32c check; see Section 6.8), but the receiver is not able

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-30 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an "out of the blue" (OOTB) packet if it is correctly formed (i.e., passed the receiver's CR

Re: [Lksctp-developers] SCTP: Fix dead loop while received unexpected chunk with length set to zero

2007-08-31 Thread Wei Yongjun
Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: Wei Yongjun wrote: Vlad Yasevich wrote: NACK Section 8.4: An SCTP packet is called an "out of the blue" (OOTB) packet if it is correctly formed (i.e., passed the receiver's CR

[PATCH] NET: Fix function put_cmsg() which may cause usr application memory overflow

2007-12-17 Thread Wei Yongjun
~ err = 0; out: return err; } The same promble exists in put_cmsg_compat(). This patch can fix this problem. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/core/scm.c2007-12-11 08:41:57.0 -0500 +++ b/net/core/scm.c2007-12-11 12:10:25.0 -0500 @@ -1

[PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-01-21 Thread Wei Yongjun
4 Kernel panic - not syncing: Fatal exception in interrupt This patch fix this probleam to treat AUTH chunk as unknow chunk if peer has initialized with no auth capable. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/sctp/sm_statefuns.c 2008-01-21 00:03:

[PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-01-22 Thread Wei Yongjun
04 8b 54 24 04 e8 eb fe ff ff 85 c0 89 44 24 18 0f 84 84 EIP: [] sctp_auth_asoc_create_secret+0xe9/0x1a1 [sctp] SS:ESP 0068:c0756cc0 Kernel panic - not syncing: Fatal exception in interrupt This patch fix this problem. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/sct

[PATCH] SCTP: Fix kernel panic while received retransmitted ASCONF chunk 3 times

2008-01-26 Thread Wei Yongjun
f4 Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/sctp/sm_statefuns.c 2008-01-25 00:50:27.0 -0500 +++ b/net/sctp/sm_statefuns.c 2008-01-25 03:03:15.0 -0500 @@ -3420,9 +3420,10 @@ sctp

[PATCH] SCTP: Fix miss of report unrecognized HMAC Algorithm parameter

2008-01-27 Thread Wei Yongjun
This patch fix miss of check for report unrecognized HMAC Algorithm parameter. When AUTH is disabled, goto fall through path to report unrecognized parameter, else, just break. Wei Neil Horman wrote: On Wed, Jan 23, 2008 at 09:30:27AM +0900, Wei Yongjun wrote: This patch fix miss of check for

[PATCH v2] ibmvnic: fix to use list_for_each_safe() when delete items

2016-06-21 Thread Wei Yongjun
Since we will remove items off the list using list_del() we need to use a safe version of the list_for_each() macro aptly named list_for_each_safe(). Signed-off-by: Wei Yongjun --- drivers/net/ethernet/ibm/ibmvnic.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

Re: [PATCH] ibmvnic: fix to use list_for_each_safe() when delete items

2016-06-21 Thread Wei Yongjun
Hi Thomas Falcon, Thanks for found this. I will send new patch include your changes. Regards, Yongjun Wei On 06/22/2016 12:01 AM, Thomas Falcon wrote: On 06/20/2016 10:50 AM, Thomas Falcon wrote: On 06/17/2016 09:53 PM, weiyj...@163.com wrote: From: Wei Yongjun Since we will remove items

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk while enabled auth

2008-02-05 Thread Wei Yongjun
server AUTH---> Kernel Panic This patch fix this probleam to treat AUTH chunk as unknow chunk if peer has initialized with no auth capable. Sorry for the delay. Was on vacation without net access. Wei Yongjun wrote: This patch fix this probleam to treat AUTH chunk as

Re: [PATCH] SCTP: Fix kernel panic while received AUTH chunk with BAD shared key identifier

2008-02-05 Thread Wei Yongjun
On Tue, Jan 22, 2008 at 05:29:20PM +0900, Wei Yongjun wrote: FWIW, Ack from me. The assignment of NULL to key can safely be removed, since key_for_each (which is just list_for_each_entry under the covers does an initial assignment to key anyway). If the endpoint_shared_keys list is empty, or

[PATCH] SCTP: Fix kernel panic while received ASCONF chunk with bad serial number

2008-02-05 Thread Wei Yongjun
but a bogus pointer. Signed-off-by: Wei Yongjun <[EMAIL PROTECTED]> --- a/net/sctp/associola.c 2008-01-28 20:31:39.0 -0500 +++ b/net/sctp/associola.c 2008-01-28 23:45:20.0 -0500 @@ -1525,7 +1525,7 @@ struct sctp_chunk *sctp_assoc_l

Re: [PATCH] Can not send icmp netunreach packet

2008-02-26 Thread Wei Yongjun
Jarek Poplawski wrote: Maybe ip_error() does not handle the ESRCH error. In this place ESRCH eq to ENETUNREACH? static int ip_error(struct sk_buff *skb) { struct rtable *rt = (struct rtable*)skb->dst; unsigned long now; int code; switch (rt->u.dst.error) {

[PATCH net-next] ice: Fix error return code in ice_init_hw()

2018-03-28 Thread Wei Yongjun
Fix to return error code ICE_ERR_NO_MEMORY from the alloc error handling case instead of 0, as done elsewhere in this function. Fixes: dc49c7723676 ("ice: Get MAC/PHY/link info and scheduler topology") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/ice/ice_common.c | 4 ++

[PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()

2018-03-28 Thread Wei Yongjun
The devm_kfree function allocates memory that is released when a driver detaches. Also the driver core clears the driver data to NULL after device release. So remove the unnecessary pci_set_drvdata() and devm_kfree(). Signed-off-by: Wei Yongjun --- drivers/net/ethernet/hisilicon/hns3

[PATCH net-next] net: bcmgenet: return NULL instead of plain integer

2018-03-28 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/broadcom/genet/bcmgenet.c:1351:16: warning: Using plain integer as NULL pointer Signed-off-by: Wei Yongjun --- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH net-next] cxgb4: fix error return code in adap_init0()

2018-03-28 Thread Wei Yongjun
Fix to return a negative error code from the hash filter init error handling case instead of 0, as done elsewhere in this function. Fixes: 5c31254e35a8 ("cxgb4: initialize hash-filter configuration") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 3 +

[PATCH net-next] net: cavium: use module_pci_driver to simplify the code

2018-03-28 Thread Wei Yongjun
Use the module_pci_driver() macro to make the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/cavium/common/cavium_ptp.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next V2] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()

2018-03-29 Thread Wei Yongjun
ssary pci_set_drvdata() and devm_kfree(). Signed-off-by: Wei Yongjun --- v1 -> v2: change commit log --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet

[PATCH net-next] vlan: vlan_hw_filter_capable() can be static

2018-03-30 Thread Wei Yongjun
Fixes the following sparse warning: net/8021q/vlan_core.c:168:6: warning: symbol 'vlan_hw_filter_capable' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/8021q/vlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/8021q/vlan_co

[PATCH net-next] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Wei Yongjun
Return error code -EINVAL in the address len check error handling case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' in the for loop. Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg") Signed-off-by: Wei Yongj

[PATCH net-next] mlxsw: spectrum_kvdl: Make some functions static

2018-03-12 Thread Wei Yongjun
cc_get' was not declared. Should it be static? drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:397:5: warning: symbol 'mlxsw_sp_kvdl_large_chunks_occ_get' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c

[PATCH net-next v2] sctp: fix error return code in sctp_sendmsg_new_asoc()

2018-03-12 Thread Wei Yongjun
Return error code -EINVAL in the address len check error handling case since 'err' can be overwrite to 0 by 'err = sctp_verify_addr()' in the for loop. Fixes: 2c0dbaa0c43d ("sctp: add support for SCTP_DSTADDRV4/6 Information for sendmsg") Signed-off-by: Wei Yongjun

[PATCH net-next] net: aquantia: Make function hw_atl_utils_mpi_set_speed() static

2018-03-26 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:508:5: warning: symbol 'hw_atl_utils_mpi_set_speed' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c

[PATCH net-next] tipc: fix error handling in tipc_udp_enable()

2018-03-26 Thread Wei Yongjun
Release alloced resource before return from the error handling case in tipc_udp_enable(), otherwise will cause memory leak. Fixes: 52dfae5c85a4 ("tipc: obtain node identity from interface by default") Signed-off-by: Wei Yongjun --- net/tipc/udp_media.c | 3 ++- 1 file changed, 2

[PATCH net-next] tipc: tipc_node_create() can be static

2018-03-26 Thread Wei Yongjun
Fixes the following sparse warning: net/tipc/node.c:336:18: warning: symbol 'tipc_node_create' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/tipc/node.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/tipc/node.c b/net/tipc/no

[PATCH net-next] netfilter: nf_tables: fix a typo in nf_tables_getflowtable()

2018-01-09 Thread Wei Yongjun
Fix a typo, we should check 'flowtable' instead of 'table'. Fixes: 3b49e2e94e6e ("netfilter: nf_tables: add flow table netlink frontend") Signed-off-by: Wei Yongjun --- net/netfilter/nf_tables_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH net-next] netfilter: core: make local function __nf_unregister_net_hook static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: net/netfilter/core.c:380:6: warning: symbol '__nf_unregister_net_hook' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/netfilter/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilte

[PATCH net-next] i40e: Make local function i40e_get_link_speed static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/intel/i40e/i40e_main.c:5440:5: warning: symbol 'i40e_get_link_speed' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-01-09 Thread Wei Yongjun
Fix to return a negative error code from the xdp_rxq_info_reg() error handling case instead of 0, as done elsewhere in this function. Fixes: 0ddf543226ac ("xdp/mlx5: setup xdp_rxq_info") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 3 ++- 1 file

[PATCH net-next] tcp: make local function tcp_recv_timestamp static

2018-01-09 Thread Wei Yongjun
Fixes the following sparse warning: net/ipv4/tcp.c:1736:6: warning: symbol 'tcp_recv_timestamp' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/tcp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/t

[PATCH net-next] netfilter: nf_queue: remove duplicated include from nf_queue.c

2018-01-10 Thread Wei Yongjun
Remove duplicated include. Signed-off-by: Wei Yongjun --- net/netfilter/nf_queue.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_queue.c b/net/netfilter/nf_queue.c index 7f55af5..d67a96a 100644 --- a/net/netfilter/nf_queue.c +++ b/net/netfilter/nf_queue.c @@ -15,8 +15,6

[PATCH net-next] netfilter: nf_flow_table: remove duplicated include from nf_flow_table_ipv6.c

2018-01-10 Thread Wei Yongjun
Remove duplicated include. Signed-off-by: Wei Yongjun --- net/ipv6/netfilter/nf_flow_table_ipv6.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/ipv6/netfilter/nf_flow_table_ipv6.c b/net/ipv6/netfilter/nf_flow_table_ipv6.c index 0c3b9d3..fff2160 100644 --- a/net/ipv6/netfilter

[PATCH net-next] net: socionext: Fix error return code in netsec_netdev_open()

2018-01-11 Thread Wei Yongjun
Fix to return error code -ENODEV from the of_phy_connect() error handling case instead of 0, as done elsewhere in this function. Fixes: 533dd11a12f6 ("net: socionext: Add Synquacer NetSec driver") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/socionext/netsec.c | 1 + 1 file

[PATCH net-next] net: phy: mdio-bcm-unimac: fix potential NULL dereference in unimac_mdio_probe()

2018-01-11 Thread Wei Yongjun
+ if (!res) + return -EINVAL; ... when != res == NULL e = devm_ioremap(e1, res->start, e2); Signed-off-by: Wei Yongjun --- drivers/net/phy/mdio-bcm-unimac.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c index

[PATCH net-next] i40evf: use GFP_ATOMIC under spin lock

2018-01-11 Thread Wei Yongjun
A spin lock is taken here so we should use GFP_ATOMIC. Fixes: 504398f0a78e ("i40evf: use spinlock to protect (mac|vlan)_filter_list") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) di

[PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static

2018-01-15 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning: symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 2 +- 1 file

[PATCH -next] bpf: cpumap: make some functions static

2018-01-16 Thread Wei Yongjun
mbol 'cpu_map_free' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- kernel/bpf/cpumap.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/kernel/bpf/cpumap.c b/kernel/bpf/cpumap.c index ce5b669..d392826 100644 --- a/kernel/

[PATCH net-next] devlink: Make some functions static

2018-01-16 Thread Wei Yongjun
Fixes the following sparse warnings: net/core/devlink.c:2297:25: warning: symbol 'devlink_resource_find' was not declared. Should it be static? net/core/devlink.c:2322:6: warning: symbol 'devlink_resource_validate_children' was not declared. Should it be static? Signed

[PATCH net-next] mlxsw: spectrum: Make function mlxsw_sp_kvdl_part_occ() static

2018-01-16 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c:289:5: warning: symbol 'mlxsw_sp_kvdl_part_occ' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlxsw/spectrum_kvdl.c | 2 +- 1 file changed, 1

[PATCH] net: sched: fix skb leak in dev_requeue_skb()

2017-12-24 Thread Wei Yongjun
Signed-off-by: Wei Yongjun diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 981c08f..0df2dbf 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -111,10 +111,16 @@ static inline void qdisc_enqueue_skb_bad_txq(struct Qdisc *q, static inline int __dev_reque

[PATCH net-next v2] net: sched: fix skb leak in dev_requeue_skb()

2017-12-24 Thread Wei Yongjun
Signed-off-by: Wei Yongjun --- v1 -> v2: add net-next prefix --- diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 981c08f..0df2dbf 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -111,10 +111,16 @@ static inline void qdisc_enqueue_skb_bad_txq(struct Qdis

[PATCH net-next v3] net: sched: fix skb leak in dev_requeue_skb()

2017-12-27 Thread Wei Yongjun
der. Fixes: a53851e2c321 ("net: sched: explicit locking in gso_cpu fallback") Signed-off-by: Wei Yongjun --- v2 -> v3: move lock out of while loop --- net/sched/sch_generic.c | 29 + 1 file changed, 21 insertions(+), 8 deletions(-) diff --git a/net/sched/sch

[PATCH net-next] net: dsa: lan9303: Fix error return code in lan9303_check_device()

2018-01-03 Thread Wei Yongjun
Fix to return error code -ENODEV from the chip not found error handling case instead of 0(ret have been overwritten to 0 by lan9303_read()), as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/dsa/lan9303-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH net-next] net: aquantia: make symbol hw_atl_boards static

2018-01-22 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:50:34: warning: symbol 'hw_atl_boards' was not declared. Should it be static? Fixes: 4948293ff963 ("net: aquantia: Introduce new AQC devices and capabilities") Signed-off-by: Wei Yongj

[PATCH net-next] nfp: fix error return code in nfp_pci_probe()

2018-01-22 Thread Wei Yongjun
Fix to return error code -EINVAL instead of 0 when num_vfs above limit_vfs, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/netronome/nfp/nfp_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_main.c b

[PATCH net-next] net: aquantia: Fix error return code in aq_pci_probe()

2018-01-22 Thread Wei Yongjun
Fix to return error code -ENOMEM from the aq_ndev_alloc() error handling case instead of 0, as done elsewhere in this function. Fixes: 23ee07ad3c2f ("net: aquantia: Cleanup pci functions module") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c |

[PATCH net-next] cxgb4: make symbol pedits static

2018-01-23 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_flower.c:46:27: warning: symbol 'pedits' was not declared. Should it be static? Fixes: 27ece1f357b7 ("cxgb4: add tc flower support for ETH-DMAC rewrite") Signed-off-by: Wei Yongjun --- drivers/

[PATCH] hinic: reset irq affinity before freeing irq

2018-06-27 Thread Wei Yongjun
c cpu for NUMA") Signed-off-by: Wei Yongjun diff --git a/drivers/net/ethernet/huawei/hinic/hinic_rx.c b/drivers/net/ethernet/huawei/hinic/hinic_rx.c index e2e5cdc..4c0f7ed 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_rx.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_rx.c @@ -43

[PATCH net-next] net: sched: act_pedit: fix possible memory leak in tcf_pedit_init()

2018-07-03 Thread Wei Yongjun
'keys_ex' is malloced by tcf_pedit_keys_ex_parse() in tcf_pedit_init() but not all of the error handle path free it, this may cause memory leak. This patch fix it. Fixes: 71d0ed7079df ("net/act_pedit: Support using offset relative to the conventional network headers") Signed

[PATCH net-next] net: dsa: vsc73xx: Make some functions static

2018-07-05 Thread Wei Yongjun
tic? drivers/net/dsa/vitesse-vsc73xx.c:1122:6: warning: symbol 'vsc73xx_get_ethtool_stats' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/dsa/vitesse-vsc73xx.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/ds

[PATCH net-next] net: aquantia: Make some functions static

2018-07-05 Thread Wei Yongjun
g: symbol 'hw_atl_utils_mpi_set_state' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c b/

[PATCH net-next] net: igmp: make function __ip_mc_inc_group() static

2018-07-24 Thread Wei Yongjun
Fixes the following sparse warnings: net/ipv4/igmp.c:1391:6: warning: symbol '__ip_mc_inc_group' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/igmp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/ipv4/igmp.c b/net/ipv4/ig

[PATCH net-next] tcp: make function tcp_retransmit_stamp() static

2018-07-24 Thread Wei Yongjun
Fixes the following sparse warnings: net/ipv4/tcp_timer.c:25:5: warning: symbol 'tcp_retransmit_stamp' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/tcp_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv4/tcp_timer.c

[PATCH net-next] lan743x: Make symbol lan743x_pm_ops static

2018-07-24 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/microchip/lan743x_main.c:2944:25: warning: symbol 'lan743x_pm_ops' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/microchip/lan743x_main.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH net-next] can: flexcan: flexcan_chip_start(): fix the error return code in flexcan_setup_stop_mode()

2018-12-03 Thread Wei Yongjun
The error return code PTR_ERR(gpr_np) is always 0 since gpr_np is equal to NULL in this error handling case. Fix it by return -ENOENT. Fixes: de3578c198c6 ("can: flexcan: add self wakeup support") Signed-off-by: Wei Yongjun --- drivers/net/can/flexcan.c | 2 +- 1 file changed, 1 inser

[PATCH net-next] net/mlx5e: Make function mlx5i_grp_sw_update_stats() static

2018-09-05 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c:119:6: warning: symbol 'mlx5i_grp_sw_update_stats' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c | 2 +- 1 file

[PATCH net-next] net: dsa: gswip: Fix return value check in gswip_probe()

2018-09-14 Thread Wei Yongjun
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Signed-off-by: Wei Yongjun --- drive

[PATCH net-next] net: dsa: gswip: Fix copy-paste error in gswip_gphy_fw_probe()

2018-09-14 Thread Wei Yongjun
The return value from of_reset_control_array_get_exclusive() is not checked correctly. The test is done against a wrong variable. This patch fix it. Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200") Signed-off-by: Wei Yongjun --- drivers/net/dsa/lantiq_g

[PATCH net-next] net: lantiq: Fix return value check in xrx200_probe()

2018-09-14 Thread Wei Yongjun
In case of error, the function devm_ioremap_resource() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: fe1a56420cf2 ("net: lantiq: Add Lantiq / Intel VRX200 Ethernet driver") Signed-off-by: Wei Yongjun --- d

[PATCH net-next] net: hns: make function hns_gmac_wait_fifo_clean() static

2018-09-14 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c:322:5: warning: symbol 'hns_gmac_wait_fifo_clean' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_gmac.c | 2 +- 1 file changed, 1

[PATCH RESEND] PCI: hv: Fix return value check in hv_pci_assign_slots()

2018-09-20 Thread Wei Yongjun
In case of error, the function pci_create_slot() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: a15f2c08c708 ("PCI: hv: support reporting serial number as slot information") Signed-off-by: Wei Yongjun --- Sinc

[PATCH net-next] net/core: make function ___gnet_stats_copy_basic() static

2018-09-26 Thread Wei Yongjun
Fixes the following sparse warning: net/core/gen_stats.c:166:1: warning: symbol '___gnet_stats_copy_basic' was not declared. Should it be static? Fixes: 5e111210a443 ("net/core: Add new basic hardware counter") Signed-off-by: Wei Yongjun --- net/core/gen_stats.c | 2 +

[PATCH net-next] net/tls: Make function get_rec() static

2018-09-26 Thread Wei Yongjun
Fixes the following sparse warning: net/tls/tls_sw.c:655:16: warning: symbol 'get_rec' was not declared. Should it be static? Fixes: a42055e8d2c3 ("net/tls: Add support for async encryption of records for performance") Signed-off-by: Wei Yongjun --- net/tls/tls_sw.c | 2 +

[PATCH net-next] net: aquantia: Make function aq_fw1x_set_power() static

2018-09-26 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_utils.c:873:5: warning: symbol 'aq_fw1x_set_power' was not declared. Should it be static? Fixes: a0da96c08cfa ("net: aquantia: implement WOL support") Signed-off-by: Wei Yongjun ---

[PATCH net-next] net: sched: make function qdisc_free_cb() static

2018-09-27 Thread Wei Yongjun
Fixes the following sparse warning: net/sched/sch_generic.c:944:6: warning: symbol 'qdisc_free_cb' was not declared. Should it be static? Fixes: 3a7d0d07a386 ("net: sched: extend Qdisc with rcu") Signed-off-by: Wei Yongjun --- net/sched/sch_generic.c | 2 +- 1 file change

[PATCH -next] fore200e: fix missing unlock on error in bsq_audit()

2018-10-14 Thread Wei Yongjun
Add the missing unlock before return from function bsq_audit() in the error handling case. Fixes: 1d9d8be91788 ("fore200e: check for dma mapping failures") Signed-off-by: Wei Yongjun --- drivers/atm/fore200e.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/atm/fore200e.c

[PATCH] octeontx2-af: Use GFP_ATOMIC under spin lock

2018-10-24 Thread Wei Yongjun
The function nix_update_mce_list() is called from nix_update_bcast_mce_list(), and a spin lock is held here, so we should use GFP_ATOMIC instead. Fixes: 4b05528ebf0c ("octeontx2-af: Update bcast list upon NIXLF alloc/free") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/marvell

[PATCH] xfrm: Fix error return code in xfrm_output_one()

2018-10-26 Thread Wei Yongjun
force clears the dst_entry.") Signed-off-by: Wei Yongjun --- net/xfrm/xfrm_output.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/xfrm/xfrm_output.c b/net/xfrm/xfrm_output.c index 4ae87c5c..fef6b2d 100644 --- a/net/xfrm/xfrm_output.c +++ b/net/xfrm/xfrm_output.c @@ -102,6 +102,7

[PATCH net-next] net: bpfilter: make function bpfilter_mbox_request() static

2018-05-26 Thread Wei Yongjun
Fixes the following sparse warnings: net/ipv4/bpfilter/sockopt.c:13:5: warning: symbol 'bpfilter_mbox_request' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/ipv4/bpfilter/sockopt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH net-next] netfilter: nat: make symbol nat_hook static

2018-05-26 Thread Wei Yongjun
Fixes the following sparse warning: net/netfilter/nf_nat_core.c:1039:20: warning: symbol 'nat_hook' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/netfilter/nf_nat_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/nf_

[PATCH net-next] hv_netvsc: fix error return code in netvsc_probe()

2018-05-30 Thread Wei Yongjun
Fix to return a negative error code from the failover register fail error handling case instead of 0, as done elsewhere in this function. Fixes: 1ff78076d8dd ("netvsc: refactor notifier/event handling code to use the failover framework") Signed-off-by: Wei Yongjun --- drivers/

[PATCH net-next] net/smc: fix error return code in smc_setsockopt()

2018-05-30 Thread Wei Yongjun
Fix to return error code -EINVAL instead of 0 if optlen is invalid. Fixes: 01d2f7e2cdd3 ("net/smc: sockopts TCP_NODELAY and TCP_CORK") Signed-off-by: Wei Yongjun --- net/smc/af_smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/smc/af_smc.c b/net/smc/af_s

[PATCH net-next] net/mlx5: Make function mlx5_fpga_tls_send_teardown_cmd() static

2018-05-30 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlx5/core/fpga/tls.c:199:6: warning: symbol 'mlx5_fpga_tls_send_teardown_cmd' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/fpga/tls.c | 4 ++-- 1 file

[PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static

2018-06-04 Thread Wei Yongjun
Fixes the following sparse warning: drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning: symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 2 +- 1 file changed, 1 inser

[PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-06-04 Thread Wei Yongjun
Fix to return error code -ENOMEM from the kvzalloc_node() error handling case instead of 0, as done elsewhere in this function. Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory scheme") Signed-off-by: Wei Yongjun --- drivers/net/ethernet/mellanox/mlx5/core/en_

[PATCH net-next] xfrm: Make function xfrmi_get_link_net() static

2018-07-27 Thread Wei Yongjun
Fixes the following sparse warning: net/xfrm/xfrm_interface.c:745:12: warning: symbol 'xfrmi_get_link_net' was not declared. Should it be static? Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") Signed-off-by: Wei Yongjun --- net/xfrm/xfrm_interface.c | 2 +

[PATCH net-next] tcp: remove set but not used variable 'skb_size'

2018-07-31 Thread Wei Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: net/ipv4/tcp_output.c: In function 'tcp_collapse_retrans': net/ipv4/tcp_output.c:2700:6: warning: variable 'skb_size' set but not used [-Wunused-but-set-variable] int skb_size, next_skb_size; ^ Signed-off-

[PATCH net-next] rxrpc: Remove set but not used variable 'nowj'

2018-08-01 Thread Wei Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: net/rxrpc/proc.c: In function 'rxrpc_call_seq_show': net/rxrpc/proc.c:66:29: warning: variable 'nowj' set but not used [-Wunused-but-set-variable] unsigned long timeout = 0, nowj;

[PATCH net-next] ieee802154: hwsim: fix copy-paste error in hwsim_set_edge_lqi()

2018-08-07 Thread Wei Yongjun
The return value from kzalloc() is not checked correctly. The test is done against a wrong variable. This patch fix it. Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Wei Yongjun --- drivers/net/ieee802154/mac802154_hwsim.c | 2 +- 1 file

[PATCH net-next] ieee802154: hwsim: fix missing unlock on error in hwsim_add_one()

2018-08-07 Thread Wei Yongjun
Add the missing unlock before return from function hwsim_add_one() in the error handling case. Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Wei Yongjun --- drivers/net/ieee802154/mac802154_hwsim.c | 4 +++- 1 file changed, 3 insertions(+),

[PATCH -next] net: axienet: Fix return value check in axienet_probe()

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun In case of error, the function of_parse_phandle() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 46aa27df8853 ('net: axienet: Use devm_* calls') Signed-off-by: Wei Yongjun --- drivers/ne

[PATCH -next] wan/fsl_ucc_hdlc: use module_platform_driver to simplify the code

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Wei Yongjun --- drivers/net/wan/fsl_ucc_hdlc.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan

[PATCH -next] wan/fsl_ucc_hdlc: remove .owner field for driver

2016-07-19 Thread Wei Yongjun
From: Wei Yongjun Remove .owner field if calls are used which set it automatically. Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Wei Yongjun --- drivers/net/wan/fsl_ucc_hdlc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wan/fsl_ucc_hdlc.c

  1   2   3   >