Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-26 Thread Abdelrhman Ahmed
eader which calls create method for adding hardware header (uses skb_push) so it was required to reset to network header in the beginning of the retry loop. On Wed, 26 Oct 2016 02:12:22 +0200 Eric Dumazet <eric.duma...@gmail.com> wrote > On Wed, 2016-10-26 at 01

Re: [PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-25 Thread Abdelrhman Ahmed
not clear to me? On Fri, 07 Oct 2016 23:10:56 +0200 Eric Dumazet <eric.duma...@gmail.com> wrote > On Fri, 2016-10-07 at 16:14 +0200, Abdelrhman Ahmed wrote: > > When hardware header is added without using cached one, > > neigh_resolve_output > >

[PATCH] net: Reset skb to network header in neigh_hh_output

2016-10-07 Thread Abdelrhman Ahmed
hardware header to keep the behavior consistent in all cases. Signed-off-by: Abdelrhman Ahmed <a...@abahmed.com> --- include/net/neighbour.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/include/net/neighbour.h b/include/net/neighbour.h index 8b68384..4d89fc2

Re: [PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected_output

2016-06-27 Thread Abdelrhman Ahmed
instead of network header. Fixes: e1f165032c8b ("net: Fix skb_under_panic oops in neigh_resolve_output") Signed-off-by: Abdelrhman Ahmed <a...@abahmed.com> --- net/core/neighbour.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/net/core/neighb

[PATCH] net: Fix resetting network_header in neigh_resolve_output and neigh_connected_output

2016-06-23 Thread Abdelrhman Ahmed
loop instead of network header. Fixes: e1f165032c8b ("net: Fix skb_under_panic oops in neigh_resolve_output") Signed-off-by: Abdelrhman Ahmed <a...@abahmed.com> --- net/core/neighbour.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/net/core/n

[PATCH] net: Fix skb_network_offset in neigh_resolve_output and neigh_connected_output

2016-06-16 Thread Abdelrhman Ahmed
the first packet(s) before using cached hardware header and this will lead to inconsistent behavior for outgoing packets. The fix is to reset with reference to skb's data pointer before loop instead of network header. Signed-off-by: Abdelrhman Ahmed <a...@abahmed.com> --- net/core/neighbou