On Tue, Sep 27, 2016 at 09:21:27AM +, David Laight wrote:
> From: Adit Ranadive
> > Sent: 26 September 2016 19:15
> > On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote:
> > > On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > >
On Mon, Sep 26, 2016 at 14:07:24PM -0700, Jason Gunthorpe wrote:
> On Mon, Sep 26, 2016 at 01:40:10PM -0700, Adit Ranadive wrote:
>
> > Wouldnt they be some overlap between the user-space and kernel driver? Or is
> > it expected that the common structures (even device speci
On Mon, Sep 26, 2016 at 10:51:04AM -0600, Jason Gunthorpe wrote:
> On Sun, Sep 25, 2016 at 10:25:12PM -0700, Adit Ranadive wrote:
> > > As Jason said, you need a very good reason to split and create number of
> > > files per-driver in UAPI folder.
> >
> >
On Mon, Sep 26, 2016 at 00:27:40AM -0700, Yuval Shaia wrote:
> On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > +
> > + /* Currently, the driver only supports RoCE mode. */
> > + if (dev->dsr->caps.mode != PVRDMA_DEVICE_MODE_ROCE) {
> > +
On Mon, Sep 26, 2016 at 00:16:01AM -0700, Yuval Shaia wrote:
> Minor question/suggestion inline.
> (sorry for missing it till now).
>
> Yuval
<...>
> > +int
> > +pvrdma_cmd_post(struct pvrdma_dev *dev, union pvrdma_cmd_req *req,
> > + union pvrdma_cmd_resp *resp, unsigned resp_code)
>
On Sun, Sep 25, 2016 at 23:13:38PM -0700, Leon Romanovsky wrote:
> On Sun, Sep 25, 2016 at 09:22:11PM -0700, Adit Ranadive wrote:
>> On Sun, Sep 25 2016 at 10:26:24AM +0300, Leon Romanovsky wrote:
> > > > On Sat, Sep 24, 2016 at 04:21:26PM -0700, Adit Ranadive wrote:
> &g
On Sun, Sep 25 2016 at 10:03:52AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:24PM -0700, Adit Ranadive wrote:
>
> <...>
>
> > include/uapi/rdma/pvrdma-abi.h | 99 ++
> > include/uapi/rdma/pvrdma-uapi.h| 255
On Sun, Sep 25 2016 at 10:30:10AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:40PM -0700, Adit Ranadive wrote:
> > Add maintainer info for the PVRDMA driver.
> >
> > Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
> > Reviewed-by: Geo
On sun, Sep 25 2016 at 10:57:03AM +0300, Leon Romanovsky wrote:
> On Sat, Sep 24, 2016 at 04:21:37PM -0700, Adit Ranadive wrote:
> > This patch adds the support to register a RDMA device with the kernel RDMA
> > stack as well as a kernel module. This also initializes the underlying
On Sun, Sep 25 2016 at 10:26:24AM +0300, Leon Romanovsky wrote:
> > On Sat, Sep 24, 2016 at 04:21:26PM -0700, Adit Ranadive wrote:
> > We share some common structures with the user-level driver. This patch adds
> > those structures and shared functions to traver
n...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Correct var type passed to dma_alloc_coherent.
Changes v3->v4:
- Updated conversion functions to func_name(dst, src) format.
- Removed unneeded local variables.
---
driver
mware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Removed an unnecessary comment.
Changes
tya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Updated include for headers in UAPI folder.
- Changed from EINVAL to ENOMEM if atomic add fails.
- Added error code if destroy cq comma
George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Removed two unnecessary lines.
- Updated include for headers in UAPI folde
mware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Update include for headers in UAPI folder.
- Removed setting any properties that are reported by device as 0.
- Simplified modify_port.
- PD should be allocated first in kernel then in device.
- Updat
ng <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Check the access flags correctly for DMA MR.
- Update to pvrdma_cmd_post for c
;georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Removed __ prefix for unsigned vars.
Changes v3->v4:
- Moved the pvrdma_sge struct to pvrdm
<jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- pvrdma_cmd_post takes the res
tya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Moved the timeout to pvrdma_cmd_recv.
- Added additional response code parameter to pvrdma_cmd_post.
Changes v3->v4:
- Remo
Add maintainer info for the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad
by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Updated include for headers in UAPI folder.
- Update to pvrdma_cmd_post for creating/destroying/querying/modifying QPs.
-
This patch updates the InfiniBand subsystem to build the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Sign
This patch adds a Kconfig and Makefile for the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-o
Romanovsky).
Changes v1->v2:
- Patch [07/15] - Addressed Yuval Shaia's comments and 32-bit build errors.
---
Adit Ranadive (16):
vmxnet3: Move PCI Id to pci_ids.h
IB/pvrdma: Add user-level shared functions
IB/pvrdma: Add virtual device RDMA structures
IB/pvrdma: Add the paravirtual RD
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver.
Moved it to the shared location in pci_ids.h.
Suggested-by: Leon Romanovsky <l...@kernel.org>
Acked-by: Bjorn Helgaas <bhelg...@google.com>
Reviewed-by: Yuval Shaia <yuval.sh...@oracle.com>
Signed-off-by:
h...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Moved pvrdma_uapi.h and pvrdma_user.h into common UAPI folder.
- Renamed to pvrdma-uapi.h and
<jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v4->v5:
- Update include for headers moved to
by: Yuval Shaia <yuval.sh...@oracle.com>
> >
> > Yuval
> >
> > On Thu, Sep 15, 2016 at 12:07:29AM +, Adit Ranadive wrote:
> > > On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote:
> > > > On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Rana
On Wed, Sep 14, 2016 at 05:49:50 -0700 Christoph Hellwig wrote:
> > + props->max_fmr = dev->dsr->caps.max_fmr;
> > + props->max_map_per_fmr = dev->dsr->caps.max_map_per_fmr;
>
> Please don't add FMR support to any new drivers.
We don't and our device reports these as 0. If you want me to
On Wed, Sep 14, 2016 at 05:43:37 -0700, Yuval Shaia wrote:
> On Sun, Sep 11, 2016 at 09:49:19PM -0700, Adit Ranadive wrote:
> > +
> > +static int pvrdma_poll_one(struct pvrdma_cq *cq, struct pvrdma_qp
> **cur_qp,
> > + struct ib_wc *wc)
> > +{
On Wed, Sep 14, 2016 at 10:37:00 -0700, Jason Gunthorpe wrote:
> We desire to use this as the vehical for the userspace included with the 4.9
> kernel.
>
> I anticipate the tree will be running by Oct 1.
Thanks. So does this mean that the libraries distributed via OFED
(openfabrics.org)
will be
On Wed, Sep 14, 2016 at 09:25:18 -0700, Yuval Shaia wrote:
> On Wed, Sep 14, 2016 at 04:00:25PM +0000, Adit Ranadive wrote:
> > On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:
> > > Please update vmxnet3_drv.c accordingly.
> >
> > Any reason why? I don't th
On Wed, Sep 14, 2016 at 04:09:12 -0700, Yuval Shaia wrote:
> Please update vmxnet3_drv.c accordingly.
Any reason why? I don't think we need to. Vmxnet3 should just pick up the moved
PCI device id from pci_ids.h file.
- Adit
On Mon, Sep 12, 2016 at 11:03:39 -0700, Jason Gunthorpe wrote:
> On Sun, Sep 11, 2016 at 09:49:10PM -0700, Adit Ranadive wrote:
> > [2] Libpvrdma User-level library -
> > http://git.openfabrics.org/?p=~aditr/libpvrdma.git;a=summary
>
> You will probably find that rdma-plum
On Mon, Sep 12, 2016 at 10:52:26 -0700, Jason Gunthorpe wrote:
> On Sun, Sep 11, 2016 at 09:49:26PM -0700, Adit Ranadive wrote:
> > Add maintainer info for the PVRDMA driver.
>
> You can probably squash the last three patches.
Thanks for taking a look.
Since Doug mentioned that
mware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Renamed priviledged -> privileged.
- Added error numbers for command errors.
- Removed unnecessary goto in modify_device.
- Moved pd allocation to after command execution.
- Removed an incorrect at
h...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Moved pvrdma_sge into pvrdma_uapi.h
---
drivers/infiniband/hw/pvrdma/pvrdma_uapi.h | 255 ++
George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Fixed some checkpatch warnings.
- Added support for new get_dev_fw_str API.
;georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Renamed pvrdma_flush_cqe to _pvrdma_flush_cqe since we hold a lock
to call it.
- Added wrap
rwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Changed access flag check for DMA MR to using bit operation.
- Removed some local variables.
Changes v2->v3:
- Removed bool
: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Removed an unnecessary switch case.
- Unified the returns in pvrdma_create_qp to use one exit point.
- Renamed pvrdma_flush_cqe to _pvrdma_flush_cqe since we need a lock to
be h
<jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Removed explicit enum values.
Chang
This patch updates the InfiniBand subsystem to build the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Sign
Add maintainer info for the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ra
;georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Moved the pvrdma_sge struct to pvrdma_uapi.h
---
drivers/infiniband/
: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Added a pvrdma_destroy_cq in the error path.
- Renamed pvrdma_flush_cqe to _pvrdma_flush_cqe since we need a lock to
be held while calling this.
- Updated to use wrapper for UAR write fo
mware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Removed an unnecessary comment.
Changes
tya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
Changes v3->v4:
- Removed the min check and added a BUILD_BUG_ON check for size.
Changes v2->v3:
- Converted pvrdma_cmd_recv to inline.
- A
This patch adds a Kconfig and Makefile for the PVRDMA driver.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-o
stack address handles from/to PVRDMA ones.
Reviewed-by: Jorgen Hansen <jhan...@vmware.com>
Reviewed-by: George Zhang <georgezh...@vmware.com>
Reviewed-by: Aditya Sarwade <asarw...@vmware.com>
Reviewed-by: Bryan Tan <bryan...@vmware.com>
Signed-off-by: Adit Ranadive <ad...
The VMXNet3 PCI Id will be shared with our paravirtual RDMA driver.
Moved it to the shared location in pci_ids.h.
Suggested-by: Leon Romanovsky <l...@kernel.org>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
---
drivers/net/vmxnet3/vmxnet3_int.h | 3 +--
include/lin
Removed an unneccesary bool in pvrdma_cmd_post (suggested by Yuval Shaia).
- Made the use of comma at end of enums consistent across files (suggested
by Leon Romanovsky).
Changes v1->v2:
- Patch [07/15] - Addressed Yuval Shaia's comments and 32-bit build errors.
---
Adit Ranadive (16
On Fri, Aug 05, 2016 11:23:41AM -0700, Bjorn Helgaas <helg...@kernel.org> wrote:
> On Fri, Aug 05, 2016 at 11:00:39AM -0700, Adit Ranadive wrote:
> > The VMXNet3 PCI Id will be shared with our upcoming paravirtual RDMA
> > driver. Moved it to the shared location in
The VMXNet3 PCI Id will be shared with our upcoming paravirtual RDMA
driver. Moved it to the shared location in pci_ids.h and updated the
driver version.
Suggested-by: Leon Romanovsky <l...@kernel.org>
Signed-off-by: Adit Ranadive <ad...@vmware.com>
---
drivers/net/vmxnet3/vmxne
PROTECTED]
*
+ * Fixed src_mac command to set source mac of packet to value specified in
+ * command by Adit Ranadive [EMAIL PROTECTED]
+ *
*/
#include linux/sys.h
#include linux/types.h
@@ -1415,7 +1418,9 @@ static ssize_t pktgen_if_write(struct fi
}
if (!strcmp(name, src_mac
55 matches
Mail list logo
