[PATCH BUGFIX 25-rc1] Smack: Don't fail against Nulled sk sockets

2008-02-12 Thread Ahmed S. Darwish
Hi!, Appropriately handle sockets with sk = NULL. This is usually the socket case when starting kernel nfsd. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Acked-by: Casey Schaufler [EMAIL PROTECTED] Tested-by: Joerg Platte [EMAIL PROTECTED] -- diff --git a/security/smack/smack_lsm.c b

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
: * + * Brian Braunstein [EMAIL PROTECTED] 2007/03/23 + *Fixed hw address handling. Now net_device.dev_addr is kept consistent Your mailer still wrap the long lines mistakenly as it did in the first version of the patch. Regards, -- Ahmed S. Darwish http://darwish.07.googlepages.com

Re: [PATCH] net: tun/tap: fixed hw address handling

2007-03-26 Thread Ahmed S. Darwish
mutt mail reader (not a feature, it displays other mails long lines without wrapping), sorry. -- Ahmed S. Darwish http://darwish.07.googlepages.com - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [patch 1/2] natsemi: Add support for using MII port with no PHY

2007-02-14 Thread Ahmed S. Darwish
. + */ + if (np-ignore_phy (ecmd-autoneg == AUTONEG_ENABLE || A trivial comment actually, Is there a point to write multi-line comments in two different formats ? Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line unsubscribe netdev in the body

Re: [PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:17:09PM +0300, Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 07:00:44PM +0200, Ahmed S. Darwish wrote: A trivial patch to use ARRAY_SIZE macro. You're supposed to remove it ans use ARRAY_SIZE where old macro is used. --- a/drivers/net/wireless/wavelan.p.h

Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 12:31:26PM -0800, Auke Kok wrote: Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. Remove it and use ARRAY_SIZE instead. --- a/drivers/net/ixgb/ixgb_param.c +++ b

Re: [PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-06 Thread Ahmed S. Darwish
On Mon, Feb 05, 2007 at 11:22:06PM +0300, Alexey Dobriyan wrote: On Mon, Feb 05, 2007 at 06:59:16PM +0200, Ahmed S. Darwish wrote: A patch to use ARRAY_SIZE macro already defined in kernel.h. OK, but checks you're changing are strange. idx there is signed so BUG_ON(idx 0 || idx

[PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers

2007-02-05 Thread Ahmed S. Darwish
+- zorro8390.c|2 +- 27 files changed, 50 insertions(+), 42 deletions(-) Thanks, -- Ahmed S. Darwish http://darwish-07.blogspot.com - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/e1000/e1000_ethtool.c b/drivers/net/e1000/e1000_ethtool.c index fb96c87..d21706e 100644 --- a/drivers/net/e1000

[PATCH 01/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- [PATCH 01/02] is compile tested. [PATCH 02/02] isn't compile tested cause of missing hardware. diff

[PATCH 2.6.20] ipw2100: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi all, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/wireless/ipw2100.c b/drivers/net/wireless/ipw2100.c index b85857a..a9d944a 100644 --- a/drivers/net/wireless/ipw2100.c

[PATCH 02/02] misc-net-drivers: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A 2.6.20 patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous network drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch isn't compile-tested due to missing hardware. diff --git a/drivers/net/apne.c b/drivers/net

[PATCH 2.6.20] misc-wireless: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h for some miscellaneous wireless drivers with no specific maintaners. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c index

[PATCH 2.6.20] hostap: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro in the Host AP wireless driver. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch is compile tested. diff --git a/drivers/net/wireless/hostap/hostap.h b/drivers/net/wireless/hostap/hostap.h index e89c890..ef37a75 100644 --- a/drivers/net/wireless

[PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- diff --git a/drivers/net/ixgb/ixgb_param.c b/drivers/net/ixgb/ixgb_param.c index b27442a..26031fe 100644 --- a/drivers/net/ixgb/ixgb_param.c +++ b/drivers/net/ixgb/ixgb_param.c

[PATCH 2.6.20] wavelan: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A trivial patch to use ARRAY_SIZE macro. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- diff --git a/drivers/net/wireless/wavelan.p.h b/drivers/net/wireless/wavelan.p.h index 72b646c..fe12c77 100644 --- a/drivers/net/wireless/wavelan.p.h +++ b/drivers/net/wireless/wavelan.p.h

[PATCH 2.6.20] ibm_emac: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ahmed S. Darwish
Hi, A patch to use ARRAY_SIZE macro already defined in kernel.h. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- Patch isn't compile-tested cause I don't have the needed hardware. diff --git a/drivers/net/ibm_emac/ibm_emac_debug.c b/drivers/net/ibm_emac/ibm_emac_debug.c index 92f970d

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-07 Thread Ahmed S. Darwish
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED] Hi, A kmalloc casting cleanup patch. Signed-off-by: Ahmed Darwish [EMAIL PROTECTED] [..] - (u32) (kmalloc((u32) (length + align

Re: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-07 Thread Ahmed S. Darwish
On Mon, Jan 08, 2007 at 11:12:28AM +0800, Li Yang-r58472 wrote: NACK about the 2 clean-ups above. Cast from pointer to integer is required here. Hi, here's the modified patch. A patch to switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by: Ahmed S. Darwish