On Sun, Dec 23, 2007 at 12:33:14AM -0500, Jeff Garzik wrote:
A couple [minorly] notable wireless bug fixes, and plenty of viro fixes
for obscure issues :)
Heh... FWIW, forcedeth patch (sent your way about two weeks ago) also
belongs in the same set. If you need a resend - tell...
There's
On Sun, Dec 23, 2007 at 01:42:14AM -0500, Jeff Garzik wrote:
I applied it to #upstream (2.6.25) since forcedeth is not on any
big-endian platforms AFAIK.
All right, then... I hadn't been sure if it's onboard-only, that's all.
I have an epic100 card too if you need it (though it sounds like
during the testing of PPC fixes.
PS: Ken Aaker cc'd on assumption that he is the same guy who'd done the
original set of PPC fixes in olympic
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
diff --git a/drivers/net/tokenring/olympic.c b/drivers/net/tokenring/olympic.c
index 74c1f0f..e7b4adc 100644
On Thu, Nov 08, 2007 at 04:31:05PM +0900, Magnus Damm wrote:
config AX88796
tristate ASIX AX88796 NE2000 clone support
- depends on ARM || MIPS
+ depends on ARM || MIPS || SUPERH
You know, that really sucks more and more. How about doing the following:
a) making it
On Fri, Oct 26, 2007 at 02:03:19PM -0700, Stephen Hemminger wrote:
Looking at this bug:
http://bugzilla.kernel.org/show_bug.cgi?id=9149
Exposes some rather deep issues in the filesystem/socket/inet/tcp
layering. It seems that sys_close() zaps the file table entry, but
since each thread has
On Fri, Oct 26, 2007 at 03:09:01PM -0700, Stephen Hemminger wrote:
close() from another thread is not a way to abort blocked accept(). Never
promised to be that. Just as close() from another thread is not a way to
abort blocked write() or read() or sendmsg() or...
The problem is the
On Fri, Oct 12, 2007 at 12:13:25AM -0700, Andrew Morton wrote:
I always forget to test uml. But a quick test build seems to work until
it hits this:
arch/um/drivers/slip_kern.c: In function 'slip_init':
arch/um/drivers/slip_kern.c:34: error: 'struct net_device' has no member
named
On Mon, Oct 01, 2007 at 01:32:43PM +0100, Gerrit Renker wrote:
[TCP]: break missing at end of switch statement
Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
---
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -3129,6 +3129,7 @@ static void tcp_reset(struct sock *sk)
On Mon, Oct 01, 2007 at 02:02:10PM +0100, Gerrit Renker wrote:
Quoting Al Viro:
| On Mon, Oct 01, 2007 at 01:32:43PM +0100, Gerrit Renker wrote:
| [TCP]: break missing at end of switch statement
|
| Signed-off-by: Gerrit Renker [EMAIL PROTECTED]
| ---
| --- a/net/ipv4
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
drivers/net/mv643xx_eth.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 6a117e9..456d1e1 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
now...
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c
index 1583c5e..2a54691 100644
--- a/net/8021q/vlan.c
+++ b/net/8021q/vlan.c
@@ -562,8 +562,6 @@ static int register_vlan_device(struct net_device *real_dev,
if (err 0)
goto
On Sun, Sep 02, 2007 at 03:00:46PM +0200, Igor Sobrado wrote:
Not strictly true. They can either agree to a change and issue one or
they can convey to other parties the right to change the terms. The GPL
for example does this for version selection.
So, under a dual-licensed BSD/GPL code the
On Sat, Sep 01, 2007 at 09:42:54PM -0400, Luis R. Rodriguez wrote:
We asked SFLC to work with us to make sure that everyone's copyrights
were respected in the right places, and that the licenses various developers
wanted for their copyrights were implemented correctly. The patch I sent
On Sat, Sep 01, 2007 at 09:58:26PM -0400, Casey Dahlin wrote:
Suppose you saw some other variant of *nix that had some code you wanted
to use, but there was a gaping security hole in it. Wouldn't you patch
it before you incorporated it? and would it be your fault if this fix
made the code
On Fri, Aug 24, 2007 at 01:56:49PM -0700, Stephen Hemminger wrote:
static void velocity_init_cam_filter(struct velocity_info *vptr)
{
struct mac_regs __iomem * regs = vptr-mac_regs;
+ unsigned short vid;
- mac_set_cam(regs, 0, (u8 *) (vptr-options.vid),
On Fri, Aug 24, 2007 at 02:40:45PM -0700, Stephen Hemminger wrote:
+static void mac_set_vlan_cam(struct mac_regs __iomem * regs, int idx,
+ const u8 *addr)
ITYM const u16 *, if not an outright u16. These casts (one below and
ones in callers) really should die.
+
On Wed, Aug 22, 2007 at 11:35:20PM -0700, Divy Le Ray wrote:
Hi Jeff,
I'm submitting three more patches for inclusion in netdev#upstream.
These patches are built over the series I resent yesterday night.
The patch numbering reflects the stacking.
Here is a brief description:
- avoid
On Sun, Aug 12, 2007 at 11:46:49PM -0700, Joe Perches wrote:
On Sun, 2007-08-12 at 23:36 -0700, David Miller wrote:
Ok, 374 patches is just rediculious.
So many patches eats up an enormous amount of mailing list resources,
and for these patches in particular there are few reasons to
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
net/bluetooth/l2cap.c | 20 +++-
1 files changed, 11 insertions(+), 9 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 09126bf..03309d2 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
Since nobody uses it after we convert it to host-endian,
no need to do that at all. At that point l2cap is endian-clean.
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
net/bluetooth/l2cap.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net
-endian.
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
net/bluetooth/l2cap.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/l2cap.c b/net/bluetooth/l2cap.c
index 670ff95..b82cbdd 100644
--- a/net/bluetooth/l2cap.c
+++ b/net/bluetooth/l2cap.c
@@ -748,7 +748,7
no code changes, just documenting existing types
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
include/net/bluetooth/l2cap.h | 50
net/bluetooth/l2cap.c | 27 +++--
2 files changed, 39 insertions(+), 38 deletions(-)
diff --git
On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
* netdev_pci_remove_one() can replace simple pci device remove
functions
* devm_alloc_netdev() is like alloc_netdev but allocates memory using devres.
alloc_netdev() can be removed once all drivers use devres.
E...
On Tue, Jul 24, 2007 at 11:51:34PM +0100, Al Viro wrote:
On Tue, Jul 24, 2007 at 03:39:52PM -0700, [EMAIL PROTECTED] wrote:
* netdev_pci_remove_one() can replace simple pci device remove
functions
* devm_alloc_netdev() is like alloc_netdev but allocates memory using
devres
On Wed, Jul 25, 2007 at 12:30:07AM +0100, Al Viro wrote:
On Tue, Jul 24, 2007 at 04:26:21PM -0700, Brandon Philips wrote:
Could you point me to an example you have in mind?
I quickly searched through a handful of the PCI device drivers and
couldn't find an example where the .remove
PROTECTED]
Caused-By : ?
Handled-By : ?
Status : unknown
From 2a7e1148a9d3ee860dc2650c9a45288b120e250f Mon Sep 17 00:00:00 2001
From: Al Viro [EMAIL PROTECTED]
Date: Mon, 23 Jul 2007 06:20:22 -0400
Subject: [PATCH] Fix failure exits in asus-laptop
Fallout from
gives the wrong value on little-endian;
As the matter of fact, on l-e it gives 0 - IPV6_TCLASS_MASK will be
htonl(0x0ff0), i.e. on little-endian we have (something 20) 0xff0...
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
diff --git a/net/ipv6/ip6_tunnel.c b/net/ipv6/ip6_tunnel.c
--- a/net
AFAICS, all callers of dma_skb_copy_datagram_iovec()
are either
* recursive for fragments, pass pinned_list unchanged or
* called from tcp, with pinned_list coming from
tp-ucopy.pinned_list and only when tp-ucopy.dma_chan is non-NULL.
Now, all non-NULL assignments to
On Mon, Feb 12, 2007 at 09:12:56AM +0100, Andi Kleen wrote:
On Monday 12 February 2007 09:03, Amit Kale wrote:
The already released kernel contains a broken driver. It broke due to some
code rearrangement changes someone submitted to fix sparse warnings.
s/sparse warnings/breakage on
On Mon, Feb 12, 2007 at 04:33:38AM -0800, Amit S. Kale wrote:
Signed-off-by: Amit S. Kale [EMAIL PROTECTED]
ACK. My apologies - that pile of brainos had been introduced when
I'd been fixing the set_bit() abuses in there (a bunch of places
had been casting address of u32 to unsigned long * and
Spot the bug...
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
diff --git a/drivers/net/atl1/atl1_hw.c b/drivers/net/atl1/atl1_hw.c
index 08b2d78..e28707a 100644
--- a/drivers/net/atl1/atl1_hw.c
+++ b/drivers/net/atl1/atl1_hw.c
@@ -357,7 +357,7 @@ void atl1_hash_set(struct atl1_hw *hw, u32
it has almost
no remaining users, so it's better to just outright kill it.
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
drivers/net/3c503.c |3 +--
drivers/net/ac3200.c |3 +--
drivers/net/e2100.c |3 +--
drivers/net/es3210.c |2
On Wed, Dec 27, 2006 at 07:58:54AM +, Christoph Hellwig wrote:
On Mon, Dec 18, 2006 at 05:53:59AM -0800, Amit S. Kale wrote:
Signed-off-by: Amit S. Kale [EMAIL PROTECTED]
netxen_nic.h |2 +-
netxen_nic_init.c | 12 ++--
netxen_nic_main.c |4 ++--
3 files
On Tue, Dec 12, 2006 at 05:17:56PM -0800, David Miller wrote:
From: Adrian Bunk [EMAIL PROTECTED]
Date: Tue, 12 Dec 2006 17:24:35 +0100
This patch converts drivers/net/loopback.c to using module_init().
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
I'm not %100 sure of this one, let's
On Sat, Dec 09, 2006 at 08:42:45PM -0500, Jeff Bailey wrote:
On 09/12/06, David Miller [EMAIL PROTECTED] wrote:
You can't deprecate stuff visible to userspace, sorry Thomas,
we just can't do it.
You can migrate people to better interfaces, but you can't
pull the rug out from anyone once
On Wed, Dec 06, 2006 at 03:31:46PM +0100, Thomas Graf wrote:
At the time they were added they were meant to be exported but netlink
has evolved and we now have a type safe API.
Where? AFAICS, netlink might be considered type-safe only within an
address family...
-
To unsubscribe from this
On Wed, Dec 06, 2006 at 09:26:39PM +0100, Thomas Graf wrote:
* Al Viro [EMAIL PROTECTED] 2006-12-06 17:13
On Wed, Dec 06, 2006 at 03:31:46PM +0100, Thomas Graf wrote:
At the time they were added they were meant to be exported but netlink
has evolved and we now have a type safe API
On Thu, Nov 16, 2006 at 05:58:40AM -0500, David Miller wrote:
I just rebased net-2.6.20 at:
master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6.20.git
Al Viro has been going crazy with endianness and checksum type
sparse annotations, which brings the patch count up to 171
On Wed, Nov 08, 2006 at 11:55:48PM -0800, David Miller wrote:
From: Al Viro [EMAIL PROTECTED]
Date: Thu, 9 Nov 2006 07:22:16 +
I haven't touch that argument yet; if there's an agreement as to what should
we switch to, I'll do that. So... does everyone agree that u32 is the way
to go
On Mon, Nov 13, 2006 at 09:12:22AM +, Russell King wrote:
On Mon, Nov 13, 2006 at 08:52:23AM +, Al Viro wrote:
After doing the above we have the following:
Platform-dependent:
__wsum csum_tcpudp_nofold(__be32, __be32, T1, T2, __wsum);
On arm/arm26: T1 = unsigned short, T2
On Mon, Nov 13, 2006 at 11:22:00PM +0300, Alexey Dobriyan wrote:
6.5.7(5): The result of E1 E2 is E1 right-shifted E2 bit positions.
...
If E1 has a signed type and a negative value, the resulting value
is implementation defined.
So, cast -1 to unsigned type to
On Mon, Nov 13, 2006 at 04:50:58PM -0800, David Miller wrote:
From: David Stevens [EMAIL PROTECTED]
Date: Fri, 10 Nov 2006 09:54:58 -0800
The Internet checksum is defined as a 1's-complement sum, so if the
alternate 0 does not have a special meaning in a protocol, then by
1's-complement
On Mon, Nov 13, 2006 at 05:44:12PM -0800, David Stevens wrote:
That's actually what I was suggesting. In 1's-complement,
~0 == -0 which is still 0, so barring any special case (like UDP's
0 means no checksum rule), it should be equally valid for a
packet to have 0 or ~0 as the checksum
On Fri, Nov 10, 2006 at 12:51:19PM -0500, Brian Haley wrote:
Al Viro wrote:
On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote:
Since the only difference between echo requests and echo replies is the
ICMPv6 type value (which is a difference of 1), just subtracting one
from
On Fri, Nov 10, 2006 at 06:05:34PM +, Al Viro wrote:
On Fri, Nov 10, 2006 at 12:51:19PM -0500, Brian Haley wrote:
Al Viro wrote:
On Fri, Nov 10, 2006 at 11:25:53AM -0500, Brian Haley wrote:
Since the only difference between echo requests and echo replies is the
ICMPv6 type value
On Fri, Nov 10, 2006 at 02:04:32PM -0500, Brian Haley wrote:
Al Viro wrote:
so -= 1 is broken even on ia64 and it's *always* broken on big-endian
boxen.
It's not broken in ia64, I've tested that, just don't have an x86 for
testing right now. Can you please apply these changes and prove
AFAICS, the rules are:
(1) checksum is 16-bit one's complement of the one's complement sum of
relevant 16bit words.
(2) for v4 UDP all-zeroes has special meaning - no checksum; if you get
it from (1), send all-ones instead.
(3) for v6 UDP we have the same remapping as in (2), but
On Wed, Nov 08, 2006 at 10:13:32PM +, Al Viro wrote:
AFAICS, the rules are:
(1) checksum is 16-bit one's complement of the one's complement sum of
relevant 16bit words.
(2) for v4 UDP all-zeroes has special meaning - no checksum; if you get
it from (1), send all-ones instead
On Wed, Nov 08, 2006 at 11:00:59PM -0800, David Miller wrote:
From: Chen, Kenneth W [EMAIL PROTECTED]
Date: Wed, 8 Nov 2006 18:02:06 -0800
The generic version of csum_ipv6_magic has the len argument declared as
__u16, while most arch dependent version declare it as __u32. After
looking
On Mon, Nov 06, 2006 at 10:32:43AM +, Al Viro wrote:
On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
+ opt-opt_optl = dn_htons((__u16)*ptr++);
Lose that cast; it's only confusing the things...
+ memcpy(opt-opt_data, ptr, dn_ntohs(opt-opt_optl
On Mon, Nov 06, 2006 at 10:31:02AM +, Steven Whitehouse wrote:
+ opt-opt_optl = dn_htons((__u16)*ptr++);
Lose that cast; it's only confusing the things...
+ memcpy(opt-opt_data, ptr, dn_ntohs(opt-opt_optl));
+ skb_pull(skb, dn_ntohs(opt-opt_optl) + 1);
... and I'd actually
On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
And (deleted) is correctly added to deleted files.
The hell it will.
touch a
touch b
exec 5a
mv b a
ls -l /proc/$$/fd/5
With your patch and without it, please.
PS: getting rid of socket dentries is a bad idea with the capital
On Wed, Nov 01, 2006 at 08:38:11AM +, Al Viro wrote:
On Wed, Nov 01, 2006 at 09:21:06AM +0100, Eric Dumazet wrote:
And (deleted) is correctly added to deleted files.
The hell it will.
touch a
touch b
exec 5a
mv b a
ls -l /proc/$$/fd/5
With your patch and without it, please
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
drivers/net/arm/etherh.c | 20 ++--
1 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/arm/etherh.c b/drivers/net/arm/etherh.c
index 747a71f..f3faa4f 100644
--- a/drivers/net/arm/etherh.c
+++ b/drivers/net
The rest of 8390 conversions; ifdef cascade in 8390.h is gone now.
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
drivers/net/8390.h |4
drivers/net/Makefile |2 +-
drivers/net/ne-h8300.c | 23 +++
3 files changed, 16 insertions(+), 13 deletions(-)
diff
more 8390 conversions - mac8390, zorro8390 and hydra got the same treatment
as arm etherh; one more case in 8390.h ifdef cascade is gone.
Signed-off-by: Al Viro [EMAIL PROTECTED]
---
drivers/net/8390.h | 16 +---
drivers/net/Makefile|6 +++---
drivers/net/hydra.c
:icmp_send(skb, ICMP_PARAMETERPROB, 0,
htonl((pp_ptr-iph)24));
and
./net/ipv4/icmp.c:651: info = ntohl(icmph-un.gateway) 24;
IOW,
From cef2804df14cfc340f0fa70ecd09551c8e22447b Mon Sep 17 00:00:00 2001
From: Al Viro [EMAIL PROTECTED]
Date: Tue, 12 Sep 2006 17:50:58 +0100
Subject: [PATCH] ipip
Handling of ipip and ip_gre ICMP error relaying is b0rken; it accesses
32bit net-endian field as host-endian, does comparison, subtraction and
stuffs the result to 32bit net-endian. Without any conversions.
Fixed, made endian-clean.
Signed-off-by: Al Viro [EMAIL PROTECTED]
diff --git
On Mon, Aug 07, 2006 at 04:20:33PM -0700, Stephen Hemminger wrote:
Please consider EXPORT_SYMBOL_GPL because this interface would be a obvious
target for binary modules writers to use.
As opposed to duplicating it? WTFPoint of restriction that is trivial to
bypass? Look at those functions;
On Tue, Jun 20, 2006 at 11:21:43PM +0200, Daniel Lezcano wrote:
Al Viro wrote:
On Fri, Jun 09, 2006 at 11:02:02PM +0200, [EMAIL PROTECTED] wrote:
- renaming an interface in one namespace affects everyone.
Exact. If we ensure the interface can't be renamed if used in different
namespace
On Fri, Jun 09, 2006 at 11:02:02PM +0200, [EMAIL PROTECTED] wrote:
What is missing ?
-
The routes are not yet isolated, that implies:
- binding to another container's address is allowed
- an outgoing packet which has an unset source address can
potentially get
On Fri, Jun 09, 2006 at 11:02:04PM +0200, [EMAIL PROTECTED] wrote:
+ read_lock(dev_base_lock);
+
+ for (dev = dev_base; dev; dev = dev-next)
+ if (!strncmp(dev-name, devname, IFNAMSIZ))
+ break;
+
+ if (!dev) {
+ ret = -ENODEV;
+
On Fri, Jun 09, 2006 at 11:02:05PM +0200, [EMAIL PROTECTED] wrote:
struct net_device *dev_get_by_name(const char *name)
{
+ struct net_ns_dev_list *dev_list = (net_ns()-dev_list);
struct net_device *dev;
- read_lock(dev_base_lock);
+ read_lock(dev_list-lock);
On Wed, Jun 07, 2006 at 03:38:39PM +0400, Alexey Dobriyan wrote:
I think, yes. Al Viro is sitting on terabytes of endian annotations in
networking code. See net-endian.b* branches at
git://git.kernel.org/pub/scm/linux/kernel/git/viro/bird.git
I don't know if he considers them ready.
I do
On Wed, May 10, 2006 at 04:14:05PM -0700, Stephen Hemminger wrote:
Fix warning from sparse in bonding code about incorrect type in assignment
*snerk*
Only if you are building without -Wcast-to-as. It _is_ incorrect type in
assignment. And the real fix is to expand the call, killing set_fs()
On Thu, Mar 30, 2006 at 12:26:58AM +0200, Andi Kleen wrote:
dentry_cache 999168 1024594208 191 : tunables 120 608 :
slabdata 53926 53926 0 : shrinker stat 18522624 8871000
Hrm interesting is this one:
sock_inode_cache 996784 99680570451 : tunables
On Thu, Mar 30, 2006 at 10:50:48AM +0100, Al Viro wrote:
FWIW... One thing that might be useful here:
Here's what I had in mind:
Allow explictly mark allocated objects as allocated here, so that they'll
show up that way for all slab debugging purposes. New helpers:
slab_charge_here
BTW, it allows even funnier stuff: instead of I'd been allocated by place
you can do I'd passed through place. E.g. if object has different states
you can slap slab_charge_here() in state transitions and /proc/slab_allocators
will count them separately, showing how many objects are in which
On Tue, Mar 28, 2006 at 01:12:25PM +0200, Andi Kleen wrote:
On Monday 27 March 2006 17:41, Darren Jenkins\ wrote:
- shmems = kzalloc(((0x1-0xa) / 0x800) * sizeof(unsigned long),
+ shmems = kcalloc(((0x1-0xa) / 0x800), sizeof(unsigned long),
On Tue, Feb 14, 2006 at 04:50:13PM -0800, David Stevens wrote:
[EMAIL PROTECTED] wrote on 02/14/2006 04:23:28 PM:
In linux/igmp.h:
struct ip_mc_list
{
struct in_device*interface;
unsigned long multiaddr;
struct ip_sf_list *sources;
and AFAICS
On Sat, Jan 14, 2006 at 09:38:44AM -0800, Kris Katterjohn wrote:
From: Lennert Buytenhek
Sent: 1/14/2006 9:23:19 AM
On Sat, Jan 14, 2006 at 08:23:41AM -0800, Kris Katterjohn wrote:
This changes signed long to long.
Hmmm, is 'long' guaranteed to be signed?
--L
All integral
BTW, why does csum_tcpudp_nofold() have such a prototype?
It takes IP addresses as unsigned long and proto as unsigned short;
the former is bloody odd on 64bit boxen and the latter is bloody
odd, period. The value we are interested in is 8bit; all callers
pass either an explicit constant
On Sat, Jan 07, 2006 at 12:59:15AM -0800, David S. Miller wrote:
Why not just make some kind of negate() macro that hides away all of
the typing issues? Another way to describe the operation is as a
xor of X with an all-1's bitmask the same size of X. Maybe that helps
describe it better?
On Sat, Jan 07, 2006 at 02:03:42AM -0800, David S. Miller wrote:
From: Al Viro [EMAIL PROTECTED]
Date: Sat, 7 Jan 2006 09:39:10 +
BTW, is there any reason why
static inline void ip_eth_mc_map(u32 addr, char *buf)
{
addr=ntohl(addr);
buf[0]=0x01;
buf[1
On Sat, Jan 07, 2006 at 01:05:53PM -0800, David S. Miller wrote:
Why are you shifting addr instead of n?
Because of a braino done when (re)typing it? ;-)
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Fri, Jan 06, 2006 at 01:25:03PM -0800, David S. Miller wrote:
From: Alexey Dobriyan [EMAIL PROTECTED]
Date: Fri, 6 Jan 2006 23:18:37 +0300
And fix trivial warnings that emerged.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
Applied.
OK, will merge... I've actually got way
Applied. BTW, I'm very tempted to annotate s_addr and sin_port at that
point; it will create a lot of noise around net/*, though, so depending
on the way you keep track of regressions it might be a bad idea right
now. I'm only using -D__CHECK_ENDIAN__ on subtree builds, so it's
not a problem for
On Wed, Dec 21, 2005 at 10:35:19AM -0800, Stephen Hemminger wrote:
Right now there is a hole in the module ref counting system because
there is no proper ref counting for sysctl tables used by modules.
This means that if an application is holding /proc/sys/foo open and
module that created it
On Wed, Dec 21, 2005 at 07:08:49PM +, Al Viro wrote:
Solution is fairly simple:
Just to clarify: said solution is already in the tree...
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
On Sat, Nov 12, 2005 at 01:48:20PM +, Al Viro wrote:
On Fri, Nov 11, 2005 at 10:29:18PM -0700, Matthew Wilcox wrote:
I think they work fine everywhere. Adrian wants to remove the API they
use.
I think this is a bad idea. The drivers should be converted.
They are - I'll send
On Fri, Nov 11, 2005 at 10:29:18PM -0700, Matthew Wilcox wrote:
I think they work fine everywhere. Adrian wants to remove the API they
use.
I think this is a bad idea. The drivers should be converted.
They are - I'll send patches later today...
-
To unsubscribe from this list: send the
301 - 381 of 381 matches
Mail list logo
