On Wed, Aug 19, 2015 at 3:16 PM, Alex Gartrell agartr...@fb.com wrote:
Fixes: df383e624 (lwtunnel: fix memory leak)
Ah sorry, this is PATCH net-next, obviously :/
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More
Fixes: df383e624 (lwtunnel: fix memory leak)
Signed-off-by: Alex Gartrell agartr...@fb.com
---
include/net/lwtunnel.h | 4
1 file changed, 4 insertions(+)
diff --git a/include/net/lwtunnel.h b/include/net/lwtunnel.h
index 34fd8f7..cfee539 100644
--- a/include/net/lwtunnel.h
+++ b/include
On Wed, Aug 19, 2015 at 4:28 PM, Eric Dumazet eric.duma...@gmail.com wrote:
We've seen similar patches earlier today on netdev ;)
Ah, the mailing list equivalent of someone letting you know that you
left your fly down :)
Sorry for the noise!
--
To unsubscribe from this list: send the line
Hey Gregory,
On Sun, Aug 2, 2015 at 2:28 PM, Gregory Hoggarth
gregory.hogga...@alliedtelesis.co.nz wrote:
I will apply the new suggested patch, reverting previous patch, and test
overnight and update tomorrow.
Did this solve your problem? If not, would you mind sharing a repro?
--
Alex
offset, so we should be able to validate those references as well.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
kernel/bpf/verifier.c | 6 -
samples/bpf/test_verifier.c | 59 +
2 files changed, 64 insertions(+), 1 deletion(-)
diff --git
On Tue, Jul 21, 2015 at 8:00 PM, Alexei Starovoitov a...@kernel.org wrote:
On Tue, Jul 21, 2015 at 07:00:40PM -0700, Alex Gartrell wrote:
mov %rsp, %r1 ; r1 = rsp
add $-8, %r1; r1 = rsp - 8
store_q $123, -8(%rsp) ; *(u64*)r1 = 123 - valid
offset, so we should be able to validate those references as well.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
kernel/bpf/verifier.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index 039d866..5dfbece 100644
--- a/kernel/bpf
On Tue, Jul 21, 2015 at 2:40 AM, Daniel Borkmann dan...@iogearbox.net wrote:
On 07/21/2015 12:24 AM, Alexei Starovoitov wrote:
On 7/20/15 3:15 PM, Alex Gartrell wrote:
The ship has probably sailed on this one, but it seems like ENOSPC
makes more sense than E2BIG. Any chance of changing
- }
net-next/master:kernel/bpf/hashtab.c-
net-next/master:kernel/bpf/hashtab.c- if (l_old map_flags == BPF_NOEXIST) {
net-next/master:kernel/bpf/hashtab.c- /* elem already exists */
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev
= htb_get # returns NULL, removed in htb_delete
- htb_qlen_notify(sch, NULL) # BOOM
This patch checks cl for 0 before invoking qlen_notify and put. The notify
is not necessary in this case, as the parent has already been deactivated
anyway.
Signed-off-by: Alex Gartrell agartr
already been deactivated
anyway.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
net/sched/sch_api.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index f06aa01..46be5e5 100644
--- a/net/sched/sch_api.c
+++ b/net/sched
and to skip it, and
then to otherwise find a way to close the hole. Do you agree?
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
been deactivated
anyway.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
net/sched/sch_api.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c
index 2d2f079..f5d48dd 100644
--- a/net/sched/sch_api.c
+++ b/net/sched
}
}
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
had
this problem. I'm pretty sure this isn't a problem in 3.4 or before.
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, skb_set_owner_w is totally broken for non full-socks.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
net/netfilter/ipvs/ip_vs_xmit.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index bf66a86
, skb_set_owner_w is totally broken for non full-socks.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
net/netfilter/ipvs/ip_vs_xmit.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index bf66a86
On Sun, Jul 5, 2015 at 3:13 PM, Julian Anastasov j...@ssi.bg wrote:
May be the patch fixes crashes? If yes, Simon
should apply it for ipvs/net tree, otherwise after
the merge window...
Yeah this is definitely a crash-fix and it's existed since at least 3.10.
--
Alex Gartrell agartr
it (not even sure my test would run on that code
base).
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
traffic
destined to local IP to remote host
What do you think of the following:
commit f04c42f8041cc4ccc4cb2a30c1058136dd497a83
Author: Alex Gartrell agartr...@fb.com
Date: Wed Jul 1 13:24:46 2015 -0700
ipvs: orphan_skb in case of forwarding
It is possible that we bind
this behavior in ipvs?
if (!skb-dev skb-sk) return NF_ACCEPT;
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jul 2, 2015 at 2:18 PM, Alex Gartrell alexgartr...@gmail.com wrote:
If early demux was enabled, we'd use the route from the socket
Actually now that I think about it, this is probably broken, because
we don't reply to the packet but instead silently drop it.
--
Alex Gartrell agartr
If we early-demux bind a TCP_TIMEWAIT socket to an skb and then orphan it
(as we need to do in the ipvs forwarding case), sock_wfree and sock_rfree
are going to reach into the inet_timewait_sock and mess with fields that
don't exist.
Signed-off-by: Alex Gartrell agartr...@fb.com
---
net/core
sets sock_wfree.
I'll figure out how to ensure that we're using an appropriate destructor here.
Appreciate the patience!
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info
to an array (you'll get
a build failure instead of 0).
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that
successfully reuses a port completely takes over from the previous
listener.
This is a really weird corner case from a user's perspective. I think
sharing it is more reasonable, as you can always signal the other
process out of band.
--
Alex Gartrell
--
To unsubscribe from this list: send the line
:)
--
Alex Gartrell agartr...@fb.com
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
27 matches
Mail list logo
