Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-03 Thread Alex Sidorenko
11/03/2017 02:26 PM, Jay Vosburgh wrote: Alex Sidorenko wrote: Jay, while scenario you describe makes sense, it does not match what we see in our tests. The instrumentation prints info every time we enter bond_mii_monitor(), bond_miimon_inspect(), bond_miimon_commit() and every time we are co

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-03 Thread Alex Sidorenko
9:26 SYDC1LNX kernel: bond0: bond_miimon_inspect: entered BOND_LINK_DOWN case on slave ens3f0 Oct 31 09:09:26 SYDC1LNX kernel: bond0: bond_miimon_inspect: entered BOND_LINK_UP case on slave ens3f1 ... Alex On 11/02/2017 09:11 PM, Jay Vosburgh wrote: Alex Sidorenko wrote: On 11/02/2017 12:51

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-02 Thread Alex Sidorenko
On 11/02/2017 12:51 AM, Jay Vosburgh wrote: Jarod Wilson wrote: On 2017-11-01 8:35 PM, Jay Vosburgh wrote: Jay Vosburgh wrote: Alex Sidorenko wrote: The problem has been found while trying to deploy RHEL7 on HPE Synergy platform, it is seen both in customer's environment and i

Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Alex Sidorenko
commit++; continue; } -- 2.7.4 -- -- Alex Sidorenko email: a...@hpe.com ERT Linux Hewlett-Packard Enterprise (Canada) --

Re: Receive offloads, small RCVBUF and zero TCP window

2016-11-30 Thread Alex Sidorenko
On Monday, November 28, 2016 4:14:04 PM EST Alex Sidorenko wrote: > On Monday, November 28, 2016 3:54:59 PM EST David Miller wrote: > > From: Alex Sidorenko > > Date: Mon, 28 Nov 2016 15:49:26 -0500 > > > > > Now the question is whether is is OK to have icsk->i

Re: Receive offloads, small RCVBUF and zero TCP window

2016-11-28 Thread Alex Sidorenko
On Monday, November 28, 2016 3:54:59 PM EST David Miller wrote: > From: Alex Sidorenko > Date: Mon, 28 Nov 2016 15:49:26 -0500 > > > Now the question is whether is is OK to have icsk->icsk_ack.rcv_mss > > larger than MTU. > > It absolutely is not OK. > > If

Receive offloads, small RCVBUF and zero TCP window

2016-11-28 Thread Alex Sidorenko
cause of rcv_mss * fluctuations. --SAW 1998/11/1 */ Regards, Alex -- -- Alex Sidorenko email: a...@hpe.com ERT Linux Hewlett-Packard Enterprise (Canada) --

[PATCH net v2] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-07 Thread Alex Sidorenko
to using incorrect hash-bucket for port lookup and as a result, packets are dropped. The fix consists of changing 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that there is no packet drop anymore. Signed-off-by: Alex Sidorenko --- v2: fixed formatting

[PATCH net] Fixing a bug in team driver due to incorrect 'unsigned int' to 'int' conversion

2016-10-05 Thread Alex Sidorenko
to using incorrect hash-bucket for port lookup and as a result, packets are dropped. The fix consists of changing 'int num' to 'unsigned int num'. Testing of a fixed kernel shows that there is no packet drop anymore. Signed-off-by: Alex Sidorenko --- include/linux/i

A bug in team driver

2016-10-04 Thread Alex Sidorenko
in team_mode_loadbalance.c:lb_hash_select_tx_port but we pass 'unsigned char hash' to team_num_to_port_index(), so there should be no overflow. I did not test that mode in my tests. Regards, Alex -- -- Alex Sidorenko email: a...@hpe.com ERT Linux Hewlett-Packard Enterprise (Canada) --

Re: SWS for rcvbuf < MTU

2007-04-02 Thread Alex Sidorenko
On March 14, 2007 12:18:56 pm Alex Sidorenko wrote: > On March 13, 2007 03:01:50 pm John Heffner wrote: > > Sorry for the long delay in response, I've been on vacation.  I'm okay > > with your patch, and I can't think of any real problem with it, except > > that

Re: SWS for rcvbuf < MTU

2007-03-14 Thread Alex Sidorenko
On March 13, 2007 03:01:50 pm John Heffner wrote: > Sorry for the long delay in response, I've been on vacation.  I'm okay > with your patch, and I can't think of any real problem with it, except > that the behavior is non-standard.  Then again, Linux acking in general > is non-standard, which has

Re: SWS for rcvbuf < MTU

2007-03-05 Thread Alex Sidorenko
On March 3, 2007 06:40:12 pm John Heffner wrote: > David Miller wrote: > > From: John Heffner <[EMAIL PROTECTED]> > > Date: Fri, 02 Mar 2007 16:16:39 -0500 > > > >> Please don't apply the patch I sent. I've been thinking about this a > >> bit harder, and it may not fix this particular problem. (H

Re: SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
On March 2, 2007 01:54:45 pm John Heffner wrote: > Alex Sidorenko wrote: > [snip] > > > --- net/ipv4/tcp_output.c.orig Wed May 3 20:40:43 2006 > > +++ net/ipv4/tcp_output.c Tue Jan 30 14:24:56 2007 > > @@ -641,6 +641,7 @@ > > * Note, we don't "

Re: SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
On March 2, 2007 02:25:42 pm David Miller wrote: > From: Alex Sidorenko <[EMAIL PROTECTED]> > Date: Fri, 2 Mar 2007 11:28:28 -0500 > > > Customer has confirmed that this resolves the problem and decreases > > CPU usage by his custom application - even when there is no SW

SWS for rcvbuf < MTU

2007-03-02 Thread Alex Sidorenko
Hello, this is a rare corner case met by one of HP partners on 2.4.20 on IA64. Inspecting the sources of the latest 2.6.20.1 (net/ipv4/tcp_output.c) we can see that the bug is still there. Here is a description of the bug and the suggested fix. The problem occurs when the remote host (not nece