Re: [PATCH wpan-next v2 02/11] ieee802154: Internal PAN management

2023-09-18 Thread Alexander Aring
Hi, On Mon, Sep 18, 2023 at 10:15 AM Miquel Raynal wrote: > > Hi Alexander, > > > > > > > > +// SPDX-License-Identifier: GPL-2.0 > > > > > > +/* > > > > > > + * IEEE 802.15.4 PAN management > > > > > > + * > > > > > > + * Copyright (C) 2021 Qorvo US, Inc > > > > > > + * Authors: > > > > > > + *

Re: [PATCH wpan-next v2 02/11] ieee802154: Internal PAN management

2023-09-18 Thread Alexander Aring
Hi, On Mon, Sep 18, 2023 at 5:01 AM Miquel Raynal wrote: > > Hello, > > aahri...@redhat.com wrote on Sun, 17 Sep 2023 07:50:55 -0400: > > > Hi, > > > > On Sat, Sep 16, 2023 at 11:39 AM Stefan Schmidt > > wrote: > > > > > > Hello Miquel. > > > > > > On 01.09.23 19:04, Miquel Raynal wrote: > > > >

Re: [PATCH wpan-next v2 02/11] ieee802154: Internal PAN management

2023-09-17 Thread Alexander Aring
Hi, On Sat, Sep 16, 2023 at 11:39 AM Stefan Schmidt wrote: > > Hello Miquel. > > On 01.09.23 19:04, Miquel Raynal wrote: > > Introduce structures to describe peer devices in a PAN as well as a few > > related helpers. We basically care about: > > - Our unique parent after associating with a coord

Re: [PATCH] net: mac802154: fix WARNING in ieee802154_del_device

2021-04-12 Thread Alexander Aring
Hi, On Mon, 12 Apr 2021 at 06:58, Pavel Skripkin wrote: > > syzbot reported WARNING in ieee802154_del_device. The problem > was in uninitialized mutex. In case of NL802154_IFTYPE_MONITOR > mutex won't be initialized, but ieee802154_del_device() accessing it. > > Reported-by: syzbot+bf8b5834b7ec22

Re: [PATCH] net: fix shift-out-of-bounds in nl802154_new_interface

2021-04-06 Thread Alexander Aring
Hi, On Mon, 5 Apr 2021 at 15:58, Pavel Skripkin wrote: > > syzbot reported shift-out-of-bounds in nl802154_new_interface. > The problem was in signed representation of enum nl802154_iftype > > enum nl802154_iftype { > /* for backwards compatibility TODO */ > NL802154_IFTYPE_UNSPEC

Re: [PATCH RESEND wpan 00/15] net: ieee802154: forbid sec params for monitors

2021-04-05 Thread Alexander Aring
Hi, On Sun, 4 Apr 2021 at 20:31, Alexander Aring wrote: > > Hi, > > this patch series contains fixes to forbid various security parameters > settings for monitor types. Monitor types doesn't use the llsec security > currently and we don't support it. With this pat

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-05 Thread Alexander Aring
; gerrit public mirror. I'm using it to check patches with syzbot. Change > ids are useless outside gerrit, so it shouldn't be here. > > Btw, should I sent v2 or this is already fixed? Otherwise the patch looks good. May Stefan can fix this. Acked-by: Alexander Aring - Alex

Re: [PATCH v2] net: mac802154: Fix general protection fault

2021-04-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members is in IS_ERR() range it will > cause general protection fault in clean up fun

Re: [PATCH] net: fix NULL ptr dereference in nl802154_del_llsec_key

2021-04-04 Thread Alexander Aring
Hi, On Sat, 3 Apr 2021 at 11:18, Pavel Skripkin wrote: > > syzbot reported NULL ptr dereference in nl802154_del_llsec_key()[1] > The problem was in case of info->attrs[NL802154_ATTR_SEC_KEY] == NULL. > nla_parse_nested_deprecated()[2] doesn't check this condition before calling > nla_len()[3] >

[PATCH RESEND wpan 15/15] net: ieee802154: stop dump llsec params for monitors

2021-04-04 Thread Alexander Aring
This patch stops dumping llsec params for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+cde43a581a8e5f317...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c |

[PATCH RESEND wpan 14/15] net: ieee802154: forbid monitor for del llsec seclevel

2021-04-04 Thread Alexander Aring
This patch forbids to del llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+fbf4fc11a819824e0...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/

[PATCH RESEND wpan 10/15] net: ieee802154: forbid monitor for add llsec devkey

2021-04-04 Thread Alexander Aring
This patch forbids to add llsec devkey for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 13/15] net: ieee802154: forbid monitor for add llsec seclevel

2021-04-04 Thread Alexander Aring
This patch forbids to add llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 12/15] net: ieee802154: stop dump llsec seclevels for monitors

2021-04-04 Thread Alexander Aring
This patch stops dumping llsec seclevels for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/

[PATCH RESEND wpan 11/15] net: ieee802154: forbid monitor for del llsec devkey

2021-04-04 Thread Alexander Aring
This patch forbids to del llsec devkey for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 08/15] net: ieee802154: forbid monitor for del llsec dev

2021-04-04 Thread Alexander Aring
This patch forbids to del llsec dev for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 09/15] net: ieee802154: stop dump llsec devkeys for monitors

2021-04-04 Thread Alexander Aring
This patch stops dumping llsec devkeys for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee80215

[PATCH RESEND wpan 06/15] net: ieee802154: stop dump llsec devs for monitors

2021-04-04 Thread Alexander Aring
This patch stops dumping llsec devs for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee802154/nl

[PATCH RESEND wpan 07/15] net: ieee802154: forbid monitor for add llsec dev

2021-04-04 Thread Alexander Aring
This patch forbids to add llsec dev for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 05/15] net: ieee802154: forbid monitor for del llsec key

2021-04-04 Thread Alexander Aring
This patch forbids to del llsec key for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 03/15] net: ieee802154: stop dump llsec keys for monitors

2021-04-04 Thread Alexander Aring
This patch stops dumping llsec keys for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee802154/nl

[PATCH RESEND wpan 04/15] net: ieee802154: forbid monitor for add llsec key

2021-04-04 Thread Alexander Aring
This patch forbids to add llsec key for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH RESEND wpan 02/15] net: ieee802154: forbid monitor for set llsec params

2021-04-04 Thread Alexander Aring
This patch forbids to set llsec params for monitor interfaces which we don't support yet. Reported-by: syzbot+8b6719da8a04beeaf...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ieee8

[PATCH RESEND wpan 00/15] net: ieee802154: forbid sec params for monitors

2021-04-04 Thread Alexander Aring
ecurity is not supported yet. However there might be a possibility in future that the kernel will decrypt frames with llsec information for sniffing frames and deliver plaintext to userspace, but this isn't supported yet. - Alex Alexander Aring (15): net: ieee802154: nl-mac: fix check

[PATCH RESEND wpan 01/15] net: ieee802154: nl-mac: fix check on panid

2021-04-04 Thread Alexander Aring
This patch fixes a null pointer derefence for panid handle by move the check for the netlink variable directly before accessing them. Reported-by: syzbot+d4c07de0144f6f63b...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl-mac.c | 7 --- 1 file changed, 4

Re: [PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned

2021-03-06 Thread Alexander Aring
Hi Stefan, On Thu, 4 Mar 2021 at 02:28, Stefan Schmidt wrote: > > Hello Alex. > > On 28.02.21 16:18, Alexander Aring wrote: > > This patch changes the iftype type variable to unsigned that it can > > never be reach a negative value. > > > > R

Re: [PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params

2021-03-06 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 02:28, Stefan Schmidt wrote: > > Hello Alex. > > On 28.02.21 16:18, Alexander Aring wrote: > > This patch forbids to set llsec params for monitor interfaces which we > > don't support yet. > > > > Reported-by: syzbot+8b671

[PATCH resend] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-04 Thread Alexander Aring
iable mode. Signed-off-by: Alexander Aring --- resend: - forgot linux-man mailinglist in cc, sorry. man7/netlink.7 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man7/netlink.7 b/man7/netlink.7 index c69bb62bf..2cb0d1a55 100644 --- a/man7/netlink.7 +++ b/man7/netlink.7

[PATCH] netlink.7: note not reliable if NETLINK_NO_ENOBUFS

2021-03-04 Thread Alexander Aring
iable mode. Signed-off-by: Alexander Aring --- man7/netlink.7 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man7/netlink.7 b/man7/netlink.7 index c69bb62bf..2cb0d1a55 100644 --- a/man7/netlink.7 +++ b/man7/netlink.7 @@ -478,7 +478,7 @@ errors. .\"Author: Pablo Nei

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-04 Thread Alexander Aring
Hi, On Thu, 4 Mar 2021 at 04:23, Pavel Skripkin wrote: ... > > > > I think this need to be: > > > > if (!IS_ERR_OR_NULL(key->tfm[i])) > > > > otherwise we still run into issues for the current iterator when > > key->tfm[i] is in range of IS_ERR(). > > Oh... I got it completly wrong, I'm sorry. If

Re: [PATCH] net: mac802154: Fix null pointer dereference

2021-03-03 Thread Alexander Aring
Hi, On Wed, 3 Mar 2021 at 11:28, Pavel Skripkin wrote: > > syzbot found general protection fault in crypto_destroy_tfm()[1]. > It was caused by wrong clean up loop in llsec_key_alloc(). > If one of the tfm array members won't be initialized it will cause > NULL dereference in crypto_destroy_tfm()

Re: [PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs

2021-02-28 Thread Alexander Aring
Hi Stefan, On Sun, 28 Feb 2021 at 10:21, Alexander Aring wrote: > > This patch adds a missing consume_skb() when deliver a skb to upper > monitor interfaces of a wpan phy. > > Reported-by: syzbot+44b651863a17760a8...@syzkaller.appspotmail.com > Signed-off-by: Alexander A

[PATCH wpan 17/17] net: ieee802154: stop dump llsec params for monitors

2021-02-28 Thread Alexander Aring
This patch stops dumping llsec params for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+cde43a581a8e5f317...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c |

[PATCH wpan 16/17] net: ieee802154: forbid monitor for del llsec seclevel

2021-02-28 Thread Alexander Aring
This patch forbids to del llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Reported-by: syzbot+fbf4fc11a819824e0...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/

[PATCH wpan 15/17] net: ieee802154: forbid monitor for add llsec seclevel

2021-02-28 Thread Alexander Aring
This patch forbids to add llsec seclevel for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 13/17] net: ieee802154: forbid monitor for del llsec devkey

2021-02-28 Thread Alexander Aring
This patch forbids to del llsec devkey for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 01/17] net: ieee802154: make shift exponent unsigned

2021-02-28 Thread Alexander Aring
This patch changes the iftype type variable to unsigned that it can never be reach a negative value. Reported-by: syzbot+7bf7b22759195c9a2...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH wpan 14/17] net: ieee802154: stop dump llsec seclevels for monitors

2021-02-28 Thread Alexander Aring
This patch stops dumping llsec seclevels for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/

[PATCH wpan 11/17] net: ieee802154: stop dump llsec devkeys for monitors

2021-02-28 Thread Alexander Aring
This patch stops dumping llsec devkeys for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee80215

[PATCH wpan 12/17] net: ieee802154: forbid monitor for add llsec devkey

2021-02-28 Thread Alexander Aring
This patch forbids to add llsec devkey for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 09/17] net: ieee802154: forbid monitor for add llsec dev

2021-02-28 Thread Alexander Aring
This patch forbids to add llsec dev for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 04/17] net: ieee802154: forbid monitor for set llsec params

2021-02-28 Thread Alexander Aring
This patch forbids to set llsec params for monitor interfaces which we don't support yet. Reported-by: syzbot+8b6719da8a04beeaf...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/ieee8

[PATCH wpan 10/17] net: ieee802154: forbid monitor for del llsec dev

2021-02-28 Thread Alexander Aring
This patch forbids to del llsec dev for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 06/17] net: ieee802154: forbid monitor for add llsec key

2021-02-28 Thread Alexander Aring
This patch forbids to add llsec key for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 02/17] net: ieee802154: fix memory leak when deliver monitor skbs

2021-02-28 Thread Alexander Aring
This patch adds a missing consume_skb() when deliver a skb to upper monitor interfaces of a wpan phy. Reported-by: syzbot+44b651863a17760a8...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/mac802154/rx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/mac802154/rx.c

[PATCH wpan 07/17] net: ieee802154: forbid monitor for del llsec key

2021-02-28 Thread Alexander Aring
This patch forbids to del llsec key for monitor interfaces which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/

[PATCH wpan 08/17] net: ieee802154: stop dump llsec devs for monitors

2021-02-28 Thread Alexander Aring
This patch stops dumping llsec devs for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee802154/nl

[PATCH wpan 00/17] ieee802154: syzbot fixes

2021-02-28 Thread Alexander Aring
interfaces yet. We never supported such handling but I can imagine that we can use security mib for monitor interfaces to decrypt 802.15.4 frames by the Linux kernel and the RAW sockets can see plaintext then. However it's a possibility for an new feature to check in due courses. - Alex Alexander

[PATCH wpan 03/17] net: ieee802154: nl-mac: fix check on panid

2021-02-28 Thread Alexander Aring
This patch fixes a null pointer derefence for panid handle by move the check for the netlink variable directly before accessing them. Reported-by: syzbot+d4c07de0144f6f63b...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl-mac.c | 7 --- 1 file changed, 4

[PATCH wpan 05/17] net: ieee802154: stop dump llsec keys for monitors

2021-02-28 Thread Alexander Aring
This patch stops dumping llsec keys for monitors which we don't support yet. Otherwise we will access llsec mib which isn't initialized for monitors. Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ieee802154/nl

Re: UBSAN: shift-out-of-bounds in nl802154_new_interface

2021-02-23 Thread Alexander Aring
Hi, On Tue, 23 Feb 2021 at 18:48, Jakub Kicinski wrote: > > Alex, there seems to be a few more syzbot reports for nl802154 beyond > what you posted fixes for. Are you looking at these? Yes, I have it on my list. I will try to fix them at the weekend. - Alex

[PATCH wpan 3/4] net: ieee802154: fix nl802154 add llsec key

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ce4e062c2d51977dd...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed

[PATCH wpan 2/4] net: ieee802154: fix nl802154 del llsec dev

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file

[PATCH wpan 1/4] net: ieee802154: fix nl802154 del llsec key

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_KEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+ac5c11d2959a8b3c4...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file changed

[PATCH wpan 4/4] net: ieee802154: fix nl802154 del llsec devkey

2021-02-21 Thread Alexander Aring
This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVKEY is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+368672e0da240db53...@syzkaller.appspotmail.com Signed-off-by: Alexander Aring --- net/ieee802154/nl802154.c | 3 ++- 1 file

[PATCHv2 dlm-next 1/3] net: sock: add sock_set_mark

2020-06-26 Thread Alexander Aring
This patch adds a new socket helper function to set the mark value for a kernel socket. Signed-off-by: Alexander Aring --- include/net/sock.h | 1 + net/core/sock.c| 8 2 files changed, 9 insertions(+) diff --git a/include/net/sock.h b/include/net/sock.h index c53cc42b5ab92

[PATCHv2 dlm-next 0/3] fs: dlm: add support to set skb mark value

2020-06-26 Thread Alexander Aring
nt dlm/next branch - because rebase it's necessary now to add PATCH 1/3. Please netdev maintainers, reply if it's okay to merge this one patch into dlm/next. Due other patches in dlm/next it's as well not possible to merge everything in net-next. Thanks. Alexander A

[PATCHv2 dlm-next 3/3] fs: dlm: set skb mark per peer socket

2020-06-26 Thread Alexander Aring
This patch adds support to set the skb mark value for the DLM tcp and sctp socket per peer. The mark value will be offered as per comm value of configfs. At creation time of the peer socket it will be set as socket option. Signed-off-by: Alexander Aring --- fs/dlm/config.c | 38

[PATCHv2 dlm-next 2/3] fs: dlm: set skb mark for listen socket

2020-06-26 Thread Alexander Aring
This patch adds support to set the skb mark value for the DLM listen tcp and sctp sockets. The mark value will be offered as cluster configuration. At creation time of the listen socket it will be set as socket option. Signed-off-by: Alexander Aring --- fs/dlm/config.c | 6 ++ fs/dlm

[PATCHv2 iproute2-next] lwtunnel: add support for rpl segment routing

2020-05-20 Thread Alexander Aring
This patch adds support for rpl segment routing settings. Example: ip -n ns0 -6 route add 2001::3 encap rpl segs \ fe80::c8fe:beef:cafe:cafe,fe80::c8fe:beef:cafe:beef dev lowpan0 Signed-off-by: Alexander Aring --- changes since v2: - change output to display segments count and nice segment

[PATCH iproute2-next 1/2] uapi: updates to lwtunnel and rpl iptunnel

2020-05-02 Thread Alexander Aring
Update uapi headers. Signed-off-by: Alexander Aring --- include/uapi/linux/rpl.h | 48 +++ include/uapi/linux/rpl_iptunnel.h | 21 ++ 2 files changed, 69 insertions(+) create mode 100644 include/uapi/linux/rpl.h create mode 100644 include/uapi

[PATCH iproute2-next 2/2] lwtunnel: add support for rpl segment routing

2020-05-02 Thread Alexander Aring
This patch adds support for rpl segment routing settings. Example: ip -n ns0 -6 route add 2001::3 encap rpl segs \ fe80::c8fe:beef:cafe:cafe,fe80::c8fe:beef:cafe:beef dev lowpan0 Signed-off-by: Alexander Aring --- ip/iproute.c | 2 +- ip/iproute_lwtunnel.c | 111

ANNOUNCE: rpld an another RPL implementation for Linux

2019-08-29 Thread Alexander Aring
Hi, I had some free time, I wanted to know how RPL [0] works so I did a implementation. It's _very_ basic as it only gives you a "routable" (is that a word?) thing afterwards in a very constrained setup of RPL messages. Took ~1 month to implement it and I reused some great code from radvd [1]. I

Re: [PATCH v2 net-next 3/3] tc-testing: introduce scapyPlugin for basic traffic

2019-07-09 Thread Alexander Aring
On Mon, Jul 08, 2019 at 09:28:09PM -0400, Lucas Bates wrote: > Sorry Alex, I completely forgot about this email. > On Thu, Jul 4, 2019 at 4:29 PM Alexander Aring wrote: > > > > Hi, > > > > On Wed, Jul 03, 2019 at 08:45:02PM -0400, Lucas Bates wrote: > > > Th

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-08 Thread Alexander Aring
Hi, On Mon, Jul 08, 2019 at 12:48:12PM -0400, Lucas Bates wrote: > On Thu, Jul 4, 2019 at 4:21 PM Alexander Aring wrote: > > > why you just use eval() as pattern matching operation and let the user > > define how to declare a matching mechanism instead you introduce another &

Re: [PATCH v2 net-next 3/3] tc-testing: introduce scapyPlugin for basic traffic

2019-07-04 Thread Alexander Aring
Hi, On Wed, Jul 03, 2019 at 08:45:02PM -0400, Lucas Bates wrote: > The scapyPlugin allows for simple traffic generation in tdc to > test various tc features. It was tested with scapy v2.4.2, but > should work with any successive version. > > In order to use the plugin's functionality, scapy must

Re: [PATCH v2 net-next 1/3] tc-testing: Add JSON verification to tdc

2019-07-04 Thread Alexander Aring
Hi, On Wed, Jul 03, 2019 at 08:45:00PM -0400, Lucas Bates wrote: > This patch allows tdc to process JSON output to perform secondary > verification of the command under test. If the verifyCmd generates > JSON, one can provide the 'matchJSON' key to process it > instead of a regex. > > matchJSON h

Re: [RFC iproute2] netns: add mounting state file for each netns

2019-07-01 Thread Alexander Aring
Hi Matteo, On Sun, Jun 30, 2019 at 09:29:33PM +0200, Matteo Croce wrote: > When ip creates a netns, there is a small time interval between the > placeholder file creation in NETNS_RUN_DIR and the bind mount from /proc. > > Add a temporary file named .mounting-$netns which gets deleted after the >

[RFC iproute2 1/1] ip: netns: add mounted state file for each netns

2019-06-26 Thread Alexander Aring
ute2 did a mount bind. Signed-off-by: Alexander Aring --- ip/ipnetns.c | 16 1 file changed, 16 insertions(+) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index a883f210..339a9ffc 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -606,6 +606,13 @@ static int on_netns_del(char *nsname,

[RFC iproute2 0/1] iproute2 netns mount race issue and solution?

2019-06-26 Thread Alexander Aring
w /var/run/netns works? - Alex Alexander Aring (1): ip: netns: add mounted state file for each netns ip/ipnetns.c | 16 1 file changed, 16 insertions(+) -- 2.11.0

Re: [RFC PATCH net-next 1/1] tc-testing: Scapy plugin and JSON verification for tdc

2019-06-24 Thread Alexander Aring
Hi Lucas, On Sun, Jun 09, 2019 at 10:20:32PM -0400, Lucas Bates wrote: > This is a draft version of two new tdc features. > > First, the scapy plugin. This requires the scapy Python module > installed on the system (plugin was tested against v2.4.2). > The intent is to install a given rule (as th

Re: [PATCH net] 6lowpan: Off by one handling ->nexthdr

2019-04-08 Thread Alexander Aring
; we read one element beyond the end of the array so the array needs to > be one element larger. > > Fixes: 92aa7c65d295 ("6lowpan: add generic nhc layer interface") > Signed-off-by: Dan Carpenter Acked-by: Alexander Aring Thanks. - Alex

Re: [PATCH RFC net-next] 6lowpan: use rbtree for IP frag queue

2019-02-17 Thread Alexander Aring
ip -netns foo -6 route add "fb01::1/128" dev lowpan1 > > # then in term1: > ip netns exec foo bash > ./udp_stream -6 > > # in term2: > ./udp_stream -c -6 -H fb02::1 > > # pr_warn_once showed that the code changed by th

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-31 Thread Alexander Aring
Hi, On Wed, Jan 30, 2019 at 02:42:29AM +0100, Andreas Färber wrote: > Hi Alex, > > Am 29.01.19 um 13:57 schrieb Alexander Aring: > > On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: > >> EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) &

Re: [RFC net-next 1/4] net: Reserve protocol identifiers for EnOcean

2019-01-29 Thread Alexander Aring
Hi, On Tue, Jan 29, 2019 at 06:01:27AM +0100, Andreas Färber wrote: > EnOcean wireless technology is based on ASK (ERP1) and FSK (ERP2) modulations > for sub-GHz and on IEEE 802.15.4 for 2.4 GHz. > I am not sure what you try to do here. If I see that correctly you want to add for some special pr

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-28 Thread Alexander Aring
On Fri, Dec 28, 2018 at 05:57:53AM +0100, Andreas Färber wrote: > Hi Alexander and Xue Liu, > > Am 24.12.18 um 16:32 schrieb Alexander Aring: > > On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: > >> On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > >&

Re: [PATCH v5 6/6] net: lorawan: List LORAWAN in menuconfig

2018-12-24 Thread Alexander Aring
Hi, On Tue, Dec 18, 2018 at 02:50:58PM +0100, Xue Liu wrote: > Hello Andreas, > > On Mon, 17 Dec 2018 at 15:19, Andreas Färber wrote: > > > > Hello Xue Liu, > > > > Am 17.12.18 um 09:50 schrieb Xue Liu: > > > I have a question about the architecture of your module. AFAIK LoRaWAN > > > is already

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-24 Thread Alexander Aring
On Sun, Dec 23, 2018 at 07:45:08PM -0500, Willem de Bruijn wrote: ... > > I had some questions when I was digging AF_PACKET code. So the UAPI > > limitation of AF_PACKET has a sockaddr_t of 8 bytes. > > Do you mean the size of sll_addr in struct sockaddr_ll? > yes. > It is possible to pass larg

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Alexander Aring
Hi, ... > I need to admit, I never tried AF_PACKET on a lowpan interface but I > thought about it that it ends in bad things... I would like to forbid > it, because they should use RAW IPv6 sockets where at least we already > have code to check that we have at least a IPv6 header at > skb_packer_

Re: [PATCH net] ieee802154: lowpan_header_create check must check daddr

2018-12-23 Thread Alexander Aring
eceb4 ("ieee802154: change needed headroom/tailroom") > Signed-off-by: Willem de Bruijn > Acked-by: Alexander Aring > --- > > Re: function comment on packet socket address length: that is (now) > verified to be at least dev->addr_len. > I had some questions when

Re: [PATCH net-next] ieee802154: ca8210: fix possible u8 overflow in ca8210_rx_done

2018-12-11 Thread Alexander Aring
Hi Stefan, On Tue, Dec 11, 2018 at 09:26:37AM +0100, Stefan Schmidt wrote: > Hello Dave. > > On 11.12.18 07:01, David Miller wrote: > > From: YueHaibing > > Date: Tue, 11 Dec 2018 11:13:39 +0800 > > > >> gcc warning this: > >> > >> drivers/net/ieee802154/ca8210.c:730:10: warning: > >> comparis

[PATCH net-next] ieee802154: hwsim: using right kind of iteration

2018-08-12 Thread Alexander Aring
quot;ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Alexander Aring --- drivers/net/ieee802154/mac802154_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/mac802154_hwsim.c b/drivers/net/ieee802154/mac802154_hwsim.

[PATCH net-next] ieee802154: hwsim: fix rcu handling

2018-08-07 Thread Alexander Aring
idt Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Alexander Aring --- After I installed finally the newest sparse version I found more what kbuild was pointed out. I hope I did it right, not sure if I really need rcu functionality in these case b

[PATCH net-next] ieee802154: hwsim: fix rcu address annotation

2018-08-07 Thread Alexander Aring
-pointers list head structures and one was missing in edge information which is used by rcu_assign_pointer() to update edge setting information. Cc: Stefan Schmidt Fixes: f25da51fdc38 ("ieee802154: hwsim: add replacement for fakelb") Signed-off-by: Alexander Aring --- Hopefully I did it

Re: [net-next:master 1745/1753] drivers/net/ieee802154/mac802154_hwsim.c:39:14: sparse: incorrect type in initializer (different address spaces)

2018-08-07 Thread Alexander Aring
Hi, On Tue, Aug 07, 2018 at 07:07:20AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git > master > head: de7de576eca204de9a38e2f6dafe6b7c1ddc85c1 > commit: f25da51fdc381ca2863248c7060b3662632f0872 [1745/1753] ieee802154: > hwsim: add

[PATCHv2 wpan] net: 6lowpan: fix reserved space for single frames

2018-07-14 Thread Alexander Aring
: https://bugzilla.kernel.org/show_bug.cgi?id=195059 Reported-by: David Palma Reported-by: Rabi Narayan Sahoo Signed-off-by: Alexander Aring --- changes since v2: skb to nskb, pointed out by stefan net/ieee802154/6lowpan/tx.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions

[PATCH wpan 2/2] net: mac802154: tx: expand tailroom if necessary

2018-07-02 Thread Alexander Aring
This patch is necessary if case of AF_PACKET or other socket interface which I am aware of it and didn't allocated the necessary room. Reported-by: David Palma Reported-by: Rabi Narayan Sahoo Signed-off-by: Alexander Aring --- net/mac802154/tx.c | 15 ++- 1 file change

[PATCH wpan 1/2] net: 6lowpan: fix reserved space for single frames

2018-07-02 Thread Alexander Aring
: https://bugzilla.kernel.org/show_bug.cgi?id=195059 Reported-by: David Palma Reported-by: Rabi Narayan Sahoo Signed-off-by: Alexander Aring --- net/ieee802154/6lowpan/tx.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/net/ieee802154/6lowpan/tx.c b/net

Re: netdevice notifier and device private data

2018-06-12 Thread Alexander Aring
Hi, On Sun, Jun 10, 2018 at 10:09:39PM -0400, Michael Richardson wrote: > > Alexander Aring wrote: > >> It totally seems like broken behaviour. Maybe it's not even > >> intentional. Maybe they are just foobar. > > > They simple don'

Re: netdevice notifier and device private data

2018-06-10 Thread Alexander Aring
Hi, On Sat, Jun 09, 2018 at 03:01:18PM -0400, Michael Richardson wrote: > > Alexander Aring wrote: > > Futhermore user space programs e.g. radvd will do 6lowpan specific > > handling on 6lowpan dev->type, it will not work either on tun > > devices. >

Re: netdevice notifier and device private data

2018-06-09 Thread Alexander Aring
Hi, On Fri, Jun 08, 2018 at 03:37:44PM -0400, Michael Richardson wrote: > > Alexander Aring wrote: > Alex> I already see code outside who changed tun netdevice to the > Alex> ARPHRD_6LOWPAN type and I suppose they running into this > Alex> issue. (Btw: I

Re: netdevice notifier and device private data

2018-06-08 Thread Alexander Aring
Hi Stephen, On Fri, Jun 08, 2018 at 11:14:57AM -0700, Stephen Hemminger wrote: ... > > notifiers are always called with RTNL mutex held > and dev->type should not change unless RTNL is held. thanks for you answer. I am not talking about any race between notifiers vs dev->type change. I am talki

netdevice notifier and device private data

2018-06-08 Thread Alexander Aring
Hey netdev community, I am trying to solve some issue which Eric Dumazet points to me by commit ca0edb131bdf ("ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()"). The issue is that dev->type can be changed during runtime. We don't have any problems with the netdevice notifier

Re: [PATCH net] net: ipv6: ip6_output: alloc skb with tailroom

2018-06-07 Thread Alexander Aring
Hi, On Wed, Jun 06, 2018 at 04:26:19PM -0400, Willem de Bruijn wrote: > On Wed, Jun 6, 2018 at 2:11 PM, David Miller wrote: > > From: Alexander Aring > > Date: Wed, 6 Jun 2018 14:09:20 -0400 > > > >> okay, then you want to have this patch for net-next? As an opt

Re: [PATCH net] net: ipv6: ip6_output: alloc skb with tailroom

2018-06-06 Thread Alexander Aring
Hi, On Wed, Jun 06, 2018 at 01:53:39PM -0400, David Miller wrote: > From: Alexander Aring > Date: Tue, 5 Jun 2018 18:04:04 -0400 > > > This patch adds care about tailroom length for allocate a skb from ipv6 > > level stack. In case of 6lowpan we had the proble

[PATCH net] net: ipv6: ip6_output: alloc skb with tailroom

2018-06-05 Thread Alexander Aring
tailroom specified inside the netdev structure. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=195059 Reported-by: David Palma Reported-by: Rabi Narayan Sahoo Signed-off-by: Alexander Aring --- Hi, nasty bug, I suppose this is the correct fix to my last question for what dev

ndo_star_xmit() - resevered head and tailroom

2018-06-01 Thread Alexander Aring
Hi netdev community, I am again on bug fixing in 6lowpan branch and thought that my needed_headroom and needed_tailroom of net_device are available inside my ndo_start_xmit() callback. In case of a UDP socket, it was not the case. I send a fix now to use skb_expand_copy() to make sure this space

Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag

2018-05-28 Thread Alexander Aring
Hi, On Mon, May 28, 2018 at 12:12:42PM +0300, Tariq Toukan wrote: > > > On 01/04/2018 6:25 AM, David Miller wrote: > > From: Eric Dumazet > > Date: Sat, 31 Mar 2018 12:58:41 -0700 > > > > > IP defrag processing is one of the remaining problematic layer in linux. > > > > > > It uses static has

Re: Kernel panic on kernel-3.10.0-693.21.1.el7 in ndisc.h

2018-05-14 Thread Alexander Aring
Hi, On Mon, May 14, 2018 at 11:40:02AM -0400, Alexander Aring wrote: ... > I cannot help you with such a dinosaurs kernel. Please try it with the > latest one and check if the problem still exists. > and please don't write me private e-mails, always use the mailingst. Thanks. - Alex

Re: Kernel panic on kernel-3.10.0-693.21.1.el7 in ndisc.h

2018-05-14 Thread Alexander Aring
Hi, On Sun, May 13, 2018 at 02:35:07PM +0300, Roman Makhov wrote: > Hello, > > We have a problem with Kernel panic after upgrade from CentOS 7.3 > (kernel-3.10.0-514.el7) to CentOS 7.4 (kernel-3.10.0-693.21.1.el7). > It occurs when we have the incoming traffic from other nodes and we > are perfor

  1   2   3   4   5   >