Hi Jiri
On 01.10.2020 14:49, Jiri Pirko wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
Thu, Oct 01, 2020 at 12:30:18PM CEST, henrik.bjoernl...@microchip.com wrote:
This is the definition of the CFM switchdev interface.
The interface consist
Hi,
On 08.09.2020 11:04, Henrik Bjoernlund - M31679 wrote:
On Sun, 2020-09-06 at 20:21 +0200, Horatiu Vultur wrote:
The 09/04/2020 15:44, Stephen Hemminger wrote:
> On Fri, 4 Sep 2020 09:15:20 + Henrik Bjoernlund
> wrote:
Hi, I also had the same initial thought - this really doesn't seem
On 17.07.2020 12:08, Vladimir Oltean wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
On Fri, Jul 17, 2020 at 09:34:11AM +0200, Joergen Andreasen wrote:
The 07/16/2020 17:45, Vladimir Oltean wrote:
> Hi Vladimir,
>
> On Thu, Jul 16, 2020 at 10:3
On 09.06.2020 15:55, Vladimir Oltean wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
Hi Allan,
On Mon, 8 Jun 2020 at 16:56, Allan W. Nielsen
wrote:
On 03.06.2020 13:04, Vladimir Oltean wrote:
>On Tue, 2 Jun 2020 at 11:38, Allan W. Niel
On 03.06.2020 13:04, Vladimir Oltean wrote:
On Tue, 2 Jun 2020 at 11:38, Allan W. Nielsen
wrote:
Hi Xiaoliang,
Happy to see that you are moving in the directions of multi chain - this
seems ilke a much better fit to me.
On 02.06.2020 13:18, Xiaoliang Yang wrote:
>There are three hardw
Hi Xiaoliang,
Happy to see that you are moving in the directions of multi chain - this
seems ilke a much better fit to me.
On 02.06.2020 13:18, Xiaoliang Yang wrote:
There are three hardware TCAMs for ocelot chips: IS1, IS2 and ES0. Each
one supports different actions. The hardware flow order
On 22.05.2020 16:13, Vladimir Oltean wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
On Fri, 22 May 2020 at 15:38, Nikolay Aleksandrov
wrote:
On 22/05/2020 00:10, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> In cases where the bridge i
Hi Vladimir,
I'm very happy to see that you started working on this. Let me know if
you need help to update the Ocelot/Felix driver to support this.
/Allan
On 22.05.2020 00:10, Vladimir Oltean wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
F
On 07.05.2020 11:23, Xiaoliang Yang wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
Hi Allan,
Hi Vladimir,
On 06.05.2020 13:53, Vladimir Oltean wrote:
[snip]
>At the moment, the driver does not support more than 1 action. We might
>need to
Hi Vladimir,
On 06.05.2020 13:53, Vladimir Oltean wrote:
On Wed, 6 May 2020 at 12:45, Allan W. Nielsen
wrote:
Hi Xiaoliang,
On 06.05.2020 15:48, Xiaoliang Yang wrote:
>VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and
>TCP/UDP ports keys, and do Qos and VLAN
Hi Xiaoliang,
On 06.05.2020 15:48, Xiaoliang Yang wrote:
VCAP IS1 is a VCAP module which can filter MAC, IP, VLAN, protocol, and
TCP/UDP ports keys, and do Qos and VLAN retag actions.
This patch added VCAP IS1 support in ocelot ace driver, which can supports
vlan modify action of tc filter.
Usag
Hi,
This is fixing a bug introduced in b596229448dd2
Acked-by: Allan W. Nielsen
/Allan
The 08/20/2019 12:20, Yangbo Lu wrote:
> External E-Mail
>
>
> The trap action should be copying the frame to CPU and
> dropping it for forwarding, but current setting was just
> co
The 08/14/2019 04:56, Y.b. Lu wrote:
> > -Original Message-
> > From: Allan W . Nielsen
> > Sent: Tuesday, August 13, 2019 2:25 PM
> > To: Y.b. Lu
> > Cc: netdev@vger.kernel.org; David S . Miller ;
> > Alexandre Belloni ; Microchip Linux Driver
&g
Hi Y.b. and Andrew,
The 08/14/2019 04:28, Y.b. Lu wrote:
> > > I'd like to trap all IEEE 1588 PTP Ethernet frames to CPU through etype
> > 0x88f7.
> >
> > Is this the correct way to handle PTP for this switch? For other switches we
> > don't need such traps. The switch itself identifies PTP frame
> > -Original Message-
> > From: Allan W. Nielsen
> > Sent: Tuesday, August 13, 2019 2:16 PM
> > To: Y.b. Lu
> > Cc: netdev@vger.kernel.org; David S . Miller ;
> > Alexandre Belloni ; Microchip Linux Driver
> > Support
> > Subject
The 08/13/2019 08:16, Allan W . Nielsen wrote:
> The 08/13/2019 10:52, Yangbo Lu wrote:
> > The trap action should be copying the frame to CPU and
> > dropping it for forwarding, but current setting was just
> > copying frame to CPU.
> >
> > Signed-off-by: Yang
The 08/13/2019 10:52, Yangbo Lu wrote:
> All the PTP messages over Ethernet have etype 0x88f7 on them.
> Use etype as the key to trap PTP messages.
>
> Signed-off-by: Yangbo Lu
> ---
> Changes for v2:
> - Added this patch.
> ---
> drivers/net/ethernet/mscc/ocelot.c | 28 +++
The 08/13/2019 10:52, Yangbo Lu wrote:
> The trap action should be copying the frame to CPU and
> dropping it for forwarding, but current setting was just
> copying frame to CPU.
>
> Signed-off-by: Yangbo Lu
> ---
> Changes for v2:
> - None.
> ---
> drivers/net/ethernet/mscc/ocelot_ace.c |
The 08/13/2019 02:12, Y.b. Lu wrote:
> > -Original Message-
> > From: Allan W. Nielsen
> > Sent: Monday, August 12, 2019 8:32 PM
> > To: Y.b. Lu
> > Cc: netdev@vger.kernel.org; David S . Miller ;
> > Alexandre Belloni ; Microchip Linux Driver
>
The 08/12/2019 18:48, Yangbo Lu wrote:
> The ingress ports setting of rule should support covering all ports.
> This patch is to use u16 ingress_port for ingress port mask setting
> for ace rule. One bit corresponds one port.
That is how the HW is working, and it would be nice if we could operate o
The 08/12/2019 18:48, Yangbo Lu wrote:
> The trap action should be copying the frame to CPU and
> dropping it for forwarding, but current setting was just
> copying frame to CPU.
Are there any actions which do a "copy-to-cpu" and still forward the frame in
HW?
> Signed-off-by: Yangbo Lu
> ---
>
Hi Linus,
I'm Allan, working for Microchip, who acquired Microsemi, who acquired Vitesse.
Alexandre pointed me to your comments on the VSC7384 switch done by Vitesse ~15
years ago. BTW: the chip is not being sold any more, and is unlikely to turn up
in new products.
I managed to find the complet
> /*
> * Microsemi Ocelot Switch driver
> *
> - * License: Dual MIT/GPL
> * Copyright (c) 2017 Microsemi Corporation
> */
>
> --
> 2.17.0
>
Reviewed-by: Allan W. Nielsen
On 28/11/16 21:21, Andrew Lunn wrote:
> On Mon, Nov 28, 2016 at 08:23:06PM +0100, Allan W. Nielsen wrote:
> > On 28/11/16 15:14, Andrew Lunn wrote:
> > > On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote:
> > > > From: Raju Lakkaraju
> > >
On 28/11/16 09:56, Florian Fainelli wrote:
> On 11/28/2016 05:25 AM, Allan W. Nielsen wrote:
> > From: Raju Lakkaraju
> >
> > Add loopback in ethtool tunables to access PHY drivers.
> >
> > Ethtool Help: ethtool -h for PHY tunables
> > ethtool --set-p
Hi Andrew and Florian,
On 28/11/16 15:14, Andrew Lunn wrote:
> On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote:
> > From: Raju Lakkaraju
> >
> > 3 types of PHY loopback are supported.
> > i.e. Near-End Loopback, Far-End Loopback and External Loopback
RJ45 Loopback cable created by conncting pin 1 to pin 3 and connecting pin
2 to pin 6.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool-copy.h | 23 ++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/ethtool-copy.h b/ethtool-copy.h
From: Raju Lakkaraju
Adding validation support for the ETHTOOL_PHY_LOOPBACK. Functional
implementation needs to be done in the individual PHY drivers.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
net/core/ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a
Mbps speed.
RJ45 Loopback cable created by conncting pin 1 to pin 3 and connecting pin
2 to pin 6.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
include/uapi/linux/ethtool.h | 8
1 file changed, 8 insertions(+)
diff --git a/include/uapi/linux/ethtool.h b/include
-off-by: Allan W. Nielsen
---
ethtool.8.in | 49 +
ethtool.c| 139 +++
2 files changed, 188 insertions(+)
diff --git a/ethtool.8.in b/ethtool.8.in
index 9631847..83e6b97 100644
--- a/ethtool.8.in
+++ b/ethtool.8.in
Hi All,
This patch implements for support for PHY Loopback using PHY-Tunables.
The patch will add the following options:
ethtool --set-phy-tunable DEVNAME Set PHY tunable
[ loopback off|near|far|extn ]
ethtool --get-phy-tunable DEVNAME Get PHY tunable
From: Raju Lakkaraju
Implements the loopback functionality for MSCC PHYs.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
drivers/net/phy/mscc.c | 118 +
1 file changed, 118 insertions(+)
diff --git a/drivers/net/phy/mscc.c b
Hi All,
This series add support for PHY Loopback tunable, and implement it
for MSCC phys.
To configure loopback, the ethtool_tunable structure is used. 'id' must be
set to 'ETHTOOL_PHY_LOOPBACK' and 'data' specifies the loopback type:
ETHTOOL_PHY_LOOPBACK_* (DISABLE, NEAR, FAR or EXTN).
Here is
Hi All,
This series add support for PHY Loopback tunable, and implement it
for MSCC phys.
To configure loopback, the ethtool_tunable structure is used. 'id' must be
set to 'ETHTOOL_PHY_LOOPBACK' and 'data' specifies the loopback type:
ETHTOOL_PHY_LOOPBACK_* (DISABLE, NEAR, FAR or EXTN).
Here is
xes: 968ad9da7e0e ("ethtool: Implements
> ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE")
> Fixes: 310d9ad57ae0 ("net: phy: Add downshift get/set support in Microsemi
> PHYs driver")
> Signed-off-by: Florian Fainelli
Reviewed-by: Allan W. Nielsen
older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Reviewed-by: Andrew Lunn
Signed-off-by: David S. Miller
Signed-off-by: Allan W. Nielsen
---
ethtool-copy.h | 21
[ downshift ]
Ethtool ex:
ethtool --set-phy-tunable eth0 downshift on
ethtool --set-phy-tunable eth0 downshift off
ethtool --set-phy-tunable eth0 downshift on count 2
ethtool --get-phy-tunable eth0 downshift
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Acked-by
end_ioctl() returns an error, print the error message and then
still print th value of count".
v4:
- Fixing spelling in the example included in the commit message
- Improve the description in the man-page
v5:
- re-sync ethtool.h from the net-next tree.
Allan W. Nielsen (1):
ethtool-copy.h
Hi,
On 22/11/16 12:07, Florian Fainelli wrote:
> On 11/22/2016 12:02 PM, Andrew Lunn wrote:
> >> +static int bcm7xxx_28nm_set_tunable(struct phy_device *phydev,
> >> +struct ethtool_tunable *tuna,
> >> +const void *data)
> >> +{
> >>
[ downshift ]
Ethtool ex:
ethtool --set-phy-tunable eth0 downshift on
ethtool --set-phy-tunable eth0 downshift off
ethtool --set-phy-tunable eth0 downshift on count 2
ethtool --get-phy-tunable eth0 downshift
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Acked-by
in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Signed-off-by: Allan W. Nielsen
Acked-by: Florian Fainelli
---
ethtool-copy.h | 18 +-
1 file
(downshift feature is applied in the net-next tree - d3c19c0a72)
This series adds support for downshift (using phy-tunables).
Downshifting can either be turned on/off, or it can be configured to a
specifc count.
"count" is optional.
Change set:
v1:
- Initial version of set/get phy tunable with
From: Raju Lakkaraju
Defines a generic API to get/set phy tunables. The API is using the
existing ethtool_tunable/tunable_type_id types which is already being used
for mac level tunables.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
include/uapi
[ downshift ]
Ethtool ex:
ethtool --set-phy-tuanble eth0 downshift on
ethtool --set-phy-tuanble eth0 downshift off
ethtool --set-phy-tuanble eth0 downshift on count 2
ethtool --get-phy-tunable eth0 downshift
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool
From: Raju Lakkaraju
Adding validation support for the ETHTOOL_PHY_DOWNSHIFT. Functional
implementation needs to be done in the individual PHY drivers.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
net/core/ethtool.c | 6 ++
1 file changed, 6
From: Raju Lakkaraju
Adding get_tunable/set_tunable function pointer to the phy_driver
structure, and uses these function pointers to implement the
ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
From: Raju Lakkaraju
Implements the phy tunable function pointers and implement downshift
functionality for MSCC PHYs.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
drivers/net/phy/mscc.c | 100 +
1
of
failed attempts at 1000BASE-T. This feature is useful in setting up in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Reviewed-by: Andrew Lunn
---
include/uapi/linux/ethtool.h | 5
in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool-copy.h | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/ethtool
Hi All,
(This is a re-post of the v3 patch set with a new cover letter - I was not
aware that the cover letters was used a commit comments in merge commits).
This series add support for PHY tunables, and uses this facility to
configure downshifting. The downshifting mechanism is implemented for M
Hi All,
(This is a re-post of the v3 patch set with a new cover letter - I was not
aware that the cover letters was used as commit comments in merge commits).
This patch implements for set/get downshifting.
Downshifting can either be turned on/off, or it can be configured to a
specifc count.
"c
From: Raju Lakkaraju
Adding get_tunable/set_tunable function pointer to the phy_driver
structure, and uses these function pointers to implement the
ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
[ downshift ]
Ethtool ex:
ethtool --set-phy-tuanble eth0 downshift on
ethtool --set-phy-tuanble eth0 downshift off
ethtool --set-phy-tuanble eth0 downshift on count 2
ethtool --get-phy-tunable eth0 downshift
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool
in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool-copy.h | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/ethtool
rom c235004654ee0212b6cf6ca7af14eb6ef8a04dee Mon Sep 17 00:00:00 2001
> From: "Allan W. Nielsen"
> Date: Mon, 14 Nov 2016 10:22:03 +0100
> Subject: [PATCH ethtool v2 0/2] Adding downshift support to ethtool
>
> This is a follow-up on the patch series posted at Fri, 4 Nov 2016 11:27:31
> +0100
>
From: Raju Lakkaraju
Implements the phy tunable function pointers and implement downshift
functionality for MSCC PHYs.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
drivers/net/phy/mscc.c | 100 +
1
of
failed attempts at 1000BASE-T. This feature is useful in setting up in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
include/uapi/linux/ethtool.h | 5 -
1 file changed, 4
From: Raju Lakkaraju
Defines a generic API to get/set phy tunables. The API is using the
existing ethtool_tunable/tunable_type_id types which is already being used
for mac level tunables.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
include/uapi
es changed, 217 insertions(+), 1 deletion(-)
> From 5ca4dac36f45e097b93ae4cfdf35a8922e5d975e Mon Sep 17 00:00:00 2001
> prom: "Allan W. Nielsen"
> Date: Mon, 14 Nov 2016 10:04:07 +0100
> Subject: [PATCH net-next v2 0/5] Adding PHY-Tunables and downshift support
>
> Hi,
From: Raju Lakkaraju
Adding validation support for the ETHTOOL_PHY_DOWNSHIFT. Functional
implementation needs to be done in the individual PHY drivers.
Signed-off-by: Raju Lakkaraju
Reviewed-by: Andrew Lunn
Signed-off-by: Allan W. Nielsen
---
net/core/ethtool.c | 6 ++
1 file changed, 6
From: Raju Lakkaraju
Adding validation support for the ETHTOOL_PHY_DOWNSHIFT. Functional
implementation needs to be done in the individual PHY drivers.
Signed-off-by: Raju Lakkaraju
---
net/core/ethtool.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/net/core/ethtool.c b/net/core/e
From: Raju Lakkaraju
This covers kernel changes upto:
commit f5a4732f85613b3fb43f8bc33a017e3db3b3605a
Author: Raju Lakkaraju
Date: Wed Nov 9 16:33:09 2016 +0530
ethtool: (uapi) Add ETHTOOL_PHY_GTUNABLE and ETHTOOL_PHY_STUNABLE
For operation in cabling environments that are incompati
From: Raju Lakkaraju
Adding get_tunable/set_tunable function pointer to the phy_driver
structure, and uses these function pointers to implement the
ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls.
Signed-off-by: Raju Lakkaraju
---
include/linux/phy.h | 7 +
net/core/ethtool.c | 87 +
| 18 +++-
net/core/ethtool.c | 93
4 files changed, 217 insertions(+), 1 deletion(-)
--
2.7.3
Old cover letter:
> From 1a318266822f5d74c58b5219ebbdf5a6a5f567dc Mon Sep 17 00:00:00 2001
> From: "Allan W. Nielsen"
> Date: Fri, 4 Nov 2016 1
From: Raju Lakkaraju
Defines a generic API to get/set phy tunables. The API is using the
existing ethtool_tunable/tunable_type_id types which is already being used
for mac level tunables.
Signed-off-by: Raju Lakkaraju
---
include/uapi/linux/ethtool.h | 15 ++-
1 file changed, 14 in
+-
ethtool.8.in | 39
ethtool.c | 144 +
3 files changed, 200 insertions(+), 1 deletion(-)
Old cover letter:
> From 5d926ca56f13e283aaa98e820d4720305be4da8f Mon Sep 17 00:00:00 2001
> From: "Allan W. Niels
From: Raju Lakkaraju
Implements the phy tunable function pointers and implement downshift
functionality for MSCC PHYs.
Signed-off-by: Raju Lakkaraju
---
drivers/net/phy/mscc.c | 100 +
1 file changed, 100 insertions(+)
diff --git a/drivers/net/p
From: Raju Lakkaraju
For operation in cabling environments that are incompatible with
1000BAST-T, PHY device may provide an automatic link speed downshift
operation. When enabled, the device automatically changes its 1000BAST-T
auto-negotiation to the next slower speed after a configured number o
From: Raju Lakkaraju
Add ethtool get and set tunable to access PHY drivers.
Ethtool Help: ethtool -h for PHY tunables
ethtool --set-phy-tunable DEVNAME Set PHY tunable
[ downshift on|off [count N] ]
ethtool --get-phy-tunable DEVNAME Get PHY tunable
Hi Ye Xiaolong,
On 08/11/16 10:01, Ye Xiaolong wrote:
> Could you tell us what troubles you have met when trying the "lkp qemu"
> tool, it would be better if you could paste some log so we can help to
> improve it.
Sure:
anielsen@lx-anielsen ~/work/opensource-phy/lkp-tests (master) $ bin/lkp qem
Hi,
I'm quite surprised too.
I asked Raju to see if he can re-produce, and then try again with the
microsemi_phy disabled and see it that makes a difference.
If Raju gets stuck on this, then I will try to help our during the after-noon.
/Allan
On 07/11/16 10:31, Andrew Lunn wrote:
> EXTERNAL E
On 04/11/16 13:27, Andrew Lunn wrote:
> > + } else if (count) {
> > + /* Downshift count is either 2,3,4 or 5 */
> > + count = (((count - 2) << DOWNSHIFT_CNTL_POS) | DOWNSHIFT_EN);
>
> Ah, now i see why + 2. But this means it never does what you ask it to
> do. It would
On 04/11/16 13:13, Andrew Lunn wrote:
> On Fri, Nov 04, 2016 at 11:35:39AM +0100, Allan W. Nielsen wrote:
> > From: Raju Lakkaraju
> >
> > Adding get_tunable/set_tunable function pointer to the phy_driver
> > structure, and uses these function pointers to implement t
On 04/11/16 12:59, Andrew Lunn wrote:
> > +++ b/ethtool.8.in
> > @@ -340,6 +340,14 @@ ethtool \- query or control network driver and
> > hardware settings
> > .B2 tx-lpi on off
> > .BN tx-timer
> > .BN advertise
> > +.HP
> > +.B ethtool \-\-set\-phy\-tunable
> > +.I devname
> > +.B3 downshift o
Hi,
On 04/11/16 13:03, Andrew Lunn wrote:
> On Fri, Nov 04, 2016 at 11:35:38AM +0100, Allan W. Nielsen wrote:
> > From: Raju Lakkaraju
> >
> > Defines a generic API to get/set phy tunables. The API is using the
> > existing ethtool_tunable/tunable_type_id types
From: Raju Lakkaraju
Adding validation support for the ETHTOOL_PHY_DOWNSHIFT. Functional
implementation needs to be done in the individual PHY drivers.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
net/core/ethtool.c | 5 +
1 file changed, 5 insertions(+)
diff --git
From: Raju Lakkaraju
Implements the phy tunable function pointers and implement downshift
functionality for MSCC PHYs.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
drivers/net/phy/mscc.c | 102 +
1 file changed, 102
older cable installations
that
include only pairs A and B, and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
Signed-off-by: Allan W. Nielsen
---
ethtool-copy.h | 34 ++
1 file changed, 22 insertions(+), 12 deletions
Hi All,
This patch implements for set/get downshifting.
Downshifting can either be turned on/off, or it can be configured to a
specifc count.
If no "count" are provided, then it is up to the individual PHY driver to
configure a default count.
Best regards
Allan and Raju
Allan W.
[ downshift ]
Ethtool ex:
ethtool --set-phy-tuanble eth0 downshift on
ethtool --set-phy-tuanble eth0 downshift off
ethtool --set-phy-tuanble eth0 downshift 2
ethtool --get-phy-tunable eth0 downshift
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
ethtool.8.in | 27
From: Raju Lakkaraju
Adding get_tunable/set_tunable function pointer to the phy_driver
structure, and uses these function pointers to implement the
ETHTOOL_PHY_GTUNABLE/ETHTOOL_PHY_STUNABLE ioctls.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
include/linux/phy.h | 7
of
failed attempts at 1000BAST-T. This feature is useful in setting up in
networks using older cable installations that include only pairs A and B,
and not pairs C and D.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
include/uapi/linux/ethtool.h | 4
1 file changed, 4
Hi All,
This series add support for PHY tunables, and uses this facility to configure
downshifting. The downshifting mechanism is implemented for MSCC phys.
This series tries to address the comments provided back in mid October when this
feature was posted along with fast-link-failure. Fast-link-
From: Raju Lakkaraju
Defines a generic API to get/set phy tunables. The API is using the
existing ethtool_tunable/tunable_type_id types which is already being used
for mac level tunables.
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
include/uapi/linux/ethtool.h | 7
From: Raju Lakkaraju
Signed-off-by: Raju Lakkaraju
Signed-off-by: Allan W. Nielsen
---
drivers/net/phy/Kconfig | 2 +-
drivers/net/phy/mscc.c | 42 ++
2 files changed, 43 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/Kconfig b/drivers/net
Hi All,
This patch adds support for VSC 8530/40 which is 10/100 Mbps variants of VSC
8531/41.
Please review.
Best regards
Allan and Raju
Raju Lakkaraju (1):
net: phy: Add support for Microsemi VSC 8530/40 Fast Ethernet PHY
drivers/net/phy/Kconfig | 2 +-
drivers/net/phy/mscc.c | 42 +
> Author: Allan W. Nielsen
> AuthorDate: Wed Oct 12 15:47:51 2016 +0200
> Commit: David S. Miller
> CommitDate: Fri Oct 14 10:06:13 2016 -0400
>
> net: phy: Cleanup the Edge-Rate feature in Microsemi PHYs.
>
> Edge-Rate cleanup include the following:
>
explicitly documented values for "vsc8531,vddmac" and
"vsc8531,edge-slowdown" are accepted by the device driver.
- Deleted include/dt-bindings/net/mscc-phy-vsc8531.h as it was not needed.
- Read/validate devicetree settings in probe instead of init
Signed-off-by: Allan W
ere is a re-post of version 11 (which should apply cleanly on-top of
net-next)
v10 was reviewed by Florian and Andrew:
On 12/10/16 02:14, Florian Fainelli wrote:
> On 10/10/2016 07:13 AM, Allan W. Nielsen wrote:
> > Edge-Rate cleanup include the following:
> > ...
> Reviewed-by
Hi,
I can see that the "Add Wake-on-LAN driver for Microsemi PHYs" (0a55c12f97)
patch has been applied to net-next, and that it is causing the Edge-Rate patch
to conflict.
I have therefore rebased v10 of the patch to fit on top of net-next.
/Allan
--
2.7.3
explicitly documented values for "vsc8531,vddmac" and
"vsc8531,edge-slowdown" are accepted by the device driver.
- Deleted include/dt-bindings/net/mscc-phy-vsc8531.h as it was not needed.
- Read/validate devicetree settings in probe instead of init
Signed-off-by: Allan W
Hi All,
Yet another iteration on the edge rate.
Included in this iteration:
- vdd and slowdown is removed from private structure
- rate_magic added to private structure
- devicetree settings is read and validated in probe instead of init
- unused reference in device-tree doc removed
Please revie
explicitly documented values for "vsc8531,vddmac" and
"vsc8531,edge-slowdown" are accepted by the device driver.
- Deleted include/dt-bindings/net/mscc-phy-vsc8531.h as it was not needed.
- Read/validate devicetree settings in probe instead of init
Signed-off-by: Allan W
Hi,
On 07/10/16 22:22, Andrew Lunn wrote:
> Overall, this is much better. I just have a few nitpicks.
It is good to hear that we are getting closer ;-)
> dt-bindings/net/mscc-phy-vsc8531.h is removed by this patch. It would
> be good to also remove the reference.
My bad.
> You don't need edge_sl
sc8531,edge-slowdown" are accepted by the device driver.
- Deleting include/dt-bindings/net/mscc-phy-vsc8531.h as it was not needed.
- Initialize to default values when CONFIG_OF_MDIO is not defined
- Using ARRAY_SIZE when iterating through an array.
Please review.
Best regards
Allan W. Nielsen
explicitly documented values for "vsc8531,vddmac" and
"vsc8531,edge-slowdown" are accepted by the device driver.
- Deleting include/dt-bindings/net/mscc-phy-vsc8531.h as it was not needed.
Signed-off-by: Allan W. Nielsen
Signed-off-by: Raju Lakkaraju
---
.../devicetree/bin
help from the HW team.
I will forward this to the HW team - but it will properly take a few days to get
a decent answer.
Best regards
Allan W. Nielsen
97 matches
Mail list logo
