Re: [PATCH] net: make tc-police action MTU behavior match documentation

From: Cong Wang > If this is just an iproute2 issue, please fix it there rather in kernel. I'm fine with fixing this as a documentation issue (fix being change man page, MTU "Defaults to unlimited" to "Defaults to 2047"). Note however this does mean that tc-police

Re: [PATCH] net: make tc-police action MTU behavior match documentation

es without tc you can set peakrate with no mtu, and the action will still default to a reasonable mtu rather than falling over). Andrew Collins

[PATCH] net: make tc-police action MTU behavior match documentation

ult MTU when peakrate is specified. Longer term act_police should likely segment GRO packets like sch_tbf does, but I see no clear way to accomplish this within a tc action. Signed-off-by: Andrew Collins <acoll...@cradlepoint.com> --- net/sched/act_police.c | 2 +- 1 file changed, 1 insert

Re: fq_codel and skb->hash

n my particular case I don't care, as I control the HW and can make it give me a hash. :) Thanks, Andrew Collins

[PATCH net-next] fq_codel: Avoid regenerating skb flow hash unless necessary

if necessary. Signed-off-by: Andrew Collins <acoll...@cradlepoint.com> --- net/sched/sch_fq_codel.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/sched/sch_fq_codel.c b/net/sched/sch_fq_codel.c index a5ea0e9..2f50e4c 100644 --- a/net/sched/sch_fq_codel.c +++

fq_codel and skb->hash

(if available) problematic? Is there a better way to manage flow separation in routed+encapsulated traffic? Thanks, Andrew Collins

[PATCH net] Add netdev all_adj_list refcnt propagation to fix panic

propagation so things are handled properly. Matthias Schiffer reported a similar crash in batman-adv: https://github.com/freifunk-gluon/gluon/issues/680 https://www.open-mesh.org/issues/247 which this patch also seems to resolve. Signed-off-by: Andrew Collins <acoll...@cradlepoint.com> --- ne

Re: [PATCH] Add netdev all_adj_list refcnt propagation to fix panic

On 09/28/2016 12:06 PM, David Ahern wrote: Andrew Collins posted this patch as RFC in March: http://patchwork.ozlabs.org/patch/603101/ It has apparently fallen through the cracks and never applied. It solves a refcnt problem (thanks Nik for pointing out this patch) I have been running

Re: [RFC] Add netdev all_adj_list refcnt propagation to fix panic

From: Andrew Collins <acoll...@cradlepoint.com> Date: Tue, 29 Mar 2016 11:25:03 -0600 This is an RFC patch to fix a relatively easily reproducible kernel panic related to the all_adj_list handling for netdevs in recent kernels. This is more to generate discussion than anything else. I

[RFC] Add netdev all_adj_list refcnt propagation to fix panic

This is an RFC patch to fix a relatively easily reproducible kernel panic related to the all_adj_list handling for netdevs in recent kernels. This is more to generate discussion than anything else. I don't particularly like this approach, I'm hoping someone has a better idea. The following

Re: RESEND: Easily reproducible kernel panic due to netdev all_adj_list refcnt handling

her broken, and the patch is just working around a design that needs some rework. Thanks, Andrew Collins commit df318544e282c6ab5bdc4595658fc1cf8739d091 Author: Andrew Collins <acoll...@cradlepoint.com> Date: Fri Mar 25 16:04:59 2016 -0600 This fixes a relatively easily reproducible kern

RESEND: Easily reproducible kernel panic due to netdev all_adj_list refcnt handling

ne else encountered this before? Any ideas on a cleaner solution? Thanks, Andrew Collins

Kernel panic due to netdev all_adj_list refcnt handling

ne else encountered this before? Any ideas on a cleaner solution? Thanks, Andrew Collins