Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

2016-10-22 Thread Andrey Vagin
Hi Cong, On Thu, Oct 20, 2016 at 10:25 PM, Andrey Vagin <ava...@openvz.org> wrote: > On Thu, Oct 20, 2016 at 8:10 PM, Cong Wang <xiyou.wangc...@gmail.com> wrote: >> On Thu, Oct 20, 2016 at 7:46 PM, Andrei Vagin <ava...@openvz.org> wrote: >>> No one can

Re: [PATCH] net: skip genenerating uevents for network namespaces that are exiting

2016-10-20 Thread Andrey Vagin
On Thu, Oct 20, 2016 at 8:10 PM, Cong Wang wrote: > On Thu, Oct 20, 2016 at 7:46 PM, Andrei Vagin wrote: >> No one can see these events, because a network namespace can not be >> destroyed, if it has sockets. >> > > Are you sure? kobject_uevent_env()

Re: [PATCH] net: limit a number of namespaces which can be cleaned up concurrently

2016-10-19 Thread Andrey Vagin
; >>> > On Thu, Oct 13, 2016 at 10:49:38AM -0500, Eric W. Biederman wrote: >>> >> Andrei Vagin <ava...@openvz.org> writes: >>> >> >>> >> > From: Andrey Vagin <ava...@openvz.org> >>> >> > >>> >&g

[PATCH] ip route: timeout for routes has to be set in seconds

2016-06-28 Thread Andrey Vagin
From: Andrew Vagin Currently a timeout is multiplied by HZ in user-space and then it multiplied by HZ in kernel-space. $ ./ip/ip r add 2002::0/64 dev veth1 expires 10 $ ./ip/ip -6 r 2002::/64 dev veth1 metric 1024 linkdown expires 996sec pref medium Cc: Xin Long

[PATCH] tcp: add an ability to dump and restore window parameters

2016-06-27 Thread Andrey Vagin
bove. Cc: Pavel Emelyanov <xe...@parallels.com> Cc: "David S. Miller" <da...@davemloft.net> Cc: Alexey Kuznetsov <kuz...@ms2.inr.ac.ru> Cc: James Morris <jmor...@namei.org> Cc: Hideaki YOSHIFUJI <yoshf...@linux-ipv6.org> Cc: Patrick McHardy <ka..

Re: [CRIU] TCP_REPAIR MSS issue

2016-06-16 Thread Andrey Vagin
On Thu, Jun 16, 2016 at 07:51:22AM +, Eggert, Lars wrote: > Hi, > > On 2016-06-14, at 23:21, Andrey Vagin <ava...@virtuozzo.com> wrote: > > On my host, I see that dst is set in tcp_v4_connect() -> sk_setup_caps() > > sorry, are you saying that you don't see

Re: [CRIU] TCP_REPAIR MSS issue

2016-06-14 Thread Andrey Vagin
On Tue, Jun 14, 2016 at 07:37:12PM +, Eggert, Lars wrote: > Hi, > > On 2016-06-14, at 19:15, Andrey Vagin <ava...@virtuozzo.com> wrote: > > Recently we found that we have to restore more parameters for tcp > > sockets. > > https://patchwork.kern

Re: [CRIU] TCP_REPAIR MSS issue

2016-06-14 Thread Andrey Vagin
Hi, Recently we found that we have to restore more parameters for tcp sockets. https://patchwork.kernel.org/patch/9144995/ As for your problem, criu saves and restores mss_clamp. Could you check that it works for your case? on dump: static int tcp_stream_get_options(int sk, struct

[PATCH 2/3] netlink: add an ability to restore messages in a receive queue

2016-06-13 Thread Andrey Vagin
This patch adds an repair mode for netlink sockets. sendmsg queues messages into a receive queue if a socket is in the repair mode. Signed-off-by: Andrey Vagin <ava...@openvz.org> --- include/uapi/linux/netlink.h | 1 + net/netlink/af_netlink.c

[PATCH 1/3] netlink: allow to set peeking offset for sockets

2016-06-13 Thread Andrey Vagin
uses sk_peek_off has to be sure that nobody calls recvmsg for a socket except him. Signed-off-by: Andrey Vagin <ava...@openvz.org> --- net/netlink/af_netlink.c | 25 - 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/net/netlink/af_netlink.c b/net/n

[PATCH net-next 0/3] [RFC] netlink: prepare to dump and restore data from a receive queue

2016-06-13 Thread Andrey Vagin
.com> Cc: Daniel Borkmann <dan...@iogearbox.net> Cc: Florian Westphal <f...@strlen.de> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: David Herrmann <dh.herrm...@gmail.com> Cc: Christophe Ricard <christophe.ric...@gmail.com> Andrey Vagin (3): netlink: allow t

[PATCH 3/3] netlink/diag: report flags for netlink sockets

2016-06-13 Thread Andrey Vagin
, a receive queue contains only a part of data, and as soon as we read them, the callback will generate a new portion. In this case, we can't be sure that all data will not exceed a buffer limit on restore. Now we are going to dump and restore sockets without running callbacks. Signed-off-by: Andrey Vagin

[PATCH] netlink.7: describe netlink socket options

2016-06-10 Thread Andrey Vagin
Cc: Kir Kolyshkin <k...@openvz.org> Cc: Michael Kerrisk <mtk.manpa...@gmail.com> Cc: Herbert Xu <herb...@gondor.apana.org.au> Cc: Patrick McHardy <ka...@trash.net> Cc: Christophe Ricard <christophe.ric...@gmail.com> Cc: Nicolas Dichtel <nicolas.dich...@6wind.com&

[PATCH] tcp: extend window to fit all restored unacked data in a send queue

2016-05-31 Thread Andrey Vagin
shf...@linux-ipv6.org> Cc: Patrick McHardy <ka...@trash.net> Signed-off-by: Andrey Vagin <ava...@openvz.org> --- net/ipv4/tcp_output.c | 4 1 file changed, 4 insertions(+) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index 79a03b8..b36f968 100644 --- a/net/ipv4/tcp_o

Re: [PATCH] net/unix: fix logic about sk_peek_offset

2015-10-03 Thread Andrey Vagin
2015-10-02 15:17 GMT+03:00 Aaron Conole <acon...@bytheb.org>: > Andrey Vagin <ava...@openvz.org> writes: > >> 2015-10-02 0:05 GMT+03:00 Andrey Vagin <ava...@gmail.com>: >>> From: Andrey Vagin <ava...@openvz.org> >>> >>

Re: [PATCH] net/unix: fix logic about sk_peek_offset

2015-10-02 Thread Andrey Vagin
2015-10-02 0:05 GMT+03:00 Andrey Vagin <ava...@gmail.com>: > From: Andrey Vagin <ava...@openvz.org> > > Now send with MSG_PEEK can return data from multiple SKBs. > > Unfortunately we take into account the peek offset for each skb, > that is wrong. We need to a

[PATCH] net/unix: fix logic about sk_peek_offset

2015-10-01 Thread Andrey Vagin
From: Andrey Vagin <ava...@openvz.org> Now send with MSG_PEEK can return data from multiple SKBs. Unfortunately we take into account the peek offset for each skb, that is wrong. We need to apply the peek offset only once. In addition, the peek offset should be used only if MSG_PEEK is se

Re: [net] skbuff: Fix skb checksum flag on skb pull

2015-09-29 Thread Andrey Vagin
On Tue, Sep 29, 2015 at 03:27:03AM +0300, Pravin Shelar wrote: > On Mon, Sep 28, 2015 at 2:46 AM, Andrew Vagin wrote: > > Hi, > > > > With this patch, I can't connect two local tcp ipv6 sockets. > > > > [root@fc22-vm criu]# strace -e network python ipv6.py > > socket(PF_INET6,

[PATCH iproute2] route: filter routes by family if it's specified

2015-09-23 Thread Andrey Vagin
From: Andrew Vagin Currently when we specify AF_INET6 when it is disabled, we will get all routes. For example, we can boot kernel with ipv6.disable=1 and try to get ipv6 routes: $ ip -6 route show default via 192.168.122.1 dev eth0 proto static metric 100 192.168.122.0/24