Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-28 Thread Anil Veerabhadrappa
On Wed, 2007-11-28 at 14:06 -0600, Mike Christie wrote: Anil Veerabhadrappa wrote: Which ones were they exactly? I think JamesB wanted only common transport values in the transport class. If it is driver specific then it should go on the host or target or device

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-27 Thread Anil Veerabhadrappa
Which ones were they exactly? I think JamesB wanted only common transport values in the transport class. If it is driver specific then it should go on the host or target or device with the scsi_host_template attrs. It's a chicken egg issue to put port mapper sysfs entry in scsi

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-11-21 Thread Anil Veerabhadrappa
The sysfs bits related to the hba should be use one of the scsi sysfs facilities or if they are related to iscsi bits and are generic then through the iscsi hba bnx2i needs 2 sysfs entries - 1. QP size info - this is used to size per connection shared data structures to issue

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-08 Thread Anil Veerabhadrappa
On Sat, 2007-09-08 at 07:49 -0700, Michael Chan wrote: Christoph Hellwig wrote: Most of it should just go away, and the other bits shouldn't change over the lifetime of the driver except for additions. So there really isn't any point in auto-generating it. Yes, I agree with

Re: [PATCH v3 2/2][BNX2]: Add iSCSI support to BNX2 devices.

2007-09-05 Thread Anil Veerabhadrappa
On Wed, 2007-09-05 at 13:34 -0500, Mike Christie wrote: Michael Chan wrote: +* This file defines HSI constants for the iSCSI flows +*/ + +/* iSCSI request op codes */ +#define ISCSI_OPCODE_NOP_OUT (0 | 0x40) +#define ISCSI_OPCODE_SCSI_CMD (1)