Re: [PATCH RFC] phylib: fix forced mode misbehaviour for aneg off case

2008-02-22 Thread Anton Vorontsov
On Fri, Feb 22, 2008 at 11:40:04AM -0600, Andy Fleming wrote: > > On Feb 22, 2008, at 09:55, Anton Vorontsov wrote: > > >When user disabled autonegotiation via ethtool, and no link is > >detected, > >phylib will place phy into forcing mode, and then will start cal

[PATCH RFC] phylib: fix forced mode misbehaviour for aneg off case

2008-02-22 Thread Anton Vorontsov
g disabled, phylib will not try other link setups. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- This is of course post-2.6.25 material and highly RFC, as it changes current behaviour. Please review carefully. Thanks. drivers/net/phy/phy.c | 19 --- include

[PATCH] [NET] phy/broadcom: add support for BCM5481 PHY

2008-02-03 Thread Anton Vorontsov
rst opportunity, and will name that register and its bits correctly. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/phy/broadcom.c | 54 1 files changed, 54 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/broadcom

Re: [2.6 patch] net/phy/fixed.c: fix a use-after-free

2008-02-03 Thread Anton Vorontsov
truct fixed_phy *fp, *tmp; > > mdiobus_unregister(&fmb->mii_bus); > platform_device_unregister(pdev); > > - list_for_each_entry(fp, &fmb->phys, node) { > + list_for_each_entry_safe(fp, tmp, &fmb->phys, node) { > list_del(&fp->node);

[PATCH] [POWERPC][NET][SERIAL] UCCs: replace device-id with cell-index (was: Re: [PATCH] [POWERPC] get rid of `model = "UCC"' in the ucc nodes)

2008-02-01 Thread Anton Vorontsov
On Fri, Feb 01, 2008 at 09:32:38AM -0600, Kumar Gala wrote: > On Feb 1, 2008, at 9:01 AM, Anton Vorontsov wrote: > > >It isn't used anywhere, so remove it. If we'll ever need something > >like this, we'll use compatible property instead. > > > >Sig

[PATCH for 2.6.25 2/2] [NET] ucc_geth: add support for netpoll

2008-02-01 Thread Anton Vorontsov
This patch adds netpoll support for the QE UCC Gigabit Ethernet driver. Tested using netconsole and KGDBoE. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Just resending this. drivers/net/ucc_geth.c | 20 1 files changed, 20 insertions(+), 0 deletions(-)

[PATCH for 2.6.25 1/2] [NET] ucc_geth: fix module removal

2008-02-01 Thread Anton Vorontsov
hX up'; - add unregister_netdev(); - reorder geth_remove() steps. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- Hi Li, You kinda promised that these two patches would hit 2.6.25... ;-) I've rebased the patches so they apply cleanly on the current tree. Thanks, drivers/

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
On Thu, Jan 24, 2008 at 10:33:47AM -0600, Timur Tabi wrote: > Anton Vorontsov wrote: > > >Are you saying that TDM is sharing same pins with the other QE device, > >and we can choose to use/not use some device depending on which driver > >is loaded? > > No. I

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
On Thu, Jan 24, 2008 at 09:55:31AM -0600, Timur Tabi wrote: > Anton Vorontsov wrote: > > >Can we not introduce new pio-maps in the device trees? There > >were debates regarding this, and if I understood everything > >correctly, pio-maps considered as a bad tast

Re: [PATCH UCC TDM 1/3 Updated] Platform changes for UCC TDM driver for MPC8323eRDB. Also includes related QE changes and dts entries.

2008-01-24 Thread Anton Vorontsov
Can we not introduce new pio-maps in the device trees? There were debates regarding this, and if I understood everything correctly, pio-maps considered as a bad taste. Better do bunch of par_io_config_pin() in the board file. Better yet fixup the firmware (u-boot) to set up dedicated pins correctly. T

[PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure (was: Re: fixed phy support (warning related to FIXED_MII_100_FDX))

2008-01-21 Thread Anton Vorontsov
d PHY rework to go through powerpc tree, would you please Ack this patch in addition? I hope cpmac maintainer will fix remaining issues as time goes by. Thanks! - - - - From: Anton Vorontsov <[EMAIL PROTECTED]> Subject: [PATCH] [NET] cpmac: convert to new Fixed PHY infrastructure This patch

[PATCH 2/4] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2008-01-08 Thread Anton Vorontsov
device_type property is bogus, thus use proper compatible. Also change compatible property to "fsl,ucc-mdio". Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc832x_mds.dts

[PATCH v2 2/4] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2007-12-20 Thread Anton Vorontsov
device_type property is bogus, thus use proper compatible. Also change compatible property to "fsl,ucc-mdio". Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc832x_mds.dts

[PATCH/.24] [NET] fs_enet: check for phydev existence in the ethtool handlers

2007-12-20 Thread Anton Vorontsov
[c000d4c0] ret_from_syscall+0x0/0x3c Instruction dump: 8163 800b0030 2f80 419e0010 7c0803a6 4e800021 7c691b78 80010014 7d234b78 38210010 7c0803a6 4e800020 <8003014c> 7c6b1b78 3860 90040004 Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/fs_enet

[PATCH 2/4] [POWERPC][NET] ucc_geth_mii and users: get rid of device_type

2007-12-19 Thread Anton Vorontsov
device_type property is bogus, better use proper compatible property. Also change compatible to "fsl,ucc-mdio". Per http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048388.html Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc832x_mds.dts

[PATCH] [NET][POWERPC] ucc_geth: really fix section mismatch

2007-12-17 Thread Anton Vorontsov
ually fixing section mismatch by removing __exit from the header file. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/ucc_geth_mii.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ucc_geth_mii.h b/drivers/net/ucc_geth_mii.h index d83

Re: [PATCH][RESEND] PHY: Add the phy_device_release device method.

2007-12-04 Thread Anton Vorontsov
or necessary to export the > phy_device_free symbol, though. Makes sense, I think. Here is the newer patch, the only difference is removed EXPORT_SYMBOL(). Because of trivial change, I dared to keep Andy's Acked-by intact. - - - - From: Anton Vorontsov <[EMAIL PROTECTED]> Subject: [

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHYlayer functionality

2007-12-02 Thread Anton Vorontsov
ut the PHY lib supports it. > Even if fixed PHYs doesn't support it directly I think the OF interface > should have it. > > - fixed-link : where a is emulated phy id - choose any, > but unique to the all specified fixed-links, b is duplex - 0 half, > 1 full

Re: [PATCH 1/3] [NET] phy/fixed.c: rework to not duplicate PHY layer functionality

2007-12-01 Thread Anton Vorontsov
- - - And remove fixed_phy_add() from the fs_enet. This should work nicely and also should be ideologically correct. ;-) > How is this supposed to work for modules or for the > PPC_CPM_NEW_BINDING mode where the device tree is no longer scanned > during fs_soc initialization but durin

Re: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property

2007-11-27 Thread Anton Vorontsov
On Tue, Nov 27, 2007 at 02:17:11PM +0100, Joakim Tjernlund wrote: > > On Tue, 2007-11-27 at 14:39 +0300, Anton Vorontsov wrote: > > On Mon, Nov 26, 2007 at 04:04:08PM +0100, Joakim Tjernlund wrote: > > > On Mon, 2007-11-26 at 17:29 +0300, Vitaly Bordug wrote: > > > &

Re: [PATCH 2/3] [POWERPC] fsl_soc: add support for gianfar for fixed-link property

2007-11-27 Thread Anton Vorontsov
f-by: Vitaly Bordug <[EMAIL PROTECTED]> > > Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > > > --- > > > > Documentation/powerpc/booting-without-of.txt |3 + > > arch/powerpc/sysdev/fsl_soc.c| 56 > > ++

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-09 Thread Anton Vorontsov
s them up to go through netdev or the > other way around; either way is fine with me). I'm hoping they're > trivial enough to go in 2.6.24. All five patches are Tested-by: Anton Vorontsov <[EMAIL PROTECTED]> Let's hope they'll hit 2.6.24. Thanks, -- Anton

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-09 Thread Anton Vorontsov
c MII () read wrong value : mii_id 1,mii_reg 1, base e0103120 read wrong value : mii_id 1,mii_reg 1, base e0103120 read wrong value : mii_id 1,mii_reg 5, base e0103120 FSL UEC1: Full Duplex switching to rgmii 100 FSL UEC1: Speed 100BT FSL UEC1: Link is up FSL UEC0, FSL UEC1 - - - - And

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-08 Thread Anton Vorontsov
On Thu, Nov 08, 2007 at 12:15:08PM -0600, Kim Phillips wrote: > On Thu, 8 Nov 2007 17:16:11 +0300 > Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > On Mon, Nov 05, 2007 at 12:15:30PM -0600, Kim Phillips wrote: > > > Hello all, > > > > > > the fo

Re: [PATCH 0/5] fixups for mpc8360 rev. 2.1 erratum #2 (RGMII Timing)

2007-11-08 Thread Anton Vorontsov
ing > with Rev Pilot MDS for proper RGMII operation: > > IMMR_BASE + 0x14A8[4:5] = 11 (clk delay for UCC 2) > IMMR_BASE + 0x14A8[18:19] = 11 (clk delay for UCC 1) > IMMR_BASE + 0x14AC[20:27] = 10101010 (data delay for both UCC's) > > The Phy (Marvell 88e) should be con

Re: [PATCH] ucc_geth: add support for netpoll

2007-11-01 Thread Anton Vorontsov
On Thu, Nov 01, 2007 at 10:33:24AM +0800, Li Yang-r58472 wrote: > > -Original Message- > > From: Anton Vorontsov [mailto:[EMAIL PROTECTED] > > Sent: Thursday, November 01, 2007 5:59 AM > > To: Li Yang-r58472 > > Cc: netdev@vger.kernel.org; [EMAIL PRO

Re: [PATCH] ucc_geth: add support for netpoll

2007-10-31 Thread Anton Vorontsov
On Mon, Oct 29, 2007 at 03:17:44PM +0300, Anton Vorontsov wrote: [...] > > Oops. The original patch happened to hit the Junk mail box. :( > > That one as well? http://lkml.org/lkml/2007/10/11/128 > > > I think > > the patch is good to merge after the cosmetic chang

Re: [PATCH] ucc_geth: add support for netpoll

2007-10-29 Thread Anton Vorontsov
h > > really cosmetic changes. But if Jeff would directly apply > > modfied patch, I'll send it. ;-) > > Oops. The original patch happened to hit the Junk mail box. :( That one as well? http://lkml.org/lkml/2007/10/11/128 > I think > the patch is good to merge after

Re: [PATCH] ucc_geth: add support for netpoll

2007-10-27 Thread Anton Vorontsov
On Sat, Oct 27, 2007 at 05:09:51PM +0400, Sergei Shtylyov wrote: > Hello. > > Anton Vorontsov wrote: > > > This patch adds netpoll support for the QE UCC Gigabit Ethernet > > driver. The approach is very similar to the gianfar driver. > > It's rath

[PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-17 Thread Anton Vorontsov
Erroneous #ifdef introduced by 293c8513398657f6263fcdb03c87f2760cf61be4 causing NAPI-less ethernet malfunctioning. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- if (...) #if ...; #endif good candidate for checkpatc

[PATCH respin] phy: implement release function

2007-10-11 Thread Anton Vorontsov
ng rid of this badness. Also small hidden bug fixed, hope none other introduced. ;-) Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Acked-by: Andy Fleming <[EMAIL PROTECTED]> --- drivers/net/phy/mdio_bus.c |9 + drivers/net/phy/phy_device.c | 13 + include

[PATCH] ucc_geth: add support for netpoll

2007-10-11 Thread Anton Vorontsov
This patch adds netpoll support for the QE UCC Gigabit Ethernet driver. The approach is very similar to the gianfar driver. Tested using netconsole. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 19 +++ 1 files changed, 19 insertions

[PATCH respin] ucc_geth: fix module removal

2007-10-11 Thread Anton Vorontsov
hX up'; - add unregister_netdev(); - reorder geth_remove() steps. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index

[PATCH] ucc_geth: fix compilation

2007-09-13 Thread Anton Vorontsov
Currently qe_bd_t is used in the macro call -- dma_unmap_single, which is a no-op on PPC32, thus error is hidden today. Starting with 2.6.24, macro will be replaced by the empty static function, and erroneous use of qe_bd_t will trigger compilation error. Signed-off-by: Anton Vorontsov <[EM

[PATCH] [POWERPC] ucc_geth: fix module removal

2007-09-12 Thread Anton Vorontsov
hX up'; - add unregister_netdev(); - reorder geth_remove() steps. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/ucc_geth.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index

[PATCH] phy: implement release function

2007-09-12 Thread Anton Vorontsov
ng rid of this badness. Also small hidden bug fixed, hope none other introduced. ;-) Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> --- drivers/net/phy/mdio_bus.c |9 + drivers/net/phy/phy_device.c | 13 + include/linux/phy.h |1 + 3 files change