[PATCH net-next] cxgb4: Add HMA support

2018-03-13 Thread Arjun Vynipadath
memory information via debugfs. Signed-off-by: Arjun Vynipadath Signed-off-by: Santosh Rastapur Signed-off-by: Michael Werner Signed-off-by: Ganesh GR --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 13 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 10 +- drivers/net/ethernet

[REGRESSION, bisect] pci: cxgb4 probe fails after commit 104daa71b3961434 ("PCI: Determine actual VPD size on first access")

2018-01-23 Thread Arjun Vynipadath
Sending on behalf of "Casey Leedom " Way back on April 11, 2016 we reported a regression in Linux kernel 4.6-rc2 brought on by kernel.org commit 104daa71b396. This commit calculates the size of a PCI Device's VPD area by parsing the VPD Structure at offset 0x000, and restricts accesses to the V

[PATCH net-next] cxgb4: free mac_hlist properly

2018-11-09 Thread Arjun Vynipadath
The locally maintained list for tracking hash mac table was not freed during driver remove. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/ethernet/chelsio

[PATCH net-next] cxgb4vf: fix memleak in mac_hlist initialization

2018-11-09 Thread Arjun Vynipadath
that, move list init to the condition that performs initial one time adapter setup. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next] cxgb4vf: free mac_hlist properly

2018-11-09 Thread Arjun Vynipadath
The locally maintained list for tracking hash mac table was not freed during driver remove. Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet

[PATCH net-next] cxgb4: Remove SGE_HOST_PAGE_SIZE dependency on page size

2018-11-15 Thread Arjun Vynipadath
e SGE Host Page Size in order to properly calculate BAR2 Offsets. Signed-off-by: Casey Leedom Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxg

[PATCH net-next] cxgb4/cxgb4vf: Fix mac_hlist initialization and free

2018-11-19 Thread Arjun Vynipadath
Null pointer dereference seen when cxgb4vf driver is unloaded without bringing up any interfaces, moving mac_hlist initialization to driver probe and free the mac_hlist in remove to fix this. Fixes 'commit 24357e06ba51 ("cxgb4vf: fix memleak in mac_hlist initialization")'

[PATCH v2 net-next] cxgb4/cxgb4vf: Fix mac_hlist initialization and free

2018-11-19 Thread Arjun Vynipadath
Null pointer dereference seen when cxgb4vf driver is unloaded without bringing up any interfaces, moving mac_hlist initialization to driver probe and free the mac_hlist in remove to fix the issue. Fixes: 24357e06ba51 ("cxgb4vf: fix memleak in mac_hlist initialization") Signed-off

[PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up

2018-09-18 Thread Arjun Vynipadath
Forcing link up of virtual interfaces even when physical link is down causes packet drops and ping failures during bonding failover. Hence adding a ethtool private flag to toggle force_link_up whenever required. Signed-off-by: Arjun Vynipadath Signed-off-by: Casey Leedom Signed-off-by: Ganesh

Re: [PATCH net-next] cxgb4vf: Add ethtool private flags for changing force_link_up

2018-09-21 Thread Arjun Vynipadath
On Tuesday, September 09/18/18, 2018 at 11:39:14 -0700, Jakub Kicinski wrote: > On Tue, 18 Sep 2018 18:37:23 +0530, Arjun Vynipadath wrote: > > Forcing link up of virtual interfaces even when physical link is down > > causes packet drops and ping failures during bonding failover. H

[PATCH net-next] cxgb4/cxgb4vf: Fix up netdev->hw_features

2019-02-28 Thread Arjun Vynipadath
GRO is done by cxgb4/cxgb4vf. Hence set NETIF_F_GRO flag for both cxgb4/cxgb4vf. Cleaned up VLAN netdev features in cxgb4vf. Also fixed NETIF_F_HIGHDMA being set unconditionally for vlan netdev features. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet

[PATCH net-next 4/4] cxgb4: Enable outer UDP checksum offload for T6

2019-02-28 Thread Arjun Vynipadath
T6 adapters support outer UDP checksum offload for encapsulated packets, hence enabling netdev feature flag NETIF_F_GSO_UDP_TUNNEL_CSUM. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 ++ 1 file changed, 2 insertions

[PATCH net-next] cxgb4vf: Enter debugging mode if FW is inaccessible

2019-02-28 Thread Arjun Vynipadath
If we are not able to reach firmware, enter debugging mode that will help us to get adapter logs. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h | 1 + .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 45

[PATCH net-next 2/2] cxgb4vf: Revert force link up behaviour

2019-02-28 Thread Arjun Vynipadath
Reverting force link up changes since this behaviour can be achieved using VF link state feature. Reverts: commit 0913667ab3ad ("cxgb4vf: Forcefully link up virtual interfaces") Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chels

[PATCH net-next 0/2]cxgb4/cxgb4vf: VF link state support

2019-02-28 Thread Arjun Vynipadath
This series of patches adds support for ndo_set_vf_link_state in cxgb4 driver. Patch 1 implements ndo_set_vf_link_state Patch 2 reverts the existing force_link_up behaviour for cxgb4vf driver. Arjun Vynipadath (2): cxgb4: Add VF Link state support cxgb4vf: Revert force link up behaviour

[PATCH net-next 1/2] cxgb4: Add VF Link state support

2019-02-28 Thread Arjun Vynipadath
Use ndo_set_vf_link_state to control the link states associated with the virtual interfaces. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 57

[PATCH net-next] cxgb4: Prefix adapter flags with CXGB4

2019-03-01 Thread Arjun Vynipadath
Some of these macros were conflicting with global namespace, hence prefixing them with CXGB4. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4/cudbg_lib.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 24 ++--- drivers

[PATCH net-next] cxgb4vf: Prefix adapter flags with CXGB4VF

2019-03-01 Thread Arjun Vynipadath
Some of these macros were conflicting with global namespace, hence prefixing them with CXGB4VF. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h | 12 ++-- .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 68

[PATCH net-next v2 1/2] cxgb4: Add VF Link state support

2019-03-01 Thread Arjun Vynipadath
Use ndo_set_vf_link_state to control the link states associated with the virtual interfaces. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- v2: - Using reverse christmas tree for variable declaration - Renamed FW_LINK* macros for vf link states to make it more clean

[PATCH net-next v2 0/2]cxgb4/cxgb4vf: VF link state support

2019-03-01 Thread Arjun Vynipadath
This series of patches adds support for ndo_set_vf_link_state in cxgb4 driver. Patch 1 implements ndo_set_vf_link_state Patch 2 reverts the existing force_link_up behaviour for cxgb4vf driver. v2: - Using reverse christmas tree for variable declaration in Patch 1 - Patch 2 has no change Arjun

[PATCH net-next v2 2/2] cxgb4vf: Revert force link up behaviour

2019-03-01 Thread Arjun Vynipadath
Reverting force link up changes since this behaviour can be achieved using VF link state feature. Reverts: commit 0913667ab3ad ("cxgb4vf: Forcefully link up virtual interfaces") Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- v2: - No changes --- drivers/ne

[PATCH net-next] cxgb4vf: Call netif_carrier_off properly in pci_probe

2019-03-01 Thread Arjun Vynipadath
netif_carrier_off() should be called only after register_netdev(). Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf

Re: [PATCH net-next] cxgb4: Prefix adapter flags with CXGB4

2019-03-04 Thread Arjun Vynipadath
On Friday, March 03/01/19, 2019 at 23:17:47 -0800, David Miller wrote: > From: Arjun Vynipadath > Date: Fri, 1 Mar 2019 15:40:24 +0530 > > > - FULL_INIT_DONE = (1 << 0), > ... > > + CXGB4_FULL_INIT_DONE= (1 << 0), > > Looks like y

[PATCH net-next v2] cxgb4/chtls: Prefix adapter flags with CXGB4

2019-03-04 Thread Arjun Vynipadath
Some of these macros were conflicting with global namespace, hence prefixing them with CXGB4. Signed-off-by: Arjun Vynipadath Signed-off-by: Vishal Kulkarni --- v2: - Fixed build issues in chtls driver --- drivers/crypto/chelsio/chtls/chtls_cm.c| 2 +- drivers/net/ethernet

[net-next] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()

2019-01-29 Thread Arjun Vynipadath
r list for hash entries is shared across mac_{sync/unsync}(), added an extra parameter if_mac to track the address added thorugh {t4/t4vf}_change_mac() Signed-off-by: Arjun Vynipadath --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.

[PATCH net-next] cxgb4vf: Update port information in cxgb4vf_open()

2019-01-29 Thread Arjun Vynipadath
It's possible that the basic port information could have changed since we first read it. Signed-off-by: Arjun Vynipadath --- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main

[PATCH net-next] MAINTAINERS: update cxgb4 and cxgb3 maintainer

2019-01-29 Thread Arjun Vynipadath
Vishal Kulkarni will be the new maintainer for Chelsio cxgb3/cxgb4 drivers. Signed-off-by: Arjun Vynipadath --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index a0245fd..071f1f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[PATCH net-next v2] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()

2019-02-01 Thread Arjun Vynipadath
r list for hash entries is shared across mac_{sync/unsync}(), added an extra parameter if_mac to track the address added thorugh {t4/t4vf}_change_mac() Signed-off-by: Arjun Vynipadath --- v2: - Remove inline keyword for functions from {cxgb4/cxgb4vf}_main.c - Use GFP_KERNEL instead of GFP_ATOMIC

[PATCH net-next v3] cxgb4/cxgb4vf: Program hash region for {t4/t4vf}_change_mac()

2019-02-01 Thread Arjun Vynipadath
r list for hash entries is shared across mac_{sync/unsync}(), added an extra parameter if_mac to track the address added thorugh {t4/t4vf}_change_mac() Signed-off-by: Arjun Vynipadath --- v3: - Missed to remove inline from one more function cxgb4vf_set_addr_hash(). v2: - Remove inline keyword for

[PATCH net] cxgb4: Added missing break in ndo_udp_tunnel_{add/del}

2018-07-25 Thread Arjun Vynipadath
Break statements were missing for Geneve case in ndo_udp_tunnel_{add/del}, thereby raw mac matchall entries were not getting added. Fixes: c746fc0e8b2d("cxgb4: add geneve offload support for T6") Signed-off-by: Arjun Vynipadath Signed-off-by: Ganesh Goudar --- drivers/net/ethern