Re: [net-next][PATCH 11/13] RDS: IB: add Fastreg MR (FRMR) detection support

2016-02-22 Thread Bart Van Assche
On 02/21/16 19:36, David Miller wrote: From: Santosh Shilimkar Date: Sat, 20 Feb 2016 03:30:02 -0800 @@ -54,6 +55,8 @@ module_param(rds_ib_mr_8k_pool_size, int, 0444); MODULE_PARM_DESC(rds_ib_mr_8k_pool_size, " Max number of 8K mr per HCA"); module_param(rds_ib_retry_count, int, 0444); M

Re: [PATCH] Revert "netpoll: Fix extra refcount release in netpoll_cleanup()"

2016-04-06 Thread Bart Van Assche
On 04/05/16 13:58, Bjorn Helgaas wrote: This reverts commit 543e3a8da5a4c453e992d5351ef405d5e32f27d7. Direct callers of __netpoll_setup() depend on it to set np->dev, so we can't simply move that assignment up to netpoll_stup(). Reported-by: Bart Van Assche Signed-off-by: Bjorn

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-07 Thread Bart Van Assche
On 04/07/16 07:38, Christoph Hellwig wrote: This is also very interesting for storage targets, which face the same issue. SCST has a mode where it caches some fully constructed SGLs, which is probably very similar to what NICs want to do. I think a cached allocator for page sets + the scatterl

Re: [Lsf] [Lsf-pc] [LSF/MM TOPIC] Generic page-pool recycle facility?

2016-04-11 Thread Bart Van Assche
On 04/11/2016 11:37 AM, Jesper Dangaard Brouer wrote: On Mon, 11 Apr 2016 14:46:25 -0300 Thadeu Lima de Souza Cascardo wrote: So, Jesper, please take into consideration that this pool design would rather be per device. Otherwise, we allow some device to write into another's device/driver memor

Re: BUG/ spinlock lockup, 2.6.24

2008-02-15 Thread Bart Van Assche
ioned > before. Did you already run memtest ? You can run memtest by booting from the Knoppix CD-ROM or DVD. Most Linux distributions also have included memtest on their bootable distribution CD's/DVD's. Bart Van Assche. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

2017-12-18 Thread Bart Van Assche
On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > Today when we run checkers we get so many warnings it is too hard to > > > make any sense of it. > > > > Here is a list of the checkpatch messages for drivers/infiniban

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

2018-01-02 Thread Bart Van Assche
On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > - Original Message - > > > - Original Message - > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining t

Re: [PATCH 00/18] prevent bounds-check bypass via speculative execution

2018-01-08 Thread Bart Van Assche
On 01/05/18 22:30, Dan Williams wrote: On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote: Please expand this. It is not clear what the static analysis is looking for. Have a clear description of what is being fixed is crucial for allowing any of these changes. For the details given in

Re: [PATCH net-next 5/5] net/smc: return booleans instead of integers

2018-01-26 Thread Bart Van Assche
On Fri, 2018-01-26 at 09:28 +0100, Ursula Braun wrote: > From: Gustavo A. R. Silva > > Return statements in functions returning bool should use > true/false instead of 1/0. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > Signed-off-by: Ursula B

Re: linux-next: Signed-off-by missing for commits in the bpf-next tree

2018-12-12 Thread Bart Van Assche
On Wed, 2018-12-12 at 15:39 -0800, Alexei Starovoitov wrote: > On Thu, Dec 13, 2018 at 09:48:20AM +1100, Stephen Rothwell wrote: > > Hi Alexei, > > > > On Wed, 12 Dec 2018 12:53:11 -0800 Alexei Starovoitov > > wrote: > > > > > > On Thu, Dec 13, 2018 at 07:32:45AM +1100, Stephen Rothwell wrote:

[PATCH] Revert "net: do not allow changing SO_REUSEADDR/SO_REUSEPORT on bound sockets"

2018-06-12 Thread Bart Van Assche
iej Żenczykowski Cc: Eric Dumazet Signed-off-by: Bart Van Assche --- net/core/sock.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/net/core/sock.c b/net/core/sock.c index f333d75ef1a9..bcc41829a16d 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-07 Thread Bart Van Assche
On 12/07/16 18:29, Michael S. Tsirkin wrote: > By now, linux is mostly endian-clean. Enabling endian-ness > checks for everyone produces about 200 new sparse warnings for me - > less than 10% over the 2000 sparse warnings already there. > > Not a big deal, OTOH enabling this helps people notice > t

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-08 Thread Bart Van Assche
On 12/07/16 21:54, Michael S. Tsirkin wrote: > On Thu, Dec 08, 2016 at 05:21:47AM +0000, Bart Van Assche wrote: >> Additionally, there are notable exceptions to the rule that most drivers >> are endian-clean, e.g. drivers/scsi/qla2xxx. I would appreciate it if it >> would rem

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

2016-12-09 Thread Bart Van Assche
On 12/08/16 22:40, Madhani, Himanshu wrote: > We’ll take a look and send patches to resolve these warnings. Thanks! Bart.

Re: [PATCH net-next 00/10] net/smc: updates 2017-09-20

2017-09-20 Thread Bart Van Assche
On Wed, 2017-09-20 at 13:58 +0200, Ursula Braun wrote: > here is a collection of small smc-patches built for net-next improving > the smc code in different areas. Hello Ursula, Can you provide us an update for the timeline of the plan to transition from PF_SMC to PF_INET/PF_INET6 + SOCK_STREAM? S

[PATCH 8/9] IB: Convert ib_dma_*_coherent() argument type from u64 into dma_addr_t

2017-01-10 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- include/rdma/ib_verbs.h | 11 +++ net/rds/ib.h| 6 +++--- 2 files changed, 6

[PATCH 9/9] treewide: Inline ib_dma_map_*() functions

2017-01-10 Thread Bart Van Assche
um:]_]\)ib_dma_\([^(]*\)(\&\([^,]\+\),/\1dma_\2(\3.dma_device,/g' \ -e 's/\([^[:alnum:]_]\)ib_dma_\([^(]*\)(\([^,]\+\),/\1dma_\2(\3->dma_device,/g' \ -e 's/ib_sg_dma_\(len\|address\)(\([^,]\+\), /sg_dma_\1(/g' Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hell

[PATCH 7/9] RDS: IB: Remove an unused structure member

2017-01-10 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Cc: Santosh Shilimkar Cc: Santosh Shilimkar Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- net/rds/ib_mr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h index

[PATCH v2 11/26] RDS: IB: Remove an unused structure member

2017-01-12 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Acked-by: Santosh Shilimkar Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- net/rds/ib_mr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h index 1c754f4acbe5

[PATCH v2 12/26] IB: Convert ib_dma_*_coherent() argument type from u64 into dma_addr_t

2017-01-12 Thread Bart Van Assche
This patch does not change any functionality. Signed-off-by: Bart Van Assche Reviewed-by: Leon Romanovsky Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- include/rdma/ib_verbs.h | 11 +++ net/rds/ib.h| 6

Re: [patch] net/mlx4: && vs & typo

2017-02-28 Thread Bart Van Assche
On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote: > Bitwise & was obviously intended here. > > Fixes: 745d8ae4622c ("net/mlx4: Spoofcheck and zero MAC can't coexist") > Signed-off-by: Dan Carpenter > --- > Applies to net.git. > > diff --git a/include/linux/mlx4/driver.h b/include/linux/mlx

Re: [patch] net/mlx4: && vs & typo

2017-02-28 Thread Bart Van Assche
On 02/28/2017 02:23 PM, Joe Perches wrote: > On Tue, 2017-02-28 at 15:35 +0000, Bart Van Assche wrote: >> On Tue, 2017-02-28 at 15:02 +0300, Dan Carpenter wrote: >>> Bitwise & was obviously intended here. > [] >>> diff --git a/include/linux/mlx4/driv

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-18 Thread Bart Van Assche
On 01/18/2017 10:31 AM, Jason Gunthorpe wrote: > I think it depends on what this tool is supposed to cover, but based > on the description, I would start with netlink-only. > > The only place verbs covers a similar ground is in 'device > capabilities' - for some of that you might want to open a ne

Re: [RFC] RESEND - rdmatool - tool for RDMA users

2017-01-19 Thread Bart Van Assche
On Thu, 2017-01-19 at 11:03 -0700, Jason Gunthorpe wrote: > sysfs is unpopular because the 'one value per file' dogma is laregly > unsuitable for complex mulit-value atomic changes which are common in > netdev. You can force it to work, but it is pretty horrible.. > > It is also very expensive if

[PATCH v3 09/37] RDS: IB: Remove an unused structure member

2017-01-20 Thread Bart Van Assche
Signed-off-by: Bart Van Assche Acked-by: Santosh Shilimkar Cc: David S. Miller Cc: linux-r...@vger.kernel.org Cc: netdev@vger.kernel.org Cc: rds-de...@oss.oracle.com --- net/rds/ib_mr.h | 1 - 1 file changed, 1 deletion(-) diff --git a/net/rds/ib_mr.h b/net/rds/ib_mr.h index 1c754f4acbe5

Re: [PATCH] cxgbit: use T6 specific macro to set force bit

2017-01-25 Thread Bart Van Assche
On Tue, 2017-01-24 at 17:07 +0530, Varun Prakash wrote: > For T6 adapters use T6 specific macro to set force bit. Thanks, I have applied this patch. Bart.

Re: [PATCH 4.10-rc3 09/13] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-01-31 Thread Bart Van Assche
rs/target/iscsi/iscsi_target_login.c > +++ b/drivers/target/iscsi/iscsi_target_login.c > @@ -17,6 +17,7 @@ > > **/ > > #include > +#include > #include > #include > #include Reviewed-by: Bart Van Assche

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-11 Thread Bart Van Assche
broken until at least that part is fixed. Since this is the only way to get the BROKEN marker in the v4.11 stable kernel series: Acked-by: Bart Van Assche

Re: [PATCH] net/smc: mark as BROKEN due to remote memory exposure

2017-05-14 Thread Bart Van Assche
On Sun, 2017-05-14 at 11:51 -0400, David Miller wrote: > From: Christoph Hellwig > Date: Sun, 14 May 2017 07:58:48 +0200 > > > this patch has not been superceeded by anything, can you explain why > > it has been marked as such in patchworks? > > I think you're being overbearing by requiring this

Re: net/smc and the RDMA core

2017-05-01 Thread Bart Van Assche
On Mon, 2017-05-01 at 18:33 +0200, Christoph Hellwig wrote: > Hi Ursual, hi netdev reviewers, > > how did the smc protocol manage to get merged without any review > on linux-rdma at all? As the results it seems it's very substandard > in terms of RDMA API usage, e.g. it neither uses the proper C

Re: net/smc and the RDMA core

2017-05-02 Thread Bart Van Assche
On Tue, 2017-05-02 at 14:41 +0200, Ursula Braun wrote: > On 05/01/2017 07:55 PM, Parav Pandit wrote: > > Hi Bart, Ursula, Dave, > > > > I am particularly concerned about SMC as address family. > > It should not be treated as address family, but rather an additional > > protocol similar for socket

Re: net/smc and the RDMA core

2017-05-02 Thread Bart Van Assche
On Tue, 2017-05-02 at 14:25 +0200, Ursula Braun wrote: > if you can point out specific issues, we will be happy to work with you > to get them addressed! Hello Ursula, My list of issues that I would like to see addressed can be found below. Doug, Christoph and others may have additional inputs. T

Re: [RFC iproute2 0/8] RDMA tool

2017-05-04 Thread Bart Van Assche
On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote: > Following our discussion both in mailing list [1] and at the LPC 2016 [2], > we would like to propose this RDMA tool to be part of iproute2 package > and finally improve this situation. Hello Leon, Although I really appreciate your work:

Re: [RFC iproute2 0/8] RDMA tool

2017-05-04 Thread Bart Van Assche
On Thu, 2017-05-04 at 21:25 +0300, Leon Romanovsky wrote: > On Thu, May 04, 2017 at 06:10:54PM +0000, Bart Van Assche wrote: > > On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote: > > > Following our discussion both in mailing list [1] and at the LPC 2016 [2], > > &g

Re: [RFC iproute2 0/8] RDMA tool

2017-05-05 Thread Bart Van Assche
On Thu, 2017-05-04 at 21:45 +0300, Leon Romanovsky wrote: > It is not hard to create new tool, the hardest part is to ensure that it is > part of the distributions. Did you count how many months we are trying to > add rdma-core to debian? Hello Leon, Sorry but I was not aware that the effort to a

Re: [RFC iproute2 0/8] RDMA tool

2017-05-06 Thread Bart Van Assche
On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote: > Thu, May 04, 2017 at 08:10:54PM CEST, bart.vanass...@sandisk.com wrote: > > On Thu, 2017-05-04 at 21:02 +0300, Leon Romanovsky wrote: > > > Following our discussion both in mailing list [1] and at the LPC 2016 [2], > > > we would like to propos

Re: [RFC iproute2 0/8] RDMA tool

2017-05-08 Thread Bart Van Assche
On Sun, 2017-05-07 at 12:20 +0200, Jiri Pirko wrote: > Sat, May 06, 2017 at 04:40:24PM CEST, bart.vanass...@sandisk.com wrote: > > On Sat, 2017-05-06 at 12:40 +0200, Jiri Pirko wrote: > > > Thu, May 04, 2017 at 08:10:54PM CEST, bart.vanass...@sandisk.com wrote: > > > > On Thu, 2017-05-04 at 21:02 +

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 12:22 -0800, Vishwanathapura, Niranjana wrote: > Intel Omni-Path Host Fabric Interface (HFI) Virtual Network Interface > Controller (VNIC) feature supports Ethernet functionality over Omni-Path > fabric by encapsulating the Ethernet packets between HFI nodes. This may have be

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > This is Ethernet - not IP - encapsulation over a non-InfiniBand > device/protocol. That's more than clear from the cover letter. In my opinion the cover letter should explain why it is considered useful to have such a driver upstream and wha

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 16:54 -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 09:58:50PM +0000, Bart Van Assche wrote: > > On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > > > This is Ethernet - not IP - encapsulation over a non-InfiniBand >

Re: [RFC v3 01/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) documentation

2017-02-08 Thread Bart Van Assche
On Tue, 2017-02-07 at 12:23 -0800, Vishwanathapura, Niranjana wrote: > diff --git a/Documentation/infiniband/hfi_vnic.txt > b/Documentation/infiniband/hfi_vnic.txt > new file mode 100644 > index 000..c6c801e > --- /dev/null > +++ b/Documentation/infiniband/hfi_vnic.txt > @@ -0,0 +1,102 @@ > +I

Re: [PATCH net 2/2] lib/dim: Fix -Wunused-const-variable warnings

2019-07-23 Thread Bart Van Assche
On 7/23/19 12:22 AM, Leon Romanovsky wrote: From: Leon Romanovsky DIM causes to the following warnings during kernel compilation which indicates that tx_profile and rx_profile are supposed to be declared in *.c and not in *.h files. Thanks Leon for this fix. Reviewed-by: Bart Van Assche

Re: [PATCH] net/mlx5: Use kasprintf instead of hand-writing it

2021-04-18 Thread Bart Van Assche
On 4/17/21 12:16 AM, Christophe JAILLET wrote: > 'kasprintf()' can replace a kmalloc/strcpy/strcat sequence. > It is less verbose and avoid the use of a magic number (64). > > Anyway, the underlying 'alloc_workqueue()' would only keep the 24 first > chars (i.e. sizeof(struct workqueue_struct->name

Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-18 Thread Bart Van Assche
On 4/18/21 2:26 PM, Christophe JAILLET wrote: > Improve 'create_workqueue', 'create_freezable_workqueue' and > 'create_singlethread_workqueue' so that they accept a format > specifier and a variable number of arguments. > > This will put these macros more in line with 'alloc_ordered_workqueue' and

Re: [PATCH 1/2] workqueue: Have 'alloc_workqueue()' like macros accept a format specifier

2021-04-19 Thread Bart Van Assche
On 4/18/21 11:36 PM, Marion et Christophe JAILLET wrote: > The list in To: is the one given by get_maintainer.pl. Usualy, I only > put the ML in Cc: I've run the script on the 2 patches of the serie > and merged the 2 lists. Everyone is in the To: of the cover letter > and of the 2 patches. > > If

Re: [PATCH mlx5-next v2 1/3] net/mlx5: Expose optimal performance scatter entries capability

2019-10-07 Thread Bart Van Assche
On 10/7/19 6:59 AM, Leon Romanovsky wrote: - u8 reserved_at_c0[0x8]; + u8 max_sgl_for_optimized_performance[0x8]; Should the name of this member variable perhaps be changed into "max_sgl_for_optimal_performance"? Thanks, Bart.

Re: [PATCH rdma-next v2 2/3] RDMA/rw: Support threshold for registration vs scattering to local pages

2019-10-07 Thread Bart Van Assche
On 10/7/19 6:59 AM, Leon Romanovsky wrote: /* - * Check if the device might use memory registration. This is currently only - * true for iWarp devices. In the future we can hopefully fine tune this based - * on HCA driver input. + * Check if the device might use memory registration. This is cu

Re: [PATCH rdma-next v2 2/3] RDMA/rw: Support threshold for registration vs scattering to local pages

2019-10-07 Thread Bart Van Assche
On 10/7/19 6:59 AM, Leon Romanovsky wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 4f671378dbfc..60fd98a9b7e8 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -445,6 +445,8 @@ struct ib_device_attr { struct ib_tm_caps tm_caps;

Re: [PATCH rdma-next v2 2/3] RDMA/rw: Support threshold for registration vs scattering to local pages

2019-10-07 Thread Bart Van Assche
On 10/7/19 9:03 AM, Leon Romanovsky wrote: On Mon, Oct 07, 2019 at 08:07:55AM -0700, Bart Van Assche wrote: On 10/7/19 6:59 AM, Leon Romanovsky wrote: /* - * Check if the device might use memory registration. This is currently only - * true for iWarp devices. In the future we can hopefully

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread Bart Van Assche
On 2020-06-24 20:01, syzbot wrote: > This bug is marked as fixed by commit: > blk-mq: Fix a recently introduced regression in > But I can't find it in any tested tree for more than 90 days. > Is it a correct commit? Please update it by replying: > #syz fix: exact-commit-title > Until then the bug i

[PATCH 0/7] net/core patches for kernel v5.2

2019-03-21 Thread Bart Van Assche
this patch series for kernel v5.2. Thanks, Bart. Bart Van Assche (7): net/core: Document reuseport_add_sock() bind_inany argument net/core: Document all dev_ioctl() arguments net/core: Document __skb_flow_dissect() flags argument net/core: Fix rtnetlink kernel-doc headers net/core: Allow

[PATCH 1/7] net/core: Document reuseport_add_sock() bind_inany argument

2019-03-21 Thread Bart Van Assche
This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'bind_inany' not described in 'reuseport_add_sock' Cc: Martin KaFai Lau Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") #

[PATCH 6/7] net/core: Declare a local function 'static'

2019-03-21 Thread Bart Van Assche
This patch avoids that the compiler complains about a missing prototype when building with W=1. Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Bart Van Assche --- net/core/datagram.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/core/datagram.c b/net/core/datagram.c index

[PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-21 Thread Bart Van Assche
This patch does not change any functionality but makes the code easier to read. Cc: Sagi Grimberg Cc: Christoph Hellwig Signed-off-by: Bart Van Assche --- net/core/utils.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/core/utils.c b/net/core/utils.c index

[PATCH 3/7] net/core: Document __skb_flow_dissect() flags argument

2019-03-21 Thread Bart Van Assche
s") # v4.3. Signed-off-by: Bart Van Assche --- net/core/flow_dissector.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index bb1a54747d64..b4d581134ef2 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissec

[PATCH 5/7] net/core: Allow the compiler to verify declaration and definition consistency

2019-03-21 Thread Bart Van Assche
OCOPY") # v4.14. Cc: Willem de Bruijn Signed-off-by: Bart Van Assche --- net/core/datagram.c | 2 ++ net/core/datagram.h | 15 +++ net/core/skbuff.c | 5 ++--- 3 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 net/core/datagram.h diff --git a/net/core/da

[PATCH 4/7] net/core: Fix rtnetlink kernel-doc headers

2019-03-21 Thread Bart Van Assche
parameter or member 'filter_dev' not described in 'ndo_dflt_fdb_dump' net/core/rtnetlink.c:3861: warning: Function parameter or member 'idx' not described in 'ndo_dflt_fdb_dump' net/core/rtnetlink.c:3861: warning: Excess function parameter 'nlh' d

[PATCH 2/7] net/core: Document all dev_ioctl() arguments

2019-03-21 Thread Bart Van Assche
t described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl' Cc: Al Viro Fixes: 44c02a2c3dc5 ("dev_ioctl(): move copyin/copyout to callers") # v4.16. Signed-off-by: Bart Van Assche --- net/core/dev

Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

2019-03-25 Thread Bart Van Assche
On Fri, 2019-03-22 at 18:46 +, Rustad, Mark D wrote: > This doesn't look right to me. The original code seemingly would stop the > copy before getting to a possible '%' character. The new code only stops at > eol. So this appears to change the functionality and I assume is broken in > any

[PATCH v2 2/5] net/core: Document all dev_ioctl() arguments

2019-03-25 Thread Bart Van Assche
t described in 'dev_ioctl' net/core/dev_ioctl.c:378: warning: Excess function parameter 'arg' description in 'dev_ioctl' Cc: Al Viro Fixes: 44c02a2c3dc5 ("dev_ioctl(): move copyin/copyout to callers") # v4.16. Signed-off-by: Bart Van Assche --- net/core/dev

[PATCH v2 1/5] net/core: Document reuseport_add_sock() bind_inany argument

2019-03-25 Thread Bart Van Assche
This patch avoids that the following warning is reported when building with W=1: warning: Function parameter or member 'bind_inany' not described in 'reuseport_add_sock' Cc: Martin KaFai Lau Fixes: 2dbb9b9e6df6 ("bpf: Introduce BPF_PROG_TYPE_SK_REUSEPORT") #

[PATCH v2 3/5] net/core: Document __skb_flow_dissect() flags argument

2019-03-25 Thread Bart Van Assche
s") # v4.3. Signed-off-by: Bart Van Assche --- net/core/flow_dissector.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index bb1a54747d64..b4d581134ef2 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissec

[PATCH v2 0/5] Fix net/core W=1 warnings

2019-03-25 Thread Bart Van Assche
://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git Bart Van Assche (5): net/core: Document reuseport_add_sock() bind_inany argument net/core: Document all dev_ioctl() arguments net/core: Document __skb_flow_dissect() flags argument net/core: Fix rtnetlink kernel-doc headers net/core

[PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency

2019-03-25 Thread Bart Van Assche
OCOPY") # v4.14. Cc: Willem de Bruijn Signed-off-by: Bart Van Assche --- net/core/datagram.c | 2 ++ net/core/datagram.h | 15 +++ net/core/skbuff.c | 5 ++--- 3 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 net/core/datagram.h diff --git a/net/core/da

[PATCH v2 4/5] net/core: Fix rtnetlink kernel-doc headers

2019-03-25 Thread Bart Van Assche
parameter or member 'filter_dev' not described in 'ndo_dflt_fdb_dump' net/core/rtnetlink.c:3861: warning: Function parameter or member 'idx' not described in 'ndo_dflt_fdb_dump' net/core/rtnetlink.c:3861: warning: Excess function parameter 'nlh' d

Re: [PATCH v2 5/5] net/core: Allow the compiler to verify declaration and definition consistency

2019-03-26 Thread Bart Van Assche
On Mon, 2019-03-25 at 19:26 +0100, Sabrina Dubroca wrote: > 2019-03-25, 09:17:23 -0700, Bart Van Assche wrote: > > diff --git a/net/core/datagram.h b/net/core/datagram.h > > new file mode 100644 > > index ..bcfb75bfa3b2 > > --- /dev/null > > +++ b/net/

[PATCH v3] lib/test_rhashtable: Make test_insert_dup() allocate its hash table dynamically

2019-01-30 Thread Bart Van Assche
: Bart Van Assche --- Changes compared to v2: fixed build error. Changes compared to v1: instead of modifying rhashtable_init(), modify its caller. lib/test_rhashtable.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/test_rhashtable.c b/lib

Re: [PATCH net-next] svcrdma: Fix an uninitialized variable false warning

2019-01-03 Thread Bart Van Assche
On Fri, 2018-12-28 at 10:36 -0500, Chuck Lever wrote: > > On Dec 20, 2018, at 4:49 AM, YueHaibing wrote: > > > > smatch warning this: > > net/sunrpc/xprtrdma/svc_rdma_rw.c:351 svc_rdma_post_chunk_ctxt() error: > > uninitialized symbol 'bad_wr' > > net/sunrpc/xprtrdma/verbs.c:1569 rpcrdma_post_re

Re: [PATCH v3] coding-style: Clarify the expectations around bool

2019-01-07 Thread Bart Van Assche
l type." > > +evaluate to 0 or 1, and implicit or explicit conversion to bool > > automatically > > +converts the value to true or false. When using bool types the !! > > construction > > +is not needed, which eliminates a class of bugs. > > + > > +When working with bool values the true and false labels should be used > > instead > > true and false are not labels but #defines With these refinements, feel free to add: Reviewed-by: Bart Van Assche

[PATCH v2] lib/test_rhashtable: Make test_insert_dup() allocate its hash table dynamically

2019-01-16 Thread Bart Van Assche
: Bart Van Assche --- Changes compared to v1: instead of modifying rhashtable_init(), modify its caller. lib/test_rhashtable.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index 6a8ac7626797

[PATCH] lib/rhashtable: Fix work initialization in rhashtable_init()

2018-12-17 Thread Bart Van Assche
...@vger.kernel.org Signed-off-by: Bart Van Assche --- lib/rhashtable.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 30526afa8343..6c22534c48e4 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -19,6 +19,7 @@ #include #include #include

Re: [PATCH V3] net/mlx4: Get rid of page operation after dma_alloc_coherent

2018-12-20 Thread Bart Van Assche
On Thu, 2018-12-20 at 18:44 +0100, Christoph Hellwig wrote: > On Thu, Dec 20, 2018 at 10:43:18AM -0700, Jason Gunthorpe wrote: > > > - chunk->coherent is an int not a bool since checkpatch complains about > > > using bool in structs; see https://lkml.org/lkml/2017/11/21/384. > > > > :( bool

Re: [PATCH] lib/rhashtable: Fix work initialization in rhashtable_init()

2018-12-20 Thread Bart Van Assche
On Tue, 2018-12-18 at 21:32 -0800, David Miller wrote: > From: Bart Van Assche > Date: Mon, 17 Dec 2018 13:40:58 -0800 > > > The test_insert_dup() function from lib/test_rhashtable.c passes a > > pointer to a stack object to rhltable_init(). Avoid that the following > &

Re: [PATCH rdma-next 01/10] RDMA: Add access flags to ib_alloc_mr() and ib_mr_pool_init()

2021-04-05 Thread Bart Van Assche
On 4/4/21 10:23 PM, Leon Romanovsky wrote: > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index bed4cfe50554..59138174affa 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -2444,10 +2444,10 @@ struct ib_device_ops { >

Re: [PATCH 10/10] compiler: Remove uninitialized_var() macro

2020-06-03 Thread Bart Van Assche
e the variable or make compiler changes. Thank you for having done this work! Reviewed-by: Bart van Assche