OTECTED]>
> Caused-By : ?
> Handled-By : Jens Axboe <[EMAIL PROTECTED]>
> Linus Torvalds <[EMAIL PROTECTED]>
> Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> Patch : http://lkml.org/lkml/2007/7/19/26
> Status
On Friday 27 July 2007, Michal Piotrowski wrote:
> IDE
>
> Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not
> References : http://lkml.org/lkml/2007/7/27/298
> Last known good : ?
> Submitter : dth <[EMAIL PROTECTED]>
> Caused-By : ?
> Handled-By : ?
On Nov 13, 2007 12:15 PM, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Mon, 12 Nov 2007 22:42:32 -0800 "Natalie Protasevich" <[EMAIL PROTECTED]>
> wrote:
>
> > This is the listing of the open bugs that are relatively new, around
> > 2.6.22 and up. They are vaguely classified by specific area.
> >
rs
> will bind with boards, not with functional resources. Avoid this by
> renaming struct nubus_dev as struct nubus_rsrc. "Functional resource"
> is the vendor's terminology so this helps avoid confusion.
>
> Cc: Bartlomiej Zolnierkiewicz
> Tested-by: Stan Johnson
On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote:
> This increases code re-use and improves readability.
>
> Cc: Bartlomiej Zolnierkiewicz
> Signed-off-by: Finn Thain
> Tested-by: Stan Johnson
Acked-by: Bartlomiej Zolnierkiewicz
for fbdev part
> ---
> driv
h Hellwig
Acked-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote:
> On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote:
> > > au1100fb is using managed dma allocations, so it doesn't need t
he routine in the driver
> setting the polling to zero is no longer needed (eg. in the mellanox
> driver). I expect int300 to be the last user of this ops, hopefully we
> can find a way to get rid of the specific call done inside and then
> remove the ops.
>
> The initial_mode approach looks hackish, I suggest to make the default
> the thermal zone disabled after creating and then explicitly enable it.
> Note that is what do a lot of drivers already.
>
> Hopefully, these changes are git-bisect safe.
>
> Does it make sense ?
Besides the requirement to split the patch it seems that the above
list contains a lot of problematic areas with the existing thermal
code yet to be addressed..
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote:
> The acpi_thermal_register_thermal_zone() is missing any error handling.
> This needs to be fixed.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote:
> Prepare for storing mode in struct thermal_zone_device.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsun
methods will become redundant.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> include/linux/thermal.h | 2 ++
> 1 file changed, 2 insertio
On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote:
> Prepare for eliminating get_mode().
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> dri
t tzd.
>
> Signed-off-by: Andrzej Pietrasiewicz
The side-effect of splitting the v3 is that some devices will be
marked in sysfs as disabled (however they are in reality enabled)
after applying this patch (it gets fixed by patch #08).
I think that we can live with that so:
Reviewed-by: B
On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote:
> Prepare for making the drivers not access tzd's private members.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
S
ode ?
> - THERMAL_DEVICE_ENABLED : THERMAL_DEVICE_DISABLED;
> + if (kernelmode)
> + ret = thermal_zone_device_enable(thz_dev);
> + else
> + ret = thermal_zone_device_disable(thz_dev);
> + if (ret)
Cleanup on error seems to be missing here.
> + return ret;
>
> if (strcmp(thz_dev->governor->name,
> acerhdf_zone_params.governor_name)) {
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
t; + thermal_zone_device_unregister(zone);
> + pr_err("Failed to enable thermal zone\n");
> + kfree(tzp);
> + kfree(ops);
> + of_thermal_free_zone(tz);
> + }
> }
> of_node_put(np);
>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/thermal/thermal_core.c | 16 ++--
> 1 file changed, 14 insertions(+), 2
debug messages.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> drivers/acpi/thermal.c| 26
> .../ethe
ode being changed and giving the driver a chance to oppose such
> change.
>
> To better reflect the purpose of the method rename it to change_mode()
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Sams
_zone_device_set_mode().
> - thermal/of-thermal.c: no need to set zone->mode to DISABLED in
> of_parse_thermal_zones() as a tzd is kzalloc'ed so mode is DISABLED anyway
>
> Signed-off-by: Andrzej Pietrasiewicz
> [for acerhdf]
> Acked-by: Peter Kaestle
Reviewed-
On 6/29/20 2:29 PM, Andrzej Pietrasiewicz wrote:
> Some thermal zone devices never change their state, so they should be
> always enabled.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierkiewicz
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D
it is always available. Exposing "mode" doesn't hurt the drivers
> which don't provide their own set_mode(), because writing to "mode" will
> result in -EPERM, as expected.
>
> Signed-off-by: Andrzej Pietrasiewicz
Reviewed-by: Bartlomiej Zolnierk
22 matches
Mail list logo