Re: 2.6.22-git: known regressions with patches

OTECTED]> > Caused-By : ? > Handled-By : Jens Axboe <[EMAIL PROTECTED]> > Linus Torvalds <[EMAIL PROTECTED]> > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> > Patch : http://lkml.org/lkml/2007/7/19/26 > Status

Re: [2/3] 2.6.23-rc1: known regressions v2

On Friday 27 July 2007, Michal Piotrowski wrote: > IDE > > Subject : ide problems: 2.6.22-git17 working, 2.6.23-rc1* is not > References : http://lkml.org/lkml/2007/7/27/298 > Last known good : ? > Submitter : dth <[EMAIL PROTECTED]> > Caused-By : ? > Handled-By : ?

Re: [BUG] New Kernel Bugs

On Nov 13, 2007 12:15 PM, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Mon, 12 Nov 2007 22:42:32 -0800 "Natalie Protasevich" <[EMAIL PROTECTED]> > wrote: > > > This is the listing of the open bugs that are relatively new, around > > 2.6.22 and up. They are vaguely classified by specific area. > >

Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev

rs > will bind with boards, not with functional resources. Avoid this by > renaming struct nubus_dev as struct nubus_rsrc. "Functional resource" > is the vendor's terminology so this helps avoid confusion. > > Cc: Bartlomiej Zolnierkiewicz > Tested-by: Stan Johnson

Re: [PATCH v3 12/14] nubus: Adopt standard linked list implementation

On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote: > This increases code re-use and improves readability. > > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Finn Thain > Tested-by: Stan Johnson Acked-by: Bartlomiej Zolnierkiewicz for fbdev part > --- > driv

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

h Hellwig Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH 03/11] au1100fb: remove a bogus dma_free_nonconsistent call

On Tuesday, June 20, 2017 11:10:45 AM Christoph Hellwig wrote: > On Mon, Jun 19, 2017 at 01:15:04PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On Friday, June 16, 2017 09:17:08 AM Christoph Hellwig wrote: > > > au1100fb is using managed dma allocations, so it doesn't need t

Re: [RFC v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

he routine in the driver > setting the polling to zero is no longer needed (eg. in the mellanox > driver). I expect int300 to be the last user of this ops, hopefully we > can find a way to get rid of the specific call done inside and then > remove the ops. > > The initial_mode approach looks hackish, I suggest to make the default > the thermal zone disabled after creating and then explicitly enable it. > Note that is what do a lot of drivers already. > > Hopefully, these changes are git-bisect safe. > > Does it make sense ? Besides the requirement to split the patch it seems that the above list contains a lot of problematic areas with the existing thermal code yet to be addressed.. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH v4 01/11] acpi: thermal: Fix error handling in the register function

On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote: > The acpi_thermal_register_thermal_zone() is missing any error handling. > This needs to be fixed. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz

Re: [PATCH v4 02/11] thermal: Store thermal mode in a dedicated enum

On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote: > Prepare for storing mode in struct thermal_zone_device. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsun

Re: [PATCH v4 03/11] thermal: Add current mode to thermal zone device

methods will become redundant. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > include/linux/thermal.h | 2 ++ > 1 file changed, 2 insertio

Re: [PATCH v4 04/11] thermal: Store device mode in struct thermal_zone_device

On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote: > Prepare for eliminating get_mode(). > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > dri

Re: [PATCH v4 05/11] thermal: remove get_mode() operation of drivers

t tzd. > > Signed-off-by: Andrzej Pietrasiewicz The side-effect of splitting the v3 is that some devices will be marked in sysfs as disabled (however they are in reality enabled) after applying this patch (it gets fixed by patch #08). I think that we can live with that so: Reviewed-by: B

Re: [PATCH v4 06/11] thermal: Add mode helpers

On 5/28/20 9:20 PM, Andrzej Pietrasiewicz wrote: > Prepare for making the drivers not access tzd's private members. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland S

Re: [PATCH v4 07/11] thermal: Use mode helpers in drivers

ode ? > - THERMAL_DEVICE_ENABLED : THERMAL_DEVICE_DISABLED; > + if (kernelmode) > + ret = thermal_zone_device_enable(thz_dev); > + else > + ret = thermal_zone_device_disable(thz_dev); > + if (ret) Cleanup on error seems to be missing here. > + return ret; > > if (strcmp(thz_dev->governor->name, > acerhdf_zone_params.governor_name)) { Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH v4 08/11] thermal: Explicitly enable non-changing thermal zone devices

t; + thermal_zone_device_unregister(zone); > + pr_err("Failed to enable thermal zone\n"); > + kfree(tzp); > + kfree(ops); > + of_thermal_free_zone(tz); > + } > } > of_node_put(np); > Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [PATCH v4 09/11] thermal: core: Stop polling DISABLED thermal devices

> > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/thermal/thermal_core.c | 16 ++-- > 1 file changed, 14 insertions(+), 2

Re: [PATCH v4 10/11] thermal: Simplify or eliminate unnecessary set_mode() methods

debug messages. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/acpi/thermal.c| 26 > .../ethe

Re: [PATCH v4 11/11] thermal: Rename set_mode() to change_mode()

ode being changed and giving the driver a chance to oppose such > change. > > To better reflect the purpose of the method rename it to change_mode() > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [PATCH v7 07/11] thermal: Use mode helpers in drivers

_zone_device_set_mode(). > - thermal/of-thermal.c: no need to set zone->mode to DISABLED in > of_parse_thermal_zones() as a tzd is kzalloc'ed so mode is DISABLED anyway > > Signed-off-by: Andrzej Pietrasiewicz > [for acerhdf] > Acked-by: Peter Kaestle Reviewed-

Re: [PATCH v7 08/11] thermal: Explicitly enable non-changing thermal zone devices

On 6/29/20 2:29 PM, Andrzej Pietrasiewicz wrote: > Some thermal zone devices never change their state, so they should be > always enabled. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D

Re: [PATCH v3 1/2] thermal: core: Let thermal zone device's mode be stored in its struct

it is always available. Exposing "mode" doesn't hurt the drivers > which don't provide their own set_mode(), because writing to "mode" will > result in -EPERM, as expected. > > Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Bartlomiej Zolnierk