[PATCH v7 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-06-22 Thread Bendik Rønning Opstad
(RFC/PATCH) Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 43 ++ Documentation/networking/tcp-thin.txt | 188 -- include/linux/skbuff.h | 1

[PATCH v7 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-06-22 Thread Bendik Rønning Opstad
etlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 35 + Documentation/networking/tcp-thin.txt | 188 -- include/linu

[PATCH v7 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-06-22 Thread Bendik Rønning Opstad
time (ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/netns/ipv4.h | 1 + includ

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-06-16 Thread Bendik Rønning Opstad
On 21/03/16 19:54, Yuchung Cheng wrote: > On Thu, Mar 17, 2016 at 4:26 PM, Bendik Rønning Opstad > wrote: >> >>>> diff --git a/Documentation/networking/ip-sysctl.txt >>>> b/Documentation/networking/ip-sysctl.txt >>>> index 6a92b15..8f3f3bf 100644 &

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-19 Thread Bendik Rønning Opstad
>> diff --git a/Documentation/networking/ip-sysctl.txt >> b/Documentation/networking/ip-sysctl.txt >> index 6a92b15..8f3f3bf 100644 >> --- a/Documentation/networking/ip-sysctl.txt >> +++ b/Documentation/networking/ip-sysctl.txt >> @@ -716,6 +716,21 @@ tcp_thin_dpifl_itt_lower_bound - INTEGER >>

Re: [PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-19 Thread Bendik Rønning Opstad
On 14/03/16 22:15, Eric Dumazet wrote: > Acked-by: Eric Dumazet > > Note that RDB probably should get some SNMP counters, > so that we get an idea of how many times a loss could be repaired. Good idea. Simply count how many times an RDB packet successfully repaired loss? Note that this can be one

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-18 Thread Bendik Rønning Opstad
On 14/03/16 22:59, Yuchung Cheng wrote: > OK that makes sense. > > I left some detailed comments on the actual patches. I would encourage > to submit an IETF draft to gather feedback from tcpm b/c the feature > seems portable. Thank you for the suggestion, we appreciate the confidence. We have had

Re: [PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-13 Thread Bendik Rønning Opstad
On 03/10/2016 01:20 AM, Yuchung Cheng wrote: > I read the paper. I think the underlying idea is neat. but the > implementation is little heavy-weight that requires changes on fast > path (tcp_write_xmit) and space in skb control blocks. Yuchung, thank you for taking the time to review the patch su

[PATCH v6 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-03-03 Thread Bendik Rønning Opstad
_queue_loss v1 (RFC/PATCH) Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 23 include/linux/skbuff.h | 1 + include/linux/tcp.h| 3 +

[PATCH v6 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-03 Thread Bendik Rønning Opstad
as Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 +++ include/linux/skbuff.h | 1 + include/linux/tcp.h

[PATCH v6 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-03-03 Thread Bendik Rønning Opstad
time (ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/tcp.h

Re: [PATCH v5 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-03-02 Thread Bendik Rønning Opstad
On 03/02/2016 08:52 PM, David Miller wrote: > From: "Bendik Rønning Opstad" > Date: Wed, 24 Feb 2016 22:12:55 +0100 > >> +/* tcp_rdb.c */ >> +void rdb_ack_event(struct sock *sk, u32 flags); > > Please name globally visible symbols with a prefix of "t

[PATCH v5 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-02-24 Thread Bendik Rønning Opstad
as commented by Neal Cardwell. * Cleaned up loss detection code in rdb_check_rtx_queue_loss v1 (RFC/PATCH) Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 23 in

[PATCH v5 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-24 Thread Bendik Rønning Opstad
as Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 +++ include/linux/skbuff.h | 1 + include/linux/tcp.h

[PATCH v5 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-02-24 Thread Bendik Rønning Opstad
time (ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/tcp.h

Re: [PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-19 Thread Bendik Rønning Opstad
On 02/18/2016 04:18 PM, Eric Dumazet wrote: >> >> -static void copy_skb_header(struct sk_buff *new, const struct sk_buff *old) >> +void copy_skb_header(struct sk_buff *new, const struct sk_buff *old) >> { >> __copy_skb_header(new, old); >> >> @@ -1061,6 +1061,7 @@ static void copy_skb_hea

[PATCH v4 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-02-16 Thread Bendik Rønning Opstad
ted by Neal Cardwell. * Cleaned up loss detection code in rdb_check_rtx_queue_loss v1 (RFC/PATCH) Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 23 include/linux/skbuff.h

[PATCH v4 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-16 Thread Bendik Rønning Opstad
ned-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 +++ include/linux/skbuff.h | 1 + include/linux/tcp.h| 3 +- include/net/tcp.h | 15 +++ include/uapi/linux/tcp.h | 1 + net/cor

[PATCH v4 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-02-16 Thread Bendik Rønning Opstad
(ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/tcp.h | 21

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-08 Thread Bendik Rønning Opstad
Eric, thank you for the feedback! On Wed, Feb 3, 2016 at 8:34 PM, Eric Dumazet wrote: > On Wed, 2016-02-03 at 19:17 +0100, Bendik Rønning Opstad wrote: >> On Tue, Feb 2, 2016 at 9:35 PM, Eric Dumazet wrote: >>> Really this looks very complicated. >> >> Can you

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-08 Thread Bendik Rønning Opstad
Sorry guys, I messed up that email by including HTML, and it got rejected by netdev@vger.kernel.org. I'll resend it properly formatted. Bendik On 08/02/16 18:17, Bendik Rønning Opstad wrote: > Eric, thank you for the feedback! > > On Wed, Feb 3, 2016 at 8:34 PM, Eric Dumazet wr

Re: [PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-03 Thread Bendik Rønning Opstad
On Tue, Feb 2, 2016 at 9:35 PM, Eric Dumazet wrote: > On Tue, 2016-02-02 at 20:23 +0100, Bendik Rønning Opstad wrote: >> >> o When packets are scheduled for transmission, RDB replaces the SKB to >> be sent with a modified SKB containing the redundant data of >&g

[PATCH v3 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2016-02-02 Thread Bendik Rønning Opstad
ned-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 ++ include/linux/skbuff.h | 1 + include/linux/tcp.h| 3 +- include/net/tcp.h | 14 ++ include/uapi/linux/tcp.h | 1 + net/cor

[PATCH v3 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2016-02-02 Thread Bendik Rønning Opstad
ted by Neal Cardwell. * Cleaned up loss detection code in rdb_check_rtx_queue_loss v1 (RFC/PATCH) Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 23 +++ include/linux/skbuff.h

[PATCH v3 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2016-02-02 Thread Bendik Rønning Opstad
(ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/tcp.h | 21

Re: [PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-23 Thread Bendik Rønning Opstad
On 23/11/15 18:43, Eric Dumazet wrote: > On Mon, 2015-11-23 at 17:26 +0100, Bendik Rønning Opstad wrote: > >> > + >> > +tcp_rdb_max_skbs - INTEGER >> > + Enable restriction on how many previous SKBs in the output queue >> > + RDB may include data fr

[PATCH RFC v2 net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2015-11-23 Thread Bendik Rønning Opstad
(ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/net/tcp.h | 21

[PATCH RFC v2 net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-23 Thread Bendik Rønning Opstad
ned-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 ++ include/linux/skbuff.h | 1 + include/linux/tcp.h| 3 +- include/net/tcp.h | 14 ++ include/uapi/linux/tcp.h | 1 + net/cor

[PATCH RFC v2 net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-11-23 Thread Bendik Rønning Opstad
nonagle in do_tcp_setsockopt (TCP_RDB) to reduce complexity as commented by Neal Cardwell. * Cleaned up loss detection code in rdb_check_rtx_queue_loss Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-

Re: [PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-11-09 Thread Bendik Rønning Opstad
On 24/10/15 14:57, Eric Dumazet wrote: > Thank you for this very high quality patch submission. > > Please give us a few days for proper evaluation. > > Thanks ! Guys, thank you very much for taking the time to evaluate this. Since there haven't been any more feedback or comments I'll submit an R

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-11-04 Thread Bendik Rønning Opstad
On Monday, November 02, 2015 09:37:54 AM David Laight wrote: > From: Bendik Rønning Opstad > > Sent: 23 October 2015 21:50 > > RDB is a mechanism that enables a TCP sender to bundle redundant > > (already sent) data with TCP packets containing new data. By bundling > &g

Re: [PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-29 Thread Bendik Rønning Opstad
On Monday, October 26, 2015 02:58:03 PM Yuchung Cheng wrote: > On Mon, Oct 26, 2015 at 2:35 PM, Andreas Petlund wrote: > > > On 26 Oct 2015, at 15:50, Neal Cardwell wrote: > > > > > > On Fri, Oct 23, 2015 at 4:50 PM, Bendik Rønning Opstad > > > &

Re: [PATCH RFC net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2015-10-24 Thread Bendik Rønning Opstad
On Friday, October 23, 2015 02:44:14 PM Eric Dumazet wrote: > On Fri, 2015-10-23 at 22:50 +0200, Bendik Rønning Opstad wrote: > > > > > +/** > > + * tcp_stream_is_thin_dpifl() - Tests if the stream is thin based on > > dynamic PIF > > + *

[PATCH RFC net-next 2/2] tcp: Add Redundant Data Bundling (RDB)

2015-10-23 Thread Bendik Rønning Opstad
ned-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 15 ++ include/linux/skbuff.h | 1 + include/linux/tcp.h| 3 +- include/net/tcp.h | 14 ++ include/uapi/linux/tcp.h | 1 + net/cor

[PATCH RFC net-next 0/2] tcp: Redundant Data Bundling (RDB)

2015-10-23 Thread Bendik Rønning Opstad
tad.pdf [2] http://home.ifi.uio.no/bendiko/rdb_fairness_tradeoff.pdf Bendik Rønning Opstad (2): tcp: Add DPIFL thin stream detection mechanism tcp: Add Redundant Data Bundling (RDB) Documentation/networking/ip-sysctl.txt | 23 +++ include/linux/skbuff.h | 1 + include/l

[PATCH RFC net-next 1/2] tcp: Add DPIFL thin stream detection mechanism

2015-10-23 Thread Bendik Rønning Opstad
(ITT). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Pål Halvorsen Cc: Jonas Markussen Cc: Kristian Evensen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- Documentation/networking/ip-sysctl.txt | 8 include/linux/tcp.h| 6 ++ include/net

[PATCH v2 net-next] tcp: Fix CWV being too strict on thin streams

2015-09-23 Thread Bendik Rønning Opstad
that a connection is considered CWND limited whenever the CWND has been filled. This is the correct behavior as specified in RFC2861 (section 3.1). Cc: Andreas Petlund Cc: Carsten Griwodz Cc: Jonas Markussen Cc: Kenneth Klette Jonassen Cc: Mads Johannessen Signed-off-by: Bendik Rønning Opstad

Re: [PATCH net-next] tcp: Fix CWV being too strict on thin streams

2015-09-23 Thread Bendik Rønning Opstad
Neal, Eric, sorry for the late replies, but keeping up with your speedy replies is a full time job :-) The packetdrill scripts are certainly useful to test this, so thanks for supplying those! On Tuesday, September 22, 2015 04:04:37 PM you wrote: > On Tue, Sep 22, 2015 at 2:02 PM, Neal Cardwell

Re: [PATCH net-next] tcp: Fix CWV being too strict on thin streams

2015-09-22 Thread Bendik Rønning Opstad
> Thanks for this report! Thank you for answering! > When you say "CWND is reduced due to loss", are you talking about RTO > or Fast Recovery? Do you have any traces you can share that illustrate > this issue? The problem is not related to loss recovery, but only occurs in congestion avoidance s

[PATCH net-next] tcp: Fix CWV being too strict on thin streams

2015-09-18 Thread Bendik Rønning Opstad
iwodz Cc: Jonas Markussen Cc: Kenneth Klette Jonassen Signed-off-by: Bendik Rønning Opstad --- net/ipv4/tcp_output.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c index d0ad355..7096b8b 100644 --- a/net/ipv4/tcp_output.c +++ b/net/ipv4/tcp